fix(ai-chat): bound MCP connect + guard turn setup so a hung handshake can't wedge every run

A transient network blip during an external-MCP handshake left createMCPClient
pending forever (@ai-sdk/mcp does not settle on abort). getOrBuildEntry caches the
per-workspace build PROMISE, so the never-settling connect poisoned the cache and
every later turn hung at step_count=0 before streamText — the run never finalized,
the row stayed 'running', and the chat was permanently blocked with
A_RUN_ALREADY_ACTIVE (an explicit Stop could not interrupt the un-signalled setup).

- mcp-clients: wrap connect() in a settling timeout (connectWithTimeout) that
  closes a late-arriving client, so a hung handshake rejects instead of poisoning
  the build cache; the bad server is skipped and the build completes.
- mcp-clients: close a connected-but-unregistered client when tools() fails,
  fixing a pre-existing transport leak in buildEntry.
- ai-chat.service: bound the toolsFor build with the run's abort signal AND a
  deadline (raceAgainstAbortAndTimeout); re-throw an explicit Stop only when a run
  exists (runId) so the run finalizes as 'aborted', and keep the legacy
  socket-bound path unchanged; settle the run 'aborted' vs 'error' accordingly.
- tests: cache-not-poisoned + orphan-client-close-once + Stop-during-setup
  finalizes the run once.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

.env.example

@@ -209,6 +209,32 @@ MCP_DOCMOST_PASSWORD=
 # active" behavior.
 # AI_CHAT_DEFERRED_TOOLS=true
 
+# --- Autonomous / detached agent runs (settings.ai.autonomousRuns) ---
+# Opt-in per workspace (AI settings; off by default). When on, a chat turn becomes
+# a server-side RUN that survives a browser disconnect — only an explicit Stop ends
+# it, and a client reconnects/live-follows the run.
+#
+# DEPLOY CONSTRAINT — SINGLE-INSTANCE ONLY in phase 1: Stop and the in-process
+# AbortController that backs it are process-local, so a Stop only aborts a run
+# executing on the SAME replica that owns it (cross-instance pub/sub stop is phase
+# 2 and not yet reliable). Do NOT enable autonomousRuns on a horizontally-scaled
+# deployment (multiple replicas behind a load balancer, or Docmost cloud
+# CLOUD=true) — run a single instance instead. The server logs a startup WARNING
+# when it detects a multi-instance deployment (CLOUD=true) so the constraint is
+# visible, and a startup sweep settles any run left dangling by a restart.
+#
+# Resumable run streams (#184 phase 1.5, #381). With the flag ON, an active
+# durable run tees its SSE frames into an in-memory registry, and a
+# reloaded/second tab attaches via GET /ai-chat/runs/:chatId/stream to follow the
+# run LIVE (replay of the buffered frames + the live tail). With the flag OFF
+# (default) the registry is never populated and attach always answers 204, so a
+# reopened tab of an active run silently falls back to degraded 2.5s history
+# polling — every wire path stays byte-for-byte identical to a build without the
+# feature. Staged-rollout switch: only meaningful when autonomousRuns (above) is
+# enabled for a workspace, and the same single-instance constraint applies (the
+# registry is process-local).
+# AI_CHAT_RESUMABLE_STREAM=false
+
 # --- Anonymous public-share AI assistant ---
 # Opt-in per workspace (AI settings -> "public share assistant"; off by default).
 # When enabled, anonymous visitors of a published share can ask an AI about that
@@ -243,44 +269,26 @@ MCP_DOCMOST_PASSWORD=
 # per rolling day).
 # SHARE_AI_WORKSPACE_TOKEN_BUDGET_PER_DAY=1000000
 
-# --- GIT-SYNC (native two-way Docmost <-> git Markdown sync) ---
-# Master switch. Off by default. When 'true', GIT_SYNC_SERVICE_USER_ID below is
-# REQUIRED (the service account that git-originated create/move/rename/delete are
-# attributed to) — the server refuses to boot with sync enabled and no user id.
-# GIT_SYNC_ENABLED=false
+# --- Observability / perf metrics (#355) ---
 #
-# Serve the per-space vaults over smart-HTTP (the /git host). Defaults to
-# GIT_SYNC_ENABLED when unset.
-# GIT_SYNC_HTTP_ENABLED=false
+# Two INDEPENDENT toggles, both OFF by default:
 #
-# REQUIRED when GIT_SYNC_ENABLED=true: id of the user that git-originated page
-# operations (create / move / rename / delete) are attributed to.
-# GIT_SYNC_SERVICE_USER_ID=
-#
-# Where the per-space working vaults live (non-bare repos; the engine needs a
-# working tree).
-# Defaults to "<DATA_DIR or ./data>/git-sync".
-# GIT_SYNC_DATA_DIR=
-#
-# SCAFFOLDING for the DEFERRED remote-push feature (SPEC §7) — NOT yet
-# implemented and currently INERT. The vendored sync engine does not consume
-# this value anywhere (git push to a remote is deferred), so setting it has NO
-# effect today: vaults remain local-only regardless. It is validated and carried
-# only so the wiring is ready for when remote push lands. The intended future
-# shape is a per-space URL template where the literal "{spaceId}" is substituted
-# per space (e.g. git@host:vault-{spaceId}.git).
-# GIT_SYNC_REMOTE_TEMPLATE=
-#
-# Poll-safety interval in ms — the cadence of the background reconcile cycle
-# (default: 15000).
-# GIT_SYNC_POLL_INTERVAL_MS=15000
-#
-# Debounce window in ms for collapsing bursts of page edits into one sync cycle
-# (default: 2000).
-# GIT_SYNC_DEBOUNCE_MS=2000
-#
-# Watchdog timeout in ms for the spawned `git http-backend` process serving a
-# git smart-HTTP push (default: 120000). A stalled/hung receive-pack is killed
-# after this deadline so it cannot hold the per-space lock forever.
-# GIT_SYNC_BACKEND_TIMEOUT_MS=120000
+# 1) METRICS_PORT — the server-side Prometheus scrape endpoint.
+#    UNSET (default) => the whole prom subsystem is OFF: no registry, no
+#    collectors, and NOTHING is exposed on the main app port. There is NO
+#    default port — leaving it blank disables it. When set to a port (e.g.
+#    9464), a SEPARATE bare node:http listener serves GET /metrics on that port
+#    only (never on the main :3000 app listener), for a scraper such as
+#    VictoriaMetrics/Prometheus reaching it as <host>:<port>/metrics.
+# METRICS_PORT=9464
 #
+# 2) CLIENT_TELEMETRY_ENABLED — the public client perf-telemetry sink.
+#    OFF by default. When true, the unauthenticated POST /api/telemetry/vitals
+#    endpoint is registered and browsers collect + send web-vitals / editor
+#    metrics into the `client_metrics` table (read directly by Grafana, separate
+#    from METRICS_PORT). Leave OFF unless you actually consume this data: the
+#    endpoint is public and the table has NO app-side retention, so enabling it
+#    requires an EXTERNAL pruner to bound `client_metrics` growth (the deployed
+#    infra prunes rows >90d via a maintenance container). When off, the endpoint
+#    does not exist and the client installs no observers.
+# CLIENT_TELEMETRY_ENABLED=false

.github/workflows/develop.yml

@@ -18,12 +18,48 @@ env:
   IMAGE: ghcr.io/vvzvlad/gitmost
 
 jobs:
-  # Run the reusable test suite first so a failing test blocks the image build.
+  # Run the reusable test suite. Together with the e2e jobs below it gates the
+  # publish job (the image push), not the build itself — build runs in parallel.
   test:
     uses: ./.github/workflows/test.yml
 
+  # Runs in parallel with the test/e2e jobs and only warms the buildx cache
+  # (GHA cache, scope develop-amd64). No push happens here — the publish job
+  # below is the only one that pushes the image.
   build:
-    needs: test
+    runs-on: ubuntu-latest
+    timeout-minutes: 30
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+
+      - name: Resolve version
+        id: version
+        run: echo "value=$(git describe --tags --always)" >> "$GITHUB_OUTPUT"
+
+      - name: Build develop image (warm cache, no push)
+        uses: docker/build-push-action@v6
+        with:
+          context: .
+          platforms: linux/amd64
+          build-args: |
+            APP_VERSION=${{ steps.version.outputs.value }}
+            AI_AGENT_ROLES_CATALOG_URL=https://raw.githubusercontent.com/vvzvlad/gitmost/develop/agent-roles-catalog
+          push: false
+          cache-from: type=gha,scope=develop-amd64
+          cache-to: type=gha,scope=develop-amd64,mode=max,ignore-error=true
+
+  # The gate: rebuilds from the cache the build job just wrote (near-instant on
+  # a cache hit; worst case — cache eviction — a full rebuild, which matches the
+  # old sequential timing) and pushes :develop only when unit tests AND both
+  # e2e suites AND the build are green.
+  publish:
+    needs: [test, e2e-server, e2e-mcp, build]
     runs-on: ubuntu-latest
     timeout-minutes: 30
     steps:
@@ -57,13 +93,10 @@ jobs:
           push: true
           tags: ${{ env.IMAGE }}:develop
           cache-from: type=gha,scope=develop-amd64
-          cache-to: type=gha,scope=develop-amd64,mode=max,ignore-error=true
 
-  # e2e jobs run on every develop push but DO NOT gate the build/publish above:
-  # `build` stays `needs: test` only, so the :develop image still ships even if
-  # e2e fails. A failing e2e job turns the run red and triggers GitHub's email
-  # to the pusher — that red run + email is the intended notification, not a
-  # deploy block.
+  # e2e jobs gate the publish (image push), not the build: the :develop image
+  # is pushed only when unit tests AND both e2e suites pass (publish.needs
+  # lists them all).
   e2e-server:
     runs-on: ubuntu-latest
     # Hard cap: the full-AppModule e2e leaks open handles and hung jest to the 6h max.
@@ -118,15 +151,19 @@ jobs:
       - name: Build editor-ext
         run: pnpm --filter @docmost/editor-ext build
 
+      # @docmost/prosemirror-markdown is an ESM workspace package the server
+      # imports at runtime; its build/ is gitignored and test:e2e has no pretest
+      # hook, so build it before the e2e run (mirrors the test.yml job).
+      - name: Build prosemirror-markdown
+        run: pnpm --filter @docmost/prosemirror-markdown build
+
       - name: Run migrations
         run: pnpm --filter ./apps/server migration:latest
 
       - name: Run server e2e
         run: pnpm --filter ./apps/server test:e2e
 
-  # Same rationale as e2e-server: this job is intentionally NOT in
-  # `build.needs`. Deploy of the :develop image must not be blocked by e2e;
-  # a red run plus GitHub's email to the pusher is the notification mechanism.
+  # Gates the publish too — see the comment above e2e-server.
   e2e-mcp:
     runs-on: ubuntu-latest
     timeout-minutes: 20

.github/workflows/nightly-property.yml

@@ -0,0 +1,224 @@
+name: Nightly property fuzz
+
+# The daily heavy property run for the ProseMirror<->Markdown converter
+# (packages/prosemirror-markdown). The PR/CI test run keeps NUM_RUNS modest to
+# stay under budget; this cron cranks up total coverage with random seeds to hunt
+# for deeper round-trip counterexamples than a fixed-seed PR run can reach.
+#
+# WHY SHARDING: a single mega-run (~10000 fast-check runs) OOMs the vitest worker
+# (empirically ~1625 runs -> "JS heap out of memory", ~2GB) because heap
+# accumulates across the whole property run in one process. Instead this job runs
+# SHARDS fresh vitest processes, each a MODERATE per-shard count with a DISTINCT
+# derived seed, so total coverage ~= SHARDS x PER_SHARD_NUM_RUNS across processes
+# that never accumulate heap. On the first failing shard we stop and keep that
+# shard's output for triage.
+#
+# Counterexample -> fixture workflow: when a shard fails, fast-check prints the
+# SHRUNK minimal counterexample plus the reproducing seed. This job files a Gitea
+# issue containing that seed + counterexample ONLY when the output actually holds
+# a fast-check counterexample; an infra failure (OOM/tsc/install, no
+# counterexample) is filed under a DISTINCT title so it can never poison the
+# counterexample dedup. A human then commits the shrunk doc as a PERMANENT fixture
+# under packages/prosemirror-markdown/test/fixtures/counterexamples/ with a case in
+# counterexamples.test.ts, and FIXES the converter (never weakens a property to
+# hide the bug). See packages/prosemirror-markdown/README.md.
+
+on:
+  schedule:
+    # 03:00 UTC daily.
+    - cron: '0 3 * * *'
+  workflow_dispatch:
+    inputs:
+      num_runs:
+        description: 'fast-check runs PER SHARD (8 shards run in sequence)'
+        required: false
+        default: '600'
+      seed:
+        description: 'base fast-check seed (empty = random); shard i uses base+i'
+        required: false
+        default: ''
+
+permissions:
+  contents: read
+  issues: write
+
+jobs:
+  property-fuzz:
+    runs-on: ubuntu-latest
+    timeout-minutes: 60
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Set up pnpm
+        uses: pnpm/action-setup@v4
+
+      - name: Set up Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: pnpm
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      # No build step: the generative suite imports the converter from src/
+      # directly (e.g. `from '../../src/lib/markdown-converter.js'`), so it runs
+      # against source without the package's build/. Skipping the build also
+      # keeps a tsc build error from masquerading as a property-test failure and
+      # filing a bogus counterexample issue.
+      - name: Resolve base seed and per-shard run count
+        id: params
+        # Dispatch inputs are read via env (NOT interpolated into the shell body)
+        # to avoid script injection through a crafted input value.
+        env:
+          SEED_INPUT: ${{ inputs.seed }}
+          NUM_RUNS_INPUT: ${{ inputs.num_runs }}
+        run: |
+          set -euo pipefail
+          SEED="${SEED_INPUT:-}"
+          # Empty seed (cron, or a dispatch that left it blank) -> random. Combine
+          # two RANDOMs so the seed spans more than RANDOM's 0..32767 range.
+          [ -z "$SEED" ] && SEED=$(( (RANDOM << 15) | RANDOM ))
+          NUM_RUNS="${NUM_RUNS_INPUT:-}"
+          [ -z "$NUM_RUNS" ] && NUM_RUNS=600
+          echo "seed=$SEED" >> "$GITHUB_OUTPUT"
+          echo "num_runs=$NUM_RUNS" >> "$GITHUB_OUTPUT"
+          echo "Sharded property fuzz: BASE_SEED=$SEED PER_SHARD_NUM_RUNS=$NUM_RUNS SHARDS=8"
+
+      - name: Run generative property suite (sharded)
+        id: fuzz
+        env:
+          BASE_SEED: ${{ steps.params.outputs.seed }}
+          PER_SHARD_NUM_RUNS: ${{ steps.params.outputs.num_runs }}
+          SHARDS: '8'
+        run: |
+          set -uo pipefail
+          # Give each fresh process headroom, but rely on SHARDING (not a big heap)
+          # to avoid OOM: a moderate per-shard count in a process that starts clean.
+          export NODE_OPTIONS=--max-old-space-size=4096
+          : > property-output.txt
+          FAILED=0
+          FAIL_SEED=""
+          i=0
+          while [ "$i" -lt "$SHARDS" ]; do
+            SHARD_SEED=$(( BASE_SEED + i ))
+            echo "=== shard $((i + 1))/$SHARDS: PROPERTY_SEED=$SHARD_SEED PROPERTY_NUM_RUNS=$PER_SHARD_NUM_RUNS ==="
+            # tee OVERWRITES property-output.txt each shard; since we break on the
+            # first failure, the file ends up holding exactly the failing shard's
+            # output (which carries the shrunk counterexample + reproducing seed).
+            if PROPERTY_SEED="$SHARD_SEED" PROPERTY_NUM_RUNS="$PER_SHARD_NUM_RUNS" \
+                pnpm --filter @docmost/prosemirror-markdown exec \
+                  vitest run test/generative/ 2>&1 | tee property-output.txt; then
+              echo "shard $((i + 1)) passed"
+            else
+              echo "shard $((i + 1)) FAILED (seed=$SHARD_SEED) — stopping; keeping its output"
+              FAILED=1
+              FAIL_SEED="$SHARD_SEED"
+              break
+            fi
+            i=$(( i + 1 ))
+          done
+          echo "failed=$FAILED" >> "$GITHUB_OUTPUT"
+          echo "fail_seed=$FAIL_SEED" >> "$GITHUB_OUTPUT"
+          exit "$FAILED"
+
+      # A GENUINE counterexample: fast-check printed a shrunk minimal case and its
+      # reproducing seed into property-output.txt. File a dedup-guarded issue whose
+      # title prefix is UNIQUE to counterexamples, so an infra failure (handled by
+      # the next step under a different title) can never poison this dedup.
+      - name: File counterexample issue
+        # always() is REQUIRED: the fuzz step exits nonzero on a failing shard,
+        # so a bare `if:` (implicitly success() && ...) would skip this step
+        # exactly when it must run. always() lets it run on the failure path.
+        if: always() && steps.fuzz.outputs.failed == '1'
+        env:
+          FAIL_SEED: ${{ steps.fuzz.outputs.fail_seed }}
+          NUM_RUNS: ${{ steps.params.outputs.num_runs }}
+          RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          TITLE_PREFIX: 'Nightly property counterexample'
+        run: |
+          set -uo pipefail
+          # Discriminate counterexample vs infra failure by the fast-check
+          # signature. No signature -> leave it to the infra-failure step.
+          if ! grep -Eq 'Property failed after|Counterexample' property-output.txt; then
+            echo "No fast-check counterexample signature — infra failure, handled by the next step."
+            exit 0
+          fi
+          TITLE="${TITLE_PREFIX} (seed=${FAIL_SEED})"
+
+          # Best-effort dedup: skip if an open issue with the counterexample title
+          # prefix already exists. A failure of this check must NOT block creation.
+          EXISTING=""
+          if EXISTING=$(curl -sS \
+              -H "Authorization: token ${GITHUB_TOKEN}" \
+              "${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/issues?state=open&limit=100"); then
+            if printf '%s' "$EXISTING" \
+                | node -e 'let s="";process.stdin.on("data",d=>s+=d).on("end",()=>{let a;try{a=JSON.parse(s)}catch{process.exit(1)}if(!Array.isArray(a))process.exit(1);const p=process.env.TITLE_PREFIX;process.exit(a.some(i=>typeof i.title==="string"&&i.title.startsWith(p))?0:1)})'; then
+              echo "An open '${TITLE_PREFIX}' issue already exists — skipping creation."
+              exit 0
+            fi
+          fi
+
+          # Build the JSON body with the test output SAFELY escaped (never hand-
+          # interpolate the counterexample into JSON).
+          BODY_TEXT=$(printf 'A nightly property fuzz SHARD failed with a fast-check counterexample.\n\n- failing shard seed: `%s`\n- NUM_RUNS (per shard): `%s`\n- run: %s\n\nReproduce locally:\n\n```\nPROPERTY_SEED=%s PROPERTY_NUM_RUNS=%s pnpm --filter @docmost/prosemirror-markdown exec vitest run test/generative/\n```\n\nfast-check shrinks the failure to a minimal counterexample. Commit it as a permanent fixture under `packages/prosemirror-markdown/test/fixtures/counterexamples/` + a case in `counterexamples.test.ts`, then FIX the converter (do not weaken a property). See `packages/prosemirror-markdown/README.md`.\n\nTail of the test output (contains the shrunk counterexample):\n\n```\n%s\n```\n' \
+            "$FAIL_SEED" "$NUM_RUNS" "$RUN_URL" "$FAIL_SEED" "$NUM_RUNS" "$(tail -n 120 property-output.txt)")
+
+          jq -n --arg title "$TITLE" --arg body "$BODY_TEXT" \
+            '{title: $title, body: $body}' > payload.json
+
+          curl -sS -X POST \
+            "${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/issues" \
+            -H "Authorization: token ${GITHUB_TOKEN}" \
+            -H 'Content-Type: application/json' \
+            -d @payload.json
+
+      # An INFRA failure (OOM, tsc, install) has NO counterexample signature. File
+      # it under a DISTINCT title so it is visible but keeps the counterexample
+      # dedup (above) uncontaminated — a real counterexample can still file even
+      # while an infra issue is open.
+      - name: File infra failure issue
+        # always() is REQUIRED: the fuzz step exits nonzero on a failing shard,
+        # so a bare `if:` (implicitly success() && ...) would skip this step
+        # exactly when it must run. always() lets it run on the failure path.
+        if: always() && steps.fuzz.outputs.failed == '1'
+        env:
+          FAIL_SEED: ${{ steps.fuzz.outputs.fail_seed }}
+          NUM_RUNS: ${{ steps.params.outputs.num_runs }}
+          RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          TITLE_PREFIX: 'Nightly property run infra failure'
+        run: |
+          set -uo pipefail
+          # Only file when there is NO counterexample signature (else the
+          # counterexample step owns it).
+          if grep -Eq 'Property failed after|Counterexample' property-output.txt; then
+            echo "Counterexample present — owned by the counterexample step."
+            exit 0
+          fi
+          TITLE="${TITLE_PREFIX} (seed=${FAIL_SEED})"
+
+          EXISTING=""
+          if EXISTING=$(curl -sS \
+              -H "Authorization: token ${GITHUB_TOKEN}" \
+              "${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/issues?state=open&limit=100"); then
+            if printf '%s' "$EXISTING" \
+                | node -e 'let s="";process.stdin.on("data",d=>s+=d).on("end",()=>{let a;try{a=JSON.parse(s)}catch{process.exit(1)}if(!Array.isArray(a))process.exit(1);const p=process.env.TITLE_PREFIX;process.exit(a.some(i=>typeof i.title==="string"&&i.title.startsWith(p))?0:1)})'; then
+              echo "An open '${TITLE_PREFIX}' issue already exists — skipping creation."
+              exit 0
+            fi
+          fi
+
+          BODY_TEXT=$(printf 'A nightly property fuzz SHARD failed WITHOUT a fast-check counterexample (infra failure: OOM / build / install). This is NOT a converter round-trip bug.\n\n- failing shard seed: `%s`\n- NUM_RUNS (per shard): `%s`\n- run: %s\n\nInvestigate the run log (memory, dependency install, or a tsc/import error). The nightly counterexample dedup is intentionally separate from this issue.\n\nTail of the test output:\n\n```\n%s\n```\n' \
+            "$FAIL_SEED" "$NUM_RUNS" "$RUN_URL" "$(tail -n 120 property-output.txt)")
+
+          jq -n --arg title "$TITLE" --arg body "$BODY_TEXT" \
+            '{title: $title, body: $body}' > payload.json
+
+          curl -sS -X POST \
+            "${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/issues" \
+            -H "Authorization: token ${GITHUB_TOKEN}" \
+            -H 'Content-Type: application/json' \
+            -d @payload.json

.github/workflows/test.yml

@@ -13,6 +13,49 @@ permissions:
   contents: read
 
 jobs:
+  # Guard against a long-lived branch adding a migration whose timestamped
+  # filename sorts BEFORE migrations already applied on the target branch (and
+  # thus in prod). The Kysely startup migrator rejects that as "corrupted
+  # migrations" and crash-loops the app on boot (incident #361). This gate fails
+  # the PR so the migration is renamed to a current timestamp before merge. Only
+  # runs for pull_request events (needs a base branch to diff against).
+  migration-order:
+    if: github.event_name == 'pull_request'
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    steps:
+      - name: Checkout (full history for the base-branch diff)
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Added migrations must sort after the newest on the base branch
+        env:
+          TARGET_BRANCH: ${{ github.base_ref }}
+        run: |
+          set -euo pipefail
+          MIG_DIR="apps/server/src/database/migrations"
+          # checkout above already did fetch-depth:0 (full history). Fetch the base
+          # WITHOUT --depth (a shallow graft would truncate the base history and
+          # break the merge-base when the base has moved ahead of the PR merge —
+          # exactly the long-branch-vs-moving-base case this gate guards, #361).
+          git fetch --no-tags origin "$TARGET_BRANCH"
+          newest_on_target=$(git ls-tree -r --name-only "origin/${TARGET_BRANCH}" "$MIG_DIR" | sort | tail -1)
+          # NO `|| true`: a diff failure (e.g. an unresolved merge-base) must fail
+          # the job CLOSED — a gate whose job is to BLOCK must never pass on error.
+          # `set -e` above already aborts on a non-zero diff exit.
+          added=$(git diff --diff-filter=A --name-only "origin/${TARGET_BRANCH}...HEAD" -- "$MIG_DIR")
+          bad=0
+          for f in $added; do
+            if [[ "$f" < "$newest_on_target" || "$f" == "$newest_on_target" ]]; then
+              echo "::error::Migration $f sorts at or before the newest on ${TARGET_BRANCH} ($newest_on_target) — rename it with a CURRENT timestamp before merge (do not change its contents). See incident #361."
+              bad=1
+            fi
+          done
+          if [ "$bad" -eq 0 ]; then
+            echo "Migration order OK (added migrations all sort after $newest_on_target)."
+          fi
+          exit $bad
+
   test:
     runs-on: ubuntu-latest
     timeout-minutes: 20
@@ -76,18 +119,10 @@ jobs:
       # build/ is gitignored, and plain `pnpm -r test` does NOT honour nx
       # `dependsOn: ^build`, so its consumers (mcp `pretest: tsc`, git-sync vitest
       # typecheck) fail with TS2307 Cannot find module '@docmost/prosemirror-markdown'
-      # unless it is built first. Build it BEFORE git-sync/mcp (which import it).
+      # unless it is built first. Build it before the recursive test run.
       - name: Build prosemirror-markdown
         run: pnpm --filter @docmost/prosemirror-markdown build
 
-      # git-sync and mcp are no longer committed in built form (build/ is
-      # gitignored), so CI must compile them: the server resolves both via their
-      # built build/index.js (git-sync's runtime consumer lands on this branch,
-      # #119). The server pretest also builds them, but building here keeps it
-      # explicit and independent of pnpm lifecycle ordering.
-      - name: Build git-sync and mcp
-        run: pnpm --filter @docmost/git-sync build && pnpm --filter @docmost/mcp build
-
       - name: Run unit tests
         run: pnpm -r test
 

.gitignore

@@ -4,16 +4,19 @@
 data
 # compiled output
 /dist
-/node_modules
-# workspace package node_modules (pnpm symlinks — never commit; they bake
-# machine-local store paths).
-packages/*/node_modules/
+node_modules
 
-# Compiled package output: build/ is gitignored for every workspace package
-# (built in CI/Docker via `pnpm build`, never committed, so src/ and prod can
-# never silently diverge). Private packages are rebuilt at deploy.
+# git-sync compiled output (built in CI/Docker via `pnpm build`, never committed,
+# so src/ and prod can never silently diverge).
 packages/git-sync/build/
+
+# prosemirror-markdown compiled output (built in CI/Docker via `pnpm build`,
+# never committed, so src/ and prod can never silently diverge).
 packages/prosemirror-markdown/build/
+
+# mcp compiled output (built in CI/Docker via `pnpm build`, never committed, so
+# src/ and prod can never silently diverge). Matches the git-sync/prosemirror-
+# markdown convention; the package is private and rebuilt at deploy.
 packages/mcp/build/
 
 # Logs

AGENTS.md

@@ -193,7 +193,7 @@ authenticated in-process, so no `tea`/`curl` and no keychain lookup are needed.
 
 ## Monorepo layout
 
-pnpm workspace (`pnpm@10.4.0`) orchestrated by **Nx**. Five workspace packages:
+pnpm workspace (`pnpm@10.4.0`) orchestrated by **Nx**. Four workspace packages:
 
 | Path | Name | Stack | Role |
 | --- | --- | --- | --- |
@@ -201,8 +201,7 @@ pnpm workspace (`pnpm@10.4.0`) orchestrated by **Nx**. Five workspace packages:
 | `apps/client` | `client` | React 18 + Vite + Mantine 8 + TanStack Query + Jotai | SPA frontend |
 | `packages/editor-ext` | `@docmost/editor-ext` | Tiptap/ProseMirror | Shared Tiptap node/mark extensions, imported by both the client and the server |
 | `packages/mcp` | `@docmost/mcp` | MCP SDK, Tiptap, Yjs | Standalone MCP server, also bundled into the server at `/mcp`. Consumes the shared converter/schema from `@docmost/prosemirror-markdown` (#293) — it no longer carries its own vendored converter/schema copy |
-| `packages/prosemirror-markdown` | `@docmost/prosemirror-markdown` | Tiptap, marked, jsdom | The single, canonical ProseMirror↔Markdown converter + Docmost schema mirror (#293). Consumed by `mcp` and `git-sync`; there is exactly ONE copy of the converter now |
-| `packages/git-sync` | `@docmost/git-sync` | Tiptap/ProseMirror, Yjs, git | The two-way Docmost↔git Markdown sync **engine** (vault layout, git orchestration, reconcile). Consumes the ProseMirror↔Markdown converter from `@docmost/prosemirror-markdown` (#293) — no longer carries its own converter copy. Bundled into the server (loaded over the ESM bridge), built in CI and the Dockerfile. |
+| `packages/prosemirror-markdown` | `@docmost/prosemirror-markdown` | Tiptap, marked, jsdom | The single, canonical ProseMirror↔Markdown converter + Docmost schema mirror (#293). Consumed by `mcp`, `git-sync`, AND `apps/server` (server-side markdown import/export, #345); there is exactly ONE copy of the converter now |
 
 `build` targets are Nx-cached and dependency-ordered (`dependsOn: ["^build"]`), so `editor-ext` builds before the apps. `nx.json` sets `affected.defaultBase: main`.
 
@@ -215,6 +214,12 @@ Run from the repo root unless noted. The dev workflow needs **Postgres (with the
 > server, `APP_SECRET` mismatch between processes, a stale `editor-ext` white-
 > screening the client, LAN exposure. See **[docs/dev-stand.md](docs/dev-stand.md)**
 > for the step-by-step and the traps.
+>
+> **Testing the app against a stand** (browser E2E + out-of-band verification) has
+> its own non-obvious traps — the page has two ProseMirror editors (only the body is
+> collab-bound), a ~10s store debounce, and API-seeding the thing under test is a
+> silent no-test. See **[docs/how-to-test.md](docs/how-to-test.md)** before writing
+> UI tests.
 
 ```bash
 pnpm install                 # install all workspaces (uses pnpm patches; see package.json `pnpm.patchedDependencies`)
@@ -225,6 +230,24 @@ pnpm build                   # nx run-many -t build (all packages)
 pnpm collab:dev              # run the collaboration server process standalone (see "Two server processes")
 ```
 
+> **Build the shared packages before running a consumer's `tsc`/tests in
+> isolation.** The `build/` dirs of `@docmost/prosemirror-markdown`,
+> `@docmost/git-sync`, and `@docmost/mcp` are **gitignored** (not committed), and
+> a single-package `pnpm --filter <pkg> test` / `tsc` or a bare `pnpm -r test`
+> does **NOT** honour the Nx `dependsOn: ["^build"]` ordering. So a consumer — the
+> server's `tsc`, `git-sync`'s vitest typecheck, `mcp`'s `pretest: tsc` — fails
+> with `error TS2307: Cannot find module '@docmost/…'` until those packages are
+> built first:
+> ```bash
+> pnpm --filter @docmost/prosemirror-markdown build
+> pnpm --filter @docmost/editor-ext build
+> pnpm --filter @docmost/git-sync build && pnpm --filter @docmost/mcp build
+> ```
+> `pnpm build` (nx run-many) does this for you; CI does it explicitly in
+> `.github/workflows/test.yml` (prosemirror-markdown → git-sync/mcp → server, in
+> that order). Reach for it whenever you run a consumer package's checks on their
+> own rather than through the full `pnpm build`.
+
 **Lint** (per package — there is no root lint script):
 ```bash
 pnpm --filter server lint    # eslint --fix on server .ts
@@ -251,7 +274,10 @@ pnpm --filter server migration:codegen                   # regenerate src/databa
 ```
 Migration files live in `apps/server/src/database/migrations/` and are named `YYYYMMDDThhmmss-description.ts`. Fork-specific migrations only **add** tables (`page_embeddings`, `ai_chats`, `ai_chat_messages`, `ai_provider_credentials`, `ai_mcp_servers`, `page_template_references`) and columns (e.g. `pages.is_template`, a `NOT NULL DEFAULT false` boolean) — never drop/rewrite Docmost data.
 
-**Migration ordering — always check when merging branches/features.** Kysely runs migrations in **alphabetical (= timestamp) order** and refuses to start if a *new* migration sorts **before** one already applied to the DB (`corrupted migrations: ... must always have a name that comes alphabetically after the last executed migration`). When you merge a branch or land a feature, verify your migration's timestamp still sorts **after every migration that may already be applied on the target** (`/bin/ls -1 apps/server/src/database/migrations | sort | tail`). Branches developed in parallel routinely break this: a feature branch adds `…T130000-…`, `main` meanwhile ships and deploys `…T150000-…`, and after the merge the older-timestamped file is rejected at boot. **Fix = rename your migration to a timestamp after the latest one already in the target** (content unchanged — the filename is the ordering key), then rebuild so the compiled `dist/database/migrations/` picks up the new name.
+**Migration ordering — always check when merging branches/features.** Kysely runs migrations in **alphabetical (= timestamp) order**. A *new* migration that sorts **before** one already applied to the DB is a "back-dated" migration, which branches developed in parallel routinely produce: a feature branch adds `…T130000-…`, `develop` meanwhile ships and deploys `…T150000-…`, and after the merge the older-timestamped file has been skipped. Two layers guard this (both added for incident #361, where a back-dated migration crash-looped prod for ~11 min):
+
+- **CI gate (primary):** the `migration-order` job in `.github/workflows/test.yml` fails a PR whose added migration sorts at/before the newest on the base branch. **So the fix is to rename your migration to a timestamp after the latest one already in the target** (`/bin/ls -1 apps/server/src/database/migrations | sort | tail`; content unchanged — the filename is the ordering key), then rebuild so the compiled `dist/database/migrations/` picks up the new name.
+- **Runtime safety net:** both Migrators (`migration.service.ts` startup auto-migrate + `migrate.ts` CLI) set `allowUnorderedMigrations: true`, so the app does **not** refuse to start on an out-of-order migration — it applies the skipped older one instead of crash-looping. Kysely's `#ensureNoMissingMigrations` guard is still on (a *removed* applied migration is still an error). Because apply order can then differ from lexicographic across instances, migrations must stay **independent** (each creates its own objects) — the CI gate remains the primary line; this net only covers a gate bypass (manual push / hotfix branch).
 
 ## Architecture — the big picture
 
@@ -264,10 +290,8 @@ Migration files live in `apps/server/src/database/migrations/` and are named `YY
 
 The API server is a Fastify app with a global `/api` prefix (`main.ts` excludes `robots.txt`, public share pages, and `mcp` from the prefix). A `preHandler` hook enforces that a resolved `workspaceId` exists for most `/api` routes (multi-tenant by hostname/subdomain via `DomainMiddleware`). `GET /api/sb/:id` (the anonymous blob-sandbox read route) is listed in that preHandler's `excludedPaths`, so it is exempt from workspace resolution and carries no session auth at all (its capability is the unguessable UUID + TTL + TLS) — unlike `/api/files/public/...`, which still resolves a workspace and requires a workspace-bound attachment JWT. Auth is JWT (cookie + bearer); authorization is **CASL** (`core/casl`) — every data access is scoped to the user's abilities.
 
-Two routes are mounted **outside** the `/api` prefix at the root, as raw Fastify routes that bypass the Nest pipeline (so neither `DomainMiddleware` nor `ThrottlerGuard` runs for them — each resolves the workspace and throttles itself): `/mcp` (the embedded MCP server, see below) and `/git/<spaceId>.git/...` (the git-sync smart-HTTP host, see below). Both share `mcp-auth.helpers.ts` (HTTP-Basic parsing, `FailedLoginLimiter`, `clientIp`) and the common `resolveRequestWorkspace` helper.
-
 ### Module structure (server)
-`AppModule` wires integration modules (`integrations/*`: storage [local/S3/Azure], mail, queue [BullMQ on Redis], security, telemetry, throttle, `mcp`, `ai`, `git-sync`) plus `CoreModule`, `DatabaseModule`, and `CollaborationModule`. `CoreModule` (`core/*`) holds the domain modules: `page`, `space`, `comment`, `workspace`, `user`, `auth`, `group`, `attachment`, `search`, `share`, `ai-chat`, etc. Each domain module follows NestJS controller → service → repo layering; DB repos live under `database/repos` and are injected app-wide from the global `DatabaseModule`.
+`AppModule` wires integration modules (`integrations/*`: storage [local/S3/Azure], mail, queue [BullMQ on Redis], security, telemetry, throttle, `mcp`, `ai`) plus `CoreModule`, `DatabaseModule`, and `CollaborationModule`. `CoreModule` (`core/*`) holds the domain modules: `page`, `space`, `comment`, `workspace`, `user`, `auth`, `group`, `attachment`, `search`, `share`, `ai-chat`, etc. Each domain module follows NestJS controller → service → repo layering; DB repos live under `database/repos` and are injected app-wide from the global `DatabaseModule`.
 
 **EE removal artifact:** `app.module.ts` still contains a `try/require('./ee/ee.module')` stub. That path no longer exists, so the require fails and is swallowed (it only hard-exits when `CLOUD === 'true'`). Treat EE as gone — do not add code that depends on it.
 
@@ -282,17 +306,12 @@ Two routes are mounted **outside** the `/api` prefix at the root, as raw Fastify
    - `core/ai-chat/tools/` — the agent's ~40 read+write tools. Every tool runs under the **calling user's** CASL permissions via a per-user loopback access token (`docmost-client.loader.ts`), so the agent can never exceed what the user could do. Only **reversible** operations are exposed (page history + trash; no permanent delete). Agent edits get an "AI agent" provenance badge in page history (`20260616T130000-agent-provenance` migration).
    - `core/ai-chat/embedding/` — RAG indexer + a BullMQ consumer on `AI_QUEUE` that embeds pages into `page_embeddings` (vector search), complementing Postgres full-text search. Pages are (re)indexed on edit; `AI_EMBEDDING_TIMEOUT_MS` bounds a hung embeddings endpoint.
    - `core/ai-chat/external-mcp/` — admins can attach external MCP servers (e.g. Tavily) to give the agent web access. **`ssrf-guard.ts` validates outbound MCP URLs against SSRF** — keep that guard in the path when touching external-MCP connection logic.
-
-### Git-sync (native two-way Docmost ↔ git Markdown sync)
-`integrations/git-sync/` (`GitSyncModule`) + the vendored pure engine in `packages/git-sync`. Off by default; gated by the `GIT_SYNC_ENABLED` master switch (and `GIT_SYNC_SERVICE_USER_ID`, the account git-originated writes are attributed to). Per-space opt-in via `space.settings.gitSync.enabled`, with a second per-space toggle `space.settings.gitSync.autoMergeConflicts` that changes PUSH behavior for a still-conflicted page (one carrying `<<<<<<<`/`>>>>>>>` markers): **off (the safe default)** records a per-page failure and holds the refs so the user resolves the git conflict first (markers never reach Docmost); **on** strips the marker lines and pushes both sides' content. Each enabled space gets an on-disk working "vault" repo; the `GitSyncOrchestrator` runs a debounced + poll-backstop reconcile cycle (PULL Docmost→vault, PUSH vault→Docmost) under a per-space Redis leader lock + in-process mutex (`SpaceLockService`). Writes go through the collaboration layer (so concurrent human edits aren't clobbered) and are stamped `lastUpdatedSource = 'git-sync'` for the listener loop-guard. The in-process `setInterval` orchestration + best-effort lock (no fencing tokens) is a known multi-replica limitation — BullMQ + fencing is the documented future direction.
-
-- **`/git` smart-HTTP host** (`integrations/git-sync/http/`, gated additionally by `GIT_SYNC_HTTP_ENABLED`, which defaults to `GIT_SYNC_ENABLED`): a raw root-mounted Fastify route `/git/<spaceId>.git/...` (registered in `main.ts`, NOT under `/api`) that bridges `git clone`/`fetch`/`push` to `git http-backend`. It authenticates HTTP Basic against `AuthService` (throttled by a `FailedLoginLimiter` mirroring the `/mcp` path), authorizes via `SpaceAbilityFactory` (read = fetch, Manage = push), and gates existence so a non-member gets the SAME 404 as a missing/sync-disabled space (never 403 — that would leak space existence). A push runs the receive-pack under the space lock, then a reconcile cycle.
-- **Schema mirror:** `packages/git-sync/src/lib/docmost-schema.ts` is one of the **three** hand-synced copies of the Tiptap document schema (see Client structure) — keep it in lockstep with `editor-ext` (canonical) and `packages/mcp`.
+   - `core/ai-chat/ai-chat-run.service.ts` + `ai_chat_runs` — **detached/autonomous agent runs** (`#184`), behind the per-workspace `settings.ai.autonomousRuns` flag (off by default). When on, a turn becomes a server-side RUN that survives a browser disconnect; only an explicit `POST /ai-chat/stop` ends it, and a client reconnects/live-follows via `POST /ai-chat/run`. **DEPLOY CONSTRAINT — single-instance only in phase 1:** Stop and the AbortController that backs it are process-local, so a Stop only aborts a run executing on the **same** replica that owns it (cross-instance pub/sub stop is phase 2). Do **not** enable `autonomousRuns` on a horizontally-scaled deployment (multiple replicas behind a load balancer, or Docmost cloud `CLOUD=true`) — run a single instance instead. The server logs a startup WARNING when it detects a multi-instance deployment (`CLOUD=true`) so the constraint is visible. The startup sweep settles any run left dangling by a restart.
 
 ### Client structure
 Vite SPA. Code is organized by feature under `apps/client/src/features/*` (mirrors the server domains: `page`, `space`, `comment`, `ai-chat`, `editor`, …). Conventions:
 - **TanStack Query** for server state (one `queries/` file per feature), **Jotai** atoms for local/shared UI state, **Mantine 8** + CSS modules (`*.module.css`) + `postcss-preset-mantine` for UI.
-- The editor is Tiptap; shared node/mark extensions live in `packages/editor-ext` and are imported by **both the client and the server** (collaboration, import/export) — editor schema changes often need to be made in `editor-ext`, not just the client. The ProseMirror↔Markdown converter and its Docmost schema mirror now live in a SINGLE package, `@docmost/prosemirror-markdown` (#293), consumed by both `mcp` and `git-sync` — do NOT reintroduce a per-package copy. `editor-ext` is the upstream source of the Tiptap schema; the package's `docmost-schema.ts` mirrors it and a serializer-contract test (`packages/prosemirror-markdown/test/serializer-contract.test.ts`) guards the boundary (every schema node must have a converter case), so a drift surfaces as a failing test rather than silent divergence.
+- The editor is Tiptap; shared node/mark extensions live in `packages/editor-ext` and are imported by **both the client and the server** (collaboration, schema, `canonicalizeFootnotes`) — editor schema changes often need to be made in `editor-ext`, not just the client. Server-side markdown import/export no longer lives in `editor-ext`: it goes through the canonical converter (#345, see below). The ProseMirror↔Markdown converter and its Docmost schema mirror now live in a SINGLE package, `@docmost/prosemirror-markdown` (#293), consumed by `mcp`, `git-sync`, and `apps/server` (#345) — do NOT reintroduce a per-package copy. `editor-ext` is the upstream source of the Tiptap schema; the package's `docmost-schema.ts` mirrors it and a serializer-contract test (`packages/prosemirror-markdown/test/serializer-contract.test.ts`) guards the boundary (every schema node must have a converter case), so a drift surfaces as a failing test rather than silent divergence. For the converter's property-testing and counterexample→fixture process (P1–P4 invariants, the `PROPERTY_SEED`/`PROPERTY_NUM_RUNS` knobs, and the nightly fuzz workflow), see `packages/prosemirror-markdown/README.md`.
 - API access goes through `apps/client/src/lib/api-client.ts` (axios). The `@` alias maps to `apps/client/src`.
 - Runtime config is injected at build time by `vite.config.ts` via `define` (`APP_URL`, `COLLAB_URL`, `APP_VERSION`, …) — these come from the root `.env`, not from `import.meta.env`.
 
@@ -302,7 +321,7 @@ Vite SPA. Code is organized by feature under `apps/client/src/features/*` (mirro
 - **Errors must never be swallowed or shown as generic messages.** Every caught error MUST (1) be logged in full to the console/logger — error name, message, stack, `cause`, and (for HTTP/provider failures) the status code and response body — and (2) be surfaced to the user with a *specific, human-readable explanation of what actually went wrong*, never a bare generic string like "Something went wrong" / "Could not start recording" / "Transcription failed". Include the real reason (the underlying error/provider message) in the user-facing text. On the server, wrap third-party/provider failures with `describeProviderError` (or equivalent) and rethrow as a meaningful HTTP status + message — never let them collapse into an opaque 500. On the client, `console.error(<context>, err)` the raw error AND show the extracted reason (e.g. `err.response?.data?.message`, or the error `name: message`) in the notification.
 - The version string shown in the UI comes from `APP_VERSION` (CI/Docker) or `git describe --tags --always` (local), resolved in `vite.config.ts` — not from `package.json`.
 - Server TS config is permissive (`noImplicitAny: false`, `strictNullChecks: false`, `no-explicit-any` lint disabled). Follow the existing relaxed style rather than tightening types broadly.
-- Dependency versions are heavily pinned via `pnpm.overrides` and `pnpm.patchedDependencies` (`scimmy`, `yjs`) in the root `package.json`. Don't bump pinned/patched deps casually; the patches and overrides exist for compatibility/security reasons.
+- Dependency versions are heavily pinned via `pnpm.overrides` and `pnpm.patchedDependencies` (`scimmy`, `yjs`, `ai`) in the root `package.json`. Don't bump pinned/patched deps casually; the patches and overrides exist for compatibility/security reasons. The `ai@6.0.134` patch disables the SDK's O(n²) cumulative `partialOutput` accumulation when no output strategy is requested (server heap OOM on long agent runs, #184; tripwire test: `apps/server/src/integrations/ai/ai-sdk-partial-output.patch.spec.ts`) — it MUST be re-created via `pnpm patch` when bumping `ai`.
 - **Adding/renaming/removing an MCP tool requires updating `SERVER_INSTRUCTIONS`** in `packages/mcp/src/index.ts` — the intent-routing guide MCP clients receive on initialize. This applies both to inline `server.registerTool(...)` calls in `index.ts` and to specs in `packages/mcp/src/tool-specs.ts`. Enforced by `packages/mcp/test/unit/server-instructions.test.mjs`, which fails when a registered tool is not mentioned in the guide (deliberate opt-outs go into its `EXCEPTIONS` list). `packages/mcp/build/` is gitignored and rebuilt in CI/Docker via `pnpm build` (same convention as `git-sync`/`prosemirror-markdown`) — never commit it; rebuild locally after editing to run the tests.
 
 ## CI / release

CHANGELOG.md

@@ -12,20 +12,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- **Native two-way Docmost ↔ git Markdown sync.** Opt-in per space (Space
-  settings → a git-sync toggle, plus an `autoMergeConflicts` toggle that controls
-  whether a still-conflicted page is held back or pushed with its conflict
-  markers stripped): each enabled space is mirrored to an on-disk git "vault" of
-  Markdown files and reconciled in both directions (Docmost → vault and vault →
-  Docmost) on a debounced + poll-backstop cycle, under a per-space lock, writing
-  through the collaboration layer so concurrent human edits aren't clobbered.
-  Git-originated changes are attributed to a configurable service account and
-  carry a "git-sync" provenance badge in page history. Optionally exposes a `/git`
-  smart-HTTP host so you can `git clone`/`fetch`/`push` a space directly (HTTP
-  Basic auth, space-permission authorized). Off by default and configured via the
-  `GIT_SYNC_*` environment variables, including `GIT_SYNC_ENABLED`,
-  `GIT_SYNC_SERVICE_USER_ID`, and `GIT_SYNC_HTTP_ENABLED` (see `.env.example`).
-  (#119)
 - **Place several images side by side in a row.** A new "Inline (side by
   side)" alignment mode in the image bubble menu renders consecutive inline
   images as a row that wraps onto the next line on narrow screens. The row is
@@ -86,6 +72,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   append/prepend fragments, nor to COMMENT bodies — a comment may legitimately
   contain a standalone footnote definition, which canonicalization would drop.
   (#228)
+- **Detached, autonomous agent runs that survive a browser disconnect.** When the
+  new `settings.ai.autonomousRuns` workspace flag is on (off by default), an
+  AI-chat turn becomes a first-class, server-side RUN tracked in a new
+  `ai_chat_runs` table instead of a socket-bound stream: closing the tab or
+  losing the connection no longer aborts the turn — it keeps executing and
+  persisting server-side, and only an explicit Stop ends it. A client can
+  reconnect and live-follow (or stop) an in-flight run via `POST /ai-chat/run`
+  (resolve the latest run + its assistant message for a chat) and
+  `POST /ai-chat/stop` (stop by `runId` or `chatId`). A partial unique index
+  enforces one active run per chat, and a startup sweep settles any run left
+  dangling by a restart. Phase 1 is single-instance-only (cross-instance Stop is
+  not yet reliable); the server warns at startup on a horizontally-scaled
+  deployment. (#184)
 - **Out-of-band page transfer via an in-RAM blob sandbox (`stash_page`).** A
   new MCP tool serializes a whole page (its full ProseMirror JSON, with every
   internal image/file mirrored) into an ephemeral in-RAM blob and returns only
@@ -170,6 +169,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- **The server no longer runs out of heap during long autonomous agent runs.** A
+  new pnpm patch on `ai@6.0.134` stops the SDK from building a cumulative
+  snapshot of the ENTIRE turn text on every streamed text-delta when no output
+  strategy was requested (our server never requests one). Unpatched, those
+  O(n²) `partialOutput` snapshots piled up in a never-consumed internal
+  `tee()` branch of the stream result — a ~20-step, ~28k-chunk agent run
+  retained ~1.7 GB and OOM'd the 2 GB JS heap. Streaming granularity is
+  unchanged; the patch must be re-created if `ai` is ever bumped. (#184)
 - **Internal links in exported Markdown no longer lose their visible text.** A
   link whose target page name had no file extension (e.g. a bare title) was
   collapsed to empty text during export, producing an unclickable, label-less

Dockerfile

@@ -5,6 +5,13 @@ RUN npm install -g pnpm@10.4.0
 
 FROM base AS builder
 
+# re2 (packages/mcp) always compiles from source under pnpm (the prebuilt-binary
+# download cannot identify the GitHub repo), so node-gyp needs python3/make/g++.
+# This stage is discarded, so the toolchain can stay installed.
+RUN apt-get update \
+  && apt-get install -y --no-install-recommends python3 make g++ \
+  && rm -rf /var/lib/apt/lists/*
+
 WORKDIR /app
 
 COPY . .
@@ -17,9 +24,8 @@ RUN pnpm build
 
 FROM base AS installer
 
-# git: required by the git-sync VaultGit (shells out to git)
 RUN apt-get update \
-  && apt-get install -y --no-install-recommends curl bash git \
+  && apt-get install -y --no-install-recommends curl bash \
   && rm -rf /var/lib/apt/lists/*
 
 WORKDIR /app
@@ -39,20 +45,14 @@ COPY --from=builder /app/packages/editor-ext/dist /app/packages/editor-ext/dist
 COPY --from=builder /app/packages/editor-ext/package.json /app/packages/editor-ext/package.json
 COPY --from=builder /app/packages/mcp/build /app/packages/mcp/build
 COPY --from=builder /app/packages/mcp/package.json /app/packages/mcp/package.json
-# @docmost/prosemirror-markdown is the shared converter (#293/#326). Both mcp and
-# git-sync depend on it (workspace:*) and load it at runtime, so the built package +
-# its manifest must be shipped or the prod install resolves a broken workspace
-# symlink and every consumer dies with ERR_MODULE_NOT_FOUND.
+# mcp now depends on @docmost/prosemirror-markdown (workspace:*) and eager-imports
+# it at runtime (the in-app ai-chat DocmostClient loads build/index.js -> lib/
+# markdown-converter.js). Ship the built package + its manifest, or the prod
+# install resolves a broken workspace symlink and every ai-chat tool dies with
+# ERR_MODULE_NOT_FOUND (#293/#326 step 5). (git-sync has no runtime consumer yet;
+# revisit at step 6 when #119 lands.)
 COPY --from=builder /app/packages/prosemirror-markdown/build /app/packages/prosemirror-markdown/build
 COPY --from=builder /app/packages/prosemirror-markdown/package.json /app/packages/prosemirror-markdown/package.json
-# git-sync: the server loads @docmost/git-sync at runtime via the loader
-# (git-sync.loader.ts), which deliberately does NOT `require()` it — the package is
-# ESM-only, so the loader uses `require.resolve` + a dynamic `import()`. Without
-# these copied build artifacts that resolve/import fails and the server crashes on
-# first use. Built fresh by the builder's `pnpm build` (nx builds the package's tsc
-# `build` target). This branch (#119) is where git-sync gains its runtime consumer.
-COPY --from=builder /app/packages/git-sync/build /app/packages/git-sync/build
-COPY --from=builder /app/packages/git-sync/package.json /app/packages/git-sync/package.json
 
 # Copy root package files
 COPY --from=builder /app/package.json /app/package.json
@@ -64,9 +64,16 @@ COPY --from=builder /app/patches /app/patches
 
 RUN chown -R node:node /app
 
-USER node
+# Toolchain is needed transiently to compile re2 during the prod install; install
+# and purge it in one layer to keep the final image slim. The install itself runs
+# as the node user via su to keep node_modules ownership without a costly chown layer.
+RUN apt-get update \
+  && apt-get install -y --no-install-recommends python3 make g++ \
+  && su node -c "pnpm install --frozen-lockfile --prod" \
+  && apt-get purge -y --auto-remove python3 make g++ \
+  && rm -rf /var/lib/apt/lists/*
 
-RUN pnpm install --frozen-lockfile --prod
+USER node
 
 RUN mkdir -p /app/data/storage
 

README.md

@@ -125,6 +125,32 @@ Gitmost follows the upstream Docmost setup. See the Docmost
 [documentation](https://docmost.com/docs) for self-hosting and development instructions; replace the
 `docmost/docmost` image with `ghcr.io/vvzvlad/gitmost` where applicable.
 
+### Reverse proxy: SSE streaming paths
+
+The AI agent streams its answers over Server-Sent Events. These endpoints produce a
+long-lived `text/event-stream` response and **must bypass response buffering AND response
+compression** at every proxy in front of the app:
+
+- `POST /api/ai-chat/stream` — the live agent turn stream
+- `GET /api/ai-chat/runs/<chatId>/stream` — attach/resume of a detached agent run
+  (`AI_CHAT_RESUMABLE_STREAM`)
+- `POST /api/shares/ai/stream` — the anonymous public-share assistant
+
+A buffering or compressing proxy does not break these with an error — it silently ruins them:
+the request hangs in `pending`, tokens stop streaming and arrive in one burst when the turn
+ends, or a reloaded tab falls back to coarse polling. The tell in DevTools is a
+`Content-Encoding: gzip/zstd` response header on a `text/event-stream` response.
+
+The server already sends `X-Accel-Buffering: no` (honored by nginx unless ignored), but
+compression middleware is applied by proxy configuration, not headers:
+
+- **nginx** — `proxy_buffering off; proxy_cache off; gzip off;` for these locations, e.g.
+  `location ~ ^/api/(ai-chat/(stream$|runs/.+/stream$)|shares/ai/) { ... }`
+- **Traefik** — route these paths through a dedicated router **without** the `compress`
+  middleware (a `compress` middleware buffers SSE frames until the response closes), e.g.
+  ``PathPrefix(`/api/ai-chat/stream`) || PathPrefix(`/api/ai-chat/runs/`)``. Belt-and-braces:
+  `traefik.http.middlewares.<name>.compress.excludedcontenttypes: text/event-stream`.
+
 ## Migration from Docmost
 
 Gitmost's database schema is a **strict superset** of Docmost's. Every Gitmost-specific migration

README.ru.md

@@ -126,6 +126,32 @@ Gitmost повторяет процесс установки upstream-Docmost.
 смотрите в [документации](https://docmost.com/docs) Docmost; где это применимо, заменяйте образ
 `docmost/docmost` на `ghcr.io/vvzvlad/gitmost`.
 
+### Reverse proxy: SSE-стриминговые пути
+
+AI-агент стримит ответы через Server-Sent Events. Эти эндпоинты отдают долгоживущий
+`text/event-stream`-ответ и **обязаны обходить буферизацию И сжатие ответов** на каждом
+прокси перед приложением:
+
+- `POST /api/ai-chat/stream` — живой стрим хода агента
+- `GET /api/ai-chat/runs/<chatId>/stream` — подключение/резюм detached-рана
+  (`AI_CHAT_RESUMABLE_STREAM`)
+- `POST /api/shares/ai/stream` — анонимный ассистент публичных шар
+
+Буферизующий или сжимающий прокси не ломает эти пути с ошибкой — он тихо их портит:
+запрос висит в `pending`, токены не стримятся и вываливаются одним куском в конце хода,
+а перезагруженная вкладка падает в грубый поллинг. Диагностический признак в DevTools —
+заголовок `Content-Encoding: gzip/zstd` на ответе с `text/event-stream`.
+
+Сервер уже шлёт `X-Accel-Buffering: no` (nginx учитывает его по умолчанию), но
+compression-мидлвари управляются конфигом прокси, а не заголовками:
+
+- **nginx** — `proxy_buffering off; proxy_cache off; gzip off;` для этих location,
+  например `location ~ ^/api/(ai-chat/(stream$|runs/.+/stream$)|shares/ai/) { ... }`
+- **Traefik** — вести эти пути через отдельный роутер **без** `compress`-мидлвари
+  (compress буферизует SSE-кадры до закрытия ответа), например
+  ``PathPrefix(`/api/ai-chat/stream`) || PathPrefix(`/api/ai-chat/runs/`)``. Для надёжности:
+  `traefik.http.middlewares.<name>.compress.excludedcontenttypes: text/event-stream`.
+
 ## Миграция с Docmost
 
 Схема БД Gitmost — это **строгий superset** схемы Docmost. Все Gitmost-специфичные миграции только

agent-roles-catalog/bundles/research/en.yaml

@@ -23,18 +23,33 @@ roles:
         inside it, which terms are ambiguous or have synonyms/jargon.
       - Formulate 5–10 search directions, including adjacent perspectives that
         may prove useful even if the user did not ask about them directly.
-      - Set a "research budget" — roughly how many searches the task's complexity
-        warrants (a simple fact: under 5; a medium task: 5–15; a hard task: more).
+      - Fix the "research budget" — how many searches to run. If the USER named a
+        budget (e.g. "budget 100"), that number is BINDING and MUST be spent in
+        full: it defines the volume of the research, so keep searching until it is
+        used up. If the user gave no number, estimate one yourself from the task's
+        complexity (a simple fact: under 5; a medium task: 5–15; a hard task:
+        more).
       - Decide which languages it makes sense to search in (see below).
 
       ═══════════════════════════════════════════════
       WHERE TO WRITE THE RESULT
       ═══════════════════════════════════════════════
-      - If the user explicitly asks to work in the current/already-open document,
-        work in it.
-      - If this is not specified, create a NEW document for the report.
-      - Keep a working draft in the document or in notes: fact → source →
-        reliability assessment. Update the structure as you go.
+      - Reuse the current/already-open document ONLY if either (a) the user
+        explicitly asked to work in it, or (b) it is empty or has very little on
+        it AND its title matches the topic of the research. In every other case —
+        a non-empty page, or one whose title is about something else — create a
+        NEW document for the report.
+      - Set up this document at the VERY START — right after the plan (STEP 0) and
+        BEFORE running any searches. Seed it immediately with the query, the plan,
+        and a skeleton of the sections you expect to fill.
+      - Fill the document DYNAMICALLY as you work: after every meaningful finding,
+        write it in straight away (fact → source → reliability assessment) and
+        grow or reshape the structure as your understanding evolves.
+      - Do NOT hoard everything in your head or in notes and dump the whole report
+        in one pass at the end. The document is a LIVING artifact: it must exist
+        from the first minute and be updated continuously throughout the run, so
+        that by the finalization stage it is already almost complete and only
+        needs cleanup, ordering, and self-verification.
 
       ═══════════════════════════════════════════════
       WORK LOOP (repeat until saturation)
@@ -53,9 +68,19 @@ roles:
       HOW TO SEARCH
       ═══════════════════════════════════════════════
       VOLUME. Execute a MINIMUM of 15 distinct searches, more for complex tasks.
-      Do not stop at the first plausible answer. Stop only when further searches
-      stop yielding new relevant information (saturation / diminishing returns) —
-      not when it "seems like enough" or when you get tired.
+      Do not stop at the first plausible answer. Absent an explicit budget, stop
+      only when further searches stop yielding new relevant information
+      (saturation / diminishing returns) — not when it "seems like enough" or when
+      you get tired.
+
+      MANDATORY BUDGET. A "research budget" set by the user is a floor you MUST
+      reach: spend it in full even past the point where the topic already feels
+      covered. Do not treat apparent saturation as permission to stop early —
+      instead put the remaining searches to real use: broaden the scope, go
+      lateral into adjacent areas, dig deeper into primary sources, and verify key
+      facts from independent angles. Never pad the count with junk or near-
+      duplicate queries; every search must be a genuine attempt to learn something
+      new.
 
       WIDE → NARROW. Start with short, broad queries (2–5 words), survey the
       landscape, then narrow. If results are scarce, broaden the phrasing; if

agent-roles-catalog/bundles/research/ru.yaml

@@ -23,18 +23,33 @@ roles:
         inside it, which terms are ambiguous or have synonyms/jargon.
       - Formulate 5–10 search directions, including adjacent perspectives that
         may prove useful even if the user did not ask about them directly.
-      - Set a "research budget" — roughly how many searches the task's complexity
-        warrants (a simple fact: under 5; a medium task: 5–15; a hard task: more).
+      - Fix the "research budget" — how many searches to run. If the USER named a
+        budget (e.g. "budget 100"), that number is BINDING and MUST be spent in
+        full: it defines the volume of the research, so keep searching until it is
+        used up. If the user gave no number, estimate one yourself from the task's
+        complexity (a simple fact: under 5; a medium task: 5–15; a hard task:
+        more).
       - Decide which languages it makes sense to search in (see below).
 
       ═══════════════════════════════════════════════
       WHERE TO WRITE THE RESULT
       ═══════════════════════════════════════════════
-      - If the user explicitly asks to work in the current/already-open document,
-        work in it.
-      - If this is not specified, create a NEW document for the report.
-      - Keep a working draft in the document or in notes: fact → source →
-        reliability assessment. Update the structure as you go.
+      - Reuse the current/already-open document ONLY if either (a) the user
+        explicitly asked to work in it, or (b) it is empty or has very little on
+        it AND its title matches the topic of the research. In every other case —
+        a non-empty page, or one whose title is about something else — create a
+        NEW document for the report.
+      - Set up this document at the VERY START — right after the plan (STEP 0) and
+        BEFORE running any searches. Seed it immediately with the query, the plan,
+        and a skeleton of the sections you expect to fill.
+      - Fill the document DYNAMICALLY as you work: after every meaningful finding,
+        write it in straight away (fact → source → reliability assessment) and
+        grow or reshape the structure as your understanding evolves.
+      - Do NOT hoard everything in your head or in notes and dump the whole report
+        in one pass at the end. The document is a LIVING artifact: it must exist
+        from the first minute and be updated continuously throughout the run, so
+        that by the finalization stage it is already almost complete and only
+        needs cleanup, ordering, and self-verification.
 
       ═══════════════════════════════════════════════
       WORK LOOP (repeat until saturation)
@@ -53,9 +68,19 @@ roles:
       HOW TO SEARCH
       ═══════════════════════════════════════════════
       VOLUME. Execute a MINIMUM of 15 distinct searches, more for complex tasks.
-      Do not stop at the first plausible answer. Stop only when further searches
-      stop yielding new relevant information (saturation / diminishing returns) —
-      not when it "seems like enough" or when you get tired.
+      Do not stop at the first plausible answer. Absent an explicit budget, stop
+      only when further searches stop yielding new relevant information
+      (saturation / diminishing returns) — not when it "seems like enough" or when
+      you get tired.
+
+      MANDATORY BUDGET. A "research budget" set by the user is a floor you MUST
+      reach: spend it in full even past the point where the topic already feels
+      covered. Do not treat apparent saturation as permission to stop early —
+      instead put the remaining searches to real use: broaden the scope, go
+      lateral into adjacent areas, dig deeper into primary sources, and verify key
+      facts from independent angles. Never pad the count with junk or near-
+      duplicate queries; every search must be a genuine attempt to learn something
+      new.
 
       WIDE → NARROW. Start with short, broad queries (2–5 words), survey the
       landscape, then narrow. If results are scarce, broaden the phrasing; if

agent-roles-catalog/index.yaml

@@ -33,4 +33,4 @@ bundles:
       - en
     roles:
       - slug: researcher
-        version: 1
+        version: 4

agent-roles-catalog/scripts/content-hashes.json

@@ -16,8 +16,8 @@
     "hash": "cef39fed321779631ddd1077fcba53399adf0e48b301df281c71eb042610900d"
   },
   "researcher": {
-    "version": 1,
-    "hash": "853658fda43ddbe0a4d08f2c6e50b5116d29a2e9ccd7f46e173e65920d8f6ace"
+    "version": 4,
+    "hash": "9446ec6d2c8a6ec548358537ac392b8bf9b4d2a832ebb105d5514eac2c76da74"
   },
   "structural-editor": {
     "version": 4,

apps/client/package.json

@@ -61,6 +61,7 @@
     "react-clear-modal": "^2.0.18",
     "react-dom": "^18.3.1",
     "react-drawio": "1.0.7",
+    "web-vitals": "^5.1.0",
     "react-error-boundary": "6.1.1",
     "react-helmet-async": "3.0.0",
     "react-i18next": "16.5.8",

apps/client/public/locales/en-US/translation.json

@@ -1222,12 +1222,8 @@
   "Commented": "Commented",
   "Resolved comment": "Resolved comment",
   "Ran tool {{name}}": "Ran tool {{name}}",
-  "AI-agent": "AI-agent",
   "AI agent «{{role}}» on behalf of {{person}}": "AI agent «{{role}}» on behalf of {{person}}",
   "AI agent {{name}}": "AI agent {{name}}",
-  "Edited by AI agent on behalf of {{name}}": "Edited by AI agent on behalf of {{name}}",
-  "Git sync": "Git sync",
-  "Synced from Git on behalf of {{name}}": "Synced from Git on behalf of {{name}}",
   "Endpoints": "Endpoints",
   "where we fetch models": "where we fetch models",
   "All endpoints are OpenAI-compatible. Point the Base URL at OpenAI, OpenRouter, a local Ollama, or any self-hosted server.": "All endpoints are OpenAI-compatible. Point the Base URL at OpenAI, OpenRouter, a local Ollama, or any self-hosted server.",
@@ -1252,10 +1248,6 @@
   "MCP server": "MCP server",
   "expose the workspace": "expose the workspace",
   "Enable MCP server": "Enable MCP server",
-  "Enable Git sync": "Enable Git sync",
-  "Sync this space's pages to a Git repository.": "Sync this space's pages to a Git repository.",
-  "Auto-merge conflicts on push": "Auto-merge conflicts on push",
-  "When off (recommended), a page whose content still has unresolved Git conflict markers is skipped on push until you resolve the conflict in Git. When on, the markers are stripped and both sides' content is pushed.": "When off (recommended), a page whose content still has unresolved Git conflict markers is skipped on push until you resolve the conflict in Git. When on, the markers are stripped and both sides' content is pushed.",
   "Exposes the workspace as an MCP server at /mcp — this provides a capability, it doesn't consume a model.": "Exposes the workspace as an MCP server at /mcp — this provides a capability, it doesn't consume a model.",
   "Resolves to {{url}}": "Resolves to {{url}}",
   "Model": "Model",
@@ -1381,6 +1373,39 @@
   "The role catalog is unavailable": "The role catalog is unavailable",
   "Please try again later.": "Please try again later.",
   "No bundles available": "No bundles available",
+  "Content": "Content",
+  "Content language of the roles": "Content language of the roles",
+  "{{count}} updates available in {{bundles}} bundles": "{{count}} updates available in {{bundles}} bundles",
+  "Update all ({{count}})": "Update all ({{count}})",
+  "Updating {{current}}/{{total}}…": "Updating {{current}}/{{total}}…",
+  "{{count}} roles are installed in another language. A different language installs separately and appears as new.": "{{count}} roles are installed in another language. A different language installs separately and appears as new.",
+  "{{count}} roles": "{{count}} roles",
+  "{{count}} new — none installed": "{{count}} new — none installed",
+  "All installed · up to date": "All installed · up to date",
+  "{{count}} updates · {{installed}} up to date": "{{count}} updates · {{installed}} up to date",
+  "{{count}} new": "{{count}} new",
+  "{{count}} installed": "{{count}} installed",
+  "{{count}} updates": "{{count}} updates",
+  "Install bundle": "Install bundle",
+  "Install {{count}} selected": "Install {{count}} selected",
+  "Install bundle ({{count}})": "Install bundle ({{count}})",
+  "{{selected}} of {{total}} selected": "{{selected}} of {{total}} selected",
+  "Select all": "Select all",
+  "Deselect all": "Deselect all",
+  "Skipped": "Skipped",
+  "v{{version}}": "v{{version}}",
+  "{{count}} roles installed": "{{count}} roles installed",
+  "{{count}} roles installed · {{renamed}} renamed": "{{count}} roles installed · {{renamed}} renamed",
+  "{{count}} roles updated": "{{count}} roles updated",
+  "Installed {{installed}} · {{skipped}} skipped": "Installed {{installed}} · {{skipped}} skipped",
+  "A role named \"{{name}}\" already exists in this workspace.": "A role named \"{{name}}\" already exists in this workspace.",
+  "\"{{name}}\" is already installed.": "\"{{name}}\" is already installed.",
+  "Rename & install": "Rename & install",
+  "Couldn’t load the catalog": "Couldn’t load the catalog",
+  "Check your connection and try again. Installed roles are not affected.": "Check your connection and try again. Installed roles are not affected.",
+  "Retry": "Retry",
+  "The catalog is empty": "The catalog is empty",
+  "No role bundles are published for this language yet. Try switching the content language.": "No role bundles are published for this language yet. Try switching the content language.",
   "Already up to date": "Already up to date",
   "Updated to the latest version": "Updated to the latest version",
   "This role is no longer in the catalog": "This role is no longer in the catalog",

apps/client/public/locales/ru-RU/translation.json

@@ -737,7 +737,6 @@
   "Deleted successfully": "Успешно удалено",
   "AI agent «{{role}}» on behalf of {{person}}": "AI-агент «{{role}}» от имени {{person}}",
   "AI agent {{name}}": "AI-агент {{name}}",
-  "Edited by AI agent on behalf of {{name}}": "Отредактировано AI-агентом от имени {{name}}",
   "Failed to delete chat": "Не удалось удалить чат",
   "Failed to rename chat": "Не удалось переименовать чат",
   "Failed": "Ошибка",
@@ -1236,6 +1235,39 @@
   "The role catalog is unavailable": "Каталог ролей недоступен",
   "Please try again later.": "Попробуйте позже.",
   "No bundles available": "Наборы недоступны",
+  "Content": "Язык контента",
+  "Content language of the roles": "Язык контента ролей",
+  "{{count}} updates available in {{bundles}} bundles": "Доступно обновлений: {{count}} в наборах: {{bundles}}",
+  "Update all ({{count}})": "Обновить все ({{count}})",
+  "Updating {{current}}/{{total}}…": "Обновление {{current}}/{{total}}…",
+  "{{count}} roles are installed in another language. A different language installs separately and appears as new.": "Ролей установлено на другом языке: {{count}}. Другой язык устанавливается отдельно и отображается как новый.",
+  "{{count}} roles": "ролей: {{count}}",
+  "{{count}} new — none installed": "новых: {{count}} — ничего не установлено",
+  "All installed · up to date": "Все установлены · актуальны",
+  "{{count}} updates · {{installed}} up to date": "обновлений: {{count}} · актуальны: {{installed}}",
+  "{{count}} new": "новых: {{count}}",
+  "{{count}} installed": "установлено: {{count}}",
+  "{{count}} updates": "обновлений: {{count}}",
+  "Install bundle": "Установить набор",
+  "Install {{count}} selected": "Установить выбранные ({{count}})",
+  "Install bundle ({{count}})": "Установить набор ({{count}})",
+  "{{selected}} of {{total}} selected": "выбрано {{selected}} из {{total}}",
+  "Select all": "Выбрать все",
+  "Deselect all": "Снять выбор",
+  "Skipped": "Пропущено",
+  "v{{version}}": "v{{version}}",
+  "{{count}} roles installed": "Установлено ролей: {{count}}",
+  "{{count}} roles installed · {{renamed}} renamed": "Установлено ролей: {{count}} · переименовано: {{renamed}}",
+  "{{count}} roles updated": "Обновлено ролей: {{count}}",
+  "Installed {{installed}} · {{skipped}} skipped": "Установлено: {{installed}} · пропущено: {{skipped}}",
+  "A role named \"{{name}}\" already exists in this workspace.": "Роль с именем «{{name}}» уже существует в этом рабочем пространстве.",
+  "\"{{name}}\" is already installed.": "«{{name}}» уже установлена.",
+  "Rename & install": "Переименовать и установить",
+  "Couldn’t load the catalog": "Не удалось загрузить каталог",
+  "Check your connection and try again. Installed roles are not affected.": "Проверьте подключение и попробуйте снова. Установленные роли не затронуты.",
+  "Retry": "Повторить",
+  "The catalog is empty": "Каталог пуст",
+  "No role bundles are published for this language yet. Try switching the content language.": "Для этого языка ещё не опубликовано ни одного набора ролей. Попробуйте сменить язык контента.",
   "No roles configured": "Роли не настроены",
   "Already up to date": "Уже актуальна",
   "Updated to the latest version": "Обновлено до последней версии",

apps/client/src/components/ui/git-sync-badge.tsx

@@ -1,37 +0,0 @@
-import { Badge, Tooltip } from "@mantine/core";
-import { IconGitMerge } from "@tabler/icons-react";
-import { useTranslation } from "react-i18next";
-
-interface GitSyncBadgeProps {
-  authorName?: string;
-}
-
-/**
- * Badge marking a version produced by git-sync (provenance §8.1). The history
- * version is created on the PUSH path — when an incoming git body is written back
- * into the Docmost doc — not by the pull itself. Like {@link AiAgentBadge} it is
- * ADDITIVE — shown next to the human author, never replacing them — but a git-sync
- * edit is NOT an agent edit and has no chat to deep-link into, so it is a small,
- * neutral, non-clickable label.
- */
-export function GitSyncBadge({ authorName }: GitSyncBadgeProps) {
-  const { t } = useTranslation();
-
-  const tooltip = t("Synced from Git on behalf of {{name}}", {
-    name: authorName ?? "",
-  });
-
-  return (
-    <Tooltip label={tooltip} withArrow>
-      <Badge
-        size="sm"
-        variant="light"
-        color="gray"
-        radius="sm"
-        leftSection={<IconGitMerge size={12} stroke={2} />}
-      >
-        {t("Git sync")}
-      </Badge>
-    </Tooltip>
-  );
-}

apps/client/src/features/ai-chat/components/ai-chat-window.tsx

@@ -19,7 +19,7 @@ import {
   IconPlus,
   IconX,
 } from "@tabler/icons-react";
-import { useAtom, useSetAtom } from "jotai";
+import { useAtom, useAtomValue, useSetAtom } from "jotai";
 import { useLocation, useMatch } from "react-router-dom";
 import { useTranslation } from "react-i18next";
 import { useQueryClient } from "@tanstack/react-query";
@@ -37,6 +37,14 @@ import {
   mobileSidebarAtom,
 } from "@/components/layouts/global/hooks/atoms/sidebar-atom.ts";
 import { usePageQuery } from "@/features/page/queries/page-query.ts";
+import {
+  pageEditorAtom,
+  readOnlyEditorAtom,
+} from "@/features/editor/atoms/editor-atoms.ts";
+import {
+  getEditorSelectionContext,
+  type EditorSelectionContext,
+} from "@/features/editor/utils/get-editor-selection.ts";
 import { extractPageSlugId } from "@/lib";
 import {
   AI_CHATS_RQ_KEY,
@@ -45,9 +53,13 @@ import {
   useAiChatsQuery,
   useAiRolesQuery,
 } from "@/features/ai-chat/queries/ai-chat-query.ts";
+import { workspaceAtom } from "@/features/user/atoms/current-user-atom";
 import ConversationList from "@/features/ai-chat/components/conversation-list.tsx";
 import ChatThread from "@/features/ai-chat/components/chat-thread.tsx";
-import { exportAiChat } from "@/features/ai-chat/services/ai-chat-service.ts";
+import {
+  exportAiChat,
+  stopRun,
+} from "@/features/ai-chat/services/ai-chat-service.ts";
 import { useChatSession } from "@/features/ai-chat/hooks/use-chat-session.ts";
 import {
   shouldCollapseOnOutsidePointer,
@@ -74,6 +86,12 @@ const MIN_HEIGHT = 400;
 // Margin kept between the window and the viewport edges while dragging.
 const EDGE_MARGIN = 8;
 
+// #184 phase 1.5: hard cap on the degraded-poll fallback. The poll is armed when
+// a resume attempt could not attach to the live run and disarmed by the thread on
+// settle / local stream; this cap is the ONLY backstop against an endless tick
+// (a stuck 'streaming' row before the boot-sweep, or a user-tail 204 with no run).
+const DEGRADED_POLL_MAX_MS = 10 * 60_000;
+
 /** Compact token formatter: 1.2M / 3.4k / 950. */
 function formatTokens(n: number): string {
   if (n >= 1_000_000) return `${(n / 1_000_000).toFixed(1)}M`;
@@ -231,8 +249,61 @@ export default function AiChatWindow() {
     [roles],
   );
 
+  // #184 phase 1.5: degraded-poll fallback (replaces the F4/F5/F7 latches). When
+  // ChatThread could not attach to a still-running run it arms this via
+  // onResumeFallback(true); the thread disarms it on settle / local stream. The
+  // window only OWNS the timer (armedAtRef stamps when it was armed for the cap).
+  const [degradedPoll, setDegradedPoll] = useState(false);
+  const armedAtRef = useRef(0);
+  const onResumeFallback = useCallback((active: boolean): void => {
+    if (active) armedAtRef.current = Date.now();
+    setDegradedPoll(active);
+  }, []);
+  // Reset the degraded poll whenever the open chat changes: it is scoped to the
+  // resume attempt of the previously-open chat (invariant 8).
+  useEffect(() => {
+    setDegradedPoll(false);
+  }, [activeChatId]);
+
   const { data: messageRows, isLoading: messagesLoading } =
-    useAiChatMessagesQuery(activeChatId ?? undefined);
+    useAiChatMessagesQuery(
+      activeChatId ?? undefined,
+      // DELIBERATELY DUMB (invariant 8 / task 2.4): poll every 2.5s while armed
+      // and under the 10-min cap; otherwise off. NO error checks (TanStack v5
+      // resets fetchFailureCount each fetch, so consecutive errors are not
+      // expressible — and the poll must survive a server restart) and NO tail
+      // checks (the settled/local-stream semantics live in ChatThread, which
+      // disarms via onResumeFallback(false)). The time cap is the only backstop.
+      () =>
+        degradedPoll === true &&
+        Date.now() - armedAtRef.current < DEGRADED_POLL_MAX_MS
+          ? 2500
+          : false,
+    );
+
+  // #184 reconnect-and-live-follow. Whether detached agent runs are enabled for
+  // this workspace. When the feature is off no runs are ever created, so the
+  // resume attempt would only ever 204; gating ChatThread's resume on it avoids a
+  // pointless attach round-trip.
+  const workspace = useAtomValue(workspaceAtom);
+  const autonomousRunsEnabled =
+    workspace?.settings?.ai?.autonomousRuns === true;
+
+  // Authoritative stop of the open chat's detached run (the Stop button in
+  // autonomous mode). Request the server stop — the ONLY thing that ends a
+  // detached run; a mere local SSE abort is a client disconnect the server
+  // ignores. On failure surface the error.
+  const handleServerStop = useCallback(
+    (chatId: string): void => {
+      void stopRun(chatId).catch(() => {
+        notifications.show({
+          message: t("Failed to stop the run"),
+          color: "red",
+        });
+      });
+    },
+    [t],
+  );
 
   // The page the user is currently viewing. AiChatWindow lives in a pathless
   // parent layout route, so useParams() can't see :pageSlug. Match the full
@@ -251,6 +322,27 @@ export default function AiChatWindow() {
     ? { id: openPageData.id, title: openPageData.title }
     : null;
 
+  // Live editor handles for the selection snapshot (#388). Both are published by
+  // the page editor; the read-only editor is used in read mode. Reading the
+  // selection off `editor.state` stays valid after the editor blurs (ProseMirror
+  // keeps state.selection), mirroring the comment button (comment-dialog.tsx).
+  const pageEditor = useAtomValue(pageEditorAtom);
+  const readOnlyEditor = useAtomValue(readOnlyEditorAtom);
+
+  // Snapshot the user's current editor selection at send time. Edit-mode editor
+  // wins; the read-only editor is the fallback (read mode). Null when neither
+  // holds a non-empty selection. Passed to <ChatThread>, which reads it live
+  // from a ref inside prepareSendMessagesRequest — so each turn ships a fresh
+  // snapshot and multi-turn works without recreating the transport.
+  const getEditorSelection = useCallback((): EditorSelectionContext | null => {
+    for (const editor of [pageEditor, readOnlyEditor]) {
+      if (!editor || editor.isDestroyed) continue;
+      const sel = getEditorSelectionContext(editor.state);
+      if (sel) return sel;
+    }
+    return null;
+  }, [pageEditor, readOnlyEditor]);
+
   // The AI-chat thread-identity lifecycle (mount key, both new-chat id adoption
   // paths, the history-loaded latch, the render-phase reconciler) lives in this
   // hook. See adopt-chat-id.ts for the canonical #137 two-tab race explanation.
@@ -873,6 +965,9 @@ export default function AiChatWindow() {
               chatId={activeChatId}
               initialRows={activeChatId ? messageRows : []}
               openPage={openPage}
+              // #388: live snapshotter for the user's editor selection, read at
+              // send time and nested inside openPage on the wire.
+              getEditorSelection={getEditorSelection}
               // Honoured only for a new chat; null = universal assistant.
               roleId={activeChatId === null ? selectedRoleId : null}
               // Role cards are the new-chat empty-state; offered only when this
@@ -882,6 +977,15 @@ export default function AiChatWindow() {
               assistantName={currentRole?.name}
               onTurnFinished={onTurnFinished}
               onServerChatId={onServerChatId}
+              // #184 phase 1.5: arm/disarm the degraded-poll fallback when a
+              // resume attempt could not attach to the live run; the thread
+              // disarms it on settle / local stream.
+              onResumeFallback={onResumeFallback}
+              // #184: in autonomous mode the Stop button must hit the authoritative
+              // server stop (a local SSE abort is a client disconnect the server
+              // ignores).
+              autonomousRunsEnabled={autonomousRunsEnabled}
+              onServerStop={handleServerStop}
             />
           )}
         </div>

apps/client/src/features/ai-chat/components/chat-thread.test.tsx

@@ -1,6 +1,13 @@
-import { describe, it, expect, beforeEach, vi } from "vitest";
-import { render, screen, fireEvent, act, cleanup } from "@testing-library/react";
+import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
+import {
+  render,
+  screen,
+  fireEvent,
+  act,
+  cleanup,
+} from "@testing-library/react";
 import { MantineProvider } from "@mantine/core";
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
 
 // Shared, hoisted mock state so the @ai-sdk/react and "ai" module mocks (hoisted
 // above the imports) can expose the captured useChat callbacks / transport and
@@ -11,48 +18,62 @@ const h = vi.hoisted(() => ({
     onFinish: null as null | ((arg: Record<string, unknown>) => void),
     sendMessage: vi.fn(),
     stop: vi.fn(),
+    setMessages: vi.fn(),
+    resumeStream: vi.fn(),
+    // The messages array useChat was seeded with (to assert strip/seed behavior).
+    seededMessages: null as null | unknown[],
     transport: null as null | {
-      prepareSendMessagesRequest: (arg: {
+      prepareSendMessagesRequest?: (arg: {
         messages: unknown[];
         body: Record<string, unknown>;
       }) => { body: Record<string, unknown> };
+      prepareReconnectToStreamRequest?: () => { api?: string };
+      fetch?: (input: unknown, init?: { method?: string }) => Promise<unknown>;
     },
   },
 }));
 
-// Mock useChat: capture onFinish, return the spies and the controllable status.
+// Mock useChat: capture onFinish + seeded messages, return the spies and the
+// controllable status.
 vi.mock("@ai-sdk/react", () => ({
-  useChat: (opts: { onFinish?: (arg: Record<string, unknown>) => void }) => {
+  useChat: (opts: {
+    messages?: unknown[];
+    onFinish?: (arg: Record<string, unknown>) => void;
+  }) => {
     h.state.onFinish = opts.onFinish ?? null;
+    h.state.seededMessages = opts.messages ?? null;
     return {
       messages: [],
       sendMessage: h.state.sendMessage,
       status: h.state.status,
       stop: h.state.stop,
       error: null,
+      setMessages: h.state.setMessages,
+      resumeStream: h.state.resumeStream,
     };
   },
 }));
 
 // Mock "ai": deterministic ids + a transport that records its options so the test
-// can invoke prepareSendMessagesRequest and assert the `interrupted` flag.
+// can invoke prepareSendMessagesRequest / prepareReconnectToStreamRequest / fetch.
 vi.mock("ai", () => {
   let counter = 0;
   return {
     generateId: () => `gid-${counter++}`,
     DefaultChatTransport: class {
-      constructor(opts: {
-        prepareSendMessagesRequest: (arg: {
-          messages: unknown[];
-          body: Record<string, unknown>;
-        }) => { body: Record<string, unknown> };
-      }) {
-        h.state.transport = opts;
+      constructor(opts: Record<string, unknown>) {
+        h.state.transport = opts as never;
       }
     },
   };
 });
 
+// Keep the ai-chat-query import light: ChatThread only needs the messages RQ key,
+// so stub the module to avoid pulling axios / i18n transitively.
+vi.mock("@/features/ai-chat/queries/ai-chat-query.ts", () => ({
+  AI_CHAT_MESSAGES_RQ_KEY: (chatId: string) => ["ai-chat-messages", chatId],
+}));
+
 // Stub the heavy children: MessageList (markdown/render) and ChatInput (the
 // composer). The ChatInput stub exposes a button that queues a message, the only
 // interaction this test needs to populate the queue while "streaming".
@@ -60,49 +81,90 @@ vi.mock("@/features/ai-chat/components/message-list.tsx", () => ({
   default: () => <div data-testid="message-list" />,
 }));
 vi.mock("@/features/ai-chat/components/chat-input.tsx", () => ({
-  default: ({ onQueue }: { onQueue: (text: string) => void }) => (
-    <button data-testid="queue-btn" onClick={() => onQueue("queued text")}>
-      queue
-    </button>
+  default: ({
+    onQueue,
+    onStop,
+  }: {
+    onQueue: (text: string) => void;
+    onStop: () => void;
+  }) => (
+    <>
+      <button data-testid="queue-btn" onClick={() => onQueue("queued text")}>
+        queue
+      </button>
+      <button aria-label="Stop" onClick={() => onStop()}>
+        stop
+      </button>
+    </>
   ),
 }));
 
 import ChatThread from "./chat-thread";
+import type { IAiChatMessageRow } from "@/features/ai-chat/types/ai-chat.types.ts";
 
-function renderThread() {
+function row(
+  id: string,
+  role: string,
+  status?: string,
+  text = "",
+): IAiChatMessageRow {
+  return { id, role, content: text, status, createdAt: "2026-01-01T00:00:00Z" };
+}
+
+function renderThread(props?: {
+  chatId?: string | null;
+  initialRows?: IAiChatMessageRow[];
+  autonomousRunsEnabled?: boolean;
+}) {
   const onTurnFinished = vi.fn();
-  render(
-    <MantineProvider>
-      <ChatThread chatId="c1" initialRows={[]} onTurnFinished={onTurnFinished} />
-    </MantineProvider>,
+  const onResumeFallback = vi.fn();
+  const onServerStop = vi.fn();
+  const queryClient = new QueryClient({
+    defaultOptions: { queries: { retry: false } },
+  });
+  const invalidateSpy = vi.spyOn(queryClient, "invalidateQueries");
+  const { unmount } = render(
+    <QueryClientProvider client={queryClient}>
+      <MantineProvider>
+        <ChatThread
+          chatId={props?.chatId === undefined ? "c1" : props.chatId}
+          initialRows={props?.initialRows ?? []}
+          autonomousRunsEnabled={props?.autonomousRunsEnabled}
+          onTurnFinished={onTurnFinished}
+          onResumeFallback={onResumeFallback}
+          onServerStop={onServerStop}
+        />
+      </MantineProvider>
+    </QueryClientProvider>,
   );
-  return { onTurnFinished };
+  return { onTurnFinished, onResumeFallback, onServerStop, invalidateSpy, unmount };
+}
+
+function resetState() {
+  h.state.status = "streaming";
+  h.state.onFinish = null;
+  h.state.seededMessages = null;
+  h.state.transport = null;
+  h.state.sendMessage.mockClear();
+  h.state.stop.mockClear();
+  h.state.setMessages.mockClear();
+  h.state.resumeStream.mockClear();
 }
 
 describe("ChatThread — send now (#198)", () => {
-  beforeEach(() => {
-    h.state.status = "streaming";
-    h.state.onFinish = null;
-    h.state.sendMessage.mockClear();
-    h.state.stop.mockClear();
-    h.state.transport = null;
-  });
+  beforeEach(resetState);
 
   it("aborts the current turn and resends the queued message on the abort", () => {
     renderThread();
 
-    // Queue a message while the turn is streaming.
     fireEvent.click(screen.getByTestId("queue-btn"));
     const sendNowBtn = screen.getByLabelText("Send now");
     expect(sendNowBtn).toBeTruthy();
 
-    // "Send now" interrupts the current turn (stop), but does NOT send yet —
-    // the resend happens once the abort lands in onFinish.
     fireEvent.click(sendNowBtn);
     expect(h.state.stop).toHaveBeenCalledTimes(1);
     expect(h.state.sendMessage).not.toHaveBeenCalled();
 
-    // The abort we triggered reaches onFinish: the promoted head is flushed.
     act(() => {
       h.state.onFinish?.({
         message: { id: "a", role: "assistant", parts: [] },
@@ -119,10 +181,8 @@ describe("ChatThread — send now (#198)", () => {
     fireEvent.click(screen.getByTestId("queue-btn"));
     fireEvent.click(screen.getByLabelText("Send now"));
 
-    const prep = h.state.transport!.prepareSendMessagesRequest;
-    // The send right after "send now" carries interrupted: true...
+    const prep = h.state.transport!.prepareSendMessagesRequest!;
     expect(prep({ messages: [], body: {} }).body.interrupted).toBe(true);
-    // ...and only that one (the flag is read-and-cleared).
     expect(prep({ messages: [], body: {} }).body.interrupted).toBe(false);
   });
 
@@ -133,42 +193,92 @@ describe("ChatThread — send now (#198)", () => {
     fireEvent.click(screen.getByTestId("queue-btn"));
     fireEvent.click(screen.getByLabelText("Send now"));
 
-    // No turn to interrupt: sent straight away, no abort, not flagged.
     expect(h.state.stop).not.toHaveBeenCalled();
     expect(h.state.sendMessage).toHaveBeenCalledWith({ text: "queued text" });
-    const prep = h.state.transport!.prepareSendMessagesRequest;
+    const prep = h.state.transport!.prepareSendMessagesRequest!;
     expect(prep({ messages: [], body: {} }).body.interrupted).toBe(false);
   });
 });
 
-// The turn-end decision lives in the `onFinish` handler: given the terminal
-// outcome of a turn (`isAbort` / `isDisconnect` / `isError`, or none = clean),
-// it decides whether to CONTINUE (flush the next queued message) or END (leave
-// the queue intact for the user), and which stop notice — if any — to show.
-// `sendNow` is exercised above; these tests pin down the plain outcomes.
-describe("ChatThread — turn-end decision (onFinish)", () => {
-  beforeEach(() => {
-    h.state.status = "streaming";
-    h.state.onFinish = null;
-    h.state.sendMessage.mockClear();
-    h.state.stop.mockClear();
-    h.state.transport = null;
+// #388: the editor selection is snapshotted at send time and nested inside
+// openPage on the wire. The getter is read live from a ref, so each send ships a
+// fresh snapshot.
+describe("ChatThread — editor selection wiring (#388)", () => {
+  beforeEach(resetState);
+  afterEach(cleanup);
+
+  function renderWithSelection(props: {
+    openPage?: { id: string; title: string } | null;
+    getEditorSelection?: () => unknown;
+  }) {
+    const queryClient = new QueryClient({
+      defaultOptions: { queries: { retry: false } },
+    });
+    render(
+      <QueryClientProvider client={queryClient}>
+        <MantineProvider>
+          <ChatThread
+            chatId="c1"
+            initialRows={[]}
+            openPage={props.openPage as never}
+            getEditorSelection={props.getEditorSelection as never}
+            onTurnFinished={vi.fn()}
+            onResumeFallback={vi.fn()}
+            onServerStop={vi.fn()}
+          />
+        </MantineProvider>
+      </QueryClientProvider>,
+    );
+  }
+
+  it("nests the snapshot from the getter into openPage.selection at send time", () => {
+    const selection = { text: "fix this", blockIds: ["b1"], before: "a " };
+    renderWithSelection({
+      openPage: { id: "p1", title: "Doc" },
+      getEditorSelection: () => selection,
+    });
+    const prep = h.state.transport!.prepareSendMessagesRequest!;
+    const openPage = prep({ messages: [], body: {} }).body.openPage as Record<
+      string,
+      unknown
+    >;
+    expect(openPage).toEqual({ id: "p1", title: "Doc", selection });
   });
 
-  // Drive a fresh onFinish with the given terminal flags after queueing a
-  // message, and report both what the parent was told and whether the queue was
-  // flushed (a resend to the sendMessage spy).
+  it("sends selection: null when the getter returns null", () => {
+    renderWithSelection({
+      openPage: { id: "p1", title: "Doc" },
+      getEditorSelection: () => null,
+    });
+    const prep = h.state.transport!.prepareSendMessagesRequest!;
+    const openPage = prep({ messages: [], body: {} }).body.openPage as Record<
+      string,
+      unknown
+    >;
+    expect(openPage).toEqual({ id: "p1", title: "Doc", selection: null });
+  });
+
+  it("does not send selection at all on a non-page route (openPage null)", () => {
+    const getter = vi.fn(() => ({ text: "sel" }));
+    renderWithSelection({ openPage: null, getEditorSelection: getter });
+    const prep = h.state.transport!.prepareSendMessagesRequest!;
+    expect(prep({ messages: [], body: {} }).body.openPage).toBeNull();
+    // The getter must not even be consulted when there is no page.
+    expect(getter).not.toHaveBeenCalled();
+  });
+});
+
+describe("ChatThread — turn-end decision (onFinish)", () => {
+  beforeEach(resetState);
+
   function finishWith(flags: {
     isAbort?: boolean;
     isDisconnect?: boolean;
     isError?: boolean;
   }) {
-    // Tear down any prior render so the loop-driven "every outcome" case does
-    // not leave duplicate queue buttons in the DOM.
     cleanup();
     h.state.sendMessage.mockClear();
     const { onTurnFinished } = renderThread();
-    // Populate the queue while the turn is streaming.
     fireEvent.click(screen.getByTestId("queue-btn"));
     act(() => {
       h.state.onFinish?.({
@@ -184,16 +294,12 @@ describe("ChatThread — turn-end decision (onFinish)", () => {
 
   it("CONTINUES — flushes the next queued message on a clean finish", () => {
     finishWith({});
-    // Clean finish (no terminal flag): the queued message is auto-sent.
     expect(h.state.sendMessage).toHaveBeenCalledWith({ text: "queued text" });
-    // A clean finish shows no stop notice.
     expect(screen.queryByText("Response stopped.")).toBeNull();
   });
 
   it("ENDS — keeps the queue intact on a user abort and shows the stopped notice", () => {
     finishWith({ isAbort: true });
-    // A plain Stop (not the sendNow interrupt path) must NOT auto-resend: the
-    // queue is preserved for the user to decide.
     expect(h.state.sendMessage).not.toHaveBeenCalled();
     expect(screen.getByText("Response stopped.")).toBeTruthy();
   });
@@ -208,15 +314,11 @@ describe("ChatThread — turn-end decision (onFinish)", () => {
 
   it("ENDS — keeps the queue intact on a stream error (no auto-retry, no stopped notice)", () => {
     finishWith({ isError: true });
-    // Blindly retrying after a failure would be wrong; the queue is left alone.
     expect(h.state.sendMessage).not.toHaveBeenCalled();
-    // isError clears the neutral notice (the error banner covers this case).
     expect(screen.queryByText("Response stopped.")).toBeNull();
   });
 
   it("notifies the parent on EVERY terminal outcome", () => {
-    // The chat-list refresh / new-chat id adoption must run on success and on
-    // every failure path alike.
     for (const flags of [
       {},
       { isAbort: true },
@@ -228,3 +330,412 @@ describe("ChatThread — turn-end decision (onFinish)", () => {
     }
   });
 });
+
+// #184 phase 1.5: the resumable-SSE client. A reopened tab resumes the live run
+// via the SDK's reconnect transport (attach: replay + tail) instead of polling.
+describe("ChatThread — resume (attach) machinery (#184)", () => {
+  const streamingTail = () => [
+    row("u1", "user", undefined, "hi"),
+    row("a1", "assistant", "streaming", "partial"),
+  ];
+  const settledTail = () => [
+    row("u1", "user", undefined, "hi"),
+    row("a1", "assistant", "succeeded", "done"),
+  ];
+  const userTail = () => [row("u1", "user", undefined, "hi")];
+
+  const visibleMsg = {
+    id: "a1",
+    role: "assistant",
+    parts: [{ type: "text", text: "streamed answer" }],
+  };
+  const emptyMsg = { id: "a1", role: "assistant", parts: [] };
+
+  beforeEach(resetState);
+  // NOTE: do NOT vi.unstubAllGlobals() here — vitest.setup.ts installs
+  // matchMedia/localStorage via vi.stubGlobal and unstubbing wipes them for the
+  // rest of the file. Fetch is re-stubbed per test that needs it.
+  afterEach(cleanup);
+
+  it("resumes on mount only when the flag is on, chatId is set, and the tail is not a settled assistant", () => {
+    // streaming tail -> resume
+    renderThread({ autonomousRunsEnabled: true, initialRows: streamingTail() });
+    expect(h.state.resumeStream).toHaveBeenCalledTimes(1);
+
+    // user tail -> resume (the assistant row may not be seeded yet)
+    cleanup();
+    h.state.resumeStream.mockClear();
+    renderThread({ autonomousRunsEnabled: true, initialRows: userTail() });
+    expect(h.state.resumeStream).toHaveBeenCalledTimes(1);
+
+    // settled assistant tail -> NO resume
+    cleanup();
+    h.state.resumeStream.mockClear();
+    renderThread({ autonomousRunsEnabled: true, initialRows: settledTail() });
+    expect(h.state.resumeStream).not.toHaveBeenCalled();
+
+    // flag off -> NO resume
+    cleanup();
+    h.state.resumeStream.mockClear();
+    renderThread({ autonomousRunsEnabled: false, initialRows: streamingTail() });
+    expect(h.state.resumeStream).not.toHaveBeenCalled();
+
+    // no chatId -> NO resume
+    cleanup();
+    h.state.resumeStream.mockClear();
+    renderThread({
+      autonomousRunsEnabled: true,
+      chatId: null,
+      initialRows: streamingTail(),
+    });
+    expect(h.state.resumeStream).not.toHaveBeenCalled();
+  });
+
+  it("strips the streaming tail from the seed, but keeps a user tail whole", () => {
+    renderThread({ autonomousRunsEnabled: true, initialRows: streamingTail() });
+    // 2 rows in, streaming tail stripped -> 1 seeded message.
+    expect(h.state.seededMessages).toHaveLength(1);
+
+    cleanup();
+    renderThread({ autonomousRunsEnabled: true, initialRows: userTail() });
+    // user tail is not stripped.
+    expect(h.state.seededMessages).toHaveLength(1);
+  });
+
+  it("builds the attach URL with expect=live&anchor only when the streaming tail was stripped", () => {
+    renderThread({ autonomousRunsEnabled: true, initialRows: streamingTail() });
+    expect(h.state.transport!.prepareReconnectToStreamRequest!().api).toBe(
+      "/api/ai-chat/runs/c1/stream?expect=live&anchor=a1",
+    );
+
+    cleanup();
+    renderThread({ autonomousRunsEnabled: true, initialRows: userTail() });
+    expect(h.state.transport!.prepareReconnectToStreamRequest!().api).toBe(
+      "/api/ai-chat/runs/c1/stream",
+    );
+  });
+
+  async function fetch204() {
+    vi.stubGlobal(
+      "fetch",
+      vi.fn().mockResolvedValue({ status: 204, ok: false }),
+    );
+    await act(async () => {
+      await h.state.transport!.fetch!("http://x", { method: "GET" });
+    });
+  }
+
+  it("204 on a user tail: no crash, no restore, reconcile+invalidate, onResumeFallback(true)", async () => {
+    const { onResumeFallback, invalidateSpy } = renderThread({
+      autonomousRunsEnabled: true,
+      initialRows: userTail(),
+    });
+    await fetch204();
+    // No stripped row -> no restore merge.
+    expect(h.state.setMessages).not.toHaveBeenCalled();
+    expect(invalidateSpy).toHaveBeenCalledWith({
+      queryKey: ["ai-chat-messages", "c1"],
+    });
+    expect(onResumeFallback).toHaveBeenCalledWith(true);
+  });
+
+  it("204 on a streaming tail: restore + invalidate + onResumeFallback(true)", async () => {
+    const { onResumeFallback, invalidateSpy } = renderThread({
+      autonomousRunsEnabled: true,
+      initialRows: streamingTail(),
+    });
+    await fetch204();
+    // Stripped row is restored to the store.
+    expect(h.state.setMessages).toHaveBeenCalledTimes(1);
+    expect(invalidateSpy).toHaveBeenCalledWith({
+      queryKey: ["ai-chat-messages", "c1"],
+    });
+    expect(onResumeFallback).toHaveBeenCalledWith(true);
+  });
+
+  it("F7 restart-survival: a 500 attach failure restores the stripped row AND arms the poll (not lost)", async () => {
+    const { onResumeFallback, invalidateSpy } = renderThread({
+      autonomousRunsEnabled: true,
+      initialRows: streamingTail(),
+    });
+    vi.stubGlobal(
+      "fetch",
+      vi.fn().mockResolvedValue({ status: 500, ok: false }),
+    );
+    await act(async () => {
+      await h.state.transport!.fetch!("http://x", { method: "GET" });
+    });
+    expect(h.state.setMessages).toHaveBeenCalledTimes(1); // stripped row restored
+    expect(invalidateSpy).toHaveBeenCalledWith({
+      queryKey: ["ai-chat-messages", "c1"],
+    });
+    expect(onResumeFallback).toHaveBeenCalledWith(true); // degraded poll armed
+  });
+
+  it("F7 restart-survival: a network throw restores the stripped row AND arms the poll", async () => {
+    const { onResumeFallback, invalidateSpy } = renderThread({
+      autonomousRunsEnabled: true,
+      initialRows: streamingTail(),
+    });
+    vi.stubGlobal(
+      "fetch",
+      vi.fn().mockRejectedValue(new Error("network down")),
+    );
+    await act(async () => {
+      await h.state
+        .transport!.fetch!("http://x", { method: "GET" })
+        .catch(() => undefined); // the wrapper rethrows; swallow here
+    });
+    expect(h.state.setMessages).toHaveBeenCalledTimes(1);
+    expect(invalidateSpy).toHaveBeenCalledWith({
+      queryKey: ["ai-chat-messages", "c1"],
+    });
+    expect(onResumeFallback).toHaveBeenCalledWith(true);
+  });
+
+  it("unmount during a pending attach aborts the controller and gates late callbacks", async () => {
+    const { onResumeFallback, invalidateSpy, unmount } = renderThread({
+      autonomousRunsEnabled: true,
+      initialRows: streamingTail(),
+    });
+    let abortSeen = false;
+    let resolveFetch!: (v: unknown) => void;
+    vi.stubGlobal(
+      "fetch",
+      vi.fn().mockImplementation((_input: unknown, init: RequestInit) => {
+        init.signal?.addEventListener("abort", () => {
+          abortSeen = true;
+        });
+        return new Promise((res) => {
+          resolveFetch = res;
+        });
+      }),
+    );
+    // Kick a reconnect GET (stays pending).
+    let pending!: Promise<unknown>;
+    act(() => {
+      pending = h.state.transport!.fetch!("http://x", { method: "GET" });
+    });
+    // Unmount: the cleanup aborts the in-flight attach.
+    unmount();
+    expect(abortSeen).toBe(true);
+    // A late 204 landing after unmount must NOT arm a poll / invalidate the (now
+    // different) chat.
+    onResumeFallback.mockClear();
+    invalidateSpy.mockClear();
+    await act(async () => {
+      resolveFetch({ status: 204, ok: false });
+      await pending;
+    });
+    expect(onResumeFallback).not.toHaveBeenCalledWith(true);
+    expect(invalidateSpy).not.toHaveBeenCalled();
+  });
+
+  it("a resume fetch error clears resumedTurn so the next local turn flushes the queue", async () => {
+    renderThread({ autonomousRunsEnabled: true, initialRows: streamingTail() });
+    h.state.status = "ready";
+    vi.stubGlobal(
+      "fetch",
+      vi.fn().mockResolvedValue({ status: 500, ok: false }),
+    );
+    await act(async () => {
+      await h.state.transport!.fetch!("http://x", { method: "GET" });
+    });
+    // Queue then clean-finish: suppression was cleared, so the queue flushes.
+    fireEvent.click(screen.getByTestId("queue-btn"));
+    act(() => {
+      h.state.onFinish?.({
+        message: visibleMsg,
+        isAbort: false,
+        isDisconnect: false,
+        isError: false,
+      });
+    });
+    expect(h.state.sendMessage).toHaveBeenCalledWith({ text: "queued text" });
+  });
+
+  it("a resumed turn's onFinish does NOT flush the queue", () => {
+    renderThread({ autonomousRunsEnabled: true, initialRows: streamingTail() });
+    fireEvent.click(screen.getByTestId("queue-btn"));
+    act(() => {
+      h.state.onFinish?.({
+        message: visibleMsg,
+        isAbort: false,
+        isDisconnect: false,
+        isError: false,
+      });
+    });
+    expect(h.state.sendMessage).not.toHaveBeenCalled();
+  });
+
+  it("a healthy resumed finish (visible content) arms nothing and keeps the store", () => {
+    h.state.status = "ready";
+    const { onResumeFallback } = renderThread({
+      autonomousRunsEnabled: true,
+      initialRows: streamingTail(),
+    });
+    h.state.setMessages.mockClear();
+    onResumeFallback.mockClear();
+    act(() => {
+      h.state.onFinish?.({
+        message: visibleMsg,
+        isAbort: false,
+        isDisconnect: false,
+        isError: false,
+      });
+    });
+    // No restore (would clobber the fuller streamed message), no poll arm.
+    expect(h.state.setMessages).not.toHaveBeenCalled();
+    expect(onResumeFallback).not.toHaveBeenCalledWith(true);
+  });
+
+  it("isDisconnect WITH visible content arms the poll but does NOT restore", () => {
+    h.state.status = "ready";
+    const { onResumeFallback, invalidateSpy } = renderThread({
+      autonomousRunsEnabled: true,
+      initialRows: streamingTail(),
+    });
+    h.state.setMessages.mockClear();
+    onResumeFallback.mockClear();
+    invalidateSpy.mockClear();
+    act(() => {
+      h.state.onFinish?.({
+        message: visibleMsg,
+        isAbort: false,
+        isDisconnect: true,
+        isError: false,
+      });
+    });
+    expect(onResumeFallback).toHaveBeenCalledWith(true);
+    expect(invalidateSpy).toHaveBeenCalledWith({
+      queryKey: ["ai-chat-messages", "c1"],
+    });
+    // Restore forbidden: the on-screen partial must not roll back.
+    expect(h.state.setMessages).not.toHaveBeenCalled();
+  });
+
+  it("an empty resumed message (starved replay) restores the stripped row AND arms the poll", () => {
+    h.state.status = "ready";
+    const { onResumeFallback } = renderThread({
+      autonomousRunsEnabled: true,
+      initialRows: streamingTail(),
+    });
+    h.state.setMessages.mockClear();
+    onResumeFallback.mockClear();
+    act(() => {
+      h.state.onFinish?.({
+        message: emptyMsg,
+        isAbort: false,
+        isDisconnect: false,
+        isError: false,
+      });
+    });
+    expect(h.state.setMessages).toHaveBeenCalledTimes(1); // restore
+    expect(onResumeFallback).toHaveBeenCalledWith(true); // arm
+  });
+
+  it("degraded-merge: merges the tail per initialRows update, and settles disarm the poll", async () => {
+    h.state.status = "ready";
+    const { rerender, onResumeFallback } = renderResumable(streamingTail());
+    // Arm reconcile via a 204.
+    vi.stubGlobal(
+      "fetch",
+      vi.fn().mockResolvedValue({ status: 204, ok: false }),
+    );
+    await act(async () => {
+      await h.state.transport!.fetch!("http://x", { method: "GET" });
+    });
+    h.state.setMessages.mockClear();
+    onResumeFallback.mockClear();
+
+    // A streaming-tail update: merge, poll stays armed.
+    rerender([
+      row("u1", "user", undefined, "hi"),
+      row("a1", "assistant", "streaming", "step 1\nstep 2"),
+    ]);
+    expect(h.state.setMessages).toHaveBeenCalledTimes(1);
+    expect(onResumeFallback).not.toHaveBeenCalledWith(false);
+
+    // A settled-tail update: merge + disarm.
+    h.state.setMessages.mockClear();
+    rerender([
+      row("u1", "user", undefined, "hi"),
+      row("a1", "assistant", "succeeded", "final"),
+    ]);
+    expect(h.state.setMessages).toHaveBeenCalledTimes(1);
+    expect(onResumeFallback).toHaveBeenCalledWith(false);
+  });
+
+  it("a local stream disarms both the merge and the poll", () => {
+    h.state.status = "streaming";
+    const { rerender, onResumeFallback } = renderResumable(streamingTail());
+    onResumeFallback.mockClear();
+    // A re-render while streaming: the reconciliation effect disarms.
+    rerender(streamingTail());
+    expect(onResumeFallback).toHaveBeenCalledWith(false);
+  });
+
+  it("Send now is hidden on a resumed turn but visible on a local stream", () => {
+    // Resumed turn: hidden.
+    renderThread({ autonomousRunsEnabled: true, initialRows: streamingTail() });
+    fireEvent.click(screen.getByTestId("queue-btn"));
+    expect(screen.queryByLabelText("Send now")).toBeNull();
+
+    // Local streaming turn (no resume): visible.
+    cleanup();
+    resetState();
+    renderThread({ initialRows: [] });
+    fireEvent.click(screen.getByTestId("queue-btn"));
+    expect(screen.getByLabelText("Send now")).toBeTruthy();
+  });
+
+  it("handleStop aborts the attach controller and calls onServerStop", async () => {
+    const { onServerStop } = renderThread({
+      autonomousRunsEnabled: true,
+      initialRows: streamingTail(),
+    });
+    // Establish an attach controller via a (pending) reconnect GET.
+    let abortSeen = false;
+    vi.stubGlobal(
+      "fetch",
+      vi.fn().mockImplementation((_input: unknown, init: RequestInit) => {
+        init.signal?.addEventListener("abort", () => {
+          abortSeen = true;
+        });
+        return new Promise(() => undefined); // never resolves
+      }),
+    );
+    act(() => {
+      void h.state.transport!.fetch!("http://x", { method: "GET" });
+    });
+    fireEvent.click(screen.getByLabelText("Stop"));
+    expect(abortSeen).toBe(true);
+    expect(onServerStop).toHaveBeenCalledWith("c1");
+  });
+});
+
+// Helper: render a resumable thread and expose a rerender that only swaps
+// initialRows (the degraded-merge effect depends on it).
+function renderResumable(initialRows: IAiChatMessageRow[]) {
+  const onResumeFallback = vi.fn();
+  const queryClient = new QueryClient({
+    defaultOptions: { queries: { retry: false } },
+  });
+  const Wrapper = ({ rows }: { rows: IAiChatMessageRow[] }) => (
+    <QueryClientProvider client={queryClient}>
+      <MantineProvider>
+        <ChatThread
+          chatId="c1"
+          initialRows={rows}
+          autonomousRunsEnabled
+          onTurnFinished={vi.fn()}
+          onResumeFallback={onResumeFallback}
+        />
+      </MantineProvider>
+    </QueryClientProvider>
+  );
+  const view = render(<Wrapper rows={initialRows} />);
+  const rerender = (rows: IAiChatMessageRow[]) =>
+    act(() => view.rerender(<Wrapper rows={rows} />));
+  return { rerender, onResumeFallback };
+}

apps/client/src/features/ai-chat/components/chat-thread.tsx

@@ -1,4 +1,5 @@
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
+import { useQueryClient } from "@tanstack/react-query";
 import { generateId } from "ai";
 import { ActionIcon, Box, Group, Stack, Text, Tooltip } from "@mantine/core";
 import {
@@ -24,6 +25,15 @@ import {
 } from "@/features/ai-chat/utils/role-launch.ts";
 import { describeChatError } from "@/features/ai-chat/utils/error-message.ts";
 import { extractServerChatId } from "@/features/ai-chat/utils/adopt-chat-id.ts";
+import { assistantMessageHasVisibleContent } from "@/features/ai-chat/utils/message-content.ts";
+import {
+  isStreamingTail,
+  isSettledAssistantTail,
+  seedRows,
+  mergeById,
+} from "@/features/ai-chat/utils/resume-helpers.ts";
+import { AI_CHAT_MESSAGES_RQ_KEY } from "@/features/ai-chat/queries/ai-chat-query.ts";
+import type { EditorSelectionContext } from "@/features/editor/utils/get-editor-selection.ts";
 import {
   dequeue,
   enqueueMessage,
@@ -60,6 +70,10 @@ interface ChatThreadProps {
   /** The page currently open in the workspace, or null on a non-page route.
    *  Sent with each turn so the agent knows what "this page" refers to. */
   openPage?: OpenPageContext | null;
+  /** #388: snapshot the user's current editor selection at SEND time. Invoked
+   *  inside prepareSendMessagesRequest and nested into openPage on the wire, so a
+   *  fresh snapshot ships each turn. Null/absent => nothing selected. */
+  getEditorSelection?: () => EditorSelectionContext | null;
   /** The agent role selected for a NEW chat (null = universal assistant). Sent
    *  in the request body so the server persists it on chat creation; ignored by
    *  the server for existing chats (the role is read from the chat row). */
@@ -86,6 +100,23 @@ interface ChatThreadProps {
    *  Copy/export button available mid-stream). Distinct from onTurnFinished,
    *  which fires only at the terminal outcome. */
   onServerChatId?: (serverChatId?: string) => void;
+  /** #184 phase 1.5: arm/disarm the parent's degraded-poll fallback for THIS
+   *  chat's window. Called `true` when a resume attempt could not attach to the
+   *  live run (attach 204 / starved-or-torn resumed finish), so the window starts
+   *  a dumb timed poll of the message history to follow the detached run to settle;
+   *  called `false` the moment a local stream starts or the terminal settled row is
+   *  merged (invariant 8). The window owns the timer + its 10-min cap. */
+  onResumeFallback?: (active: boolean) => void;
+  /** #184: whether detached/autonomous agent runs are enabled for this workspace.
+   *  When true the Stop button must additionally hit the AUTHORITATIVE server stop
+   *  (via onServerStop) — aborting only the local SSE is just a client disconnect,
+   *  which the server deliberately ignores, so the detached run would keep going. */
+  autonomousRunsEnabled?: boolean;
+  /** #184: request the server-side stop of this chat's active run (the parent owns
+   *  the endpoint call + the "stopping" latch that keeps observer-polling from
+   *  immediately re-streaming the stopping run's output). Called with the resolved
+   *  chat id when the user presses Stop in autonomous mode. */
+  onServerStop?: (chatId: string) => void;
 }
 
 /**
@@ -125,17 +156,65 @@ export default function ChatThread({
   threadKey,
   initialRows,
   openPage,
+  getEditorSelection,
   roleId,
   roles,
   onRolePicked,
   assistantName,
   onTurnFinished,
   onServerChatId,
+  onResumeFallback,
+  autonomousRunsEnabled,
+  onServerStop,
 }: ChatThreadProps) {
   const { t } = useTranslation();
+  const queryClient = useQueryClient();
+
+  // resume machinery refs (#184 phase 1.5)
+  const attachAbortRef = useRef<AbortController | null>(null);
+  const reconcileTailRef = useRef(false);
+  const noStreamHandledRef = useRef(false);
+  const onNoActiveStreamRef = useRef<(() => void) | null>(null);
+  // Live mount flag. The attach GET and the resumed `onFinish` are async and can
+  // land AFTER this thread unmounts (the parent remounts per chat via `key`); with
+  // chatIdRef then pointing at the NEW chat, an ungated late callback would arm a
+  // spurious poll + foreign invalidation on the newly-opened chat. Every parent-
+  // facing resume side-effect is gated on this.
+  const mountedRef = useRef(true);
+  const [resumedTurn, setResumedTurn] = useState(false);
+  const resumedTurnRef = useRef(false);
+  // Identity-stable pair setter (bare useState setter + ref write): it is closed
+  // over by the transport useMemo([]), so it MUST NOT capture state.
+  const setResumedTurnPair = useCallback((v: boolean) => {
+    resumedTurnRef.current = v;
+    setResumedTurn(v);
+  }, []);
+
+  // Mount-time resume gating (in refs — computed once for this mount; the parent
+  // remounts per chat via `key`).
+  //
+  // Attempt resume for any non-settled tail: a streaming tail (strip + expect
+  // live replay) or a user tail (the run may exist but its assistant row is not
+  // seeded yet — attach to the pre-opened registry entry and wait for frames).
+  // A settled assistant tail must NEVER resume: replaying a finished run into a
+  // store that already contains its message duplicates parts (SDK text-start
+  // always pushes a new part).
+  const stripRef = useRef(chatId !== null && isStreamingTail(initialRows ?? []));
+  const attemptResumeRef = useRef(
+    autonomousRunsEnabled === true &&
+      chatId !== null &&
+      !isSettledAssistantTail(initialRows ?? []),
+  );
+  const strippedRowRef = useRef<IAiChatMessageRow | null>(
+    stripRef.current ? (initialRows ?? [])[initialRows!.length - 1] : null,
+  );
 
   const initialMessages = useMemo<UIMessage[]>(
-    () => (initialRows ?? []).map(rowToUiMessage),
+    () =>
+      seedRows(
+        initialRows ?? [],
+        attemptResumeRef.current && stripRef.current,
+      ).map(rowToUiMessage),
     [initialRows],
   );
 
@@ -153,6 +232,14 @@ export default function ChatThread({
   const openPageRef = useRef<OpenPageContext | null>(openPage ?? null);
   openPageRef.current = openPage ?? null;
 
+  // Keep the selection snapshotter in a ref, same rationale as openPageRef: the
+  // transport useMemo([]) closes it over, so prop-identity churn must not matter.
+  // Called at send time inside prepareSendMessagesRequest (#388).
+  const getEditorSelectionRef = useRef<
+    (() => EditorSelectionContext | null) | undefined
+  >(getEditorSelection);
+  getEditorSelectionRef.current = getEditorSelection;
+
   // Keep the selected role id in a ref, same rationale as openPageRef. Only the
   // FIRST request of a brand-new chat uses it (the server persists it then and
   // ignores it for existing chats), but sending it on every send is harmless.
@@ -216,6 +303,16 @@ export default function ChatThread({
   const flushOnAbortRef = useRef(false);
   const interruptNextSendRef = useRef(false);
 
+  // #234 F5: the user pressed Stop while streaming a BRAND-NEW chat whose server
+  // chat id has not been adopted yet (the `start` chunk carrying it hadn't landed
+  // when Stop was pressed). A local SSE abort alone does NOT stop the DETACHED
+  // autonomous run — it keeps burning tokens and WRITING TO PAGES — so we cannot
+  // just no-op. We latch the stop as PENDING and fire the authoritative server
+  // stop the moment onServerChatId adopts the id (below). Read-and-cleared there;
+  // also defused on every new turn start so it can never fire against a later,
+  // unrelated turn's run.
+  const stopPendingRef = useRef(false);
+
   // FIFO dequeue + send the next queued message (no-op when the queue is empty).
   // Returns whether a message was actually sent, so callers can tell an empty
   // dequeue (nothing to flush) from a real send.
@@ -223,9 +320,12 @@ export default function ChatThread({
     const { head, rest } = dequeue(queuedRef.current);
     if (!head) return false;
     setQueue(rest);
+    // Local send: clear any resume-suppression flag so this genuine local turn's
+    // onFinish flushes normally (invariant 8).
+    setResumedTurnPair(false);
     sendMessageRef.current?.({ text: head.text });
     return true;
-  }, [setQueue]);
+  }, [setQueue, setResumedTurnPair]);
 
   const enqueue = useCallback(
     (text: string) => {
@@ -245,6 +345,47 @@ export default function ChatThread({
       new DefaultChatTransport<UIMessage>({
         api: "/api/ai-chat/stream",
         credentials: "include",
+        prepareReconnectToStreamRequest: () => ({
+          // SDK default URL uses the useChat STORE id — always build from the real chat id.
+          // ?expect=live&anchor=<row id> ONLY when we stripped a streaming tail: expect=live
+          // is the only case where a finished-retained replay is safe (the row is stripped,
+          // replay rebuilds it), and the anchor pins the replay to OUR run — a mismatching
+          // (newer) run must 204 into the restore+poll path instead of replaying a foreign
+          // transcript into this store.
+          api: `/api/ai-chat/runs/${chatIdRef.current}/stream${
+            stripRef.current
+              ? `?expect=live&anchor=${strippedRowRef.current!.id}`
+              : ""
+          }`,
+        }),
+        fetch: async (input: RequestInfo | URL, init: RequestInit = {}) => {
+          if ((init.method ?? "GET") !== "GET") return fetch(input, init); // send path untouched
+          // Reconnect GET: the SDK passes no AbortSignal, so wire our own controller
+          // for observer Stop / unmount abort.
+          const controller = new AbortController();
+          attachAbortRef.current = controller;
+          try {
+            const response = await fetch(input, {
+              ...init,
+              signal: controller.signal,
+            });
+            // No onFinish will come for a 204 (silent no-op) OR any non-2xx
+            // (5xx/502 — a server restart mid-attach). Both run the same
+            // no-active-stream recovery: restore the stripped row, invalidate, and
+            // arm the degraded poll (idempotent via noStreamHandledRef; its part-d
+            // also clears the resumedTurn flag). This is the restart-survival path
+            // the removed F7 latch used to guard — a transient attach failure must
+            // NOT drop the in-progress row or stop tracking the durable run.
+            if (response.status === 204 || !response.ok)
+              onNoActiveStreamRef.current?.();
+            return response;
+          } catch (err) {
+            // Network throw: same no-onFinish recovery, then rethrow so the SDK
+            // still surfaces the error to its own machinery.
+            onNoActiveStreamRef.current?.();
+            throw err;
+          }
+        },
         // Inject the chat id and the currently-open page alongside the useChat
         // messages so the server can resolve an existing chat (or create one
         // when null) and tell the agent which page "this page" refers to. Both
@@ -261,7 +402,16 @@ export default function ChatThread({
             body: {
               ...body,
               chatId: chatIdRef.current,
-              openPage: openPageRef.current,
+              // Attach the live editor selection to the open-page context at send
+              // time — "this"/"here" in the user's message means THIS selection.
+              // Nested inside openPage so it dies with the page when the server
+              // rejects the page id (#388). Null when nothing is selected.
+              openPage: openPageRef.current
+                ? {
+                    ...openPageRef.current,
+                    selection: getEditorSelectionRef.current?.() ?? null,
+                  }
+                : null,
               // Honoured by the server only when creating a new chat; null =>
               // universal assistant.
               roleId: roleIdRef.current,
@@ -274,7 +424,15 @@ export default function ChatThread({
     [],
   );
 
-  const { messages, sendMessage, status, stop, error } = useChat({
+  const {
+    messages,
+    sendMessage,
+    status,
+    stop,
+    error,
+    setMessages,
+    resumeStream,
+  } = useChat({
     // Stable per-mount key. Existing chats use their real id; new chats use a
     // generated client id (never `undefined`) so the store is NOT re-created on
     // every render mid-stream (see `chatStoreId` above).
@@ -292,6 +450,38 @@ export default function ChatThread({
     // would be wrong, so on Stop/disconnect/error the queue is left intact for
     // the user to decide.
     onFinish: ({ message, isAbort, isDisconnect, isError }) => {
+      // (1) Capture whether THIS finish belongs to a resumed (attach) turn and
+      // immediately clear the flag so it can never suppress a LATER local turn.
+      const wasResumed = resumedTurnRef.current;
+      setResumedTurnPair(false);
+      // (2) Recovery after a starved/torn resumed finish (invariant 9). The arm
+      // and the stripped-row restore are gated DIFFERENTLY. Skip entirely once
+      // unmounted (an abort-triggered onFinish landing after a chat switch must
+      // not arm a poll / invalidate on the new chat).
+      if (wasResumed && mountedRef.current) {
+        const hasVisibleContent = assistantMessageHasVisibleContent(message);
+        // ARM the reconcile + degraded poll when the resumed message carries no
+        // visible content (starved replay) OR the connection dropped mid-run — in
+        // both cases the poll must drive the row to its real terminal state.
+        if (isDisconnect || !hasVisibleContent) {
+          reconcileTailRef.current = true;
+          queryClient.invalidateQueries({
+            queryKey: AI_CHAT_MESSAGES_RQ_KEY(chatIdRef.current),
+          });
+          onResumeFallback?.(true);
+        }
+        // RESTORE the stripped streaming row ONLY when the resumed message has no
+        // visible content. On isDisconnect WITH visible content restore is
+        // FORBIDDEN: the live stream may have advanced far past the mount-time
+        // snapshot, so restoring would clobber on-screen content (invariant 9) —
+        // the arm above suffices, the poll reaches the true terminal.
+        if (!hasVisibleContent && strippedRowRef.current) {
+          setMessages((prev) =>
+            mergeById(prev, rowToUiMessage(strippedRowRef.current!)),
+          );
+        }
+      }
+      // (3) Standard branches.
       // Forward the authoritative server chatId (streamed on the assistant
       // message metadata) so the parent adopts the REAL created chat id for a new
       // chat — see adopt-chat-id.ts for the full #137 design. `threadKey` lets the
@@ -304,6 +494,10 @@ export default function ChatThread({
       else if (isAbort) setStopNotice("manual");
       else if (isDisconnect) setStopNotice("disconnect");
       else setStopNotice(null);
+      // A resumed turn NEVER flushes the queue (invariant 7): skip BOTH the
+      // flush-on-abort branch and the plain flush. The local streamer is the only
+      // tab that owns the queue.
+      if (wasResumed) return;
       // "Send now": WE triggered this abort to interrupt the current turn and
       // immediately send the promoted head. Flush it even though the turn was
       // aborted (the normal abort path below keeps the queue intact). The
@@ -365,7 +559,14 @@ export default function ChatThread({
       return;
     lastForwardedChatIdRef.current = serverChatId;
     onServerChatId(serverChatId);
-  }, [messages, onServerChatId]);
+    // #234 F5: if Stop was pressed before the id was known, the authoritative
+    // server stop was deferred to this adoption point — fire it now with the
+    // just-adopted id. One-shot (read-and-clear) so it can't fire twice.
+    if (stopPendingRef.current) {
+      stopPendingRef.current = false;
+      onServerStop?.(serverChatId);
+    }
+  }, [messages, onServerChatId, onServerStop]);
 
   // Live "turn was interrupted" marker for the CURRENT session. The red error
   // banner (driven by `error`) covers the error case; this covers an aborted
@@ -378,6 +579,99 @@ export default function ChatThread({
 
   const isStreaming = status === "submitted" || status === "streaming";
 
+  // 204-handler (`onNoActiveStream`): the attach returned 204 — nothing live to
+  // resume (overflow / begin-failure / after retention / anchor-mismatch). One-
+  // shot via noStreamHandledRef (we do NOT null onNoActiveStreamRef). Exactly four
+  // parts. Kept in a ref (read by the transport's fetch closure) and refreshed
+  // each render below.
+  const onNoActiveStream = useCallback(() => {
+    // A late attach outcome after unmount must not arm a poll / invalidate on the
+    // now-different chat this thread's refs were reused for.
+    if (!mountedRef.current) return;
+    if (noStreamHandledRef.current) return;
+    noStreamHandledRef.current = true;
+    // (a) Restore the stripped streaming row to the store — ONLY when we actually
+    // stripped one (a user-tail 204 does NOT reach here with a stripped row, so do
+    // not dereference null).
+    if (strippedRowRef.current) {
+      setMessages((prev) =>
+        mergeById(prev, rowToUiMessage(strippedRowRef.current!)),
+      );
+    }
+    // (b) Reconcile the tail from the message history + invalidate it so the
+    // degraded poll starts from a fresh fetch.
+    reconcileTailRef.current = true;
+    queryClient.invalidateQueries({
+      queryKey: AI_CHAT_MESSAGES_RQ_KEY(chatIdRef.current),
+    });
+    // (c) Arm the degraded poll (a dumb timer with a 10-min cap in the window);
+    // the thread disarms it via onResumeFallback(false) on settle / local stream.
+    onResumeFallback?.(true);
+    // (d) 204 means onFinish will NOT fire — clear the suppression flag so it
+    // cannot swallow the NEXT local turn's queue flush.
+    setResumedTurnPair(false);
+  }, [setMessages, queryClient, onResumeFallback, setResumedTurnPair]);
+  onNoActiveStreamRef.current = onNoActiveStream;
+
+  // Mount effect: kick off the resume attempt for a non-settled tail. Marking the
+  // turn as resumed BEFORE resumeStream so onFinish (invariant 7/8) sees it.
+  useEffect(() => {
+    // Re-arm on (re)mount — StrictMode dev-mounts twice, and the cleanup below
+    // flips this false between the two.
+    mountedRef.current = true;
+    if (attemptResumeRef.current) {
+      setResumedTurnPair(true);
+      void resumeStream();
+    }
+    // Unmount: mark unmounted (gates late attach/onFinish side-effects) and abort
+    // the in-flight attach GET so its callbacks don't fire against the next chat.
+    return () => {
+      mountedRef.current = false;
+      attachAbortRef.current?.abort();
+    };
+    // Mount-only by design; the parent remounts per chat via `key`.
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, []);
+
+  // Reconciliation + degraded-merge (invariant 8). Deps are EXACTLY
+  // [initialRows, isStreaming, setMessages].
+  useEffect(() => {
+    // A local stream owns the view: disarm BOTH the merge and the window poll.
+    if (isStreaming) {
+      reconcileTailRef.current = false;
+      onResumeFallback?.(false);
+      return;
+    }
+    if (!reconcileTailRef.current) return;
+    const rows = initialRows ?? [];
+    const tail = rows[rows.length - 1];
+    if (!tail || tail.role !== "assistant") return;
+    // Merge the polled assistant tail on EVERY initialRows update — while the
+    // degraded poll is active this IS the live per-step progress.
+    setMessages((prev) => mergeById(prev, rowToUiMessage(tail)));
+    // Anchor-mismatch coherence: when we restored a stripped streaming row A but a
+    // DIFFERENT run's row B is now the tail (A finished, B replaced the registry
+    // entry, so the attach 204'd), A would otherwise linger forever as an orphan
+    // jumping-dots row over the real run. Settle it from fresh history (where A is
+    // now persisted) so no phantom row survives. No-op in the common case where A
+    // IS the tail (id match).
+    const stripped = strippedRowRef.current;
+    if (stripped && stripped.id !== tail.id) {
+      const historical = rows.find((r) => r.id === stripped.id);
+      if (historical)
+        setMessages((prev) => mergeById(prev, rowToUiMessage(historical)));
+    }
+    // Settled: the terminal merge is done — disarm the flag AND the window poll
+    // explicitly (the window only has a time cap, it will not disarm itself).
+    if (tail.status !== "streaming") {
+      reconcileTailRef.current = false;
+      onResumeFallback?.(false);
+    }
+    // onResumeFallback intentionally omitted (parent-stable callback); deps are
+    // fixed by the resume design.
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [initialRows, isStreaming, setMessages]);
+
   // "Send now" on a queued message: interrupt the current turn and immediately
   // send THIS message, keeping the agent's partial output. Other queued messages
   // stay queued and flush normally after the new turn. Reuses the existing
@@ -403,12 +697,51 @@ export default function ChatThread({
         const msg = queuedRef.current.find((m) => m.id === id);
         if (!msg) return;
         setQueue(removeQueuedById(queuedRef.current, id));
+        // Local send: clear any resume-suppression flag (invariant 8).
+        setResumedTurnPair(false);
         sendMessageRef.current?.({ text: msg.text });
       }
     },
-    [setQueue, stop],
+    [setQueue, stop, setResumedTurnPair],
   );
 
+  // Stop the current turn. ALWAYS abort the local SSE (`stop()`) so the composer
+  // returns to idle immediately. In AUTONOMOUS mode the turn is a DETACHED run:
+  // aborting the local SSE is only a client disconnect, which the server ignores,
+  // so the run would keep executing — we ADDITIONALLY request the authoritative
+  // server-side stop (the parent owns that call + the "stopping" latch that keeps
+  // observer-polling from re-streaming the stopping run's output). The chat id is
+  // read live from chatIdRef (adopted early at the stream's `start` chunk); if it
+  // is not known yet — a brand-new chat in the first moment of its first turn —
+  // only the local abort happens (there is no server-side run handle to stop yet).
+  const handleStop = useCallback(() => {
+    // Abort the resume/attach GET first: the SDK does not pass it a signal, so an
+    // observer's Stop would otherwise leave the attach fetch running.
+    attachAbortRef.current?.abort();
+    stop();
+    if (!autonomousRunsEnabled) return;
+    if (chatIdRef.current) {
+      onServerStop?.(chatIdRef.current);
+    } else {
+      // #234 F5: no chat id yet (brand-new chat in the first moment of its first
+      // turn, before the `start` chunk adopted the id). Latch the stop as pending;
+      // the onServerChatId adoption effect fires the deferred server stop as soon
+      // as the id appears, so the detached run is still authoritatively stopped
+      // instead of left running by a silent local-only abort.
+      //
+      // KNOWN LIMITATION (#234 F5 review): `stop()` above has already aborted the
+      // local SSE reader. In the rare sub-window where Stop is pressed while still
+      // `submitted` (request sent, not one chunk read yet), that abort can cancel
+      // the reader BEFORE the `start` chunk is applied to `messages`, so the
+      // adoption effect never runs and this pending stop never fires. The detached
+      // run then keeps going for that turn. This is not a regression (the pre-fix
+      // behavior sent no server stop at all); closing it fully would require
+      // deferring the local abort until adoption, which is riskier and out of scope
+      // for this fix. Documented so a future change can address the abort-ordering.
+      stopPendingRef.current = true;
+    }
+  }, [stop, autonomousRunsEnabled, onServerStop]);
+
   // Clear the stopped marker as soon as a new turn begins streaming, and drop any
   // stale "Send now" interrupt flags. On the legit interrupt path both refs are
   // already consumed synchronously (onFinish + prepareSendMessagesRequest) before
@@ -420,6 +753,11 @@ export default function ChatThread({
       setStopNotice(null);
       flushOnAbortRef.current = false;
       interruptNextSendRef.current = false;
+      // #234 F5: a new turn is starting — drop any pending deferred-stop from a
+      // previous turn that never adopted an id, so it can never fire against this
+      // (or a later) unrelated turn's run. A deferred stop for the CURRENT turn is
+      // set AFTER this effect (on the Stop click), so this does not clobber it.
+      stopPendingRef.current = false;
     }
   }, [isStreaming]);
 
@@ -512,17 +850,23 @@ export default function ChatThread({
                 <Text size="xs" lineClamp={2} className={classes.queuedText}>
                   {m.text}
                 </Text>
-                <Tooltip label={t("Interrupt and send now")} withArrow>
-                  <ActionIcon
-                    size="xs"
-                    variant="subtle"
-                    color="blue"
-                    onClick={() => sendNow(m.id)}
-                    aria-label={t("Send now")}
-                  >
-                    <IconPlayerPlayFilled size={12} />
-                  </ActionIcon>
-                </Tooltip>
+                {/* "Send now" (interrupt) is hidden on a RESUMED turn: a local
+                    stop() does not abort the resumed attach fetch, so the click
+                    would be swallowed while flushOnAbortRef would fire minutes
+                    later on the natural finish. Only the remove affordance stays. */}
+                {!resumedTurn && (
+                  <Tooltip label={t("Interrupt and send now")} withArrow>
+                    <ActionIcon
+                      size="xs"
+                      variant="subtle"
+                      color="blue"
+                      onClick={() => sendNow(m.id)}
+                      aria-label={t("Send now")}
+                    >
+                      <IconPlayerPlayFilled size={12} />
+                    </ActionIcon>
+                  </Tooltip>
+                )}
                 <ActionIcon
                   size="xs"
                   variant="subtle"
@@ -537,9 +881,13 @@ export default function ChatThread({
           </Stack>
         )}
         <ChatInput
-          onSend={(text) => sendMessage({ text })}
+          onSend={(text) => {
+            // Local send: clear any resume-suppression flag (invariant 8).
+            setResumedTurnPair(false);
+            sendMessage({ text });
+          }}
           onQueue={enqueue}
-          onStop={stop}
+          onStop={handleStop}
           isStreaming={isStreaming}
         />
       </Stack>

apps/client/src/features/ai-chat/components/message-item.tsx

@@ -40,6 +40,13 @@ interface MessageItemProps {
    * Defaults to true (internal chat). The public share passes false.
    */
   showCitations?: boolean;
+  /**
+   * Forwarded to ToolCallCard: whether tool cards render the one-line summary of
+   * a call's arguments (e.g. the search query). Defaults to true (internal
+   * chat). The public share passes false so an anonymous reader doesn't see the
+   * agent's raw query/argument text.
+   */
+  showInput?: boolean;
   /**
    * Neutralize internal/relative markdown links in the rendered answer (drop
    * their href so they become inert text). Defaults to false (internal chat,
@@ -117,6 +124,7 @@ const MarkdownPart = memo(function MarkdownPart({
 function MessageItem({
   message,
   showCitations = true,
+  showInput = true,
   neutralizeInternalLinks = false,
   assistantName,
   turnStreaming = false,
@@ -210,6 +218,7 @@ function MessageItem({
               key={index}
               part={part as unknown as ToolUiPart}
               showCitations={showCitations}
+              showInput={showInput}
             />
           );
         }
@@ -274,6 +283,7 @@ export function arePropsEqual(
   return (
     prev.signature === next.signature &&
     prev.showCitations === next.showCitations &&
+    prev.showInput === next.showInput &&
     prev.neutralizeInternalLinks === next.neutralizeInternalLinks &&
     prev.assistantName === next.assistantName &&
     // The turn-end flip re-renders every row once (cheap, terminal event) —

apps/client/src/features/ai-chat/components/message-list.tsx

@@ -25,6 +25,13 @@ interface MessageListProps {
    * false because an anonymous reader cannot open the linked internal pages.
    */
   showCitations?: boolean;
+  /**
+   * Forwarded to MessageItem -> ToolCallCard: whether tool cards render the
+   * one-line summary of a call's arguments (e.g. the search query). Defaults to
+   * true (internal chat). The public share passes false so an anonymous reader
+   * doesn't see the agent's raw query/argument text.
+   */
+  showInput?: boolean;
   /**
    * Forwarded to MessageItem: neutralize internal/relative markdown links in
    * the rendered answers (drop their href so they render as inert text).
@@ -119,6 +126,7 @@ export default function MessageList({
   isStreaming,
   emptyState,
   showCitations = true,
+  showInput = true,
   neutralizeInternalLinks = false,
   assistantName,
 }: MessageListProps) {
@@ -208,6 +216,7 @@ export default function MessageList({
             message={message}
             signature={messageSignature(message)}
             showCitations={showCitations}
+            showInput={showInput}
             neutralizeInternalLinks={neutralizeInternalLinks}
             assistantName={assistantName}
             // Turn-level liveness, gated to the TAIL row: only the tail message

apps/client/src/features/ai-chat/components/tool-call-card.tsx

@@ -5,6 +5,7 @@ import { useTranslation } from "react-i18next";
 import {
   getToolName,
   toolCitations,
+  toolInputSummary,
   toolLabelKey,
   toolRunState,
   ToolUiPart,
@@ -21,6 +22,14 @@ interface ToolCallCardProps {
    * (the action log itself) while dropping the unusable links.
    */
   showCitations?: boolean;
+  /**
+   * Whether to render the one-line summary of the call's arguments (e.g. the
+   * search query) under the label. Defaults to true (the internal chat). The
+   * public share passes false: an anonymous reader should not see the agent's
+   * raw query/argument text. Conservative and reversible — it only suppresses
+   * the extra summary line, leaving the card (the action log) intact.
+   */
+  showInput?: boolean;
 }
 
 /**
@@ -31,12 +40,14 @@ interface ToolCallCardProps {
 export default function ToolCallCard({
   part,
   showCitations = true,
+  showInput = true,
 }: ToolCallCardProps) {
   const { t } = useTranslation();
   const toolName = getToolName(part);
   const state = toolRunState(part.state);
   const { key, values } = toolLabelKey(toolName);
   const citations = showCitations ? toolCitations(part) : [];
+  const inputSummary = showInput ? toolInputSummary(part) : undefined;
 
   return (
     <div className={classes.toolCard}>
@@ -57,6 +68,12 @@ export default function ToolCallCard({
         </Text>
       </Group>
 
+      {inputSummary && (
+        <Text size="xs" c="dimmed" mt={2} lineClamp={2}>
+          {inputSummary}
+        </Text>
+      )}
+
       {state === "error" && part.errorText && (
         <Text size="xs" c="red" mt={2}>
           {part.errorText}

apps/client/src/features/ai-chat/queries/ai-chat-messages-query.test.tsx

@@ -0,0 +1,90 @@
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import React from "react";
+import { renderHook, waitFor } from "@testing-library/react";
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
+
+// react-i18next / notifications are pulled in transitively by ai-chat-query.ts
+// (the mutation hooks use them); stub so the module imports cleanly.
+vi.mock("react-i18next", () => ({
+  useTranslation: () => ({ t: (key: string) => key }),
+}));
+vi.mock("@mantine/notifications", () => ({
+  notifications: { show: vi.fn() },
+}));
+
+// Mock the service module; only getAiChatMessages is exercised, but the other
+// named exports must exist so ai-chat-query.ts imports resolve.
+vi.mock("@/features/ai-chat/services/ai-chat-service.ts", () => ({
+  getAiChatMessages: vi.fn(),
+  getAiChats: vi.fn(),
+  getAiRoleCatalog: vi.fn(),
+  getAiRoleCatalogBundle: vi.fn(),
+  getAiRoles: vi.fn(),
+  importAiRolesFromCatalog: vi.fn(),
+  createAiRole: vi.fn(),
+  deleteAiChat: vi.fn(),
+  deleteAiRole: vi.fn(),
+  renameAiChat: vi.fn(),
+  updateAiRole: vi.fn(),
+  updateAiRoleFromCatalog: vi.fn(),
+}));
+
+import { getAiChatMessages } from "@/features/ai-chat/services/ai-chat-service.ts";
+import { useAiChatMessagesQuery } from "@/features/ai-chat/queries/ai-chat-query.ts";
+
+const emptyPage = { items: [], meta: { hasNextPage: false, nextCursor: null } };
+
+function createWrapper() {
+  const queryClient = new QueryClient({
+    defaultOptions: { queries: { retry: false } },
+  });
+  return function Wrapper({ children }: { children: React.ReactNode }) {
+    return (
+      <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
+    );
+  };
+}
+
+// The degraded-poll fallback (#184 phase 1.5) is threaded into this query as a
+// `refetchInterval`; AiChatWindow supplies the deliberately-dumb callback. These
+// pin the plumbing the window depends on: the interval polls the message history,
+// and — critically — fetch ERRORS do NOT stop the tick (TanStack v5 resets the
+// failure count each fetch, so the poll must survive a server restart).
+describe("useAiChatMessagesQuery — degraded refetchInterval", () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });
+
+  it("re-polls at the interval while the callback returns a duration", async () => {
+    vi.mocked(getAiChatMessages).mockResolvedValue(emptyPage as never);
+    renderHook(() => useAiChatMessagesQuery("c1", () => 30), {
+      wrapper: createWrapper(),
+    });
+    await waitFor(() =>
+      expect(vi.mocked(getAiChatMessages).mock.calls.length).toBeGreaterThan(2),
+    );
+  });
+
+  it("does NOT re-poll when the callback returns false", async () => {
+    vi.mocked(getAiChatMessages).mockResolvedValue(emptyPage as never);
+    renderHook(() => useAiChatMessagesQuery("c1", () => false), {
+      wrapper: createWrapper(),
+    });
+    await waitFor(() =>
+      expect(vi.mocked(getAiChatMessages)).toHaveBeenCalledTimes(1),
+    );
+    // Give any errant interval a chance to fire, then assert it did not.
+    await new Promise((r) => setTimeout(r, 60));
+    expect(vi.mocked(getAiChatMessages)).toHaveBeenCalledTimes(1);
+  });
+
+  it("keeps ticking through fetch errors (errors do not gate the poll)", async () => {
+    vi.mocked(getAiChatMessages).mockRejectedValue(new Error("server down"));
+    renderHook(() => useAiChatMessagesQuery("c1", () => 30), {
+      wrapper: createWrapper(),
+    });
+    await waitFor(() =>
+      expect(vi.mocked(getAiChatMessages).mock.calls.length).toBeGreaterThan(2),
+    );
+  });
+});

apps/client/src/features/ai-chat/queries/ai-chat-query.ts

@@ -1,6 +1,7 @@
 import {
   useInfiniteQuery,
   useMutation,
+  useQueries,
   useQuery,
   useQueryClient,
 } from "@tanstack/react-query";
@@ -56,11 +57,12 @@ export const AI_CHAT_MESSAGES_RQ_KEY = (chatId: string) => [
 export function useAiChatsQuery() {
   const query = useInfiniteQuery({
     queryKey: AI_CHATS_RQ_KEY,
-    queryFn: ({ pageParam }) =>
-      getAiChats({ cursor: pageParam, limit: 50 }),
+    queryFn: ({ pageParam }) => getAiChats({ cursor: pageParam, limit: 50 }),
     initialPageParam: undefined as string | undefined,
     getNextPageParam: (lastPage) =>
-      lastPage.meta.hasNextPage ? (lastPage.meta.nextCursor ?? undefined) : undefined,
+      lastPage.meta.hasNextPage
+        ? (lastPage.meta.nextCursor ?? undefined)
+        : undefined,
   });
 
   const data = useMemo<IPagination<IAiChat> | undefined>(() => {
@@ -83,15 +85,26 @@ export function useAiChatsQuery() {
  * Load all persisted messages of a chat (oldest first), flattening the
  * paginated server response. Used to seed `useChat` initial messages.
  */
-export function useAiChatMessagesQuery(chatId: string | undefined) {
+export function useAiChatMessagesQuery(
+  chatId: string | undefined,
+  // #184 phase 1.5: the degraded-poll fallback. When a tab could not attach to a
+  // still-running run (the attach returned 204 / the resumed stream ended with no
+  // terminal row), the window arms a dumb timed poll of the message history to
+  // follow the detached run to settle. The callback form lives in AiChatWindow;
+  // threaded here verbatim so this query owns the polling. Undefined => no poll.
+  refetchInterval?: number | false | (() => number | false),
+) {
   const query = useInfiniteQuery({
     queryKey: AI_CHAT_MESSAGES_RQ_KEY(chatId ?? ""),
     queryFn: ({ pageParam }) =>
       getAiChatMessages({ chatId: chatId as string, cursor: pageParam }),
     initialPageParam: undefined as string | undefined,
     getNextPageParam: (lastPage) =>
-      lastPage.meta.hasNextPage ? (lastPage.meta.nextCursor ?? undefined) : undefined,
+      lastPage.meta.hasNextPage
+        ? (lastPage.meta.nextCursor ?? undefined)
+        : undefined,
     enabled: !!chatId,
+    refetchInterval,
   });
 
   // useInfiniteQuery only fetches the first page on its own. The hook's contract
@@ -272,6 +285,29 @@ export function useAiRoleCatalogBundleQuery(
   });
 }
 
+/**
+ * Eagerly open EVERY listed bundle's content in parallel for one language. The
+ * redesigned catalog shows each bundle's status summary in its COLLAPSED header,
+ * which needs every role's install state up front — so contents can no longer be
+ * lazy-loaded on expand. The catalog is small, so a fan-out of `useQueries` (one
+ * cached read per bundle, sharing the same cache keys as
+ * `useAiRoleCatalogBundleQuery`) is cheap. Gated by `enabled` (modal open + a
+ * resolved language) so nothing fetches while the modal is closed.
+ */
+export function useAiRoleCatalogBundlesQueries(
+  bundleIds: string[],
+  language: string,
+  enabled: boolean,
+) {
+  return useQueries({
+    queries: bundleIds.map((bundleId) => ({
+      queryKey: AI_ROLE_CATALOG_BUNDLE_RQ_KEY(bundleId, language),
+      queryFn: () => getAiRoleCatalogBundle(bundleId, language),
+      enabled: enabled && !!language,
+    })),
+  });
+}
+
 export function useImportAiRolesFromCatalogMutation() {
   const queryClient = useQueryClient();
   const { t } = useTranslation();
@@ -280,11 +316,14 @@ export function useImportAiRolesFromCatalogMutation() {
     mutationFn: (payload) => importAiRolesFromCatalog(payload),
     onSuccess: (result) => {
       notifications.show({
-        message: t("Imported {{created}}, renamed {{renamed}}, skipped {{skipped}}", {
-          created: result.created,
-          renamed: result.renamed,
-          skipped: result.skipped,
-        }),
+        message: t(
+          "Imported {{created}}, renamed {{renamed}}, skipped {{skipped}}",
+          {
+            created: result.created,
+            renamed: result.renamed,
+            skipped: result.skipped,
+          },
+        ),
       });
       // Surface partial failures (e.g. unique-name races) as a red warning.
       if (result.errors.length > 0) {

apps/client/src/features/ai-chat/queries/import-from-catalog-message.test.tsx

@@ -77,7 +77,14 @@ describe("useImportAiRolesFromCatalogMutation — success notifications", () =>
   });
 
   it("errors:[] -> only the summary notification (counts interpolated)", async () => {
-    await runMutation({ created: 3, renamed: 1, skipped: 2, errors: [] });
+    await runMutation({
+      created: 3,
+      renamed: 1,
+      skipped: 2,
+      errors: [],
+      createdRoles: [],
+      skippedRoles: [],
+    });
     expect(notificationsShowMock).toHaveBeenCalledTimes(1);
     expect(notificationsShowMock).toHaveBeenCalledWith({
       message: "Imported 3, renamed 1, skipped 2",
@@ -93,6 +100,8 @@ describe("useImportAiRolesFromCatalogMutation — success notifications", () =>
         { slug: "a", message: "name taken" },
         { slug: "b", message: "name taken" },
       ],
+      createdRoles: [{ slug: "ok", name: "Ok" }],
+      skippedRoles: [],
     });
     expect(notificationsShowMock).toHaveBeenCalledTimes(2);
     expect(notificationsShowMock).toHaveBeenNthCalledWith(1, {

apps/client/src/features/ai-chat/services/ai-chat-service.ts

@@ -42,6 +42,21 @@ export async function getAiChatMessages(
   return req.data;
 }
 
+/**
+ * Explicitly STOP the active agent run of a chat (#184). This is the ONLY thing
+ * that ends a DETACHED run — a mere browser disconnect (aborting the local SSE)
+ * is deliberately ignored server-side, so the client must call this to actually
+ * stop an autonomous run. Targeted by `chatId` (the server resolves whatever run
+ * is active on it); owner-gated server-side. Returns `{ stopped }` — false when
+ * there was nothing active to stop.
+ */
+export async function stopRun(
+  chatId: string,
+): Promise<{ stopped: boolean }> {
+  const req = await api.post<{ stopped: boolean }>("/ai-chat/stop", { chatId });
+  return req.data;
+}
+
 /**
  * Resolve the chat bound to a document (the current user's most-recent chat
  * created on that page), or null when there is none. Drives auto-open-on-page.

apps/client/src/features/ai-chat/types/ai-chat.types.ts

@@ -108,12 +108,25 @@ export interface IAiRoleImportPayload {
   conflict: "skip" | "rename";
 }
 
-/** Import result counts (mirrors `importFromCatalog()`). */
+/**
+ * Import result (mirrors `importFromCatalog()`). The counters (`created`,
+ * `skipped`, `renamed`) drive the summary notification; the per-role lists
+ * (`createdRoles`, `skippedRoles`) drive the redesigned catalog modal's inline
+ * result plaque — which roles were installed (and any rename) and which were
+ * skipped and why (so the plaque can name the conflicting role and offer
+ * "Rename & install").
+ */
 export interface IAiRoleImportResult {
   created: number;
   skipped: number;
   renamed: number;
   errors: { slug: string; message: string }[];
+  createdRoles: { slug: string; name: string; renamedTo?: string }[];
+  skippedRoles: {
+    slug: string;
+    name: string;
+    reason: "name-conflict" | "already-installed";
+  }[];
 }
 
 /**
@@ -197,6 +210,11 @@ export interface IAiChatMessageRow {
     // renders a "stopped" marker on interrupted turns.
     finishReason?: string;
   } | null;
+  // Persisted lifecycle status of the row's turn, carried on the wire by
+  // `baseFields`. 'streaming' marks a still-in-progress assistant row (used by
+  // the resume machinery to decide whether a tail is a live stream to attach to
+  // or a settled row that must not be replayed).
+  status?: string;
   createdAt: string;
 }
 

apps/client/src/features/ai-chat/utils/catalog-bundle-model.test.ts

@@ -0,0 +1,234 @@
+import { describe, it, expect } from "vitest";
+import {
+  bundleCounts,
+  bundlePhase,
+  installedLangForRole,
+  mapBundleRolesToView,
+  mapCatalogRoleToView,
+  nameConflictSlugs,
+  partialOffersRename,
+  type CatalogViewRole,
+} from "./catalog-bundle-model.ts";
+import type {
+  IAiRole,
+  IAiRoleCatalogRole,
+} from "@/features/ai-chat/types/ai-chat.types.ts";
+
+function installedRole(
+  source: { slug: string; language: string; version: number },
+  overrides: Partial<IAiRole> = {},
+): IAiRole {
+  return {
+    id: `role-${source.slug}-${source.language}`,
+    name: source.slug,
+    emoji: null,
+    description: null,
+    enabled: true,
+    autoStart: true,
+    launchMessage: null,
+    source,
+    ...overrides,
+  };
+}
+
+function catalogRole(
+  overrides: Partial<IAiRoleCatalogRole> = {},
+): IAiRoleCatalogRole {
+  return {
+    slug: "writer",
+    emoji: "✍️",
+    name: "Writer",
+    description: "Drafts copy.",
+    instructions: "be a writer",
+    autoStart: true,
+    launchMessage: null,
+    version: 3,
+    ...overrides,
+  };
+}
+
+// Build a minimal view role for bundlePhase tests.
+function viewRole(status: CatalogViewRole["status"]): CatalogViewRole {
+  return { slug: `s-${status}`, name: status, description: "", version: 1, status };
+}
+
+describe("bundlePhase", () => {
+  it("empty bundle -> empty", () => {
+    expect(bundlePhase([])).toBe("empty");
+  });
+
+  it("all importable, none installed -> allNew", () => {
+    expect(bundlePhase([viewRole("import"), viewRole("import")])).toBe(
+      "allNew",
+    );
+  });
+
+  it("nothing to import or update -> allInstalled", () => {
+    expect(bundlePhase([viewRole("installed"), viewRole("installed")])).toBe(
+      "allInstalled",
+    );
+  });
+
+  it("updates present, nothing to import -> updates", () => {
+    expect(bundlePhase([viewRole("update"), viewRole("installed")])).toBe(
+      "updates",
+    );
+  });
+
+  it("import + installed (no updates) -> mixed", () => {
+    expect(bundlePhase([viewRole("import"), viewRole("installed")])).toBe(
+      "mixed",
+    );
+  });
+
+  it("import + update -> mixed", () => {
+    expect(bundlePhase([viewRole("import"), viewRole("update")])).toBe("mixed");
+  });
+
+  it("a skipped role with nothing installed -> mixed (NOT allInstalled)", () => {
+    // F1: a bundle whose only non-installed role was skipped has 0 installed for
+    // it, so the collapsed 'All installed · up to date' header would contradict
+    // the open 'Installed 0 · 1 skipped' plaque. It must be mixed until resolved.
+    expect(bundlePhase([viewRole("skipped")])).toBe("mixed");
+  });
+
+  it("installed + a skipped role -> mixed (partial success is not allInstalled)", () => {
+    expect(bundlePhase([viewRole("installed"), viewRole("skipped")])).toBe(
+      "mixed",
+    );
+  });
+});
+
+describe("bundleCounts", () => {
+  it("tallies each status once", () => {
+    expect(
+      bundleCounts([
+        viewRole("import"),
+        viewRole("import"),
+        viewRole("installed"),
+        viewRole("update"),
+        viewRole("skipped"),
+      ]),
+    ).toEqual({ importable: 2, installed: 1, update: 1, skipped: 1 });
+  });
+});
+
+describe("nameConflictSlugs / partialOffersRename (reason -> action)", () => {
+  it("only name-conflict skips become the transient overlay / offer rename", () => {
+    const skipped = [
+      { slug: "writer", name: "Writer", reason: "name-conflict" as const },
+      { slug: "editor", name: "Editor", reason: "already-installed" as const },
+    ];
+    expect(nameConflictSlugs(skipped)).toEqual(["writer"]);
+    expect(partialOffersRename(skipped)).toBe(true);
+  });
+
+  it("an already-installed-only skip is informational: no overlay, no rename", () => {
+    const skipped = [
+      { slug: "editor", name: "Editor", reason: "already-installed" as const },
+    ];
+    expect(nameConflictSlugs(skipped)).toEqual([]);
+    expect(partialOffersRename(skipped)).toBe(false);
+  });
+});
+
+describe("installedLangForRole", () => {
+  it("returns the other language when the same slug is installed elsewhere", () => {
+    const roles = [installedRole({ slug: "writer", language: "ru", version: 2 })];
+    expect(installedLangForRole("writer", roles, "en")).toBe("ru");
+  });
+
+  it("returns undefined when the same slug is installed in the SAME language", () => {
+    const roles = [installedRole({ slug: "writer", language: "en", version: 2 })];
+    expect(installedLangForRole("writer", roles, "en")).toBeUndefined();
+  });
+
+  it("returns undefined when no install of the slug exists", () => {
+    expect(installedLangForRole("writer", [], "en")).toBeUndefined();
+  });
+
+  it("ignores manually-created roles (no source)", () => {
+    const roles = [
+      installedRole({ slug: "writer", language: "ru", version: 2 }, {
+        source: null,
+      }),
+    ];
+    expect(installedLangForRole("writer", roles, "en")).toBeUndefined();
+  });
+});
+
+describe("mapCatalogRoleToView", () => {
+  it("no install -> import status, catalog version, emoji preserved", () => {
+    const view = mapCatalogRoleToView(catalogRole(), [], "en");
+    expect(view).toMatchObject({
+      slug: "writer",
+      emoji: "✍️",
+      name: "Writer",
+      description: "Drafts copy.",
+      status: "import",
+      version: 3,
+    });
+    expect(view.installedRoleId).toBeUndefined();
+    expect(view.installedLang).toBeUndefined();
+  });
+
+  it("import with the slug installed in another language -> installedLang set", () => {
+    const roles = [installedRole({ slug: "writer", language: "ru", version: 9 })];
+    const view = mapCatalogRoleToView(catalogRole(), roles, "en");
+    expect(view.status).toBe("import");
+    expect(view.installedLang).toBe("ru");
+  });
+
+  it("installed (up to date) -> installed status, catalog version, installedRoleId", () => {
+    const installed = installedRole({
+      slug: "writer",
+      language: "en",
+      version: 3,
+    });
+    const view = mapCatalogRoleToView(catalogRole(), [installed], "en");
+    expect(view).toMatchObject({
+      status: "installed",
+      version: 3,
+      installedRoleId: installed.id,
+    });
+  });
+
+  it("update -> version=from, newVersion=to, installedRoleId", () => {
+    const installed = installedRole({
+      slug: "writer",
+      language: "en",
+      version: 1,
+    });
+    const view = mapCatalogRoleToView(catalogRole(), [installed], "en");
+    expect(view).toMatchObject({
+      status: "update",
+      version: 1,
+      newVersion: 3,
+      installedRoleId: installed.id,
+    });
+  });
+
+  it("missing emoji -> emoji undefined; null description -> empty string", () => {
+    const view = mapCatalogRoleToView(
+      catalogRole({ emoji: null, description: null }),
+      [],
+      "en",
+    );
+    expect(view.emoji).toBeUndefined();
+    expect(view.description).toBe("");
+  });
+});
+
+describe("mapBundleRolesToView", () => {
+  it("maps a bundle's roles preserving order", () => {
+    const roles = [
+      catalogRole({ slug: "a", name: "A", version: 1 }),
+      catalogRole({ slug: "b", name: "B", version: 1 }),
+    ];
+    const installed = [installedRole({ slug: "a", language: "en", version: 1 })];
+    const view = mapBundleRolesToView(roles, installed, "en");
+    expect(view.map((r) => r.slug)).toEqual(["a", "b"]);
+    expect(view[0].status).toBe("installed");
+    expect(view[1].status).toBe("import");
+  });
+});

apps/client/src/features/ai-chat/utils/catalog-bundle-model.ts

@@ -0,0 +1,206 @@
+import type {
+  IAiRole,
+  IAiRoleCatalogRole,
+} from "@/features/ai-chat/types/ai-chat.types.ts";
+import { catalogRoleInstallState } from "@/features/ai-chat/utils/catalog-role-install-state.ts";
+
+/**
+ * The redesigned catalog modal renders bundles as cards with a summary status
+ * (readable without expanding) and a single primary action. The per-role and
+ * per-bundle view model that drives that UI is derived here as PURE functions so
+ * the mapping, the "installed in another language" hint, and the bundle-phase
+ * computation are unit-testable without mounting the component (mirrors the
+ * `catalogRoleInstallState` precedent).
+ */
+
+/**
+ * A role's status in the catalog view model.
+ *  - `import`    — not installed in the current content language.
+ *  - `installed` — installed and up to date.
+ *  - `update`    — installed, but the catalog ships a newer version.
+ *  - `skipped`   — TRANSIENT client-only status set after a conflicted import
+ *                  (a name collision under `conflict:'skip'`); never from the
+ *                  backend.
+ */
+export type RoleStatus = "import" | "installed" | "update" | "skipped";
+
+/** A catalog role mapped into the modal's view model. */
+export interface CatalogViewRole {
+  // Slug is the stable identity within a bundle; used as the row key and as the
+  // `slugs[]` payload for import.
+  slug: string;
+  // Optional in the catalog — the row reserves space and renders nothing when
+  // absent.
+  emoji?: string;
+  name: string;
+  description: string;
+  // For `installed`/`import`: the catalog version. For `update`: the installed
+  // (from) version, with `newVersion` holding the catalog (to) version.
+  version: number;
+  newVersion?: number;
+  status: RoleStatus;
+  // The language a same-slug role is installed under, when it differs from the
+  // current content language (drives the Р5 hint). Only set for `import` roles.
+  installedLang?: string;
+  // The workspace role id, present for `installed`/`update` — needed to call the
+  // update-from-catalog mutation.
+  installedRoleId?: string;
+}
+
+/**
+ * The summary phase of a bundle, derived from its roles' statuses. Determines
+ * the collapsed-header summary and the bundle's single primary action.
+ *  - `empty`        — the bundle has no roles.
+ *  - `allNew`       — everything is importable, nothing installed.
+ *  - `allInstalled` — everything installed & up to date; nothing else pending.
+ *  - `updates`      — updates available and nothing left to import.
+ *  - `mixed`        — any other combination.
+ */
+export type BundlePhase =
+  | "empty"
+  | "allNew"
+  | "allInstalled"
+  | "updates"
+  | "mixed";
+
+/** Per-status tallies for a bundle's roles (the single source of truth). */
+export interface BundleCounts {
+  importable: number;
+  installed: number;
+  update: number;
+  skipped: number;
+}
+
+/**
+ * Count a bundle's roles by status ONCE. Both `bundlePhase` and the panel derive
+ * from this, so the tally logic lives in exactly one place (no rescans / drift).
+ */
+export function bundleCounts(roles: CatalogViewRole[]): BundleCounts {
+  const counts: BundleCounts = {
+    importable: 0,
+    installed: 0,
+    update: 0,
+    skipped: 0,
+  };
+  for (const r of roles) {
+    if (r.status === "import") counts.importable += 1;
+    else if (r.status === "installed") counts.installed += 1;
+    else if (r.status === "update") counts.update += 1;
+    else if (r.status === "skipped") counts.skipped += 1;
+  }
+  return counts;
+}
+
+export function bundlePhase(roles: CatalogViewRole[]): BundlePhase {
+  if (roles.length === 0) return "empty";
+  const { importable, installed, update, skipped } = bundleCounts(roles);
+  // A `skipped` role is a pending post-import conflict (0 installed for it), so a
+  // bundle that has ANY skipped role is NOT "all installed & up to date" — that
+  // would make the collapsed green "up to date" header contradict the open
+  // panel's "Installed 0 · 1 skipped" plaque. It is `mixed` until resolved.
+  if (importable === 0 && update === 0 && skipped === 0) return "allInstalled";
+  if (update > 0 && importable === 0 && skipped === 0) return "updates";
+  if (importable > 0 && installed === 0 && update === 0 && skipped === 0)
+    return "allNew";
+  return "mixed";
+}
+
+/**
+ * The subset of a skip result that should be shown as a TRANSIENT `skipped`
+ * overlay in the bundle (so the row offers a re-import path). Only NAME-CONFLICT
+ * skips qualify: an `already-installed` skip (a concurrent-import race) has
+ * nothing to act on — re-importing the same slug would just skip again — so it
+ * must NOT be overlaid (else the row shows a misleading "Rename & install" that
+ * self-heals into a false "installed"). Pure so both reason branches are tested.
+ */
+export function nameConflictSlugs(
+  skipped: { slug: string; reason: "name-conflict" | "already-installed" }[],
+): string[] {
+  return skipped
+    .filter((s) => s.reason === "name-conflict")
+    .map((s) => s.slug);
+}
+
+/**
+ * Whether a partial-import result should offer the "Rename & install" action:
+ * only when at least one skip is a name conflict (renameable). An
+ * `already-installed`-only partial is informational.
+ */
+export function partialOffersRename(
+  skipped: { reason: "name-conflict" | "already-installed" }[],
+): boolean {
+  return skipped.some((s) => s.reason === "name-conflict");
+}
+
+/**
+ * For a role NOT installed in the current `language`, find a workspace role with
+ * the same catalog `slug` installed under a DIFFERENT language, and return that
+ * language. Drives the "installed in another language" hint (Р5): a different
+ * language of the same slug is a separate install and appears as `import`.
+ */
+export function installedLangForRole(
+  slug: string,
+  workspaceRoles: IAiRole[],
+  language: string,
+): string | undefined {
+  const other = workspaceRoles.find(
+    (r) =>
+      r.source?.slug === slug &&
+      !!r.source?.language &&
+      r.source.language !== language,
+  );
+  return other?.source?.language;
+}
+
+/**
+ * Map one catalog role to the view model, computing its install status against
+ * the workspace roles (via `catalogRoleInstallState`) and, for importable roles,
+ * the other-language hint.
+ */
+export function mapCatalogRoleToView(
+  role: IAiRoleCatalogRole,
+  workspaceRoles: IAiRole[],
+  language: string,
+): CatalogViewRole {
+  const state = catalogRoleInstallState(role, workspaceRoles, language);
+  const base = {
+    slug: role.slug,
+    emoji: role.emoji ?? undefined,
+    name: role.name,
+    description: role.description ?? "",
+  };
+  if (state.state === "update") {
+    return {
+      ...base,
+      status: "update",
+      version: state.fromVersion,
+      newVersion: state.toVersion,
+      installedRoleId: state.installed.id,
+    };
+  }
+  if (state.state === "installed") {
+    return {
+      ...base,
+      status: "installed",
+      version: role.version,
+      installedRoleId: state.installed.id,
+    };
+  }
+  return {
+    ...base,
+    status: "import",
+    version: role.version,
+    installedLang: installedLangForRole(role.slug, workspaceRoles, language),
+  };
+}
+
+/**
+ * Map a whole bundle's catalog roles to the view model, preserving order.
+ */
+export function mapBundleRolesToView(
+  roles: IAiRoleCatalogRole[],
+  workspaceRoles: IAiRole[],
+  language: string,
+): CatalogViewRole[] {
+  return roles.map((r) => mapCatalogRoleToView(r, workspaceRoles, language));
+}

apps/client/src/features/ai-chat/utils/resume-helpers.test.ts

@@ -0,0 +1,112 @@
+import { describe, it, expect } from "vitest";
+import type { UIMessage } from "@ai-sdk/react";
+import type { IAiChatMessageRow } from "@/features/ai-chat/types/ai-chat.types.ts";
+import {
+  isStreamingTail,
+  isSettledAssistantTail,
+  seedRows,
+  mergeById,
+} from "./resume-helpers.ts";
+
+function row(
+  id: string,
+  role: string,
+  status?: string,
+): IAiChatMessageRow {
+  return { id, role, content: "", status, createdAt: "2026-01-01T00:00:00Z" };
+}
+
+function makeMsg(id: string, text: string): UIMessage {
+  return {
+    id,
+    role: "assistant",
+    parts: [{ type: "text", text }],
+  } as UIMessage;
+}
+
+describe("isStreamingTail", () => {
+  it("is true when the last row is a streaming assistant row", () => {
+    expect(
+      isStreamingTail([row("u1", "user"), row("a1", "assistant", "streaming")]),
+    ).toBe(true);
+  });
+
+  it("is false for a settled assistant tail", () => {
+    expect(isStreamingTail([row("a1", "assistant", "succeeded")])).toBe(false);
+    expect(isStreamingTail([row("a1", "assistant")])).toBe(false);
+  });
+
+  it("is false when the tail is a user row or the list is empty", () => {
+    expect(isStreamingTail([row("u1", "user")])).toBe(false);
+    expect(isStreamingTail([])).toBe(false);
+  });
+});
+
+describe("isSettledAssistantTail", () => {
+  it("is true for an assistant tail whose status is not streaming", () => {
+    expect(isSettledAssistantTail([row("a1", "assistant", "succeeded")])).toBe(
+      true,
+    );
+    expect(isSettledAssistantTail([row("a1", "assistant")])).toBe(true);
+    expect(isSettledAssistantTail([row("a1", "assistant", "aborted")])).toBe(
+      true,
+    );
+  });
+
+  it("is false for a streaming assistant tail", () => {
+    expect(isSettledAssistantTail([row("a1", "assistant", "streaming")])).toBe(
+      false,
+    );
+  });
+
+  it("is false when the tail is a user row or the list is empty", () => {
+    expect(isSettledAssistantTail([row("u1", "user")])).toBe(false);
+    expect(isSettledAssistantTail([])).toBe(false);
+  });
+});
+
+describe("seedRows", () => {
+  const rows = [row("u1", "user"), row("a1", "assistant", "streaming")];
+
+  it("returns the rows unchanged when not stripping", () => {
+    expect(seedRows(rows, false)).toBe(rows);
+  });
+
+  it("drops the last row when stripping", () => {
+    const seeded = seedRows(rows, true);
+    expect(seeded).toHaveLength(1);
+    expect(seeded[0].id).toBe("u1");
+  });
+
+  it("returns an empty list when stripping a single-row list", () => {
+    expect(seedRows([row("a1", "assistant", "streaming")], true)).toHaveLength(
+      0,
+    );
+  });
+});
+
+describe("mergeById", () => {
+  it("replaces the message with the same id in place (per-step growth)", () => {
+    const prev = [makeMsg("u1", "hi"), makeMsg("a1", "step 1")];
+    const incoming = makeMsg("a1", "step 1\nstep 2");
+    const next = mergeById(prev, incoming);
+    expect(next).toHaveLength(2);
+    expect(next[1]).toBe(incoming);
+    expect(next[0]).toBe(prev[0]); // untouched
+    expect(next).not.toBe(prev); // new array (never mutates input)
+  });
+
+  it("appends when the incoming message is not yet present", () => {
+    const prev = [makeMsg("u1", "hi")];
+    const incoming = makeMsg("a1", "first token");
+    const next = mergeById(prev, incoming);
+    expect(next).toHaveLength(2);
+    expect(next[1]).toBe(incoming);
+  });
+
+  it("returns the original list unchanged when there is nothing to merge", () => {
+    const prev = [makeMsg("u1", "hi")];
+    expect(mergeById(prev, null)).toBe(prev);
+    expect(mergeById(prev, undefined)).toBe(prev);
+  });
+});

apps/client/src/features/ai-chat/utils/resume-helpers.ts

@@ -0,0 +1,62 @@
+import type { UIMessage } from "@ai-sdk/react";
+import type { IAiChatMessageRow } from "@/features/ai-chat/types/ai-chat.types.ts";
+
+/**
+ * Pure decisions for the resumable-SSE resume machinery (#184 phase 1.5). A tab
+ * that reopens a chat whose agent run is still going attaches to the server's
+ * run-stream registry (replay + live tail) instead of polling snapshots; these
+ * small predicates decide WHICH tail is safe to resume and how to seed the store,
+ * extracted so they can be unit-tested in isolation.
+ */
+
+/**
+ * A STREAMING tail: the last persisted row is an assistant row still marked
+ * `status === 'streaming'`. Such a tail is stripped from the seed and rebuilt by
+ * the replay (`expect=live`), since the SDK's `text-start` always pushes a new
+ * part and replaying over a seeded in-progress row would duplicate its text.
+ */
+export function isStreamingTail(rows: IAiChatMessageRow[]): boolean {
+  const tail = rows[rows.length - 1];
+  return !!tail && tail.role === "assistant" && tail.status === "streaming";
+}
+
+/**
+ * A SETTLED assistant tail: the last row is an assistant row whose status is
+ * anything OTHER than 'streaming'. A settled assistant tail must NEVER resume —
+ * replaying a finished run into a store that already holds its message duplicates
+ * parts (`text-start` always pushes a new part).
+ */
+export function isSettledAssistantTail(rows: IAiChatMessageRow[]): boolean {
+  const tail = rows[rows.length - 1];
+  return !!tail && tail.role === "assistant" && tail.status !== "streaming";
+}
+
+/**
+ * Seed rows for `useChat`: return the rows unchanged, or without the last row when
+ * `strip` is set (the streaming tail is stripped so the live replay rebuilds it
+ * without duplicating parts).
+ */
+export function seedRows(
+  rows: IAiChatMessageRow[],
+  strip: boolean,
+): IAiChatMessageRow[] {
+  return strip ? rows.slice(0, -1) : rows;
+}
+
+/**
+ * Merge an assistant message into the rendered list by id: replace the message
+ * with the same id in place (the in-progress assistant row is already seeded from
+ * history, so per-step growth replaces it), or append it when absent. Returns a
+ * new array; the input is never mutated.
+ */
+export function mergeById(
+  messages: UIMessage[],
+  incoming: UIMessage | null | undefined,
+): UIMessage[] {
+  if (!incoming) return messages;
+  const idx = messages.findIndex((m) => m.id === incoming.id);
+  if (idx === -1) return [...messages, incoming];
+  const next = messages.slice();
+  next[idx] = incoming;
+  return next;
+}

apps/client/src/features/ai-chat/utils/tool-parts.test.tsx

@@ -1,6 +1,7 @@
 import { describe, it, expect } from "vitest";
 import {
   toolCitations,
+  toolInputSummary,
   toolRunState,
   type ToolUiPart,
 } from "./tool-parts";
@@ -77,6 +78,138 @@ describe("toolCitations", () => {
   });
 });
 
+describe("toolInputSummary", () => {
+  it("returns the primary `query` string", () => {
+    const part: ToolUiPart = {
+      type: "tool-Search_web_search",
+      state: "input-available",
+      input: { query: "hello world" },
+    };
+    expect(toolInputSummary(part)).toBe("hello world");
+  });
+
+  it("summarizes a primary array field with a (+N) suffix", () => {
+    // `urls` is an external MCP read_pages-style list; the first element plus a
+    // count of the rest.
+    const part: ToolUiPart = {
+      type: "tool-read_pages",
+      state: "input-available",
+      input: { urls: ["a", "b", "c"] },
+    };
+    expect(toolInputSummary(part)).toBe("a (+2)");
+  });
+
+  it("omits the (+N) suffix for a single-element array", () => {
+    const part: ToolUiPart = {
+      type: "tool-read_pages",
+      state: "input-available",
+      input: { urls: ["only"] },
+    };
+    expect(toolInputSummary(part)).toBe("only");
+  });
+
+  it("falls back to `title` for a page op with no query", () => {
+    const part: ToolUiPart = {
+      type: "tool-createPage",
+      state: "input-available",
+      input: { pageId: "x", title: "My Page" },
+    };
+    expect(toolInputSummary(part)).toBe("My Page");
+  });
+
+  it("prefers the earlier primary field when several are present", () => {
+    const part: ToolUiPart = {
+      type: "tool-x",
+      state: "input-available",
+      // `query` outranks `title` in PRIMARY_INPUT_FIELDS — the ordered list is
+      // the contract, so a reordering must break this test.
+      input: { query: "Q", title: "T" },
+    };
+    expect(toolInputSummary(part)).toBe("Q");
+  });
+
+  it("does not clamp a value exactly at the 140-char limit", () => {
+    const exact = "a".repeat(140);
+    const part: ToolUiPart = {
+      type: "tool-Search_web_search",
+      state: "input-available",
+      input: { query: exact },
+    };
+    const out = toolInputSummary(part)!;
+    expect(out).toBe(exact);
+    expect(out.endsWith("…")).toBe(false);
+    expect(out.length).toBe(140);
+  });
+
+  it("clamps one char over the limit (141 -> 140 + ellipsis)", () => {
+    const part: ToolUiPart = {
+      type: "tool-Search_web_search",
+      state: "input-available",
+      input: { query: "a".repeat(141) },
+    };
+    const out = toolInputSummary(part)!;
+    expect(out.endsWith("…")).toBe(true);
+    expect(out.length).toBe(141);
+    expect(out).toBe("a".repeat(140) + "…");
+  });
+
+  it("clamps a long value to ~140 chars with an ellipsis", () => {
+    const long = "a".repeat(300);
+    const part: ToolUiPart = {
+      type: "tool-Search_web_search",
+      state: "input-available",
+      input: { query: long },
+    };
+    const out = toolInputSummary(part)!;
+    expect(out.endsWith("…")).toBe(true);
+    expect(out.length).toBeLessThanOrEqual(141);
+  });
+
+  it("collapses newlines and repeated spaces to single spaces", () => {
+    const part: ToolUiPart = {
+      type: "tool-Search_web_search",
+      state: "input-available",
+      input: { query: "  foo\n\n  bar   baz  " },
+    };
+    expect(toolInputSummary(part)).toBe("foo bar baz");
+  });
+
+  it("returns undefined with no input", () => {
+    expect(
+      toolInputSummary({ type: "tool-x", state: "input-available" }),
+    ).toBeUndefined();
+  });
+
+  it("returns undefined for an empty object input", () => {
+    expect(
+      toolInputSummary({
+        type: "tool-x",
+        state: "input-available",
+        input: {},
+      }),
+    ).toBeUndefined();
+  });
+
+  it("returns undefined for a non-object input", () => {
+    expect(
+      toolInputSummary({
+        type: "tool-x",
+        state: "input-available",
+        input: "just a string",
+      }),
+    ).toBeUndefined();
+  });
+
+  it("returns undefined while the input is still streaming (even with a full input)", () => {
+    const part: ToolUiPart = {
+      type: "tool-Search_web_search",
+      state: "input-streaming",
+      input: { query: "hello world" },
+    };
+    expect(toolInputSummary(part)).toBeUndefined();
+  });
+});
+
 describe("toolRunState", () => {
   it('maps "output-error" to error', () => {
     expect(toolRunState("output-error")).toBe("error");

apps/client/src/features/ai-chat/utils/tool-parts.tsx

@@ -97,6 +97,69 @@ function asString(value: unknown): string | undefined {
   return typeof value === "string" && value.length > 0 ? value : undefined;
 }
 
+/** Collapse runs of whitespace/newlines to a single space and trim. */
+function collapse(s: string): string {
+  return s.replace(/\s+/g, " ").trim();
+}
+
+/** Truncate to ~140 chars, appending an ellipsis when it overflows. */
+function clamp(s: string): string {
+  const MAX = 140;
+  return s.length > MAX ? s.slice(0, MAX).trimEnd() + "…" : s;
+}
+
+/**
+ * Priority "primary" argument fields, in order. The first present one supplies
+ * the summary. `urls` is included (external MCP `read_pages`-style tools take a
+ * list of URLs) and is handled as an array; `url` covers the single-URL form.
+ */
+const PRIMARY_INPUT_FIELDS = [
+  "query",
+  "q",
+  "searchQuery",
+  "url",
+  "urls",
+  "title",
+  "name",
+  "text",
+  "prompt",
+] as const;
+
+/**
+ * A short, PLAIN-TEXT one-line summary of a tool call's arguments (e.g. the
+ * search query), or undefined when no recognizable primary field is present.
+ * Rendered under the tool label so tools without a friendly name (external MCP
+ * tools like `Search_web_search`) still show WHAT was requested, not just a
+ * generic "Ran tool {{name}}". The returned string is plain text and MUST be
+ * rendered React-escaped (Mantine `<Text>`), never as markdown/HTML.
+ *
+ * Streaming gate: while `state === "input-streaming"` the `input` object grows
+ * chunk by chunk but `messageSignature` deliberately does NOT track `input`, so
+ * a live summary computed here would freeze at its first captured value and go
+ * stale. We therefore return undefined until the state flips to
+ * `input-available` (input finalized) — that state change IS tracked by the
+ * signature, so the row re-renders and shows the complete summary. Do NOT add
+ * `input` to `message-signature.ts` to work around this.
+ */
+export function toolInputSummary(part: ToolUiPart): string | undefined {
+  if (part.state === "input-streaming") return undefined;
+  if (!part.input || typeof part.input !== "object") return undefined;
+  const input = part.input as Record<string, unknown>;
+
+  for (const field of PRIMARY_INPUT_FIELDS) {
+    const value = input[field];
+    if (typeof value === "string" && value.length > 0) {
+      return clamp(collapse(value));
+    }
+    if (Array.isArray(value) && value.length > 0) {
+      const first = collapse(String(value[0]));
+      if (first.length === 0) continue;
+      return clamp(first + (value.length > 1 ? ` (+${value.length - 1})` : ""));
+    }
+  }
+  return undefined;
+}
+
 /**
  * Resolve the page citation(s) a tool part references, from its input/output.
  * Only output-available parts (the tool returned) yield citations. Search

apps/client/src/features/editor/gitmost/gitmost-global-bridge.tsx

@@ -24,6 +24,7 @@ import {
   GitmostListPagesResult,
   GitmostListSpacesResult,
   gitmostDecodePayloadToFile,
+  gitmostInsertTranscriptIntoEditor,
   gitmostUploadFileToEditor,
 } from "@/features/editor/gitmost/gitmost-recording.ts";
 
@@ -281,6 +282,18 @@ export default function GitmostGlobalBridge() {
             pageId: page.id,
           };
         }
+
+        // Best-effort: append the transcript (heading + one paragraph per line)
+        // below the just-inserted audio node. The audio insert already
+        // succeeded, so a transcript failure must NOT turn this into an error —
+        // wrap it and, on any throw, log and still return ok. A missing/empty/
+        // non-string transcript is a no-op inside the helper (audio only).
+        try {
+          gitmostInsertTranscriptIntoEditor(editor, payload?.transcript);
+        } catch (err) {
+          console.error("[gitmost] transcript insert failed", err);
+        }
+
         return { ok: true, pageId: page.id };
       } catch (err: any) {
         console.error("[gitmost] createPageWithRecording failed", err);

apps/client/src/features/editor/gitmost/gitmost-recording.test.ts

@@ -0,0 +1,150 @@
+import { describe, it, expect } from "vitest";
+import { Editor } from "@tiptap/core";
+import { Document } from "@tiptap/extension-document";
+import { Paragraph } from "@tiptap/extension-paragraph";
+import { Text } from "@tiptap/extension-text";
+import { Heading } from "@tiptap/extension-heading";
+import { Bold } from "@tiptap/extension-bold";
+import { Italic } from "@tiptap/extension-italic";
+import { Link } from "@tiptap/extension-link";
+import { gitmostInsertTranscriptIntoEditor } from "./gitmost-recording.ts";
+
+const ZWSP = "​"; // U+200B, the helper's block-trigger neutralizer
+
+/**
+ * #377 — the web-side bridge must append the native host's transcript below the
+ * recording. These exercise the pure insert helper through a REAL Tiptap editor
+ * (Document/Paragraph/Text/Heading + Bold/Italic/Link marks so an HTML-parsing
+ * regression would be caught), asserting the resulting document rather than
+ * mocking the editor: transcript present -> "Transcript" heading + one paragraph
+ * per non-empty line; content is inserted as LITERAL TEXT (no HTML/markdown
+ * parsing); col-0 markdown block triggers are neutralized so git-sync keeps them
+ * paragraphs; absent/empty/non-string -> no-op.
+ */
+describe("gitmostInsertTranscriptIntoEditor", () => {
+  const makeEditor = () =>
+    new Editor({
+      // Bold/Italic/Link are registered specifically so that IF the helper ever
+      // regressed to inserting an HTML/markdown string (instead of a text node),
+      // TipTap would parse `<b>`/`*..*`/`[..](..)` into marks and the literal-
+      // text assertions below would fail.
+      extensions: [Document, Paragraph, Text, Heading, Bold, Italic, Link],
+      // Start from a single empty paragraph (a fresh page's baseline). The
+      // helper appends at the end of the doc, i.e. below existing content.
+      content: { type: "doc", content: [{ type: "paragraph" }] },
+    });
+
+  it("inserts a Transcript heading + one paragraph per non-empty line, verbatim", () => {
+    const editor = makeEditor();
+
+    const inserted = gitmostInsertTranscriptIntoEditor(
+      editor,
+      "You: hello there\nSpeaker 1: hi\n\nYou: bye",
+    );
+
+    expect(inserted).toBe(true);
+
+    const nodes = (editor.getJSON().content ?? []) as any[];
+    // A level-2 "Transcript" heading is present.
+    const heading = nodes.find((n) => n.type === "heading");
+    expect(heading?.attrs?.level).toBe(2);
+    expect(heading?.content?.[0]?.text).toBe("Transcript");
+
+    // Every non-empty transcript line becomes a paragraph, in order, verbatim;
+    // the blank line between them is dropped.
+    const texts = nodes
+      .filter((n) => n.type === "paragraph")
+      .map((n) => n.content?.[0]?.text)
+      .filter((t) => typeof t === "string");
+    expect(texts).toEqual(["You: hello there", "Speaker 1: hi", "You: bye"]);
+
+    editor.destroy();
+  });
+
+  it("inserts HTML + markdown metacharacters as LITERAL text (no injection / no mark parsing)", () => {
+    const editor = makeEditor();
+    const line =
+      "You: <b>bold</b> <script>alert(1)</script> and *stars* and [link](x)";
+
+    const inserted = gitmostInsertTranscriptIntoEditor(editor, line);
+    expect(inserted).toBe(true);
+
+    const paras = (editor.getJSON().content ?? []).filter(
+      (n: any) => n.type === "paragraph",
+    ) as any[];
+    // The transcript line is exactly ONE paragraph holding a SINGLE text node
+    // whose text is the verbatim string — not split into bold/link/other nodes,
+    // not carrying any marks, not raw HTML. This FAILS if the helper switched to
+    // insertContent(htmlString): TipTap would then parse <b>/[link](x)/*stars*.
+    const content = paras[paras.length - 1].content;
+    expect(content).toHaveLength(1);
+    expect(content[0].type).toBe("text");
+    expect(content[0].marks ?? []).toEqual([]);
+    expect(content[0].text).toBe(line);
+    // And no bold/italic/link mark exists anywhere in the document.
+    const html = editor.getHTML();
+    expect(html).not.toMatch(/<(strong|b|em|i|a)\b/);
+    // The angle brackets survived as escaped entities (literal text), not a live
+    // <script>/<b> element.
+    expect(html).not.toMatch(/<script/i);
+
+    editor.destroy();
+  });
+
+  it("neutralizes col-0 markdown block triggers with a leading ZWSP (git-sync safety)", () => {
+    const editor = makeEditor();
+    // Trigger lines (some with a leaked indent) + a normal prefixed line.
+    const inserted = gitmostInsertTranscriptIntoEditor(
+      editor,
+      [
+        "- dash",
+        "  > quote", // leading indent must be trimmed then neutralized
+        "# hash",
+        "1. one",
+        "> [!info] note",
+        "```js",
+        "---", // solid thematic break -> horizontalRule (text-losing) if unneutralized
+        "***",
+        "___",
+        "You: normal line",
+      ].join("\n"),
+    );
+    expect(inserted).toBe(true);
+
+    const texts = (editor.getJSON().content ?? [])
+      .filter((n: any) => n.type === "paragraph")
+      .map((n: any) => n.content?.[0]?.text)
+      .filter((t: any) => typeof t === "string") as string[];
+
+    // Every block-trigger line is prefixed with the invisible ZWSP (indent
+    // trimmed first); the normal `You:` line is left byte-exact.
+    expect(texts).toEqual([
+      ZWSP + "- dash",
+      ZWSP + "> quote",
+      ZWSP + "# hash",
+      ZWSP + "1. one",
+      ZWSP + "> [!info] note",
+      ZWSP + "```js",
+      ZWSP + "---",
+      ZWSP + "***",
+      ZWSP + "___",
+      "You: normal line",
+    ]);
+
+    editor.destroy();
+  });
+
+  it("is a no-op for undefined / empty / whitespace-only / non-string transcripts", () => {
+    for (const value of [undefined, "", "   \n  \n", 42, {}, null]) {
+      const editor = makeEditor();
+      const before = JSON.stringify(editor.getJSON());
+
+      const inserted = gitmostInsertTranscriptIntoEditor(editor, value as any);
+
+      expect(inserted).toBe(false);
+      // Document is untouched (audio-only behavior preserved).
+      expect(JSON.stringify(editor.getJSON())).toBe(before);
+      editor.destroy();
+    }
+  });
+});

apps/client/src/features/editor/gitmost/gitmost-recording.ts

@@ -65,6 +65,11 @@ export interface GitmostCreatePagePayload {
   base64: string;
   filename: string;
   mimeType: string;
+  // Optional transcript for the recording: plain text, `\n`-separated, each
+  // line already formatted as `You: ...` / `Speaker N: ...` by the native host
+  // (ready to insert, no parsing needed). Omitted (no speech / no models) ->
+  // audio only.
+  transcript?: string;
 }
 
 export interface GitmostCreatePageResult {
@@ -235,6 +240,83 @@ export async function gitmostUploadFileToEditor(
   }
 }
 
+// Zero-width space (U+200B). Prepended to a transcript line that begins with a
+// markdown BLOCK trigger: it is invisible in the rendered doc but shifts the
+// trigger off column 0, so the git-sync doc->markdown->doc round-trip keeps the
+// line a plain paragraph (see GITMOST_MD_BLOCK_TRIGGER_RE).
+const GITMOST_ZWSP = "​";
+
+// A markdown BLOCK-level construct that, sitting at column 0 of a paragraph
+// line, the git-sync markdown serializer (packages/prosemirror-markdown
+// markdown-converter.ts, `case "paragraph"`) would re-parse into a NON-paragraph
+// block on the doc->markdown->doc cycle. That serializer emits paragraph text
+// verbatim with NO block-escape (the pre-existing root cause), so a leading
+// `#`/`-`/`*`/`+`/`>`, an ordered-list `N.`/`N)`, a code fence ```/~~~, a table
+// `|`, or a `> [!info]` callout opener would silently become a heading / list /
+// quote / code block / table / callout. The final alternative matches a WHOLE-
+// LINE thematic break — solid `---`/`***`/`___` or spaced `- - -`/`_ _ _` (3+ of
+// the same `-`/`*`/`_`) — which round-trips into a `horizontalRule`; because
+// that node carries NO text, an un-neutralized separator line would LOSE its
+// text entirely (worse than the list/quote case). This matches a TRIMMED line's
+// start; the transcript's own `You:` / `Speaker N:` prefix begins with a letter
+// and never matches, so prefixed lines are left byte-exact.
+const GITMOST_MD_BLOCK_TRIGGER_RE =
+  /^(?:#{1,6}(?:\s|$)|[-*+](?:\s|$)|>|\d+[.)](?:\s|$)|```|~~~|\||([-*_])(?:\s*\1){2,}\s*$)/;
+
+// Append a transcript block BELOW the recording's audio node in a live editor:
+// a "Transcript" heading followed by one paragraph per non-empty transcript
+// line. The transcript is plain text, `\n`-separated, each line already
+// formatted as `You: ...` / `Speaker N: ...` by the native host — line text is
+// inserted as a TEXT node (never HTML/markdown), so there is no injection or
+// mark-parsing surface. Each kept line is trimmed (drops an indent that would
+// both leak into the display and, at col 0, form a markdown block trigger) and,
+// if it still begins with a col-0 markdown block trigger, gets an invisible
+// zero-width space prepended so the git-sync round-trip cannot turn it into a
+// list/quote/heading/callout/code/table (defensive boundary against the
+// serializer's missing block-escape). This is best-effort and meant to run
+// AFTER the audio has already been inserted; the caller must guard against a
+// throw so a transcript failure never fails the (already successful) recording.
+// Returns true when a block was inserted, false when there was nothing to
+// insert (transcript undefined/empty/not-a-string). A non-string value is a
+// no-op, not an error.
+export function gitmostInsertTranscriptIntoEditor(
+  editor: Editor,
+  transcript: unknown,
+): boolean {
+  if (typeof transcript !== "string") return false;
+  const lines = transcript
+    .split("\n")
+    // Trim each line and drop blank (whitespace-only) ones.
+    .map((line) => line.trim())
+    .filter((line) => line.length > 0)
+    // Neutralize a col-0 markdown block trigger with an invisible ZWSP so the
+    // git-sync round-trip keeps the line a paragraph. Host lines (`You:` /
+    // `Speaker N:`) never match and stay byte-exact.
+    .map((line) =>
+      GITMOST_MD_BLOCK_TRIGGER_RE.test(line) ? GITMOST_ZWSP + line : line,
+    );
+  if (lines.length === 0) return false;
+
+  const content = [
+    {
+      type: "heading",
+      attrs: { level: 2 },
+      content: [{ type: "text", text: "Transcript" }],
+    },
+    ...lines.map((line) => ({
+      type: "paragraph",
+      content: [{ type: "text", text: line }],
+    })),
+  ];
+
+  // Append at the end of the document. On a freshly-created recording page the
+  // audio node is the last block, so the end position places the transcript
+  // directly below it.
+  const endPos = editor.state.doc.content.size;
+  editor.chain().focus().insertContentAt(endPos, content).run();
+  return true;
+}
+
 // Full insert path used by the open-page bridge (insertRecording): guard the
 // editor, validate/decode the payload, then upload. Never throws — resolves to
 // a result code.

apps/client/src/features/editor/page-editor.tsx

@@ -93,6 +93,11 @@ import {
   isBodyEditable,
   isCollabSynced,
 } from "@/features/editor/editor-sync-state";
+import {
+  isVitalsActive,
+  measurePageOpen,
+  reportEditorTx,
+} from "@/lib/telemetry/vitals";
 
 interface PageEditorProps {
   pageId: string;
@@ -351,6 +356,40 @@ export default function PageEditor({
           editor.storage.pageId = pageId;
           handleScrollTo(editor);
           editorRef.current = editor;
+
+          // #355 — perf instrumentation. Skip ALL of it when telemetry is
+          // disabled (F1 flag off) or this session isn't sampled: no page-open
+          // measure, and crucially NO dispatch wrapping, so a non-collecting
+          // session pays zero per-transaction cost.
+          if (isVitalsActive()) {
+            // page_open_ms: this is the first editor-content render, so measure
+            // against any page-open mark set on the tree-row/link click.
+            measurePageOpen();
+
+            // editor_tx_ms: time the SYNCHRONOUS part of applying each
+            // transaction (state.apply + updateState) by wrapping the view's
+            // dispatch. Only slow syncs (>8ms) are reported (see reportEditorTx),
+            // so the common path adds just one performance.now() pair. Passive:
+            // the original dispatch still runs unchanged.
+            try {
+              const view = editor.view as unknown as {
+                dispatch: (tr: unknown) => void;
+              };
+              const originalDispatch = view.dispatch.bind(view);
+              view.dispatch = (tr: unknown) => {
+                const started = performance.now();
+                originalDispatch(tr);
+                const elapsed = performance.now() - started;
+                try {
+                  reportEditorTx(elapsed, editor.state.doc.content.size);
+                } catch {
+                  // never let telemetry break editing
+                }
+              };
+            } catch {
+              // if the view shape changes, skip editor_tx instrumentation
+            }
+          }
         }
       },
       onUpdate({ editor }) {

apps/client/src/features/editor/utils/get-editor-selection.test.ts

@@ -0,0 +1,113 @@
+import { describe, it, expect } from "vitest";
+import { Editor } from "@tiptap/core";
+import { Document } from "@tiptap/extension-document";
+import { Paragraph } from "@tiptap/extension-paragraph";
+import { Text } from "@tiptap/extension-text";
+import { EditorState, TextSelection } from "@tiptap/pm/state";
+import type { Node as PMNode } from "@tiptap/pm/model";
+import { UniqueID } from "@docmost/editor-ext";
+import { getEditorSelectionContext } from "./get-editor-selection";
+
+/**
+ * Unit tests for getEditorSelectionContext (#388). Built on a headless
+ * ProseMirror schema (Document + Paragraph + Text + the block-id UniqueID
+ * extension), mirroring the editor-ext test style. We assemble docs with
+ * explicit block ids so the covered-blockIds assertions are deterministic.
+ */
+
+// A schema that carries the `id` block attribute (UniqueID) on paragraphs, just
+// like the real editor.
+const { schema } = new Editor({
+  extensions: [
+    Document,
+    Paragraph,
+    Text,
+    UniqueID.configure({ types: ["paragraph"] }),
+  ],
+  content: "",
+});
+
+function docOf(blocks: { id: string; text: string }[]): PMNode {
+  return schema.node(
+    "doc",
+    null,
+    blocks.map((b) =>
+      schema.node("paragraph", { id: b.id }, b.text ? schema.text(b.text) : []),
+    ),
+  );
+}
+
+function stateWith(doc: PMNode, from: number, to: number): EditorState {
+  const base = EditorState.create({ schema, doc });
+  return base.apply(base.tr.setSelection(TextSelection.create(doc, from, to)));
+}
+
+// Select every text position of the doc (pos 1 .. content.size - 1).
+function selectAll(doc: PMNode): EditorState {
+  return stateWith(doc, 1, doc.content.size - 1);
+}
+
+describe("getEditorSelectionContext", () => {
+  it("returns null for an empty (collapsed) selection", () => {
+    const doc = docOf([{ id: "b1", text: "Hello world" }]);
+    const state = stateWith(doc, 3, 3); // caret, from === to
+    expect(getEditorSelectionContext(state)).toBeNull();
+  });
+
+  it("returns null for the default caret-at-start of a fresh editor", () => {
+    const editor = new Editor({
+      extensions: [
+        Document,
+        Paragraph,
+        Text,
+        UniqueID.configure({ types: ["paragraph"] }),
+      ],
+      content: "<p>fresh</p>",
+    });
+    expect(getEditorSelectionContext(editor.state)).toBeNull();
+    editor.destroy();
+  });
+
+  it("reads a single-paragraph selection with no block-separator artifacts", () => {
+    const doc = docOf([{ id: "b1", text: "Hello world" }]);
+    const sel = getEditorSelectionContext(selectAll(doc))!;
+    expect(sel.text).toBe("Hello world");
+    expect(sel.blockIds).toEqual(["b1"]);
+    expect(sel.truncated).toBeUndefined();
+  });
+
+  it("joins multiple blocks with a newline and collects all covered blockIds", () => {
+    const doc = docOf([
+      { id: "b1", text: "First" },
+      { id: "b2", text: "Second" },
+    ]);
+    const sel = getEditorSelectionContext(selectAll(doc))!;
+    expect(sel.text).toBe("First\nSecond");
+    expect(sel.blockIds).toEqual(["b1", "b2"]);
+  });
+
+  it("caps the text at 2000 chars and flags truncated", () => {
+    const doc = docOf([{ id: "b1", text: "x".repeat(2500) }]);
+    const sel = getEditorSelectionContext(selectAll(doc))!;
+    expect(sel.text).toHaveLength(2000);
+    expect(sel.truncated).toBe(true);
+  });
+
+  it("computes before/after context and clamps it to the doc bounds", () => {
+    // One paragraph "0123456789abcdefghij"; select the middle "56789".
+    const doc = docOf([{ id: "b1", text: "0123456789abcdefghij" }]);
+    // text char i lives at pos (1 + i); select chars index 5..9 -> pos 6..11.
+    const sel = getEditorSelectionContext(stateWith(doc, 6, 11))!;
+    expect(sel.text).toBe("56789");
+    expect(sel.before).toBe("01234");
+    expect(sel.after).toBe("abcdefghij");
+  });
+
+  it("omits before/after at the document boundaries (never reads past 0/size)", () => {
+    const doc = docOf([{ id: "b1", text: "Edge" }]);
+    const sel = getEditorSelectionContext(selectAll(doc))!;
+    // Selection spans the whole single block: nothing before or after it.
+    expect(sel.before).toBeUndefined();
+    expect(sel.after).toBeUndefined();
+  });
+});

apps/client/src/features/editor/utils/get-editor-selection.ts

@@ -0,0 +1,71 @@
+import type { EditorState } from "@tiptap/pm/state";
+
+export interface EditorSelectionContext {
+  text: string;
+  truncated?: boolean;
+  blockIds?: string[];
+  before?: string;
+  after?: string;
+}
+
+// Client-side caps. The server re-caps every field independently (defence in
+// depth — the payload is attacker-controllable), so these only keep the wire
+// small for the common case.
+const TEXT_CAP = 2000;
+const CONTEXT_CHARS = 160;
+const MAX_BLOCK_IDS = 20;
+
+// Pure: takes an EditorState so it is unit-testable with a headless editor.
+// Snapshots the user's current selection into the wire shape carried inside
+// openPage — plain text + the ids of the blocks it covers + a little surrounding
+// context. Returns null when nothing meaningful is selected.
+//
+// Deliberately does NOT emit the ProseMirror positions (from/to): they rot the
+// instant the document changes and the server tools address content by block id
+// + text (getNode / editPageText find-replace), never by position.
+export function getEditorSelectionContext(
+  state: EditorState,
+): EditorSelectionContext | null {
+  const { selection, doc } = state;
+  // An empty selection (incl. the default caret-at-start of a fresh editor) is
+  // never a "this"/"here" — bail before reading any text.
+  if (selection.empty) return null;
+
+  const { from, to } = selection;
+
+  let text = doc.textBetween(from, to, "\n");
+  let truncated = false;
+  if (text.length > TEXT_CAP) {
+    text = text.slice(0, TEXT_CAP);
+    truncated = true;
+  }
+  // A selection spanning only non-text nodes (e.g. an image) trims to empty ->
+  // treat as no selection.
+  if (text.trim().length === 0) return null;
+
+  // Ids of every block the selection covers, deduped and capped. These bridge
+  // the plain-text selection to the server tools (getNode / editPageText).
+  const blockIds: string[] = [];
+  doc.nodesBetween(from, to, (node) => {
+    const id = node.isBlock ? node.attrs?.id : undefined;
+    if (typeof id === "string" && id.length > 0 && !blockIds.includes(id)) {
+      blockIds.push(id);
+    }
+  });
+
+  // ~160 chars of plain text on each side, clamped to the document bounds, so
+  // editPageText can disambiguate a duplicate of the selected text.
+  const before = doc.textBetween(Math.max(0, from - CONTEXT_CHARS), from, "\n");
+  const after = doc.textBetween(
+    to,
+    Math.min(doc.content.size, to + CONTEXT_CHARS),
+    "\n",
+  );
+
+  const result: EditorSelectionContext = { text };
+  if (truncated) result.truncated = true;
+  if (blockIds.length > 0) result.blockIds = blockIds.slice(0, MAX_BLOCK_IDS);
+  if (before.length > 0) result.before = before;
+  if (after.length > 0) result.after = after;
+  return result;
+}

apps/client/src/features/page-history/components/history-item.test.tsx

@@ -1,234 +0,0 @@
-import { describe, it, expect, vi, afterEach, beforeAll } from "vitest";
-import { render, screen, cleanup, within } from "@testing-library/react";
-import { MantineProvider } from "@mantine/core";
-
-// Mantine Tooltip mounts its label lazily on hover via Floating UI, which is
-// flaky under jsdom. Replace ONLY the Tooltip with a thin wrapper that renders
-// the label inline (keeping Badge/Switch/etc. real), so the provenance label —
-// the contract we care about — is deterministically queryable.
-vi.mock("@mantine/core", async () => {
-  const actual =
-    await vi.importActual<typeof import("@mantine/core")>("@mantine/core");
-  const Tooltip = ({
-    label,
-    children,
-  }: {
-    label?: React.ReactNode;
-    children?: React.ReactNode;
-  }) => (
-    <>
-      {children}
-      <span data-testid="tooltip-label">{label}</span>
-    </>
-  );
-  Tooltip.Group = ({ children }: { children?: React.ReactNode }) => (
-    <>{children}</>
-  );
-  return { ...actual, Tooltip };
-});
-
-// jsdom lacks matchMedia, which MantineProvider's color-scheme hook needs.
-beforeAll(() => {
-  if (!window.matchMedia) {
-    window.matchMedia = (query: string) =>
-      ({
-        matches: false,
-        media: query,
-        onchange: null,
-        addListener: () => {},
-        removeListener: () => {},
-        addEventListener: () => {},
-        removeEventListener: () => {},
-        dispatchEvent: () => false,
-      }) as unknown as MediaQueryList;
-  }
-});
-
-// --- Mocks for the heavy / networked module graph ---------------------------
-// HistoryItem pulls in i18n, jotai atoms (ai-chat / history), a config-backed
-// avatar and a time formatter. The provenance-badge contract is the unit under
-// test, so we stub everything else down to inert, deterministic renders and
-// keep the real Mantine Badge/Tooltip so role/label queries are meaningful.
-
-// i18n: interpolate {{name}} so the git-sync tooltip carries the author name,
-// letting us assert provenance attribution without a real i18n backend.
-vi.mock("react-i18next", () => ({
-  useTranslation: () => ({
-    t: (key: string, vars?: Record<string, unknown>) =>
-      vars && typeof vars.name !== "undefined"
-        ? key.replace("{{name}}", String(vars.name))
-        : key,
-  }),
-}));
-
-// jotai setters: the badges call useSetAtom; return inert setters so a click on
-// the (deep-linkable) AiAgentBadge would fire these — proving the git-sync badge
-// does NOT wire any of them.
-const setAiChatWindowOpen = vi.fn();
-const setActiveChatId = vi.fn();
-const setDraft = vi.fn();
-const setHistoryModalOpen = vi.fn();
-vi.mock("jotai", async () => {
-  const actual = await vi.importActual<typeof import("jotai")>("jotai");
-  return {
-    ...actual,
-    useSetAtom: (atom: unknown) => {
-      switch (atom) {
-        case aiChatWindowOpenAtom:
-          return setAiChatWindowOpen;
-        case activeAiChatIdAtom:
-          return setActiveChatId;
-        case aiChatDraftAtom:
-          return setDraft;
-        case historyAtoms:
-          return setHistoryModalOpen;
-        default:
-          return vi.fn();
-      }
-    },
-  };
-});
-
-// Atoms are imported only as identity tokens for the useSetAtom switch above.
-vi.mock("@/features/ai-chat/atoms/ai-chat-atom.ts", () => ({
-  activeAiChatIdAtom: { __tag: "activeAiChatIdAtom" },
-  aiChatWindowOpenAtom: { __tag: "aiChatWindowOpenAtom" },
-  aiChatDraftAtom: { __tag: "aiChatDraftAtom" },
-}));
-vi.mock("@/features/page-history/atoms/history-atoms.ts", () => ({
-  historyAtoms: { __tag: "historyAtoms" },
-}));
-
-// Avatar reaches into config (getAvatarUrl) — stub to a plain element.
-vi.mock("@/components/ui/custom-avatar.tsx", () => ({
-  CustomAvatar: ({ name }: { name?: string }) => (
-    <span data-testid="avatar">{name}</span>
-  ),
-}));
-
-// Deterministic, locale-free date string.
-vi.mock("@/lib/time", () => ({
-  formattedDate: () => "2026-06-21",
-}));
-
-import HistoryItem from "./history-item";
-import {
-  activeAiChatIdAtom,
-  aiChatWindowOpenAtom,
-  aiChatDraftAtom,
-} from "@/features/ai-chat/atoms/ai-chat-atom.ts";
-import { historyAtoms } from "@/features/page-history/atoms/history-atoms.ts";
-import type { IPageHistory } from "@/features/page-history/types/page.types";
-
-function makeItem(overrides: Partial<IPageHistory> = {}): IPageHistory {
-  return {
-    id: "h1",
-    pageId: "p1",
-    title: "Title",
-    slug: "slug",
-    icon: "",
-    coverPhoto: "",
-    version: 1,
-    lastUpdatedById: "u1",
-    workspaceId: "w1",
-    createdAt: "2026-06-21T00:00:00.000Z",
-    updatedAt: "2026-06-21T00:00:00.000Z",
-    lastUpdatedBy: { id: "u1", name: "Alice", avatarUrl: "" },
-    ...overrides,
-  };
-}
-
-function renderItem(item: IPageHistory) {
-  return render(
-    <MantineProvider>
-      <HistoryItem
-        historyItem={item}
-        index={0}
-        onSelect={vi.fn()}
-        isActive={false}
-      />
-    </MantineProvider>,
-  );
-}
-
-afterEach(() => {
-  cleanup();
-  vi.clearAllMocks();
-});
-
-describe("HistoryItem git-sync provenance badge", () => {
-  // Test 1: the git-sync badge renders ONLY for lastUpdatedSource === 'git-sync'.
-  it("renders the Git sync badge only when lastUpdatedSource is 'git-sync'", () => {
-    renderItem(makeItem({ lastUpdatedSource: "git-sync" }));
-    expect(screen.getByText("Git sync")).toBeTruthy();
-  });
-
-  it.each([
-    ["agent", "agent"],
-    ["user", "user"],
-    ["undefined", undefined],
-  ])(
-    "does NOT render the Git sync badge when lastUpdatedSource is %s",
-    (_label, source) => {
-      renderItem(makeItem({ lastUpdatedSource: source }));
-      expect(screen.queryByText("Git sync")).toBeNull();
-    },
-  );
-
-  // Test 2: provenance attribution + the git-sync badge is NOT interactive.
-  it("attributes the git-sync provenance to the correct author and is not clickable", () => {
-    renderItem(
-      makeItem({
-        lastUpdatedSource: "git-sync",
-        lastUpdatedBy: { id: "u2", name: "Bob", avatarUrl: "" },
-      }),
-    );
-
-    const badge = screen.getByText("Git sync");
-
-    // Provenance attribution: the tooltip label carries the author name (the
-    // git-sync badge passes authorName -> "Synced from Git on behalf of {{name}}").
-    expect(screen.getByText("Synced from Git on behalf of Bob")).toBeTruthy();
-
-    // The git-sync badge must NOT behave like AiAgentBadge: the badge element
-    // itself is not a button, carries no role=button and no tabIndex, and
-    // clicking it must not trigger any ai-chat deep-link. (The surrounding
-    // history-row IS an UnstyledButton — that is the row's own select affordance,
-    // not the badge — so we scope these checks to the badge element.)
-    const badgeRoot = (badge.closest("[class*='mantine-Badge-root']") ??
-      badge) as HTMLElement;
-    expect(badgeRoot.getAttribute("role")).not.toBe("button");
-    expect(badgeRoot.getAttribute("tabindex")).toBeNull();
-    expect(badgeRoot.tagName.toLowerCase()).not.toBe("button");
-    // No interactive descendant button lives inside the badge itself.
-    expect(within(badgeRoot).queryByRole("button")).toBeNull();
-
-    badgeRoot.dispatchEvent(new MouseEvent("click", { bubbles: true }));
-    expect(setActiveChatId).not.toHaveBeenCalled();
-    expect(setAiChatWindowOpen).not.toHaveBeenCalled();
-    expect(setDraft).not.toHaveBeenCalled();
-    expect(setHistoryModalOpen).not.toHaveBeenCalled();
-  });
-
-  // Sanity contrast: the agent provenance IS interactive when it carries an
-  // aiChatId — proving the not-clickable assertion above is real. The old text
-  // `AiAgentBadge` was superseded by `AgentAvatarStack` (#300), which becomes a
-  // role=button deep-link (and fires the ai-chat atoms) when an aiChatId is present.
-  it("contrast: the agent stack is a deep-link button when it has an aiChatId", () => {
-    renderItem(
-      makeItem({
-        lastUpdatedSource: "agent",
-        agent: { name: "Zeta" },
-        lastUpdatedAiChatId: "chat-1",
-      }),
-    );
-    // The agent glyph lives inside the clickable stack; walk up to its role=button.
-    const root = screen.getByTestId("agent-glyph").closest("[role='button']");
-    expect(root).not.toBeNull();
-    (root as HTMLElement).dispatchEvent(
-      new MouseEvent("click", { bubbles: true }),
-    );
-    expect(setActiveChatId).toHaveBeenCalledWith("chat-1");
-    expect(setAiChatWindowOpen).toHaveBeenCalled();
-  });
-});

apps/client/src/features/page-history/components/history-item.tsx

@@ -1,6 +1,5 @@
 import { Text, Group, UnstyledButton, Avatar, Tooltip } from "@mantine/core";
 import { CustomAvatar } from "@/components/ui/custom-avatar.tsx";
-import { GitSyncBadge } from "@/components/ui/git-sync-badge.tsx";
 import { AgentAvatarStack } from "@/components/ui/agent-avatar-stack.tsx";
 import { formattedDate } from "@/lib/time";
 import classes from "./css/history.module.css";
@@ -42,7 +41,6 @@ const HistoryItem = memo(function HistoryItem({
   const contributors = historyItem.contributors;
   const hasContributors = contributors && contributors.length > 0;
   const isAgentEdit = historyItem.lastUpdatedSource === "agent";
-  const isGitSyncEdit = historyItem.lastUpdatedSource === "git-sync";
 
   return (
     <UnstyledButton
@@ -111,10 +109,6 @@ const HistoryItem = memo(function HistoryItem({
             onActivate={() => setHistoryModalOpen(false)}
           />
         )}
-
-        {isGitSyncEdit && (
-          <GitSyncBadge authorName={historyItem.lastUpdatedBy?.name} />
-        )}
       </Group>
     </UnstyledButton>
   );

apps/client/src/features/share/components/share-ai-widget.tsx

@@ -165,6 +165,9 @@ export default function ShareAiWidget({
             isStreaming={isStreaming}
             assistantName={assistantName}
             showCitations={false}
+            // Anonymous reader: suppress the tool-argument summary line so the
+            // agent's raw query/argument text isn't shown on the public share.
+            showInput={false}
             // Anonymous reader: neutralize internal/relative links in the
             // assistant's markdown so internal UUIDs/auth-gated routes don't
             // leak as clickable links (external http(s) links are kept).

apps/client/src/features/space/components/edit-space-form.test.tsx

@@ -1,240 +0,0 @@
-import {
-  describe,
-  it,
-  expect,
-  vi,
-  beforeAll,
-  afterEach,
-} from "vitest";
-import {
-  render,
-  screen,
-  cleanup,
-  fireEvent,
-  waitFor,
-} from "@testing-library/react";
-import { MantineProvider } from "@mantine/core";
-
-// --- Mocks for the heavy / networked module graph ---------------------------
-// EditSpaceForm wires the "Enable Git sync" Switch to a TanStack-Query mutation
-// (useUpdateSpaceMutation). We mock ONLY that hook so the test fully controls
-// mutateAsync (resolve / reject) and isPending, and stub i18n. The real Mantine
-// Switch is rendered so the checkbox role / disabled state is meaningful.
-
-// i18n: identity translator — labels stay as their English keys for queries.
-vi.mock("react-i18next", () => ({
-  useTranslation: () => ({ t: (key: string) => key }),
-}));
-
-// Mutation hook: a controllable mutateAsync plus a togglable isPending.
-const mutateAsync = vi.fn();
-let isPending = false;
-vi.mock("@/features/space/queries/space-query.ts", () => ({
-  useUpdateSpaceMutation: () => ({
-    mutateAsync,
-    get isPending() {
-      return isPending;
-    },
-  }),
-}));
-
-// jsdom lacks matchMedia, which MantineProvider's color-scheme hook needs.
-beforeAll(() => {
-  if (!window.matchMedia) {
-    window.matchMedia = (query: string) =>
-      ({
-        matches: false,
-        media: query,
-        onchange: null,
-        addListener: () => {},
-        removeListener: () => {},
-        addEventListener: () => {},
-        removeEventListener: () => {},
-        dispatchEvent: () => false,
-      }) as unknown as MediaQueryList;
-  }
-});
-
-import { EditSpaceForm } from "./edit-space-form";
-import type { ISpace } from "@/features/space/types/space.types.ts";
-
-function makeSpace(overrides: Partial<ISpace> = {}): ISpace {
-  return {
-    id: "space-1",
-    name: "Engineering",
-    description: "",
-    slug: "eng",
-    hostname: "host",
-    creatorId: "u1",
-    createdAt: new Date("2026-01-01"),
-    updatedAt: new Date("2026-01-01"),
-    ...overrides,
-  } as ISpace;
-}
-
-function renderForm(props: { space: ISpace; readOnly?: boolean }) {
-  return render(
-    <MantineProvider>
-      <EditSpaceForm space={props.space} readOnly={props.readOnly} />
-    </MantineProvider>,
-  );
-}
-
-// The form now renders TWO switches (git-sync enable + auto-merge-conflicts) in
-// that DOM order. Mantine renders each as an <input type="checkbox"
-// role="switch"> but does NOT expose its label as the accessible name, so we
-// disambiguate by DOM order (index 0 = enable, 1 = auto-merge) and assert the
-// human-readable label text is present alongside.
-function getToggle(): HTMLInputElement {
-  screen.getByText("Enable Git sync");
-  return screen.getAllByRole("switch")[0] as HTMLInputElement;
-}
-
-function getAutoMergeToggle(): HTMLInputElement {
-  screen.getByText("Auto-merge conflicts on push");
-  return screen.getAllByRole("switch")[1] as HTMLInputElement;
-}
-
-afterEach(() => {
-  cleanup();
-  mutateAsync.mockReset();
-  isPending = false;
-});
-
-describe("EditSpaceForm git-sync toggle", () => {
-  // Test 3: initial checked state derives from settings.gitSync.enabled ?? false.
-  it("derives initial checked state from space.settings.gitSync.enabled (true -> checked)", () => {
-    renderForm({
-      space: makeSpace({ settings: { gitSync: { enabled: true } } }),
-    });
-    expect(getToggle().checked).toBe(true);
-  });
-
-  it("defaults to unchecked when gitSync settings are missing", () => {
-    renderForm({ space: makeSpace() });
-    expect(getToggle().checked).toBe(false);
-  });
-
-  // Test 4: toggling fires the mutation with { spaceId, gitSyncEnabled } and
-  // optimistically flips the switch.
-  it("fires the mutation with the correct payload and optimistically flips on", async () => {
-    mutateAsync.mockResolvedValue(undefined);
-    renderForm({ space: makeSpace() });
-
-    const toggle = getToggle();
-    expect(toggle.checked).toBe(false);
-
-    fireEvent.click(toggle);
-
-    // Optimistic update: the switch reflects the new state immediately.
-    expect(toggle.checked).toBe(true);
-
-    expect(mutateAsync).toHaveBeenCalledTimes(1);
-    expect(mutateAsync).toHaveBeenCalledWith({
-      spaceId: "space-1",
-      gitSyncEnabled: true,
-    });
-
-    // Resolution leaves the toggle on.
-    await waitFor(() => expect(toggle.checked).toBe(true));
-  });
-
-  // Test 5: rollback on mutation error — the most valuable test.
-  it("rolls back the toggle to its prior state when the mutation rejects", async () => {
-    mutateAsync.mockRejectedValue(new Error("network"));
-    renderForm({
-      space: makeSpace({ settings: { gitSync: { enabled: false } } }),
-    });
-
-    const toggle = getToggle();
-    expect(toggle.checked).toBe(false);
-
-    fireEvent.click(toggle);
-
-    // Optimistically flips on before the rejection lands.
-    expect(toggle.checked).toBe(true);
-    expect(mutateAsync).toHaveBeenCalledWith({
-      spaceId: "space-1",
-      gitSyncEnabled: true,
-    });
-
-    // After the rejected promise settles, the component reverts to OFF so the
-    // user is not misled into believing sync is enabled.
-    await waitFor(() => expect(toggle.checked).toBe(false));
-  });
-
-  // Test 6: disabled when readOnly and when the mutation is pending.
-  it("disables the toggle when readOnly", () => {
-    renderForm({ space: makeSpace(), readOnly: true });
-    expect(getToggle().disabled).toBe(true);
-  });
-
-  it("disables the toggle while the mutation is pending", () => {
-    isPending = true;
-    renderForm({ space: makeSpace() });
-    expect(getToggle().disabled).toBe(true);
-  });
-});
-
-describe("EditSpaceForm auto-merge-conflicts toggle", () => {
-  it("derives initial checked state from space.settings.gitSync.autoMergeConflicts (true -> checked)", () => {
-    renderForm({
-      space: makeSpace({
-        settings: { gitSync: { autoMergeConflicts: true } },
-      }),
-    });
-    expect(getAutoMergeToggle().checked).toBe(true);
-  });
-
-  it("defaults to unchecked when autoMergeConflicts is missing (SAFE default)", () => {
-    renderForm({ space: makeSpace() });
-    expect(getAutoMergeToggle().checked).toBe(false);
-  });
-
-  it("fires the mutation with { spaceId, autoMergeConflicts } and optimistically flips on", async () => {
-    mutateAsync.mockResolvedValue(undefined);
-    renderForm({ space: makeSpace() });
-
-    const toggle = getAutoMergeToggle();
-    expect(toggle.checked).toBe(false);
-
-    fireEvent.click(toggle);
-
-    // Optimistic update.
-    expect(toggle.checked).toBe(true);
-    expect(mutateAsync).toHaveBeenCalledTimes(1);
-    expect(mutateAsync).toHaveBeenCalledWith({
-      spaceId: "space-1",
-      autoMergeConflicts: true,
-    });
-
-    await waitFor(() => expect(toggle.checked).toBe(true));
-  });
-
-  it("rolls back to its prior state when the mutation rejects", async () => {
-    mutateAsync.mockRejectedValue(new Error("network"));
-    renderForm({
-      space: makeSpace({
-        settings: { gitSync: { autoMergeConflicts: false } },
-      }),
-    });
-
-    const toggle = getAutoMergeToggle();
-    expect(toggle.checked).toBe(false);
-
-    fireEvent.click(toggle);
-
-    expect(toggle.checked).toBe(true);
-    expect(mutateAsync).toHaveBeenCalledWith({
-      spaceId: "space-1",
-      autoMergeConflicts: true,
-    });
-
-    await waitFor(() => expect(toggle.checked).toBe(false));
-  });
-
-  it("disables the toggle when readOnly", () => {
-    renderForm({ space: makeSpace(), readOnly: true });
-    expect(getAutoMergeToggle().disabled).toBe(true);
-  });
-});

apps/client/src/features/space/components/edit-space-form.tsx

@@ -1,14 +1,5 @@
-import {
-  Group,
-  Box,
-  Button,
-  TextInput,
-  Stack,
-  Textarea,
-  Divider,
-  Switch,
-} from "@mantine/core";
-import React, { useState } from "react";
+import { Group, Box, Button, TextInput, Stack, Textarea } from "@mantine/core";
+import React from "react";
 import { useForm } from "@mantine/form";
 import { zod4Resolver } from "mantine-form-zod-resolver";
 import { z } from "zod/v4";
@@ -38,37 +29,6 @@ export function EditSpaceForm({ space, readOnly }: EditSpaceFormProps) {
   const { t } = useTranslation();
   const updateSpaceMutation = useUpdateSpaceMutation();
 
-  const [gitSyncEnabled, setGitSyncEnabled] = useState<boolean>(
-    space?.settings?.gitSync?.enabled ?? false,
-  );
-
-  const [autoMergeConflicts, setAutoMergeConflicts] = useState<boolean>(
-    space?.settings?.gitSync?.autoMergeConflicts ?? false,
-  );
-
-  // One parameterized handler for both git-sync space toggles: they differ only by
-  // the local state setter, the mutation payload field, and the error label. The
-  // update is optimistic and reverts the local state on failure (the mutation
-  // surfaces a toast via onError; the raw error is still logged per AGENTS.md).
-  const handleToggle = async (
-    field: "gitSyncEnabled" | "autoMergeConflicts",
-    value: boolean,
-    previous: boolean,
-    setLocal: (next: boolean) => void,
-    errorLabel: string,
-  ) => {
-    setLocal(value); // optimistic update
-    try {
-      await updateSpaceMutation.mutateAsync({
-        spaceId: space.id,
-        [field]: value,
-      });
-    } catch (err) {
-      setLocal(previous); // revert on failure
-      console.error(errorLabel, err);
-    }
-  };
-
   const form = useForm<FormValues>({
     validate: zod4Resolver(formSchema),
     initialValues: {
@@ -144,43 +104,6 @@ export function EditSpaceForm({ space, readOnly }: EditSpaceFormProps) {
             </Group>
           )}
         </form>
-
-        <Divider my="lg" />
-
-        <Switch
-          label={t("Enable Git sync")}
-          description={t("Sync this space's pages to a Git repository.")}
-          checked={gitSyncEnabled}
-          disabled={readOnly || updateSpaceMutation.isPending}
-          onChange={(event) =>
-            handleToggle(
-              "gitSyncEnabled",
-              event.currentTarget.checked,
-              gitSyncEnabled,
-              setGitSyncEnabled,
-              "Failed to toggle git-sync for space",
-            )
-          }
-        />
-
-        <Switch
-          mt="md"
-          label={t("Auto-merge conflicts on push")}
-          description={t(
-            "When off (recommended), a page whose content still has unresolved Git conflict markers is skipped on push until you resolve the conflict in Git. When on, the markers are stripped and both sides' content is pushed.",
-          )}
-          checked={autoMergeConflicts}
-          disabled={readOnly || updateSpaceMutation.isPending}
-          onChange={(event) =>
-            handleToggle(
-              "autoMergeConflicts",
-              event.currentTarget.checked,
-              autoMergeConflicts,
-              setAutoMergeConflicts,
-              "Failed to toggle git-sync auto-merge-conflicts",
-            )
-          }
-        />
       </Box>
     </>
   );

apps/client/src/features/space/types/space.types.ts

@@ -13,15 +13,9 @@ export interface ISpaceCommentsSettings {
   allowViewerComments?: boolean;
 }
 
-export interface ISpaceGitSyncSettings {
-  enabled?: boolean;
-  autoMergeConflicts?: boolean;
-}
-
 export interface ISpaceSettings {
   sharing?: ISpaceSharingSettings;
   comments?: ISpaceCommentsSettings;
-  gitSync?: ISpaceGitSyncSettings;
 }
 
 export interface ISpace {
@@ -41,8 +35,6 @@ export interface ISpace {
   // for updates
   disablePublicSharing?: boolean;
   allowViewerComments?: boolean;
-  gitSyncEnabled?: boolean;
-  autoMergeConflicts?: boolean;
 }
 
 interface IMembership {

apps/client/src/features/workspace/components/settings/components/ai-provider-settings.tsx

@@ -394,6 +394,10 @@ export default function AiProviderSettings() {
     useState<boolean>(
       workspace?.settings?.ai?.publicShareAssistant ?? false,
     );
+  // #184: detached/autonomous agent runs (settings.ai.autonomousRuns).
+  const [autonomousRunsEnabled, setAutonomousRunsEnabled] = useState<boolean>(
+    workspace?.settings?.ai?.autonomousRuns ?? false,
+  );
   const [chatToggleLoading, setChatToggleLoading] = useState(false);
   const [searchToggleLoading, setSearchToggleLoading] = useState(false);
   const [dictationToggleLoading, setDictationToggleLoading] = useState(false);
@@ -403,6 +407,8 @@ export default function AiProviderSettings() {
     publicShareAssistantToggleLoading,
     setPublicShareAssistantToggleLoading,
   ] = useState(false);
+  const [autonomousRunsToggleLoading, setAutonomousRunsToggleLoading] =
+    useState(false);
 
   // Whether a key is currently stored server-side (drives the placeholder).
   const [hasApiKey, setHasApiKey] = useState(false);
@@ -730,6 +736,37 @@ export default function AiProviderSettings() {
     }
   }
 
+  // Optimistic toggle for detached/autonomous agent runs
+  // (settings.ai.autonomousRuns). When on, a chat turn becomes a server-side run
+  // that survives a browser disconnect and can be reconnected to / live-followed;
+  // only an explicit Stop ends it. Off by default; single-instance-only in phase 1.
+  async function handleToggleAutonomousRuns(value: boolean) {
+    setAutonomousRunsToggleLoading(true);
+    const previous = autonomousRunsEnabled;
+    setAutonomousRunsEnabled(value);
+    try {
+      const updated = await updateWorkspace({ autonomousRuns: value });
+      setWorkspace({
+        ...updated,
+        settings: {
+          ...updated.settings,
+          ai: { ...updated.settings?.ai, autonomousRuns: value },
+        },
+      });
+      notifications.show({ message: t("Updated successfully") });
+    } catch (err) {
+      setAutonomousRunsEnabled(previous);
+      const message = (err as { response?: { data?: { message?: string } } })
+        ?.response?.data?.message;
+      notifications.show({
+        message: message ?? t("Failed to update data"),
+        color: "red",
+      });
+    } finally {
+      setAutonomousRunsToggleLoading(false);
+    }
+  }
+
   // Admins only — match the previous behavior.
   if (!isAdmin) {
     return (
@@ -960,6 +997,31 @@ export default function AiProviderSettings() {
           {...form.getInputProps("publicShareAssistantRoleId")}
         />
 
+        {/* Detached/autonomous agent runs: a chat turn becomes a server-side run
+            that survives a browser disconnect; only an explicit Stop ends it.
+            Single-instance-only in phase 1. */}
+        <Group justify="space-between" align="center" wrap="nowrap" mt="md">
+          <Stack gap={0}>
+            <Text fw={600} size="sm">
+              {t("Autonomous agent runs")}
+            </Text>
+            <Text size="xs" c="dimmed">
+              {t(
+                "Keep an agent turn running server-side even if the browser disconnects; reconnect and follow it on reopen. Single-instance deployments only.",
+              )}
+            </Text>
+          </Stack>
+          <Switch
+            label={t("Enabled")}
+            labelPosition="left"
+            checked={autonomousRunsEnabled}
+            disabled={autonomousRunsToggleLoading}
+            onChange={(e) =>
+              handleToggleAutonomousRuns(e.currentTarget.checked)
+            }
+          />
+        </Group>
+
         <Group mt="md" align="center">
           <Button
             variant="default"

apps/client/src/features/workspace/types/workspace.types.ts

@@ -26,6 +26,9 @@ export interface IWorkspace {
   aiDictation?: boolean;
   aiDictationStreaming?: boolean;
   aiPublicShareAssistant?: boolean;
+  // Write-only field for updateWorkspace({ autonomousRuns }). Read state lives at
+  // settings.ai.autonomousRuns.
+  autonomousRuns?: boolean;
   trashRetentionDays?: number;
   // Default lifetime (HOURS) for new temporary notes; frozen per-note at creation.
   temporaryNoteHours?: number;
@@ -65,6 +68,9 @@ export interface IWorkspaceAiSettings {
   dictation?: boolean;
   dictationStreaming?: boolean;
   publicShareAssistant?: boolean;
+  // #184: detached agent runs (a run survives a browser disconnect and can be
+  // reconnected to / live-followed on reopen). Gates the run-reconnect polling.
+  autonomousRuns?: boolean;
 }
 
 export interface IWorkspaceSharingSettings {

apps/client/src/lib/config.ts

@@ -47,6 +47,13 @@ export function isCompactPageTreeEnabled(): boolean {
   return castToBoolean(getConfigValue("COMPACT_PAGE_TREE", "true"));
 }
 
+// #355 — operator toggle for client perf-telemetry. DEFAULT OFF: the server
+// mirrors CLIENT_TELEMETRY_ENABLED into window.CONFIG; when off the client
+// installs no observers and sends nothing (the sink endpoint doesn't exist).
+export function isClientTelemetryEnabled(): boolean {
+  return castToBoolean(getConfigValue("CLIENT_TELEMETRY_ENABLED", "false"));
+}
+
 export function getAvatarUrl(
   avatarUrl: string,
   type: AvatarIconType = AvatarIconType.AVATAR,

apps/client/src/lib/telemetry/route-template.test.ts

@@ -0,0 +1,35 @@
+import { describe, it, expect } from "vitest";
+import { templateRoute } from "./route-template";
+
+describe("templateRoute", () => {
+  it("templates a space page path (never leaks slugs)", () => {
+    const t = templateRoute("/s/engineering/p/design-doc-abc123");
+    expect(t).toBe("/s/:space/p/:slug");
+    expect(t).not.toContain("engineering");
+    expect(t).not.toContain("design-doc");
+  });
+
+  it("templates share, redirect and space paths", () => {
+    expect(templateRoute("/share/abc/p/xyz")).toBe("/share/:shareId/p/:slug");
+    expect(templateRoute("/share/p/xyz")).toBe("/share/p/:slug");
+    expect(templateRoute("/p/some-slug")).toBe("/p/:slug");
+    expect(templateRoute("/s/team")).toBe("/s/:space");
+    expect(templateRoute("/s/team/trash")).toBe("/s/:space/trash");
+    expect(templateRoute("/labels/urgent")).toBe("/labels/:label");
+  });
+
+  it("keeps known static routes verbatim", () => {
+    expect(templateRoute("/home")).toBe("/home");
+    expect(templateRoute("/settings/members")).toBe("/settings/members");
+    expect(templateRoute("/")).toBe("/");
+  });
+
+  it("normalises a trailing slash", () => {
+    expect(templateRoute("/s/team/p/slug/")).toBe("/s/:space/p/:slug");
+  });
+
+  it("collapses unknown paths to 'other' (bounded cardinality)", () => {
+    expect(templateRoute("/weird/unknown/thing")).toBe("other");
+    expect(templateRoute("/s/team/p/slug/extra/segments")).toBe("other");
+  });
+});

apps/client/src/lib/telemetry/route-template.ts

@@ -0,0 +1,70 @@
+/**
+ * Map a raw pathname to a BOUNDED route TEMPLATE (#355).
+ *
+ * Perf metrics must be labelled by route template only — never a raw path with
+ * slugs/ids — so the server-side `route` column and any downstream aggregation
+ * stay low-cardinality and carry NO page slugs/titles (privacy). Anything that
+ * does not match a known pattern collapses to `other`.
+ *
+ * The template vocabulary mirrors the issue's example (`/s/:space/p/:slug`).
+ */
+const ROUTE_PATTERNS: { re: RegExp; template: string }[] = [
+  // Share pages (public).
+  { re: /^\/share\/[^/]+\/p\/[^/]+$/, template: '/share/:shareId/p/:slug' },
+  { re: /^\/share\/p\/[^/]+$/, template: '/share/p/:slug' },
+  { re: /^\/share\/[^/]+$/, template: '/share/:shareId' },
+  // Page redirect.
+  { re: /^\/p\/[^/]+$/, template: '/p/:slug' },
+  // Space + page.
+  { re: /^\/s\/[^/]+\/p\/[^/]+$/, template: '/s/:space/p/:slug' },
+  { re: /^\/s\/[^/]+\/trash$/, template: '/s/:space/trash' },
+  { re: /^\/s\/[^/]+$/, template: '/s/:space' },
+  // Misc dynamic.
+  { re: /^\/labels\/[^/]+$/, template: '/labels/:label' },
+  { re: /^\/invites\/[^/]+$/, template: '/invites/:invitationId' },
+  { re: /^\/settings\/groups\/[^/]+$/, template: '/settings/groups/:groupId' },
+];
+
+// Static routes we accept verbatim (finite set).
+const STATIC_ROUTES = new Set<string>([
+  '/home',
+  '/spaces',
+  '/favorites',
+  '/login',
+  '/forgot-password',
+  '/password-reset',
+  '/setup/register',
+  '/settings/account/profile',
+  '/settings/account/preferences',
+  '/settings/workspace',
+  '/settings/ai',
+  '/settings/members',
+  '/settings/groups',
+  '/settings/spaces',
+  '/settings/sharing',
+]);
+
+export function templateRoute(pathname: string): string {
+  // Normalise a trailing slash (except root).
+  const path =
+    pathname.length > 1 && pathname.endsWith('/')
+      ? pathname.slice(0, -1)
+      : pathname;
+
+  if (path === '' || path === '/') return '/';
+  if (STATIC_ROUTES.has(path)) return path;
+
+  for (const { re, template } of ROUTE_PATTERNS) {
+    if (re.test(path)) return template;
+  }
+  return 'other';
+}
+
+/** Template for the current window location. */
+export function currentRouteTemplate(): string {
+  try {
+    return templateRoute(window.location.pathname);
+  } catch {
+    return 'other';
+  }
+}

apps/client/src/lib/telemetry/vitals.ts

@@ -0,0 +1,290 @@
+import {
+  onCLS,
+  onINP,
+  onLCP,
+  onTTFB,
+  type CLSMetricWithAttribution,
+  type INPMetricWithAttribution,
+  type LCPMetricWithAttribution,
+  type TTFBMetricWithAttribution,
+} from "web-vitals/attribution";
+import { isClientTelemetryEnabled } from "@/lib/config";
+import { currentRouteTemplate } from "./route-template";
+
+/**
+ * Client perf-telemetry (#355): web-vitals + custom metrics buffered and posted
+ * to POST /api/telemetry/vitals via sendBeacon.
+ *
+ * Design constraints from the issue:
+ *  - Sampling is decided ONCE per session (25%), cached in sessionStorage,
+ *    BEFORE any observer is subscribed. Non-sampled sessions send nothing.
+ *  - Route labels are TEMPLATES only; attr is truncated to 120 chars; no page
+ *    titles/slugs/text ever leave the browser.
+ *  - Observers are passive and reporting is best-effort — telemetry must not
+ *    degrade the perf it measures.
+ */
+
+const ENDPOINT = "/api/telemetry/vitals";
+const SAMPLE_RATE = 0.25;
+const SAMPLE_KEY = "gm_vitals_sampled";
+const FLUSH_INTERVAL_MS = 15_000;
+const MAX_BUFFER = 40; // flush early if the buffer fills between timers
+const MAX_ATTR_LENGTH = 120;
+const EDITOR_TX_MIN_MS = 8; // only report editor transactions slower than this
+
+const ALLOWED_NAMES = new Set([
+  "INP",
+  "LCP",
+  "CLS",
+  "TTFB",
+  "editor_tx_ms",
+  "page_open_ms",
+  "longtask_ms",
+]);
+
+interface VitalEvent {
+  name: string;
+  value: number;
+  rating?: string;
+  route?: string;
+  attr?: string;
+  docSize?: number;
+}
+
+let sampledCache: boolean | null = null;
+let initialised = false;
+let buffer: VitalEvent[] = [];
+let longtaskSum = 0; // accumulated longtask duration (ms) for the current window
+
+/**
+ * Decide once per session whether this session is sampled. Cached in
+ * sessionStorage so the choice is stable across reloads within the session and
+ * identical for every observer/custom-metric caller.
+ */
+export function isVitalsSampled(): boolean {
+  if (sampledCache !== null) return sampledCache;
+  try {
+    const stored = sessionStorage.getItem(SAMPLE_KEY);
+    if (stored === "1") return (sampledCache = true);
+    if (stored === "0") return (sampledCache = false);
+    const sampled = Math.random() < SAMPLE_RATE;
+    sessionStorage.setItem(SAMPLE_KEY, sampled ? "1" : "0");
+    return (sampledCache = sampled);
+  } catch {
+    // sessionStorage unavailable (private mode / SSR): default to not sampled.
+    return (sampledCache = false);
+  }
+}
+
+/**
+ * True only when telemetry is BOTH enabled by the operator (F1 flag) AND this
+ * session is sampled. Callers outside initVitals (e.g. the editor dispatch
+ * wrapper) use this to skip ALL instrumentation cost on disabled/non-sampled
+ * sessions — no observers, no per-transaction timing.
+ */
+export function isVitalsActive(): boolean {
+  return isClientTelemetryEnabled() && isVitalsSampled();
+}
+
+function truncateAttr(value: unknown): string | undefined {
+  if (typeof value !== "string" || value.length === 0) return undefined;
+  return value.slice(0, MAX_ATTR_LENGTH);
+}
+
+function enqueue(event: VitalEvent): void {
+  if (!ALLOWED_NAMES.has(event.name)) return;
+  if (!Number.isFinite(event.value)) return;
+  buffer.push(event);
+  if (buffer.length >= MAX_BUFFER) flush();
+}
+
+function flush(): void {
+  // Fold any pending longtask total into the batch first.
+  if (longtaskSum > 0) {
+    buffer.push({
+      name: "longtask_ms",
+      value: Math.round(longtaskSum),
+      route: currentRouteTemplate(),
+    });
+    longtaskSum = 0;
+  }
+  if (buffer.length === 0) return;
+
+  const payload = JSON.stringify({ events: buffer });
+  buffer = [];
+
+  try {
+    const blob = new Blob([payload], { type: "application/json" });
+    if (navigator.sendBeacon && navigator.sendBeacon(ENDPOINT, blob)) return;
+    // Fallback for browsers without sendBeacon: keepalive fetch.
+    void fetch(ENDPOINT, {
+      method: "POST",
+      body: payload,
+      headers: { "Content-Type": "application/json" },
+      keepalive: true,
+    }).catch(() => undefined);
+  } catch {
+    // Best-effort: never throw out of telemetry.
+  }
+}
+
+/**
+ * Report a custom client metric (editor_tx_ms, page_open_ms). No-op unless the
+ * session is sampled. Route is always the current TEMPLATE.
+ */
+export function reportClientMetric(
+  name: "editor_tx_ms" | "page_open_ms",
+  value: number,
+  extra?: { docSize?: number },
+): void {
+  if (!isVitalsActive()) return;
+  if (!Number.isFinite(value)) return;
+  enqueue({
+    name,
+    value,
+    route: currentRouteTemplate(),
+    docSize: extra?.docSize,
+  });
+}
+
+/** Threshold-gated editor transaction reporter (only reports slow syncs). */
+export function reportEditorTx(ms: number, docSize: number): void {
+  if (ms <= EDITOR_TX_MIN_MS) return;
+  reportClientMetric("editor_tx_ms", ms, { docSize });
+}
+
+const PAGE_OPEN_MARK = "gm_page_open_start";
+
+/** Mark the start of a page-open interaction (tree-row / link click). */
+export function markPageOpenStart(): void {
+  try {
+    performance.clearMarks(PAGE_OPEN_MARK);
+    performance.mark(PAGE_OPEN_MARK);
+  } catch {
+    // ignore
+  }
+}
+
+/**
+ * Measure page_open_ms at first editor-content render, if a start mark exists.
+ * Consumes the mark so a later render doesn't double-count.
+ */
+export function measurePageOpen(): void {
+  try {
+    const marks = performance.getEntriesByName(PAGE_OPEN_MARK, "mark");
+    if (marks.length === 0) return;
+    const started = marks[0].startTime;
+    const elapsed = performance.now() - started;
+    performance.clearMarks(PAGE_OPEN_MARK);
+    if (elapsed > 0 && Number.isFinite(elapsed)) {
+      reportClientMetric("page_open_ms", elapsed);
+    }
+  } catch {
+    // ignore
+  }
+}
+
+function attrTarget(
+  metric:
+    | INPMetricWithAttribution
+    | LCPMetricWithAttribution
+    | CLSMetricWithAttribution,
+): string | undefined {
+  const a = metric.attribution as Record<string, unknown> | undefined;
+  if (!a) return undefined;
+  // Different vitals expose their culprit element under different keys; only a
+  // CSS-selector-ish target string is taken (no text content / titles).
+  return (
+    truncateAttr(a.interactionTarget) ??
+    truncateAttr(a.element) ??
+    truncateAttr(a.largestShiftTarget) ??
+    undefined
+  );
+}
+
+/**
+ * Initialise client telemetry. Safe to call multiple times (idempotent). Returns
+ * immediately without subscribing when the session is not sampled — so a
+ * non-sampled session subscribes to NO observers and sends nothing.
+ */
+export function initVitals(): void {
+  if (initialised) return;
+  initialised = true;
+
+  // Operator flag gate (F1, default OFF): when telemetry is disabled the sink
+  // endpoint does not even exist server-side, so install ZERO observers.
+  if (!isClientTelemetryEnabled()) return;
+
+  // Sampling gate is evaluated BEFORE any observer subscription.
+  if (!isVitalsSampled()) return;
+
+  const report = (
+    metric:
+      | INPMetricWithAttribution
+      | LCPMetricWithAttribution
+      | CLSMetricWithAttribution
+      | TTFBMetricWithAttribution,
+  ) => {
+    enqueue({
+      name: metric.name,
+      value: metric.value,
+      rating: metric.rating,
+      route: currentRouteTemplate(),
+      attr:
+        metric.name === "TTFB"
+          ? undefined
+          : attrTarget(
+              metric as
+                | INPMetricWithAttribution
+                | LCPMetricWithAttribution
+                | CLSMetricWithAttribution,
+            ),
+    });
+  };
+
+  onINP(report);
+  onLCP(report);
+  onCLS(report);
+  onTTFB(report);
+
+  // Long tasks: aggregate the total blocking time per flush window (a passive
+  // observer; individual entries are summed, never stored/sent individually).
+  try {
+    if (typeof PerformanceObserver !== "undefined") {
+      const observer = new PerformanceObserver((list) => {
+        for (const entry of list.getEntries()) {
+          longtaskSum += entry.duration;
+        }
+      });
+      observer.observe({ type: "longtask", buffered: true });
+    }
+  } catch {
+    // longtask entry type unsupported: skip silently.
+  }
+
+  // page_open_ms start: mark when the user clicks a page link/tree-row (any
+  // anchor navigating to a page URL). Passive capture listener; the matching
+  // measure fires at first editor-content render (measurePageOpen). No page
+  // titles/slugs are read — only the click timing is marked.
+  document.addEventListener(
+    "click",
+    (event) => {
+      const target = event.target as Element | null;
+      const anchor = target?.closest?.("a[href]") as HTMLAnchorElement | null;
+      if (!anchor) return;
+      const href = anchor.getAttribute("href") ?? "";
+      // A page link is `/s/:space/p/:slug`, `/p/:slug` or a share page path.
+      if (/\/p\//.test(href)) markPageOpenStart();
+    },
+    { capture: true, passive: true },
+  );
+
+  // Flush on tab hide (most reliable delivery point) and periodically.
+  const onHidden = () => {
+    if (document.visibilityState === "hidden") flush();
+  };
+  document.addEventListener("visibilitychange", onHidden);
+  window.addEventListener("pagehide", flush);
+
+  setInterval(flush, FLUSH_INTERVAL_MS);
+}

apps/client/src/main.tsx

@@ -22,6 +22,7 @@ import {
   isPostHogEnabled,
 } from "@/lib/config.ts";
 import posthog from "posthog-js";
+import { initVitals } from "@/lib/telemetry/vitals";
 
 export const queryClient = new QueryClient({
   defaultOptions: {
@@ -43,6 +44,10 @@ if (isCloud() && isPostHogEnabled) {
   });
 }
 
+// #355 — client perf-telemetry. Decides sampling ONCE (25%/session) before
+// subscribing to any observer; non-sampled sessions send nothing.
+initVitals();
+
 const container = document.getElementById("root") as HTMLElement;
 const root = (container as any).__reactRoot ??= ReactDOM.createRoot(container);
 

apps/server/package.json

@@ -23,7 +23,7 @@
     "migration:reset": "tsx src/database/migrate.ts down-to NO_MIGRATIONS",
     "migration:codegen": "kysely-codegen --dialect=postgres --camel-case --env-file=../../.env --out-file=./src/database/types/db.d.ts",
     "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
-    "pretest": "pnpm --filter @docmost/editor-ext build && pnpm --filter @docmost/prosemirror-markdown build && pnpm --filter @docmost/git-sync build && pnpm --filter @docmost/mcp build",
+    "pretest": "pnpm --filter @docmost/editor-ext build && pnpm --filter @docmost/prosemirror-markdown build",
     "test": "jest",
     "test:int": "jest --config test/jest-integration.json",
     "test:watch": "jest --watch",
@@ -41,9 +41,9 @@
     "@aws-sdk/s3-request-presigner": "3.1050.0",
     "@azure/storage-blob": "12.31.0",
     "@clickhouse/client": "^1.18.2",
-    "@docmost/git-sync": "workspace:*",
     "@docmost/mcp": "workspace:*",
     "@docmost/pdf-inspector": "1.9.6",
+    "@docmost/prosemirror-markdown": "workspace:*",
     "@fastify/cookie": "^11.0.2",
     "@fastify/multipart": "^10.0.0",
     "@fastify/static": "^9.1.3",
@@ -112,6 +112,7 @@
     "pino-pretty": "^13.1.3",
     "postgres": "^3.4.8",
     "postmark": "^4.0.7",
+    "prom-client": "^15.1.3",
     "react": "^18.3.1",
     "react-email": "6.0.8",
     "reflect-metadata": "^0.2.2",
@@ -175,7 +176,7 @@
       "/node_modules/"
     ],
     "transform": {
-      "happy-dom.+\\.js$": [
+      "(happy-dom.+|prosemirror-markdown/build/.+)\\.js$": [
         "babel-jest",
         {
           "presets": [
@@ -190,33 +191,22 @@
           ]
         }
       ],
-      "^.+\\.(t|j)sx?$": [
-        "ts-jest",
-        {
-          "isolatedModules": true
-        }
-      ]
+      "^.+\\.(t|j)sx?$": "ts-jest"
     },
     "transformIgnorePatterns": [
-      "/node_modules/(?!(\\.pnpm/)?(nanoid|uuid|image-dimensions|marked|happy-dom|lib0)(@|/))"
+      "/node_modules/(?!(\\.pnpm/)?(nanoid|uuid|image-dimensions|marked|happy-dom|lib0|@docmost/prosemirror-markdown)(@|/))"
     ],
     "collectCoverageFrom": [
       "**/*.(t|j)s"
     ],
     "coverageDirectory": "../coverage",
     "testEnvironment": "node",
-    "setupFiles": [
-      "<rootDir>/../test/jest.setup.ts"
-    ],
     "moduleNameMapper": {
       "^@docmost/db/(.*)$": "<rootDir>/database/$1",
       "^@docmost/transactional/(.*)$": "<rootDir>/integrations/transactional/$1",
       "^@docmost/ee/(.*)$": "<rootDir>/ee/$1",
       "^src/(.*)$": "<rootDir>/$1",
-      "^@docmost/git-sync$": "<rootDir>/../../../packages/git-sync/src/index.ts",
-      "^@docmost/git-sync/(.*)$": "<rootDir>/../../../packages/git-sync/src/$1",
-      "^@docmost/prosemirror-markdown$": "<rootDir>/../../../packages/prosemirror-markdown/src/index.ts",
-      "^(\\.{1,2}/.*)\\.js$": "$1"
+      "^@tiptap/react$": "<rootDir>/../test/stubs/tiptap-react.js"
     }
   }
 }

apps/server/src/app.module.ts

@@ -28,10 +28,11 @@ import { ClsModule } from 'nestjs-cls';
 import { NoopAuditModule } from './integrations/audit/audit.module';
 import { ThrottleModule } from './integrations/throttle/throttle.module';
 import { McpModule } from './integrations/mcp/mcp.module';
-import { GitSyncModule } from './integrations/git-sync/git-sync.module';
 import { SandboxModule } from './integrations/sandbox/sandbox.module';
 import { AiModule } from './integrations/ai/ai.module';
 import { AiChatModule } from './core/ai-chat/ai-chat.module';
+import { MetricsModule } from './integrations/metrics/metrics.module';
+import { ClientTelemetryModule } from './core/telemetry/client-telemetry.module';
 
 const enterpriseModules = [];
 try {
@@ -91,10 +92,13 @@ try {
     TelemetryModule,
     ThrottleModule,
     McpModule,
-    GitSyncModule,
     SandboxModule,
     AiModule,
     AiChatModule,
+    MetricsModule,
+    // Gated OFF by default: only registers the public vitals sink controller
+    // when CLIENT_TELEMETRY_ENABLED=true (maintainer decision E1=B).
+    ClientTelemetryModule.register(),
     ...enterpriseModules,
   ],
   controllers: [AppController],

apps/server/src/collaboration/collaboration.gateway.ts

@@ -188,45 +188,6 @@ export class CollaborationGateway {
     return this.hocuspocus.openDirectConnection(documentName, context);
   }
 
-  /**
-   * Write a git-originated body into a page, applying the merge on the instance
-   * that OWNS the live Y.Doc so a connected editor CONVERGES on the change.
-   *
-   * git-sync must NOT use openDirectConnection directly for this: that opens the
-   * document on whichever instance/process runs git-sync (the API/worker). When
-   * an editor is connected to a DIFFERENT collab instance/process, that is a
-   * SEPARATE, detached Y.Doc — the merge lands in the detached doc and the DB,
-   * but the live editor never receives the Yjs update; its next debounced
-   * autosave then overwrites the DB with its stale state and SILENTLY REVERTS
-   * the git change (the data-loss bug). Routing through the custom-event channel
-   * runs the merge on the owning instance's shared Document, whose update is
-   * broadcast to every connection (handleUpdate), so the editor's CRDT converges
-   * on the merged result.
-   *
-   * Without redis there is a single instance, so the write runs locally — which
-   * is already the owning (and only) instance the editor is connected to.
-   */
-  async writePageBody(
-    documentName: string,
-    payload: {
-      prosemirrorJson: unknown;
-      baseProsemirrorJson?: unknown;
-      userId: string;
-    },
-  ): Promise<void> {
-    if (this.redisSync) {
-      await this.handleYjsEvent(
-        'gitSyncWriteBody',
-        documentName,
-        payload as any,
-      );
-      return;
-    }
-    await this.collabEventsService
-      .getHandlers(this.hocuspocus)
-      .gitSyncWriteBody(documentName, payload as any);
-  }
-
   /*
    *Can be used before calling openDirectConnection directly
    */

apps/server/src/collaboration/collaboration.handler.git-sync.spec.ts

@@ -1,262 +0,0 @@
-// Exercises the REAL `gitSyncWriteBody` collab handler (the owner-routed body
-// write the data-loss fix introduces). The handler imports the editor graph via
-// collaboration.util / yjs.util (tiptapExtensions -> editor-ext -> react-dom,
-// unloadable under jest's node env, same coupling noted in
-// gitmost-datasource.service.spec.ts), so we stub those + the transformer. The
-// stubbed toYdoc builds paragraph blocks straight from the ProseMirror JSON so
-// we can assert convergence on real text.
-jest.mock('./collaboration.util', () => ({
-  tiptapExtensions: [],
-  getPageId: (name: string) => name.replace(/^page\./, ''),
-  prosemirrorNodeToYElement: jest.fn(),
-}));
-jest.mock('./yjs.util', () => ({
-  setYjsMark: jest.fn(),
-  updateYjsMarkAttribute: jest.fn(),
-}));
-jest.mock('@hocuspocus/transformer', () => {
-  const Yjs = require('yjs');
-  return {
-    TiptapTransformer: {
-      toYdoc: (json: any) => {
-        if (json?.__throw) throw new Error('boom: malformed doc');
-        const d = new Yjs.Doc();
-        const frag = d.getXmlFragment('default');
-        const blocks = (json?.content ?? []).map((node: any) => {
-          const el = new Yjs.XmlElement(node.type || 'paragraph');
-          const text = (node.content ?? [])
-            .map((t: any) => t.text ?? '')
-            .join('');
-          const t = new Yjs.XmlText();
-          if (text) t.insert(0, text);
-          el.insert(0, [t]);
-          return el;
-        });
-        if (blocks.length) frag.insert(0, blocks);
-        return d;
-      },
-    },
-  };
-});
-
-import * as Y from 'yjs';
-import { CollaborationHandler } from './collaboration.handler';
-
-const pmDoc = (...paras: string[]) => ({
-  type: 'doc',
-  content: paras.map((text) => ({
-    type: 'paragraph',
-    content: text ? [{ type: 'text', text }] : [],
-  })),
-});
-
-const texts = (frag: Y.XmlFragment): string[] =>
-  frag.toArray().map((el) =>
-    (el as Y.XmlElement)
-      .toArray()
-      .map((c) => (c as Y.XmlText).toString())
-      .join(''),
-  );
-
-// Build a fake Hocuspocus whose openDirectConnection yields a DirectConnection
-// over a REAL shared Document, with a connected "editor" doc that receives the
-// shared doc's updates (modelling Document.handleUpdate's broadcast on the
-// OWNING instance). Initial content carries live block ids; the editor starts
-// fully synced with the shared doc.
-function fakeHocuspocus(initial: { text: string; id: string }[]) {
-  const shared = new Y.Doc();
-  const frag = shared.getXmlFragment('default');
-  shared.transact(() => {
-    frag.insert(
-      0,
-      initial.map((s) => {
-        const el = new Y.XmlElement('paragraph');
-        el.setAttribute('id', s.id);
-        const t = new Y.XmlText();
-        if (s.text) t.insert(0, s.text);
-        el.insert(0, [t]);
-        return el;
-      }),
-    );
-  });
-  const editor = new Y.Doc();
-  Y.applyUpdate(editor, Y.encodeStateAsUpdate(shared));
-  // Broadcast relay: server-originated updates flow to the connected editor.
-  shared.on('update', (u: Uint8Array, origin: any) => {
-    if (origin !== 'editor') Y.applyUpdate(editor, u, 'server');
-  });
-
-  const openDirectConnection = jest.fn(async () => ({
-    // DirectConnection.transact runs the fn directly against the Document (no
-    // wrapping Y transaction), exactly like @hocuspocus/server.
-    transact: async (fn: (doc: Y.Doc) => void) => fn(shared),
-    disconnect: jest.fn(async () => undefined),
-  }));
-
-  return { hocuspocus: { openDirectConnection } as any, shared, editor };
-}
-
-describe('CollaborationHandler.gitSyncWriteBody (owner-routed body write)', () => {
-  it('converges a connected editor on the git change (no silent revert)', async () => {
-    const { hocuspocus, shared, editor } = fakeHocuspocus([
-      { text: 'alpha', id: 'p1' },
-      { text: 'beta', id: 'p2' },
-    ]);
-    const handler = new CollaborationHandler();
-    const handlers = handler.getHandlers(hocuspocus);
-
-    // git changed block 1 beta -> beta2; base is the pre-change content.
-    await handlers.gitSyncWriteBody('page.x', {
-      prosemirrorJson: pmDoc('alpha', 'beta2'),
-      baseProsemirrorJson: pmDoc('alpha', 'beta'),
-      userId: 'svc-user',
-    });
-
-    // The shared (owning-instance) doc holds the merge...
-    expect(texts(shared.getXmlFragment('default'))).toEqual(['alpha', 'beta2']);
-    // ...and the connected editor CONVERGED via the broadcast (the bug would
-    // leave it on 'beta' and revert the page on its next autosave).
-    expect(texts(editor.getXmlFragment('default'))).toEqual(['alpha', 'beta2']);
-  });
-
-  it('preserves a concurrent edit to a DIFFERENT block (3-way, finding #2)', async () => {
-    const { hocuspocus, shared, editor } = fakeHocuspocus([
-      { text: 'alpha', id: 'p1' },
-      { text: 'beta', id: 'p2' },
-    ]);
-    // The editor is actively editing block 0 while the push arrives.
-    const eFrag = editor.getXmlFragment('default');
-    editor.transact(
-      () => (eFrag.get(0) as Y.XmlElement).get(0) instanceof Y.XmlText &&
-        ((eFrag.get(0) as Y.XmlElement).get(0) as Y.XmlText).insert(5, ' EDIT'),
-      'editor',
-    );
-    Y.applyUpdate(shared, Y.encodeStateAsUpdate(editor), 'editor');
-
-    const handler = new CollaborationHandler();
-    await handler.getHandlers(hocuspocus).gitSyncWriteBody('page.x', {
-      prosemirrorJson: pmDoc('alpha', 'beta2'),
-      baseProsemirrorJson: pmDoc('alpha', 'beta'),
-      userId: 'svc-user',
-    });
-
-    // Human's block-0 edit AND git's block-1 change both survive on the editor.
-    expect(texts(editor.getXmlFragment('default'))).toEqual([
-      'alpha EDIT',
-      'beta2',
-    ]);
-  });
-
-  it('FLUSHES the pending debounced store BEFORE merging so an in-flight edit survives (finding #2)', async () => {
-    // QA #119 finding #2: the 3-way merge must run against the latest live-doc
-    // state. A concurrent UI edit that is still in-flight (the store is debounced)
-    // must be drained into the live doc BEFORE git merges, or git clean-applies and
-    // the edit is silently dropped — even on a DIFFERENT block. Model the drain via
-    // the pending-store flush: when it runs, the in-flight block-0 edit lands.
-    const shared = new Y.Doc();
-    const frag = shared.getXmlFragment('default');
-    shared.transact(() => {
-      frag.insert(
-        0,
-        [
-          { text: 'alpha', id: 'p1' },
-          { text: 'beta', id: 'p2' },
-        ].map((s) => {
-          const el = new Y.XmlElement('paragraph');
-          el.setAttribute('id', s.id);
-          const t = new Y.XmlText();
-          t.insert(0, s.text);
-          el.insert(0, [t]);
-          return el;
-        }),
-      );
-    });
-
-    const order: string[] = [];
-    const debouncer = {
-      isDebounced: jest.fn(() => true),
-      executeNow: jest.fn(async () => {
-        order.push('flush');
-        // The in-flight client edit to block 0 only lands once the pending store
-        // is flushed (i.e. the event loop is drained) — BEFORE the merge.
-        shared.transact(() =>
-          ((frag.get(0) as Y.XmlElement).get(0) as Y.XmlText).insert(5, ' EDIT'),
-        );
-      }),
-    };
-    const openDirectConnection = jest.fn(async () => ({
-      transact: async (fn: (doc: Y.Doc) => void) => {
-        order.push('merge');
-        fn(shared);
-      },
-      disconnect: jest.fn(async () => undefined),
-    }));
-    const hocuspocus = { openDirectConnection, debouncer } as any;
-
-    const handler = new CollaborationHandler();
-    await handler.getHandlers(hocuspocus).gitSyncWriteBody('page.x', {
-      prosemirrorJson: pmDoc('alpha', 'beta2'), // git changes block 1
-      baseProsemirrorJson: pmDoc('alpha', 'beta'),
-      userId: 'svc-user',
-    });
-
-    // The flush ran, and it ran BEFORE the merge transaction.
-    expect(debouncer.executeNow).toHaveBeenCalledTimes(1);
-    expect(order).toEqual(['flush', 'merge']);
-    // Both the in-flight block-0 edit and git's block-1 change survive — the
-    // pre-flush bug would have produced ['alpha', 'beta2'] (UI edit dropped).
-    expect(texts(shared.getXmlFragment('default'))).toEqual([
-      'alpha EDIT',
-      'beta2',
-    ]);
-  });
-
-  it('does not flush when no store is pending (isDebounced false)', async () => {
-    const { hocuspocus, shared } = fakeHocuspocus([{ text: 'a', id: 'p1' }]);
-    const executeNow = jest.fn();
-    (hocuspocus as any).debouncer = {
-      isDebounced: jest.fn(() => false),
-      executeNow,
-    };
-    const handler = new CollaborationHandler();
-    await handler.getHandlers(hocuspocus).gitSyncWriteBody('page.x', {
-      prosemirrorJson: pmDoc('a', 'b'),
-      userId: 'svc-user',
-    });
-    expect(executeNow).not.toHaveBeenCalled();
-    expect(texts(shared.getXmlFragment('default'))).toEqual(['a', 'b']);
-  });
-
-  it('crash-safe: a transform failure never opens the connection or mutates the live doc', async () => {
-    const { hocuspocus, shared } = fakeHocuspocus([{ text: 'alpha', id: 'p1' }]);
-    const before = texts(shared.getXmlFragment('default'));
-    const handler = new CollaborationHandler();
-
-    await expect(
-      handler.getHandlers(hocuspocus).gitSyncWriteBody('page.x', {
-        prosemirrorJson: { __throw: true } as any,
-        userId: 'svc-user',
-      }),
-    ).rejects.toThrow('boom');
-
-    // The incoming doc is built BEFORE opening the connection, so the throw
-    // happens first: the live doc is untouched and no connection was opened.
-    expect(hocuspocus.openDirectConnection).not.toHaveBeenCalled();
-    expect(texts(shared.getXmlFragment('default'))).toEqual(before);
-  });
-
-  it('falls back to a 2-way merge when no base is supplied', async () => {
-    const { hocuspocus, shared, editor } = fakeHocuspocus([
-      { text: 'alpha', id: 'p1' },
-    ]);
-    const handler = new CollaborationHandler();
-
-    await handler.getHandlers(hocuspocus).gitSyncWriteBody('page.x', {
-      prosemirrorJson: pmDoc('alpha', 'gamma'),
-      userId: 'svc-user',
-    });
-
-    expect(texts(shared.getXmlFragment('default'))).toEqual(['alpha', 'gamma']);
-    expect(texts(editor.getXmlFragment('default'))).toEqual(['alpha', 'gamma']);
-  });
-});

apps/server/src/collaboration/collaboration.handler.ts

@@ -14,10 +14,6 @@ import {
 } from './yjs.util';
 import * as Y from 'yjs';
 import { User } from '@docmost/db/types/entity.types';
-import {
-  mergeXmlFragments,
-  mergeXmlFragments3WayWithStats,
-} from './merge/yjs-body-merge';
 
 export type CollabEventHandlers = ReturnType<
   CollaborationHandler['getHandlers']
@@ -185,130 +181,9 @@ export class CollaborationHandler {
           },
         );
       },
-      /**
-       * Git-sync body write, applied as a block-level MERGE into the LIVE doc on
-       * the instance that OWNS it (routed here via the custom-event channel —
-       * see CollaborationGateway.writePageBody). Running on the owning instance
-       * is what makes a connected editor CONVERGE: the merge mutates the shared
-       * Document, whose update is broadcast to every connection, so the editor's
-       * CRDT applies the git change instead of silently reverting it on its next
-       * autosave (the data-loss bug this fixes).
-       *
-       * With a `baseProsemirrorJson` (the last-synced common ancestor) it does a
-       * THREE-WAY merge — a block only the human changed is kept, a block only
-       * git changed is taken (conflicts -> git). Without a base it falls back to
-       * the 2-way merge.
-       */
-      gitSyncWriteBody: async (
-        documentName: string,
-        payload: {
-          prosemirrorJson: any;
-          baseProsemirrorJson?: any;
-          userId: string;
-        },
-      ) => {
-        const { prosemirrorJson, baseProsemirrorJson, userId } = payload;
-
-        // Build the incoming (and base) Yjs docs BEFORE opening the connection /
-        // touching the live doc. If a transform throws (a malformed/unsupported
-        // doc) we must NOT have mutated the live body — otherwise a conversion
-        // failure could leave the page empty (crash-safe conversion).
-        const targetDoc = TiptapTransformer.toYdoc(
-          prosemirrorJson,
-          'default',
-          tiptapExtensions,
-        );
-        const baseDoc =
-          baseProsemirrorJson != null
-            ? TiptapTransformer.toYdoc(
-                baseProsemirrorJson,
-                'default',
-                tiptapExtensions,
-              )
-            : null;
-
-        // CONCURRENT-EDIT FLUSH (QA #119, finding #2). The 3-way merge below runs
-        // against the LIVE Y.Doc, so a concurrent UI edit is only preserved if it
-        // is already part of that doc. A user's edit is debounced before it lands
-        // (the editor batches; the collab store is debounced up to 10s), so the
-        // merge could otherwise run against a PRE-EDIT doc: git would then
-        // clean-apply (no same-block conflict detected) and the in-flight UI edit
-        // — even on a DIFFERENT block — would be silently dropped.
-        //
-        // Flushing the pending debounced store here (a) drains the event loop so a
-        // just-arrived client Yjs update is applied to the live doc BEFORE we
-        // merge, and (b) persists the live doc so the merge baseline is current
-        // even on the doc-reload-from-DB path. After the flush the merge sees the
-        // latest state, so an edit on a different block is MERGED (not overwritten)
-        // and a genuine same-block edit is detected as a conflict -> the
-        // boundary-snapshot in PersistenceExtension pins it to page history
-        // (recoverable) instead of vanishing silently.
-        await this.flushPendingStore(hocuspocus, documentName);
-
-        // actor:'git-sync' + the service user flow into PersistenceExtension
-        // (lastUpdatedSource='git-sync', lastUpdatedById=userId).
-        await this.withYdocConnection(
-          hocuspocus,
-          documentName,
-          { actor: 'git-sync', user: { id: userId } },
-          (doc) => {
-            const liveFrag = doc.getXmlFragment('default');
-            const targetFrag = targetDoc.getXmlFragment('default');
-            if (baseDoc) {
-              const { conflicts } = mergeXmlFragments3WayWithStats(
-                liveFrag,
-                targetFrag,
-                baseDoc.getXmlFragment('default'),
-              );
-              // SAME-BLOCK conflict contract (SPEC §9): a block both the human
-              // and git changed resolves to GIT (deterministic). Make that
-              // OBSERVABLE rather than silent — log it. The losing human content
-              // is NOT destroyed: the persistence extension's boundary snapshot
-              // pins the pre-merge page state to history on this user->git-sync
-              // transition, so it stays recoverable.
-              if (conflicts > 0) {
-                this.logger.warn(
-                  `git-sync merge for ${documentName}: ${conflicts} same-block ` +
-                    `conflict(s) resolved to the git version; the prior page ` +
-                    `state is preserved in page history (recoverable).`,
-                );
-              }
-            } else {
-              mergeXmlFragments(liveFrag, targetFrag);
-            }
-          },
-        );
-      },
     };
   }
 
-  /**
-   * Flush any pending DEBOUNCED store for `documentName` so the live Y.Doc and the
-   * DB are current BEFORE a git-sync merge reads them (QA #119, finding #2 —
-   * concurrent UI edit silently lost). Mirrors the PersistenceExtension.onDisconnect
-   * flush: only acts when a store is actually pending (`isDebounced`), runs the
-   * SAME scheduled payload (`executeNow`, preserving the edit's context/actor), and
-   * never throws — a flush failure must not abort the git-sync write. Awaiting it
-   * also drains the event loop, so a client Yjs update sitting in the socket buffer
-   * is applied to the live doc before the merge transaction runs.
-   */
-  private async flushPendingStore(
-    hocuspocus: Hocuspocus,
-    documentName: string,
-  ): Promise<void> {
-    const debounceId = `onStoreDocument-${documentName}`;
-    try {
-      const debouncer = (hocuspocus as any)?.debouncer;
-      if (!debouncer?.isDebounced?.(debounceId)) return;
-      await debouncer.executeNow(debounceId);
-    } catch (err) {
-      this.logger.warn(
-        `git-sync pre-merge flush failed for ${documentName}: ` +
-          (err instanceof Error ? err.message : String(err)),
-      );
-    }
-  }
-
   async withYdocConnection<T>(
     hocuspocus: Hocuspocus,
     documentName: string,

apps/server/src/collaboration/collaboration.util.ts

@@ -43,7 +43,6 @@ import {
   Column,
   Status,
   addUniqueIdsToDoc,
-  htmlToMarkdown,
   TransclusionSource,
   TransclusionReference,
   FootnoteReference,
@@ -51,6 +50,7 @@ import {
   FootnoteDefinition,
   PageEmbed,
 } from '@docmost/editor-ext';
+import { convertProseMirrorToMarkdown } from '@docmost/prosemirror-markdown';
 import { generateText, getSchema, JSONContent } from '@tiptap/core';
 import { generateHTML, generateJSON } from '../common/helpers/prosemirror/html';
 // @tiptap/html library works best for generating prosemirror json state but not HTML
@@ -239,6 +239,10 @@ export function prosemirrorNodeToYElement(node: any): Y.XmlElement | Y.XmlText {
 }
 
 export function jsonToMarkdown(tiptapJson: any): string {
-  const html = jsonToHtml(tiptapJson);
-  return htmlToMarkdown(html);
+  // Direct ProseMirror JSON -> Markdown via the canonical converter
+  // (`@docmost/prosemirror-markdown`) — no HTML intermediate, no second
+  // editor-ext markdown layer. Same serializer as the page/space export and the
+  // git-sync vault writer, so every server PM->MD path emits identical canonical
+  // markdown (issue #345).
+  return convertProseMirrorToMarkdown(tiptapJson);
 }

apps/server/src/collaboration/extensions/persistence.disconnect-flush.spec.ts

@@ -1,89 +0,0 @@
-import { PersistenceExtension } from './persistence.extension';
-
-/**
- * Regression for the QA #119 "loss-on-fast-close" data loss: editing a page then
- * closing the tab within the collab debounce window (~3-18s) lost the edit
- * because, with `unloadImmediately: false`, Hocuspocus does NOT flush the
- * debounced onStoreDocument on a last-client disconnect. PersistenceExtension
- * now flushes the pending store on the LAST disconnect (and only then).
- */
-describe('PersistenceExtension.onDisconnect flush (loss-on-fast-close)', () => {
-  function makeExt(): PersistenceExtension {
-    // onDisconnect touches none of the injected deps; pass casts.
-    return new PersistenceExtension(
-      null as any,
-      null as any,
-      null as any,
-      null as any,
-      null as any,
-      null as any,
-      null as any,
-      null as any,
-    );
-  }
-
-  function makeData(opts: {
-    clientsCount: number;
-    isDebounced: boolean;
-    isLoading?: boolean;
-  }) {
-    const executeNow = jest.fn(async () => undefined);
-    const isDebounced = jest.fn(() => opts.isDebounced);
-    return {
-      executeNow,
-      isDebounced,
-      payload: {
-        clientsCount: opts.clientsCount,
-        context: {},
-        document: { isLoading: opts.isLoading ?? false } as any,
-        documentName: 'page.abc',
-        instance: { debouncer: { isDebounced, executeNow } } as any,
-        requestHeaders: {},
-        requestParameters: new URLSearchParams(),
-        socketId: 's',
-      } as any,
-    };
-  }
-
-  it('flushes the pending store when the LAST client disconnects', async () => {
-    const ext = makeExt();
-    const { executeNow, payload } = makeData({
-      clientsCount: 0,
-      isDebounced: true,
-    });
-    await ext.onDisconnect(payload);
-    expect(executeNow).toHaveBeenCalledTimes(1);
-    expect(executeNow).toHaveBeenCalledWith('onStoreDocument-page.abc');
-  });
-
-  it('does NOT flush while other editors remain connected', async () => {
-    const ext = makeExt();
-    const { executeNow, payload } = makeData({
-      clientsCount: 2,
-      isDebounced: true,
-    });
-    await ext.onDisconnect(payload);
-    expect(executeNow).not.toHaveBeenCalled();
-  });
-
-  it('does NOT write when nothing is pending (already persisted)', async () => {
-    const ext = makeExt();
-    const { executeNow, payload } = makeData({
-      clientsCount: 0,
-      isDebounced: false,
-    });
-    await ext.onDisconnect(payload);
-    expect(executeNow).not.toHaveBeenCalled();
-  });
-
-  it('does NOT flush a doc that is still loading (load error guard)', async () => {
-    const ext = makeExt();
-    const { executeNow, payload } = makeData({
-      clientsCount: 0,
-      isDebounced: true,
-      isLoading: true,
-    });
-    await ext.onDisconnect(payload);
-    expect(executeNow).not.toHaveBeenCalled();
-  });
-});

apps/server/src/collaboration/extensions/persistence.extension.spec.ts

@@ -1,223 +0,0 @@
-// Stub collaboration.util so importing the extension does not drag in the
-// editor-ext -> @tiptap/react -> react-dom graph (unloadable under jest's node
-// env, same coupling the gitmost-datasource / mcp specs document). The
-// extension only calls getPageId, jsonToText and isEmptyParagraphDoc from it on
-// the store path; tiptapExtensions is unused by onStoreDocument.
-jest.mock('../collaboration.util', () => ({
-  tiptapExtensions: [],
-  getPageId: (name: string) => name.replace(/^page\./, ''),
-  jsonToText: () => 'text',
-  isEmptyParagraphDoc: () => false,
-  // The post-write mention extraction walks the doc via jsonToNode().descendants;
-  // return a node-like stub with no descendants so no mentions are produced
-  // (mention handling is out of scope here — we only assert provenance).
-  jsonToNode: () => ({ descendants: () => undefined }),
-}));
-
-// Control the Yjs<->JSON bridge: fromYdoc returns the "incoming" doc the writer
-// is storing. We keep it distinct from the page's persisted content so the
-// no-op guard (isDeepStrictEqual) never short-circuits the write.
-const INCOMING_JSON = { type: 'doc', content: [{ type: 'paragraph' }, { t: 1 }] };
-jest.mock('@hocuspocus/transformer', () => ({
-  TiptapTransformer: {
-    fromYdoc: jest.fn(() => INCOMING_JSON),
-    toYdoc: jest.fn(),
-  },
-}));
-
-// Run the executeTx callback inline with a passthrough trx.
-jest.mock('@docmost/db/utils', () => ({
-  executeTx: jest.fn(async (_db: any, cb: any) => cb({} as any)),
-}));
-
-import * as Y from 'yjs';
-import { PersistenceExtension } from './persistence.extension';
-import {
-  onChangePayload,
-  onStoreDocumentPayload,
-} from '@hocuspocus/server';
-
-/**
- * Provenance-precedence coverage for PersistenceExtension.onStoreDocument
- * (test-strategy Module 4 / item #2): the contract `agent > git-sync > user`,
- * plus the negative that a git-sync store does NOT pin a boundary history
- * snapshot. We drive the precedence through the real public method (onChange to
- * arm the sticky agent marker, then onStoreDocument), mocking the repos / db /
- * Yjs bridge so no real database or collab server is needed. The store's
- * persisted `lastUpdatedSource` and the saveHistory call are the observable
- * outputs.
- */
-describe('PersistenceExtension.onStoreDocument — provenance precedence (#2)', () => {
-  const DOCUMENT_NAME = 'page.page-1';
-  const PAGE_ID = 'page-1';
-
-  // `page.content` differs from INCOMING_JSON so the write is never skipped.
-  const persistedPage = (overrides?: { lastUpdatedSource?: string }) => ({
-    id: PAGE_ID,
-    slugId: 'slug-1',
-    spaceId: 'space-1',
-    workspaceId: 'ws-1',
-    creatorId: 'creator-1',
-    contributorIds: ['creator-1'],
-    content: { type: 'doc', content: [{ type: 'paragraph', content: [] }] },
-    lastUpdatedSource: overrides?.lastUpdatedSource ?? 'user',
-    createdAt: new Date(),
-  });
-
-  const build = (pageOverrides?: { lastUpdatedSource?: string }) => {
-    const pageRepo = {
-      findById: jest.fn().mockResolvedValue(persistedPage(pageOverrides)),
-      updatePage: jest.fn().mockResolvedValue({ numUpdatedRows: 1n }),
-    };
-    const pageHistoryRepo = {
-      // No prior snapshot -> humanBaselineMissing is true, so the ONLY thing
-      // gating the boundary snapshot in these tests is the source precedence.
-      findPageLastHistory: jest.fn().mockResolvedValue(null),
-      saveHistory: jest.fn().mockResolvedValue(undefined),
-    };
-    const aiQueue = { add: jest.fn().mockResolvedValue(undefined) };
-    const historyQueue = { add: jest.fn().mockResolvedValue(undefined) };
-    const notificationQueue = { add: jest.fn().mockResolvedValue(undefined) };
-    const collabHistory = {
-      addContributors: jest.fn().mockResolvedValue(undefined),
-    };
-    const transclusionService = {
-      syncPageTransclusions: jest.fn().mockResolvedValue(undefined),
-      syncPageReferences: jest.fn().mockResolvedValue(undefined),
-      syncPageTemplateReferences: jest.fn().mockResolvedValue(undefined),
-    };
-
-    const ext = new PersistenceExtension(
-      pageRepo as any,
-      pageHistoryRepo as any,
-      {} as any, // db
-      aiQueue as any,
-      historyQueue as any,
-      notificationQueue as any,
-      collabHistory as any,
-      transclusionService as any,
-    );
-
-    return { ext, pageRepo, pageHistoryRepo, historyQueue };
-  };
-
-  // A real Y.Doc is required for Y.encodeStateAsUpdate(document); broadcastStateless
-  // is a no-op spy. The fromYdoc bridge is mocked, so the doc's contents are
-  // irrelevant to the JSON path.
-  const makeStorePayload = (context: any): onStoreDocumentPayload =>
-    ({
-      documentName: DOCUMENT_NAME,
-      document: Object.assign(new Y.Doc(), {
-        broadcastStateless: jest.fn(),
-      }),
-      context,
-    }) as any;
-
-  const makeChangePayload = (actor: string): onChangePayload =>
-    ({
-      documentName: DOCUMENT_NAME,
-      context: { user: { id: 'user-1' }, actor },
-    }) as any;
-
-  const sourceOf = (pageRepo: { updatePage: jest.Mock }) =>
-    pageRepo.updatePage.mock.calls[0][0].lastUpdatedSource;
-
-  it("tags 'user' for a plain write (no agent touch, no git-sync actor)", async () => {
-    const { ext, pageRepo } = build();
-
-    await ext.onStoreDocument(
-      makeStorePayload({ user: { id: 'user-1' }, actor: 'user' }),
-    );
-
-    expect(sourceOf(pageRepo)).toBe('user');
-  });
-
-  it("tags 'git-sync' when the writer's actor is 'git-sync' and no agent touched the window", async () => {
-    const { ext, pageRepo } = build();
-
-    await ext.onStoreDocument(
-      makeStorePayload({ user: { id: 'svc-user' }, actor: 'git-sync' }),
-    );
-
-    expect(sourceOf(pageRepo)).toBe('git-sync');
-  });
-
-  it("keeps 'git-sync' for an explicit git-sync store even with a sticky agent marker (#14 loop-guard)", async () => {
-    const { ext, pageRepo } = build();
-
-    // An agent edit landed earlier in the coalescing window (sticky marker),
-    // then a git-sync writer performs the store. Red-team finding #14: an
-    // EXPLICIT current-write actor is authoritative for THIS write, so the
-    // store must stay 'git-sync' — otherwise the PageChangeListener loop-guard
-    // (keyed on lastUpdatedSource === 'git-sync') fails to recognize git-sync's
-    // own write and re-exports it. Explicit 'agent' still wins (see below); the
-    // sticky marker only promotes a plain human writer to 'agent'.
-    await ext.onChange(makeChangePayload('agent'));
-    await ext.onStoreDocument(
-      makeStorePayload({ user: { id: 'svc-user' }, actor: 'git-sync' }),
-    );
-
-    expect(sourceOf(pageRepo)).toBe('git-sync');
-  });
-
-  it("tags 'agent' when the storing writer itself is the agent (no prior onChange)", async () => {
-    const { ext, pageRepo } = build();
-
-    await ext.onStoreDocument(
-      makeStorePayload({ user: { id: 'agent-user' }, actor: 'agent' }),
-    );
-
-    expect(sourceOf(pageRepo)).toBe('agent');
-  });
-
-  // --- boundary snapshot for a git-sync store over a HUMAN baseline -----------
-  // SPEC §9 observable-loss guard (bug #2): a git-sync body write is a block-level
-  // 3-way merge whose same-block rule is "git wins". To keep a concurrent human
-  // edit RECOVERABLE rather than silently overwritten, a git-sync store over a
-  // prior NON-git-sync baseline pins that prior state to page history first —
-  // exactly like the agent path. So saveHistory MUST be called here.
-  it('DOES pin a boundary snapshot for a git-sync store over a prior human state', async () => {
-    const { ext, pageHistoryRepo } = build({ lastUpdatedSource: 'user' });
-
-    await ext.onStoreDocument(
-      makeStorePayload({ user: { id: 'svc-user' }, actor: 'git-sync' }),
-    );
-
-    expect(pageHistoryRepo.saveHistory).toHaveBeenCalledTimes(1);
-  });
-
-  // --- negative: a git-sync store over a git-sync baseline does NOT re-pin -----
-  // The boundary is pinned once on the transition INTO git-sync; a subsequent
-  // git-sync store over an already-git-sync baseline must not churn history.
-  it('does NOT re-pin a boundary snapshot for a git-sync store over a git-sync baseline', async () => {
-    const { ext, pageHistoryRepo } = build({ lastUpdatedSource: 'git-sync' });
-
-    await ext.onStoreDocument(
-      makeStorePayload({ user: { id: 'svc-user' }, actor: 'git-sync' }),
-    );
-
-    expect(pageHistoryRepo.saveHistory).not.toHaveBeenCalled();
-  });
-
-  it('DOES pin a boundary snapshot for an agent store over a prior human state (control)', async () => {
-    // Confirms the negative above is meaningful: under the SAME mocks, an agent
-    // store over a 'user' baseline DOES trigger the boundary snapshot.
-    const { ext, pageHistoryRepo } = build({ lastUpdatedSource: 'user' });
-
-    await ext.onStoreDocument(
-      makeStorePayload({ user: { id: 'agent-user' }, actor: 'agent' }),
-    );
-
-    expect(pageHistoryRepo.saveHistory).toHaveBeenCalledTimes(1);
-  });
-
-  it('does NOT pin a boundary snapshot for a plain user store', async () => {
-    const { ext, pageHistoryRepo } = build({ lastUpdatedSource: 'user' });
-
-    await ext.onStoreDocument(
-      makeStorePayload({ user: { id: 'user-1' }, actor: 'user' }),
-    );
-
-    expect(pageHistoryRepo.saveHistory).not.toHaveBeenCalled();
-  });
-});

apps/server/src/collaboration/extensions/persistence.extension.ts

@@ -2,7 +2,6 @@ import {
   afterUnloadDocumentPayload,
   Extension,
   onChangePayload,
-  onDisconnectPayload,
   onLoadDocumentPayload,
   onStatelessPayload,
   onStoreDocumentPayload,
@@ -42,6 +41,7 @@ import {
   HISTORY_INTERVAL,
 } from '../constants';
 import { TransclusionService } from '../../core/page/transclusion/transclusion.service';
+import { observeCollabStore } from '../../integrations/metrics/metrics.registry';
 
 /**
  * #251 — wire format of the client→server stateless message that signals a
@@ -83,17 +83,7 @@ export function resolveSource(
   stickyTouched: boolean,
   contextActor?: string,
 ): ProvenanceSource {
-  // An EXPLICIT current-write actor is authoritative for THIS write and wins
-  // over the sticky-agent fallback. Order: explicit 'agent' > explicit
-  // 'git-sync' > sticky agent marker > plain human 'user'. The git-sync case
-  // must NOT be masked by the sticky marker, or the PageChangeListener
-  // loop-guard (which keys on lastUpdatedSource === 'git-sync') would re-export
-  // git-sync's own writes (#14). Explicit agent still wins so a window that
-  // mixed an agent edit stays tagged 'agent'.
-  if (contextActor === 'agent') return 'agent';
-  if (contextActor === 'git-sync') return 'git-sync';
-  if (stickyTouched) return 'agent';
-  return 'user';
+  return stickyTouched || contextActor === 'agent' ? 'agent' : 'user';
 }
 
 /**
@@ -202,41 +192,18 @@ export class PersistenceExtension implements Extension {
     return new Y.Doc();
   }
 
-  /**
-   * LOSS-ON-FAST-CLOSE FIX (QA #119). When the LAST editor disconnects, FLUSH any
-   * pending (debounced) store to the DB IMMEDIATELY instead of waiting out the
-   * up-to-10s `debounce` window.
-   *
-   * The collab server runs with `unloadImmediately: false` (collaboration.gateway),
-   * so on a last-client disconnect Hocuspocus does NOT flush the debounced
-   * onStoreDocument — it relies on the timer firing later. A quick edit-then-close
-   * (closing the tab within the debounce window, ~3-18s) therefore left the edit
-   * only in the soon-to-be-unloaded in-memory Y.Doc; meanwhile git-sync mirrored
-   * the STALE/empty DB body to the vault (the reported "59-byte frontmatter-only"
-   * data loss). Running the already-scheduled store now closes that window.
-   *
-   * Gated tightly so it never adds a redundant write: only on the LAST disconnect
-   * (`clientsCount === 0`), only for a fully-loaded doc, and only when a store is
-   * actually pending (`isDebounced`). `executeNow` runs the SAME payload Hocuspocus
-   * scheduled (preserving the edit's context/actor) and clears the timer.
-   */
-  async onDisconnect(data: onDisconnectPayload) {
-    const { instance, document, documentName, clientsCount } = data;
-    if (clientsCount > 0) return;
-    if (!document || document.isLoading) return;
-    const debounceId = `onStoreDocument-${documentName}`;
-    if (!instance?.debouncer?.isDebounced(debounceId)) return;
+  async onStoreDocument(data: onStoreDocumentPayload) {
+    // #355 — time the full store (persist + post-store side effects) into
+    // collab_store_duration_seconds. No-op when METRICS_PORT is unset.
+    const startedAt = performance.now();
     try {
-      await instance.debouncer.executeNow(debounceId);
-    } catch (err) {
-      this.logger.error(
-        `onDisconnect flush failed for ${documentName}: ` +
-          (err instanceof Error ? err.message : String(err)),
-      );
+      await this.storeDocument(data);
+    } finally {
+      observeCollabStore((performance.now() - startedAt) / 1000);
     }
   }
 
-  async onStoreDocument(data: onStoreDocumentPayload) {
+  private async storeDocument(data: onStoreDocumentPayload) {
     const { documentName, document, context } = data;
 
     const pageId = getPageId(documentName);
@@ -258,11 +225,6 @@ export class PersistenceExtension implements Extension {
     // Sticky agent marker: 'agent' if any agent edit landed in this window, OR
     // if the current writer is the agent (covers a store with no prior onChange
     // agent event in the same window). §15 H2.
-    // Provenance precedence: agent > git-sync > user (see resolveSource). A
-    // 'git-sync' store is NOT given an immediate history snapshot — it is
-    // debounced like a human edit (a git-sync write is a block-level merge into
-    // the live doc, so it reads like an incremental human edit, not a bulk
-    // import that would warrant its own immediate snapshot).
     const lastUpdatedSource = resolveSource(
       this.consumeAgentTouched(documentName),
       context?.actor,
@@ -329,25 +291,17 @@ export class PersistenceExtension implements Extension {
           // flag via that same hoisted consume (a "cleared then retyped"
           // sequence can't leave a usable one behind).
           const incomingEmpty = isEmptyParagraphDoc(tiptapJson as any);
-          // A git-sync write is authoritative and its content IS the vault file:
-          // an empty incoming doc there means the user DELIBERATELY cleared the
-          // page's markdown in git (there is no "transient glitch empty" for a
-          // file-sourced write). Honor it, otherwise the empty-guard rejects the
-          // clear, the vault ref has already advanced past the empty commit, and
-          // vault<->Docmost diverge permanently (review warning). This mirrors the
-          // #251 intentional-clear allowance for a different authoritative source.
-          const gitSyncClear = lastUpdatedSource === 'git-sync';
           if (
             incomingEmpty &&
             page.content &&
             !isEmptyParagraphDoc(page.content as any)
           ) {
-            if (allowIntentionalClear || gitSyncClear) {
+            if (allowIntentionalClear) {
               this.logger.debug(
                 `Intentional clear for ${pageId}: persisting empty doc over ` +
-                  `non-empty content (${gitSyncClear ? 'git-sync' : 'user-signalled'})`,
+                  `non-empty content (user-signalled)`,
               );
-              // fall through — the empty write is allowed.
+              // fall through — the empty write is allowed exactly once.
             } else {
               this.logger.warn(
                 `Skipping store for ${pageId}: empty live doc would overwrite ` +
@@ -372,30 +326,21 @@ export class PersistenceExtension implements Extension {
             //this.logger.debug('Contributors error:' + err?.['message']);
           }
 
-          // Approach A — boundary snapshot before a MACHINE write overwrites a
-          // human (or other-source) baseline. When this store is from a machine
-          // source — the AGENT or GIT-SYNC — and the page's currently persisted
-          // state was authored by a DIFFERENT source, pin that prior state as its
-          // own history version BEFORE the machine write overwrites it. `page`
-          // still holds the OLD content/provenance here, so saveHistory(page)
-          // captures the pre-write state. The machine's new content is snapshotted
-          // later by the debounced PAGE_HISTORY job.
-          //
-          // For GIT-SYNC this is the OBSERVABLE-LOSS guard (SPEC §9 conflict
-          // contract): a git-sync body write is a block-level 3-way merge whose
-          // same-block rule is "git wins". Without this pin, a concurrent human
-          // edit to a block git also changed would be overwritten with NO trace.
-          // Pinning the pre-merge state here means the human's content is always
-          // RECOVERABLE via page history rather than silently lost — git still
-          // wins the live doc deterministically, but nothing is destroyed.
-          //
-          // Skip if the prior state was already authored by THIS machine source
-          // (boundary already pinned on the transition into it), if the page is
-          // effectively empty, or if the latest existing snapshot already equals
-          // the prior state (avoid duplicates).
-          const isMachineWrite =
-            lastUpdatedSource === 'agent' || lastUpdatedSource === 'git-sync';
-          if (isMachineWrite && page.lastUpdatedSource !== lastUpdatedSource) {
+          // Approach A — boundary snapshot before the agent's first edit.
+          // When this store is the agent's and the page's currently persisted
+          // state was authored by a human, pin that human state as its own
+          // history version BEFORE the agent overwrites it. `page` still holds
+          // the OLD content/provenance here, so saveHistory(page) captures the
+          // pre-agent state tagged 'user'. The agent's new content is
+          // snapshotted later by the debounced PAGE_HISTORY job ('agent'). Skip
+          // if the prior state is already agent-authored (boundary already
+          // pinned on the user->agent transition), if the page is effectively
+          // empty, or if the latest existing snapshot already equals this human
+          // state (avoid duplicates).
+          if (
+            lastUpdatedSource === 'agent' &&
+            page.lastUpdatedSource !== 'agent'
+          ) {
             // pageHistory.pageId is uuid-typed; use page.id (never the doc-name
             // slugId) so a `page.<slugId>` doc cannot throw 22P02 here (#260).
             const lastHistory = await this.pageHistoryRepo.findPageLastHistory(

apps/server/src/collaboration/extensions/redis-sync/redis-sync.extension.spec.ts

@@ -1,208 +0,0 @@
-// Regression coverage for the custom-event request/reply protocol in the
-// RedisSyncExtension. git-sync routes its body write through a custom event
-// (`gitSyncWriteBody`) which, when the target doc is owned by a DIFFERENT collab
-// instance, runs REMOTELY inside `handleRedisMessage` on the owning instance. The
-// remote handler can THROW (markdown->ProseMirror transform on a malformed body).
-//
-// Before the fix the throw was uncaught: (1) no `customEventComplete` reply was
-// published, so the origin's awaiting promise only rejected after `customEventTTL`
-// (~30s) as a generic 'TIMEOUT', and (2) an unhandledRejection escaped the async
-// `messageBuffer` listener on the owning instance. These tests assert the throw is
-// turned into an error-carrying reply that rejects the origin PROMPTLY with the
-// real message, with the no-throw and local paths unchanged.
-
-import { RedisSyncExtension } from './redis-sync.extension';
-
-type Listener = (channel: Buffer, message: Buffer) => unknown;
-
-// Minimal in-memory pub/sub + lock store shared across FakeRedis duplicates,
-// modelling the two-instance topology (origin + owner) over one Redis.
-class FakeRedisBus {
-  instances: FakeRedis[] = [];
-  locks = new Map<string, string>();
-  published: { channel: string; message: Buffer }[] = [];
-
-  register(inst: FakeRedis) {
-    this.instances.push(inst);
-  }
-
-  publish(channel: string, message: Buffer) {
-    this.published.push({ channel, message });
-    for (const inst of this.instances) {
-      if (!inst.subscribed.has(channel)) continue;
-      for (const listener of inst.messageListeners) {
-        // ioredis delivers async; `void` mirrors the production listener
-        // registration (`sub.on('messageBuffer', ...)`), whose rejection would
-        // surface as an unhandledRejection if the handler did not catch.
-        void listener(Buffer.from(channel), message);
-      }
-    }
-  }
-}
-
-class FakeRedis {
-  subscribed = new Set<string>();
-  messageListeners: Listener[] = [];
-
-  constructor(private bus: FakeRedisBus) {
-    bus.register(this);
-  }
-
-  duplicate() {
-    return new FakeRedis(this.bus);
-  }
-
-  subscribe(...channels: string[]) {
-    for (const c of channels) this.subscribed.add(c);
-    return Promise.resolve();
-  }
-
-  on(event: string, cb: any) {
-    if (event === 'messageBuffer') this.messageListeners.push(cb as Listener);
-    return this;
-  }
-
-  publish(channel: string, message: Buffer) {
-    this.bus.publish(channel, message);
-    return Promise.resolve(1);
-  }
-
-  // Models `SET key val PX ttl NX GET`: only writes when absent (NX); returns the
-  // previous value (GET) so the origin observes the owner already holding the lock.
-  set(key: string, val: string, ...args: any[]) {
-    const hasNX = args.includes('NX');
-    const hasGET = args.includes('GET');
-    const old = this.bus.locks.get(key) ?? null;
-    if (!hasNX || old === null) this.bus.locks.set(key, val);
-    return Promise.resolve(hasGET ? old : 'OK');
-  }
-
-  del(key: string) {
-    this.bus.locks.delete(key);
-    return Promise.resolve(1);
-  }
-
-  disconnect() {}
-}
-
-const pack = (m: any) => Buffer.from(JSON.stringify(m));
-const unpack = (b: Buffer) => JSON.parse(b.toString());
-
-function makeExtension(
-  bus: FakeRedisBus,
-  serverId: string,
-  customEvents: Record<string, (doc: string, payload: any) => Promise<any>>,
-) {
-  const ext = new RedisSyncExtension({
-    redis: new FakeRedis(bus) as any,
-    pack: pack as any,
-    unpack: unpack as any,
-    serverId,
-    customEvents: customEvents as any,
-    customEventTTL: 30_000,
-  });
-  // Doc is NOT loaded on this instance -> handleEvent takes the remote/proxy path.
-  (ext as any).instance = { documents: new Map() };
-  return ext;
-}
-
-describe('RedisSyncExtension custom-event error propagation', () => {
-  let unhandled: unknown[];
-  let onUnhandled: (e: unknown) => void;
-
-  beforeEach(() => {
-    // Fake timers so the 30s TTL fallback timer never fires (and never dangles).
-    jest.useFakeTimers();
-    unhandled = [];
-    onUnhandled = (e) => unhandled.push(e);
-    process.on('unhandledRejection', onUnhandled);
-  });
-
-  afterEach(() => {
-    process.off('unhandledRejection', onUnhandled);
-    jest.useRealTimers();
-  });
-
-  const flush = async () => {
-    for (let i = 0; i < 10; i++) await Promise.resolve();
-  };
-
-  it('owner publishes an error-carrying reply (no unhandledRejection) when the remote handler throws', async () => {
-    const bus = new FakeRedisBus();
-    const owner = makeExtension(bus, 'owner', {
-      boom: async () => {
-        throw new Error('kaboom');
-      },
-    });
-
-    // Drive the remote branch directly, as if the origin's customEventStart arrived.
-    await (owner as any).handleRedisMessage(
-      Buffer.from('collabMsg:owner'),
-      pack({
-        type: 'customEventStart',
-        documentName: 'page.x',
-        eventName: 'boom',
-        payload: {},
-        replyTo: 'collabMsg:origin',
-        replyId: 7,
-      }),
-    );
-    await flush();
-
-    const replies = bus.published
-      .filter((p) => p.channel === 'collabMsg:origin')
-      .map((p) => unpack(p.message));
-    expect(replies).toHaveLength(1);
-    expect(replies[0]).toMatchObject({
-      type: 'customEventComplete',
-      replyId: 7,
-      error: 'kaboom',
-    });
-    expect(unhandled).toHaveLength(0);
-  });
-
-  it('origin rejects PROMPTLY with the real error (not a TTL TIMEOUT) when the remote handler throws', async () => {
-    const bus = new FakeRedisBus();
-    // Owner already holds the document lock.
-    bus.locks.set('collabLock:page.x', 'owner');
-    makeExtension(bus, 'owner', {
-      boom: async () => {
-        throw new Error('kaboom');
-      },
-    });
-    const origin = makeExtension(bus, 'origin', {
-      boom: async () => undefined,
-    });
-
-    const promise = (origin as any).handleEvent('boom', 'page.x', { foo: 1 });
-    // Attach a catch immediately so a rejection is never momentarily unhandled.
-    const settled = promise.then(
-      () => ({ ok: true as const }),
-      (e: unknown) => ({ ok: false as const, error: e }),
-    );
-
-    await flush();
-    // Resolves WITHOUT advancing any timer -> the 30s TIMEOUT fallback did not fire.
-    const result = await settled;
-    expect(result.ok).toBe(false);
-    expect((result as any).error).toBeInstanceOf(Error);
-    expect(((result as any).error as Error).message).toBe('kaboom');
-    expect(unhandled).toHaveLength(0);
-  });
-
-  it('origin resolves with the payload when the remote handler succeeds (unchanged behavior)', async () => {
-    const bus = new FakeRedisBus();
-    bus.locks.set('collabLock:page.x', 'owner');
-    makeExtension(bus, 'owner', {
-      ok: async (_doc: string, payload: any) => ({ echoed: payload }),
-    });
-    const origin = makeExtension(bus, 'origin', {
-      ok: async () => undefined,
-    });
-
-    const promise = (origin as any).handleEvent('ok', 'page.x', { foo: 1 });
-    await flush();
-    await expect(promise).resolves.toEqual({ echoed: { foo: 1 } });
-    expect(unhandled).toHaveLength(0);
-  });
-});

apps/server/src/collaboration/extensions/redis-sync/redis-sync.extension.ts

@@ -51,15 +51,9 @@ export class RedisSyncExtension<TCE extends CustomEvents> implements Extension {
   private instance!: Hocuspocus;
   private readonly customEvents: TCE;
   private replyIdCounter: number = 0;
-  private pendingReplies: Record<
-    number,
-    {
-      // @ts-ignore
-      resolve: PromiseWithResolvers<any>['resolve'];
-      // @ts-ignore
-      reject: PromiseWithResolvers<any>['reject'];
-    }
-  > = {};
+  // @ts-ignore
+  private pendingReplies: Record<number, PromiseWithResolvers<any>['resolve']> =
+    {};
 
   constructor(configuration: Configuration<TCE>) {
     const {
@@ -182,45 +176,25 @@ export class RedisSyncExtension<TCE extends CustomEvents> implements Extension {
     }
     if (type === 'customEventStart') {
       const { documentName, eventName, payload, replyTo, replyId } = msg;
-      let reply: RSAMessageCustomEventComplete;
-      try {
-        const res = await this.handleEventLocally(
-          eventName as Extract<keyof TCE, string>,
-          documentName,
-          payload,
-        );
-        reply = {
-          type: 'customEventComplete',
-          replyId,
-          payload: res,
-        };
-      } catch (err) {
-        // The remote handler threw (e.g. the markdown->ProseMirror transform in
-        // gitSyncWriteBody can throw on a malformed body). Reply with the error on
-        // the SAME correlation channel so the origin rejects promptly with the real
-        // message instead of waiting out customEventTTL as a generic 'TIMEOUT'.
-        // Catching here also keeps the throw from escaping this async messageBuffer
-        // listener as an unhandledRejection on the owning instance.
-        reply = {
-          type: 'customEventComplete',
-          replyId,
-          payload: undefined,
-          error: err instanceof Error ? err.message : String(err),
-        };
-      }
+      const res = await this.handleEventLocally(
+        eventName as Extract<keyof TCE, string>,
+        documentName,
+        payload,
+      );
+      const reply: RSAMessageCustomEventComplete = {
+        type: 'customEventComplete',
+        replyId,
+        payload: res,
+      };
       this.pub.publish(`${replyTo}`, this.pack(reply));
       return;
     }
     if (type === 'customEventComplete') {
-      const { replyId, payload, error } = msg;
-      const pending = this.pendingReplies[replyId];
-      if (!pending) return;
+      const { replyId, payload } = msg;
+      const resolveFn = this.pendingReplies[replyId];
+      if (!resolveFn) return;
       delete this.pendingReplies[replyId];
-      if (error !== undefined) {
-        pending.reject(new Error(error));
-      } else {
-        pending.resolve(payload);
-      }
+      resolveFn(payload);
       return;
     }
     const { socketId } = msg;
@@ -299,22 +273,11 @@ export class RedisSyncExtension<TCE extends CustomEvents> implements Extension {
       };
       const msg = this.pack(proxyMessage);
       this.pub.publish(`${this.msgChannel}:${proxyTo}`, msg);
-      // Manual deferred (no Promise.withResolvers) so this runs on Node < 22 too.
-      let resolve!: (v: unknown) => void;
-      let reject!: (e: unknown) => void;
-      const promise = new Promise((res, rej) => {
-        resolve = res;
-        reject = rej;
-      });
-      this.pendingReplies[replyId] = { resolve, reject };
+      // @ts-ignore
+      const { promise, resolve, reject } = Promise.withResolvers();
+      this.pendingReplies[replyId] = resolve;
       setTimeout(() => {
-        // Fallback for a genuinely lost reply. A handler that threw now rejects
-        // promptly via the error-carrying customEventComplete above; this TIMEOUT
-        // only fires when no reply ever comes back.
-        if (this.pendingReplies[replyId]) {
-          delete this.pendingReplies[replyId];
-          reject('TIMEOUT');
-        }
+        reject('TIMEOUT');
       }, this.customEventTTL);
       return promise as Promise<ReturnType<TCE[TName]>>;
     }

apps/server/src/collaboration/extensions/redis-sync/redis-sync.types.ts

@@ -72,10 +72,6 @@ export type RSAMessageCustomEventComplete = {
   type: 'customEventComplete';
   replyId: number;
   payload: unknown;
-  // When the remote handler THREW, the owner sends back the error message here
-  // instead of a payload, so the origin can reject its awaiting promise promptly
-  // (with the real error) rather than waiting out the customEventTTL timeout.
-  error?: string;
 };
 
 export type RSAMessage =

apps/server/src/collaboration/git-sync-converter-gate.spec.ts

@@ -1,587 +0,0 @@
-/**
- * JEST CONFIG NOTE (#119 ESM refactor): this is the one spec that needs the REAL
- * `@docmost/git-sync` converter (not a mock). The package is now ESM, which jest
- * cannot `require()` nor `import()` without --experimental-vm-modules, so the
- * server jest config `moduleNameMapper`s `@docmost/git-sync` to its TS SOURCE and
- * strips the ESM `.js` import suffixes. ts-jest then type-checks that source under
- * the server's (looser) tsconfig and trips a benign narrowing; the global
- * `isolatedModules: true` on the ts-jest transform (apps/server/package.json)
- * makes it transpile-only so this spec loads. Full type-checking of the package
- * is still enforced by its own `tsc`/vitest gates and the server `tsc --noEmit`.
- *
- * §13.1 IDEMPOTENCY GATE — the blocking gate for git-sync Phase B.
- *
- * Proves the `@docmost/git-sync` pure converter is schema-compatible
- * with the server's REAL editor-ext document schema: a representative corpus of
- * editor-ext ProseMirror documents must survive a full round trip through the
- * actual server write path without losing any node / mark / attribute.
- *
- * Pipeline per document (issue #194 §13.1):
- *   1. md   = convertProseMirrorToMarkdown(content)          // git-sync export
- *   2. doc  = await markdownToProseMirror(md)                // git-sync import
- *   3. push `doc` through the REAL editor-ext Yjs write path the server uses:
- *        ydoc       = TiptapTransformer.toYdoc(doc, 'default', tiptapExtensions)
- *        normalized = TiptapTransformer.fromYdoc(ydoc, 'default')
- *      This is exactly what PersistenceExtension does on store
- *      (apps/server/src/collaboration/extensions/persistence.extension.ts:96/115)
- *      with the same `tiptapExtensions` (collaboration.util.ts) and the same
- *      `@hocuspocus/transformer`, so the gate exercises the real schema
- *      validation that runs on a git-sync write (issue #194 §3.3).
- *   4. assert docsCanonicallyEqual(canon(original), canon(normalized)) === true
- *
- * Any node / mark / attr that editor-ext drops (because the git-sync
- * docmost-schema named it differently, or declares a different default) makes
- * the gate FAIL for that document — exactly the schema-divergence issue #194 §3.3 /
- * §13.1 warn about. Genuine, irreducible divergences are isolated into the
- * clearly-named `KNOWN DIVERGENCE` block at the bottom (never silently hidden).
- *
- * Requires the workspace packages built first:
- *   pnpm --filter @docmost/editor-ext build
- *   pnpm --filter @docmost/git-sync  build
- */
-import { TiptapTransformer } from '@hocuspocus/transformer';
-// Import the server's real schema FIRST so `@docmost/editor-ext` resolves to its
-// built CJS `dist` (its `main`). The ESM-only `@docmost/git-sync` package is
-// mapped to its TS SOURCE by the jest `moduleNameMapper` (the built ESM cannot
-// be `require()`d nor dynamically `import()`ed under jest's node VM), so ts-jest
-// transpiles the real converter to CJS here — exercising the actual converter
-// the server ships, not a stub.
-import { tiptapExtensions } from './collaboration.util';
-import {
-  convertProseMirrorToMarkdown,
-  markdownToProseMirror,
-  canonicalizeContent,
-  docsCanonicallyEqual,
-} from '@docmost/git-sync';
-
-/**
- * Run a single editor-ext document through the full gate pipeline and return
- * the canonical original vs the canonical doc as it lands after the real Yjs
- * write path, plus the intermediate markdown for diagnostics.
- */
-async function runGate(original: any): Promise<{
-  md: string;
-  imported: any;
-  normalized: any;
-  canonOriginal: any;
-  canonNormalized: any;
-}> {
-  // 1) editor-ext JSON -> markdown (git-sync export).
-  const md = convertProseMirrorToMarkdown(original);
-
-  // 2) markdown -> ProseMirror JSON (git-sync import, docmost-schema).
-  const imported = await markdownToProseMirror(md);
-
-  // 3) push through the REAL editor-ext schema via the server's Yjs write path.
-  //    toYdoc validates `imported` against tiptapExtensions (throws on an
-  //    unknown node, drops unknown attrs); fromYdoc reads it back as the
-  //    normalized editor-ext JSON the server would persist.
-  const ydoc = TiptapTransformer.toYdoc(imported, 'default', tiptapExtensions);
-  const normalized = TiptapTransformer.fromYdoc(ydoc, 'default');
-
-  return {
-    md,
-    imported,
-    normalized,
-    canonOriginal: canonicalizeContent(original),
-    canonNormalized: canonicalizeContent(normalized),
-  };
-}
-
-const doc = (...content: any[]) => ({ type: 'doc', content });
-const text = (t: string, marks?: any[]) =>
-  marks ? { type: 'text', text: t, marks } : { type: 'text', text: t };
-const para = (...content: any[]) => ({ type: 'paragraph', content });
-
-// ---------------------------------------------------------------------------
-// Corpus: editor-ext ProseMirror documents covering the common node/mark types.
-// Node / mark / attr names and DEFAULTS are taken from the real schema —
-// editor-ext (packages/editor-ext/src) + the server's tiptapExtensions
-// (collaboration.util.ts) — NOT guessed. Where editor-ext materializes a
-// non-null default on import (e.g. image.align="center", callout.type, list
-// start) the fixture pre-authors that materialized value so the round trip is
-// already at its fixpoint (matches how the engine normalizes-on-write, SPEC §11).
-// ---------------------------------------------------------------------------
-const CORPUS: Record<string, any> = {
-  'paragraphs + headings (h1-h3)': doc(
-    { type: 'heading', attrs: { level: 1 }, content: [text('Heading one')] },
-    { type: 'heading', attrs: { level: 2 }, content: [text('Heading two')] },
-    { type: 'heading', attrs: { level: 3 }, content: [text('Heading three')] },
-    para(text('A plain paragraph of text.')),
-    para(text('Second paragraph.')),
-  ),
-
-  // A non-default paragraph alignment now round-trips (item #7 fix): it exports
-  // as `<p style="text-align:center">` and the schema's paragraph parseHTML
-  // reads `style="text-align"` back onto `textAlign` on import, so the alignment
-  // survives the full editor-ext write path. Promoted from the old KNOWN
-  // DIVERGENCE block (which only heading alignment still occupies).
-  'aligned paragraph (textAlign center)': doc({
-    type: 'paragraph',
-    attrs: { textAlign: 'center' },
-    content: [text('centered')],
-  }),
-
-  'inline marks (bold/italic/strike/code)': doc(
-    para(
-      text('normal '),
-      text('bold', [{ type: 'bold' }]),
-      text(' '),
-      text('italic', [{ type: 'italic' }]),
-      text(' '),
-      text('struck', [{ type: 'strike' }]),
-      text(' '),
-      text('code', [{ type: 'code' }]),
-    ),
-  ),
-
-  'links': doc(
-    para(
-      text('see '),
-      text('the site', [
-        { type: 'link', attrs: { href: 'https://example.com' } },
-      ]),
-      text(' for more'),
-    ),
-  ),
-
-  'bullet list': doc({
-    type: 'bulletList',
-    content: [
-      { type: 'listItem', content: [para(text('first'))] },
-      { type: 'listItem', content: [para(text('second'))] },
-      { type: 'listItem', content: [para(text('third'))] },
-    ],
-  }),
-
-  'ordered list': doc({
-    type: 'orderedList',
-    attrs: { start: 1 },
-    content: [
-      { type: 'listItem', content: [para(text('one'))] },
-      { type: 'listItem', content: [para(text('two'))] },
-    ],
-  }),
-
-  'task list (checkbox)': doc({
-    type: 'taskList',
-    content: [
-      {
-        type: 'taskItem',
-        attrs: { checked: true },
-        content: [para(text('done item'))],
-      },
-      {
-        type: 'taskItem',
-        attrs: { checked: false },
-        content: [para(text('todo item'))],
-      },
-    ],
-  }),
-
-  'blockquote': doc({
-    type: 'blockquote',
-    content: [para(text('a quoted line')), para(text('second quoted line'))],
-  }),
-
-  'callout (info)': doc({
-    type: 'callout',
-    attrs: { type: 'info' },
-    content: [para(text('an informational callout'))],
-  }),
-
-  'callout (warning)': doc({
-    type: 'callout',
-    attrs: { type: 'warning' },
-    content: [para(text('a warning callout'))],
-  }),
-
-  'code block (with language)': doc({
-    type: 'codeBlock',
-    attrs: { language: 'typescript' },
-    // A fenced code block's body is stored with a trailing newline (the form a
-    // markdown ``` fence round-trips to: marked normalizes the code text to end
-    // in "\n"). Authoring the fixture at that fixpoint mirrors how the engine
-    // normalizes-on-write (SPEC §11): codeBlock + `language` round-trip exactly.
-    content: [text('const a: number = 1;\nconsole.log(a);\n')],
-  }),
-
-  'horizontal rule': doc(
-    para(text('before')),
-    { type: 'horizontalRule' },
-    para(text('after')),
-  ),
-
-  'table (header row + cells)': doc({
-    type: 'table',
-    content: [
-      {
-        type: 'tableRow',
-        content: [
-          {
-            type: 'tableHeader',
-            attrs: { colspan: 1, rowspan: 1, colwidth: null },
-            content: [para(text('Name'))],
-          },
-          {
-            type: 'tableHeader',
-            attrs: { colspan: 1, rowspan: 1, colwidth: null },
-            content: [para(text('Value'))],
-          },
-        ],
-      },
-      {
-        type: 'tableRow',
-        content: [
-          {
-            type: 'tableCell',
-            attrs: { colspan: 1, rowspan: 1, colwidth: null },
-            content: [para(text('alpha'))],
-          },
-          {
-            type: 'tableCell',
-            attrs: { colspan: 1, rowspan: 1, colwidth: null },
-            content: [para(text('1'))],
-          },
-        ],
-      },
-    ],
-  }),
-
-  // #8 — a table with a MULTI-BLOCK cell (two paragraphs). A GFM pipe table
-  // cannot hold two blocks without flattening them; the converter emits a
-  // lossless HTML <table> instead, and the two blocks must survive the round trip.
-  'table (multi-block cell, #8)': doc({
-    type: 'table',
-    content: [
-      {
-        type: 'tableRow',
-        content: [
-          {
-            type: 'tableHeader',
-            attrs: { colspan: 1, rowspan: 1, colwidth: null },
-            content: [para(text('H'))],
-          },
-        ],
-      },
-      {
-        type: 'tableRow',
-        content: [
-          {
-            type: 'tableCell',
-            attrs: { colspan: 1, rowspan: 1, colwidth: null },
-            content: [para(text('first')), para(text('second'))],
-          },
-        ],
-      },
-    ],
-  }),
-
-  // #7 — a table nested inside a column. Columns render as HTML containers, and a
-  // table inside one must stay an HTML <table> (a GFM pipe table cannot live
-  // inside an HTML block), round-tripping without being unwrapped or lost.
-  // `widthMode` is pre-authored at its materialized `normal` default (SPEC §11).
-  'table inside a column (#7)': doc({
-    type: 'columns',
-    attrs: { layout: 'two', widthMode: 'normal' },
-    content: [
-      {
-        type: 'column',
-        content: [
-          {
-            type: 'table',
-            content: [
-              {
-                type: 'tableRow',
-                content: [
-                  {
-                    type: 'tableHeader',
-                    attrs: { colspan: 1, rowspan: 1, colwidth: null },
-                    content: [para(text('C7'))],
-                  },
-                ],
-              },
-            ],
-          },
-        ],
-      },
-      { type: 'column', content: [para(text('right'))] },
-    ],
-  }),
-
-  // --- editor-ext nodes/marks beyond the original corpus (item #7) ----------
-  // Each of these was verified to round-trip CLEANLY through the real gate
-  // (export -> markdown -> import -> editor-ext Yjs write path). Fixtures are
-  // pre-authored at the engine's normalize-on-write fixpoint (SPEC §11), e.g.
-  // details carries the materialized `open:false`, and color marks use the
-  // `rgb(...)` form the HTML re-parser normalizes to.
-
-  'mention (user)': doc(
-    para(
-      text('hi '),
-      {
-        type: 'mention',
-        attrs: {
-          id: 'user-123',
-          label: 'Alice',
-          entityType: 'user',
-          entityId: 'user-123',
-          creatorId: 'creator-1',
-        },
-      },
-      text(' there'),
-    ),
-  ),
-
-  'inline math': doc(
-    para(
-      text('inline '),
-      { type: 'mathInline', attrs: { text: 'x^2' } },
-      text(' math'),
-    ),
-  ),
-
-  'block math': doc({ type: 'mathBlock', attrs: { text: 'x^2 + y^2 = z^2' } }),
-
-  'details (collapsible)': doc({
-    type: 'details',
-    // `open:false` is the value editor-ext materializes on import; pre-authoring
-    // it puts the fixture at its round-trip fixpoint.
-    attrs: { open: false },
-    content: [
-      { type: 'detailsSummary', content: [text('Summary line')] },
-      { type: 'detailsContent', content: [para(text('hidden body'))] },
-    ],
-  }),
-
-  'highlight (mark, no color)': doc(
-    para(
-      text('a '),
-      text('highlighted', [{ type: 'highlight' }]),
-      text(' word'),
-    ),
-  ),
-
-  'highlight (mark, with color)': doc(
-    para(
-      text('a '),
-      text('red', [{ type: 'highlight', attrs: { color: 'rgb(255, 0, 0)' } }]),
-      text(' word'),
-    ),
-  ),
-
-  'subscript': doc(
-    para(text('H'), text('2', [{ type: 'subscript' }]), text('O')),
-  ),
-
-  'superscript': doc(
-    para(text('E=mc'), text('2', [{ type: 'superscript' }])),
-  ),
-
-  'text color (textStyle)': doc(
-    // The HTML re-parser normalizes CSS colors to the `rgb(...)` form, so the
-    // fixture pre-authors that form; a `#hex` color would round-trip to the
-    // equivalent rgb() and is therefore a value-normalization divergence (see
-    // the KNOWN DIVERGENCE block below).
-    para(text('green', [{ type: 'textStyle', attrs: { color: 'rgb(0, 255, 0)' } }])),
-  ),
-
-  'nested / mixed document': doc(
-    { type: 'heading', attrs: { level: 1 }, content: [text('Mixed')] },
-    para(
-      text('intro with '),
-      text('bold', [{ type: 'bold' }]),
-      text(' and a '),
-      text('link', [{ type: 'link', attrs: { href: 'https://example.com' } }]),
-      text('.'),
-    ),
-    {
-      type: 'bulletList',
-      content: [
-        {
-          type: 'listItem',
-          content: [
-            para(text('item with '), text('code', [{ type: 'code' }])),
-          ],
-        },
-        {
-          type: 'listItem',
-          content: [
-            para(text('item with sublist')),
-            {
-              type: 'bulletList',
-              content: [
-                { type: 'listItem', content: [para(text('nested a'))] },
-                { type: 'listItem', content: [para(text('nested b'))] },
-              ],
-            },
-          ],
-        },
-      ],
-    },
-    {
-      type: 'callout',
-      attrs: { type: 'success' },
-      content: [
-        para(text('callout body')),
-        { type: 'codeBlock', attrs: { language: 'bash' }, content: [text('echo hi\n')] },
-      ],
-    },
-    {
-      type: 'blockquote',
-      content: [para(text('quote at the end'))],
-    },
-  ),
-
-  // Atom embeds that carry no inline text: they must round-trip via their
-  // schema-matching HTML (data-type div), NOT a literal that re-imports as plain
-  // text. `subpages` used to export as the literal "{{SUBPAGES}}" and came back
-  // as visible text on the page (red-team round-trip data loss) — this locks it.
-  // editor-ext materializes the `recursive: false` default on import, so the
-  // fixture pre-authors it to sit at the round-trip fixpoint (matches the other
-  // default-materializing fixtures above).
-  'subpages embed': doc({ type: 'subpages', attrs: { recursive: false } }),
-};
-
-describe('git-sync converter §13.1 idempotency gate (editor-ext schema)', () => {
-  for (const [name, original] of Object.entries(CORPUS)) {
-    it(`round-trips losslessly: ${name}`, async () => {
-      const { md, canonOriginal, canonNormalized } = await runGate(original);
-
-      const equal = docsCanonicallyEqual(original, canonNormalized);
-      if (!equal) {
-        // Surface a readable diff so a real divergence is actionable.
-        // eslint-disable-next-line no-console
-        console.error(
-          `\n[GATE FAIL] ${name}\n--- markdown ---\n${md}\n` +
-            `--- canonical original ---\n${JSON.stringify(canonOriginal, null, 2)}\n` +
-            `--- canonical round-tripped ---\n${JSON.stringify(canonNormalized, null, 2)}\n`,
-        );
-      }
-      expect(equal).toBe(true);
-    });
-  }
-});
-
-// ---------------------------------------------------------------------------
-// Image layout attrs preserved by canon #4 (width/height/align all round-trip).
-//
-// The `image` NODE round-trips through editor-ext fine. Plain markdown `![](src)`
-// has no way to express layout attrs, so the canonical converter (#293/#326
-// canon decision #4) appends a machine comment `<!--img {...}-->` carrying the
-// NON-DEFAULT attrs, and re-parses it on import — the same trailing-comment
-// pattern used for media/textAlign.
-//
-// About `align` — DO NOT repeat an earlier false diagnosis: align is NOT lost.
-// `center` is the schema default, so the emitter omits it (only left/right go
-// into the comment) and the importer restores it via the image `align` default
-// ("center"). `canonNormalized.align` reads `undefined` here ONLY because
-// `canonicalizeContent` normalizes the "center" default away SYMMETRICALLY (from
-// both the original and the round trip), so docsCanonicallyEqual is unaffected —
-// this is canonical-form normalization, not a divergence. Verified empirically:
-// left/right survive the raw round trip; center is restored on import then
-// canon-stripped on both sides. The real round-trip instability in this family
-// was the empty-string-vs-absent class (image.alt `absent -> ""`), fixed
-// parse-side in the converter PACKAGE on develop (PR #350). This branch absorbs
-// that fix via the next develop merge; nothing to flip here for align.
-// ---------------------------------------------------------------------------
-describe('git-sync converter §13.1 image layout attrs round-trip (align via schema default)', () => {
-  const imageDoc = doc({
-    type: 'image',
-    attrs: {
-      src: 'https://example.com/pic.png',
-      width: 640,
-      height: 480,
-      align: 'center',
-    },
-  });
-
-  it('preserves width/height via the canon `<!--img {...}-->` comment; center align is the default', async () => {
-    const { md, canonNormalized } = await runGate(imageDoc);
-
-    // Canon #4: bare `![](src)` plus a trailing `<!--img {...}-->` comment that
-    // carries the non-default layout attrs. `center` is the default, so it is
-    // correctly OMITTED from the comment (only width/height appear here).
-    expect(md.trim()).toBe(
-      '![](https://example.com/pic.png) <!--img {"width":"640","height":"480"}-->',
-    );
-
-    // The round-tripped image keeps src + width/height. width/height are
-    // re-imported as strings (matching the video/audio/pdf string convention),
-    // so assert the values rather than the JS type.
-    const imgAttrs = (canonNormalized as any).content[0].attrs;
-    expect((canonNormalized as any).content[0].type).toBe('image');
-    expect(imgAttrs.src).toBe('https://example.com/pic.png');
-    expect(String(imgAttrs.width)).toBe('640');
-    expect(String(imgAttrs.height)).toBe('480');
-    // `align` is NOT lost — see the block comment above: `center` is the schema
-    // default, restored on import then normalized away symmetrically by
-    // canonicalize, so it reads `undefined` on the CANONICAL form (not a loss).
-    expect(imgAttrs.align).toBeUndefined();
-  });
-});
-
-// ---------------------------------------------------------------------------
-// HEADING text alignment — now round-trips (item A1; formerly a KNOWN DIVERGENCE).
-// Symmetric with the paragraph fix: a heading's non-default `textAlign` is
-// exported as a styled `<hN style="text-align:…">` (was a bare ATX `## text`
-// that dropped it) and re-parsed by the heading + textAlign parseHTML on import,
-// so a non-default heading alignment SURVIVES a full round trip.
-// ---------------------------------------------------------------------------
-describe('git-sync converter §13.1 heading text alignment round-trips', () => {
-  it('preserves a heading textAlign across the markdown round trip', async () => {
-    const alignedHeading = doc({
-      type: 'heading',
-      attrs: { level: 2, textAlign: 'center' },
-      content: [text('centered heading')],
-    });
-
-    const { md, canonNormalized } = await runGate(alignedHeading);
-
-    // Canon #9: ATX heading plus a trailing `<!--attrs {...}-->` comment carrying
-    // the non-default textAlign (was a lossy bare `## centered heading`).
-    expect(md.trim()).toBe(
-      '## centered heading <!--attrs {"textAlign":"center"}-->',
-    );
-    expect(docsCanonicallyEqual(alignedHeading, canonNormalized)).toBe(true);
-  });
-});
-
-// ---------------------------------------------------------------------------
-// KNOWN DIVERGENCE — textStyle color is VALUE-NORMALIZED, not lost (item #7).
-//
-// The textStyle/color mark itself round-trips (the green CORPUS has the rgb()
-// form). But a `#hex` color is normalized to the equivalent `rgb(...)` string
-// by the HTML re-parser on import, and canonicalize.ts does NOT normalize color
-// formats — so a `#hex` original is not STRING-identical to its round trip even
-// though the color is semantically preserved. Locked here so the boundary is
-// explicit: author color fixtures in rgb() form to stay in the green corpus.
-// ---------------------------------------------------------------------------
-describe('git-sync converter §13.1 KNOWN DIVERGENCE (textStyle color #hex -> rgb)', () => {
-  it('normalizes a #hex text color to rgb() (semantically preserved, string-divergent)', async () => {
-    const hexDoc = doc(
-      para(text('green', [{ type: 'textStyle', attrs: { color: '#00ff00' } }])),
-    );
-
-    const { canonNormalized } = await runGate(hexDoc);
-
-    // Color survives, but as the normalized rgb() string.
-    expect(canonNormalized).toEqual({
-      type: 'doc',
-      content: [
-        {
-          type: 'paragraph',
-          content: [
-            {
-              type: 'text',
-              text: 'green',
-              marks: [{ type: 'textStyle', attrs: { color: 'rgb(0, 255, 0)' } }],
-            },
-          ],
-        },
-      ],
-    });
-    // Not string-identical to the #hex original.
-    expect(docsCanonicallyEqual(hexDoc, canonNormalized)).toBe(false);
-  });
-});

apps/server/src/collaboration/merge/lcs.ts

@@ -1,26 +0,0 @@
-/**
- * Backward-filled LCS length table for sequences `a` and `b`: `dp[i][j]` is the
- * length of the longest common subsequence of the suffixes `a[i:]` and `b[j:]`.
- * O(n*m) time/space — fine for page block counts.
- *
- * Shared by the two-way block diff (`yjs-body-merge.diffBlocks`) and the
- * three-way merge planner (`three-way-merge.lcsPairs`) so the (identical) table
- * construction lives in ONE place; each caller does its own traceback over the
- * returned table.
- */
-export function buildLcsTable(a: string[], b: string[]): number[][] {
-  const n = a.length;
-  const m = b.length;
-  const dp: number[][] = Array.from({ length: n + 1 }, () =>
-    new Array(m + 1).fill(0),
-  );
-  for (let i = n - 1; i >= 0; i--) {
-    for (let j = m - 1; j >= 0; j--) {
-      dp[i][j] =
-        a[i] === b[j]
-          ? dp[i + 1][j + 1] + 1
-          : Math.max(dp[i + 1][j], dp[i][j + 1]);
-    }
-  }
-  return dp;
-}

apps/server/src/collaboration/merge/redteam-three-way.spec.ts

@@ -1,20 +0,0 @@
-import { diff3Plan, type Pick } from './three-way-merge';
-
-// Materialize a plan into the merged key sequence for assertion.
-function apply(plan: Pick[], live: string[], target: string[]): string[] {
-  return plan.map((p) => (p.src === 'live' ? live[p.index] : target[p.index]));
-}
-
-const merge = (o: string[], a: string[], b: string[]): string[] =>
-  apply(diff3Plan(o, a, b), a, b);
-
-describe('diff3Plan red-team #9 (human edit + adjacent git insert)', () => {
-  it('keeps human block-2 edit AND applies git insert of 2.5', () => {
-    // base:   1 2 3
-    // live:   1 H 3   (human rewrote block 2)
-    // target: 1 2 2.5 3 (git inserted 2.5 after block 2)
-    expect(
-      merge(['1', '2', '3'], ['1', 'H', '3'], ['1', '2', '2.5', '3']),
-    ).toEqual(['1', 'H', '2.5', '3']);
-  });
-});

apps/server/src/collaboration/merge/three-way-merge.spec.ts

@@ -1,159 +0,0 @@
-import {
-  diff3Plan,
-  diff3PlanWithConflicts,
-  type Pick,
-} from './three-way-merge';
-
-// Materialize a plan into the merged key sequence for assertion.
-function apply(plan: Pick[], live: string[], target: string[]): string[] {
-  return plan.map((p) => (p.src === 'live' ? live[p.index] : target[p.index]));
-}
-
-const merge = (o: string[], a: string[], b: string[]): string[] =>
-  apply(diff3Plan(o, a, b), a, b);
-
-describe('diff3Plan (block-level three-way merge)', () => {
-  it('identical on all three sides -> unchanged (all from live)', () => {
-    const plan = diff3Plan(['1', '2', '3'], ['1', '2', '3'], ['1', '2', '3']);
-    expect(plan.every((p) => p.src === 'live')).toBe(true);
-    expect(apply(plan, ['1', '2', '3'], ['1', '2', '3'])).toEqual(['1', '2', '3']);
-  });
-
-  it('git changed a block the human did not -> takes git', () => {
-    expect(merge(['1', '2', '3'], ['1', '2', '3'], ['1', '9', '3'])).toEqual([
-      '1',
-      '9',
-      '3',
-    ]);
-  });
-
-  it('human changed a block git did not -> KEEPS the human edit (the core 3-way win)', () => {
-    expect(merge(['1', '2', '3'], ['1', 'H', '3'], ['1', '2', '3'])).toEqual([
-      '1',
-      'H',
-      '3',
-    ]);
-  });
-
-  // Bug #2 observability: diff3PlanWithConflicts reports SAME-BLOCK conflicts so
-  // the caller can surface the "git wins" loss (log + history pin) instead of
-  // dropping the human side silently.
-  describe('diff3PlanWithConflicts (same-block conflict reporting)', () => {
-    it('reports 0 conflicts when sides changed DIFFERENT blocks (clean merge)', () => {
-      const r = diff3PlanWithConflicts(
-        ['1', '2', '3'],
-        ['H', '2', '3'],
-        ['1', '2', 'G'],
-      );
-      expect(r.conflicts).toBe(0);
-      expect(apply(r.picks, ['H', '2', '3'], ['1', '2', 'G'])).toEqual([
-        'H',
-        '2',
-        'G',
-      ]);
-    });
-
-    it('reports 1 conflict and git wins when BOTH rewrote the SAME block', () => {
-      const r = diff3PlanWithConflicts(
-        ['1', '2', '3'],
-        ['1', 'H', '3'], // human rewrote block 2
-        ['1', 'G', '3'], // git rewrote block 2
-      );
-      expect(r.conflicts).toBe(1);
-      // Git wins the contested block; the human 'H' is NOT in the picks.
-      expect(apply(r.picks, ['1', 'H', '3'], ['1', 'G', '3'])).toEqual([
-        '1',
-        'G',
-        '3',
-      ]);
-    });
-
-    it('does NOT count a git-only region (no human content to lose) as a conflict', () => {
-      const r = diff3PlanWithConflicts(
-        ['1', '2', '3'],
-        ['1', '2', '3'], // human unchanged
-        ['1', '9', '3'], // git rewrote block 2
-      );
-      expect(r.conflicts).toBe(0);
-    });
-  });
-
-  it('human and git changed DIFFERENT blocks -> both preserved', () => {
-    // human rewrote block 1, git rewrote block 3.
-    expect(merge(['1', '2', '3'], ['H', '2', '3'], ['1', '2', 'G'])).toEqual([
-      'H',
-      '2',
-      'G',
-    ]);
-  });
-
-  it('human inserted a block AND git changed a different block -> both preserved', () => {
-    expect(
-      merge(['1', '2', '3'], ['1', '1.5', '2', '3'], ['1', '2', 'G']),
-    ).toEqual(['1', '1.5', '2', 'G']);
-  });
-
-  it('both changed the SAME block -> conflict resolves to git', () => {
-    expect(merge(['1', '2', '3'], ['1', 'H', '3'], ['1', 'G', '3'])).toEqual([
-      '1',
-      'G',
-      '3',
-    ]);
-  });
-
-  it('both made the SAME edit -> that edit (no duplication)', () => {
-    expect(merge(['1', '2', '3'], ['1', 'X', '3'], ['1', 'X', '3'])).toEqual([
-      '1',
-      'X',
-      '3',
-    ]);
-  });
-
-  it('human deleted a block git left alone -> deletion preserved', () => {
-    expect(merge(['1', '2', '3'], ['1', '3'], ['1', '2', '3'])).toEqual([
-      '1',
-      '3',
-    ]);
-  });
-
-  it('git deleted a block the human left alone -> deletion applied', () => {
-    expect(merge(['1', '2', '3'], ['1', '2', '3'], ['1', '3'])).toEqual([
-      '1',
-      '3',
-    ]);
-  });
-
-  it('both deleted the same block -> gone (no conflict)', () => {
-    expect(merge(['1', '2', '3'], ['1', '3'], ['1', '3'])).toEqual(['1', '3']);
-  });
-
-  it('git appended a trailing block -> appended', () => {
-    expect(merge(['1', '2'], ['1', '2'], ['1', '2', '3'])).toEqual([
-      '1',
-      '2',
-      '3',
-    ]);
-  });
-
-  it('human appended a trailing block git did not -> kept', () => {
-    expect(merge(['1', '2'], ['1', '2', '3'], ['1', '2'])).toEqual([
-      '1',
-      '2',
-      '3',
-    ]);
-  });
-
-  it('empty base, git provides content (brand-new page body) -> git content', () => {
-    expect(merge([], [], ['1', '2'])).toEqual(['1', '2']);
-  });
-
-  it('git changed block 1, human edited block 3, far apart -> both kept', () => {
-    expect(
-      merge(
-        ['a', 'b', 'c', 'd', 'e'],
-        ['a', 'b', 'c', 'd', 'E'],
-        ['A', 'b', 'c', 'd', 'e'],
-      ),
-    ).toEqual(['A', 'b', 'c', 'd', 'E']);
-  });
-});

apps/server/src/collaboration/merge/three-way-merge.ts

@@ -1,284 +0,0 @@
-/**
- * Pure block-level THREE-WAY merge planner (diff3) over arrays of opaque block
- * keys. Used by the git-sync body write to merge an incoming git body into the
- * live page using the last-synced version as the common ancestor (review #5):
- *
- *   - a block only the human changed (live != base, git == base) -> keep LIVE
- *   - a block only git changed       (git != base, live == base) -> take GIT
- *   - a block both sides changed (a real conflict)               -> GIT wins
- *   - inserts/deletes from either side are preserved when unambiguous
- *
- * Content-agnostic: it works on string keys and returns the merged block order as
- * picks ({ src: 'live'|'target', index }) — the caller (the Yjs applier)
- * materializes them — so the whole algorithm is unit-testable on plain arrays.
- *
- * Algorithm: anchor on base blocks present (unchanged) in BOTH live and target
- * (their LCS-with-base intersection). Between consecutive anchors lies one region
- * the human and/or git rewrote; resolve each region three-way. Stable anchor
- * blocks are emitted from LIVE so the applier keeps the existing Yjs block
- * instances (and the human's in-flight edits) in place.
- *
- * LOCATION (deferred): this and its `lcs.ts` sibling are pure, framework-free and
- * could conceptually live in `packages/git-sync` (the engine). They are kept in
- * the server integration on purpose: `packages/git-sync` is a VENDORED engine
- * (pinned upstream, manually re-synced), so adding first-party files there
- * complicates the re-sync story, and the only consumer today is the server. Move
- * them into the engine only once the vendoring re-sync story is settled.
- */
-
-import { buildLcsTable } from './lcs';
-
-/** Matched index pairs of the longest common subsequence of `a` and `b`. */
-function lcsPairs(a: string[], b: string[]): Array<[number, number]> {
-  const n = a.length;
-  const m = b.length;
-  const dp = buildLcsTable(a, b);
-  const pairs: Array<[number, number]> = [];
-  let i = 0;
-  let j = 0;
-  while (i < n && j < m) {
-    if (a[i] === b[j]) {
-      pairs.push([i, j]);
-      i++;
-      j++;
-    } else if (dp[i + 1][j] >= dp[i][j + 1]) {
-      i++;
-    } else {
-      j++;
-    }
-  }
-  return pairs;
-}
-
-/** o-index -> matched index in the other side (only for LCS-matched blocks). */
-function matchMap(pairs: Array<[number, number]>): Map<number, number> {
-  const m = new Map<number, number>();
-  for (const [o, x] of pairs) m.set(o, x);
-  return m;
-}
-
-/**
- * One change `side` made to `base` within a region: base blocks `[oStart,oEnd)`
- * were replaced by the side's blocks listed in `content` (region-local indices).
- * A pure insert has `oStart === oEnd`; a pure delete has empty `content`.
- */
-interface Hunk {
-  oStart: number;
-  oEnd: number;
-  content: number[];
-}
-
-/**
- * Diff `o` against one side as a list of non-overlapping hunks (the base spans
- * the side rewrote/inserted/deleted), derived from their LCS alignment.
- */
-function buildHunks(o: string[], side: string[]): Hunk[] {
-  const pairs = lcsPairs(o, side); // [oIdx, sideIdx] kept (unchanged) blocks
-  const hunks: Hunk[] = [];
-  let prevO = -1;
-  let prevS = -1;
-  const flush = (curO: number, curS: number): void => {
-    const oStart = prevO + 1;
-    const oEnd = curO;
-    const content: number[] = [];
-    for (let s = prevS + 1; s < curS; s++) content.push(s);
-    if (oEnd > oStart || content.length > 0) hunks.push({ oStart, oEnd, content });
-  };
-  for (const [oIdx, sIdx] of pairs) {
-    flush(oIdx, sIdx);
-    prevO = oIdx;
-    prevS = sIdx;
-  }
-  flush(o.length, side.length);
-  return hunks;
-}
-
-/**
- * Do two hunks (one per side) touch the same base region? Pure inserts only
- * collide when nested strictly inside the other hunk's base span (or, for two
- * inserts, at the same gap); changes sitting at a shared boundary do not.
- */
-function hunksOverlap(a: Hunk, b: Hunk): boolean {
-  const aIns = a.oStart === a.oEnd;
-  const bIns = b.oStart === b.oEnd;
-  if (aIns && bIns) return a.oStart === b.oStart;
-  if (aIns) return b.oStart < a.oStart && a.oStart < b.oEnd;
-  if (bIns) return a.oStart < b.oStart && b.oStart < a.oEnd;
-  return Math.max(a.oStart, b.oStart) < Math.min(a.oEnd, b.oEnd);
-}
-
-interface LocalPick {
-  src: 'live' | 'target';
-  local: number;
-}
-
-/**
- * Fine-grained three-way merge of ONE inter-anchor region. Combines the human's
- * and git's NON-overlapping hunks (e.g. a human edit to one block plus a git
- * insert/delete of OTHER blocks in the same region) so neither change is lost.
- * Returns the merged region as region-local picks, or `null` when the two sides
- * changed the SAME base block — a genuine conflict the caller resolves by the
- * original all-or-nothing rule (git wins the whole region).
- */
-function tryMergeRegion(
-  o: string[],
-  a: string[],
-  b: string[],
-): LocalPick[] | null {
-  // Agreement short-circuit (review #11). When live (a) and target (b) are
-  // identical, both sides converged on the SAME result — diff3 "agreement", NOT
-  // a conflict. This is the dominant echo case (live == target != base) that
-  // otherwise trips the overlap check below and is logged as a false "N same-block
-  // conflict(s) resolved to the git version", masking REAL data-loss signals.
-  // Emit the region straight from live (which equals target); no conflict.
-  if (a.length === b.length && a.every((v, i) => v === b[i])) {
-    return a.map((_v, i) => ({ src: 'live', local: i }) as LocalPick);
-  }
-
-  const aHunks = buildHunks(o, a);
-  const bHunks = buildHunks(o, b);
-
-  // Any overlap between a human hunk and a git hunk is a real conflict; bail so
-  // the caller falls back to git-wins (preserving the original behavior).
-  for (const ah of aHunks) {
-    for (const bh of bHunks) {
-      if (hunksOverlap(ah, bh)) return null;
-    }
-  }
-
-  // Disjoint: live index of each base block that BOTH sides kept (stable).
-  const aKept = matchMap(lcsPairs(o, a)); // base index -> live index
-
-  const out: LocalPick[] = [];
-  let pa = 0;
-  let pb = 0;
-  let oi = 0;
-  while (oi < o.length || pa < aHunks.length || pb < bHunks.length) {
-    const ah = pa < aHunks.length ? aHunks[pa] : null;
-    const bh = pb < bHunks.length ? bHunks[pb] : null;
-    const nextStart = Math.min(
-      ah ? ah.oStart : o.length,
-      bh ? bh.oStart : o.length,
-    );
-
-    // Emit stable base blocks (kept by both) until the next hunk, from LIVE.
-    while (oi < nextStart) {
-      out.push({ src: 'live', local: aKept.get(oi) as number });
-      oi++;
-    }
-    if (!ah && !bh) break;
-
-    // Apply the hunk at oi. When both sides act here they are disjoint, so the
-    // pure-insert (oEnd === oi) is emitted before the side that consumes base oi.
-    const aHere = ah !== null && ah.oStart === oi;
-    const bHere = bh !== null && bh.oStart === oi;
-    let useA: boolean;
-    if (aHere && bHere) {
-      useA = ah!.oEnd === oi; // insert side first; otherwise either order is fine
-    } else {
-      useA = aHere;
-    }
-    const h = (useA ? ah : bh) as Hunk;
-    const src: 'live' | 'target' = useA ? 'live' : 'target';
-    for (const idx of h.content) out.push({ src, local: idx });
-    oi = h.oEnd;
-    if (useA) pa++;
-    else pb++;
-  }
-  return out;
-}
-
-export interface Pick {
-  src: 'live' | 'target';
-  index: number;
-}
-
-/**
- * The merged block order PLUS how many regions resolved as a genuine SAME-BLOCK
- * conflict (both sides rewrote the same base block — `tryMergeRegion` returned
- * null and git won the whole region, so the live/human version of those blocks
- * is NOT in `picks`). `conflicts > 0` is the OBSERVABLE signal the caller uses to
- * surface "git won a concurrent same-block edit" (log it + pin the human
- * baseline to page history) instead of dropping the human side silently.
- */
-export interface Diff3Result {
-  picks: Pick[];
-  conflicts: number;
-}
-
-/**
- * Three-way merge of base `o`, live `a`, target `b` (arrays of block keys).
- * Returns the merged block order as picks from live/target. Thin wrapper over
- * `diff3PlanWithConflicts` (kept for the existing pure-array callers/tests).
- */
-export function diff3Plan(o: string[], a: string[], b: string[]): Pick[] {
-  return diff3PlanWithConflicts(o, a, b).picks;
-}
-
-/**
- * Like `diff3Plan` but also reports the SAME-BLOCK conflict count (see
- * `Diff3Result`). A region where both the human and git rewrote the same base
- * block cannot be merged automatically; the rule is deterministic — GIT WINS the
- * whole region — but the human's version of those blocks is then absent from the
- * picks, so we count it so the caller can make the loss observable/recoverable
- * rather than silent (the documented conflict contract).
- */
-export function diff3PlanWithConflicts(
-  o: string[],
-  a: string[],
-  b: string[],
-): Diff3Result {
-  const oToA = matchMap(lcsPairs(o, a));
-  const oToB = matchMap(lcsPairs(o, b));
-
-  const res: Pick[] = [];
-  let conflicts = 0;
-  let oi = 0;
-  let ai = 0;
-  let bi = 0;
-
-  for (;;) {
-    // Next anchor: a base block present (unchanged) in BOTH live and target.
-    let anchor = oi;
-    while (anchor < o.length && !(oToA.has(anchor) && oToB.has(anchor))) {
-      anchor++;
-    }
-    const aEnd = anchor < o.length ? (oToA.get(anchor) as number) : a.length;
-    const bEnd = anchor < o.length ? (oToB.get(anchor) as number) : b.length;
-
-    // Resolve the region [oi,anchor) that one or both sides rewrote/inserted.
-    // Try a fine-grained three-way merge first so a human block-edit survives a
-    // git insert/delete of OTHER blocks in the same region; only a genuine
-    // same-block conflict (null) falls back to the original git-wins rule.
-    const merged = tryMergeRegion(
-      o.slice(oi, anchor),
-      a.slice(ai, aEnd),
-      b.slice(bi, bEnd),
-    );
-    if (merged) {
-      for (const p of merged) {
-        res.push(
-          p.src === 'live'
-            ? { src: 'live', index: ai + p.local }
-            : { src: 'target', index: bi + p.local },
-        );
-      }
-    } else {
-      // SAME-BLOCK CONFLICT: count it ONLY when the human side actually had
-      // content in this region that git's win discards (live region non-empty).
-      // A region only git rewrote (live region empty) is not a human loss.
-      if (aEnd > ai) conflicts++;
-      for (let k = bi; k < bEnd; k++) res.push({ src: 'target', index: k });
-    }
-
-    if (anchor >= o.length) break;
-
-    // Emit the stable anchor block from LIVE, then advance past it on all sides.
-    res.push({ src: 'live', index: aEnd });
-    ai = aEnd + 1;
-    bi = bEnd + 1;
-    oi = anchor + 1;
-  }
-
-  return { picks: res, conflicts };
-}

apps/server/src/collaboration/merge/yjs-body-merge.callout.spec.ts

@@ -1,171 +0,0 @@
-import { TiptapTransformer } from '@hocuspocus/transformer';
-import * as Y from 'yjs';
-import {
-  markdownToProseMirror,
-  convertProseMirrorToMarkdown,
-} from '@docmost/git-sync';
-
-import { tiptapExtensions } from '../collaboration.util';
-import { mergeXmlFragments, mergeXmlFragments3Way } from './yjs-body-merge';
-
-/**
- * Regression for the QA #119 callout findings (body-duplication re-verify +
- * "callout strips the whole body"). These reproduce the ACTUAL live merge path:
- *
- *   live  = TiptapTransformer.toYdoc(editor JSON, tiptapExtensions)   (the
- *           collaboration server's materialization — schema defaults stamped)
- *   git   = toYdoc(markdownToProseMirror(convertProseMirrorToMarkdown(editor)))
- *           (the engine round-trip the push side feeds into writePageBody)
- *
- * A page containing a callout (with a neighbouring heading + paragraphs) must:
- *   - merge with ZERO ops on an unchanged resync (no duplication — bug #1), and
- *   - NEVER lose blocks / collapse to empty (no strip — bug #2),
- * across repeated cycles, for every editor-canonical callout type.
- */
-
-const toYdoc = (content: unknown[]) =>
-  TiptapTransformer.toYdoc(
-    { type: 'doc', content },
-    'default',
-    tiptapExtensions as any,
-  );
-
-const blockTypes = (f: Y.XmlFragment) =>
-  f.toArray().map((n: any) => n.nodeName);
-
-function editorPage(calloutType: string) {
-  return [
-    {
-      type: 'heading',
-      attrs: { id: 'h1', level: 1 },
-      content: [{ type: 'text', text: 'Title here' }],
-    },
-    {
-      type: 'paragraph',
-      attrs: { id: 'p1' },
-      content: [{ type: 'text', text: 'Para before callout' }],
-    },
-    {
-      type: 'callout',
-      attrs: { type: calloutType },
-      content: [
-        {
-          type: 'paragraph',
-          attrs: { id: 'pc' },
-          content: [{ type: 'text', text: 'Inside the callout' }],
-        },
-      ],
-    },
-    {
-      type: 'paragraph',
-      attrs: { id: 'p2' },
-      content: [{ type: 'text', text: 'Para after callout' }],
-    },
-  ];
-}
-
-async function gitRoundTrip(content: unknown[]): Promise<any[]> {
-  const md = await convertProseMirrorToMarkdown({ type: 'doc', content });
-  const json = await markdownToProseMirror(md);
-  return json.content;
-}
-
-describe('git-sync callout merge is idempotent + non-destructive (QA #119)', () => {
-  for (const type of ['info', 'note', 'warning', 'danger', 'success', 'default']) {
-    it(`callout(${type}) resyncs with 0 ops and never strips the body`, async () => {
-      const editor = editorPage(type);
-      const gitContent = await gitRoundTrip(editor);
-
-      const liveDoc = toYdoc(editor);
-      const live = liveDoc.getXmlFragment('default');
-      const before = live.toArray().length;
-      expect(before).toBe(4);
-
-      // 2-way: live vs the git round-trip -> no-op (no dup, no strip).
-      let applied = -1;
-      liveDoc.transact(() => {
-        applied = mergeXmlFragments(live, toYdoc(gitContent).getXmlFragment('default'));
-      });
-      expect(applied).toBe(0);
-      expect(live.toArray().length).toBe(before);
-
-      // 3-way across 4 cycles with base == git (the steady-state) -> stable.
-      for (let cycle = 0; cycle < 4; cycle++) {
-        let a = -1;
-        liveDoc.transact(() => {
-          a = mergeXmlFragments3Way(
-            live,
-            toYdoc(gitContent).getXmlFragment('default'),
-            toYdoc(gitContent).getXmlFragment('default'),
-          );
-        });
-        expect(a).toBe(0);
-        expect(live.toArray().length).toBe(before);
-        expect(blockTypes(live)).toEqual([
-          'heading',
-          'paragraph',
-          'callout',
-          'paragraph',
-        ]);
-      }
-    });
-  }
-
-  it('3-way with a stale base (callout JUST added) keeps the callout + neighbours', async () => {
-    // base = the previously-synced version WITHOUT the callout (git round-trip);
-    // the human just inserted the callout -> the merge must KEEP everything.
-    const prev = [
-      { type: 'heading', attrs: { id: 'h1', level: 1 }, content: [{ type: 'text', text: 'Title here' }] },
-      { type: 'paragraph', attrs: { id: 'p1' }, content: [{ type: 'text', text: 'Para before callout' }] },
-      { type: 'paragraph', attrs: { id: 'p2' }, content: [{ type: 'text', text: 'Para after callout' }] },
-    ];
-    const editor = editorPage('info');
-    const baseContent = await gitRoundTrip(prev);
-    const gitContent = await gitRoundTrip(editor);
-
-    const liveDoc = toYdoc(editor);
-    const live = liveDoc.getXmlFragment('default');
-    liveDoc.transact(() => {
-      mergeXmlFragments3Way(
-        live,
-        toYdoc(gitContent).getXmlFragment('default'),
-        toYdoc(baseContent).getXmlFragment('default'),
-      );
-    });
-    // Body survives in full — NOT stripped to empty / a lone paragraph.
-    expect(blockTypes(live)).toEqual([
-      'heading',
-      'paragraph',
-      'callout',
-      'paragraph',
-    ]);
-  });
-});
-
-describe('git-sync callout type fidelity (QA "callout type -> [!info]")', () => {
-  for (const type of ['info', 'note', 'warning', 'danger', 'success', 'default']) {
-    it(`preserves callout type "${type}" across the engine round-trip`, async () => {
-      const content = editorPage(type);
-      const gitContent = await gitRoundTrip(content);
-      const co = gitContent.find((b: any) => b.type === 'callout');
-      expect(co?.attrs?.type).toBe(type);
-    });
-  }
-
-  it('maps a known GitHub/Obsidian alias to the editor banner (tip -> success)', async () => {
-    // `tip` is not a schema callout type — it is an input alias the editor itself
-    // maps onto the supported set (GITHUB_ALERT_TYPE_MAP: tip -> success). git-sync
-    // mirrors that so the ingest lands on the closest banner instead of flatly info.
-    const content = editorPage('tip');
-    const gitContent = await gitRoundTrip(content);
-    const co = gitContent.find((b: any) => b.type === 'callout');
-    expect(co?.attrs?.type).toBe('success');
-  });
-
-  it('flattens a genuinely unknown callout type to info', async () => {
-    const content = editorPage('banana'); // not a type and not a known alias
-    const gitContent = await gitRoundTrip(content);
-    const co = gitContent.find((b: any) => b.type === 'callout');
-    expect(co?.attrs?.type).toBe('info');
-  });
-});

apps/server/src/collaboration/merge/yjs-body-merge.idempotency.spec.ts

@@ -1,198 +0,0 @@
-import * as Y from 'yjs';
-
-import { mergeXmlFragments, mergeXmlFragments3Way } from './yjs-body-merge';
-
-/**
- * Regression for the HIGH-severity runaway whole-body duplication: a page body
- * was RE-APPENDED in full on every git-sync reconcile cycle, unbounded, with NO
- * client connected.
- *
- * ROOT CAUSE (confirmed in-process against the real failing page): the LIVE Yjs
- * document materializes the editor-schema default `indent: 0` on every
- * paragraph/heading (and on the paragraph inside every list item, callout, and
- * table cell), but a body re-imported from git — parsed from clean markdown —
- * carries NO indent attribute. So every live block's comparison key differed from
- * the same block coming back from git; the three-way merge could anchor on
- * NOTHING, and the trailing unit that git's export already contained (but the
- * merge could not match against the byte-identical live tail) was re-appended
- * each cycle. Each grown export then diverged from the last-pushed base by one
- * more unit — a self-sustaining loop.
- *
- * The fix normalizes the materialized default (`indent: 0`) out of the block key
- * (the schema-derived `serializeXmlNode` normalization in yjs-body-merge.ts drops
- * every attr equal to its ProseMirror-schema default; `indent: 0` is one such),
- * so a live block compares equal to its git-round-tripped twin and the resync is
- * a true no-op. The sibling `yjs-body-merge.schema-defaults.spec.ts` covers the
- * rest of the bug class (image.align, link mark internal, …).
- *
- * These tests model that EXACTLY at the Yjs level: a LIVE fragment whose blocks
- * carry `indent: 0` + block ids, versus a git-derived fragment of the SAME
- * content with neither — for a body built from BYTE-IDENTICAL units that each
- * contain a heading, a paragraph, a callout, and a table with empty cells (the
- * trigger). RED before the fix (the merge applies > 0 ops and the body grows),
- * GREEN after (0 ops, no growth).
- */
-
-type Attrs = Record<string, string | number>;
-
-function el(
-  name: string,
-  attrs: Attrs,
-  children: (Y.XmlElement | Y.XmlText)[],
-) {
-  const e = new Y.XmlElement(name);
-  for (const [k, v] of Object.entries(attrs)) e.setAttribute(k, v as string);
-  if (children.length) e.insert(0, children);
-  return e;
-}
-
-function text(s: string): Y.XmlText {
-  const t = new Y.XmlText();
-  if (s) t.insert(0, s);
-  return t;
-}
-
-/**
- * One byte-identical content unit (heading / paragraph / callout / table-with-
- * empty-cells). `live` toggles the two things that exist ONLY in the live Yjs
- * doc and NOT in a git round-trip: the materialized `indent: 0` default and the
- * per-block `id`. `n` makes each unit's ids unique (as the editor would stamp)
- * while keeping the visible CONTENT byte-identical across units.
- */
-function unit(
-  live: boolean,
-  n: number,
-  headingText = 'Big Heading',
-): Y.XmlElement[] {
-  const ind: Attrs = live ? { indent: 0 } : {};
-  const id = (base: string): Attrs => (live ? { id: `${base}${n}` } : {});
-  const para = (attrs: Attrs, s: string) =>
-    el('paragraph', { ...attrs, ...ind }, [text(s)]);
-
-  const cell = (name: string) =>
-    el(name, { colspan: 1, rowspan: 1 }, [para({}, '')]);
-
-  return [
-    el('heading', { ...id('h'), level: 1, ...ind }, [text(headingText)]),
-    para(id('p'), 'Para with the same words'),
-    el('callout', { type: 'info' }, [para(id('c'), 'CalloutText here')]),
-    el('table', {}, [
-      el('tableRow', {}, [cell('tableHeader'), cell('tableHeader')]),
-      el('tableRow', {}, [cell('tableCell'), cell('tableCell')]),
-    ]),
-  ];
-}
-
-function fragmentOf(units: Y.XmlElement[][]): {
-  doc: Y.Doc;
-  frag: Y.XmlFragment;
-} {
-  const doc = new Y.Doc();
-  const frag = doc.getXmlFragment('default');
-  const blocks = units.flat();
-  if (blocks.length) frag.insert(0, blocks);
-  return { doc, frag };
-}
-
-const blockCount = (frag: Y.XmlFragment): number => frag.toArray().length;
-
-describe('git-sync reconcile import is idempotent (no whole-body duplication)', () => {
-  const UNITS = 3;
-
-  it('3-way: identical content, live carries indent:0, base stale-by-one -> 0 ops, no growth', () => {
-    // LIVE: the editor-stamped Yjs doc (indent:0 + ids on every block).
-    const { doc: liveDoc, frag: live } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => unit(true, i)),
-    );
-    // INCOMING (git export -> re-import): same content, NO indent / ids.
-    const { frag: incoming } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => unit(false, i)),
-    );
-    // BASE = last-pushed file, lagging by ONE unit (the realistic divergence
-    // that drives the trailing insert-vs-insert).
-    const { frag: base } = fragmentOf(
-      Array.from({ length: UNITS - 1 }, (_, i) => unit(false, i)),
-    );
-
-    const before = blockCount(live);
-    let applied = -1;
-    liveDoc.transact(() => {
-      applied = mergeXmlFragments3Way(live, incoming, base);
-    });
-
-    expect(applied).toBe(0);
-    expect(blockCount(live)).toBe(before);
-  });
-
-  it('3-way is a fixpoint across repeated cycles (does not grow)', () => {
-    const { doc: liveDoc, frag: live } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => unit(true, i)),
-    );
-    const incomingUnits = () =>
-      fragmentOf(Array.from({ length: UNITS }, (_, i) => unit(false, i))).frag;
-    const baseUnits = () =>
-      fragmentOf(Array.from({ length: UNITS - 1 }, (_, i) => unit(false, i)))
-        .frag;
-
-    const before = blockCount(live);
-    for (let cycle = 0; cycle < 5; cycle++) {
-      let applied = -1;
-      liveDoc.transact(() => {
-        applied = mergeXmlFragments3Way(live, incomingUnits(), baseUnits());
-      });
-      expect(applied).toBe(0);
-      expect(blockCount(live)).toBe(before);
-    }
-  });
-
-  it('2-way: identical content, live carries indent:0 -> 0 ops, no growth', () => {
-    const { doc: liveDoc, frag: live } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => unit(true, i)),
-    );
-    const { frag: incoming } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => unit(false, i)),
-    );
-
-    const before = blockCount(live);
-    let applied = -1;
-    liveDoc.transact(() => {
-      applied = mergeXmlFragments(live, incoming);
-    });
-
-    expect(applied).toBe(0);
-    expect(blockCount(live)).toBe(before);
-  });
-
-  it('does NOT regress real edits: a git change to one block still lands', () => {
-    const { doc: liveDoc, frag: live } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => unit(true, i)),
-    );
-    const base = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => unit(false, i)),
-    ).frag;
-    // git edits the heading text of the LAST unit.
-    const incoming = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) =>
-        unit(false, i, i === UNITS - 1 ? 'EDITED Heading' : 'Big Heading'),
-      ),
-    ).frag;
-
-    const before = blockCount(live);
-    liveDoc.transact(() => {
-      mergeXmlFragments3Way(live, incoming, base);
-    });
-
-    // The edit landed, and the body did NOT grow (one block changed in place).
-    const headings = live
-      .toArray()
-      .filter((b) => (b as Y.XmlElement).nodeName === 'heading')
-      .map((b) =>
-        (b as Y.XmlElement)
-          .toArray()
-          .map((c) => (c as Y.XmlText).toString())
-          .join(''),
-      );
-    expect(headings).toContain('EDITED Heading');
-    expect(blockCount(live)).toBe(before);
-  });
-});

apps/server/src/collaboration/merge/yjs-body-merge.schema-defaults.spec.ts

@@ -1,316 +0,0 @@
-import { TiptapTransformer } from '@hocuspocus/transformer';
-import * as Y from 'yjs';
-
-import { tiptapExtensions } from '../collaboration.util';
-import { mergeXmlFragments, mergeXmlFragments3Way } from './yjs-body-merge';
-
-/**
- * Regression for the BUG CLASS behind the runaway whole-body duplication: the
- * point-fix (7a7b840e) only normalized `indent: 0`, but the SAME divergence
- * recurs for every attribute whose editor-ext (server) schema default the live
- * Yjs doc MATERIALIZES while the git round-trip — which comes through the engine
- * schema (different, usually null, defaults) plus `y-prosemirror`'s null-attr
- * dropping — does NOT carry. Confirmed triggers beyond `indent`:
- *
- *   - `image.align`   : editor-ext default "center" (materialized) vs engine
- *                       default null (dropped) -> element-attr divergence.
- *   - link mark `internal`: editor-ext default false (materialized) vs engine
- *                       default null -> MARK-attr divergence (the prior denylist
- *                       could not reach marks at all — they are serialized raw in
- *                       the XmlText delta).
- *
- * `highlight.colorName` is normalized too (defense-in-depth); it is NOT a strong
- * real-world trigger because BOTH schemas default it to null, but the schema-
- * derived normalization handles it for free and stays idempotent.
- *
- * The fix derives the defaults from the ACTUAL ProseMirror schema (getSchema of
- * the server tiptapExtensions) and drops any element- OR mark-attribute equal to
- * its schema default (or null/undefined) from the block comparison key — so a
- * live block compares equal to its git-round-tripped twin and an unchanged
- * resync applies 0 ops. RED before the fix (keys diverge -> ops > 0 / growth),
- * GREEN after.
- */
-
-type Attrs = Record<string, unknown>;
-
-function el(
-  name: string,
-  attrs: Attrs,
-  children: (Y.XmlElement | Y.XmlText)[],
-): Y.XmlElement {
-  const e = new Y.XmlElement(name);
-  for (const [k, v] of Object.entries(attrs)) e.setAttribute(k, v as string);
-  if (children.length) e.insert(0, children);
-  return e;
-}
-
-/** Text carrying marks, as the live Yjs doc stores them (XmlText format ops). */
-function markedText(s: string, marks: Record<string, unknown>): Y.XmlText {
-  const t = new Y.XmlText();
-  t.insert(0, s, marks);
-  return t;
-}
-
-/**
- * One byte-identical RICH unit: a paragraph with a LINK, a top-level IMAGE, and
- * a paragraph with a HIGHLIGHT. `live` toggles exactly what the editor
- * materializes but a git round-trip does not: block `id`, `indent: 0`,
- * `image.align: "center"`, the link mark's `internal: false`, and the
- * highlight's `colorName: null`.
- */
-function richUnit(live: boolean, n: number): Y.XmlElement[] {
-  const ind: Attrs = live ? { indent: 0 } : {};
-  const id = (base: string): Attrs => (live ? { id: `${base}${n}` } : {});
-
-  const linkMarks = live
-    ? {
-        link: {
-          href: 'https://example.com',
-          target: '_blank',
-          rel: 'noopener noreferrer nofollow',
-          class: null,
-          title: null,
-          internal: false, // editor-ext default, materialized
-        },
-      }
-    : {
-        link: {
-          href: 'https://example.com',
-          target: '_blank',
-          rel: 'noopener noreferrer nofollow',
-          internal: null, // engine default
-        },
-      };
-
-  const hlMarks = live
-    ? { highlight: { color: '#ffd43b', colorName: null } }
-    : { highlight: { color: '#ffd43b' } };
-
-  const imageAttrs: Attrs = live
-    ? { src: 'https://img.example.com/a.png', align: 'center' } // materialized
-    : { src: 'https://img.example.com/a.png' }; // align:null dropped on git side
-
-  return [
-    el('paragraph', { ...id('lp'), ...ind }, [
-      markedText('click here', linkMarks),
-    ]),
-    el('image', imageAttrs, []),
-    el('paragraph', { ...id('hp'), ...ind }, [markedText('hot', hlMarks)]),
-  ];
-}
-
-function fragmentOf(units: Y.XmlElement[][]): {
-  doc: Y.Doc;
-  frag: Y.XmlFragment;
-} {
-  const doc = new Y.Doc();
-  const frag = doc.getXmlFragment('default');
-  const blocks = units.flat();
-  if (blocks.length) frag.insert(0, blocks);
-  return { doc, frag };
-}
-
-const blockCount = (frag: Y.XmlFragment): number => frag.toArray().length;
-
-describe('git-sync reconcile is idempotent for schema-default attrs (image/link/highlight)', () => {
-  const UNITS = 3;
-
-  it('3-way: live carries image.align/link.internal/indent defaults, base stale-by-one -> 0 ops', () => {
-    const { doc: liveDoc, frag: live } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => richUnit(true, i)),
-    );
-    const { frag: incoming } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => richUnit(false, i)),
-    );
-    const { frag: base } = fragmentOf(
-      Array.from({ length: UNITS - 1 }, (_, i) => richUnit(false, i)),
-    );
-
-    const before = blockCount(live);
-    let applied = -1;
-    liveDoc.transact(() => {
-      applied = mergeXmlFragments3Way(live, incoming, base);
-    });
-
-    expect(applied).toBe(0);
-    expect(blockCount(live)).toBe(before);
-  });
-
-  it('2-way: live carries the materialized defaults -> 0 ops, no growth', () => {
-    const { doc: liveDoc, frag: live } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => richUnit(true, i)),
-    );
-    const { frag: incoming } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => richUnit(false, i)),
-    );
-
-    const before = blockCount(live);
-    let applied = -1;
-    liveDoc.transact(() => {
-      applied = mergeXmlFragments(live, incoming);
-    });
-
-    expect(applied).toBe(0);
-    expect(blockCount(live)).toBe(before);
-  });
-
-  it('is a fixpoint across repeated cycles (does not grow)', () => {
-    const { doc: liveDoc, frag: live } = fragmentOf(
-      Array.from({ length: UNITS }, (_, i) => richUnit(true, i)),
-    );
-    const incoming = () =>
-      fragmentOf(Array.from({ length: UNITS }, (_, i) => richUnit(false, i)))
-        .frag;
-    const base = () =>
-      fragmentOf(
-        Array.from({ length: UNITS - 1 }, (_, i) => richUnit(false, i)),
-      ).frag;
-
-    const before = blockCount(live);
-    for (let cycle = 0; cycle < 5; cycle++) {
-      let applied = -1;
-      liveDoc.transact(() => {
-        applied = mergeXmlFragments3Way(live, incoming(), base());
-      });
-      expect(applied).toBe(0);
-      expect(blockCount(live)).toBe(before);
-    }
-  });
-
-  it('does NOT regress a genuine non-default value (a real link.href / image.align:left still diffs)', () => {
-    const { doc: liveDoc, frag: live } = fragmentOf([richUnit(true, 0)]);
-    const base = fragmentOf([richUnit(false, 0)]).frag;
-    // git genuinely changes the image alignment to a NON-default value.
-    const incomingUnit = richUnit(false, 0);
-    (incomingUnit[1] as Y.XmlElement).setAttribute('align', 'left');
-    const incoming = fragmentOf([incomingUnit]).frag;
-
-    liveDoc.transact(() => {
-      mergeXmlFragments3Way(live, incoming, base);
-    });
-
-    const img = live
-      .toArray()
-      .find((b) => (b as Y.XmlElement).nodeName === 'image') as Y.XmlElement;
-    expect(img.getAttribute('align')).toBe('left');
-  });
-});
-
-/**
- * FAITHFUL end-to-end proof through the REAL server transformer: build the live
- * doc the way the collaboration server does (defaults omitted in the JSON ->
- * TiptapTransformer.toYdoc MATERIALIZES image.align:"center", link.internal:false,
- * indent:0) versus the git-derived doc (engine-style: defaults emitted as
- * explicit null, no block ids). An unchanged resync must apply 0 ops.
- */
-describe('git-sync reconcile is idempotent through the real toYdoc materialization', () => {
-  const liveContent = [
-    {
-      type: 'paragraph',
-      attrs: { id: 'p1' },
-      content: [
-        {
-          type: 'text',
-          text: 'click here',
-          marks: [{ type: 'link', attrs: { href: 'https://example.com' } }],
-        },
-      ],
-    },
-    { type: 'image', attrs: { src: 'https://img.example.com/a.png' } },
-    {
-      type: 'paragraph',
-      attrs: { id: 'p2' },
-      content: [
-        {
-          type: 'text',
-          text: 'hot',
-          marks: [{ type: 'highlight', attrs: { color: '#ffd43b' } }],
-        },
-      ],
-    },
-  ];
-
-  // git/engine-style: explicit nulls for the engine-default attrs, no ids.
-  const gitContent = [
-    {
-      type: 'paragraph',
-      content: [
-        {
-          type: 'text',
-          text: 'click here',
-          marks: [
-            {
-              type: 'link',
-              attrs: {
-                href: 'https://example.com',
-                target: '_blank',
-                rel: 'noopener noreferrer nofollow',
-                class: null,
-                title: null,
-                internal: null,
-              },
-            },
-          ],
-        },
-      ],
-    },
-    {
-      type: 'image',
-      attrs: { src: 'https://img.example.com/a.png', align: null },
-    },
-    {
-      type: 'paragraph',
-      content: [
-        {
-          type: 'text',
-          text: 'hot',
-          marks: [
-            { type: 'highlight', attrs: { color: '#ffd43b', colorName: null } },
-          ],
-        },
-      ],
-    },
-  ];
-
-  const toYdoc = (content: unknown[]) =>
-    TiptapTransformer.toYdoc(
-      { type: 'doc', content },
-      'default',
-      tiptapExtensions as any,
-    );
-
-  it('3-way: materialized-default live vs engine-style git, base stale-by-one -> 0 ops', () => {
-    const liveDoc = toYdoc(liveContent);
-    const targetDoc = toYdoc(gitContent);
-    const baseDoc = toYdoc(gitContent.slice(0, gitContent.length - 1));
-
-    const live = liveDoc.getXmlFragment('default');
-    const before = live.toArray().length;
-    let applied = -1;
-    liveDoc.transact(() => {
-      applied = mergeXmlFragments3Way(
-        live,
-        targetDoc.getXmlFragment('default'),
-        baseDoc.getXmlFragment('default'),
-      );
-    });
-
-    expect(applied).toBe(0);
-    expect(live.toArray().length).toBe(before);
-  });
-
-  it('2-way: materialized-default live vs engine-style git -> 0 ops', () => {
-    const liveDoc = toYdoc(liveContent);
-    const targetDoc = toYdoc(gitContent);
-
-    const live = liveDoc.getXmlFragment('default');
-    const before = live.toArray().length;
-    let applied = -1;
-    liveDoc.transact(() => {
-      applied = mergeXmlFragments(live, targetDoc.getXmlFragment('default'));
-    });
-
-    expect(applied).toBe(0);
-    expect(live.toArray().length).toBe(before);
-  });
-});

apps/server/src/collaboration/merge/yjs-body-merge.spec.ts

@@ -1,373 +0,0 @@
-import * as Y from 'yjs';
-
-import {
-  mergeXmlFragments,
-  mergeXmlFragments3Way,
-  mergeXmlFragments3WayWithStats,
-  cloneXmlNode,
-  diffBlocks,
-} from './yjs-body-merge';
-
-// Build a Y.XmlFragment('default') in `doc` from a list of paragraph specs.
-// Each spec is the paragraph's plain text (a single XmlText child).
-function buildFragment(doc: Y.Doc, paragraphs: string[]): Y.XmlFragment {
-  const frag = doc.getXmlFragment('default');
-  const blocks = paragraphs.map((text) => {
-    const el = new Y.XmlElement('paragraph');
-    const t = new Y.XmlText();
-    if (text) t.insert(0, text);
-    el.insert(0, [t]);
-    return el;
-  });
-  if (blocks.length) frag.insert(0, blocks);
-  return frag;
-}
-
-function texts(frag: Y.XmlFragment): string[] {
-  return frag.toArray().map((el) => (el as Y.XmlElement).toArray()
-    .map((c) => (c as Y.XmlText).toString())
-    .join(''));
-}
-
-describe('yjs-body-merge', () => {
-  describe('diffBlocks (LCS edit script)', () => {
-    it('identical sequences produce only keeps (no edits)', () => {
-      const ops = diffBlocks(['a', 'b', 'c'], ['a', 'b', 'c']);
-      expect(ops.every((o) => o.op === 'keep')).toBe(true);
-    });
-
-    it('a single changed middle element is one del + one ins', () => {
-      const ops = diffBlocks(['a', 'b', 'c'], ['a', 'B', 'c']);
-      expect(ops.filter((o) => o.op === 'del')).toHaveLength(1);
-      expect(ops.filter((o) => o.op === 'ins')).toHaveLength(1);
-      expect(ops.filter((o) => o.op === 'keep')).toHaveLength(2);
-    });
-  });
-
-  describe('mergeXmlFragments', () => {
-    it('identical content is a complete no-op (0 ops) — never clobbers an unchanged resync', () => {
-      const live = new Y.Doc();
-      const target = new Y.Doc();
-      const liveFrag = buildFragment(live, ['one', 'two', 'three']);
-      const targetFrag = buildFragment(target, ['one', 'two', 'three']);
-
-      // Capture block identities to prove they are left untouched.
-      const before = liveFrag.toArray();
-      let applied = -1;
-      live.transact(() => {
-        applied = mergeXmlFragments(liveFrag, targetFrag);
-      });
-
-      expect(applied).toBe(0);
-      // Same Y.XmlElement instances — nothing was deleted/recreated.
-      expect(liveFrag.toArray()).toEqual(before);
-      expect(texts(liveFrag)).toEqual(['one', 'two', 'three']);
-    });
-
-    it('a human edit to one block survives a git change to a DIFFERENT block', () => {
-      // Live: the human has the doc open; block 0 holds their edit. Git changed
-      // only block 2. The merge must touch ONLY block 2 and leave block 0 (and
-      // its in-flight edit) exactly as-is.
-      const live = new Y.Doc();
-      const target = new Y.Doc();
-      const liveFrag = buildFragment(live, ['HUMAN EDIT', 'shared', 'old tail']);
-      const targetFrag = buildFragment(target, [
-        'HUMAN EDIT',
-        'shared',
-        'new tail from git',
-      ]);
-
-      const block0Before = liveFrag.get(0); // the human's block instance
-      const block1Before = liveFrag.get(1);
-
-      let applied = -1;
-      live.transact(() => {
-        applied = mergeXmlFragments(liveFrag, targetFrag);
-      });
-
-      // Only block 2 was replaced: one del + one ins.
-      expect(applied).toBe(2);
-      // The human's block and the shared block are the SAME instances (untouched).
-      expect(liveFrag.get(0)).toBe(block0Before);
-      expect(liveFrag.get(1)).toBe(block1Before);
-      // Block 2 now carries git's content.
-      expect(texts(liveFrag)).toEqual([
-        'HUMAN EDIT',
-        'shared',
-        'new tail from git',
-      ]);
-    });
-
-    it('appends a new trailing block without disturbing existing ones', () => {
-      const live = new Y.Doc();
-      const target = new Y.Doc();
-      const liveFrag = buildFragment(live, ['a', 'b']);
-      const targetFrag = buildFragment(target, ['a', 'b', 'c']);
-      const a = liveFrag.get(0);
-      const b = liveFrag.get(1);
-
-      let applied = -1;
-      live.transact(() => {
-        applied = mergeXmlFragments(liveFrag, targetFrag);
-      });
-
-      expect(applied).toBe(1); // single insert
-      expect(liveFrag.get(0)).toBe(a);
-      expect(liveFrag.get(1)).toBe(b);
-      expect(texts(liveFrag)).toEqual(['a', 'b', 'c']);
-    });
-
-    it('deletes a removed block, keeping its neighbours', () => {
-      const live = new Y.Doc();
-      const target = new Y.Doc();
-      const liveFrag = buildFragment(live, ['a', 'b', 'c']);
-      const targetFrag = buildFragment(target, ['a', 'c']);
-      const a = liveFrag.get(0);
-
-      let applied = -1;
-      live.transact(() => {
-        applied = mergeXmlFragments(liveFrag, targetFrag);
-      });
-
-      expect(applied).toBe(1); // single delete
-      expect(liveFrag.get(0)).toBe(a);
-      expect(texts(liveFrag)).toEqual(['a', 'c']);
-    });
-
-    it('a fully different body is replaced (and stays valid)', () => {
-      const live = new Y.Doc();
-      const target = new Y.Doc();
-      const liveFrag = buildFragment(live, ['x', 'y']);
-      const targetFrag = buildFragment(target, ['p', 'q', 'r']);
-      live.transact(() => mergeXmlFragments(liveFrag, targetFrag));
-      expect(texts(liveFrag)).toEqual(['p', 'q', 'r']);
-    });
-  });
-
-  describe('mergeXmlFragments3Way', () => {
-    it('keeps a human edit to one block while applying a git change to another (3-way)', () => {
-      // base (last synced): [a, b, c]. Human edited block 0 in the live doc; git
-      // changed block 2 in the incoming file. 3-way must keep BOTH — the 2-way
-      // merge would instead revert the human's block 0 to git's stale version.
-      const base = new Y.Doc();
-      const live = new Y.Doc();
-      const target = new Y.Doc();
-      const baseFrag = buildFragment(base, ['a', 'b', 'c']);
-      const liveFrag = buildFragment(live, ['HUMAN', 'b', 'c']);
-      const targetFrag = buildFragment(target, ['a', 'b', 'GIT']);
-
-      const humanBlock = liveFrag.get(0); // the human's live instance
-      live.transact(() =>
-        mergeXmlFragments3Way(liveFrag, targetFrag, baseFrag),
-      );
-
-      // Human's block preserved as the SAME instance; git's change applied.
-      expect(liveFrag.get(0)).toBe(humanBlock);
-      expect(texts(liveFrag)).toEqual(['HUMAN', 'b', 'GIT']);
-    });
-
-    it('a block both sides changed resolves to git (conflict policy)', () => {
-      const base = new Y.Doc();
-      const live = new Y.Doc();
-      const target = new Y.Doc();
-      const baseFrag = buildFragment(base, ['a', 'b', 'c']);
-      const liveFrag = buildFragment(live, ['a', 'HUMAN', 'c']);
-      const targetFrag = buildFragment(target, ['a', 'GIT', 'c']);
-
-      live.transact(() =>
-        mergeXmlFragments3Way(liveFrag, targetFrag, baseFrag),
-      );
-      expect(texts(liveFrag)).toEqual(['a', 'GIT', 'c']);
-    });
-
-    // Bug #2 observability: the stats variant reports the same-block conflict so
-    // the handler can log it + the persistence layer can pin the human baseline.
-    it('reports the same-block conflict count via mergeXmlFragments3WayWithStats', () => {
-      const base = new Y.Doc();
-      const live = new Y.Doc();
-      const target = new Y.Doc();
-      const baseFrag = buildFragment(base, ['a', 'b', 'c']);
-      const liveFrag = buildFragment(live, ['a', 'HUMAN', 'c']);
-      const targetFrag = buildFragment(target, ['a', 'GIT', 'c']);
-
-      let result!: { applied: number; conflicts: number };
-      live.transact(() => {
-        result = mergeXmlFragments3WayWithStats(liveFrag, targetFrag, baseFrag);
-      });
-      expect(result.conflicts).toBe(1);
-      expect(texts(liveFrag)).toEqual(['a', 'GIT', 'c']);
-    });
-
-    it('reports 0 conflicts for a clean different-block 3-way merge', () => {
-      const base = new Y.Doc();
-      const live = new Y.Doc();
-      const target = new Y.Doc();
-      const baseFrag = buildFragment(base, ['a', 'b', 'c']);
-      const liveFrag = buildFragment(live, ['HUMAN', 'b', 'c']);
-      const targetFrag = buildFragment(target, ['a', 'b', 'GIT']);
-
-      let result!: { applied: number; conflicts: number };
-      live.transact(() => {
-        result = mergeXmlFragments3WayWithStats(liveFrag, targetFrag, baseFrag);
-      });
-      expect(result.conflicts).toBe(0);
-      expect(texts(liveFrag)).toEqual(['HUMAN', 'b', 'GIT']);
-    });
-
-    it('git change with no concurrent human edit (live == base) applies cleanly', () => {
-      const base = new Y.Doc();
-      const live = new Y.Doc();
-      const target = new Y.Doc();
-      const baseFrag = buildFragment(base, ['a', 'b']);
-      const liveFrag = buildFragment(live, ['a', 'b']);
-      const targetFrag = buildFragment(target, ['a', 'B2']);
-
-      live.transact(() =>
-        mergeXmlFragments3Way(liveFrag, targetFrag, baseFrag),
-      );
-      expect(texts(liveFrag)).toEqual(['a', 'B2']);
-    });
-  });
-
-  // Regression: start-of-document content duplicating on every two-way sync.
-  //
-  // The LIVE Docmost doc stamps a per-block UniqueID on every heading/paragraph;
-  // a body arriving FROM git is parsed from clean markdown and carries NO block
-  // ids. If the merge comparison key includes that `id`, an unchanged live block
-  // never matches the SAME block coming from git, so the three-way merge cannot
-  // anchor on it — and an incoming block with no anchor (content inserted at the
-  // TOP of the page) is RE-ADDED on every cycle, an unbounded duplication loop.
-  // These tests model that exact id-asymmetry and assert the reconciliation is
-  // IDEMPOTENT (no block growth). They are RED before excluding `id` from the
-  // key in `serializeXmlNode`.
-  describe('idempotent reconciliation with live block ids (start-of-doc dup)', () => {
-    // Build a fragment from block specs. `id` is set only when provided, mirroring
-    // the live doc (ids present) vs a git-parsed body (ids absent).
-    type Spec = { tag: 'heading' | 'paragraph'; text: string; id?: string };
-    function buildDoc(doc: Y.Doc, specs: Spec[]): Y.XmlFragment {
-      const frag = doc.getXmlFragment('default');
-      const blocks = specs.map((s) => {
-        const el = new Y.XmlElement(s.tag);
-        if (s.id) el.setAttribute('id', s.id);
-        if (s.tag === 'heading') el.setAttribute('level', '2');
-        const t = new Y.XmlText();
-        if (s.text) t.insert(0, s.text);
-        el.insert(0, [t]);
-        return el;
-      });
-      if (blocks.length) frag.insert(0, blocks);
-      return frag;
-    }
-    const textsOf = (frag: Y.XmlFragment): string[] =>
-      frag.toArray().map((el) =>
-        (el as Y.XmlElement)
-          .toArray()
-          .map((c) => (c as Y.XmlText).toString())
-          .join(''),
-      );
-
-    it('re-merging the SAME git body does NOT re-add the top block (idempotent)', () => {
-      // last-synced base (from git markdown): NO block ids.
-      const base = new Y.Doc();
-      const baseFrag = buildDoc(base, [
-        { tag: 'heading', text: 'Title' },
-        { tag: 'paragraph', text: 'Some paragraph.' },
-        { tag: 'paragraph', text: 'End block.' },
-      ]);
-      // live Docmost doc: SAME content, but every block carries a UniqueID.
-      const live = new Y.Doc();
-      const liveFrag = buildDoc(live, [
-        { tag: 'heading', text: 'Title', id: 'ida' },
-        { tag: 'paragraph', text: 'Some paragraph.', id: 'idb' },
-        { tag: 'paragraph', text: 'End block.', id: 'idc' },
-      ]);
-      // incoming git body: the user inserted a heading at the very TOP.
-      const buildTarget = (): Y.XmlFragment =>
-        buildDoc(new Y.Doc(), [
-          { tag: 'heading', text: 'TOPDUP' },
-          { tag: 'heading', text: 'Title' },
-          { tag: 'paragraph', text: 'Some paragraph.' },
-          { tag: 'paragraph', text: 'End block.' },
-        ]);
-
-      // First sync: the top block is added once.
-      live.transact(() =>
-        mergeXmlFragments3Way(liveFrag, buildTarget(), baseFrag),
-      );
-      expect(textsOf(liveFrag)).toEqual([
-        'TOPDUP',
-        'Title',
-        'Some paragraph.',
-        'End block.',
-      ]);
-
-      // Subsequent sync of the SAME git body against the SAME base must be a
-      // NO-OP — not a second copy of the top block. Before the fix this re-adds
-      // 'TOPDUP', growing the doc on every cycle.
-      live.transact(() =>
-        mergeXmlFragments3Way(liveFrag, buildTarget(), baseFrag),
-      );
-      expect(textsOf(liveFrag)).toEqual([
-        'TOPDUP',
-        'Title',
-        'Some paragraph.',
-        'End block.',
-      ]);
-      expect(textsOf(liveFrag).filter((t) => t === 'TOPDUP')).toHaveLength(1);
-    });
-
-    it('an unchanged git body (live ids, none in git) is a complete no-op', () => {
-      // base == git body (no pending git change); live is the same content with
-      // ids. With `id` in the key the whole body looks rewritten; the merge must
-      // still leave live byte-identical (block instances untouched).
-      const base = new Y.Doc();
-      const baseFrag = buildDoc(base, [
-        { tag: 'heading', text: 'Title' },
-        { tag: 'paragraph', text: 'Body.' },
-      ]);
-      const live = new Y.Doc();
-      const liveFrag = buildDoc(live, [
-        { tag: 'heading', text: 'Title', id: 'ida' },
-        { tag: 'paragraph', text: 'Body.', id: 'idb' },
-      ]);
-      const before = liveFrag.toArray();
-      let applied = -1;
-      live.transact(() => {
-        applied = mergeXmlFragments3Way(
-          liveFrag,
-          buildDoc(new Y.Doc(), [
-            { tag: 'heading', text: 'Title' },
-            { tag: 'paragraph', text: 'Body.' },
-          ]),
-          baseFrag,
-        );
-      });
-      expect(applied).toBe(0);
-      // Same live block instances (ids preserved) — nothing recreated.
-      expect(liveFrag.toArray()).toEqual(before);
-    });
-  });
-
-  describe('cloneXmlNode', () => {
-    it('preserves text marks (XmlText delta) across docs', () => {
-      const src = new Y.Doc();
-      const srcFrag = src.getXmlFragment('default');
-      const el = new Y.XmlElement('paragraph');
-      const t = new Y.XmlText();
-      t.insert(0, 'plain ');
-      t.insert(6, 'bold', { bold: true });
-      el.insert(0, [t]);
-      srcFrag.insert(0, [el]);
-
-      const dst = new Y.Doc();
-      const dstFrag = dst.getXmlFragment('default');
-      dstFrag.insert(0, [cloneXmlNode(srcFrag.get(0) as Y.XmlElement)]);
-
-      const clonedText = (dstFrag.get(0) as Y.XmlElement).get(0) as Y.XmlText;
-      expect(clonedText.toDelta()).toEqual([
-        { insert: 'plain ' },
-        { insert: 'bold', attributes: { bold: true } },
-      ]);
-    });
-  });
-});

apps/server/src/collaboration/merge/yjs-body-merge.ts

@@ -1,371 +0,0 @@
-import * as Y from 'yjs';
-import { getSchema } from '@tiptap/core';
-import type { Schema } from '@tiptap/pm/model';
-
-import { tiptapExtensions } from '../collaboration.util';
-import { diff3PlanWithConflicts } from './three-way-merge';
-import { buildLcsTable } from './lcs';
-
-/**
- * Block-level merge of an incoming (git) page body into a LIVE Yjs document,
- * replacing the previous full-body "delete everything + re-insert" write that
- * clobbered concurrent human edits on every sync (review #5 — "do the write as a
- * merge").
- *
- * Strategy: diff the two documents at TOP-LEVEL BLOCK granularity (an LCS over a
- * canonical structural serialization of each block) and apply only the minimal
- * insert/delete operations. Blocks that are byte-identical on both sides are
- * left UNTOUCHED in the live doc — so a human editing one paragraph is unaffected
- * when git changes a different paragraph, and an unchanged re-sync is a complete
- * no-op (zero Yjs operations). Yjs then CRDT-merges the minimal ops with any
- * concurrent edits.
- *
- * Merge mode: a THREE-WAY merge (live vs incoming vs base) runs whenever the
- * engine plumbs the last-synced base (`baseMarkdown` from refs/docmost/last-pushed)
- * — which it now does end-to-end — so a block both sides changed is a genuine
- * conflict resolved deterministically (git wins that block; the prior state is
- * preserved in page history). Only when NO base is available (a brand-new file)
- * does it fall back to a 2-way merge (live vs incoming). Common cases — unchanged
- * resync and edits to DIFFERENT blocks — are lossless in both modes.
- */
-
-type XmlNode = Y.XmlElement | Y.XmlText | Y.XmlHook;
-
-/**
- * Node attributes that are VOLATILE identity (not content) and so must be
- * excluded from the block comparison key.
- *
- * `id` is the per-block UniqueID the editor stamps on every heading/paragraph
- * (and transclusionSource). It exists ONLY in the live Yjs document — a body
- * arriving from git is parsed from clean markdown, which carries no block ids
- * (`markdownToProseMirror` materializes `id: null`, which the Yjs transform then
- * drops). If `id` were part of the key, an UNCHANGED live block (id "abc123")
- * would never match the SAME block coming from git (no id), so the three-way
- * merge's LCS could not anchor on it. The merge would then treat every live
- * block as deleted-and-reinserted and, when an incoming block has no matching
- * anchor (e.g. content inserted at the very TOP of the page), RE-ADD a copy of
- * it on every sync cycle — a non-convergent, unbounded duplication loop
- * (start-of-document content duplicating each push/pull cycle).
- *
- * Excluding `id` makes blocks compare by CONTENT, so an unchanged block matches
- * across the git round-trip and the reconciliation is idempotent. Block identity
- * is still preserved in the merged output: `diff3Plan` keeps the LIVE block
- * INSTANCE (with its id) for an anchor — picks are by index, not by key — so the
- * stable Yjs block (and any in-flight human edit on it) stays put. This mirrors
- * `canonicalize.ts`, which already strips the regenerated block `id` from the
- * round-trip idempotency comparison for exactly the same reason.
- *
- * Known limitation (accepted trade-off of content-based matching): two GENUINELY
- * DISTINCT blocks whose content is byte-identical now collapse to the same content
- * key, so when git deletes one of the duplicates the LCS may drop the OTHER live
- * instance instead. The visible result is identical (one copy removed, one kept),
- * but a concurrent in-flight human edit on the dropped instance could be lost.
- */
-const VOLATILE_KEY_ATTRS = new Set(['id']);
-
-/**
- * The editor (ProseMirror) schema, built ONCE from the same `tiptapExtensions`
- * the collaboration server uses to materialize Yjs docs. Memoized: building the
- * schema is non-trivial and the block key is computed per block per cycle.
- *
- * Why the schema (not a hardcoded denylist): the LIVE Yjs document is produced by
- * `TiptapTransformer.toYdoc(pm, 'default', tiptapExtensions)`, which STAMPS every
- * schema-default attribute onto every node and mark — `indent: 0` on every
- * paragraph/heading, `image.align: "center"`, the link mark's `internal: false`,
- * `highlight.colorName: null`, and so on for youtube/pdf/any future node. A body
- * re-imported from git comes through the engine's `markdownToProseMirror`, whose
- * schema declares those attrs with DIFFERENT (usually null) defaults; the
- * resulting null/absent element attrs are then DROPPED by `y-prosemirror`'s
- * toYdoc. So the SAME block carries materialized defaults on the live side and
- * nothing on the git side, its key diverges, the three-way merge anchors on
- * NOTHING, and the whole body is RE-APPENDED every reconcile cycle — an unbounded
- * duplication loop with no client connected.
- *
- * Deriving the defaults from the actual schema normalizes ALL such attributes
- * generally (it is not another per-attribute denylist): any attribute whose value
- * equals the schema default — or is null/undefined — is dropped from the key, on
- * BOTH element attributes and the mark attributes inside each XmlText delta, so a
- * live block compares equal to its git-round-tripped twin and an unchanged resync
- * applies zero ops. Genuinely non-default values (a real `indent: 2`, an
- * `align: "left"`, a real `link.href`, a real highlight color) are content and
- * stay in the key, so real edits still diff and land.
- */
-let memoSchema: Schema | null = null;
-let memoSchemaTried = false;
-function getMergeSchema(): Schema | null {
-  if (!memoSchemaTried) {
-    memoSchemaTried = true;
-    try {
-      memoSchema = getSchema(tiptapExtensions as any);
-    } catch {
-      // Defensive: if the schema can't be built (e.g. a degenerate extension
-      // set in a unit test that stubs `tiptapExtensions`), fall back to dropping
-      // only null/undefined attrs. The real server always builds it fine.
-      memoSchema = null;
-    }
-  }
-  return memoSchema;
-}
-
-/** True if `value` is the schema default for `attrName` of `attrSpecs`, or is
- * null/undefined (which a git round-trip drops). Such attributes are excluded
- * from the comparison key. `attrSpecs` is a ProseMirror node/mark spec attr map
- * (`{ [name]: { default } }`); a missing map (unknown node/mark) only drops
- * null/undefined. (A non-null value matching an attr declared without a default
- * cannot occur — `spec.default === value` is then `undefined === value`, false.) */
-function isDefaultAttr(
-  attrSpecs: Record<string, any> | undefined | null,
-  attrName: string,
-  value: unknown,
-): boolean {
-  if (value === null || value === undefined) return true;
-  const spec = attrSpecs?.[attrName];
-  return !!spec && spec.default === value;
-}
-
-/**
- * Normalize one XmlText delta op's mark attributes: drop every mark-attr whose
- * value equals the mark's schema default (or is null/undefined), so the link
- * mark's materialized `internal: false`/`target: "_blank"` and a highlight's
- * `colorName: null` no longer diverge from a git round-trip that carries neither.
- * The text (op.insert) and genuinely-set mark attrs (a real `href`, a real
- * highlight color) are preserved verbatim. `attributes` maps markName -> mark
- * attrs object (or `true`/boolean for attr-less marks); each is handled safely.
- */
-function normalizeDelta(delta: any[]): any[] {
-  const schema = getMergeSchema();
-  return delta.map((op) => {
-    if (!op || op.attributes == null || typeof op.attributes !== 'object') {
-      return op;
-    }
-    const marks: Record<string, unknown> = {};
-    for (const markName of Object.keys(op.attributes).sort()) {
-      const markVal = op.attributes[markName];
-      if (markVal === null || markVal === undefined) continue;
-      if (typeof markVal !== 'object') {
-        // attr-less mark stored as a primitive (e.g. `true`) — keep as-is.
-        marks[markName] = markVal;
-        continue;
-      }
-      const markSpec = schema?.marks[markName]?.spec.attrs as
-        | Record<string, any>
-        | undefined;
-      const cleaned: Record<string, unknown> = {};
-      for (const ak of Object.keys(markVal as object).sort()) {
-        const av = (markVal as Record<string, unknown>)[ak];
-        if (isDefaultAttr(markSpec, ak, av)) continue;
-        cleaned[ak] = av;
-      }
-      marks[markName] = cleaned;
-    }
-    return { ...op, attributes: marks };
-  });
-}
-
-/**
- * Canonical, comparable serialization of a Yjs XML node (structure + text +
- * marks + attributes), with attribute keys sorted so equal blocks always produce
- * an identical string regardless of attribute insertion order. The volatile
- * block `id` (see `VOLATILE_KEY_ATTRS`) and every schema-default attribute (see
- * `getMergeSchema`) are excluded at every level — on element attributes AND on
- * the mark attributes inside each XmlText delta — so a block compares equal by
- * CONTENT across the git round-trip (which materializes neither), keeping the
- * merge anchor-able and idempotent.
- */
-export function serializeXmlNode(node: unknown): unknown {
-  if (node instanceof Y.XmlText) {
-    return { t: normalizeDelta(node.toDelta()) };
-  }
-  if (node instanceof Y.XmlElement) {
-    const attrs = node.getAttributes() as Record<string, unknown>;
-    const attrSpecs = getMergeSchema()?.nodes[node.nodeName]?.spec.attrs as
-      | Record<string, any>
-      | undefined;
-    const sorted: Record<string, unknown> = {};
-    for (const k of Object.keys(attrs).sort()) {
-      if (VOLATILE_KEY_ATTRS.has(k)) continue;
-      if (isDefaultAttr(attrSpecs, k, attrs[k])) continue;
-      sorted[k] = attrs[k];
-    }
-    return {
-      n: node.nodeName,
-      a: sorted,
-      c: node.toArray().map(serializeXmlNode),
-    };
-  }
-  // XmlHook / unknown: fall back to a stable string so it compares by identity
-  // of its serialized form (these do not occur in the Docmost block schema).
-  return { u: String(node) };
-}
-
-const key = (node: unknown): string => JSON.stringify(serializeXmlNode(node));
-
-/**
- * Deep-clone a detached/owned Yjs XML node into a fresh node that can be inserted
- * into ANOTHER document (Yjs types are bound to their doc, so cross-doc moves are
- * impossible — we rebuild). Preserves nodeName, attributes, text+marks (via the
- * XmlText delta) and the full child subtree.
- */
-export function cloneXmlNode(node: XmlNode): Y.XmlElement | Y.XmlText {
-  if (node instanceof Y.XmlText) {
-    const t = new Y.XmlText();
-    const delta = node.toDelta();
-    if (delta.length) t.applyDelta(delta);
-    return t;
-  }
-  if (node instanceof Y.XmlElement) {
-    const el = new Y.XmlElement(node.nodeName);
-    const attrs = node.getAttributes() as Record<string, unknown>;
-    for (const k of Object.keys(attrs)) el.setAttribute(k, attrs[k] as string);
-    const kids = node.toArray().map((c) => cloneXmlNode(c as XmlNode));
-    if (kids.length) el.insert(0, kids);
-    return el;
-  }
-  // Best-effort for any other node type (XmlHook — does not occur in the
-  // Docmost block schema): an empty paragraph so the merge never crashes.
-  return new Y.XmlElement('paragraph');
-}
-
-type Op = { op: 'keep' } | { op: 'del' } | { op: 'ins'; bi: number };
-
-/**
- * LCS-based edit script turning sequence `a` (live block keys) into `b` (incoming
- * block keys): a run of keep/del/ins ops. O(n*m) table — fine for page block
- * counts.
- */
-export function diffBlocks(a: string[], b: string[]): Op[] {
-  const n = a.length;
-  const m = b.length;
-  const dp = buildLcsTable(a, b);
-  const ops: Op[] = [];
-  let i = 0;
-  let j = 0;
-  while (i < n && j < m) {
-    if (a[i] === b[j]) {
-      ops.push({ op: 'keep' });
-      i++;
-      j++;
-    } else if (dp[i + 1][j] >= dp[i][j + 1]) {
-      ops.push({ op: 'del' });
-      i++;
-    } else {
-      ops.push({ op: 'ins', bi: j });
-      j++;
-    }
-  }
-  while (i < n) {
-    ops.push({ op: 'del' });
-    i++;
-  }
-  while (j < m) {
-    ops.push({ op: 'ins', bi: j });
-    j++;
-  }
-  return ops;
-}
-
-/**
- * Merge `target` block children into `live`, mutating `live` in place with the
- * minimal set of inserts/deletes. MUST be called inside a Yjs transaction.
- * Returns the number of block operations applied (0 == content already identical).
- */
-export function mergeXmlFragments(
-  live: Y.XmlFragment,
-  target: Y.XmlFragment,
-): number {
-  const liveKids = live.toArray();
-  const targetKids = target.toArray();
-  const liveKeys = liveKids.map(key);
-  const targetKeys = targetKids.map(key);
-
-  const ops = diffBlocks(liveKeys, targetKeys);
-
-  let cursor = 0; // index into the LIVE fragment as we mutate it
-  let applied = 0;
-  for (const op of ops) {
-    if (op.op === 'keep') {
-      cursor++;
-    } else if (op.op === 'del') {
-      live.delete(cursor, 1); // remove the live block at the cursor; do not advance
-      applied++;
-    } else {
-      live.insert(cursor, [cloneXmlNode(targetKids[op.bi] as XmlNode)]);
-      cursor++;
-      applied++;
-    }
-  }
-  return applied;
-}
-
-/** Outcome of a 3-way block merge: ops applied + same-block conflict count. */
-export interface Merge3WayResult {
-  /** Number of block insert/delete operations spliced into `live`. */
-  applied: number;
-  /**
-   * Regions where the human AND git rewrote the SAME base block. The rule is
-   * deterministic (GIT WINS the region), so the human's version of those blocks
-   * is dropped from the live doc. `conflicts > 0` is the OBSERVABLE signal the
-   * caller uses to LOG the loss and pin the human baseline to page history (so it
-   * is recoverable), instead of the edit vanishing silently.
-   */
-  conflicts: number;
-}
-
-/**
- * THREE-WAY block merge: reconcile `live` toward `target` using `base` (the
- * last-synced common ancestor) so a block only the human changed is KEPT and a
- * block only git changed is taken — instead of git's version always winning
- * (review #5). Conflicts (both changed the same block) resolve to git.
- *
- * Implementation: diff3Plan computes the merged block ORDER (picks from live or
- * target); we materialize that as a virtual target fragment and reuse the 2-way
- * `mergeXmlFragments` to splice it into `live` minimally (so untouched live block
- * instances — and their in-flight edits — stay put). MUST be called inside a Yjs
- * transaction. Returns the number of block operations applied. (Use
- * `mergeXmlFragments3WayWithStats` when the SAME-BLOCK conflict count is needed.)
- */
-export function mergeXmlFragments3Way(
-  live: Y.XmlFragment,
-  target: Y.XmlFragment,
-  base: Y.XmlFragment,
-): number {
-  return mergeXmlFragments3WayWithStats(live, target, base).applied;
-}
-
-/**
- * As `mergeXmlFragments3Way`, but also returns the SAME-BLOCK conflict count so
- * the caller can make a "git won a concurrent same-block edit" event OBSERVABLE
- * (the documented conflict contract: git wins deterministically, but the losing
- * human content is never destroyed silently — it is logged and recoverable via
- * page history).
- */
-export function mergeXmlFragments3WayWithStats(
-  live: Y.XmlFragment,
-  target: Y.XmlFragment,
-  base: Y.XmlFragment,
-): Merge3WayResult {
-  const liveKids = live.toArray();
-  const targetKids = target.toArray();
-  const liveKeys = liveKids.map(key);
-  const targetKeys = targetKids.map(key);
-  const baseKeys = base.toArray().map(key);
-
-  const { picks: plan, conflicts } = diff3PlanWithConflicts(
-    baseKeys,
-    liveKeys,
-    targetKeys,
-  );
-
-  // Build the merged block sequence in a throwaway doc, cloning from whichever
-  // side each pick came from, then 2-way merge it back into the live fragment.
-  const merged = new Y.Doc();
-  const mergedFrag = merged.getXmlFragment('default');
-  const nodes = plan.map((p) =>
-    cloneXmlNode(
-      (p.src === 'live' ? liveKids[p.index] : targetKids[p.index]) as XmlNode,
-    ),
-  );
-  if (nodes.length) mergedFrag.insert(0, nodes);
-
-  return { applied: mergeXmlFragments(live, mergedFrag), conflicts };
-}

apps/server/src/collaboration/schema-attribute-contract.spec.ts

@@ -1,144 +0,0 @@
-import { getSchema } from '@tiptap/core';
-import { Schema } from '@tiptap/pm/model';
-import { tiptapExtensions } from './collaboration.util';
-// The canonical converter mirror's extension set. The schema mirror now lives in
-// the single `@docmost/prosemirror-markdown` package (#293); the server jest
-// config maps it to the package SOURCE (moduleNameMapper
-// `^@docmost/prosemirror-markdown$`), so this reads the real mirror, not a build.
-import { docmostExtensions as gitSyncExtensions } from '@docmost/prosemirror-markdown';
-
-/**
- * ATTRIBUTE-LEVEL SCHEMA CONTRACT (review #293, variant A).
- *
- * The document schema exists as three hand-synced copies (editor-ext =
- * source-of-truth, plus the git-sync and mcp converter mirrors). The existing
- * `schema-editor-ext-contract.test.ts` compares only node/mark TYPE NAMES, so a
- * NEW ATTRIBUTE added to an existing node upstream slips through and its value is
- * silently dropped on every git-sync round trip. That is a repeatedly-hit
- * data-loss class (image caption #221, paragraph alignment #10, details `open`).
- *
- * This test closes the attribute gap MECHANICALLY: it builds the real canonical
- * schema from the server's `tiptapExtensions` (the same set the collab write path
- * uses) and the git-sync mirror schema, then asserts that for every node/mark the
- * two schemas share, their ATTRIBUTE-KEY sets are equal — minus a committed
- * allowlist of intentional, understood divergences. A forgotten attribute now
- * fails CI loudly instead of losing data in production.
- *
- * WHY THIS ISN'T THE "fragile attribute compare" the sibling name-level contract
- * (`packages/git-sync/test/schema-editor-ext-contract.test.ts`) deferred: that
- * concern was about comparing raw extension CONFIGS, where editor-ext spreads
- * global attributes (textAlign, id, …) across separate extensions and StarterKit
- * contributes types the mirror gets elsewhere. We instead compare the RESOLVED
- * ProseMirror `Schema` objects — `getSchema()` has already merged every
- * addGlobalAttributes spread into concrete per-node attrs on both sides — so the
- * compare is apples-to-apples (57 shared nodes/marks, only a handful of
- * documented divergences) rather than config-shape noise.
- */
-
-/**
- * Intentional, understood attribute divergences between the canonical schema and
- * the git-sync mirror. Each entry MUST carry a reason. The test asserts the
- * allowlist is not stale (every listed attr is actually still divergent), so this
- * cannot rot into a silent escape hatch.
- *
- * Shape: { [nodeOrMarkName]: { canonicalOnly?: string[]; mirrorOnly?: string[] } }
- */
-const ALLOWED_DIVERGENCES: Record<
-  string,
-  { canonicalOnly?: string[]; mirrorOnly?: string[] }
-> = {
-  // mirrorOnly: the converter mirror carries `align` on table cells/headers so a
-  // GFM column-alignment marker (:--, :-:, --:) can be reconstructed on export;
-  // editor-ext expresses cell alignment differently. Intentional, round-trip-used.
-  tableCell: { mirrorOnly: ['align'] },
-  tableHeader: { mirrorOnly: ['align'] },
-  // youtube: the mirror adds `align` (media alignment it renders as data-align)
-  // and does NOT carry editor-ext's `start` (video start-time). `start` is a
-  // PRE-EXISTING gap (a youtube embed's start offset is not preserved across a
-  // markdown round trip) — documented here so the contract is green for the known
-  // state and RED for any NEW drift. Follow-up: carry `start` through the mirror.
-  youtube: { mirrorOnly: ['align'], canonicalOnly: ['start'] },
-  // image.title: the mirror carries a `title` attr (used to round-trip the
-  // markdown image title `![alt](src "title")`) that editor-ext does not declare
-  // on its image node. Mirror-only and round-trip-used, not data loss. Intentional.
-  image: { mirrorOnly: ['title'] },
-  // highlight.colorName (a named-color alias alongside the color value) is a
-  // PRE-EXISTING mirror gap; the color value itself round-trips. Documented.
-  highlight: { canonicalOnly: ['colorName'] },
-};
-
-function attrKeys(schema: Schema): Map<string, Set<string>> {
-  const out = new Map<string, Set<string>>();
-  for (const [name, type] of Object.entries(schema.nodes)) {
-    out.set(name, new Set(Object.keys((type.spec as any).attrs ?? {})));
-  }
-  for (const [name, type] of Object.entries(schema.marks)) {
-    out.set(name, new Set(Object.keys((type.spec as any).attrs ?? {})));
-  }
-  return out;
-}
-
-function diff(a: Set<string>, b: Set<string>): string[] {
-  return [...a].filter((x) => !b.has(x)).sort();
-}
-
-describe('schema attribute contract: git-sync mirror vs canonical editor-ext', () => {
-  const canonical = attrKeys(getSchema(tiptapExtensions as never));
-  const mirror = attrKeys(getSchema(gitSyncExtensions as never));
-
-  it('builds meaningful schemas (guard against a vacuous pass)', () => {
-    expect(canonical.size).toBeGreaterThan(10);
-    expect(mirror.size).toBeGreaterThan(10);
-  });
-
-  it('every shared node/mark has matching attribute keys (modulo the allowlist)', () => {
-    const drift: string[] = [];
-    for (const [name, canonAttrs] of canonical) {
-      const mirrorAttrs = mirror.get(name);
-      if (!mirrorAttrs) continue; // name-level gaps are the other test's job
-      const allow = ALLOWED_DIVERGENCES[name] ?? {};
-      const canonicalOnly = diff(canonAttrs, mirrorAttrs).filter(
-        (k) => !(allow.canonicalOnly ?? []).includes(k),
-      );
-      const mirrorOnly = diff(mirrorAttrs, canonAttrs).filter(
-        (k) => !(allow.mirrorOnly ?? []).includes(k),
-      );
-      if (canonicalOnly.length) {
-        drift.push(
-          `${name}: attrs in editor-ext but MISSING from git-sync mirror ` +
-            `(silently dropped on round trip): ${canonicalOnly.join(', ')}`,
-        );
-      }
-      if (mirrorOnly.length) {
-        drift.push(
-          `${name}: attrs in git-sync mirror but NOT in editor-ext ` +
-            `(mirror invented an attribute): ${mirrorOnly.join(', ')}`,
-        );
-      }
-    }
-    expect(drift).toEqual([]);
-  });
-
-  it('the allowlist is not stale (every listed divergence is still real)', () => {
-    const stale: string[] = [];
-    for (const [name, allow] of Object.entries(ALLOWED_DIVERGENCES)) {
-      const canonAttrs = canonical.get(name);
-      const mirrorAttrs = mirror.get(name);
-      if (!canonAttrs || !mirrorAttrs) {
-        stale.push(`${name}: no longer a shared node/mark`);
-        continue;
-      }
-      for (const k of allow.canonicalOnly ?? []) {
-        if (!(canonAttrs.has(k) && !mirrorAttrs.has(k))) {
-          stale.push(`${name}.canonicalOnly '${k}' is no longer divergent`);
-        }
-      }
-      for (const k of allow.mirrorOnly ?? []) {
-        if (!(mirrorAttrs.has(k) && !canonAttrs.has(k))) {
-          stale.push(`${name}.mirrorOnly '${k}' is no longer divergent`);
-        }
-      }
-    }
-    expect(stale).toEqual([]);
-  });
-});

apps/server/src/common/decorators/auth-provenance.decorator.spec.ts

@@ -73,32 +73,6 @@ describe('agentSourceFields', () => {
     ).toEqual({ lastUpdatedSource: 'agent', lastUpdatedAiChatId: null });
   });
 
-  it("stamps ONLY the source column 'git-sync' (no chat key) for a git-sync write", () => {
-    // The git-sync data plane (issue #194 §8.1) has no internal ai_chats row, so
-    // it stamps the *Source column 'git-sync' and OMITS the chat key entirely
-    // (unlike the agent branch, which also writes aiChatId). Pinned directly here
-    // because the page.service.spec only exercises it indirectly.
-    expect(
-      agentSourceFields(
-        { actor: 'git-sync', aiChatId: null },
-        'lastUpdatedSource',
-        'lastUpdatedAiChatId',
-      ),
-    ).toEqual({ lastUpdatedSource: 'git-sync' });
-  });
-
-  it("ignores any aiChatId on a git-sync write (chat key never written)", () => {
-    // Even if a non-null aiChatId is present, the git-sync branch must not emit
-    // the chat key.
-    expect(
-      agentSourceFields(
-        { actor: 'git-sync', aiChatId: 'should-be-ignored' },
-        'createdSource',
-        'aiChatId',
-      ),
-    ).toEqual({ createdSource: 'git-sync' });
-  });
-
   it('returns {} for a user write so the column keeps its default', () => {
     expect(
       agentSourceFields(

apps/server/src/common/decorators/auth-provenance.decorator.ts

@@ -9,8 +9,6 @@ import { ProvenanceSource } from '../../core/auth/dto/jwt-payload';
  * cannot fake an 'agent' marker.
  */
 export interface AuthProvenanceData {
-  // ProvenanceSource includes 'git-sync' — set by the in-process git-sync data
-  // plane (issue #194 §8.1) when it drives PageService writes; never from a request token.
   actor: ProvenanceSource;
   aiChatId: string | null;
 }
@@ -62,14 +60,6 @@ export function agentSourceFields<S extends string, C extends string>(
   sourceKey: S,
   chatKey: C,
 ): Partial<Record<S, ProvenanceSource> & Record<C, string | null>> {
-  // git-sync data-plane write (issue #194 §8.1): stamp the source 'git-sync' with NO
-  // aiChatId (it has no internal ai_chats row). Mirrors the agent branch; each
-  // write has a single actor, so precedence is irrelevant here.
-  if (provenance?.actor === 'git-sync') {
-    return { [sourceKey]: 'git-sync' } as Partial<
-      Record<S, ProvenanceSource> & Record<C, string | null>
-    >;
-  }
   if (provenance?.actor !== 'agent') return {};
   return {
     [sourceKey]: 'agent',

apps/server/src/common/helpers/esm-import.ts

@@ -1,18 +0,0 @@
-/**
- * Dynamic ESM import bridge for a CommonJS build.
- *
- * The server compiles with `module: commonjs`, and TypeScript downlevels a
- * literal `import()` expression to `require()` — which cannot load an ESM-only
- * package (`@docmost/mcp`, `@docmost/git-sync`). Indirecting through `new
- * Function` hides the `import()` from the TS downleveler so the REAL dynamic
- * `import()` survives to runtime and can load ESM from CommonJS.
- *
- * This is the single shared copy of that bridge. The per-package typed loaders
- * (git-sync.loader.ts, docmost-client.loader.ts, mcp.service.ts) import this and
- * keep their own typed `loadX()` wrappers (require.resolve + pathToFileURL +
- * memoization) on top.
- */
-export const esmImport = new Function(
-  'specifier',
-  'return import(specifier)',
-) as (specifier: string) => Promise<unknown>;

apps/server/src/common/helpers/resolve-request-workspace.spec.ts

@@ -1,71 +0,0 @@
-import { resolveRequestWorkspace } from './resolve-request-workspace';
-
-// Unit tests for the shared self-hosted/cloud workspace resolver deduplicated out
-// of DomainMiddleware + GitHttpService (architecture #11). They must behave
-// identically, so this pins the single source of truth.
-
-type AnyMock = jest.Mock;
-
-function build(opts: {
-  selfHosted: boolean;
-  first?: { id: string } | null;
-  byHostname?: { id: string } | null;
-}) {
-  const env = {
-    isSelfHosted: jest.fn(() => opts.selfHosted),
-    isCloud: jest.fn(() => !opts.selfHosted),
-  };
-  const repo = {
-    findFirst: jest.fn(async () => opts.first ?? null) as AnyMock,
-    findByHostname: jest.fn(async () => opts.byHostname ?? null) as AnyMock,
-  };
-  return { env, repo };
-}
-
-describe('resolveRequestWorkspace', () => {
-  it('self-hosted: returns the first/default workspace, ignoring the host', async () => {
-    const { env, repo } = build({ selfHosted: true, first: { id: 'ws-1' } });
-    const ws = await resolveRequestWorkspace(
-      env as any,
-      repo as any,
-      'anything.example.com',
-    );
-    expect(ws).toEqual({ id: 'ws-1' });
-    expect(repo.findFirst).toHaveBeenCalledTimes(1);
-    expect(repo.findByHostname).not.toHaveBeenCalled();
-  });
-
-  it('self-hosted: returns null when no workspace is configured', async () => {
-    const { env, repo } = build({ selfHosted: true, first: null });
-    expect(await resolveRequestWorkspace(env as any, repo as any, 'h')).toBeNull();
-  });
-
-  it('cloud: resolves by the host-header subdomain', async () => {
-    const { env, repo } = build({
-      selfHosted: false,
-      byHostname: { id: 'ws-acme' },
-    });
-    const ws = await resolveRequestWorkspace(
-      env as any,
-      repo as any,
-      'acme.example.com',
-    );
-    expect(ws).toEqual({ id: 'ws-acme' });
-    expect(repo.findByHostname).toHaveBeenCalledWith('acme');
-    expect(repo.findFirst).not.toHaveBeenCalled();
-  });
-
-  it('cloud: returns null for a blank/missing host (no throw)', async () => {
-    const { env, repo } = build({ selfHosted: false, byHostname: { id: 'x' } });
-    expect(await resolveRequestWorkspace(env as any, repo as any, undefined)).toBeNull();
-    expect(await resolveRequestWorkspace(env as any, repo as any, '')).toBeNull();
-    expect(repo.findByHostname).not.toHaveBeenCalled();
-  });
-
-  it('cloud: returns null when the subdomain matches no workspace', async () => {
-    const { env, repo } = build({ selfHosted: false, byHostname: null });
-    expect(
-      await resolveRequestWorkspace(env as any, repo as any, 'ghost.example.com'),
-    ).toBeNull();
-  });
-});

apps/server/src/common/helpers/resolve-request-workspace.ts

@@ -1,35 +0,0 @@
-import { WorkspaceRepo } from '@docmost/db/repos/workspace/workspace.repo';
-import { Workspace } from '@docmost/db/types/entity.types';
-import { EnvironmentService } from '../../integrations/environment/environment.service';
-
-/**
- * The ONE canonical way to resolve the workspace for an incoming request:
- *   - self-hosted (single workspace) -> the first/default workspace;
- *   - cloud (multi-tenant)           -> resolved by the host-header subdomain.
- * Returns null when none resolves (no workspace configured, or a blank/unknown
- * subdomain on cloud). `isSelfHosted()` is `!isCloud()`, so exactly one branch is
- * always taken.
- *
- * Extracted so the self-hosted/cloud branch is not hand-duplicated. Shared by
- * `DomainMiddleware` (the normal /api request path) and `GitHttpService` (the raw
- * root-mounted /git smart-HTTP host, which Nest middleware does NOT run for) so
- * the two cannot drift.
- *
- * This helper does NOT catch DB errors — callers decide: DomainMiddleware lets a
- * throw bubble (as before); GitHttpService wraps it to log + treat as
- * unresolvable (-> 404). A blank/missing host on cloud resolves to null rather
- * than throwing.
- */
-export async function resolveRequestWorkspace(
-  environmentService: EnvironmentService,
-  workspaceRepo: WorkspaceRepo,
-  hostHeader: string | undefined,
-): Promise<Workspace | null> {
-  if (environmentService.isSelfHosted()) {
-    return (await workspaceRepo.findFirst()) ?? null;
-  }
-  // Cloud (isSelfHosted === !isCloud, so this is the only remaining branch).
-  const subdomain = hostHeader ? hostHeader.split('.')[0] : '';
-  if (!subdomain) return null;
-  return (await workspaceRepo.findByHostname(subdomain)) ?? null;
-}

apps/server/src/common/middlewares/domain.middleware.ts

@@ -1,8 +1,7 @@
-import { Injectable, NestMiddleware } from '@nestjs/common';
+import { Injectable, NestMiddleware, NotFoundException } from '@nestjs/common';
 import { FastifyRequest, FastifyReply } from 'fastify';
 import { EnvironmentService } from '../../integrations/environment/environment.service';
 import { WorkspaceRepo } from '@docmost/db/repos/workspace/workspace.repo';
-import { resolveRequestWorkspace } from '../helpers/resolve-request-workspace';
 
 @Injectable()
 export class DomainMiddleware implements NestMiddleware {
@@ -15,19 +14,30 @@ export class DomainMiddleware implements NestMiddleware {
     res: FastifyReply['raw'],
     next: () => void,
   ) {
-    // Shared self-hosted/cloud resolution (the SAME branch the /git host uses),
-    // so the logic cannot drift between the two.
-    const workspace = await resolveRequestWorkspace(
-      this.environmentService,
-      this.workspaceRepo,
-      req.headers.host,
-    );
+    if (this.environmentService.isSelfHosted()) {
+      const workspace = await this.workspaceRepo.findFirst();
+      if (!workspace) {
+        //throw new NotFoundException('Workspace not found');
+        (req as any).workspaceId = null;
+        return next();
+      }
+
+      // TODO: unify
+      (req as any).workspaceId = workspace.id;
+      (req as any).workspace = workspace;
+    } else if (this.environmentService.isCloud()) {
+      const header = req.headers.host;
+      const subdomain = header.split('.')[0];
+
+      const workspace = await this.workspaceRepo.findByHostname(subdomain);
+
+      if (!workspace) {
+        (req as any).workspaceId = null;
+        return next();
+      }
 
-    if (workspace) {
       (req as any).workspaceId = workspace.id;
       (req as any).workspace = workspace;
-    } else {
-      (req as any).workspaceId = null;
     }
 
     next();

apps/server/src/core/ai-chat/ai-chat-run.service.spec.ts

@@ -0,0 +1,527 @@
+import { Logger } from '@nestjs/common';
+import {
+  AiChatRunService,
+  RunAlreadyActiveError,
+  ONE_ACTIVE_RUN_PER_CHAT_INDEX,
+  mapTurnStatusToRun,
+} from './ai-chat-run.service';
+
+/** Shape a Postgres unique-violation the way the postgres.js driver surfaces it:
+ *  SQLSTATE 23505 + the offending index in `constraint_name`. */
+function uniqueViolation(constraintName: string): Error & {
+  code: string;
+  constraint_name: string;
+} {
+  return Object.assign(
+    new Error('duplicate key value violates unique constraint'),
+    {
+      code: '23505',
+      constraint_name: constraintName,
+    },
+  );
+}
+
+/**
+ * Unit coverage for the #184 phase-1 run lifecycle (AiChatRunService) with a
+ * hand-rolled mock repo — no Nest graph, no DB. The invariant under test is the
+ * one that makes a run "autonomous": a run keeps going when its SUBSCRIBER (the
+ * browser) detaches, and ONLY an explicit stop aborts it. We assert that at the
+ * abort-signal level (the signal the agent loop actually consumes).
+ */
+
+/** Minimal EnvironmentService stub. Single-instance (CLOUD unset) by default. */
+function makeEnv(isCloud = false) {
+  return { isCloud: () => isCloud };
+}
+
+function makeRepo(overrides: Record<string, jest.Mock> = {}) {
+  return {
+    insert: jest.fn(async (v: any) => ({
+      id: 'run-1',
+      status: v.status ?? 'running',
+      chatId: v.chatId,
+      workspaceId: v.workspaceId,
+    })),
+    update: jest.fn(async () => ({ id: 'run-1' })),
+    markStopRequested: jest.fn(async () => ({ id: 'run-1' })),
+    findActiveByChat: jest.fn(async () => undefined),
+    findLatestByChat: jest.fn(async () => undefined),
+    findById: jest.fn(async () => undefined),
+    sweepRunning: jest.fn(async () => 0),
+    ...overrides,
+  };
+}
+
+describe('mapTurnStatusToRun', () => {
+  it('maps the turn terminal status to the run terminal status', () => {
+    expect(mapTurnStatusToRun('completed')).toBe('succeeded');
+    expect(mapTurnStatusToRun('error')).toBe('failed');
+    expect(mapTurnStatusToRun('aborted')).toBe('aborted');
+  });
+});
+
+describe('AiChatRunService.onModuleInit (startup sweep)', () => {
+  afterEach(() => jest.restoreAllMocks());
+
+  it('calls sweepRunning and resolves; logs when > 0', async () => {
+    const repo = makeRepo({ sweepRunning: jest.fn(async () => 2) });
+    const logSpy = jest
+      .spyOn(Logger.prototype, 'log')
+      .mockImplementation(() => undefined);
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await expect(svc.onModuleInit()).resolves.toBeUndefined();
+    expect(repo.sweepRunning).toHaveBeenCalledTimes(1);
+    expect(logSpy).toHaveBeenCalledTimes(1);
+    expect(String(logSpy.mock.calls[0][0])).toContain('2');
+  });
+
+  it('a sweep failure is swallowed (never blocks startup)', async () => {
+    const repo = makeRepo({
+      sweepRunning: jest.fn(async () => {
+        throw new Error('db down');
+      }),
+    });
+    const warnSpy = jest
+      .spyOn(Logger.prototype, 'warn')
+      .mockImplementation(() => undefined);
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await expect(svc.onModuleInit()).resolves.toBeUndefined();
+    // The first warn is the sweep failure (the multi-instance warn never fires
+    // single-instance), so the message is the db error.
+    expect(String(warnSpy.mock.calls[0][0])).toContain('db down');
+  });
+
+  it('F1 (DECISION C): the boot sweep is UNCONDITIONAL — sweepRunning is called with NO staleness window, so a fresh running run (updatedAt = now) is settled, not skipped', async () => {
+    // The bug: a fast restart (deploy/OOM within minutes of the last step) left a
+    // run stuck 'running' under the old 10-min window, 409ing every later turn in
+    // the chat. The fix settles ALL pending|running on boot. We assert the service
+    // invokes sweepRunning with no `staleMs` (the unconditional path); the repo's
+    // own spec proves no-window => no updatedAt filter.
+    const repo = makeRepo({ sweepRunning: jest.fn(async () => 1) });
+    jest.spyOn(Logger.prototype, 'log').mockImplementation(() => undefined);
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await svc.onModuleInit();
+    expect(repo.sweepRunning).toHaveBeenCalledTimes(1);
+    const callArgs = repo.sweepRunning.mock.calls[0] as unknown[];
+    const firstArg = callArgs[0] as { staleMs?: number } | undefined;
+    // Either no opts at all, or opts without a staleMs window => unconditional.
+    expect(firstArg?.staleMs).toBeUndefined();
+  });
+
+  it('F2 (DECISION A): warns at startup that autonomousRuns is single-instance-only when a horizontally-scaled deployment (CLOUD) is detected', async () => {
+    const repo = makeRepo();
+    const warnSpy = jest
+      .spyOn(Logger.prototype, 'warn')
+      .mockImplementation(() => undefined);
+    const svc = new AiChatRunService(repo as never, makeEnv(true) as never);
+    await svc.onModuleInit();
+    const warned = warnSpy.mock.calls.some((c) =>
+      /single-instance-only/i.test(String(c[0])),
+    );
+    expect(warned).toBe(true);
+  });
+
+  it('F2: does NOT warn about multi-instance on a single-instance (CLOUD unset) deployment', async () => {
+    const repo = makeRepo();
+    const warnSpy = jest
+      .spyOn(Logger.prototype, 'warn')
+      .mockImplementation(() => undefined);
+    const svc = new AiChatRunService(repo as never, makeEnv(false) as never);
+    await svc.onModuleInit();
+    const warned = warnSpy.mock.calls.some((c) =>
+      /single-instance-only/i.test(String(c[0])),
+    );
+    expect(warned).toBe(false);
+  });
+});
+
+describe('AiChatRunService run lifecycle', () => {
+  it('beginRun inserts a running row and registers a live abort controller', async () => {
+    const repo = makeRepo();
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    const handle = await svc.beginRun({
+      chatId: 'chat-1',
+      workspaceId: 'ws-1',
+      userId: 'user-1',
+    });
+    expect(repo.insert).toHaveBeenCalledWith(
+      expect.objectContaining({
+        chatId: 'chat-1',
+        workspaceId: 'ws-1',
+        createdBy: 'user-1',
+        status: 'running',
+        trigger: 'user',
+      }),
+    );
+    expect(handle.runId).toBe('run-1');
+    expect(handle.signal.aborted).toBe(false);
+    expect(svc.isLocallyActive('run-1')).toBe(true);
+  });
+
+  it('beginRun REJECTS the racer: a 23505 on the one-active-per-chat index throws RunAlreadyActiveError (not swallowed) and registers no controller', async () => {
+    // The race: the controller's cheap pre-check passed for BOTH concurrent
+    // turns, so the loser's INSERT hits the partial unique index. That rejection
+    // is the authoritative gate — it must surface, not be swallowed into an
+    // untracked turn.
+    const repo = makeRepo({
+      insert: jest.fn(async () => {
+        throw uniqueViolation(ONE_ACTIVE_RUN_PER_CHAT_INDEX);
+      }),
+    });
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await expect(
+      svc.beginRun({ chatId: 'chat-1', workspaceId: 'ws-1', userId: 'user-1' }),
+    ).rejects.toBeInstanceOf(RunAlreadyActiveError);
+    // No controller leaked for a rejected start.
+    expect(svc.isLocallyActive('run-1')).toBe(false);
+  });
+
+  it('beginRun does NOT mask an unrelated unique violation as already-active', async () => {
+    // A 23505 on some OTHER constraint is a real bug, not the race — it must
+    // propagate unchanged so it is never silently treated as "already active".
+    const other = uniqueViolation('ai_chat_runs_pkey');
+    const repo = makeRepo({
+      insert: jest.fn(async () => {
+        throw other;
+      }),
+    });
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await expect(
+      svc.beginRun({ chatId: 'chat-1', workspaceId: 'ws-1', userId: 'user-1' }),
+    ).rejects.toBe(other);
+  });
+
+  it('beginRun propagates a non-unique insert failure unchanged', async () => {
+    const boom = new Error('connection reset');
+    const repo = makeRepo({
+      insert: jest.fn(async () => {
+        throw boom;
+      }),
+    });
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await expect(
+      svc.beginRun({ chatId: 'chat-1', workspaceId: 'ws-1', userId: 'user-1' }),
+    ).rejects.toBe(boom);
+  });
+
+  it('two concurrent begins on one chat: exactly one wins, the other is rejected as already-active', async () => {
+    // Integration-style: model the DB partial unique index with a one-shot slot.
+    // The first insert claims it; the second hits a 23505 on the active index.
+    let slotTaken = false;
+    const repo = makeRepo({
+      insert: jest.fn(async (v: any) => {
+        if (slotTaken) throw uniqueViolation(ONE_ACTIVE_RUN_PER_CHAT_INDEX);
+        slotTaken = true;
+        return { id: 'run-win', status: v.status, chatId: v.chatId };
+      }),
+    });
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    const results = await Promise.allSettled([
+      svc.beginRun({ chatId: 'chat-1', workspaceId: 'ws-1', userId: 'user-1' }),
+      svc.beginRun({ chatId: 'chat-1', workspaceId: 'ws-1', userId: 'user-1' }),
+    ]);
+    const fulfilled = results.filter((r) => r.status === 'fulfilled');
+    const rejected = results.filter((r) => r.status === 'rejected');
+    expect(fulfilled).toHaveLength(1);
+    expect(rejected).toHaveLength(1);
+    expect((rejected[0] as PromiseRejectedResult).reason).toBeInstanceOf(
+      RunAlreadyActiveError,
+    );
+    // Exactly the winner is locally active.
+    expect(svc.isLocallyActive('run-win')).toBe(true);
+  });
+
+  it('a SUBSCRIBER detaching does NOT abort the run (only an explicit stop does)', async () => {
+    const repo = makeRepo();
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    const handle = await svc.beginRun({
+      chatId: 'chat-1',
+      workspaceId: 'ws-1',
+      userId: 'user-1',
+    });
+    // Model a browser disconnect: nothing in the run service is told to stop.
+    // The signal the agent loop consumes must stay un-aborted and the run stays
+    // locally active — i.e. it keeps running server-side.
+    expect(handle.signal.aborted).toBe(false);
+    expect(svc.isLocallyActive('run-1')).toBe(true);
+    // markStopRequested was never called by a mere detach.
+    expect(repo.markStopRequested).not.toHaveBeenCalled();
+  });
+
+  it('requestStop aborts the live controller, marks the row, and reports true', async () => {
+    const repo = makeRepo();
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    const handle = await svc.beginRun({
+      chatId: 'chat-1',
+      workspaceId: 'ws-1',
+      userId: 'user-1',
+    });
+    const aborted = jest.fn();
+    handle.signal.addEventListener('abort', aborted);
+
+    const result = await svc.requestStop('run-1', 'ws-1');
+
+    expect(result).toBe(true);
+    expect(handle.signal.aborted).toBe(true);
+    expect(aborted).toHaveBeenCalledTimes(1);
+    expect(repo.markStopRequested).toHaveBeenCalledWith('run-1', 'ws-1');
+  });
+
+  it('requestStop on a run this replica does NOT hold still marks the row (true)', async () => {
+    // e.g. after a restart, or a sibling replica owns the controller. The row is
+    // marked so the owning replica/sweep settles it; we report a stop took effect.
+    const repo = makeRepo({
+      markStopRequested: jest.fn(async () => ({ id: 'run-9' })),
+    });
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    const result = await svc.requestStop('run-9', 'ws-1');
+    expect(result).toBe(true);
+    expect(svc.isLocallyActive('run-9')).toBe(false);
+  });
+
+  it('requestStop still aborts the live controller when markStopRequested rejects (transient DB error)', async () => {
+    // F15: the in-memory abort is the ONLY thing that stops a run and must not be
+    // hostage to the audit write of stop_requested_at. A transient failure on
+    // markStopRequested must NOT prevent abort() nor make requestStop throw.
+    const warnSpy = jest
+      .spyOn(Logger.prototype, 'warn')
+      .mockImplementation(() => undefined);
+    const repo = makeRepo({
+      markStopRequested: jest.fn(async () => {
+        throw new Error('pool exhausted');
+      }),
+    });
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    const handle = await svc.beginRun({
+      chatId: 'chat-1',
+      workspaceId: 'ws-1',
+      userId: 'user-1',
+    });
+    const aborted = jest.fn();
+    handle.signal.addEventListener('abort', aborted);
+
+    // Does NOT throw despite the DB write rejecting.
+    const result = await svc.requestStop('run-1', 'ws-1');
+
+    // The live turn was aborted even though the audit write failed...
+    expect(handle.signal.aborted).toBe(true);
+    expect(aborted).toHaveBeenCalledTimes(1);
+    expect(repo.markStopRequested).toHaveBeenCalledWith('run-1', 'ws-1');
+    // ...the catch branch logged the swallowed failure...
+    expect(warnSpy).toHaveBeenCalledTimes(1);
+    // ...and a stop is reported as having taken effect (the entry existed).
+    expect(result).toBe(true);
+    warnSpy.mockRestore();
+  });
+
+  it('requestStop on an already-settled run (nothing active) reports false', async () => {
+    const repo = makeRepo({
+      markStopRequested: jest.fn(async () => undefined),
+    });
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    const result = await svc.requestStop('run-done', 'ws-1');
+    expect(result).toBe(false);
+  });
+
+  it('finalizeRun settles the row to the mapped status with finishedAt and drops the in-memory entry', async () => {
+    const repo = makeRepo();
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await svc.beginRun({
+      chatId: 'chat-1',
+      workspaceId: 'ws-1',
+      userId: 'user-1',
+    });
+    expect(svc.isLocallyActive('run-1')).toBe(true);
+
+    await svc.finalizeRun('run-1', 'ws-1', 'error', 'provider blew up');
+
+    expect(svc.isLocallyActive('run-1')).toBe(false);
+    expect(repo.update).toHaveBeenCalledWith(
+      'run-1',
+      'ws-1',
+      expect.objectContaining({
+        status: 'failed',
+        error: 'provider blew up',
+        finishedAt: expect.any(Date),
+      }),
+    );
+  });
+
+  it('finalizeRun is IDEMPOTENT: a second settle no-ops (single terminal write)', async () => {
+    // The #184 review fix: AiChatService.stream wraps the turn in a safety-net
+    // catch that settles a failed turn AND streamText's terminal callback may
+    // also settle — both routes call finalizeRun. Only the FIRST may write the
+    // terminal row; the second must no-op so a late settle can never clobber the
+    // real terminal status or double-write the row.
+    const repo = makeRepo();
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await svc.beginRun({
+      chatId: 'chat-1',
+      workspaceId: 'ws-1',
+      userId: 'user-1',
+    });
+
+    await svc.finalizeRun('run-1', 'ws-1', 'error', 'first');
+    expect(svc.isLocallyActive('run-1')).toBe(false);
+    // A second settle (e.g. a streamText callback firing after the catch) no-ops.
+    await svc.finalizeRun('run-1', 'ws-1', 'completed', undefined);
+
+    expect(repo.update).toHaveBeenCalledTimes(1);
+    expect(repo.update).toHaveBeenCalledWith(
+      'run-1',
+      'ws-1',
+      expect.objectContaining({ status: 'failed', error: 'first' }),
+    );
+  });
+
+  it('CONCURRENCY: two simultaneous finalizeRun on the same run write the terminal row EXACTLY ONCE (the 2nd caller exits synchronously at the atomic claim)', async () => {
+    // The CRITICAL race: AiChatService.stream's safety-net catch settles the turn
+    // to 'error' while a streamText terminal callback also settles it — both call
+    // finalizeRun for the SAME runId. The once-gate must close ATOMICALLY: a
+    // `settled.has` check alone is read BEFORE the awaited UPDATE, so both callers
+    // would pass it and BOTH write the row (last-write-wins clobber + double
+    // write). The fix claims the run with a SYNCHRONOUS `active.delete` before any
+    // await, so the second caller returns in the same tick, before the UPDATE.
+    //
+    // We force the two calls to overlap by making `update` return a promise we
+    // resolve only AFTER both finalizeRun calls have run their synchronous bodies.
+    let resolveUpdate!: (v: unknown) => void;
+    const updateGate = new Promise((res) => {
+      resolveUpdate = res;
+    });
+    const update = jest.fn(() => updateGate);
+    const repo = makeRepo({ update });
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await svc.beginRun({
+      chatId: 'chat-1',
+      workspaceId: 'ws-1',
+      userId: 'user-1',
+    });
+
+    // Fire both before the (pending) update resolves. The first synchronously
+    // claims the entry (active.delete) and awaits update; the second, started in
+    // the same macrotask, finds the entry already gone and returns at the claim
+    // WITHOUT ever calling update.
+    const p1 = svc.finalizeRun('run-1', 'ws-1', 'completed');
+    const p2 = svc.finalizeRun('run-1', 'ws-1', 'error', 'safety-net');
+
+    // The decisive assertion: exactly one caller reached the terminal UPDATE.
+    expect(update).toHaveBeenCalledTimes(1);
+
+    // Let the single in-flight update land; both calls resolve cleanly.
+    resolveUpdate({ id: 'run-1' });
+    await Promise.all([p1, p2]);
+
+    expect(update).toHaveBeenCalledTimes(1);
+    // The winner is the FIRST caller ('completed' -> 'succeeded'); the late
+    // 'error' settle never wrote, so it could not clobber the real status.
+    expect(update).toHaveBeenCalledWith(
+      'run-1',
+      'ws-1',
+      expect.objectContaining({ status: 'succeeded' }),
+    );
+    expect(svc.isLocallyActive('run-1')).toBe(false);
+  });
+
+  it('F6: a TRANSIENT terminal-write failure is ridden out by the bounded retry — the run is settled, not stranded', async () => {
+    // The bug: finalizeRun used to DROP the in-memory entry BEFORE the terminal
+    // UPDATE, then only warn-log a failure. A single transient blip (pool
+    // exhaustion / deadlock / connection hiccup) on that PK UPDATE left the row
+    // 'running' with nothing left to recover it -> every later turn in that chat
+    // 409s until a restart. The fix updates FIRST and retries.
+    let calls = 0;
+    const repo = makeRepo({
+      update: jest.fn(async () => {
+        calls += 1;
+        if (calls === 1) throw new Error('deadlock detected');
+        return { id: 'run-1' };
+      }),
+    });
+    jest.spyOn(Logger.prototype, 'warn').mockImplementation(() => undefined);
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await svc.beginRun({
+      chatId: 'chat-1',
+      workspaceId: 'ws-1',
+      userId: 'user-1',
+    });
+
+    await svc.finalizeRun('run-1', 'ws-1', 'completed');
+
+    // The retry landed the terminal write: the entry is dropped (slot freed) and
+    // the row carries the real terminal status — NOT stranded at 'running'.
+    expect(svc.isLocallyActive('run-1')).toBe(false);
+    expect(repo.update).toHaveBeenCalledTimes(2);
+    expect(repo.update).toHaveBeenLastCalledWith(
+      'run-1',
+      'ws-1',
+      expect.objectContaining({ status: 'succeeded' }),
+    );
+  });
+
+  it('F6: if the terminal write keeps failing, the entry is RETAINED and a LATER settle completes it (chat not permanently 409d)', async () => {
+    // Worst case: the DB is down for the whole first finalize (all attempts fail).
+    // The run must NOT be silently lost — the entry stays so a subsequent settle
+    // (a streamText callback, requestStop -> onAbort, or a future sweep) can retry.
+    let healthy = false;
+    const repo = makeRepo({
+      update: jest.fn(async () => {
+        if (!healthy) throw new Error('pool exhausted');
+        return { id: 'run-1' };
+      }),
+    });
+    jest.spyOn(Logger.prototype, 'warn').mockImplementation(() => undefined);
+    const errorSpy = jest
+      .spyOn(Logger.prototype, 'error')
+      .mockImplementation(() => undefined);
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await svc.beginRun({
+      chatId: 'chat-1',
+      workspaceId: 'ws-1',
+      userId: 'user-1',
+    });
+
+    // First settle: every bounded attempt fails -> entry retained, NOT settled.
+    await svc.finalizeRun('run-1', 'ws-1', 'completed');
+    expect(svc.isLocallyActive('run-1')).toBe(true);
+    // F12: the give-up emits ONE explicit, greppable ERROR (run + chat context)
+    // so an operator can tell "gave up, run held in memory" from a per-attempt
+    // blip — distinct from the per-attempt warns.
+    const gaveUp = errorSpy.mock.calls.some(
+      (c) =>
+        /NON-TERMINAL/.test(String(c[0])) &&
+        /run-1/.test(String(c[0])) &&
+        /chat-1/.test(String(c[0])),
+    );
+    expect(gaveUp).toBe(true);
+
+    // The DB recovers; a later settle now succeeds and frees the slot.
+    healthy = true;
+    await svc.finalizeRun('run-1', 'ws-1', 'completed');
+    expect(svc.isLocallyActive('run-1')).toBe(false);
+    expect(repo.update).toHaveBeenLastCalledWith(
+      'run-1',
+      'ws-1',
+      expect.objectContaining({ status: 'succeeded' }),
+    );
+
+    // And it is now idempotent: a further settle no-ops (terminal row already
+    // written), so a double-settle can never clobber the real status.
+    const callsBefore = repo.update.mock.calls.length;
+    await svc.finalizeRun('run-1', 'ws-1', 'error', 'late');
+    expect(repo.update).toHaveBeenCalledTimes(callsBefore);
+  });
+
+  it('recordStep / linkAssistantMessage are best-effort: a repo failure is swallowed', async () => {
+    const repo = makeRepo({
+      update: jest.fn(async () => {
+        throw new Error('transient');
+      }),
+    });
+    jest.spyOn(Logger.prototype, 'warn').mockImplementation(() => undefined);
+    const svc = new AiChatRunService(repo as never, makeEnv() as never);
+    await expect(svc.recordStep('run-1', 'ws-1', 3)).resolves.toBeUndefined();
+    await expect(
+      svc.linkAssistantMessage('run-1', 'ws-1', 'msg-1'),
+    ).resolves.toBeUndefined();
+  });
+});

apps/server/src/core/ai-chat/ai-chat-run.service.ts

@@ -0,0 +1,452 @@
+import { Injectable, Logger, OnModuleInit } from '@nestjs/common';
+import { AiChatRunRepo } from '@docmost/db/repos/ai-chat/ai-chat-run.repo';
+import { AiChatRun } from '@docmost/db/types/entity.types';
+import { isUniqueViolation, violatedConstraint } from '@docmost/db/utils';
+import { EnvironmentService } from '../../integrations/environment/environment.service';
+
+/** Name of the partial unique index enforcing "one active run per chat" (see the
+ *  ai_chat_runs migration). A 23505 on THIS constraint is the race-safe signal
+ *  that a concurrent turn already owns the chat — distinct from any other unique
+ *  collision, which must NOT be silently treated as "already active". */
+export const ONE_ACTIVE_RUN_PER_CHAT_INDEX = 'ai_chat_runs_one_active_per_chat';
+
+/**
+ * Thrown by {@link AiChatRunService.beginRun} when the run-row INSERT loses the
+ * race for a chat's single active slot (the partial unique index rejects it with
+ * a 23505). This is the AUTHORITATIVE concurrency gate: the controller's cheap
+ * pre-check is only a fast-path, and a request that slips past it must NOT run
+ * untracked. The caller (AiChatService.stream) translates this into a 409 and
+ * aborts the turn BEFORE any AI/provider call.
+ */
+export class RunAlreadyActiveError extends Error {
+  constructor(public readonly chatId: string) {
+    super(`An agent run is already in progress for chat ${chatId}`);
+    this.name = 'RunAlreadyActiveError';
+  }
+}
+
+/**
+ * The terminal status of a TURN (the #183 assistant-row lifecycle) maps onto the
+ * terminal status of a RUN (#184). A turn that completed -> the run succeeded; a
+ * turn that errored -> the run failed; a turn aborted (explicit user stop) -> the
+ * run aborted. Pure + unit-testable.
+ */
+export type TurnTerminalStatus = 'completed' | 'error' | 'aborted';
+export type RunTerminalStatus = 'succeeded' | 'failed' | 'aborted';
+
+export function mapTurnStatusToRun(
+  status: TurnTerminalStatus,
+): RunTerminalStatus {
+  switch (status) {
+    case 'completed':
+      return 'succeeded';
+    case 'error':
+      return 'failed';
+    case 'aborted':
+      return 'aborted';
+  }
+}
+
+/** An in-flight run held in process memory: its AbortController is the ONLY thing
+ *  that can stop the turn (an explicit user stop), independent of the browser
+ *  socket. A mere disconnect never touches it, so the run keeps going. */
+interface ActiveRun {
+  controller: AbortController;
+  chatId: string;
+  workspaceId: string;
+}
+
+/** The live handle the streaming path drives a run through (returned by
+ *  {@link AiChatRunService.beginRun}). The `signal` governs the agent loop's
+ *  abort — wired to the run, NOT to the HTTP socket. */
+export interface RunHandle {
+  runId: string;
+  signal: AbortSignal;
+}
+
+/**
+ * AiChatRunService (#184 phase 1) — owns the agent RUN as a first-class,
+ * server-side lifecycle object detached from the HTTP request / browser window.
+ *
+ * Responsibilities:
+ *  - create a run row when a turn starts (inserted directly as 'running'; the
+ *    'pending' status is only the column default + a reserved value, never
+ *    written by code in phase 1) and register an in-memory AbortController for it
+ *    (the explicit-stop lever);
+ *  - finalize the run row (succeeded / failed / aborted) and unregister it;
+ *  - service an EXPLICIT user stop (`requestStop`) — the ONLY thing that aborts a
+ *    run; a browser disconnect deliberately does NOT;
+ *  - crash-recovery sweep of dangling runs on startup.
+ *
+ * The agent loop itself still runs in AiChatService.stream (reusing #183's
+ * step-granular durable write path, `consumeStream` already drains it independent
+ * of the socket); this service only wraps it in a durable lifecycle and an
+ * abort handle that outlives the subscriber.
+ */
+@Injectable()
+export class AiChatRunService implements OnModuleInit {
+  private readonly logger = new Logger(AiChatRunService.name);
+
+  // runId -> ActiveRun. Process-local on purpose (phase 1 is single-process /
+  // in-memory transport; a cross-process BullMQ runner + Redis stop-signal is
+  // deferred to phase 2). A stop for a runId not in this map (e.g. after a
+  // restart) still records `stop_requested_at` on the row.
+  private readonly active = new Map<string, ActiveRun>();
+
+  // runIds whose TERMINAL row write has SUCCEEDED — the idempotency once-gate
+  // (F6). A finalize must short-circuit only AFTER the terminal write has landed,
+  // NOT merely after the in-memory entry was dropped: a transient UPDATE failure
+  // has to stay retryable, so "already settled" means "row already terminal", not
+  // "entry already gone". Grows by one short UUID per finished run over process
+  // uptime — negligible in phase 1's single process.
+  private readonly settled = new Set<string>();
+
+  // Bounded retry for the terminal write (F6): a single PK UPDATE can fail
+  // transiently under many fire-and-forget writes (pool exhaustion, deadlock, a
+  // brief connection blip). Riding out that blip in-place matters because the
+  // dominant success path (streamText onFinish) settles exactly ONCE — if that
+  // write is dropped and never retried, the row is stranded 'running' and the
+  // one-active-run gate 409s every future turn in the chat until a restart (no
+  // periodic sweep in phase 1).
+  private static readonly FINALIZE_MAX_ATTEMPTS = 3;
+  private static readonly FINALIZE_RETRY_BASE_MS = 50;
+
+  constructor(
+    private readonly runRepo: AiChatRunRepo,
+    private readonly environment: EnvironmentService,
+  ) {}
+
+  /**
+   * Crash-recovery sweep on server start: settle EVERY run still left
+   * pending/running to 'aborted' (F1 / DECISION C). The boot sweep is
+   * UNCONDITIONAL — no staleness window — because phase 1 is single-process: on a
+   * fresh boot any pending|running run is definitionally hung (no live runner owns
+   * it), so even a fast restart (deploy/OOM within minutes of the last step) can
+   * no longer leave a run stuck 'running' forever (which would make the
+   * one-active-run gate 409 every future turn in that chat). The staleness window
+   * is reintroduced only for the phase-2 multi-instance timer sweep, where a
+   * booting replica must not abort a run another replica is actively executing.
+   * Best-effort — a sweep failure is logged but MUST NOT block startup (mirrors
+   * AiChatService.onModuleInit for #183).
+   */
+  async onModuleInit(): Promise<void> {
+    this.warnIfMultiInstance();
+    try {
+      // No `staleMs`: unconditional boot sweep (F1). See AiChatRunRepo.sweepRunning.
+      const swept = await this.runRepo.sweepRunning();
+      if (swept > 0) {
+        this.logger.log(
+          `Startup sweep: marked ${swept} dangling agent run(s) as 'aborted'.`,
+        );
+      }
+    } catch (err) {
+      this.logger.warn(
+        `Startup sweep of dangling runs failed: ${
+          err instanceof Error ? err.message : 'unknown error'
+        }`,
+      );
+    }
+  }
+
+  /**
+   * F2 (DECISION A): autonomous runs are SINGLE-INSTANCE-ONLY in phase 1. An
+   * explicit Stop, and the in-memory AbortController that backs it, are
+   * process-local: a Stop only aborts the live turn if it lands on the SAME
+   * replica that owns the run (it still stamps `stop_requested_at` cross-instance,
+   * but nothing reads that flag during an active run yet). Cross-instance pub/sub
+   * stop is phase 2. So if the deployment is horizontally scaled, warn loudly at
+   * startup that a Stop may not reach a run executing on another replica.
+   *
+   * DETECTION: this codebase always wires the socket.io Redis adapter (REDIS_URL
+   * is mandatory), so the adapter alone is NOT a horizontal-scaling signal. The
+   * authoritative signal the codebase has is `CLOUD=true` (EnvironmentService
+   * .isCloud()), the Docmost-cloud multi-replica deployment. We warn whenever that
+   * is set, because any workspace could enable settings.ai.autonomousRuns. A
+   * self-hosted operator running multiple replicas behind a load balancer is also
+   * multi-instance; the deploy docs (.env.example / AGENTS.md) spell out the
+   * single-instance constraint for that case.
+   */
+  private warnIfMultiInstance(): void {
+    if (this.environment.isCloud()) {
+      this.logger.warn(
+        'Autonomous agent runs (settings.ai.autonomousRuns) are SINGLE-INSTANCE-ONLY ' +
+          'in phase 1: a horizontally-scaled deployment was detected (CLOUD=true). ' +
+          'An explicit Stop only aborts a run executing on the same replica that owns ' +
+          'it (cross-instance Stop is not yet reliable — phase 2). Run a single ' +
+          'instance if you enable autonomousRuns, or keep the flag off.',
+      );
+    }
+  }
+
+  /**
+   * Start a run for a turn: insert the run row (status 'running', startedAt now),
+   * register a fresh AbortController for it, and return a {@link RunHandle} whose
+   * `signal` the agent loop uses. The DB partial unique index guarantees at most
+   * one active run per chat — a second concurrent start on the same chat REJECTS
+   * at the insert (a 23505 on {@link ONE_ACTIVE_RUN_PER_CHAT_INDEX}). That
+   * rejection is the AUTHORITATIVE race gate: it is surfaced as a distinct
+   * {@link RunAlreadyActiveError} (NOT swallowed), so the caller turns it into a
+   * 409 and never streams an untracked turn. The controller is registered AFTER a
+   * successful insert so a rejected start leaks nothing.
+   */
+  async beginRun(args: {
+    chatId: string;
+    workspaceId: string;
+    userId: string;
+    trigger?: string;
+  }): Promise<RunHandle> {
+    let run: AiChatRun;
+    try {
+      run = await this.runRepo.insert({
+        chatId: args.chatId,
+        workspaceId: args.workspaceId,
+        createdBy: args.userId,
+        trigger: args.trigger ?? 'user',
+        status: 'running',
+        startedAt: new Date(),
+      });
+    } catch (err) {
+      // The race backstop: a concurrent turn already holds this chat's single
+      // active slot, so the partial unique index rejected our insert. Surface a
+      // distinct signal — the caller MUST reject this turn (409), not run it
+      // untracked. Any OTHER error propagates unchanged.
+      if (
+        isUniqueViolation(err) &&
+        violatedConstraint(err) === ONE_ACTIVE_RUN_PER_CHAT_INDEX
+      ) {
+        throw new RunAlreadyActiveError(args.chatId);
+      }
+      throw err;
+    }
+    const controller = new AbortController();
+    this.active.set(run.id, {
+      controller,
+      chatId: args.chatId,
+      workspaceId: args.workspaceId,
+    });
+    return { runId: run.id, signal: controller.signal };
+  }
+
+  /** Link the assistant message (the #183 projection) to its run. Best-effort. */
+  async linkAssistantMessage(
+    runId: string,
+    workspaceId: string,
+    assistantMessageId: string,
+  ): Promise<void> {
+    try {
+      await this.runRepo.update(runId, workspaceId, { assistantMessageId });
+    } catch (err) {
+      this.logger.warn(
+        `Failed to link assistant message to run ${runId}: ${
+          err instanceof Error ? err.message : 'unknown error'
+        }`,
+      );
+    }
+  }
+
+  /** Persist progress: bump the run's finished-step count. Best-effort (never
+   *  blocks or breaks the stream). */
+  async recordStep(
+    runId: string,
+    workspaceId: string,
+    stepCount: number,
+  ): Promise<void> {
+    try {
+      await this.runRepo.update(runId, workspaceId, { stepCount });
+    } catch (err) {
+      this.logger.warn(
+        `Failed to record step for run ${runId}: ${
+          err instanceof Error ? err.message : 'unknown error'
+        }`,
+      );
+    }
+  }
+
+  /**
+   * Finalize a run to its terminal status (succeeded / failed / aborted),
+   * stamping finishedAt + any error. Best-effort, but ROBUST against a transient
+   * terminal-write failure (F6) AND atomically safe against a concurrent settle.
+   *
+   * ATOMIC ONCE-CLAIM (the gate must close in ONE synchronous tick): two
+   * finalizeRun calls for the SAME run can race — the documented real path is
+   * AiChatService.stream's safety-net catch settling the turn to 'error' while a
+   * streamText terminal callback (onFinish/onAbort/onError) ALSO settles it. The
+   * `settled.has` check alone is NOT a gate: it is read BEFORE the awaited UPDATE,
+   * so two callers can both see `false` and both write the row (last-write-wins
+   * clobbers the real terminal status, and the bounded retry only widens that
+   * window). The claim therefore happens via `active.delete`, a SYNCHRONOUS
+   * check-and-clear with NO await between the gate and the entry removal: the
+   * second concurrent caller finds the entry already gone and returns in the same
+   * tick, before any UPDATE. The transition "nobody is finalizing" -> "I am
+   * finalizing" is thus a single atomic step.
+   *
+   * ORDER MATTERS (F6): once we own the claim, the terminal UPDATE happens FIRST;
+   * only once it SUCCEEDS do we record the run as settled. If the UPDATE fails on
+   * every bounded attempt we RESTORE the in-memory entry, leave the run UNsettled,
+   * and emit an ERROR signal that the row is left non-terminal 'running' (which
+   * would 409 every future turn in the chat until recovery). An in-process retry
+   * by a LATER settle is only POSSIBLE, never guaranteed: it needs (a) the entry
+   * to have been restored at the give-up path AND (b) a fresh settler to arrive
+   * AFTER that restore. A concurrent settler that arrives DURING the retry window
+   * — while the entry is deleted for backoff and not yet restored — is consumed at
+   * the synchronous `active.delete` claim (it finds nothing to delete and returns
+   * a no-op), so it does NOT become an in-process retrier. The NO-streamText path
+   * (the turn threw before streamText was wired, so ONLY the safety-net ever
+   * settles) likewise has no second in-process settler at all. The UNCONDITIONAL
+   * backstop in every case is the boot sweep on the next restart (phase 1 has no
+   * periodic in-process sweep); the retained entry is bounded (cleared on restart)
+   * and harmless meanwhile.
+   *
+   * IDEMPOTENT on SUCCESS (#184 review): the terminal write happens AT MOST ONCE
+   * per run. After a successful write the once-gate keys off {@link settled} (the
+   * terminal row already written) so a settle arriving AFTER the entry was already
+   * dropped-and-settled returns early; a settle racing the in-flight write is
+   * stopped earlier still, by the `active.delete` claim. Either way a genuine
+   * double-settle collapses to a single write and a late settle can never clobber
+   * the real terminal status or double-write the row.
+   */
+  async finalizeRun(
+    runId: string,
+    workspaceId: string,
+    turnStatus: TurnTerminalStatus,
+    error?: string,
+  ): Promise<void> {
+    // ---- Atomic once-claim (synchronous; NO await before the gate closes) ----
+    // Already terminally written -> idempotent no-op.
+    if (this.settled.has(runId)) return;
+    // Capture the entry BEFORE the delete so a total-failure path can restore it.
+    const entry = this.active.get(runId);
+    // SYNCHRONOUS check-and-clear: the FIRST caller deletes (claims) the entry;
+    // any concurrent SECOND caller finds nothing to delete and returns HERE, in
+    // the same tick, before any await — so it can never reach the UPDATE.
+    if (!this.active.delete(runId)) return;
+
+    let lastError: unknown;
+    for (
+      let attempt = 1;
+      attempt <= AiChatRunService.FINALIZE_MAX_ATTEMPTS;
+      attempt++
+    ) {
+      try {
+        await this.runRepo.update(runId, workspaceId, {
+          status: mapTurnStatusToRun(turnStatus),
+          finishedAt: new Date(),
+          error: error ?? null,
+        });
+        // Terminal write landed: arm the once-gate. The entry is already gone
+        // (claimed above); we do NOT restore it. The slot is now free.
+        this.settled.add(runId);
+        return;
+      } catch (err) {
+        lastError = err;
+        this.logger.warn(
+          `Failed to finalize run ${runId} (attempt ${attempt}/${
+            AiChatRunService.FINALIZE_MAX_ATTEMPTS
+          }): ${err instanceof Error ? err.message : 'unknown error'}`,
+        );
+        if (attempt < AiChatRunService.FINALIZE_MAX_ATTEMPTS) {
+          await this.delay(AiChatRunService.FINALIZE_RETRY_BASE_MS * attempt);
+        }
+      }
+    }
+    // Every attempt failed: this is a give-up, materially worse than a per-attempt
+    // blip — the row is left NON-TERMINAL ('running'), so emit ONE explicit,
+    // greppable ERROR so an operator can tell "survived a blip" from "gave up, run
+    // held in memory until recovery" (the last warn alone says only "attempt 3/3").
+    this.logger.error(
+      `Run ${runId} (chat ${entry?.chatId ?? 'unknown'}) left NON-TERMINAL ` +
+        `('running'): terminal write failed after ${
+          AiChatRunService.FINALIZE_MAX_ATTEMPTS
+        } attempts; entry retained in memory, recovery deferred to next settle / ` +
+        `boot sweep`,
+      lastError,
+    );
+    // RESTORE the claimed entry (and leave the run UNsettled) so a LATER settle
+    // that arrives AFTER this restore MAY retry the terminal write — but that
+    // in-process retry is NOT guaranteed (a concurrent settler caught in the retry
+    // window above is consumed at the `active.delete` claim, and the no-streamText
+    // path has no second settler at all). The UNCONDITIONAL backstop in every case
+    // is the boot sweep on the next restart; the restored entry is bounded and
+    // cleared on restart.
+    if (entry) this.active.set(runId, entry);
+  }
+
+  /** Small async backoff between terminal-write retries (F6). Isolated so it is
+   *  trivial to stub/fake-time in tests. */
+  private delay(ms: number): Promise<void> {
+    return new Promise((resolve) => setTimeout(resolve, ms));
+  }
+
+  /**
+   * Request an EXPLICIT stop of a run (the user pressed Stop). This is the ONLY
+   * thing that aborts a run — distinct from a browser disconnect, which leaves
+   * the run going. Aborts the in-process controller FIRST (the only thing that
+   * actually stops the run, if this replica owns it), then makes a best-effort
+   * attempt to stamp `stop_requested_at` — that audit write stamps only while the
+   * row is active and may be skipped on a DB error or lost to the finalize race,
+   * which is acceptable since the row still settles as 'aborted'. Returns true
+   * when a stop took effect (row marked and/or controller aborted), false when
+   * there was nothing active to stop.
+   */
+  async requestStop(runId: string, workspaceId: string): Promise<boolean> {
+    const entry = this.active.get(runId);
+    if (entry) {
+      // Abort the live turn FIRST -> streamText onAbort fires -> the partial is
+      // persisted (#183) and finalizeRun settles the row as 'aborted'. This is
+      // the ONLY thing that aborts a run, so it MUST NOT be hostage to the audit
+      // write below: a transient failure on `markStopRequested` (pool exhaustion,
+      // deadlock, dropped connection) must never leave the run executing despite
+      // an explicit Stop. At worst only the `stop_requested_at` timestamp is lost.
+      entry.controller.abort();
+    }
+    // Record `stop_requested_at` (best-effort). A transient DB failure here is
+    // logged and treated as `marked = false`; the abort above already took
+    // effect, so we never rethrow and skip stopping the run. Note: because
+    // markStopRequested only stamps while the row is active, aborting first means
+    // even a healthy write can lose the race against the resulting finalize and
+    // skip the stamp — acceptable, as the row still settles as 'aborted' and only
+    // this audit timestamp may be lost.
+    let marked: unknown;
+    try {
+      marked = await this.runRepo.markStopRequested(runId, workspaceId);
+    } catch (err) {
+      marked = undefined;
+      this.logger.warn(
+        `requestStop: markStopRequested failed for run ${runId} ` +
+          `(stop_requested_at not recorded); abort already issued: ` +
+          `${err instanceof Error ? err.message : String(err)}`,
+      );
+    }
+    return Boolean(marked) || Boolean(entry);
+  }
+
+  /** Latest persisted run for a chat — the reconnect target (an in-flight or
+   *  finished run). Pure read-through to the repo. */
+  getLatestForChat(
+    chatId: string,
+    workspaceId: string,
+  ): Promise<AiChatRun | undefined> {
+    return this.runRepo.findLatestByChat(chatId, workspaceId);
+  }
+
+  /** Fetch a run by id (workspace-scoped). Used to resolve + ownership-check an
+   *  explicit stop targeting a runId. */
+  getRun(runId: string, workspaceId: string): Promise<AiChatRun | undefined> {
+    return this.runRepo.findById(runId, workspaceId);
+  }
+
+  /** The active run on a chat, if any (used to reject a concurrent start with a
+   *  clean 409 before committing to the stream). */
+  getActiveForChat(
+    chatId: string,
+    workspaceId: string,
+  ): Promise<AiChatRun | undefined> {
+    return this.runRepo.findActiveByChat(chatId, workspaceId);
+  }
+
+  /** Test/diagnostic seam: whether this replica is holding a live controller for
+   *  the run. */
+  isLocallyActive(runId: string): boolean {
+    return this.active.has(runId);
+  }
+}

apps/server/src/core/ai-chat/ai-chat-stream-registry.service.ts

@@ -0,0 +1,329 @@
+import { Injectable, Logger, OnModuleDestroy } from '@nestjs/common';
+
+/**
+ * In-memory run-stream registry (#184 phase 1.5). A durable agent run tees its
+ * SSE frames here (via `pipeUIMessageStreamToResponse({ consumeSseStream })`)
+ * so a LATE tab — one that reloaded, or opened after the starter dropped — can
+ * attach through `GET /ai-chat/runs/:chatId/stream`, replay the frames buffered
+ * so far, and then follow the live tail as a normal streamer.
+ *
+ * This is deliberately single-process and best-effort: it holds nothing the DB
+ * does not (the run + assistant row are the source of truth), so a process
+ * restart simply drops in-flight entries and the client falls back to its
+ * restore + degraded-poll path. The async `attach` return type is the seam for a
+ * future phase-2 cross-process backend (Redis) — the interface does not change.
+ */
+
+/** How long a finished entry is retained for late attach (replay + immediate end). */
+export const RUN_STREAM_RETAIN_FINISHED_MS = 30_000;
+
+/** Per-run replay buffer cap. Past this the buffer is dropped (attach -> 204). */
+export const RUN_STREAM_MAX_BUFFER_BYTES = 4 * 1024 * 1024;
+
+// 2x the replay cap: a just-written 4MB replay burst alone can never trip the
+// per-subscriber cap (see controller); only a genuinely stalled socket can.
+export const SUBSCRIBER_MAX_BUFFERED_BYTES = 2 * RUN_STREAM_MAX_BUFFER_BYTES;
+
+export interface RunStreamCallbacks {
+  onFrame: (frame: string) => void;
+  onEnd: () => void;
+}
+
+export interface RunStreamAttachment {
+  replay: string[];
+  finished: boolean;
+  start(): void; // drain pending frames (order preserved) and go live
+  unsubscribe(): void; // safe to call at any point, idempotent
+}
+
+interface Subscriber extends RunStreamCallbacks {
+  started: boolean;
+  pending: string[];
+  // Byte size of `pending`, capped at SUBSCRIBER_MAX_BUFFERED_BYTES. `start()` is
+  // called in the SAME tick as `attach()` today (see attach), so `pending` never
+  // holds more than one microtask of frames — but the async `attach` signature is
+  // a phase-2 seam: an await between attach and start would let a stalled paused
+  // subscriber buffer the WHOLE run here. The cap is the structural backstop.
+  pendingBytes: number;
+  overflowed: boolean;
+  pendingEnd: boolean;
+}
+
+interface Entry {
+  runId: string;
+  // The persisted assistant row id of this run (set at bind; undefined if the
+  // seed failed). Used by the attach anchor check (invariant 6).
+  assistantMessageId?: string;
+  frames: string[];
+  bytes: number;
+  overflowed: boolean;
+  finished: boolean;
+  subscribers: Set<Subscriber>;
+  retainTimer?: NodeJS.Timeout;
+}
+
+@Injectable()
+export class AiChatStreamRegistryService implements OnModuleDestroy {
+  private readonly logger = new Logger(AiChatStreamRegistryService.name);
+  private readonly entries = new Map<string, Entry>(); // key: chatId
+
+  /**
+   * Register a fresh entry at the START of a run (before any frame), so a tab
+   * that attaches in the begin->seed window finds an entry to wait on. If an
+   * entry already exists for this chat (a previous, possibly still-live run whose
+   * tee loop is draining), it is terminated MIRRORING the done-path (invariant 3)
+   * so its subscribers are released and its retention timer is cleared; a late
+   * `done` from that old tee then fires against the closed-over old reference and,
+   * thanks to identity checks, never touches this new entry.
+   */
+  open(chatId: string, runId: string): void {
+    const existing = this.entries.get(chatId);
+    if (existing) {
+      if (existing.retainTimer) {
+        clearTimeout(existing.retainTimer);
+        existing.retainTimer = undefined;
+      }
+      // Started subscribers get exactly one onEnd() and are removed; paused ones
+      // are marked pendingEnd (their start() will end them). finished=true guards
+      // any later done from the old tee loop from double-notifying.
+      this.terminateSubscribers(existing);
+    }
+    this.entries.set(chatId, {
+      runId,
+      frames: [],
+      bytes: 0,
+      overflowed: false,
+      finished: false,
+      subscribers: new Set<Subscriber>(),
+    });
+  }
+
+  /**
+   * Tee a run's SSE frame stream into its entry (called from consumeSseStream).
+   * No-op with a warning when there is no entry or the entry belongs to a
+   * different run (invariant 1). The reader loop is fire-and-forget: the tee
+   * branch outlives the client socket by design.
+   */
+  bind(
+    chatId: string,
+    runId: string,
+    assistantMessageId: string | undefined,
+    stream: ReadableStream<string>,
+  ): void {
+    const entry = this.entries.get(chatId);
+    if (!entry || entry.runId !== runId) {
+      // Invariant 1: only the matching run may mutate the entry.
+      this.logger.warn(
+        `bind: no matching run-stream entry for chat=${chatId} run=${runId}`,
+      );
+      return;
+    }
+    entry.assistantMessageId = assistantMessageId;
+    const reader = stream.getReader();
+    const pump = async (): Promise<void> => {
+      try {
+        for (;;) {
+          const { done, value } = await reader.read();
+          if (done) break;
+          this.ingestFrame(entry, value);
+        }
+        this.finalizeEntry(chatId, entry);
+      } catch {
+        // A read error is a terminal event too — release subscribers.
+        this.finalizeEntry(chatId, entry);
+      }
+    };
+    void pump();
+  }
+
+  /**
+   * Terminate a run's entry from the OUTER catch of the stream method (a failure
+   * before/while wiring the pipe, so `done` will never arrive). Identity-checked
+   * on runId (invariant 1); the shared terminal path is idempotent.
+   */
+  abortEntry(chatId: string, runId: string): void {
+    const entry = this.entries.get(chatId);
+    if (!entry || entry.runId !== runId) return;
+    this.finalizeEntry(chatId, entry);
+  }
+
+  /**
+   * Attach to a run's stream. Async only for the phase-2 Redis seam — the body
+   * runs synchronously so the replay snapshot and the subscriber registration
+   * happen in ONE tick with no await between them (invariant 4): a frame ingested
+   * concurrently cannot slip into the gap and be lost or duplicated.
+   *
+   * Returns null (-> the caller answers 204) when:
+   *  - there is no entry, or it overflowed (replay is gone);
+   *  - expect=live with an anchor that does not match this run's assistant id
+   *    (invariant 6: a stripped tab must never replay a FOREIGN run's transcript);
+   *  - the run finished and the caller did not expect a live tail.
+   * A finished run with expect=live yields a replay-only attachment (no
+   * subscriber registered). Otherwise a paused subscriber is registered and the
+   * caller replays `replay`, then calls start() to drain and go live.
+   */
+  async attach(
+    chatId: string,
+    expectLive: boolean,
+    anchor: string | undefined,
+    cb: RunStreamCallbacks,
+  ): Promise<RunStreamAttachment | null> {
+    const entry = this.entries.get(chatId);
+    if (!entry || entry.overflowed) return null;
+    // Invariant 6: cross-run replay is forbidden. Before bind, assistantMessageId
+    // is undefined and mismatches any anchor -> 204 -> client restore+poll path.
+    if (expectLive && anchor && entry.assistantMessageId !== anchor) return null;
+    if (entry.finished && !expectLive) return null;
+    if (entry.finished && expectLive) {
+      // Replay-only: the run is done, no subscriber is registered.
+      return {
+        replay: entry.frames.slice(),
+        finished: true,
+        start: () => undefined,
+        unsubscribe: () => undefined,
+      };
+    }
+
+    const sub: Subscriber = {
+      onFrame: cb.onFrame,
+      onEnd: cb.onEnd,
+      started: false,
+      pending: [],
+      pendingBytes: 0,
+      overflowed: false,
+      pendingEnd: false,
+    };
+    entry.subscribers.add(sub);
+    // Snapshot in the SAME synchronous block as the registration (invariant 4).
+    const replay = entry.frames.slice();
+    // CONTRACT: the caller MUST call start() in the SAME tick as this attach()
+    // returns — no await between them. While a subscriber is paused, every frame
+    // is buffered in sub.pending; a delayed start() lets a whole run accumulate
+    // there. The pendingBytes cap (see ingestFrame) is the structural backstop if
+    // that contract is ever broken (e.g. the phase-2 Redis await seam).
+    return {
+      replay,
+      finished: false,
+      start: () => {
+        if (sub.overflowed) {
+          // The pending buffer overflowed while paused: end the stream instead of
+          // replaying a partial (a 204-equivalent post-attach degrade).
+          try {
+            sub.onEnd();
+          } catch {
+            // The socket is gone; nothing to end.
+          }
+          entry.subscribers.delete(sub);
+          return;
+        }
+        // Deliver frames buffered while paused, in order, then go live.
+        for (const frame of sub.pending) {
+          try {
+            sub.onFrame(frame);
+          } catch {
+            entry.subscribers.delete(sub);
+            return;
+          }
+        }
+        sub.pending = [];
+        sub.started = true;
+        if (sub.pendingEnd) {
+          try {
+            sub.onEnd();
+          } catch {
+            // The socket is gone; nothing to end.
+          }
+          entry.subscribers.delete(sub);
+        }
+      },
+      unsubscribe: () => {
+        entry.subscribers.delete(sub);
+      },
+    };
+  }
+
+  onModuleDestroy(): void {
+    for (const entry of this.entries.values()) {
+      if (entry.retainTimer) clearTimeout(entry.retainTimer);
+    }
+    this.entries.clear();
+  }
+
+  /** Buffer + fan-out a single frame. See invariant/overflow semantics inline. */
+  private ingestFrame(entry: Entry, frame: string): void {
+    entry.bytes += Buffer.byteLength(frame);
+    if (!entry.overflowed) {
+      entry.frames.push(frame);
+      if (entry.bytes > RUN_STREAM_MAX_BUFFER_BYTES) {
+        // The crossing frame was already counted AND (below) fanned out; only the
+        // replay buffer is dropped. After overflow no more frames are buffered,
+        // but live fan-out continues.
+        entry.overflowed = true;
+        entry.frames = [];
+        this.logger.warn(
+          `run-stream buffer overflow for run=${entry.runId}; ` +
+            `late attach will 204 until the run ends`,
+        );
+      }
+    }
+    for (const sub of entry.subscribers) {
+      if (sub.started) {
+        try {
+          sub.onFrame(frame);
+        } catch {
+          entry.subscribers.delete(sub);
+        }
+      } else {
+        sub.pending.push(frame);
+        sub.pendingBytes += Buffer.byteLength(frame);
+        if (sub.pendingBytes > SUBSCRIBER_MAX_BUFFERED_BYTES) {
+          // The paused subscriber's buffer overflowed — only possible if start()
+          // was delayed past the same-tick contract (the phase-2 await seam).
+          // Drop it rather than buffer the whole run; on start() it degrades to an
+          // immediate end (a 204-equivalent) instead of replaying a partial.
+          sub.overflowed = true;
+          sub.pending = [];
+          entry.subscribers.delete(sub);
+        }
+      }
+    }
+  }
+
+  /**
+   * Shared terminal path for done / read-error / external-abort. Idempotent: a
+   * second call (already finished) is a no-op, so an open()-replaced or
+   * abort-then-done entry is never double-armed or double-ended.
+   */
+  private finalizeEntry(chatId: string, entry: Entry): void {
+    if (entry.finished) return;
+    this.terminateSubscribers(entry);
+    const timer = setTimeout(() => {
+      // Invariant 2: only delete OUR entry (a replacement may already own the key).
+      if (this.entries.get(chatId) === entry) this.entries.delete(chatId);
+    }, RUN_STREAM_RETAIN_FINISHED_MS);
+    timer.unref?.();
+    entry.retainTimer = timer;
+  }
+
+  /**
+   * Mark the entry finished and release its subscribers, mirroring the done-path:
+   * started subscribers get exactly one onEnd() and are removed; paused ones are
+   * flagged pendingEnd so their start() ends them. Deleting the current element
+   * during Set iteration is safe.
+   */
+  private terminateSubscribers(entry: Entry): void {
+    entry.finished = true;
+    for (const sub of entry.subscribers) {
+      if (sub.started) {
+        try {
+          sub.onEnd();
+        } catch {
+          // The socket is gone; nothing to end.
+        }
+        entry.subscribers.delete(sub);
+      } else {
+        sub.pendingEnd = true;
+      }
+    }
+  }
+}

apps/server/src/core/ai-chat/ai-chat-stream-registry.spec.ts

@@ -0,0 +1,388 @@
+import {
+  AiChatStreamRegistryService,
+  RUN_STREAM_MAX_BUFFER_BYTES,
+  RUN_STREAM_RETAIN_FINISHED_MS,
+  RunStreamCallbacks,
+} from './ai-chat-stream-registry.service';
+
+/**
+ * Unit tests for the in-memory run-stream registry (#184 phase 1.5). The registry
+ * is the whole of the resumable-transport contract: replay ordering, paused ->
+ * live hand-off, overflow, retention, the anchor check (invariant 6), and the
+ * mirror-the-done-path replace semantics (invariant 3). Every enumerated case in
+ * the issue's task 1.5 has a test here.
+ */
+
+// A ReadableStream whose frames the test pushes explicitly, plus close/error.
+function makePushStream(): {
+  stream: ReadableStream<string>;
+  push: (f: string) => void;
+  close: () => void;
+  error: (e?: unknown) => void;
+} {
+  let controller!: ReadableStreamDefaultController<string>;
+  const stream = new ReadableStream<string>({
+    start(c) {
+      controller = c;
+    },
+  });
+  return {
+    stream,
+    push: (f) => controller.enqueue(f),
+    close: () => controller.close(),
+    error: (e) => controller.error(e ?? new Error('read error')),
+  };
+}
+
+// Let the fire-and-forget pump drain queued frames (reader.read() resolves on a
+// macrotask boundary for an already-enqueued value).
+const flush = (): Promise<void> => new Promise((r) => setTimeout(r, 0));
+
+function collector(): {
+  cb: RunStreamCallbacks;
+  frames: string[];
+  ended: () => number;
+} {
+  const frames: string[] = [];
+  let ends = 0;
+  return {
+    frames,
+    ended: () => ends,
+    cb: {
+      onFrame: (f) => frames.push(f),
+      onEnd: () => {
+        ends += 1;
+      },
+    },
+  };
+}
+
+describe('AiChatStreamRegistryService', () => {
+  const CHAT = 'chat-1';
+  let registry: AiChatStreamRegistryService;
+
+  beforeEach(() => {
+    registry = new AiChatStreamRegistryService();
+    jest.spyOn((registry as any).logger, 'warn').mockImplementation(() => {});
+  });
+
+  afterEach(() => {
+    registry.onModuleDestroy();
+  });
+
+  it('replays frames in arrival order (live attach)', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+    src.push('a');
+    src.push('b');
+    src.push('c');
+    await flush();
+
+    const c = collector();
+    const att = await registry.attach(CHAT, false, undefined, c.cb);
+    expect(att).not.toBeNull();
+    expect(att!.replay).toEqual(['a', 'b', 'c']);
+    expect(att!.finished).toBe(false);
+  });
+
+  it('late attach gets the full prefix as replay plus the live tail', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+    src.push('a');
+    src.push('b');
+    await flush();
+
+    const c = collector();
+    const att = (await registry.attach(CHAT, false, undefined, c.cb))!;
+    expect(att.replay).toEqual(['a', 'b']);
+    att.start();
+    // Live tail arrives after start().
+    src.push('c');
+    src.push('d');
+    await flush();
+    expect(c.frames).toEqual(['c', 'd']);
+  });
+
+  it('a paused subscriber receives frames buffered during pause in order, then live (no loss/reorder)', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+    src.push('a');
+    await flush();
+
+    const c = collector();
+    // Attach (paused). Frames that arrive BEFORE start() must queue, not drop.
+    const att = (await registry.attach(CHAT, false, undefined, c.cb))!;
+    expect(att.replay).toEqual(['a']);
+    src.push('b'); // arrives while paused -> pending
+    src.push('c');
+    await flush();
+    expect(c.frames).toEqual([]); // nothing delivered yet (paused)
+    att.start(); // drains pending in order
+    expect(c.frames).toEqual(['b', 'c']);
+    src.push('d'); // now live
+    await flush();
+    expect(c.frames).toEqual(['b', 'c', 'd']);
+  });
+
+  it('a run that finishes while a subscriber is paused ends it on start()', async () => {
+    registry.open(CHAT, 'run-1');
+    const c = collector();
+    const att = (await registry.attach(CHAT, false, undefined, c.cb))!;
+    // Terminate the run while the subscriber is still paused.
+    registry.abortEntry(CHAT, 'run-1');
+    expect(c.ended()).toBe(0); // paused: not ended yet
+    att.start();
+    expect(c.ended()).toBe(1); // start() drains + ends
+  });
+
+  it('finished + expect=live returns a replay WITHOUT registering a subscriber', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+    src.push('a');
+    src.push('b');
+    src.close();
+    await flush();
+
+    const c = collector();
+    const att = (await registry.attach(CHAT, true, undefined, c.cb))!;
+    expect(att.finished).toBe(true);
+    expect(att.replay).toEqual(['a', 'b']);
+    // No subscriber registered: start()/unsubscribe are no-ops and the entry has
+    // zero subscribers.
+    const entry = (registry as any).entries.get(CHAT);
+    expect(entry.subscribers.size).toBe(0);
+    att.start();
+    expect(c.frames).toEqual([]);
+  });
+
+  it('finished WITHOUT expect=live returns null', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+    src.push('a');
+    src.close();
+    await flush();
+
+    const c = collector();
+    expect(await registry.attach(CHAT, false, undefined, c.cb)).toBeNull();
+  });
+
+  it('anchor mismatch with expect=live returns null (and null before bind sets assistantMessageId)', async () => {
+    registry.open(CHAT, 'run-1');
+    const c = collector();
+    // Before bind: assistantMessageId is undefined -> mismatches any anchor.
+    expect(
+      await registry.attach(CHAT, true, 'assist-1', c.cb),
+    ).toBeNull();
+
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+    src.push('a');
+    await flush();
+    // Wrong anchor -> null (cross-run replay forbidden, invariant 6).
+    expect(await registry.attach(CHAT, true, 'other-id', c.cb)).toBeNull();
+  });
+
+  it('matching anchor with expect=live attaches', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+    src.push('a');
+    await flush();
+
+    const c = collector();
+    const att = await registry.attach(CHAT, true, 'assist-1', c.cb);
+    expect(att).not.toBeNull();
+    expect(att!.replay).toEqual(['a']);
+  });
+
+  it('overflow: attach returns null, but the LIVE subscriber keeps receiving (incl. the crossing frame)', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+
+    // A live (started) subscriber attached before the flood.
+    const c = collector();
+    const att = (await registry.attach(CHAT, false, undefined, c.cb))!;
+    att.start();
+
+    const oneMb = 'x'.repeat(1024 * 1024);
+    // 5 x 1MB = 5MB > 4MB cap; the 5th frame is the one that crosses.
+    for (let i = 0; i < 5; i++) src.push(oneMb + i);
+    await flush();
+
+    const entry = (registry as any).entries.get(CHAT);
+    expect(entry.overflowed).toBe(true);
+    expect(entry.bytes).toBeGreaterThan(RUN_STREAM_MAX_BUFFER_BYTES);
+    // The live subscriber received ALL 5 frames, including the crossing one.
+    expect(c.frames).toHaveLength(5);
+    expect(c.frames[4]).toBe(oneMb + 4);
+
+    // A NEW attach after overflow gets null (replay buffer is gone).
+    const c2 = collector();
+    expect(await registry.attach(CHAT, false, undefined, c2.cb)).toBeNull();
+  });
+
+  it('a paused subscriber whose pending buffer overflows is dropped and ends on start(); other subscribers keep receiving', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+
+    // A: paused (start() deliberately delayed to simulate the phase-2 await seam).
+    const a = collector();
+    const attA = (await registry.attach(CHAT, false, undefined, a.cb))!;
+    // B: live (started) — its delivery must be unaffected by A's overflow.
+    const b = collector();
+    const attB = (await registry.attach(CHAT, false, undefined, b.cb))!;
+    attB.start();
+
+    const oneMb = 'x'.repeat(1024 * 1024);
+    // 9 x 1MB = 9MB > 8MB per-subscriber cap; A's pending overflows, B streams live.
+    for (let i = 0; i < 9; i++) src.push(oneMb + i);
+    await flush();
+
+    const entry = (registry as any).entries.get(CHAT);
+    // A was dropped from the subscriber set on overflow; B (started) remains.
+    expect(entry.subscribers.size).toBe(1);
+    expect(a.frames).toEqual([]); // paused + overflowed: nothing was delivered
+    // B received every frame live (delivery unaffected by A's overflow).
+    expect(b.frames).toHaveLength(9);
+
+    // A's start() (arriving late) degrades to an immediate end, not a partial replay.
+    attA.start();
+    expect(a.frames).toEqual([]);
+    expect(a.ended()).toBe(1);
+  });
+
+  it('open() over a LIVE entry ends started subscribers exactly once and a late done does not touch the new entry (invariant 3)', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+    src.push('a');
+    await flush();
+
+    const c = collector();
+    const att = (await registry.attach(CHAT, false, undefined, c.cb))!;
+    att.start(); // started subscriber on run-1
+
+    // run-2 starts on the same chat while run-1's tee is still reading.
+    registry.open(CHAT, 'run-2');
+    expect(c.ended()).toBe(1); // exactly one onEnd from the replace
+
+    const newEntry = (registry as any).entries.get(CHAT);
+    expect(newEntry.runId).toBe('run-2');
+    expect(newEntry.finished).toBe(false);
+
+    // The old tee now completes: its late done must NOT double-end nor delete the
+    // new entry.
+    src.push('b');
+    src.close();
+    await flush();
+    expect(c.ended()).toBe(1); // still exactly one
+    const still = (registry as any).entries.get(CHAT);
+    expect(still).toBe(newEntry);
+    expect(still.runId).toBe('run-2');
+  });
+
+  it('bind with a foreign runId is a no-op (invariant 1)', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'WRONG-run', 'assist-x', src.stream);
+    src.push('a');
+    await flush();
+    const entry = (registry as any).entries.get(CHAT);
+    // Frames were NOT ingested (bind bailed), assistantMessageId untouched.
+    expect(entry.frames).toEqual([]);
+    expect(entry.assistantMessageId).toBeUndefined();
+  });
+
+  it('abortEntry with a foreign runId is a no-op (invariant 1)', async () => {
+    registry.open(CHAT, 'run-1');
+    registry.abortEntry(CHAT, 'WRONG-run');
+    const entry = (registry as any).entries.get(CHAT);
+    expect(entry.finished).toBe(false);
+  });
+
+  it('a throwing onFrame ejects only that subscriber; the ingest loop stays alive', async () => {
+    registry.open(CHAT, 'run-1');
+    const src = makePushStream();
+    registry.bind(CHAT, 'run-1', 'assist-1', src.stream);
+
+    const bad = collector();
+    const badAtt = (await registry.attach(CHAT, false, undefined, {
+      onFrame: () => {
+        throw new Error('boom');
+      },
+      onEnd: bad.cb.onEnd,
+    }))!;
+    badAtt.start();
+
+    const good = collector();
+    const goodAtt = (await registry.attach(CHAT, false, undefined, good.cb))!;
+    goodAtt.start();
+
+    src.push('a'); // bad throws on this frame -> ejected
+    src.push('b'); // good still receives both
+    await flush();
+
+    const entry = (registry as any).entries.get(CHAT);
+    expect(entry.subscribers.size).toBe(1); // bad ejected, good remains
+    expect(good.frames).toEqual(['a', 'b']);
+  });
+});
+
+/**
+ * Retention + replace timer behavior. Fake timers, and entries are finalized via
+ * the synchronous abortEntry() path so no stream pump / microtask juggling is
+ * needed.
+ */
+describe('AiChatStreamRegistryService retention timers', () => {
+  const CHAT = 'chat-r';
+  let registry: AiChatStreamRegistryService;
+
+  beforeEach(() => {
+    jest.useFakeTimers();
+    registry = new AiChatStreamRegistryService();
+    jest.spyOn((registry as any).logger, 'warn').mockImplementation(() => {});
+  });
+
+  afterEach(() => {
+    registry.onModuleDestroy();
+    jest.useRealTimers();
+  });
+
+  it('a finished entry is removed after the retention window', () => {
+    registry.open(CHAT, 'run-1');
+    registry.abortEntry(CHAT, 'run-1'); // finalize -> retention armed
+    expect((registry as any).entries.get(CHAT)).toBeDefined();
+    jest.advanceTimersByTime(RUN_STREAM_RETAIN_FINISHED_MS + 1);
+    expect((registry as any).entries.get(CHAT)).toBeUndefined();
+  });
+
+  it('retention deletes ONLY its own entry (invariant 2)', () => {
+    registry.open(CHAT, 'run-1');
+    registry.abortEntry(CHAT, 'run-1'); // arm retention for entry A
+    // Simulate the race where the key was replaced without clearing A's timer.
+    const sentinel = { marker: true };
+    (registry as any).entries.set(CHAT, sentinel);
+    jest.advanceTimersByTime(RUN_STREAM_RETAIN_FINISHED_MS + 1);
+    // A's timer saw entries.get(CHAT) !== A, so it did NOT delete the successor.
+    expect((registry as any).entries.get(CHAT)).toBe(sentinel);
+  });
+
+  it('open() over a retained entry clears its timer and the successor survives', () => {
+    registry.open(CHAT, 'run-1');
+    registry.abortEntry(CHAT, 'run-1'); // retained, timer armed
+    const clearSpy = jest.spyOn(global, 'clearTimeout');
+    registry.open(CHAT, 'run-2'); // must clear run-1's retain timer
+    expect(clearSpy).toHaveBeenCalled();
+    jest.advanceTimersByTime(RUN_STREAM_RETAIN_FINISHED_MS + 1);
+    const entry = (registry as any).entries.get(CHAT);
+    expect(entry).toBeDefined();
+    expect(entry.runId).toBe('run-2');
+  });
+});

apps/server/src/core/ai-chat/ai-chat.controller.attach.spec.ts

@@ -0,0 +1,423 @@
+import { ForbiddenException } from '@nestjs/common';
+import { AiChatController } from './ai-chat.controller';
+import type {
+  RunStreamAttachment,
+  RunStreamCallbacks,
+} from './ai-chat-stream-registry.service';
+import { SUBSCRIBER_MAX_BUFFERED_BYTES } from './ai-chat-stream-registry.service';
+import type { User, Workspace } from '@docmost/db/types/entity.types';
+
+/**
+ * Wiring spec for the #184 phase 1.5 attach endpoint
+ * (`GET /ai-chat/runs/:chatId/stream`). Owner-gated via assertOwnedChat; the
+ * registry is mocked so this exercises ONLY the controller's replay/live/204/
+ * cleanup wiring against a fake raw socket. Constructor order is (aiChatService,
+ * aiChatRunService, aiChatRepo, aiChatMessageRepo, aiTranscription, pageRepo,
+ * streamRegistry, environment).
+ */
+describe('AiChatController attach endpoint (#184 phase 1.5)', () => {
+  const user = { id: 'u1' } as User;
+  const workspace = { id: 'ws1' } as Workspace;
+
+  function makeRawRes() {
+    const raw: any = {
+      writableEnded: false,
+      writableLength: 0,
+      destroyed: false,
+      written: [] as string[],
+      head: null as any,
+      write: jest.fn((f: string) => {
+        raw.written.push(f);
+        return true;
+      }),
+      writeHead: jest.fn((code: number, headers: any) => {
+        raw.head = { code, headers };
+        return raw;
+      }),
+      flushHeaders: jest.fn(),
+      end: jest.fn(() => {
+        raw.writableEnded = true;
+      }),
+      destroy: jest.fn(() => {
+        raw.destroyed = true;
+      }),
+      on: jest.fn(),
+      once: jest.fn(),
+    };
+    const res: any = {
+      raw,
+      status: jest.fn(() => res),
+      send: jest.fn(),
+      hijack: jest.fn(),
+    };
+    return { res, raw };
+  }
+
+  function makeReq(destroyed = false) {
+    const handlers: Record<string, () => void> = {};
+    const raw: any = {
+      destroyed,
+      once: jest.fn((ev: string, fn: () => void) => {
+        handlers[ev] = fn;
+      }),
+    };
+    return { req: { raw } as any, raw, fireClose: () => handlers['close']?.() };
+  }
+
+  function makeAttachment(
+    over: Partial<RunStreamAttachment> = {},
+  ): RunStreamAttachment {
+    return {
+      replay: [],
+      finished: false,
+      start: jest.fn(),
+      unsubscribe: jest.fn(),
+      ...over,
+    };
+  }
+
+  function makeController(opts: {
+    chat?: unknown;
+    attachment?: RunStreamAttachment | null;
+  }) {
+    const aiChatRepo = { findById: jest.fn().mockResolvedValue(opts.chat) };
+    let capturedCb: RunStreamCallbacks | undefined;
+    const streamRegistry = {
+      attach: jest.fn(
+        (
+          _chatId: string,
+          _live: boolean,
+          _anchor: string | undefined,
+          cb: RunStreamCallbacks,
+        ) => {
+          capturedCb = cb;
+          return Promise.resolve(
+            opts.attachment === undefined ? makeAttachment() : opts.attachment,
+          );
+        },
+      ),
+    };
+    const environment = { isAiChatResumableStreamEnabled: () => true };
+    const controller = new AiChatController(
+      {} as never, // aiChatService
+      {} as never, // aiChatRunService
+      aiChatRepo as never,
+      {} as never, // aiChatMessageRepo
+      {} as never, // aiTranscription
+      {} as never, // pageRepo
+      streamRegistry as never,
+      environment as never,
+    );
+    return {
+      controller,
+      aiChatRepo,
+      streamRegistry,
+      getCb: () => capturedCb!,
+    };
+  }
+
+  const owned = { id: 'c1', creatorId: 'u1' };
+
+  it('owner-gates: a foreign chat throws ForbiddenException and never attaches', async () => {
+    const { controller, streamRegistry } = makeController({
+      chat: { id: 'c1', creatorId: 'someone-else' },
+    });
+    const { res } = makeRawRes();
+    const { req } = makeReq();
+    await expect(
+      controller.attachRunStream(
+        'c1',
+        undefined,
+        undefined,
+        req,
+        res,
+        user,
+        workspace,
+      ),
+    ).rejects.toBeInstanceOf(ForbiddenException);
+    expect(streamRegistry.attach).not.toHaveBeenCalled();
+  });
+
+  it('answers 204 when the registry has nothing to resume (no entry / finished / anchor-mismatch)', async () => {
+    const { controller } = makeController({ chat: owned, attachment: null });
+    const { res } = makeRawRes();
+    const { req } = makeReq();
+    await controller.attachRunStream(
+      'c1',
+      undefined,
+      undefined,
+      req,
+      res,
+      user,
+      workspace,
+    );
+    expect(res.status).toHaveBeenCalledWith(204);
+    expect(res.send).toHaveBeenCalled();
+    expect(res.hijack).not.toHaveBeenCalled();
+  });
+
+  it('threads expect=live and anchor through to the registry', async () => {
+    const { controller, streamRegistry } = makeController({
+      chat: owned,
+      attachment: null,
+    });
+    const { res } = makeRawRes();
+    const { req } = makeReq();
+    await controller.attachRunStream(
+      'c1',
+      'live',
+      'anchor-1',
+      req,
+      res,
+      user,
+      workspace,
+    );
+    expect(streamRegistry.attach).toHaveBeenCalledWith(
+      'c1',
+      true,
+      'anchor-1',
+      expect.anything(),
+    );
+  });
+
+  it('passes expect=false when the query is absent', async () => {
+    const { controller, streamRegistry } = makeController({
+      chat: owned,
+      attachment: null,
+    });
+    const { res } = makeRawRes();
+    const { req } = makeReq();
+    await controller.attachRunStream(
+      'c1',
+      undefined,
+      undefined,
+      req,
+      res,
+      user,
+      workspace,
+    );
+    expect(streamRegistry.attach).toHaveBeenCalledWith(
+      'c1',
+      false,
+      undefined,
+      expect.anything(),
+    );
+  });
+
+  it('hijacks, writes headers + replay, registers a close cleanup, then goes live', async () => {
+    const start = jest.fn();
+    const attachment = makeAttachment({
+      replay: ['f1', 'f2'],
+      finished: false,
+      start,
+    });
+    const { controller } = makeController({ chat: owned, attachment });
+    const { res, raw } = makeRawRes();
+    const { req } = makeReq();
+    await controller.attachRunStream(
+      'c1',
+      undefined,
+      undefined,
+      req,
+      res,
+      user,
+      workspace,
+    );
+    expect(res.hijack).toHaveBeenCalled();
+    expect(raw.writeHead).toHaveBeenCalledWith(
+      200,
+      expect.objectContaining({ 'content-type': 'text/event-stream' }),
+    );
+    expect(raw.written).toEqual(['f1', 'f2']); // replay
+    expect(start).toHaveBeenCalled(); // go live after replay
+    expect(req.raw.once).toHaveBeenCalledWith('close', expect.any(Function));
+  });
+
+  it('finished replay ends the response immediately without going live', async () => {
+    const start = jest.fn();
+    const attachment = makeAttachment({
+      replay: ['f1'],
+      finished: true,
+      start,
+    });
+    const { controller } = makeController({ chat: owned, attachment });
+    const { res, raw } = makeRawRes();
+    const { req } = makeReq();
+    await controller.attachRunStream(
+      'c1',
+      'live',
+      'a1',
+      req,
+      res,
+      user,
+      workspace,
+    );
+    expect(raw.written).toEqual(['f1']);
+    expect(raw.end).toHaveBeenCalled();
+    expect(start).not.toHaveBeenCalled(); // finished -> returns before start()
+  });
+
+  it('a close during the awaits (req.raw.destroyed) unsubscribes and writes nothing', async () => {
+    const attachment = makeAttachment({ replay: ['f1'] });
+    const { controller } = makeController({ chat: owned, attachment });
+    const { res, raw } = makeRawRes();
+    const { req } = makeReq(true); // destroyed already at registration time
+    await controller.attachRunStream(
+      'c1',
+      undefined,
+      undefined,
+      req,
+      res,
+      user,
+      workspace,
+    );
+    expect(attachment.unsubscribe).toHaveBeenCalled();
+    expect(raw.writeHead).not.toHaveBeenCalled();
+    expect(raw.written).toEqual([]);
+  });
+
+  it('the registered close handler unsubscribes the attachment', async () => {
+    const attachment = makeAttachment({ replay: [] });
+    const { controller } = makeController({ chat: owned, attachment });
+    const { res } = makeRawRes();
+    const { req, fireClose } = makeReq();
+    await controller.attachRunStream(
+      'c1',
+      undefined,
+      undefined,
+      req,
+      res,
+      user,
+      workspace,
+    );
+    expect(attachment.unsubscribe).not.toHaveBeenCalled();
+    fireClose(); // socket closed
+    expect(attachment.unsubscribe).toHaveBeenCalled();
+  });
+
+  it('onFrame destroys the socket when the buffered length exceeds the cap', async () => {
+    const attachment = makeAttachment({ replay: [] });
+    const { controller, getCb } = makeController({ chat: owned, attachment });
+    const { res, raw } = makeRawRes();
+    const { req } = makeReq();
+    await controller.attachRunStream(
+      'c1',
+      undefined,
+      undefined,
+      req,
+      res,
+      user,
+      workspace,
+    );
+    const cb = getCb();
+    // Normal live frame writes.
+    raw.writableLength = 0;
+    cb.onFrame('live-1');
+    expect(raw.written).toContain('live-1');
+    // A stalled socket over the cap is destroyed instead of buffering.
+    raw.writableLength = SUBSCRIBER_MAX_BUFFERED_BYTES + 1;
+    raw.write.mockClear();
+    cb.onFrame('too-much');
+    expect(raw.destroy).toHaveBeenCalled();
+    expect(raw.write).not.toHaveBeenCalled();
+  });
+});
+
+/**
+ * The begin-hook `open()` flag gate (#184 phase 1.5). `open()` lives ONLY in the
+ * stream() begin-hook, gated on the resumable flag. If it regressed, a flag-off
+ * turn would create an EMPTY registry entry (never bound, never finished) and a
+ * later attach would find a non-null paused attachment -> a hung SSE that never
+ * gets a frame and never ends, instead of a clean 204. These drive stream() only
+ * far enough to capture the runHooks it hands to the service, then invoke the
+ * begin-hook and assert whether the registry was opened.
+ */
+describe('AiChatController begin-hook open() flag gate (#184 phase 1.5)', () => {
+  const user = { id: 'u1' } as User;
+  const workspace = {
+    id: 'ws1',
+    settings: { ai: { chat: true, autonomousRuns: true } },
+  } as unknown as Workspace;
+
+  function makeController(opts: { resumable: boolean }) {
+    let capturedArgs: any;
+    const aiChatService = {
+      resolveRoleForRequest: jest.fn(async () => null),
+      getChatModel: jest.fn(async () => ({})),
+      stream: jest.fn(async (args: any) => {
+        capturedArgs = args;
+      }),
+    };
+    const aiChatRunService = {
+      getActiveForChat: jest.fn(async () => undefined),
+      beginRun: jest.fn(async () => ({
+        runId: 'run-1',
+        signal: new AbortController().signal,
+      })),
+    };
+    const streamRegistry = { open: jest.fn(), attach: jest.fn() };
+    const environment = {
+      isAiChatResumableStreamEnabled: () => opts.resumable,
+    };
+    const controller = new AiChatController(
+      aiChatService as never,
+      aiChatRunService as never,
+      {} as never, // aiChatRepo
+      {} as never, // aiChatMessageRepo
+      {} as never, // aiTranscription
+      {} as never, // pageRepo
+      streamRegistry as never,
+      environment as never,
+    );
+    return {
+      controller,
+      streamRegistry,
+      aiChatRunService,
+      getRunHooks: () => capturedArgs?.runHooks,
+    };
+  }
+
+  function makeReqRes() {
+    const req: any = {
+      raw: { sessionId: 'sess-1', once: jest.fn() },
+      body: {
+        messages: [
+          { id: 'm1', role: 'user', parts: [{ type: 'text', text: 'hi' }] },
+        ],
+      },
+    };
+    const res: any = {
+      raw: { once: jest.fn(), on: jest.fn(), headersSent: false, writableEnded: false },
+      hijack: jest.fn(),
+    };
+    return { req, res };
+  }
+
+  it('flag OFF: the begin-hook does NOT open a registry entry (no hung empty entry)', async () => {
+    const { controller, streamRegistry, aiChatRunService, getRunHooks } =
+      makeController({ resumable: false });
+    const { req, res } = makeReqRes();
+    await controller.stream(req, res, user, workspace);
+
+    const runHooks = getRunHooks();
+    expect(runHooks).toBeDefined();
+    const handle = await runHooks.begin('chat-1');
+    // The run still begins (the durable-run feature is independent of resume)...
+    expect(aiChatRunService.beginRun).toHaveBeenCalled();
+    expect(handle).toEqual({ runId: 'run-1', signal: expect.anything() });
+    // ...but with the flag off the registry entry is NEVER opened.
+    expect(streamRegistry.open).not.toHaveBeenCalled();
+  });
+
+  it('flag ON: the begin-hook opens the registry entry with (chatId, runId)', async () => {
+    const { controller, streamRegistry, getRunHooks } = makeController({
+      resumable: true,
+    });
+    const { req, res } = makeReqRes();
+    await controller.stream(req, res, user, workspace);
+
+    const runHooks = getRunHooks();
+    await runHooks.begin('chat-1');
+    expect(streamRegistry.open).toHaveBeenCalledWith('chat-1', 'run-1');
+  });
+});

apps/server/src/core/ai-chat/ai-chat.controller.bound-chat.spec.ts

@@ -25,6 +25,7 @@ describe('AiChatController.boundChat', () => {
     };
     const controller = new AiChatController(
       {} as never,
+      {} as never, // aiChatRunService
       aiChatRepo as never,
       {} as never,
       {} as never,

apps/server/src/core/ai-chat/ai-chat.controller.export.spec.ts

@@ -53,6 +53,7 @@ describe('AiChatController.export', () => {
     };
     const controller = new AiChatController(
       {} as never,
+      {} as never, // aiChatRunService
       aiChatRepo as never,
       aiChatMessageRepo as never,
       {} as never,

apps/server/src/core/ai-chat/ai-chat.controller.run.spec.ts

@@ -0,0 +1,164 @@
+import { BadRequestException, ForbiddenException } from '@nestjs/common';
+import { AiChatController } from './ai-chat.controller';
+import type { User, Workspace } from '@docmost/db/types/entity.types';
+
+/**
+ * Wiring spec for the #184 run-reconnect / run-stop endpoints
+ * (`POST /ai-chat/run` and `POST /ai-chat/stop`). Both are OWNER-gated via
+ * assertOwnedChat (the requesting user must own the chat) and NOT flag-gated.
+ * Exercised with hand-rolled mocks — no Nest graph, no DB. The controller's
+ * constructor order is (aiChatService, aiChatRunService, aiChatRepo,
+ * aiChatMessageRepo, aiTranscription).
+ */
+describe('AiChatController run endpoints (#184)', () => {
+  const user = { id: 'u1' } as User;
+  const workspace = { id: 'ws1' } as Workspace;
+
+  function makeController(opts: {
+    chat?: unknown; // what aiChatRepo.findById returns (owner-gate)
+    run?: unknown; // getLatestForChat / getRun result
+    activeRun?: unknown; // getActiveForChat result
+    message?: unknown; // aiChatMessageRepo.findById result
+    stopped?: boolean; // requestStop result
+  }) {
+    const aiChatRunService = {
+      getLatestForChat: jest.fn().mockResolvedValue(opts.run),
+      getRun: jest.fn().mockResolvedValue(opts.run),
+      getActiveForChat: jest.fn().mockResolvedValue(opts.activeRun),
+      requestStop: jest.fn().mockResolvedValue(opts.stopped ?? false),
+    };
+    const aiChatRepo = {
+      findById: jest.fn().mockResolvedValue(opts.chat),
+    };
+    const aiChatMessageRepo = {
+      findById: jest.fn().mockResolvedValue(opts.message),
+    };
+    const controller = new AiChatController(
+      {} as never, // aiChatService
+      aiChatRunService as never,
+      aiChatRepo as never,
+      aiChatMessageRepo as never,
+      {} as never, // aiTranscription
+      {} as never, // pageRepo
+    );
+    return { controller, aiChatRunService, aiChatRepo, aiChatMessageRepo };
+  }
+
+  describe('POST /ai-chat/run (getRun)', () => {
+    it('owner-gates: a chat the user does not own throws ForbiddenException', async () => {
+      const { controller, aiChatRunService } = makeController({
+        chat: { id: 'c1', creatorId: 'someone-else' },
+      });
+      await expect(
+        controller.getRun({ chatId: 'c1' }, user, workspace),
+      ).rejects.toBeInstanceOf(ForbiddenException);
+      // It must NOT reach the run lookup once the owner-gate fails.
+      expect(aiChatRunService.getLatestForChat).not.toHaveBeenCalled();
+    });
+
+    it('returns { run: null, message: null } when the chat has never had a run', async () => {
+      const { controller, aiChatRunService } = makeController({
+        chat: { id: 'c1', creatorId: 'u1' },
+        run: undefined,
+      });
+      const res = await controller.getRun({ chatId: 'c1' }, user, workspace);
+      expect(res).toEqual({ run: null, message: null });
+      expect(aiChatRunService.getLatestForChat).toHaveBeenCalledWith(
+        'c1',
+        'ws1',
+      );
+    });
+
+    it('returns the run and its projected assistant message', async () => {
+      const run = { id: 'run-1', chatId: 'c1', assistantMessageId: 'm1' };
+      const message = { id: 'm1', role: 'assistant' };
+      const { controller, aiChatMessageRepo } = makeController({
+        chat: { id: 'c1', creatorId: 'u1' },
+        run,
+        message,
+      });
+      const res = await controller.getRun({ chatId: 'c1' }, user, workspace);
+      expect(res).toEqual({ run, message });
+      expect(aiChatMessageRepo.findById).toHaveBeenCalledWith('m1', 'ws1');
+    });
+
+    it('returns message: null when the run has no linked assistant message', async () => {
+      const run = { id: 'run-1', chatId: 'c1', assistantMessageId: null };
+      const { controller, aiChatMessageRepo } = makeController({
+        chat: { id: 'c1', creatorId: 'u1' },
+        run,
+      });
+      const res = await controller.getRun({ chatId: 'c1' }, user, workspace);
+      expect(res).toEqual({ run, message: null });
+      expect(aiChatMessageRepo.findById).not.toHaveBeenCalled();
+    });
+  });
+
+  describe('POST /ai-chat/stop (stopRun)', () => {
+    it('throws BadRequestException when neither runId nor chatId is given', async () => {
+      const { controller } = makeController({});
+      await expect(
+        controller.stopRun({}, user, workspace),
+      ).rejects.toBeInstanceOf(BadRequestException);
+    });
+
+    it('stops by runId: owner-gates via the run’s chat, then requests the stop', async () => {
+      const { controller, aiChatRunService, aiChatRepo } = makeController({
+        run: { id: 'run-1', chatId: 'c1' },
+        chat: { id: 'c1', creatorId: 'u1' },
+        stopped: true,
+      });
+      const res = await controller.stopRun({ runId: 'run-1' }, user, workspace);
+      expect(res).toEqual({ stopped: true });
+      expect(aiChatRunService.getRun).toHaveBeenCalledWith('run-1', 'ws1');
+      expect(aiChatRepo.findById).toHaveBeenCalledWith('c1', 'ws1');
+      expect(aiChatRunService.requestStop).toHaveBeenCalledWith('run-1', 'ws1');
+    });
+
+    it('stops by runId: a foreign run’s chat throws ForbiddenException (no stop)', async () => {
+      const { controller, aiChatRunService } = makeController({
+        run: { id: 'run-1', chatId: 'c1' },
+        chat: { id: 'c1', creatorId: 'someone-else' },
+      });
+      await expect(
+        controller.stopRun({ runId: 'run-1' }, user, workspace),
+      ).rejects.toBeInstanceOf(ForbiddenException);
+      expect(aiChatRunService.requestStop).not.toHaveBeenCalled();
+    });
+
+    it('stops by runId: an unknown run reports { stopped: false }', async () => {
+      const { controller, aiChatRunService } = makeController({
+        run: undefined,
+      });
+      const res = await controller.stopRun({ runId: 'gone' }, user, workspace);
+      expect(res).toEqual({ stopped: false });
+      expect(aiChatRunService.requestStop).not.toHaveBeenCalled();
+    });
+
+    it('stops by chatId: owner-gates, resolves the active run, requests the stop', async () => {
+      const { controller, aiChatRunService, aiChatRepo } = makeController({
+        chat: { id: 'c1', creatorId: 'u1' },
+        activeRun: { id: 'run-9' },
+        stopped: true,
+      });
+      const res = await controller.stopRun({ chatId: 'c1' }, user, workspace);
+      expect(res).toEqual({ stopped: true });
+      expect(aiChatRepo.findById).toHaveBeenCalledWith('c1', 'ws1');
+      expect(aiChatRunService.getActiveForChat).toHaveBeenCalledWith(
+        'c1',
+        'ws1',
+      );
+      expect(aiChatRunService.requestStop).toHaveBeenCalledWith('run-9', 'ws1');
+    });
+
+    it('stops by chatId: reports { stopped: false } when no run is active', async () => {
+      const { controller, aiChatRunService } = makeController({
+        chat: { id: 'c1', creatorId: 'u1' },
+        activeRun: undefined,
+      });
+      const res = await controller.stopRun({ chatId: 'c1' }, user, workspace);
+      expect(res).toEqual({ stopped: false });
+      expect(aiChatRunService.requestStop).not.toHaveBeenCalled();
+    });
+  });
+});

apps/server/src/core/ai-chat/ai-chat.controller.ts

@@ -1,13 +1,18 @@
 import {
   BadRequestException,
   Body,
+  ConflictException,
   Controller,
   ForbiddenException,
+  Get,
   HttpCode,
   HttpException,
   HttpStatus,
   Logger,
+  Param,
+  ParseUUIDPipe,
   Post,
+  Query,
   Req,
   Res,
   ServiceUnavailableException,
@@ -20,7 +25,13 @@ import { JwtAuthGuard } from '../../common/guards/jwt-auth.guard';
 import { AuthUser } from '../../common/decorators/auth-user.decorator';
 import { AuthWorkspace } from '../../common/decorators/auth-workspace.decorator';
 import { SkipTransform } from '../../common/decorators/skip-transform.decorator';
-import { AiChat, User, Workspace } from '@docmost/db/types/entity.types';
+import {
+  AiChat,
+  AiChatMessage,
+  AiChatRun,
+  User,
+  Workspace,
+} from '@docmost/db/types/entity.types';
 import { PaginationOptions } from '@docmost/db/pagination/pagination-options';
 import { AiChatRepo } from '@docmost/db/repos/ai-chat/ai-chat.repo';
 import { AiChatMessageRepo } from '@docmost/db/repos/ai-chat/ai-chat-message.repo';
@@ -28,7 +39,12 @@ import { PageRepo } from '@docmost/db/repos/page/page.repo';
 import { UserThrottlerGuard } from '../../integrations/throttle/user-throttler.guard';
 import { AI_CHAT_THROTTLER } from '../../integrations/throttle/throttler-names';
 import { FileInterceptor } from '../../common/interceptors/file.interceptor';
-import { AiChatService, AiChatStreamBody } from './ai-chat.service';
+import {
+  AiChatRunHooks,
+  AiChatService,
+  AiChatStreamBody,
+} from './ai-chat.service';
+import { AiChatRunService } from './ai-chat-run.service';
 import { AiTranscriptionService } from './ai-transcription.service';
 import {
   BoundChatDto,
@@ -36,10 +52,18 @@ import {
   ExportChatDto,
   GeneratePageTitleDto,
   GetChatMessagesDto,
+  GetRunDto,
   RenameChatDto,
+  StopRunDto,
 } from './dto/ai-chat.dto';
 import { describeProviderError } from '../../integrations/ai/ai-error.util';
 import { buildChatMarkdown } from './chat-markdown.util';
+import {
+  AiChatStreamRegistryService,
+  SUBSCRIBER_MAX_BUFFERED_BYTES,
+} from './ai-chat-stream-registry.service';
+import { startSseHeartbeat } from './sse-resilience';
+import { EnvironmentService } from '../../integrations/environment/environment.service';
 
 /**
  * Per-user AI chat API (§6.1). Routes are POST to match this codebase's
@@ -53,10 +77,16 @@ export class AiChatController {
 
   constructor(
     private readonly aiChatService: AiChatService,
+    private readonly aiChatRunService: AiChatRunService,
     private readonly aiChatRepo: AiChatRepo,
     private readonly aiChatMessageRepo: AiChatMessageRepo,
     private readonly aiTranscription: AiTranscriptionService,
     private readonly pageRepo: PageRepo,
+    // #184 phase 1.5. OPTIONAL so existing positional constructions (controller
+    // specs) compile unchanged; Nest always injects the real providers in
+    // production. Only touched on the resumable-stream (flag-on) path.
+    private readonly streamRegistry?: AiChatStreamRegistryService,
+    private readonly environment?: EnvironmentService,
   ) {}
 
   /** List the requesting user's chats in this workspace (paginated). */
@@ -149,6 +179,171 @@ export class AiChatController {
     return { markdown };
   }
 
+  /**
+   * Reconnect to the latest run of a chat (#184 phase 1). Returns the run's
+   * persisted lifecycle state ({ status, error, stepCount, timings, ... }) plus
+   * the assistant message it projects (the partial/final output) — the DB is the
+   * source of truth, so this works for an in-flight run (the browser dropped, the
+   * run kept going) and a finished one alike. Owner-gated via assertOwnedChat.
+   * `{ run: null }` when the chat has never had a run.
+   */
+  @HttpCode(HttpStatus.OK)
+  @Post('run')
+  async getRun(
+    @Body() dto: GetRunDto,
+    @AuthUser() user: User,
+    @AuthWorkspace() workspace: Workspace,
+  ): Promise<{ run: AiChatRun | null; message: AiChatMessage | null }> {
+    await this.assertOwnedChat(dto.chatId, user, workspace);
+    const run = await this.aiChatRunService.getLatestForChat(
+      dto.chatId,
+      workspace.id,
+    );
+    if (!run) return { run: null, message: null };
+    const message = run.assistantMessageId
+      ? await this.aiChatMessageRepo.findById(
+          run.assistantMessageId,
+          workspace.id,
+        )
+      : undefined;
+    return { run, message: message ?? null };
+  }
+
+  /**
+   * Explicitly STOP an agent run (#184 phase 1) — the user pressed Stop. This is
+   * the ONLY thing that ends a detached run; a browser disconnect deliberately
+   * does not. Target by `runId` (from the streamed start metadata) or by `chatId`
+   * (stop whatever run is active on it). Owner-gated. Returns
+   * `{ stopped }` — false when there was nothing active to stop.
+   */
+  @HttpCode(HttpStatus.OK)
+  @Post('stop')
+  async stopRun(
+    @Body() dto: StopRunDto,
+    @AuthUser() user: User,
+    @AuthWorkspace() workspace: Workspace,
+  ): Promise<{ stopped: boolean }> {
+    let runId = dto.runId;
+    if (!runId && !dto.chatId) {
+      throw new BadRequestException('runId or chatId is required');
+    }
+    if (runId) {
+      // Resolve the run to its chat and owner-gate via that chat.
+      const run = await this.aiChatRunService.getRun(runId, workspace.id);
+      if (!run) return { stopped: false };
+      await this.assertOwnedChat(run.chatId, user, workspace);
+    } else {
+      await this.assertOwnedChat(dto.chatId!, user, workspace);
+      const active = await this.aiChatRunService.getActiveForChat(
+        dto.chatId!,
+        workspace.id,
+      );
+      if (!active) return { stopped: false };
+      runId = active.id;
+    }
+    const stopped = await this.aiChatRunService.requestStop(
+      runId,
+      workspace.id,
+    );
+    return { stopped };
+  }
+
+  /**
+   * Attach to a chat's live run stream (#184 phase 1.5). A late/reloaded tab
+   * replays the frames buffered so far and then follows the live tail as a normal
+   * streamer. Owner-gated via assertOwnedChat (same gate as getRun). When there is
+   * nothing to resume — no entry, a finished run without expect=live, an
+   * overflowed buffer, or an anchor that pins a DIFFERENT run — the endpoint
+   * answers 204, the ONLY "nothing to resume" signal the AI SDK's reconnect
+   * accepts (it maps 204 to a silent no-op). With AI_CHAT_RESUMABLE_STREAM off the
+   * registry is never populated, so attach always 204s.
+   *
+   * `expect=live` opts into replaying a finished-but-retained run (safe only when
+   * the client stripped the streaming tail); `anchor` is the client's assistant
+   * row id, which must match this run's (invariant 6) or a foreign run's
+   * transcript would be replayed into the store.
+   */
+  @SkipTransform()
+  @UseGuards(JwtAuthGuard, UserThrottlerGuard)
+  @Throttle({ [AI_CHAT_THROTTLER]: { limit: 60, ttl: 60000 } })
+  @Get('runs/:chatId/stream')
+  async attachRunStream(
+    @Param('chatId', new ParseUUIDPipe()) chatId: string,
+    @Query('expect') expect: string | undefined,
+    @Query('anchor') anchor: string | undefined,
+    @Req() req: FastifyRequest,
+    @Res() res: FastifyReply,
+    @AuthUser() user: User,
+    @AuthWorkspace() workspace: Workspace,
+  ): Promise<void> {
+    await this.assertOwnedChat(chatId, user, workspace); // same gate as getRun
+    let stopHeartbeat: () => void = () => undefined;
+    const attachment = await this.streamRegistry?.attach(
+      chatId,
+      expect === 'live',
+      anchor,
+      {
+        onFrame: (frame) => {
+          // Backpressure guard: 2x the replay cap, so the initial replay burst
+          // alone can never trip it; only a genuinely stalled socket can.
+          try {
+            if (res.raw.writableLength > SUBSCRIBER_MAX_BUFFERED_BYTES) {
+              res.raw.destroy(); // 'close' fires -> unsubscribe below
+              return;
+            }
+            if (!res.raw.writableEnded) res.raw.write(frame);
+          } catch {
+            res.raw.destroy();
+          }
+        },
+        onEnd: () => {
+          stopHeartbeat();
+          if (!res.raw.writableEnded) res.raw.end();
+        },
+      },
+    );
+    if (!attachment) {
+      res.status(204).send(); // the ONLY "nothing to resume" signal the SDK accepts
+      return;
+    }
+    res.hijack();
+    // Cleanup BEFORE any write (invariant 5): a torn-down socket must not orphan
+    // a paused subscriber whose pending queue would buffer the whole run.
+    req.raw.once('close', () => {
+      attachment.unsubscribe();
+      stopHeartbeat();
+    });
+    // A close emitted DURING the awaits above was missed by the listener — check.
+    // (Healthy pending GETs have req.raw.destroyed === false, so no false
+    // positives; returning without end() is fine — the socket is gone.)
+    if (req.raw.destroyed) {
+      attachment.unsubscribe();
+      return;
+    }
+    res.raw.on('error', () => undefined);
+    try {
+      res.raw.writeHead(200, {
+        'content-type': 'text/event-stream',
+        'cache-control': 'no-cache',
+        'x-vercel-ai-ui-message-stream': 'v1',
+        'x-accel-buffering': 'no',
+        // deliberately NO Connection/Keep-Alive (hop-by-hop; Safari/HTTP2)
+      });
+      res.raw.flushHeaders?.();
+      for (const frame of attachment.replay) res.raw.write(frame);
+      if (attachment.finished) {
+        res.raw.end();
+        return;
+      }
+      stopHeartbeat = startSseHeartbeat(res.raw, 15_000);
+      attachment.start(); // drain pending accumulated during replay, go live
+    } catch {
+      attachment.unsubscribe();
+      stopHeartbeat();
+      res.raw.destroy();
+    }
+  }
+
   /** Rename a chat. */
   @HttpCode(HttpStatus.OK)
   @Post('rename')
@@ -200,11 +395,20 @@ export class AiChatController {
     @AuthWorkspace() workspace: Workspace,
   ): Promise<void> {
     // A7 gate: the workspace must have AI chat explicitly enabled.
-    const settings = (workspace.settings ?? {}) as { ai?: { chat?: boolean } };
+    const settings = (workspace.settings ?? {}) as {
+      ai?: { chat?: boolean; autonomousRuns?: boolean };
+    };
     if (settings.ai?.chat !== true) {
       throw new ForbiddenException('AI chat is disabled');
     }
 
+    // #184 phase 1 flag: when ON, the turn becomes a detached, durable RUN — its
+    // lifecycle is tracked in ai_chat_runs, a browser disconnect no longer aborts
+    // it, and only an explicit /ai-chat/stop ends it. When OFF (the default) the
+    // turn is socket-bound exactly as before, so existing deployments are
+    // unaffected.
+    const autonomousRuns = settings.ai?.autonomousRuns === true;
+
     const sessionId = (req.raw as { sessionId?: string }).sessionId;
     if (!sessionId) {
       // The chat requires an interactive session to mint loopback tokens
@@ -228,6 +432,70 @@ export class AiChatController {
     // HttpException) instead of breaking mid-stream.
     const model = await this.aiChatService.getChatModel(workspace.id, role);
 
+    // #184: one active run per chat. For an EXISTING chat reject a concurrent
+    // start with a clean 409 BEFORE hijack (the common double-submit / second-tab
+    // case), so the user gets JSON, not a mid-stream error. A brand-new chat
+    // (no chatId) cannot have a prior run, and the DB partial unique index is the
+    // backstop against any race that slips past this check.
+    if (autonomousRuns && body.chatId) {
+      const active = await this.aiChatRunService.getActiveForChat(
+        body.chatId,
+        workspace.id,
+      );
+      if (active) {
+        throw new ConflictException({
+          message: 'An agent run is already in progress for this chat',
+          code: 'A_RUN_ALREADY_ACTIVE',
+        });
+      }
+    }
+
+    // Run-lifecycle hooks (#184), only when the flag is on. They wrap the turn in
+    // a durable run whose abort is governed by the run (explicit stop), persist
+    // its progress, and settle its terminal status — see AiChatRunService.
+    const runHooks: AiChatRunHooks | undefined = autonomousRuns
+      ? {
+          begin: async (chatId) => {
+            const handle = await this.aiChatRunService.beginRun({
+              chatId,
+              workspaceId: workspace.id,
+              userId: user.id,
+              trigger: 'user',
+            });
+            // #184 phase 1.5: register the run-stream entry at BEGIN (before any
+            // frame) so a tab that attaches in the begin->seed window finds an
+            // entry to wait on. Gated on AI_CHAT_RESUMABLE_STREAM: with the flag
+            // off nothing is registered and attach always 204s.
+            if (
+              handle?.runId &&
+              this.environment?.isAiChatResumableStreamEnabled?.()
+            ) {
+              this.streamRegistry?.open(chatId, handle.runId);
+            }
+            return handle;
+          },
+          onAssistantSeeded: (runId, messageId) =>
+            this.aiChatRunService.linkAssistantMessage(
+              runId,
+              workspace.id,
+              messageId,
+            ),
+          onStep: (runId, stepCount) =>
+            void this.aiChatRunService.recordStep(
+              runId,
+              workspace.id,
+              stepCount,
+            ),
+          onSettled: (runId, status, error) =>
+            this.aiChatRunService.finalizeRun(
+              runId,
+              workspace.id,
+              status,
+              error,
+            ),
+        }
+      : undefined;
+
     // Abort the agent loop when the client disconnects. `close` also fires on
     // normal completion, so only abort when the response has not finished
     // writing (a genuine disconnect). `once` fires at most once and self-removes;
@@ -242,18 +510,44 @@ export class AiChatController {
       // A genuine disconnect leaves the response unfinished (unlike a normal
       // completion, which also fires `close`). Such a drop — e.g. a reverse
       // proxy cutting the SSE mid-answer — is otherwise invisible server-side,
-      // so log it here before aborting the agent loop.
+      // so log it here.
       if (!res.raw.writableEnded) {
-        this.logger.warn(
-          `AI chat stream: client disconnected before completion; aborting turn ` +
-            `(elapsed=${Date.now() - reqStartedAt}ms since request received)`,
-        );
-        controller.abort();
+        if (autonomousRuns) {
+          // #184: the turn is a DETACHED run. A disconnect must NOT abort it —
+          // the run keeps executing and persisting server-side; the client
+          // reconnects via /ai-chat/run (or re-stops via /ai-chat/stop). Log only.
+          this.logger.log(
+            `AI chat stream: client disconnected; run continues server-side ` +
+              `(elapsed=${Date.now() - reqStartedAt}ms since request received)`,
+          );
+        } else {
+          this.logger.warn(
+            `AI chat stream: client disconnected before completion; aborting turn ` +
+              `(elapsed=${Date.now() - reqStartedAt}ms since request received)`,
+          );
+          controller.abort();
+        }
       }
     };
     req.raw.once('close', onClose);
     res.raw.once('finish', () => req.raw.off('close', onClose));
 
+    // #184: in detached mode the turn is NOT aborted on disconnect, so the SDK's
+    // pipe keeps writing to a socket the client may have dropped — for the rest of
+    // the (continuing) run. A write to the dead socket can emit an 'error' on the
+    // raw response; without a listener that surfaces as an unhandled error event.
+    // Swallow it (the run continues server-side regardless). Legacy mode aborts on
+    // disconnect, so it does not need this and keeps its exact prior behavior.
+    if (autonomousRuns) {
+      res.raw.on('error', (err) => {
+        this.logger.debug(
+          `AI chat detached stream: post-disconnect socket error swallowed: ${
+            err instanceof Error ? err.message : String(err)
+          }`,
+        );
+      });
+    }
+
     // Commit to streaming: hijack so Fastify stops managing the response and
     // the AI SDK can write the UI-message stream directly to the Node socket.
     res.hijack();
@@ -268,15 +562,32 @@ export class AiChatController {
         signal: controller.signal,
         model,
         role,
+        // #184: present only when the flag is on; wraps the turn in a durable run.
+        runHooks,
       });
     } catch (err) {
-      // Any failure AFTER hijack can no longer send a clean JSON error, so emit
-      // a minimal error on the raw socket if nothing has been written yet.
-      this.logger.error('AI chat stream failed', err as Error);
+      // Any failure AFTER hijack can no longer go through Nest's exception
+      // filter, so emit the error on the raw socket if nothing has been written
+      // yet. The lost-the-race 409 (RunAlreadyActiveError -> ConflictException)
+      // is raised by stream() BEFORE it writes a byte, so headers are still
+      // unsent here: honor the HttpException's real status + body (a clean 409),
+      // not a blanket 500. Everything else stays a 500.
+      const isHttp = err instanceof HttpException;
+      if (!isHttp) {
+        this.logger.error('AI chat stream failed', err as Error);
+      }
       if (!res.raw.headersSent) {
-        res.raw.statusCode = 500;
+        const status = isHttp ? err.getStatus() : 500;
+        const payload = isHttp
+          ? err.getResponse()
+          : { error: 'Internal server error' };
+        res.raw.statusCode = status;
         res.raw.setHeader('Content-Type', 'application/json');
-        res.raw.end(JSON.stringify({ error: 'Internal server error' }));
+        res.raw.end(
+          JSON.stringify(
+            typeof payload === 'string' ? { message: payload } : payload,
+          ),
+        );
       } else if (!res.raw.writableEnded) {
         res.raw.end();
       }

apps/server/src/core/ai-chat/ai-chat.generate-page-title.spec.ts

@@ -57,6 +57,7 @@ describe('AiChatController.generatePageTitle', () => {
     const aiChatService = { generatePageTitle: generate };
     const controller = new AiChatController(
       aiChatService as never,
+      {} as never, // aiChatRunService
       {} as never,
       {} as never,
       {} as never,

apps/server/src/core/ai-chat/ai-chat.module.ts

@@ -3,6 +3,8 @@ import { AiModule } from '../../integrations/ai/ai.module';
 import { TokenModule } from '../auth/token.module';
 import { AiChatController } from './ai-chat.controller';
 import { AiChatService } from './ai-chat.service';
+import { AiChatRunService } from './ai-chat-run.service';
+import { AiChatStreamRegistryService } from './ai-chat-stream-registry.service';
 import { AiTranscriptionService } from './ai-transcription.service';
 import { AiChatToolsService } from './tools/ai-chat-tools.service';
 import { EmbeddingModule } from './embedding/embedding.module';
@@ -42,6 +44,8 @@ import { PublicShareChatToolsService } from './tools/public-share-chat-tools.ser
   controllers: [AiChatController, PublicShareChatController],
   providers: [
     AiChatService,
+    AiChatRunService,
+    AiChatStreamRegistryService,
     AiTranscriptionService,
     AiChatToolsService,
     PublicShareChatService,

apps/server/src/core/ai-chat/ai-chat.prompt.spec.ts

@@ -153,6 +153,41 @@ describe('buildSystemPrompt current-page context', () => {
     expect(prompt).not.toContain('pageId:');
   });
 
+  // #388: editor-selection flag. Only a FIXED one-liner is added — the selection
+  // TEXT (untrusted page content) must never reach the prompt.
+  const SELECTION_FLAG = 'currently has text SELECTED on this page';
+
+  it('adds the selection flag when a selection is present with a page', () => {
+    const prompt = buildSystemPrompt({
+      workspace,
+      openedPage: {
+        id: 'pg-123',
+        title: 'Doc',
+        selection: { text: 'SECRET-SELECTED-TEXT', blockIds: ['b1'] },
+      },
+    });
+    expect(prompt).toContain(SELECTION_FLAG);
+    // The selection TEXT itself is NEVER in the prompt.
+    expect(prompt).not.toContain('SECRET-SELECTED-TEXT');
+    expect(prompt).not.toContain('b1');
+  });
+
+  it('omits the selection flag when there is no selection', () => {
+    const prompt = buildSystemPrompt({
+      workspace,
+      openedPage: { id: 'pg-123', title: 'Doc' },
+    });
+    expect(prompt).not.toContain(SELECTION_FLAG);
+  });
+
+  it('omits the selection flag when selection is null', () => {
+    const prompt = buildSystemPrompt({
+      workspace,
+      openedPage: { id: 'pg-123', title: 'Doc', selection: null },
+    });
+    expect(prompt).not.toContain(SELECTION_FLAG);
+  });
+
   it('escapes a malicious opened-page title so it cannot inject tags (F1)', () => {
     const prompt = buildSystemPrompt({
       workspace,

apps/server/src/core/ai-chat/ai-chat.prompt.ts

@@ -156,8 +156,13 @@ export interface BuildSystemPromptInput {
    * has an id, a CONTEXT line is added so the agent can resolve "this page" /
    * "the current page" to that pageId. The page is NOT fetched here — the agent
    * uses its CASL-enforced read/write page tools with the id when needed.
+   *
+   * `selection` (#388) is present only when the user has a non-empty editor
+   * selection; the prompt adds ONLY a fixed one-line flag from it — the
+   * selection TEXT is untrusted page content and stays out of the prompt (it is
+   * surfaced solely via the getCurrentPage tool result).
    */
-  openedPage?: { id?: string; title?: string } | null;
+  openedPage?: { id?: string; title?: string; selection?: object | null } | null;
   /**
    * Admin-authored, per-EXTERNAL-MCP-server guidance ("how/when to use this
    * server's tools"), built by `McpClientsService.toolsFor` for servers that
@@ -309,6 +314,14 @@ export function buildSystemPrompt({
         ? escapeAttr(openedPage.title)
         : 'Untitled';
     context += `\nThe user is currently viewing the page "${title}" (pageId: ${pageId.trim()}). When they refer to "this page", "the current page", or similar, operate on that pageId — use the read/write page tools with it.`;
+    // Editor-selection flag (#388). A FIXED one-liner only — the selection TEXT
+    // is untrusted collaborative-page content and must never enter the prompt; it
+    // is surfaced solely through the getCurrentPage tool result (SAFETY_FRAMEWORK
+    // treats a tool result as data). Nested under the page block so it is added
+    // only alongside a resolved page (a selection cannot outlive its page).
+    if (openedPage?.selection) {
+      context += `\nThe user currently has text SELECTED on this page — call getCurrentPage to see the selection. When they say "this", "here", "the selected text" or similar, they mean that selection.`;
+    }
   }
 
   // Interrupt-resume marker (#198). Added to the context section (inside the

apps/server/src/core/ai-chat/ai-chat.service.lifecycle.spec.ts

@@ -1,5 +1,7 @@
 import { Logger } from '@nestjs/common';
-import { AiChatService } from './ai-chat.service';
+import { AiChatService, AiChatRunHooks } from './ai-chat.service';
+import { AiChatRunService } from './ai-chat-run.service';
+import type { User, Workspace } from '@docmost/db/types/entity.types';
 
 /**
  * Lifecycle unit tests for AiChatService.onModuleInit (#183 crash-recovery
@@ -61,3 +63,99 @@ describe('AiChatService.onModuleInit (startup sweep)', () => {
     expect(String(warnSpy.mock.calls[0][0])).toContain('db unavailable');
   });
 });
+
+/**
+ * #184 CRITICAL run-lifecycle safety net (review fix). A transient failure
+ * AFTER a successful beginRun but BEFORE streamText's terminal callbacks own the
+ * lifecycle must STILL settle the run — otherwise the run row is stuck 'running'
+ * forever (sweepRunning only runs at startup) and the partial unique index + the
+ * controller pre-check 409 every future turn in that chat until a restart. Here
+ * we model the very first bare await after beginRun (the user-message insert)
+ * throwing, wiring the run hooks to a REAL AiChatRunService (mock repo) exactly
+ * as the controller does, and assert the run is settled to 'error' and its
+ * in-memory entry dropped (so a follow-up turn would NOT be 409'd).
+ */
+describe('AiChatService.stream run-lifecycle safety net (#184)', () => {
+  const user = { id: 'u1' } as User;
+  const workspace = { id: 'ws1' } as Workspace;
+
+  afterEach(() => jest.restoreAllMocks());
+
+  it('an exception after beginRun settles the run to error and drops the in-memory entry', async () => {
+    jest.spyOn(Logger.prototype, 'error').mockImplementation(() => undefined);
+
+    // Real run service over a mock repo, so finalizeRun's in-memory bookkeeping
+    // (active.delete) is exercised for real.
+    const runRepo = {
+      insert: jest.fn().mockResolvedValue({ id: 'run-1', status: 'running' }),
+      update: jest.fn().mockResolvedValue({ id: 'run-1' }),
+    };
+    const runService = new AiChatRunService(runRepo as never, { isCloud: () => false } as never);
+
+    // The user-message insert (the first bare await after beginRun) throws.
+    const aiChatMessageRepo = {
+      insert: jest.fn().mockRejectedValue(new Error('insert boom')),
+    };
+    const aiChatRepo = {
+      // Existing chat -> chatId stays, no new-chat insert path.
+      findById: jest.fn().mockResolvedValue({ id: 'chat-1', creatorId: 'u1' }),
+    };
+
+    const service = new AiChatService(
+      {} as never, // ai
+      aiChatRepo as never,
+      aiChatMessageRepo as never,
+      {} as never, // aiChatPageSnapshotRepo
+      {} as never, // aiSettings
+      {} as never, // tools
+      {} as never, // mcpClients
+      {} as never, // aiAgentRoleRepo
+      {} as never, // pageRepo
+      {} as never, // pageAccess
+      {} as never, // environment
+    );
+
+    const runHooks: AiChatRunHooks = {
+      begin: (chatId) =>
+        runService.beginRun({
+          chatId,
+          workspaceId: workspace.id,
+          userId: user.id,
+          trigger: 'user',
+        }),
+      onSettled: (runId, status, error) =>
+        runService.finalizeRun(runId, workspace.id, status, error),
+    };
+
+    await expect(
+      service.stream({
+        user,
+        workspace,
+        sessionId: 'sess',
+        body: {
+          chatId: 'chat-1',
+          messages: [
+            { id: 'm', role: 'user', parts: [{ type: 'text', text: 'hi' }] },
+          ],
+        },
+        res: {} as never,
+        signal: new AbortController().signal,
+        model: {} as never,
+        role: null,
+        runHooks,
+      }),
+    ).rejects.toThrow('insert boom');
+
+    // The run was begun...
+    expect(runRepo.insert).toHaveBeenCalledTimes(1);
+    // ...then settled to a terminal FAILED status by the safety net...
+    expect(runRepo.update).toHaveBeenCalledTimes(1);
+    expect(runRepo.update).toHaveBeenCalledWith(
+      'run-1',
+      'ws1',
+      expect.objectContaining({ status: 'failed' }),
+    );
+    // ...and the in-memory entry is gone, so a follow-up turn is NOT 409'd.
+    expect(runService.isLocallyActive('run-1')).toBe(false);
+  });
+});

apps/server/src/core/ai-chat/ai-chat.service.run-race.spec.ts

@@ -0,0 +1,489 @@
+import { ConflictException, Logger } from '@nestjs/common';
+
+// Mock the AI SDK so we can PROVE no provider call is made for the turn we are
+// about to reject. The race rejection happens at runHooks.begin(), long before
+// any streamText/generateText, so these never resolve a real model.
+jest.mock('ai', () => ({
+  streamText: jest.fn(),
+  generateText: jest.fn(),
+  convertToModelMessages: jest.fn(() => []),
+  stepCountIs: jest.fn(() => () => false),
+}));
+
+import { streamText, generateText } from 'ai';
+import { AiChatService } from './ai-chat.service';
+import { RunAlreadyActiveError } from './ai-chat-run.service';
+
+/**
+ * Race-closure coverage for the "one active run per chat" guard (#184).
+ *
+ * THE BUG: two simultaneous POST /ai-chat/stream on the same chat both pass the
+ * controller's cheap pre-check (TOCTOU), so the loser's run-row INSERT hits the
+ * partial unique index. Previously that 23505 was SWALLOWED and the second turn
+ * streamed UNTRACKED (no runId, not stoppable). THE FIX: beginRun surfaces a
+ * RunAlreadyActiveError and stream() turns it into a 409 BEFORE any AI call —
+ * the second turn never runs.
+ */
+describe('AiChatService.stream — concurrent-run race rejection (#184)', () => {
+  const streamTextMock = streamText as unknown as jest.Mock;
+  const generateTextMock = generateText as unknown as jest.Mock;
+
+  beforeEach(() => {
+    streamTextMock.mockReset();
+    generateTextMock.mockReset();
+  });
+
+  // Minimal service whose only reachable deps before begin() are aiChatRepo
+  // (resolve the existing chat) — everything past begin must remain untouched.
+  function makeService(beginImpl: () => Promise<unknown>) {
+    const aiChatMessageRepo = { insert: jest.fn() };
+    const aiChatRepo = {
+      // An existing chat: stream keeps the supplied chatId and skips creation.
+      findById: jest.fn(async () => ({ id: 'chat-1', workspaceId: 'ws-1' })),
+      insert: jest.fn(),
+    };
+    const svc = new AiChatService(
+      {} as never, // ai
+      aiChatRepo as never,
+      aiChatMessageRepo as never,
+      {} as never, // aiChatPageSnapshotRepo
+      {} as never, // aiSettings
+      {} as never, // tools
+      {} as never, // mcpClients
+      {} as never, // aiAgentRoleRepo
+      {} as never, // pageRepo
+      {} as never, // pageAccess
+      { isAiChatDeferredToolsEnabled: () => false } as never, // environment
+    );
+    const begin = jest.fn(beginImpl);
+    return { svc, begin, aiChatRepo, aiChatMessageRepo };
+  }
+
+  const baseArgs = (begin: jest.Mock) => ({
+    user: { id: 'user-1' } as never,
+    workspace: { id: 'ws-1' } as never,
+    sessionId: 'sess-1',
+    body: { chatId: 'chat-1', messages: [] } as never,
+    res: { raw: {} } as never,
+    signal: new AbortController().signal,
+    model: {} as never,
+    role: null,
+    runHooks: {
+      begin,
+      onAssistantSeeded: jest.fn(),
+      onStep: jest.fn(),
+      onSettled: jest.fn(),
+    } as never,
+  });
+
+  it('rejects the racer with a 409 ConflictException BEFORE any AI call, and never persists an untracked turn', async () => {
+    // begin loses the unique-index race -> RunAlreadyActiveError.
+    const { svc, begin, aiChatMessageRepo } = makeService(() => {
+      throw new RunAlreadyActiveError('chat-1');
+    });
+
+    const promise = svc.stream(baseArgs(begin));
+
+    await expect(promise).rejects.toBeInstanceOf(ConflictException);
+    await promise.catch((err: ConflictException) => {
+      expect(err.getStatus()).toBe(409);
+      expect((err.getResponse() as { code?: string }).code).toBe(
+        'A_RUN_ALREADY_ACTIVE',
+      );
+    });
+
+    // The decisive assertions: the rejected racer spent NO tokens and left NO
+    // untracked turn behind.
+    expect(begin).toHaveBeenCalledTimes(1);
+    expect(streamTextMock).not.toHaveBeenCalled();
+    expect(generateTextMock).not.toHaveBeenCalled();
+    expect(aiChatMessageRepo.insert).not.toHaveBeenCalled();
+  });
+});
+
+/**
+ * F3 — the LOAD-BEARING run-detach wiring: `effectiveSignal = handle.signal`
+ * after runHooks.begin, then `abortSignal: effectiveSignal` passed to streamText.
+ * That single line is what makes a run survive a browser disconnect (the agent
+ * loop's abort is governed by the RUN's signal, not the socket): a regression to
+ * the socket-bound signal would still pass every other test green while silently
+ * breaking Stop + durability. These two tests pin the exact signal streamText
+ * consumes on both paths.
+ */
+describe('AiChatService.stream — abortSignal wiring (#184 F3)', () => {
+  const streamTextMock = streamText as unknown as jest.Mock;
+
+  // A streamText result stub: the post-call drain + pipe are no-ops here; we only
+  // care WHICH abortSignal streamText was handed.
+  function makeStreamResult() {
+    return {
+      consumeStream: jest.fn(),
+      pipeUIMessageStreamToResponse: jest.fn(),
+    };
+  }
+
+  // A raw-response stub sufficient for the post-streamText wiring
+  // (stripStreamingHopByHopHeaders binds writeHead; startSseHeartbeat registers
+  // close/finish listeners; flushHeaders is belt-and-braces).
+  function makeRes() {
+    return {
+      raw: {
+        writeHead: jest.fn(),
+        write: jest.fn(),
+        once: jest.fn(),
+        on: jest.fn(),
+        flushHeaders: jest.fn(),
+        writableEnded: false,
+        destroyed: false,
+      },
+    };
+  }
+
+  // Wire only the deps reached on the way to streamText: resolve the existing
+  // chat, persist the user + seed the assistant row, load (empty) history, the
+  // admin settings, an empty external toolset + Docmost toolset.
+  function makeService() {
+    const aiChatRepo = {
+      findById: jest.fn(async () => ({ id: 'chat-1', workspaceId: 'ws-1' })),
+      insert: jest.fn(),
+    };
+    const aiChatMessageRepo = {
+      insert: jest.fn(async () => ({ id: 'msg-1' })),
+      findAllByChat: jest.fn(async () => []),
+      update: jest.fn(async () => ({ id: 'msg-1' })),
+    };
+    const aiSettings = { resolve: jest.fn(async () => ({})) };
+    const tools = { forUser: jest.fn(async () => ({})) };
+    const mcpClients = {
+      toolsFor: jest.fn(async () => ({
+        tools: {},
+        clients: [],
+        outcomes: [],
+        instructions: [],
+      })),
+    };
+    const svc = new AiChatService(
+      {} as never, // ai
+      aiChatRepo as never,
+      aiChatMessageRepo as never,
+      {} as never, // aiChatPageSnapshotRepo
+      aiSettings as never,
+      tools as never,
+      mcpClients as never,
+      {} as never, // aiAgentRoleRepo
+      {} as never, // pageRepo (openPage undefined -> never touched)
+      {} as never, // pageAccess
+      { isAiChatDeferredToolsEnabled: () => false } as never, // environment
+    );
+    return { svc };
+  }
+
+  const body = {
+    chatId: 'chat-1',
+    messages: [
+      { id: 'm1', role: 'user', parts: [{ type: 'text', text: 'hi' }] },
+    ],
+  };
+
+  beforeEach(() => {
+    streamTextMock.mockReset();
+    streamTextMock.mockImplementation(() => makeStreamResult());
+    jest
+      .spyOn(Logger.prototype, 'log')
+      .mockImplementation(() => undefined as never);
+  });
+
+  afterEach(() => jest.restoreAllMocks());
+
+  it('happy path (run-wrapped): streamText is driven with abortSignal === handle.signal (the RUN signal, NOT the socket)', async () => {
+    const { svc } = makeService();
+    const runController = new AbortController();
+    const runSignal = runController.signal;
+    const socketSignal = new AbortController().signal;
+
+    const begin = jest.fn(async () => ({ runId: 'run-1', signal: runSignal }));
+    await svc.stream({
+      user: { id: 'user-1' } as never,
+      workspace: { id: 'ws-1' } as never,
+      sessionId: 'sess-1',
+      body: body as never,
+      res: makeRes() as never,
+      signal: socketSignal,
+      model: {} as never,
+      role: null,
+      runHooks: {
+        begin,
+        onAssistantSeeded: jest.fn(),
+        onStep: jest.fn(),
+        onSettled: jest.fn(),
+      } as never,
+    });
+
+    expect(begin).toHaveBeenCalledTimes(1);
+    expect(streamTextMock).toHaveBeenCalledTimes(1);
+    // THE assertion: the agent loop's abort is wired to the RUN, so a browser
+    // disconnect (which aborts only `socketSignal`) cannot end the turn.
+    expect(streamTextMock.mock.calls[0][0].abortSignal).toBe(runSignal);
+    expect(streamTextMock.mock.calls[0][0].abortSignal).not.toBe(socketSignal);
+  });
+
+  it('legacy path (no runHooks): streamText is driven with the SOCKET signal', async () => {
+    const { svc } = makeService();
+    const socketSignal = new AbortController().signal;
+
+    await svc.stream({
+      user: { id: 'user-1' } as never,
+      workspace: { id: 'ws-1' } as never,
+      sessionId: 'sess-1',
+      body: body as never,
+      res: makeRes() as never,
+      signal: socketSignal,
+      model: {} as never,
+      role: null,
+      // No runHooks -> the turn stays socket-bound (flag off / default).
+    });
+
+    expect(streamTextMock).toHaveBeenCalledTimes(1);
+    expect(streamTextMock.mock.calls[0][0].abortSignal).toBe(socketSignal);
+  });
+
+  /**
+   * F9 — streamText's TERMINAL callbacks carry the #184 run lifecycle:
+   *   onStepFinish -> runHooks.onStep(runId, stepCount)
+   *   onFinish     -> runHooks.onSettled(runId, 'completed')   (dominant path)
+   *   onAbort      -> runHooks.onSettled(runId, 'aborted')
+   *   onError      -> runHooks.onSettled(runId, 'error', cause)
+   * makeStreamResult() ignores the streamText options, so these callbacks never
+   * fire on their own — a regression in this wiring (esp. the success path) would
+   * strand the run with NO test catching it. Here we CAPTURE the options streamText
+   * was handed and invoke each callback with the real wiring, asserting the run
+   * hooks fire with the right args.
+   */
+  // Drive stream() to the point streamText is called, capturing the options object
+  // (which carries onStepFinish/onFinish/onError/onAbort) and the run hooks.
+  async function captureStreamCallbacks() {
+    const { svc } = makeService();
+    let capturedOpts: any;
+    streamTextMock.mockImplementation((opts: any) => {
+      capturedOpts = opts;
+      return makeStreamResult();
+    });
+    const runHooks = {
+      begin: jest.fn(async () => ({
+        runId: 'run-1',
+        signal: new AbortController().signal,
+      })),
+      onAssistantSeeded: jest.fn(),
+      onStep: jest.fn(),
+      onSettled: jest.fn(),
+    };
+    await svc.stream({
+      user: { id: 'user-1' } as never,
+      workspace: { id: 'ws-1' } as never,
+      sessionId: 'sess-1',
+      body: body as never,
+      res: makeRes() as never,
+      signal: new AbortController().signal,
+      model: {} as never,
+      role: null,
+      runHooks: runHooks as never,
+    });
+    expect(capturedOpts).toBeDefined();
+    return { capturedOpts, runHooks };
+  }
+
+  it('F9: onStepFinish bumps the run step count, onFinish settles the run "completed" (the dominant autonomous-run path)', async () => {
+    const { capturedOpts, runHooks } = await captureStreamCallbacks();
+
+    // A finished step -> onStep(runId, finishedStepCount).
+    capturedOpts.onStepFinish({ text: 'step one', toolCalls: [], content: [] });
+    expect(runHooks.onStep).toHaveBeenCalledWith('run-1', 1);
+    capturedOpts.onStepFinish({ text: 'step two', toolCalls: [], content: [] });
+    expect(runHooks.onStep).toHaveBeenLastCalledWith('run-1', 2);
+
+    // The success terminal callback settles the run.
+    await capturedOpts.onFinish({
+      text: 'done',
+      finishReason: 'stop',
+      totalUsage: {},
+      usage: {},
+      steps: [],
+    });
+    expect(runHooks.onSettled).toHaveBeenCalledWith('run-1', 'completed');
+  });
+
+  it('F9: onAbort settles the run "aborted"', async () => {
+    jest
+      .spyOn(Logger.prototype, 'warn')
+      .mockImplementation(() => undefined as never);
+    const { capturedOpts, runHooks } = await captureStreamCallbacks();
+
+    await capturedOpts.onAbort({ steps: [] });
+    expect(runHooks.onSettled).toHaveBeenCalledWith('run-1', 'aborted');
+  });
+
+  it('F9: onError settles the run "error" carrying the provider cause', async () => {
+    jest
+      .spyOn(Logger.prototype, 'error')
+      .mockImplementation(() => undefined as never);
+    jest
+      .spyOn(Logger.prototype, 'warn')
+      .mockImplementation(() => undefined as never);
+    const { capturedOpts, runHooks } = await captureStreamCallbacks();
+
+    await capturedOpts.onError({ error: new Error('provider exploded') });
+    expect(runHooks.onSettled).toHaveBeenCalledWith(
+      'run-1',
+      'error',
+      expect.stringContaining('provider exploded'),
+    );
+  });
+});
+
+/**
+ * F14 — the begin-failure RESILIENCE branch (the `else` of the run-race guard).
+ *
+ * stream() wraps runHooks.begin in try/catch with TWO branches:
+ *   - RunAlreadyActiveError  -> 409 ConflictException (pinned above).
+ *   - ANY OTHER begin failure -> SWALLOW + continue UNTRACKED on the socket signal
+ *     (legacy fallback): it logs "...streaming without run tracking", leaves
+ *     `effectiveSignal = signal` (runId undefined) and serves the turn anyway.
+ *
+ * The contract: a transient beginRun failure (e.g. a non-unique DB error inserting
+ * the run row) must STILL serve the user's turn — it must NOT re-throw and must NOT
+ * be misclassified as a 409. A regression that re-threw here would break EVERY turn
+ * on a begin failure with nothing to catch it. This branch is otherwise undriven by
+ * any spec, so it is pinned here SEPARATELY from the 409 path: a plain begin error
+ * proceeds to streamText with the SOCKET signal and still persists the user turn.
+ */
+describe('AiChatService.stream — begin-failure resilience / legacy fallback (#184 F14)', () => {
+  const streamTextMock = streamText as unknown as jest.Mock;
+
+  function makeStreamResult() {
+    return {
+      consumeStream: jest.fn(),
+      pipeUIMessageStreamToResponse: jest.fn(),
+    };
+  }
+
+  function makeRes() {
+    return {
+      raw: {
+        writeHead: jest.fn(),
+        write: jest.fn(),
+        once: jest.fn(),
+        on: jest.fn(),
+        flushHeaders: jest.fn(),
+        writableEnded: false,
+        destroyed: false,
+      },
+    };
+  }
+
+  // Same harness as the F3 abortSignal block, but it also exposes
+  // aiChatMessageRepo so we can assert the user turn IS persisted (the turn really
+  // streamed) despite begin() blowing up.
+  function makeService() {
+    const aiChatRepo = {
+      findById: jest.fn(async () => ({ id: 'chat-1', workspaceId: 'ws-1' })),
+      insert: jest.fn(),
+    };
+    const aiChatMessageRepo = {
+      insert: jest.fn(async () => ({ id: 'msg-1' })),
+      findAllByChat: jest.fn(async () => []),
+      update: jest.fn(async () => ({ id: 'msg-1' })),
+    };
+    const aiSettings = { resolve: jest.fn(async () => ({})) };
+    const tools = { forUser: jest.fn(async () => ({})) };
+    const mcpClients = {
+      toolsFor: jest.fn(async () => ({
+        tools: {},
+        clients: [],
+        outcomes: [],
+        instructions: [],
+      })),
+    };
+    const svc = new AiChatService(
+      {} as never, // ai
+      aiChatRepo as never,
+      aiChatMessageRepo as never,
+      {} as never, // aiChatPageSnapshotRepo
+      aiSettings as never,
+      tools as never,
+      mcpClients as never,
+      {} as never, // aiAgentRoleRepo
+      {} as never, // pageRepo
+      {} as never, // pageAccess
+      { isAiChatDeferredToolsEnabled: () => false } as never, // environment
+    );
+    return { svc, aiChatMessageRepo };
+  }
+
+  const body = {
+    chatId: 'chat-1',
+    messages: [
+      { id: 'm1', role: 'user', parts: [{ type: 'text', text: 'hi' }] },
+    ],
+  };
+
+  beforeEach(() => {
+    streamTextMock.mockReset();
+    streamTextMock.mockImplementation(() => makeStreamResult());
+    jest
+      .spyOn(Logger.prototype, 'log')
+      .mockImplementation(() => undefined as never);
+  });
+
+  afterEach(() => jest.restoreAllMocks());
+
+  it('a PLAIN begin() failure (NOT RunAlreadyActiveError) does NOT 409 — it swallows, logs, and streams the turn UNTRACKED on the socket signal', async () => {
+    const errorSpy = jest
+      .spyOn(Logger.prototype, 'error')
+      .mockImplementation(() => undefined as never);
+
+    const { svc, aiChatMessageRepo } = makeService();
+    const socketSignal = new AbortController().signal;
+
+    // A transient, NON-race begin failure (e.g. a non-unique DB error inserting
+    // the run row). This is the `else` branch of the begin try/catch.
+    const begin = jest.fn(async () => {
+      throw new Error('insert failed');
+    });
+
+    const promise = svc.stream({
+      user: { id: 'user-1' } as never,
+      workspace: { id: 'ws-1' } as never,
+      sessionId: 'sess-1',
+      body: body as never,
+      res: makeRes() as never,
+      signal: socketSignal,
+      model: {} as never,
+      role: null,
+      runHooks: {
+        begin,
+        onAssistantSeeded: jest.fn(),
+        onStep: jest.fn(),
+        onSettled: jest.fn(),
+      } as never,
+    });
+
+    // The turn proceeds: NO throw at all (in particular NOT a 409).
+    await expect(promise).resolves.toBeUndefined();
+
+    expect(begin).toHaveBeenCalledTimes(1);
+
+    // The resilience branch logged the legacy-fallback warning.
+    expect(errorSpy).toHaveBeenCalledWith(
+      expect.stringContaining('streaming without run tracking'),
+      expect.anything(),
+    );
+
+    // The turn really streamed: the user message was persisted and streamText ran.
+    expect(aiChatMessageRepo.insert).toHaveBeenCalled();
+    expect(streamTextMock).toHaveBeenCalledTimes(1);
+
+    // The decisive wiring: with no run handle, the fallback uses the SOCKET signal
+    // (effectiveSignal = signal, runId undefined) — not a run-bound signal.
+    expect(streamTextMock.mock.calls[0][0].abortSignal).toBe(socketSignal);
+  });
+});

apps/server/src/core/ai-chat/ai-chat.service.setup-abort.spec.ts

@@ -0,0 +1,121 @@
+import { Logger } from '@nestjs/common';
+
+// Mock the AI SDK: the turn we drive is STOPPED during the pre-streamText setup
+// phase, so no provider call must ever be made. convertToModelMessages is reached
+// (before toolsFor) so it is stubbed to an empty transcript.
+jest.mock('ai', () => ({
+  streamText: jest.fn(),
+  generateText: jest.fn(),
+  convertToModelMessages: jest.fn(async () => []),
+  stepCountIs: jest.fn(() => () => false),
+}));
+
+import { streamText } from 'ai';
+import { AiChatService } from './ai-chat.service';
+
+/**
+ * D2 — an explicit Stop DURING the external-MCP toolset build (the pre-streamText
+ * setup phase) must:
+ *   (a) unwedge the turn (stream() rejects instead of hanging at step 0), and
+ *   (b) finalize the run as 'aborted' via the outer catch's onSettled — never leak
+ *       the run row as 'running' (which would 409 every later turn in this chat).
+ *
+ * The setup phase does NOT yet observe streamText's terminal callbacks, so before
+ * the fix a hung `toolsFor` ignored the run's abort signal and never finalized.
+ * `raceAgainstAbortAndTimeout(toolsFor, effectiveSignal, ...)` now rejects the
+ * moment the run's signal aborts; the catch re-throws (signal aborted), and the
+ * outer catch settles the run 'aborted'.
+ */
+describe('AiChatService.stream — abort during external-MCP setup finalizes the run (D2)', () => {
+  const streamTextMock = streamText as unknown as jest.Mock;
+
+  function makeService(mcpClients: { toolsFor: jest.Mock }) {
+    const aiChatRepo = {
+      findById: jest.fn(async () => ({ id: 'chat-1', workspaceId: 'ws-1' })),
+      insert: jest.fn(),
+    };
+    const aiChatMessageRepo = {
+      insert: jest.fn(async () => ({ id: 'msg-1' })),
+      findAllByChat: jest.fn(async () => []),
+      update: jest.fn(async () => ({ id: 'msg-1' })),
+    };
+    const aiSettings = { resolve: jest.fn(async () => ({})) };
+    const tools = { forUser: jest.fn(async () => ({})) };
+    const svc = new AiChatService(
+      {} as never, // ai
+      aiChatRepo as never,
+      aiChatMessageRepo as never,
+      {} as never, // aiChatPageSnapshotRepo
+      aiSettings as never,
+      tools as never,
+      mcpClients as never,
+      {} as never, // aiAgentRoleRepo
+      {} as never, // pageRepo (openPage undefined -> never touched)
+      {} as never, // pageAccess
+      { isAiChatDeferredToolsEnabled: () => false } as never, // environment
+    );
+    return { svc, tools };
+  }
+
+  const body = {
+    chatId: 'chat-1',
+    messages: [
+      { id: 'm1', role: 'user', parts: [{ type: 'text', text: 'hi' }] },
+    ],
+  };
+
+  beforeEach(() => {
+    streamTextMock.mockReset();
+    jest.spyOn(Logger.prototype, 'log').mockImplementation(() => undefined as never);
+    jest.spyOn(Logger.prototype, 'warn').mockImplementation(() => undefined as never);
+    jest.spyOn(Logger.prototype, 'error').mockImplementation(() => undefined as never);
+  });
+
+  afterEach(() => jest.restoreAllMocks());
+
+  it('stops the hung toolset build, rejects, and settles the run "aborted" — never reaching streamText', async () => {
+    const runController = new AbortController();
+    // The build hangs (never resolves); the run is STOPPED mid-build. Aborting on a
+    // macrotask exercises the abort-listener path (a real user Stop during setup).
+    const toolsFor = jest.fn(() => {
+      setTimeout(() => runController.abort(new Error('user stop')), 0);
+      return new Promise(() => {}); // never settles — models a hung MCP build
+    });
+    const { svc } = makeService({ toolsFor });
+
+    const onSettled = jest.fn();
+    const begin = jest.fn(async () => ({
+      runId: 'run-1',
+      signal: runController.signal,
+    }));
+
+    const promise = svc.stream({
+      user: { id: 'user-1' } as never,
+      workspace: { id: 'ws-1' } as never,
+      sessionId: 'sess-1',
+      body: body as never,
+      res: { raw: {} } as never,
+      signal: new AbortController().signal, // socket signal (distinct from the run)
+      model: {} as never,
+      role: null,
+      runHooks: {
+        begin,
+        onAssistantSeeded: jest.fn(),
+        onStep: jest.fn(),
+        onSettled,
+      } as never,
+    });
+
+    // (a) The turn is UNWEDGED: it rejects (with the stop reason) instead of hanging.
+    await expect(promise).rejects.toThrow('user stop');
+
+    // (b) The run is finalized as 'aborted' with NO error message (a Stop, not a
+    // failure) — so the run row never leaks 'running'.
+    expect(onSettled).toHaveBeenCalledTimes(1);
+    expect(onSettled).toHaveBeenCalledWith('run-1', 'aborted', undefined);
+
+    // The build was reached, but the provider call was NEVER made (stopped at setup).
+    expect(toolsFor).toHaveBeenCalledTimes(1);
+    expect(streamTextMock).not.toHaveBeenCalled();
+  });
+});