Files
pyrogram-bridge/telegram_client.py
T
claude code agent 444bd3e42f fix(stability): stage 2 — atomic media downloads, in-flight dedup, FloodWait->429, bounded semaphore
Fixes flaky static media serving: partial files served as 'ready', truncated
stubs living for an hour, and app-wide hangs under a saturated download path.

2.1 _download_atomic(file_id, final_path, timeout): downloads to a unique
    {final}.part.{hex}, validates size>0, and publishes solely via os.rename
    (atomic on POSIX); a finally ALWAYS removes the partial (timeout/cancel/
    zero-size/race-loser). Every downloader call routes through it, so a file at a
    FINAL name ({fid} / temp_{fid}) is GUARANTEED complete (grep-proven: the only
    safe_download_media caller passes a .part. path). Big-video timeout scales with
    size (min/max/min-speed knobs, documented in dockercompose.yml). The sweeper
    regex now matches both .part. and legacy .tmp. stubs.
2.2 In-flight dedup registry: the first request for a key runs the download in a
    DETACHED task sharing a Future; the task's finally sets the Future AND pops the
    key. Waiters await asyncio.shield(fut) so a client disconnect / waiter timeout
    cancels only the waiter, never the download — no hung waiters, no stuck key, a
    failed download frees the key for retry.
2.3 FloodWait->429: handler before except RPCError (FloodWait subclasses it),
    Retry-After = min(value + rand(1,30), 300); propagates from the detached task
    through the Future.
2.4 Serving a temp_* file touches its mtime so the 1h sweeper can't delete a
    video out from under a viewer.
2.5 The HTTP download semaphore acquire is bounded (wait_for 30 -> 503 +
    Retry-After); the permit is released only if the acquire succeeded. The
    request-scoped-permit trade-off (a disconnect can transiently exceed the
    download count) is documented inline for stage-7 prod observation.

Tests (tests/test_stage2_static.py, 13): atomic publish/clean on every exit incl.
FloodWait-through-the-finally; concurrent big-video serves no partial; dedup runs
one download, a cancelled waiter doesn't hang others, a failed download frees the
key; FloodWait -> 429; mtime touch; sweeper cleans .part./.tmp./stale temp_ but
keeps fresh files. 193 passed (180 baseline + 13).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-05 07:40:47 +03:00

314 lines
16 KiB
Python

#!/usr/bin/env python3
# -*- coding: utf-8 -*-
# flake8: noqa
# pylint: disable=broad-exception-raised, raise-missing-from, too-many-arguments, redefined-outer-name
# pylint: disable=multiple-statements, logging-fstring-interpolation, trailing-whitespace, line-too-long
# pylint: disable=broad-exception-caught, missing-function-docstring, missing-class-docstring
# pylint: disable=f-string-without-interpolation
# pylance: disable=reportMissingImports, reportMissingModuleSource
import logging
import os
import asyncio
import sys
import signal
import uvloop
import time
asyncio.set_event_loop_policy(uvloop.EventLoopPolicy())
from pyrogram import Client
from pyrogram.handlers import DisconnectHandler
from config import get_settings
logger = logging.getLogger(__name__)
settings = get_settings()
class TelegramClient:
def __init__(self):
self._ensure_session_directory()
self.client = Client(
name="pyro_bridge",
api_id=settings["tg_api_id"],
api_hash=settings["tg_api_hash"],
workdir=settings["session_path"],
proxy=settings["proxy"], # MTProto proxy config, None if not set
)
self.max_disconnects = settings["tg_disconnect_flap_limit"] # Max disconnects within the flap window before restart
self._shutting_down = False # Guard to prevent re-triggering restart during shutdown
self._restarting = False # Guard: an intentional in-process restart is in progress
self._disconnect_times = [] # Monotonic timestamps of recent disconnects (sliding window)
self.disconnect_window = settings["tg_disconnect_flap_window"] # Seconds; window for flap detection
self._watchdog_task = None
self.watchdog_enabled = settings["tg_watchdog_enabled"]
self.watchdog_interval = settings["tg_watchdog_interval"]
self.watchdog_timeout = settings["tg_watchdog_timeout"]
self.watchdog_failures = settings["tg_watchdog_failures"]
self.watchdog_restart_timeout = settings["tg_watchdog_restart_timeout"]
self.watchdog_heartbeat_every = settings["tg_watchdog_heartbeat_every"]
# Watchdog diagnostics counters (cumulative for the process lifetime)
self._wd_probe_count = 0 # successful liveness probes
self._wd_probe_fail_count = 0 # failed liveness probes
self._wd_restart_count = 0 # successful in-process restarts
self._wd_fallback_count = 0 # SIGTERM fallbacks after a failed in-process restart
self._wd_flap_trigger_count = 0 # times the disconnect-flap threshold was reached
self._wd_last_ok_monotonic = None # monotonic timestamp of the last successful probe
self._setup_connection_handlers()
def _ensure_session_directory(self):
try:
os.makedirs(settings["session_path"], exist_ok=True)
logger.debug(f'Session directory created/verified: {settings["session_path"]}')
except Exception as e:
logger.error(f'Failed to create session directory {settings["session_path"]}: {str(e)}')
raise
def _setup_connection_handlers(self):
"""Sets up connection/disconnection handlers"""
self.client.add_handler(DisconnectHandler(self._on_disconnect))
logger.info("connection_handlers: connection handlers set up")
async def _on_disconnect(self, _client, _session=None):
"""Handles disconnection events from Telegram servers (best-effort safety net).
NOTE: this handler only fires when Pyrogram calls session.stop(). It does NOT fire in
the 'zombie session' case where the recv loop dies silently — that case is handled by
the active watchdog (_watchdog_loop). Keep both paths.
"""
# Ignore disconnects caused by intentional shutdown or by our own in-process restart
# (client.restart() -> client.stop() -> session.stop() re-dispatches this handler).
if self._shutting_down or self._restarting:
logger.debug("connection_handler: ignoring disconnect event (shutdown/restart in progress)")
return
now = time.monotonic()
# Sliding window: drop disconnects older than the window, then record this one.
self._disconnect_times = [t for t in self._disconnect_times if now - t <= self.disconnect_window]
self._disconnect_times.append(now)
count = len(self._disconnect_times)
logger.warning(f"connection_handler: connection lost ({count} within {self.disconnect_window}s window)")
if count >= self.max_disconnects:
self._wd_flap_trigger_count += 1
logger.critical(
f"connection_handler: disconnect flap limit reached "
f"({count} disconnects within {self.disconnect_window}s window, limit={self.max_disconnects}), restarting client"
)
await self._restart_client(reason=f"disconnect flap ({count} in {self.disconnect_window}s)")
def _start_watchdog(self):
"""Starts the active liveness watchdog task (idempotent)."""
if not self.watchdog_enabled:
logger.info("watchdog: disabled via configuration")
return
if self._watchdog_task is not None and not self._watchdog_task.done():
return
self._watchdog_task = asyncio.create_task(self._watchdog_loop())
async def _watchdog_loop(self):
"""Active liveness probe for the 'zombie session' state.
The disconnect-only recovery never triggers when Pyrogram's recv loop dies silently
(is_connected stays True, no Disconnect event). This loop periodically issues a real
lightweight API call (get_me) bounded by a short timeout; after N consecutive failures
it forces an in-process restart. Emits diagnostics so the behaviour can be reconstructed
from logs afterwards.
"""
consecutive_failures = 0
logger.info(
f"watchdog: started (interval={self.watchdog_interval}s, timeout={self.watchdog_timeout}s, "
f"failures={self.watchdog_failures}, heartbeat_every={self.watchdog_heartbeat_every} probes)"
)
try:
while True:
await asyncio.sleep(self.watchdog_interval)
if self._shutting_down:
break
if self._restarting:
# A restart is already underway; skip this probe cycle.
logger.debug("watchdog: skip probe (restart in progress)")
continue
probe_started = time.monotonic()
try:
me = await asyncio.wait_for(self.client.get_me(), timeout=self.watchdog_timeout)
latency_ms = (time.monotonic() - probe_started) * 1000
self._wd_probe_count += 1
self._wd_last_ok_monotonic = time.monotonic()
if consecutive_failures:
logger.warning(
f"watchdog: liveness RESTORED after {consecutive_failures} failed probe(s) "
f"(latency={latency_ms:.0f}ms, me_id={getattr(me, 'id', None)})"
)
consecutive_failures = 0
else:
logger.debug(f"watchdog: probe ok (latency={latency_ms:.0f}ms, probe #{self._wd_probe_count})")
# Periodic proof-of-life heartbeat at INFO, so the ABSENCE of heartbeats in the
# logs is itself a signal that the watchdog died.
if self.watchdog_heartbeat_every > 0 and self._wd_probe_count % self.watchdog_heartbeat_every == 0:
logger.info(
f"watchdog: heartbeat — probes={self._wd_probe_count}, "
f"probe_failures={self._wd_probe_fail_count}, restarts={self._wd_restart_count}, "
f"sigterm_fallbacks={self._wd_fallback_count}, flap_triggers={self._wd_flap_trigger_count}, "
f"last_probe_latency={latency_ms:.0f}ms, is_connected={self.client.is_connected}"
)
except asyncio.CancelledError:
raise
except Exception as e:
latency_ms = (time.monotonic() - probe_started) * 1000
consecutive_failures += 1
self._wd_probe_fail_count += 1
if self._wd_last_ok_monotonic is not None:
last_ok = f"{time.monotonic() - self._wd_last_ok_monotonic:.0f}s ago"
else:
last_ok = "never"
logger.warning(
f"watchdog: liveness probe FAILED ({consecutive_failures}/{self.watchdog_failures}) "
f"after {latency_ms:.0f}ms: {type(e).__name__}: {e} "
f"(is_connected={self.client.is_connected}, last_ok={last_ok}, "
f"total_failures={self._wd_probe_fail_count})"
)
if consecutive_failures >= self.watchdog_failures:
consecutive_failures = 0
await self._restart_client(reason=f"watchdog: {self.watchdog_failures} consecutive failed probes")
except asyncio.CancelledError:
logger.info(
f"watchdog: stopped (probes={self._wd_probe_count}, probe_failures={self._wd_probe_fail_count}, "
f"restarts={self._wd_restart_count}, sigterm_fallbacks={self._wd_fallback_count}, "
f"flap_triggers={self._wd_flap_trigger_count})"
)
raise
except Exception as e:
logger.critical(f"watchdog: loop crashed unexpectedly ({type(e).__name__}: {e}); liveness protection is now DISABLED until next start")
async def _restart_client(self, reason: str = "unspecified"):
"""Recover the client without killing the process when possible.
Performs an in-process restart (rebuilds session + recv loop), bounded by a timeout so a
dead network layer cannot make it hang forever. Falls back to a full process restart
(SIGTERM) if the in-process restart fails or times out.
"""
if self._restarting or self._shutting_down:
logger.debug(f"recovery: restart requested (reason='{reason}') but already restarting/shutting down — skipped")
return
self._restarting = True
restart_started = time.monotonic()
was_connected = self.client.is_connected
logger.critical(
f"recovery: TRIGGERED — reason='{reason}', is_connected={was_connected}, "
f"in-process restarts so far={self._wd_restart_count}, sigterm fallbacks so far={self._wd_fallback_count}"
)
try:
if was_connected:
logger.warning("recovery: calling client.restart() (in-process teardown + reconnect)")
await asyncio.wait_for(self.client.restart(), timeout=self.watchdog_restart_timeout)
else:
logger.warning("recovery: client not connected, calling client.start()")
await asyncio.wait_for(self.client.start(), timeout=self.watchdog_restart_timeout)
duration = time.monotonic() - restart_started
self._wd_restart_count += 1
# Verification probe to prove the network layer is actually back (diagnostic only).
try:
me = await asyncio.wait_for(self.client.get_me(), timeout=self.watchdog_timeout)
self._wd_last_ok_monotonic = time.monotonic()
verify = f", verify_get_me ok (me_id={getattr(me, 'id', None)})"
except Exception as ve:
verify = f", verify_get_me FAILED ({type(ve).__name__}: {ve})"
logger.warning(
f"recovery: in-process restart SUCCEEDED in {duration:.1f}s "
f"(is_connected={self.client.is_connected}{verify}, total in-process restarts={self._wd_restart_count})"
)
self._disconnect_times.clear()
# Re-arm the watchdog in case it had previously crashed (self-healing).
self._start_watchdog()
except asyncio.CancelledError:
raise
except Exception as e:
duration = time.monotonic() - restart_started
self._wd_fallback_count += 1
logger.error(
f"recovery: in-process restart FAILED after {duration:.1f}s ({type(e).__name__}: {e}); "
f"falling back to process restart (SIGTERM), total fallbacks={self._wd_fallback_count}"
)
self._restart_app()
finally:
self._restarting = False
async def start(self):
try:
if not self.client.is_connected:
await self.client.start()
logger.info("Telegram client connected successfully")
# Reset flap history on a fresh successful connection
self._disconnect_times.clear()
logger.info("connection_handler: connection established")
self._start_watchdog()
except Exception as e:
logger.error(f"Failed to start Telegram client: {str(e)}")
raise
def _restart_app(self):
"""Restarts the application by sending SIGTERM to the process"""
self._shutting_down = True # Set flag before sending signal to suppress subsequent disconnect events
logger.warning("connection_handler: restarting application by sending SIGTERM")
try:
# Use SIGTERM for proper Docker container restart
logger.critical("connection_handler: sending SIGTERM signal")
os.kill(os.getpid(), signal.SIGTERM)
except Exception as e:
logger.error(f"connection_handler: error during restart: {str(e)}")
# Emergency termination
os._exit(1)
async def safe_get_messages(self, channel_id, post_id, max_retries=2):
"""Wrapper with retry logic for auth errors"""
for attempt in range(max_retries):
try:
return await asyncio.wait_for(
self.client.get_messages(channel_id, post_id),
timeout=30.0
)
except Exception as e:
if isinstance(e, KeyError) and attempt < max_retries - 1:
logger.warning(f"Auth error on attempt {attempt + 1}, retrying in 5s...")
await asyncio.sleep(5)
continue
raise
async def safe_download_media(self, file_id, file_name, max_retries=2, timeout: float = 120.0):
"""Wrapper with retry logic for download errors.
`timeout` bounds each download attempt; for large videos the caller scales it
with file size (see api_server._media_download_timeout)."""
for attempt in range(max_retries):
try:
return await asyncio.wait_for(
self.client.download_media(file_id, file_name=file_name),
timeout=timeout
)
except Exception as e:
if isinstance(e, KeyError) and attempt < max_retries - 1:
logger.warning(f"Download auth error on attempt {attempt + 1}, retrying...")
await asyncio.sleep(5)
continue
raise
async def stop(self):
# Suppress disconnect handling during intentional shutdown
# (client.stop() dispatches the DisconnectHandler).
self._shutting_down = True
if self._watchdog_task is not None:
self._watchdog_task.cancel()
try:
await self._watchdog_task
except asyncio.CancelledError:
pass
self._watchdog_task = None
if self.client.is_connected:
try:
await self.client.stop()
logger.info("Telegram client disconnected")
except Exception as e:
# During shutdown the client may be in a half-restarted state
# (e.g. a watchdog restart was cancelled mid-flight); ignore stop errors.
logger.warning(f"Telegram client stop during shutdown raised {type(e).__name__}: {e}")