Files
claude code agent 637e96f236 fix(logs): flush docker proxy stream per chunk; trim log-viewer settings UI
Backend (the "logs arrive every ~5s / pipe clogged" bug):
- dockerLocalProxy.ServeHTTP streamed the docker socket response via
  io.Copy, which buffers ~2KB into the ResponseWriter and only flushes
  when full or on handler return. Low-throughput streaming endpoints
  (container logs follow=1, events, stats, attach) therefore arrived in
  multi-second batches. Stream manually and Flush() after each chunk so
  they are delivered live. Behaviour is otherwise identical to io.Copy
  (full-write contract, EOF handling, Debug error logging); hijacked
  attach/exec go through a separate websocket handler, unaffected.
- NewSingleHostReverseProxyWithHostHeader: set FlushInterval = -1 so the
  remote-endpoint path streams live too.

Frontend (maintainer UI asks):
- Remove the line-selection mechanic entirely (Copy-selected-lines and
  Unselect buttons, selectLine/copySelection/clearSelection, selectedLines
  state, line_selected highlight): selecting/copying is mouse-native. Copy
  (all visible) and Download stay.
- Rename the unclear "Fetch" since-selector label to "Since".
- Move the settings controls into the widget header (rd-widget-header
  default transclude slot) so they share one row with the "Log viewer
  settings" title, reclaiming vertical space for the log pane.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 02:05:02 +03:00

71 lines
2.5 KiB
JavaScript

import moment from 'moment';
import { concatLogsToString, NEW_LINE_BREAKER } from '@/docker/helpers/logHelper';
angular.module('portainer.docker').controller('LogViewerController', [
'$scope',
'clipboard',
'Blob',
'FileSaver',
function ($scope, clipboard, Blob, FileSaver) {
this.state = {
availableSinceDatetime: [
{ desc: 'Last day', value: moment().subtract(1, 'days').format() },
{ desc: 'Last 4 hours', value: moment().subtract(4, 'hours').format() },
{ desc: 'Last hour', value: moment().subtract(1, 'hours').format() },
{ desc: 'Last 10 minutes', value: moment().subtract(10, 'minutes').format() },
],
copySupported: clipboard.supported,
autoScroll: true,
wrapLines: true,
search: '',
filteredLogs: [],
};
this.handleLogsWrapLinesChange = handleLogsWrapLinesChange.bind(this);
this.handleDisplayTimestampsChange = handleDisplayTimestampsChange.bind(this);
this.applyFilter = applyFilter.bind(this);
this.$onInit = function () {
this.applyFilter();
// Compute the filtered list in the controller (not in the template) so we
// do not rebuild `filteredLogs` on every digest. `$watchCollection` only
// fires when lines are actually appended; combined with `track by log.id`
// in the template, already-rendered rows are never re-bound — so a live
// text selection survives incoming log lines.
$scope.$watchCollection(() => this.data, this.applyFilter);
$scope.$watch(() => this.state.search, this.applyFilter);
};
function applyFilter() {
const data = this.data || [];
const search = (this.state.search || '').toLowerCase();
this.state.filteredLogs = search ? data.filter((log) => log.line && log.line.toLowerCase().indexOf(search) > -1) : data;
}
function handleLogsWrapLinesChange(enabled) {
$scope.$evalAsync(() => {
this.state.wrapLines = enabled;
});
}
function handleDisplayTimestampsChange(enabled) {
$scope.$evalAsync(() => {
this.displayTimestamps = enabled;
});
}
this.copy = function () {
clipboard.copyText(this.state.filteredLogs.map((log) => log.line).join(NEW_LINE_BREAKER));
$('#refreshRateChange').show();
$('#refreshRateChange').fadeOut(2000);
};
this.downloadLogs = function () {
const logsAsString = concatLogsToString(this.state.filteredLogs);
const data = new Blob([logsAsString]);
FileSaver.saveAs(data, this.resourceName + '_logs.txt');
};
},
]);