fix(version): change API version support from LTS to STS (#1222)

.eslintrc.yml

@@ -17,7 +17,7 @@ plugins:
   - import
 
 parserOptions:
-  ecmaVersion: latest
+  ecmaVersion: 2018
   sourceType: module
   project: './tsconfig.json'
   ecmaFeatures:

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -94,13 +94,7 @@ body:
       description: We only provide support for current versions of Portainer as per the lifecycle policy linked above. If you are on an older version of Portainer we recommend [updating first](https://docs.portainer.io/start/upgrade) in case your bug has already been fixed.
       multiple: false
       options:
-        - '2.36.0'
-        - '2.35.0'
         - '2.34.0'
-        - '2.33.5'
-        - '2.33.4'
-        - '2.33.3'
-        - '2.33.2'
         - '2.33.1'
         - '2.33.0'
         - '2.32.0'

.golangci-forward.yaml

@@ -9,8 +9,3 @@ linters:
         - pattern: ^dataservices.DataStore.(EdgeGroup|EdgeJob|EdgeStack|EndpointRelation|Endpoint|GitCredential|Registry|ResourceControl|Role|Settings|Snapshot|Stack|Tag|User)$
           msg: Use a transaction instead
       analyze-types: true
-  exclusions:
-    rules:
-      - path: _test\.go
-        linters:
-          - forbidigo

Makefile

@@ -1,3 +1,9 @@
+# See: https://gist.github.com/asukakenji/f15ba7e588ac42795f421b48b8aede63
+# For a list of valid GOOS and GOARCH values
+# Note: these can be overriden on the command line e.g. `make PLATFORM=<platform> ARCH=<arch>`
+PLATFORM=$(shell go env GOOS)
+ARCH=$(shell go env GOARCH)
+
 # build target, can be one of "production", "testing", "development"
 ENV=development
 WEBPACK_CONFIG=webpack/webpack.$(ENV).js
@@ -31,6 +37,10 @@ build-image: build-all ## Build the Portainer image locally
 build-storybook: ## Build and serve the storybook files
 	yarn storybook:build
 
+devops: clean deps build-client ## Build the everything target specifically for CI
+	echo "Building the devops binary..."
+	@./build/build_binary_azuredevops.sh "$(PLATFORM)" "$(ARCH)"
+
 ##@ Build dependencies
 .PHONY: deps server-deps client-deps tidy
 deps: server-deps client-deps ## Download all client and server build dependancies

api/cli/cli.go

@@ -56,7 +56,6 @@ func CLIFlags() *portainer.CLIFlags {
 		PullLimitCheckDisabled:    kingpin.Flag("pull-limit-check-disabled", "Pull limit check").Envar(portainer.PullLimitCheckDisabledEnvVar).Default(defaultPullLimitCheckDisabled).Bool(),
 		TrustedOrigins:            kingpin.Flag("trusted-origins", "List of trusted origins for CSRF protection. Separate multiple origins with a comma.").Envar(portainer.TrustedOriginsEnvVar).String(),
 		CSP:                       kingpin.Flag("csp", "Content Security Policy (CSP) header").Envar(portainer.CSPEnvVar).Default("true").Bool(),
-		CompactDB:                 kingpin.Flag("compact-db", "Enable database compaction on startup").Envar(portainer.CompactDBEnvVar).Default("false").Bool(),
 	}
 }
 

api/cmd/portainer/main.go

@@ -84,7 +84,7 @@ func initFileService(dataStorePath string) portainer.FileService {
 }
 
 func initDataStore(flags *portainer.CLIFlags, secretKey []byte, fileService portainer.FileService, shutdownCtx context.Context) dataservices.DataStore {
-	connection, err := database.NewDatabase("boltdb", *flags.Data, secretKey, *flags.CompactDB)
+	connection, err := database.NewDatabase("boltdb", *flags.Data, secretKey)
 	if err != nil {
 		log.Fatal().Err(err).Msg("failed creating database connection")
 	}

api/connection.go

@@ -53,5 +53,4 @@ type Connection interface {
 
 	UpdateObjectFunc(bucketName string, key []byte, object any, updateFn func()) error
 	ConvertToKey(v int) []byte
-	ConvertStringToKey(v string) []byte
 }

api/database/boltdb/db.go

@@ -21,9 +21,6 @@ import (
 const (
 	DatabaseFileName          = "portainer.db"
 	EncryptedDatabaseFileName = "portainer.edb"
-
-	txMaxSize       = 65536
-	compactedSuffix = ".compacted"
 )
 
 var (
@@ -38,7 +35,6 @@ type DbConnection struct {
 	InitialMmapSize int
 	EncryptionKey   []byte
 	isEncrypted     bool
-	Compact         bool
 
 	*bolt.DB
 }
@@ -136,8 +132,15 @@ func (connection *DbConnection) NeedsEncryptionMigration() (bool, error) {
 func (connection *DbConnection) Open() error {
 	log.Info().Str("filename", connection.GetDatabaseFileName()).Msg("loading PortainerDB")
 
+	// Now we open the db
 	databasePath := connection.GetDatabaseFilePath()
-	db, err := bolt.Open(databasePath, 0600, connection.boltOptions(connection.Compact))
+
+	db, err := bolt.Open(databasePath, 0600, &bolt.Options{
+		Timeout:         1 * time.Second,
+		InitialMmapSize: connection.InitialMmapSize,
+		FreelistType:    bolt.FreelistMapType,
+		NoFreelistSync:  true,
+	})
 	if err != nil {
 		return err
 	}
@@ -146,24 +149,6 @@ func (connection *DbConnection) Open() error {
 	db.MaxBatchDelay = connection.MaxBatchDelay
 	connection.DB = db
 
-	if connection.Compact {
-		log.Info().Msg("compacting database")
-		if err := connection.compact(); err != nil {
-			log.Error().Err(err).Msg("failed to compact database")
-
-			// Close the read-only database and re-open in read-write mode
-			if err := connection.Close(); err != nil {
-				log.Warn().Err(err).Msg("failure to close the database after failed compaction")
-			}
-
-			connection.Compact = false
-
-			return connection.Open()
-		} else {
-			log.Info().Msg("database compaction completed")
-		}
-	}
-
 	return nil
 }
 
@@ -233,10 +218,6 @@ func (connection *DbConnection) ConvertToKey(v int) []byte {
 	return b
 }
 
-func (connection *DbConnection) ConvertStringToKey(v string) []byte {
-	return []byte(v)
-}
-
 // keyToString Converts a key to a string value suitable for logging
 func keyToString(b []byte) string {
 	if len(b) != 8 {
@@ -433,48 +414,3 @@ func (connection *DbConnection) RestoreMetadata(s map[string]any) error {
 
 	return err
 }
-
-// compact attempts to compact the database and replace it iff it succeeds
-func (connection *DbConnection) compact() (err error) {
-	compactedPath := connection.GetDatabaseFilePath() + compactedSuffix
-
-	if err := os.Remove(compactedPath); err != nil && !errors.Is(err, os.ErrNotExist) {
-		return fmt.Errorf("failure to remove an existing compacted database: %w", err)
-	}
-
-	compactedDB, err := bolt.Open(compactedPath, 0o600, connection.boltOptions(false))
-	if err != nil {
-		return fmt.Errorf("failure to create the compacted database: %w", err)
-	}
-
-	compactedDB.MaxBatchSize = connection.MaxBatchSize
-	compactedDB.MaxBatchDelay = connection.MaxBatchDelay
-
-	if err := bolt.Compact(compactedDB, connection.DB, txMaxSize); err != nil {
-		return fmt.Errorf("failure to compact the database: %w",
-			errors.Join(err, compactedDB.Close(), os.Remove(compactedPath)))
-	}
-
-	if err := os.Rename(compactedPath, connection.GetDatabaseFilePath()); err != nil {
-		return fmt.Errorf("failure to move the compacted database: %w",
-			errors.Join(err, compactedDB.Close(), os.Remove(compactedPath)))
-	}
-
-	if err := connection.Close(); err != nil {
-		log.Warn().Err(err).Msg("failure to close the database after compaction")
-	}
-
-	connection.DB = compactedDB
-
-	return nil
-}
-
-func (connection *DbConnection) boltOptions(readOnly bool) *bolt.Options {
-	return &bolt.Options{
-		Timeout:         1 * time.Second,
-		InitialMmapSize: connection.InitialMmapSize,
-		FreelistType:    bolt.FreelistMapType,
-		NoFreelistSync:  true,
-		ReadOnly:        readOnly,
-	}
-}

api/database/boltdb/db_test.go

@@ -5,11 +5,7 @@ import (
 	"path"
 	"testing"
 
-	"github.com/portainer/portainer/api/filesystem"
-
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"go.etcd.io/bbolt"
 )
 
 func Test_NeedsEncryptionMigration(t *testing.T) {
@@ -123,59 +119,3 @@ func Test_NeedsEncryptionMigration(t *testing.T) {
 		})
 	}
 }
-
-func TestDBCompaction(t *testing.T) {
-	db := &DbConnection{Path: t.TempDir()}
-
-	err := db.Open()
-	require.NoError(t, err)
-
-	err = db.Update(func(tx *bbolt.Tx) error {
-		b, err := tx.CreateBucketIfNotExists([]byte("testbucket"))
-		if err != nil {
-			return err
-		}
-
-		b.Put([]byte("key"), []byte("value"))
-
-		return nil
-	})
-	require.NoError(t, err)
-
-	err = db.Close()
-	require.NoError(t, err)
-
-	// Reopen the DB to trigger compaction
-	db.Compact = true
-	err = db.Open()
-	require.NoError(t, err)
-
-	// Check that the data is still there
-	err = db.View(func(tx *bbolt.Tx) error {
-		b := tx.Bucket([]byte("testbucket"))
-		if b == nil {
-			return nil
-		}
-
-		val := b.Get([]byte("key"))
-		require.Equal(t, []byte("value"), val)
-
-		return nil
-	})
-	require.NoError(t, err)
-
-	err = db.Close()
-	require.NoError(t, err)
-
-	// Failures
-	compactedPath := db.GetDatabaseFilePath() + compactedSuffix
-	err = os.Mkdir(compactedPath, 0o755)
-	require.NoError(t, err)
-
-	f, err := os.Create(filesystem.JoinPaths(compactedPath, "somefile"))
-	require.NoError(t, err)
-	require.NoError(t, f.Close())
-
-	err = db.Open()
-	require.NoError(t, err)
-}

api/database/database.go

@@ -8,12 +8,11 @@ import (
 )
 
 // NewDatabase should use config options to return a connection to the requested database
-func NewDatabase(storeType, storePath string, encryptionKey []byte, compact bool) (connection portainer.Connection, err error) {
+func NewDatabase(storeType, storePath string, encryptionKey []byte) (connection portainer.Connection, err error) {
 	if storeType == "boltdb" {
 		return &boltdb.DbConnection{
 			Path:          storePath,
 			EncryptionKey: encryptionKey,
-			Compact:       compact,
 		}, nil
 	}
 

api/database/database_test.go

@@ -1,24 +0,0 @@
-package database
-
-import (
-	"testing"
-
-	"github.com/portainer/portainer/api/database/boltdb"
-	"github.com/portainer/portainer/api/filesystem"
-
-	"github.com/stretchr/testify/require"
-)
-
-func TestNewDatabase(t *testing.T) {
-	dbPath := filesystem.JoinPaths(t.TempDir(), "test.db")
-	connection, err := NewDatabase("boltdb", dbPath, nil, false)
-	require.NoError(t, err)
-	require.NotNil(t, connection)
-
-	_, ok := connection.(*boltdb.DbConnection)
-	require.True(t, ok)
-
-	connection, err = NewDatabase("unknown", dbPath, nil, false)
-	require.Error(t, err)
-	require.Nil(t, connection)
-}

api/dataservices/base_test.go

@@ -50,9 +50,6 @@ func (m mockConnection) ViewTx(fn func(portainer.Transaction) error) error {
 func (m mockConnection) ConvertToKey(v int) []byte {
 	return []byte(strconv.Itoa(v))
 }
-func (c mockConnection) ConvertStringToKey(v string) []byte {
-	return []byte(v)
-}
 
 func TestReadAll(t *testing.T) {
 	service := BaseDataService[testObject, int]{

api/dataservices/version/tx.go

@@ -1,70 +0,0 @@
-package version
-
-import (
-	portainer "github.com/portainer/portainer/api"
-	"github.com/portainer/portainer/api/database/models"
-	"github.com/portainer/portainer/api/dataservices"
-)
-
-type ServiceTx struct {
-	dataservices.BaseDataServiceTx[models.Version, int] // ID is not used
-}
-
-func (tx ServiceTx) InstanceID() (string, error) {
-	v, err := tx.Version()
-	if err != nil {
-		return "", err
-	}
-
-	return v.InstanceID, nil
-}
-
-func (tx ServiceTx) UpdateInstanceID(ID string) error {
-	v, err := tx.Version()
-	if err != nil {
-		if !dataservices.IsErrObjectNotFound(err) {
-			return err
-		}
-
-		v = &models.Version{}
-	}
-
-	v.InstanceID = ID
-
-	return tx.UpdateVersion(v)
-}
-
-func (tx ServiceTx) Edition() (portainer.SoftwareEdition, error) {
-	v, err := tx.Version()
-	if err != nil {
-		return 0, err
-	}
-
-	return portainer.SoftwareEdition(v.Edition), nil
-}
-
-func (tx ServiceTx) Version() (*models.Version, error) {
-	var v models.Version
-
-	err := tx.Tx.GetObject(BucketName, []byte(versionKey), &v)
-	if err != nil {
-		return nil, err
-	}
-
-	return &v, nil
-}
-
-func (tx ServiceTx) UpdateVersion(version *models.Version) error {
-	return tx.Tx.UpdateObject(BucketName, []byte(versionKey), version)
-}
-
-func (tx ServiceTx) SchemaVersion() (string, error) {
-	var v models.Version
-
-	err := tx.Tx.GetObject(BucketName, []byte(versionKey), &v)
-	if err != nil {
-		return "", err
-	}
-
-	return v.SchemaVersion, nil
-}

api/dataservices/version/version.go

@@ -33,16 +33,6 @@ func NewService(connection portainer.Connection) (*Service, error) {
 	}, nil
 }
 
-func (service *Service) Tx(tx portainer.Transaction) ServiceTx {
-	return ServiceTx{
-		BaseDataServiceTx: dataservices.BaseDataServiceTx[models.Version, int]{
-			Bucket:     BucketName,
-			Connection: service.connection,
-			Tx:         tx,
-		},
-	}
-}
-
 func (service *Service) SchemaVersion() (string, error) {
 	v, err := service.Version()
 	if err != nil {

api/datastore/test_data/output_24_to_latest.json

@@ -614,7 +614,7 @@
       "RequiredPasswordLength": 12
     },
     "KubeconfigExpiry": "0",
-    "KubectlShellImage": "portainer/kubectl-shell:2.37.0",
+    "KubectlShellImage": "portainer/kubectl-shell:2.34.0",
     "LDAPSettings": {
       "AnonymousMode": true,
       "AutoCreateUsers": true,
@@ -943,7 +943,7 @@
     }
   ],
   "version": {
-    "VERSION": "{\"SchemaVersion\":\"2.37.0\",\"MigratorCount\":0,\"Edition\":1,\"InstanceID\":\"463d5c47-0ea5-4aca-85b1-405ceefee254\"}"
+    "VERSION": "{\"SchemaVersion\":\"2.34.0\",\"MigratorCount\":0,\"Edition\":1,\"InstanceID\":\"463d5c47-0ea5-4aca-85b1-405ceefee254\"}"
   },
   "webhooks": null
 }

api/datastore/teststore.go

@@ -44,7 +44,7 @@ func NewTestStore(t testing.TB, init, secure bool) (bool, *Store, func(), error)
 		secretKey = nil
 	}
 
-	connection, err := database.NewDatabase("boltdb", storePath, secretKey, false)
+	connection, err := database.NewDatabase("boltdb", storePath, secretKey)
 	if err != nil {
 		panic(err)
 	}

api/docker/images/digest.go

@@ -7,12 +7,12 @@ import (
 
 	dockerclient "github.com/portainer/portainer/api/docker/client"
 
+	"github.com/containers/image/v5/docker"
+	imagetypes "github.com/containers/image/v5/types"
 	"github.com/docker/docker/api/types/image"
 	"github.com/opencontainers/go-digest"
 	"github.com/pkg/errors"
 	"github.com/rs/zerolog/log"
-	"go.podman.io/image/v5/docker"
-	imagetypes "go.podman.io/image/v5/types"
 )
 
 // Options holds docker registry object options

api/docker/images/image.go

@@ -7,11 +7,11 @@ import (
 	"strings"
 	"text/template"
 
+	"github.com/containers/image/v5/docker/reference"
 	"github.com/docker/docker/api/types"
 	"github.com/docker/docker/api/types/image"
 	"github.com/opencontainers/go-digest"
 	"github.com/pkg/errors"
-	"go.podman.io/image/v5/docker/reference"
 )
 
 type ImageID string

api/docker/images/ref.go

@@ -3,8 +3,8 @@ package images
 import (
 	"strings"
 
-	"go.podman.io/image/v5/docker"
-	"go.podman.io/image/v5/types"
+	"github.com/containers/image/v5/docker"
+	"github.com/containers/image/v5/types"
 )
 
 func ParseReference(imageStr string) (types.ImageReference, error) {

api/edge/edge.go

@@ -49,34 +49,17 @@ type (
 
 		// Is relative path supported
 		SupportRelativePath bool
-		// AlwaysCloneGitRepoForRelativePath is a flag indicating if the agent must always clone the git repository for relative path.
-		// This field is only valid when SupportRelativePath is true.
-		// Used only for EE
-		AlwaysCloneGitRepoForRelativePath bool
-
 		// Mount point for relative path
 		FilesystemPath string
 		// Used only for EE
 		// EnvVars is a list of environment variables to inject into the stack
 		EnvVars []portainer.Pair
 
-		// ForceUpdate is a flag indicating if the agent must force the update of the stack.
-		// Used only for EE
-		ForceUpdate bool
-
-		DeployerOptionsPayload DeployerOptionsPayload
-
 		// Used only for EE async edge agent
 		// ReadyRePullImage is a flag to indicate whether the auto update is trigger to re-pull image
-		// Deprecated(2.36): use DeployerOptionsPayload.ForceRecreate instead
 		ReadyRePullImage bool
 
-		// CreatedBy is the username that created this stack
-		// Used for adding labels to Kubernetes manifests
-		CreatedBy string
-		// CreatedByUserId is the user ID that created this stack
-		// Used for adding labels to Kubernetes manifests
-		CreatedByUserId string
+		DeployerOptionsPayload DeployerOptionsPayload
 	}
 
 	DeployerOptionsPayload struct {
@@ -89,14 +72,6 @@ type (
 		// This flag drives `docker compose down --volumes` option
 		// Used only for EE
 		RemoveVolumes bool
-
-		// ForceRecreate is a flag indicating if the agent must force the redeployment of the stack.
-		// This field is only used when the Force Redeployment is triggered.
-		// Once the stack is redeployed, this field will be reset to false.
-		// For standard edge agent, this field is used in agent side
-		// For async edge agent, this field is used in both agent side and server side.
-		// This flag drives `docker compose up --force-recreate` option
-		ForceRecreate bool
 	}
 
 	// RegistryCredentials holds the credentials for a Docker registry.

api/git/update/update.go

@@ -13,7 +13,7 @@ import (
 )
 
 // UpdateGitObject updates a git object based on its config
-func UpdateGitObject(gitService portainer.GitService, objId string, gitConfig *gittypes.RepoConfig, enableVersionFolder bool, projectPath string) (bool, string, error) {
+func UpdateGitObject(gitService portainer.GitService, objId string, gitConfig *gittypes.RepoConfig, forceUpdate, enableVersionFolder bool, projectPath string) (bool, string, error) {
 	if gitConfig == nil {
 		return false, "", nil
 	}
@@ -43,7 +43,7 @@ func UpdateGitObject(gitService portainer.GitService, objId string, gitConfig *g
 
 	hashChanged := !strings.EqualFold(newHash, gitConfig.ConfigHash)
 
-	if !hashChanged {
+	if !hashChanged && !forceUpdate {
 		log.Debug().
 			Str("hash", newHash).
 			Str("url", gitConfig.URL).

api/http/handler/edgestacks/edgestack_create.go

@@ -27,7 +27,7 @@ func (handler *Handler) edgeStackCreate(w http.ResponseWriter, r *http.Request)
 
 	var edgeStack *portainer.EdgeStack
 	if err := handler.DataStore.UpdateTx(func(tx dataservices.DataStoreTx) error {
-		edgeStack, err = handler.createSwarmStack(tx, method, dryrun, tokenData, r)
+		edgeStack, err = handler.createSwarmStack(tx, method, dryrun, tokenData.ID, r)
 		return err
 	}); err != nil {
 		switch {
@@ -43,14 +43,14 @@ func (handler *Handler) edgeStackCreate(w http.ResponseWriter, r *http.Request)
 	return response.JSON(w, edgeStack)
 }
 
-func (handler *Handler) createSwarmStack(tx dataservices.DataStoreTx, method string, dryrun bool, tokenData *portainer.TokenData, r *http.Request) (*portainer.EdgeStack, error) {
+func (handler *Handler) createSwarmStack(tx dataservices.DataStoreTx, method string, dryrun bool, userID portainer.UserID, r *http.Request) (*portainer.EdgeStack, error) {
 	switch method {
 	case "string":
-		return handler.createEdgeStackFromFileContent(r, tx, tokenData, dryrun)
+		return handler.createEdgeStackFromFileContent(r, tx, dryrun)
 	case "repository":
-		return handler.createEdgeStackFromGitRepository(r, tx, tokenData, dryrun)
+		return handler.createEdgeStackFromGitRepository(r, tx, dryrun, userID)
 	case "file":
-		return handler.createEdgeStackFromFileUpload(r, tx, tokenData, dryrun)
+		return handler.createEdgeStackFromFileUpload(r, tx, dryrun)
 	}
 
 	return nil, httperrors.NewInvalidPayloadError("Invalid value for query parameter: method. Value must be one of: string, repository or file")

api/http/handler/edgestacks/edgestack_create_file.go

@@ -1,13 +1,11 @@
 package edgestacks
 
 import (
-	"fmt"
 	"net/http"
 
 	portainer "github.com/portainer/portainer/api"
 	"github.com/portainer/portainer/api/dataservices"
 	httperrors "github.com/portainer/portainer/api/http/errors"
-	"github.com/portainer/portainer/api/stacks/stackutils"
 	"github.com/portainer/portainer/pkg/edge"
 	"github.com/portainer/portainer/pkg/libhttp/request"
 
@@ -101,7 +99,7 @@ func (payload *edgeStackFromFileUploadPayload) Validate(r *http.Request) error {
 // @failure 500 "Internal server error"
 // @failure 503 "Edge compute features are disabled"
 // @router /edge_stacks/create/file [post]
-func (handler *Handler) createEdgeStackFromFileUpload(r *http.Request, tx dataservices.DataStoreTx, tokenData *portainer.TokenData, dryrun bool) (*portainer.EdgeStack, error) {
+func (handler *Handler) createEdgeStackFromFileUpload(r *http.Request, tx dataservices.DataStoreTx, dryrun bool) (*portainer.EdgeStack, error) {
 	payload := &edgeStackFromFileUploadPayload{}
 	if err := payload.Validate(r); err != nil {
 		return nil, err
@@ -115,8 +113,6 @@ func (handler *Handler) createEdgeStackFromFileUpload(r *http.Request, tx datase
 	if dryrun {
 		return stack, nil
 	}
-	stack.CreatedByUserId = fmt.Sprintf("%d", tokenData.ID)
-	stack.CreatedBy = stackutils.SanitizeLabel(tokenData.Username)
 
 	return handler.edgeStacksService.PersistEdgeStack(tx, stack, func(stackFolder string, relatedEndpointIds []portainer.EndpointID) (composePath string, manifestPath string, projectPath string, err error) {
 		return handler.storeFileContent(tx, stackFolder, payload.DeploymentType, relatedEndpointIds, payload.StackFileContent)

api/http/handler/edgestacks/edgestack_create_git.go

@@ -9,7 +9,6 @@ import (
 	"github.com/portainer/portainer/api/filesystem"
 	gittypes "github.com/portainer/portainer/api/git/types"
 	httperrors "github.com/portainer/portainer/api/http/errors"
-	"github.com/portainer/portainer/api/stacks/stackutils"
 	"github.com/portainer/portainer/pkg/edge"
 	"github.com/portainer/portainer/pkg/libhttp/request"
 	"github.com/portainer/portainer/pkg/validate"
@@ -104,7 +103,7 @@ func (payload *edgeStackFromGitRepositoryPayload) Validate(r *http.Request) erro
 // @failure 500 "Internal server error"
 // @failure 503 "Edge compute features are disabled"
 // @router /edge_stacks/create/repository [post]
-func (handler *Handler) createEdgeStackFromGitRepository(r *http.Request, tx dataservices.DataStoreTx, tokenData *portainer.TokenData, dryrun bool) (*portainer.EdgeStack, error) {
+func (handler *Handler) createEdgeStackFromGitRepository(r *http.Request, tx dataservices.DataStoreTx, dryrun bool, userID portainer.UserID) (*portainer.EdgeStack, error) {
 	var payload edgeStackFromGitRepositoryPayload
 	if err := request.DecodeAndValidateJSONPayload(r, &payload); err != nil {
 		return nil, err
@@ -134,11 +133,8 @@ func (handler *Handler) createEdgeStackFromGitRepository(r *http.Request, tx dat
 		}
 	}
 
-	stack.CreatedByUserId = fmt.Sprintf("%d", tokenData.ID)
-	stack.CreatedBy = stackutils.SanitizeLabel(tokenData.Username)
-
 	return handler.edgeStacksService.PersistEdgeStack(tx, stack, func(stackFolder string, relatedEndpointIds []portainer.EndpointID) (composePath string, manifestPath string, projectPath string, err error) {
-		return handler.storeManifestFromGitRepository(tx, stackFolder, relatedEndpointIds, payload.DeploymentType, tokenData.ID, repoConfig)
+		return handler.storeManifestFromGitRepository(tx, stackFolder, relatedEndpointIds, payload.DeploymentType, userID, repoConfig)
 	})
 }
 

api/http/handler/edgestacks/edgestack_create_string.go

@@ -8,7 +8,6 @@ import (
 	"github.com/portainer/portainer/api/dataservices"
 	"github.com/portainer/portainer/api/filesystem"
 	httperrors "github.com/portainer/portainer/api/http/errors"
-	"github.com/portainer/portainer/api/stacks/stackutils"
 	"github.com/portainer/portainer/pkg/edge"
 	"github.com/portainer/portainer/pkg/libhttp/request"
 
@@ -75,7 +74,7 @@ func (payload *edgeStackFromStringPayload) Validate(r *http.Request) error {
 // @failure 500 "Internal server error"
 // @failure 503 "Edge compute features are disabled"
 // @router /edge_stacks/create/string [post]
-func (handler *Handler) createEdgeStackFromFileContent(r *http.Request, tx dataservices.DataStoreTx, tokenData *portainer.TokenData, dryrun bool) (*portainer.EdgeStack, error) {
+func (handler *Handler) createEdgeStackFromFileContent(r *http.Request, tx dataservices.DataStoreTx, dryrun bool) (*portainer.EdgeStack, error) {
 	var payload edgeStackFromStringPayload
 	if err := request.DecodeAndValidateJSONPayload(r, &payload); err != nil {
 		return nil, err
@@ -86,9 +85,6 @@ func (handler *Handler) createEdgeStackFromFileContent(r *http.Request, tx datas
 		return nil, errors.Wrap(err, "failed to create Edge stack object")
 	}
 
-	stack.CreatedByUserId = fmt.Sprintf("%d", tokenData.ID)
-	stack.CreatedBy = stackutils.SanitizeLabel(tokenData.Username)
-
 	if dryrun {
 		return stack, nil
 	}

api/http/handler/edgestacks/edgestack_status_update.go

@@ -74,7 +74,7 @@ func (handler *Handler) edgeStackStatusUpdate(w http.ResponseWriter, r *http.Req
 	}
 
 	if err := handler.requestBouncer.AuthorizedEdgeEndpointOperation(r, endpoint); err != nil {
-		return httperror.Forbidden("Permission denied to access environment", fmt.Errorf("unauthorized edge endpoint operation: %w. Environment ID: %d", err, payload.EndpointID))
+		return httperror.Forbidden("Permission denied to access environment", fmt.Errorf("unauthorized edge endpoint operation: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	var stack *portainer.EdgeStack

api/http/handler/endpointedge/endpointedge_job_logs.go

@@ -24,8 +24,8 @@ func (payload *logsPayload) Validate(r *http.Request) error {
 }
 
 // endpointEdgeJobsLogs
-// @summary Update the logs collected from an Edge Job
-// @description Authorized only if the request is done by an Edge Environment(Endpoint)
+// @summary Inspect an EdgeJob Log
+// @description **Access policy**: public
 // @tags edge, endpoints
 // @accept json
 // @produce json
@@ -34,7 +34,6 @@ func (payload *logsPayload) Validate(r *http.Request) error {
 // @success 200
 // @failure 500
 // @failure 400
-// @failure 403
 // @router /endpoints/{id}/edge/jobs/{jobID}/logs [post]
 func (handler *Handler) endpointEdgeJobsLogs(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
 	endpoint, err := middlewares.FetchEndpoint(r)
@@ -43,35 +42,35 @@ func (handler *Handler) endpointEdgeJobsLogs(w http.ResponseWriter, r *http.Requ
 	}
 
 	if err := handler.requestBouncer.AuthorizedEdgeEndpointOperation(r, endpoint); err != nil {
-		return httperror.Forbidden("Permission denied to access environment", fmt.Errorf("unauthorized edge endpoint operation: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.Forbidden("Permission denied to access environment", fmt.Errorf("unauthorized edge endpoint operation: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	edgeJobID, err := request.RetrieveNumericRouteVariableValue(r, "jobID")
 	if err != nil {
-		return httperror.BadRequest("Invalid edge job identifier route variable", fmt.Errorf("invalid Edge job route variable: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.BadRequest("Invalid edge job identifier route variable", fmt.Errorf("invalid Edge job route variable: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	var payload logsPayload
 	if err := request.DecodeAndValidateJSONPayload(r, &payload); err != nil {
-		return httperror.BadRequest("Invalid request payload", fmt.Errorf("invalid Edge job request payload: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.BadRequest("Invalid request payload", fmt.Errorf("invalid Edge job request payload: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	if err := handler.DataStore.UpdateTx(func(tx dataservices.DataStoreTx) error {
-		return handler.updateEdgeJobLogs(tx, endpoint.ID, portainer.EdgeJobID(edgeJobID), payload)
+		return handler.getEdgeJobLobs(tx, endpoint.ID, portainer.EdgeJobID(edgeJobID), payload)
 	}); err != nil {
 		var httpErr *httperror.HandlerError
 		if errors.As(err, &httpErr) {
-			httpErr.Err = fmt.Errorf("edge polling error: %w. Environment ID: %d", httpErr.Err, endpoint.ID)
+			httpErr.Err = fmt.Errorf("edge polling error: %w. Environment name: %s", httpErr.Err, endpoint.Name)
 			return httpErr
 		}
 
-		return httperror.InternalServerError("Unexpected error", fmt.Errorf("edge polling error: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.InternalServerError("Unexpected error", fmt.Errorf("edge polling error: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	return response.JSON(w, nil)
 }
 
-func (handler *Handler) updateEdgeJobLogs(tx dataservices.DataStoreTx, endpointID portainer.EndpointID, edgeJobID portainer.EdgeJobID, payload logsPayload) error {
+func (handler *Handler) getEdgeJobLobs(tx dataservices.DataStoreTx, endpointID portainer.EndpointID, edgeJobID portainer.EdgeJobID, payload logsPayload) error {
 	endpoint, err := tx.Endpoint().Endpoint(endpointID)
 	if tx.IsErrObjectNotFound(err) {
 		return httperror.NotFound("Unable to find an environment with the specified identifier inside the database", err)
@@ -86,11 +85,6 @@ func (handler *Handler) updateEdgeJobLogs(tx dataservices.DataStoreTx, endpointI
 		return httperror.InternalServerError("Unable to find an edge job with the specified identifier inside the database", err)
 	}
 
-	if resp, err := handler.buildSchedules(tx, endpoint, []portainer.EdgeJob{*edgeJob}); err != nil || len(resp) == 0 {
-		return httperror.InternalServerError("Unable to verify if the edge job is assigned to the environment",
-			fmt.Errorf("unable to verify if the edge job is assigned to the environment: %w. Environment name: %s", err, endpoint.Name))
-	}
-
 	if err := handler.FileService.StoreEdgeJobTaskLogFileFromBytes(strconv.Itoa(int(edgeJobID)), strconv.Itoa(int(endpoint.ID)), []byte(payload.FileContent)); err != nil {
 		return httperror.InternalServerError("Unable to save task log to the filesystem", err)
 	}

api/http/handler/endpointedge/endpointedge_job_logs_test.go

@@ -1,40 +0,0 @@
-package endpointedge
-
-import (
-	"testing"
-
-	portainer "github.com/portainer/portainer/api"
-	"github.com/portainer/portainer/api/dataservices"
-	"github.com/portainer/portainer/api/datastore"
-
-	"github.com/stretchr/testify/require"
-)
-
-func TestUpdateUnrelatedEdgeJobLogs(t *testing.T) {
-	_, store := datastore.MustNewTestStore(t, false, false)
-
-	h := &Handler{DataStore: store}
-
-	endpointID := portainer.EndpointID(2)
-	edgeJobID := portainer.EdgeJobID(3)
-	payload := logsPayload{FileContent: "log content"}
-
-	err := store.Endpoint().Create(&portainer.Endpoint{
-		ID:   endpointID,
-		Name: "test-endpoint",
-	})
-	require.NoError(t, err)
-
-	err = store.EdgeJob().CreateWithID(edgeJobID, &portainer.EdgeJob{
-		ID:   edgeJobID,
-		Name: "test-edge-job",
-	})
-	require.NoError(t, err)
-
-	// There is no relation between the edge job and the endpoint, so the
-	// update must fail
-	err = store.UpdateTx(func(tx dataservices.DataStoreTx) error {
-		return h.updateEdgeJobLogs(tx, endpointID, edgeJobID, payload)
-	})
-	require.Error(t, err)
-}

api/http/handler/endpointedge/endpointedge_stack_inspect.go

@@ -40,18 +40,18 @@ func (handler *Handler) endpointEdgeStackInspect(w http.ResponseWriter, r *http.
 	}
 
 	if err := handler.requestBouncer.AuthorizedEdgeEndpointOperation(r, endpoint); err != nil {
-		return httperror.Forbidden("Permission denied to access environment", fmt.Errorf("unauthorized edge endpoint operation: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.Forbidden("Permission denied to access environment", fmt.Errorf("unauthorized edge endpoint operation: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	edgeStackID, err := request.RetrieveNumericRouteVariableValue(r, "stackId")
 	if err != nil {
-		return httperror.BadRequest("Invalid edge stack identifier route variable", fmt.Errorf("invalid Edge stack route variable: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.BadRequest("Invalid edge stack identifier route variable", fmt.Errorf("invalid Edge stack route variable: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	s, err, _ := edgeStackSingleFlightGroup.Do(strconv.Itoa(edgeStackID), func() (any, error) {
 		edgeStack, err := handler.DataStore.EdgeStack().EdgeStack(portainer.EdgeStackID(edgeStackID))
 		if handler.DataStore.IsErrObjectNotFound(err) {
-			return nil, httperror.NotFound("Unable to find an edge stack with the specified identifier inside the database", fmt.Errorf("unable to find the Edge stack from database: %w. Environment ID: %d", err, endpoint.ID))
+			return nil, httperror.NotFound("Unable to find an edge stack with the specified identifier inside the database", fmt.Errorf("unable to find the Edge stack from database: %w. Environment name: %s", err, endpoint.Name))
 		}
 
 		return edgeStack, err
@@ -62,7 +62,7 @@ func (handler *Handler) endpointEdgeStackInspect(w http.ResponseWriter, r *http.
 			return httpErr
 		}
 
-		return httperror.InternalServerError("Unable to find an edge stack with the specified identifier inside the database", fmt.Errorf("failed to find Edge stack from the database: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.InternalServerError("Unable to find an edge stack with the specified identifier inside the database", fmt.Errorf("failed to find Edge stack from the database: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	// WARNING: this variable must not be mutated
@@ -71,7 +71,7 @@ func (handler *Handler) endpointEdgeStackInspect(w http.ResponseWriter, r *http.
 	fileName := edgeStack.EntryPoint
 	if endpointutils.IsDockerEndpoint(endpoint) {
 		if fileName == "" {
-			return httperror.BadRequest("Docker is not supported by this stack", fmt.Errorf("no filename is provided for the Docker endpoint. Environment ID: %d", endpoint.ID))
+			return httperror.BadRequest("Docker is not supported by this stack", fmt.Errorf("no filename is provided for the Docker endpoint. Environment name: %s", endpoint.Name))
 		}
 	}
 
@@ -84,18 +84,18 @@ func (handler *Handler) endpointEdgeStackInspect(w http.ResponseWriter, r *http.
 		fileName = edgeStack.ManifestPath
 
 		if fileName == "" {
-			return httperror.BadRequest("Kubernetes is not supported by this stack", fmt.Errorf("no filename is provided for the Kubernetes endpoint. Environment ID: %d", endpoint.ID))
+			return httperror.BadRequest("Kubernetes is not supported by this stack", fmt.Errorf("no filename is provided for the Kubernetes endpoint. Environment name: %s", endpoint.Name))
 		}
 	}
 
 	dirEntries, err := filesystem.LoadDir(edgeStack.ProjectPath)
 	if err != nil {
-		return httperror.InternalServerError("Unable to load repository", fmt.Errorf("failed to load project directory: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.InternalServerError("Unable to load repository", fmt.Errorf("failed to load project directory: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	fileContent, err := filesystem.FilterDirForCompatibility(dirEntries, fileName, endpoint.Agent.Version)
 	if err != nil {
-		return httperror.InternalServerError("File not found", fmt.Errorf("unable to find file: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.InternalServerError("File not found", fmt.Errorf("unable to find file: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	dirEntries = filesystem.FilterDirForEntryFile(dirEntries, fileName)
@@ -106,7 +106,5 @@ func (handler *Handler) endpointEdgeStackInspect(w http.ResponseWriter, r *http.
 		StackFileContent: fileContent,
 		Name:             edgeStack.Name,
 		Namespace:        namespace,
-		CreatedBy:        edgeStack.CreatedBy,
-		CreatedByUserId:  edgeStack.CreatedByUserId,
 	})
 }

api/http/handler/endpointedge/endpointedge_status_inspect.go

@@ -97,13 +97,13 @@ func (handler *Handler) endpointEdgeStatusInspect(w http.ResponseWriter, r *http
 	firstConn := endpoint.LastCheckInDate == 0
 
 	if err := handler.requestBouncer.AuthorizedEdgeEndpointOperation(r, endpoint); err != nil {
-		return httperror.Forbidden("Permission denied to access environment. The device has not been trusted yet", fmt.Errorf("unauthorized Edge endpoint operation: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.Forbidden("Permission denied to access environment. The device has not been trusted yet", fmt.Errorf("unauthorized Edge endpoint operation: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	handler.DataStore.Endpoint().UpdateHeartbeat(endpoint.ID)
 
 	if err := handler.requestBouncer.TrustedEdgeEnvironmentAccess(handler.DataStore, endpoint); err != nil {
-		return httperror.Forbidden("Permission denied to access environment. The device has not been trusted yet", fmt.Errorf("untrusted Edge environment access: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.Forbidden("Permission denied to access environment. The device has not been trusted yet", fmt.Errorf("untrusted Edge environment access: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	var statusResponse *endpointEdgeStatusInspectResponse
@@ -113,11 +113,11 @@ func (handler *Handler) endpointEdgeStatusInspect(w http.ResponseWriter, r *http
 	}); err != nil {
 		var httpErr *httperror.HandlerError
 		if errors.As(err, &httpErr) {
-			httpErr.Err = fmt.Errorf("edge polling error: %w. Environment ID: %d", httpErr.Err, endpoint.ID)
+			httpErr.Err = fmt.Errorf("edge polling error: %w. Environment name: %s", httpErr.Err, endpoint.Name)
 			return httpErr
 		}
 
-		return httperror.InternalServerError("Unexpected error", fmt.Errorf("edge polling error: %w. Environment ID: %d", err, endpoint.ID))
+		return httperror.InternalServerError("Unexpected error", fmt.Errorf("edge polling error: %w. Environment name: %s", err, endpoint.Name))
 	}
 
 	return cacheResponse(w, endpoint.ID, *statusResponse)
@@ -170,7 +170,7 @@ func (handler *Handler) inspectStatus(tx dataservices.DataStoreTx, r *http.Reque
 		Credentials:     tunnel.Credentials,
 	}
 
-	schedules, handlerErr := handler.buildAllSchedules(tx, endpoint)
+	schedules, handlerErr := handler.buildSchedules(tx, endpoint)
 	if handlerErr != nil {
 		return nil, handlerErr
 	}
@@ -208,18 +208,14 @@ func parseAgentPlatform(r *http.Request) (portainer.EndpointType, error) {
 	}
 }
 
-func (handler *Handler) buildAllSchedules(tx dataservices.DataStoreTx, endpoint *portainer.Endpoint) ([]edgeJobResponse, *httperror.HandlerError) {
+func (handler *Handler) buildSchedules(tx dataservices.DataStoreTx, endpoint *portainer.Endpoint) ([]edgeJobResponse, *httperror.HandlerError) {
+	schedules := []edgeJobResponse{}
+
 	edgeJobs, err := tx.EdgeJob().ReadAll()
 	if err != nil {
 		return nil, httperror.InternalServerError("Unable to retrieve Edge Jobs", err)
 	}
 
-	return handler.buildSchedules(tx, endpoint, edgeJobs)
-}
-
-func (handler *Handler) buildSchedules(tx dataservices.DataStoreTx, endpoint *portainer.Endpoint, edgeJobs []portainer.EdgeJob) ([]edgeJobResponse, *httperror.HandlerError) {
-	schedules := []edgeJobResponse{}
-
 	endpointGroups, err := tx.EndpointGroup().ReadAll()
 	if err != nil {
 		return nil, httperror.InternalServerError("Unable to retrieve endpoint groups", err)
@@ -244,10 +240,17 @@ func (handler *Handler) buildSchedules(tx dataservices.DataStoreTx, endpoint *po
 			continue
 		}
 
+		var collectLogs bool
+		if _, ok := job.GroupLogsCollection[endpoint.ID]; ok {
+			collectLogs = job.GroupLogsCollection[endpoint.ID].CollectLogs
+		} else {
+			collectLogs = job.Endpoints[endpoint.ID].CollectLogs
+		}
+
 		schedule := edgeJobResponse{
 			ID:             job.ID,
 			CronExpression: job.CronExpression,
-			CollectLogs:    job.GroupLogsCollection[endpoint.ID].CollectLogs || job.Endpoints[endpoint.ID].CollectLogs,
+			CollectLogs:    collectLogs,
 			Version:        job.Version,
 		}
 

api/http/handler/endpoints/endpoint_inspect.go

@@ -20,6 +20,7 @@ import (
 // @produce json
 // @param id path int true "Environment(Endpoint) identifier"
 // @param excludeSnapshot query bool false "if true, the snapshot data won't be retrieved"
+// @param excludeSnapshotRaw query bool false "if true, the SnapshotRaw field won't be retrieved"
 // @success 200 {object} portainer.Endpoint "Success"
 // @failure 400 "Invalid request"
 // @failure 404 "Environment(Endpoint) not found"
@@ -52,9 +53,10 @@ func (handler *Handler) endpointInspect(w http.ResponseWriter, r *http.Request)
 	endpoint.ComposeSyntaxMaxVersion = handler.ComposeStackManager.ComposeSyntaxMaxVersion()
 
 	excludeSnapshot, _ := request.RetrieveBooleanQueryParameter(r, "excludeSnapshot", true)
+	excludeRaw, _ := request.RetrieveBooleanQueryParameter(r, "excludeSnapshotRaw", true)
 
 	if !excludeSnapshot {
-		if err := handler.SnapshotService.FillSnapshotData(endpoint, false); err != nil {
+		if err := handler.SnapshotService.FillSnapshotData(endpoint, !excludeRaw); err != nil {
 			return httperror.InternalServerError("Unable to add snapshot data", err)
 		}
 	}

api/http/handler/endpoints/endpoint_list.go

@@ -45,6 +45,7 @@ const (
 // @param edgeDeviceUntrusted query bool false "if true, show only untrusted edge agents, if false show only trusted edge agents (relevant only for edge agents)"
 // @param edgeCheckInPassedSeconds query number false "if bigger then zero, show only edge agents that checked-in in the last provided seconds (relevant only for edge agents)"
 // @param excludeSnapshots query bool false "if true, the snapshot data won't be retrieved"
+// @param excludeSnapshotRaw query bool false "if true, the SnapshotRaw field won't be retrieved"
 // @param name query string false "will return only environments(endpoints) with this name"
 // @param edgeStackId query portainer.EdgeStackID false "will return the environements of the specified edge stack"
 // @param edgeStackStatus query string false "only applied when edgeStackId exists. Filter the returned environments based on their deployment status in the stack (not the environment status!)" Enum("Pending", "Ok", "Error", "Acknowledged", "Remove", "RemoteUpdateSuccess", "ImagesPulled")
@@ -62,6 +63,7 @@ func (handler *Handler) endpointList(w http.ResponseWriter, r *http.Request) *ht
 	limit, _ := request.RetrieveNumericQueryParameter(r, "limit", true)
 	sortField, _ := request.RetrieveQueryParameter(r, "sort", true)
 	sortOrder, _ := request.RetrieveQueryParameter(r, "order", true)
+	excludeRaw, _ := request.RetrieveBooleanQueryParameter(r, "excludeSnapshotRaw", true)
 
 	endpointGroups, err := handler.DataStore.EndpointGroup().ReadAll()
 	if err != nil {
@@ -116,7 +118,7 @@ func (handler *Handler) endpointList(w http.ResponseWriter, r *http.Request) *ht
 		endpointutils.UpdateEdgeEndpointHeartbeat(&paginatedEndpoints[idx], settings)
 
 		if !query.excludeSnapshots {
-			if err := handler.SnapshotService.FillSnapshotData(&paginatedEndpoints[idx], false); err != nil {
+			if err := handler.SnapshotService.FillSnapshotData(&paginatedEndpoints[idx], !excludeRaw); err != nil {
 				return httperror.InternalServerError("Unable to add snapshot data", err)
 			}
 		}

api/http/handler/endpoints/filter.go

@@ -256,7 +256,7 @@ func (handler *Handler) filterEndpointsByQuery(
 	return filteredEndpoints, totalAvailableEndpoints, nil
 }
 
-func endpointStatusInStackMatchesFilter(stackStatus *portainer.EdgeStackStatusForEnv, statusFilter portainer.EdgeStackStatusType) bool {
+func endpointStatusInStackMatchesFilter(stackStatus *portainer.EdgeStackStatusForEnv, envId portainer.EndpointID, statusFilter portainer.EdgeStackStatusType) bool {
 	// consider that if the env has no status in the stack it is in Pending state
 	if statusFilter == portainer.EdgeStackStatusPending {
 		return stackStatus == nil || len(stackStatus.Status) == 0
@@ -272,62 +272,55 @@ func endpointStatusInStackMatchesFilter(stackStatus *portainer.EdgeStackStatusFo
 }
 
 func filterEndpointsByEdgeStack(endpoints []portainer.Endpoint, edgeStackId portainer.EdgeStackID, statusFilter *portainer.EdgeStackStatusType, datastore dataservices.DataStore) ([]portainer.Endpoint, error) {
-	var filteredEndpoints []portainer.Endpoint
-	if err := datastore.ViewTx(func(tx dataservices.DataStoreTx) error {
-		stack, err := tx.EdgeStack().EdgeStack(edgeStackId)
-		if err != nil {
-			return errors.WithMessage(err, "Unable to retrieve edge stack from the database")
-		}
-
-		envIds := roar.Roar[portainer.EndpointID]{}
-		for _, edgeGroupId := range stack.EdgeGroups {
-			edgeGroup, err := tx.EdgeGroup().Read(edgeGroupId)
-			if err != nil {
-				return errors.WithMessage(err, "Unable to retrieve edge group from the database")
-			}
-
-			if edgeGroup.Dynamic {
-				endpointIDs, err := edgegroups.GetEndpointsByTags(tx, edgeGroup.TagIDs, edgeGroup.PartialMatch)
-				if err != nil {
-					return errors.WithMessage(err, "Unable to retrieve environments and environment groups for Edge group")
-				}
-				edgeGroup.EndpointIDs = roar.FromSlice(endpointIDs)
-			}
-
-			envIds.Union(edgeGroup.EndpointIDs)
-		}
-
-		filteredEnvIds := roar.Roar[portainer.EndpointID]{}
-		filteredEnvIds.Union(envIds)
-
-		if statusFilter != nil {
-			var innerErr error
-
-			envIds.Iterate(func(envId portainer.EndpointID) bool {
-				edgeStackStatus, err := tx.EdgeStackStatus().Read(edgeStackId, envId)
-				if err != nil && !dataservices.IsErrObjectNotFound(err) {
-					innerErr = errors.WithMessagef(err, "Unable to retrieve edge stack status for environment %d", envId)
-					return false
-				}
-
-				if !endpointStatusInStackMatchesFilter(edgeStackStatus, *statusFilter) {
-					filteredEnvIds.Remove(envId)
-				}
-
-				return true
-			})
-
-			if innerErr != nil {
-				return innerErr
-			}
-		}
-
-		filteredEndpoints = filteredEndpointsByIds(endpoints, filteredEnvIds)
-
-		return nil
-	}); err != nil {
-		return nil, err
+	stack, err := datastore.EdgeStack().EdgeStack(edgeStackId)
+	if err != nil {
+		return nil, errors.WithMessage(err, "Unable to retrieve edge stack from the database")
 	}
+
+	envIds := roar.Roar[portainer.EndpointID]{}
+	for _, edgeGroupdId := range stack.EdgeGroups {
+		edgeGroup, err := datastore.EdgeGroup().Read(edgeGroupdId)
+		if err != nil {
+			return nil, errors.WithMessage(err, "Unable to retrieve edge group from the database")
+		}
+
+		if edgeGroup.Dynamic {
+			endpointIDs, err := edgegroups.GetEndpointsByTags(datastore, edgeGroup.TagIDs, edgeGroup.PartialMatch)
+			if err != nil {
+				return nil, errors.WithMessage(err, "Unable to retrieve environments and environment groups for Edge group")
+			}
+			edgeGroup.EndpointIDs = roar.FromSlice(endpointIDs)
+		}
+
+		envIds.Union(edgeGroup.EndpointIDs)
+	}
+
+	if statusFilter != nil {
+		var innerErr error
+
+		envIds.Iterate(func(envId portainer.EndpointID) bool {
+			edgeStackStatus, err := datastore.EdgeStackStatus().Read(edgeStackId, envId)
+			if dataservices.IsErrObjectNotFound(err) {
+				return true
+			} else if err != nil {
+				innerErr = errors.WithMessagef(err, "Unable to retrieve edge stack status for environment %d", envId)
+				return false
+			}
+
+			if !endpointStatusInStackMatchesFilter(edgeStackStatus, portainer.EndpointID(envId), *statusFilter) {
+				envIds.Remove(envId)
+			}
+
+			return true
+		})
+
+		if innerErr != nil {
+			return nil, innerErr
+		}
+	}
+
+	filteredEndpoints := filteredEndpointsByIds(endpoints, envIds)
+
 	return filteredEndpoints, nil
 }
 

api/http/handler/endpoints/filter_test.go

@@ -5,7 +5,6 @@ import (
 	"testing"
 
 	portainer "github.com/portainer/portainer/api"
-	"github.com/portainer/portainer/api/dataservices"
 	"github.com/portainer/portainer/api/datastore"
 	"github.com/portainer/portainer/api/http/security"
 	"github.com/portainer/portainer/api/internal/testhelpers"
@@ -298,103 +297,42 @@ func TestFilterEndpointsByEdgeStack(t *testing.T) {
 	_, store := datastore.MustNewTestStore(t, false, false)
 
 	endpoints := []portainer.Endpoint{
-		{ID: 1, Name: "Endpoint 1", Type: portainer.EdgeAgentOnDockerEnvironment, UserTrusted: true},
-		{ID: 2, Name: "Endpoint 2", TagIDs: []portainer.TagID{1}, Type: portainer.EdgeAgentOnDockerEnvironment, UserTrusted: true},
-		{ID: 3, Name: "Endpoint 3", TagIDs: []portainer.TagID{1}, Type: portainer.EdgeAgentOnDockerEnvironment, UserTrusted: true},
+		{ID: 1, Name: "Endpoint 1"},
+		{ID: 2, Name: "Endpoint 2"},
+		{ID: 3, Name: "Endpoint 3"},
 		{ID: 4, Name: "Endpoint 4"},
 	}
 
 	edgeStackId := portainer.EdgeStackID(1)
-	require.NoError(t, store.UpdateTx(func(tx dataservices.DataStoreTx) error {
-		require.NoError(t, tx.Tag().Create(&portainer.Tag{ID: 1, Name: "tag", Endpoints: map[portainer.EndpointID]bool{2: true, 3: true}}))
 
-		for i := range endpoints {
-			require.NoError(t, tx.Endpoint().Create(&endpoints[i]))
-		}
-
-		require.NoError(t, tx.EdgeStack().Create(edgeStackId, &portainer.EdgeStack{
-			ID:         edgeStackId,
-			Name:       "Test Edge Stack",
-			EdgeGroups: []portainer.EdgeGroupID{1, 2},
-		}))
-
-		require.NoError(t, tx.EdgeGroup().Create(&portainer.EdgeGroup{
-			ID:          1,
-			Name:        "Edge Group 1",
-			EndpointIDs: roar.FromSlice([]portainer.EndpointID{1}),
-		}))
-
-		require.NoError(t, tx.EdgeGroup().Create(&portainer.EdgeGroup{
-			ID:      2,
-			Name:    "Edge Group 2",
-			Dynamic: true,
-			TagIDs:  []portainer.TagID{1},
-		}))
-
-		require.NoError(t, tx.EdgeStackStatus().Create(edgeStackId, endpoints[0].ID, &portainer.EdgeStackStatusForEnv{
-			Status: []portainer.EdgeStackDeploymentStatus{{Type: portainer.EdgeStackStatusAcknowledged}}}))
-
-		return nil
-	}))
-
-	test := func(status *portainer.EdgeStackStatusType, expected []portainer.Endpoint) {
-		tmp := make([]portainer.Endpoint, len(endpoints))
-		require.Equal(t, 4, copy(tmp, endpoints))
-		es, err := filterEndpointsByEdgeStack(tmp, edgeStackId, status, store)
-		require.NoError(t, err)
-		// validate that the len is the same
-		require.Len(t, es, len(expected))
-		// and that all items are the expected ones
-		for i := range expected {
-			require.Contains(t, es, expected[i])
-		}
-	}
-
-	test(nil, []portainer.Endpoint{endpoints[0], endpoints[1], endpoints[2]})
-
-	status := portainer.EdgeStackStatusPending
-	test(&status, []portainer.Endpoint{endpoints[1], endpoints[2]})
-
-	status = portainer.EdgeStackStatusCompleted
-	test(&status, []portainer.Endpoint{})
-
-	status = portainer.EdgeStackStatusAcknowledged
-	test(&status, []portainer.Endpoint{endpoints[0]}) // that's the only one with an edge stack status in DB
-}
-
-func TestErrorsFilterEndpointsByEdgeStack(t *testing.T) {
-	t.Run("must error by edge stack not found", func(t *testing.T) {
-		_, store := datastore.MustNewTestStore(t, false, false)
-		require.NotNil(t, store)
-
-		_, err := filterEndpointsByEdgeStack([]portainer.Endpoint{}, 1, nil, store)
-		require.Error(t, err)
+	err := store.EdgeStack().Create(edgeStackId, &portainer.EdgeStack{
+		ID:         edgeStackId,
+		Name:       "Test Edge Stack",
+		EdgeGroups: []portainer.EdgeGroupID{1, 2},
 	})
+	require.NoError(t, err)
 
-	t.Run("must error by edge group not found", func(t *testing.T) {
-		_, store := datastore.MustNewTestStore(t, false, false)
-		require.NotNil(t, store)
-
-		require.NoError(t, store.UpdateTx(func(tx dataservices.DataStoreTx) error {
-			require.NoError(t, tx.EdgeStack().Create(1, &portainer.EdgeStack{ID: 1, Name: "1", EdgeGroups: []portainer.EdgeGroupID{1}}))
-			return nil
-		}))
-		_, err := filterEndpointsByEdgeStack([]portainer.Endpoint{}, 1, nil, store)
-		require.Error(t, err)
+	err = store.EdgeGroup().Create(&portainer.EdgeGroup{
+		ID:          1,
+		Name:        "Edge Group 1",
+		EndpointIDs: roar.FromSlice([]portainer.EndpointID{1}),
 	})
+	require.NoError(t, err)
 
-	t.Run("must error by env tag not found", func(t *testing.T) {
-		_, store := datastore.MustNewTestStore(t, false, false)
-		require.NotNil(t, store)
-
-		require.NoError(t, store.UpdateTx(func(tx dataservices.DataStoreTx) error {
-			require.NoError(t, tx.EdgeStack().Create(1, &portainer.EdgeStack{ID: 1, Name: "1", EdgeGroups: []portainer.EdgeGroupID{1}}))
-			require.NoError(t, tx.EdgeGroup().Create(&portainer.EdgeGroup{ID: 1, Name: "edge group", Dynamic: true, TagIDs: []portainer.TagID{1}}))
-			return nil
-		}))
-		_, err := filterEndpointsByEdgeStack([]portainer.Endpoint{}, 1, nil, store)
-		require.Error(t, err)
+	err = store.EdgeGroup().Create(&portainer.EdgeGroup{
+		ID:          2,
+		Name:        "Edge Group 2",
+		EndpointIDs: roar.FromSlice([]portainer.EndpointID{2, 3}),
 	})
+	require.NoError(t, err)
+
+	es, err := filterEndpointsByEdgeStack(endpoints, edgeStackId, nil, store)
+	require.NoError(t, err)
+	require.Len(t, es, 3)
+	require.Contains(t, es, endpoints[0])    // Endpoint 1
+	require.Contains(t, es, endpoints[1])    // Endpoint 2
+	require.Contains(t, es, endpoints[2])    // Endpoint 3
+	require.NotContains(t, es, endpoints[3]) // Endpoint 4
 }
 
 func TestFilterEndpointsByEdgeGroup(t *testing.T) {

api/http/handler/handler.go

@@ -81,7 +81,7 @@ type Handler struct {
 }
 
 // @title PortainerCE API
-// @version 2.37.0
+// @version 2.34.0
 // @description.markdown api-description.md
 // @termsOfService
 

api/http/handler/hostmanagement/openamt/amtactivation.go

@@ -19,7 +19,6 @@ import (
 // @security jwt
 // @produce json
 // @param id path int true "Environment identifier"
-// @deprecated
 // @success 200 "Success"
 // @failure 400 "Invalid request"
 // @failure 403 "Permission denied to access settings"

api/http/handler/hostmanagement/openamt/amtconfiguration.go

@@ -63,7 +63,6 @@ func (payload *openAMTConfigurePayload) Validate(r *http.Request) error {
 // @security jwt
 // @accept json
 // @produce json
-// @deprecated
 // @param body body openAMTConfigurePayload true "OpenAMT Settings"
 // @success 204 "Success"
 // @failure 400 "Invalid request"

api/http/handler/hostmanagement/openamt/amtdevices.go

@@ -20,7 +20,6 @@ import (
 // @security jwt
 // @produce json
 // @param id path int true "Environment(Endpoint) identifier"
-// @deprecated
 // @success 200 "Success"
 // @failure 400 "Invalid request"
 // @failure 403 "Permission denied to access settings"
@@ -80,7 +79,6 @@ func (payload *deviceActionPayload) Validate(r *http.Request) error {
 // @security jwt
 // @accept json
 // @produce json
-// @deprecated
 // @param id path int true "Environment identifier"
 // @param deviceId path int true "Device identifier"
 // @param body body deviceActionPayload true "Device Action"
@@ -143,7 +141,6 @@ type AuthorizationResponse struct {
 // @security jwt
 // @accept json
 // @produce json
-// @deprecated
 // @param id path int true "Environment identifier"
 // @param deviceId path int true "Device identifier"
 // @param body body deviceFeaturesPayload true "Device Features"

api/http/handler/hostmanagement/openamt/amtrpc.go

@@ -48,7 +48,6 @@ const (
 // @security jwt
 // @produce json
 // @param id path int true "Environment identifier"
-// @deprecated
 // @success 200 "Success"
 // @failure 400 "Invalid request"
 // @failure 403 "Permission denied to access settings"

api/http/handler/hostmanagement/openamt/handler.go

@@ -8,7 +8,6 @@ import (
 	portainer "github.com/portainer/portainer/api"
 	"github.com/portainer/portainer/api/dataservices"
 	dockerclient "github.com/portainer/portainer/api/docker/client"
-	"github.com/portainer/portainer/api/http/middlewares"
 	"github.com/portainer/portainer/api/http/security"
 	httperror "github.com/portainer/portainer/pkg/libhttp/error"
 )
@@ -27,7 +26,6 @@ func NewHandler(bouncer security.BouncerService) *Handler {
 		Router: mux.NewRouter(),
 	}
 
-	h.Use(middlewares.DeprecatedSimple)
 	h.Handle("/open_amt/configure", bouncer.AdminAccess(httperror.LoggerHandler(h.openAMTConfigure))).Methods(http.MethodPost)
 	h.Handle("/open_amt/{id}/info", bouncer.AdminAccess(httperror.LoggerHandler(h.openAMTHostInfo))).Methods(http.MethodGet)
 	h.Handle("/open_amt/{id}/activate", bouncer.AdminAccess(httperror.LoggerHandler(h.openAMTActivate))).Methods(http.MethodPost)

api/http/handler/registries/handler.go

@@ -22,18 +22,8 @@ import (
 
 func hideFields(registry *portainer.Registry, hideAccesses bool) {
 	registry.Password = ""
-	if registry.ManagementConfiguration != nil {
-		// TLS and SkipTLSVerify should be retained since it's not sensitive information
-		minimalManagementConfig := &portainer.RegistryManagementConfiguration{}
-		minimalManagementConfig.TLSConfig = registry.ManagementConfiguration.TLSConfig
-		registry.ManagementConfiguration = minimalManagementConfig
-	}
+	registry.ManagementConfiguration = nil
 	if hideAccesses {
-		if registry.ManagementConfiguration != nil {
-			registry.ManagementConfiguration.TLSConfig.TLSCACertPath = ""
-			registry.ManagementConfiguration.TLSConfig.TLSCertPath = ""
-			registry.ManagementConfiguration.TLSConfig.TLSKeyPath = ""
-		}
 		registry.RegistryAccesses = nil
 	}
 }
@@ -81,7 +71,6 @@ func (handler *Handler) initRouter(bouncer accessGuard) {
 	// Keep the gitlab proxy on the regular authenticated router as it doesn't require specific registry access
 	authenticatedRouter := handler.NewRoute().Subrouter()
 	authenticatedRouter.Use(bouncer.AuthenticatedAccess)
-	authenticatedRouter.Handle("/registries/ping", httperror.LoggerHandler(handler.pingRegistry)).Methods(http.MethodPost)
 	authenticatedRouter.PathPrefix("/registries/proxies/gitlab").Handler(httperror.LoggerHandler(handler.proxyRequestsToGitlabAPIWithoutRegistry))
 }
 

api/http/handler/registries/registry_delete.go

@@ -7,7 +7,6 @@ import (
 	portainer "github.com/portainer/portainer/api"
 	httperrors "github.com/portainer/portainer/api/http/errors"
 	"github.com/portainer/portainer/api/http/security"
-	"github.com/portainer/portainer/api/internal/registryutils"
 	"github.com/portainer/portainer/api/pendingactions/handlers"
 	httperror "github.com/portainer/portainer/pkg/libhttp/error"
 	"github.com/portainer/portainer/pkg/libhttp/request"
@@ -81,7 +80,7 @@ func (handler *Handler) deleteKubernetesSecrets(registry *portainer.Registry) {
 			for _, ns := range access.Namespaces {
 				if err := cli.DeleteRegistrySecret(registry.ID, ns); err != nil {
 					failedNamespaces = append(failedNamespaces, ns)
-					log.Warn().Err(err).Msgf("Unable to delete registry secret %q from namespace %q for environment %d. Retrying offline", registryutils.RegistrySecretName(registry.ID), ns, endpointId)
+					log.Warn().Err(err).Msgf("Unable to delete registry secret %q from namespace %q for environment %d. Retrying offline", cli.RegistrySecretName(registry.ID), ns, endpointId)
 				}
 			}
 

api/http/handler/registries/registry_ping.go

@@ -1,180 +0,0 @@
-package registries
-
-import (
-	"context"
-	"errors"
-	"net/http"
-
-	portainer "github.com/portainer/portainer/api"
-	"github.com/portainer/portainer/pkg/fips"
-	httperror "github.com/portainer/portainer/pkg/libhttp/error"
-	"github.com/portainer/portainer/pkg/libhttp/request"
-	"github.com/portainer/portainer/pkg/libhttp/response"
-	"github.com/portainer/portainer/pkg/liboras"
-
-	"github.com/rs/zerolog/log"
-	"oras.land/oras-go/v2/registry/remote/errcode"
-)
-
-type registryPingPayload struct {
-	// Registry Type. Valid values are:
-	//	1 (Quay.io),
-	//	2 (Azure container registry),
-	//	3 (custom registry),
-	//	4 (Gitlab registry),
-	//	5 (ProGet registry),
-	//	6 (DockerHub)
-	//	7 (ECR)
-	//	8 (Github registry)
-	Type portainer.RegistryType `example:"6" validate:"required" enums:"1,2,3,4,5,6,7,8"`
-	// URL or IP address of the Docker registry
-	URL string `example:"registry-1.docker.io" validate:"required"`
-	// Username used to authenticate against this registry
-	Username string `example:"registry_user"`
-	// Password used to authenticate against this registry
-	Password string `example:"registry_password"`
-	// Use TLS
-	TLS bool `example:"true"`
-}
-
-type registryPingResponse struct {
-	// Success indicates if the registry connection was successful
-	Success bool `json:"success" example:"true"`
-	// Message provides details about the connection test result
-	Message string `json:"message" example:"Registry connection successful"`
-}
-
-func (payload *registryPingPayload) Validate(_ *http.Request) error {
-	if len(payload.Username) == 0 || len(payload.Password) == 0 {
-		return httperror.BadRequest("Username and password are required", nil)
-	}
-
-	switch payload.Type {
-	case portainer.QuayRegistry, portainer.AzureRegistry, portainer.CustomRegistry, portainer.GitlabRegistry, portainer.ProGetRegistry, portainer.DockerHubRegistry, portainer.EcrRegistry, portainer.GithubRegistry:
-	default:
-		return httperror.BadRequest("Invalid registry type. Valid values are: 1 (Quay.io), 2 (Azure container registry), 3 (custom registry), 4 (Gitlab registry), 5 (ProGet registry), 6 (DockerHub), 7 (ECR), 8 (Github registry)", nil)
-	}
-
-	return nil
-}
-
-// @id RegistryPing
-// @summary Test registry connection
-// @description Test connection to a registry with provided credentials
-// @description **Access policy**: authenticated
-// @tags registries
-// @security ApiKeyAuth
-// @security jwt
-// @accept json
-// @produce json
-// @param body body registryPingPayload true "Registry credentials to test"
-// @success 200 {object} registryPingResponse "Success"
-// @failure 400 "Invalid request"
-// @failure 500 "Server error"
-// @router /registries/ping [post]
-func (handler *Handler) pingRegistry(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
-	var payload registryPingPayload
-	err := request.DecodeAndValidateJSONPayload(r, &payload)
-	if err != nil {
-		return httperror.BadRequest("Invalid request payload", err)
-	}
-
-	// Create a temporary registry configuration for testing
-	tempRegistry := &portainer.Registry{
-		Type:           payload.Type,
-		URL:            payload.URL,
-		Authentication: true,
-		Username:       payload.Username,
-		Password:       payload.Password,
-	}
-
-	// For DockerHub, ensure URL is set correctly
-	if payload.Type == portainer.DockerHubRegistry && payload.URL == "" {
-		tempRegistry.URL = "registry-1.docker.io"
-	}
-
-	// Set up TLS configuration
-	if payload.Type == portainer.CustomRegistry {
-		tempRegistry.ManagementConfiguration = &portainer.RegistryManagementConfiguration{
-			Type: payload.Type,
-			TLSConfig: portainer.TLSConfiguration{
-				TLS: payload.TLS || fips.FIPSMode(),
-			},
-		}
-	}
-
-	// Test the registry connection
-	success, message := handler.testRegistryConnection(tempRegistry)
-
-	responseData := registryPingResponse{
-		Success: success,
-		Message: message,
-	}
-
-	return response.JSON(w, responseData)
-}
-
-// testRegistryConnection tests if we can connect to the registry
-func (handler *Handler) testRegistryConnection(registry *portainer.Registry) (bool, string) {
-	registryClient, err := liboras.CreateClient(*registry)
-	if err != nil {
-		log.Error().Err(err).Str("registryURL", registry.URL).Msg("Failed to create registry client")
-		return false, "Connection error: Failed to create registry client - " + err.Error()
-	}
-
-	ctx := context.Background()
-	err = registryClient.Ping(ctx)
-	if err != nil {
-		errorMessage := categorizeRegistryError(err, registry.URL)
-		return false, errorMessage
-	}
-
-	log.Debug().Str("registryURL", registry.URL).Msg("Registry ping successful")
-	return true, "Registry connection successful"
-}
-
-// categorizeRegistryError analyzes the error and returns a user-friendly message
-// that distinguishes between connection errors and authentication errors
-func categorizeRegistryError(err error, registryURL string) string {
-	if err == nil {
-		return ""
-	}
-
-	var userMessage string
-
-	var errResp *errcode.ErrorResponse
-	if errors.As(err, &errResp) {
-
-		// 401 Unauthorized or 403 Forbidden = authentication/authorization issue
-		if errResp.StatusCode == http.StatusUnauthorized || errResp.StatusCode == http.StatusForbidden {
-			userMessage = "Access token invalid: Authentication failed - please verify your username and access token"
-		} else {
-			userMessage = "Connection error: " + err.Error()
-		}
-
-		logEvent := log.Error().
-			Err(err).
-			Str("registryURL", registryURL).
-			Int("statusCode", errResp.StatusCode).
-			Str("userMessage", userMessage)
-
-		if len(errResp.Errors) > 0 {
-			logEvent.Interface("errors", errResp.Errors)
-		}
-
-		logEvent.Msg("Registry ping failed")
-
-		return userMessage
-	}
-
-	// Default: treat everything else as connection error
-	userMessage = "Connection error: " + err.Error()
-
-	log.Error().
-		Err(err).
-		Str("registryURL", registryURL).
-		Str("userMessage", userMessage).
-		Msg("Registry ping failed")
-
-	return userMessage
-}

api/http/handler/registries/registry_ping_test.go

@@ -1,334 +0,0 @@
-package registries
-
-import (
-	"bytes"
-	"errors"
-	"net/http"
-	"net/http/httptest"
-	"net/url"
-	"testing"
-
-	portainer "github.com/portainer/portainer/api"
-	"github.com/portainer/portainer/api/datastore"
-	"github.com/portainer/portainer/api/http/security"
-	"github.com/portainer/portainer/api/internal/testhelpers"
-
-	"github.com/segmentio/encoding/json"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"oras.land/oras-go/v2/registry/remote/errcode"
-)
-
-func Test_categorizeRegistryError(t *testing.T) {
-	tests := []struct {
-		name        string
-		err         error
-		registryURL string
-		want        string
-	}{
-		{
-			name:        "nil error returns empty string",
-			err:         nil,
-			registryURL: "registry.example.com",
-			want:        "",
-		},
-		{
-			name: "401 Unauthorized returns access token invalid message",
-			err: &errcode.ErrorResponse{
-				StatusCode: http.StatusUnauthorized,
-			},
-			registryURL: "registry-1.docker.io",
-			want:        "Access token invalid: Authentication failed - please verify your username and access token",
-		},
-		{
-			name: "403 Forbidden returns access token invalid message",
-			err: &errcode.ErrorResponse{
-				StatusCode: http.StatusForbidden,
-			},
-			registryURL: "registry-1.docker.io",
-			want:        "Access token invalid: Authentication failed - please verify your username and access token",
-		},
-		{
-			name: "500 Internal Server Error returns connection error",
-			err: &errcode.ErrorResponse{
-				StatusCode: http.StatusInternalServerError,
-				Method:     "GET",
-				URL:        &url.URL{Scheme: "https", Host: "registry-1.docker.io", Path: "/v2/"},
-				Errors:     errcode.Errors{},
-			},
-			registryURL: "registry-1.docker.io",
-			want:        "Connection error: GET \"https://registry-1.docker.io/v2/\": response status code 500: Internal Server Error",
-		},
-		{
-			name: "404 Not Found returns connection error",
-			err: &errcode.ErrorResponse{
-				StatusCode: http.StatusNotFound,
-				Method:     "GET",
-				URL:        &url.URL{Scheme: "https", Host: "registry.example.com", Path: "/v2/"},
-				Errors:     errcode.Errors{},
-			},
-			registryURL: "registry.example.com",
-			want:        "Connection error: GET \"https://registry.example.com/v2/\": response status code 404: Not Found",
-		},
-		{
-			name: "400 Bad Request with error details returns connection error with details",
-			err: &errcode.ErrorResponse{
-				StatusCode: http.StatusBadRequest,
-				Method:     "GET",
-				URL:        &url.URL{Scheme: "https", Host: "registry.example.com", Path: "/v2/"},
-				Errors: errcode.Errors{
-					{
-						Code:    errcode.ErrorCodeNameInvalid,
-						Message: "invalid repository name",
-					},
-				},
-			},
-			registryURL: "registry.example.com",
-			want:        "Connection error: GET \"https://registry.example.com/v2/\": response status code 400: name invalid: invalid repository name",
-		},
-		{
-			name:        "non-errcode error returns connection error",
-			err:         errors.New("dial tcp: lookup registry.example.com: no such host"),
-			registryURL: "registry.example.com",
-			want:        "Connection error: dial tcp: lookup registry.example.com: no such host",
-		},
-		{
-			name:        "network timeout error returns connection error",
-			err:         errors.New("context deadline exceeded"),
-			registryURL: "registry.example.com",
-			want:        "Connection error: context deadline exceeded",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			got := categorizeRegistryError(tt.err, tt.registryURL)
-			assert.Equal(t, tt.want, got)
-		})
-	}
-}
-
-func Test_registryPingPayload_Validate(t *testing.T) {
-	tests := []struct {
-		name    string
-		payload registryPingPayload
-		wantErr bool
-		errMsg  string
-	}{
-		{
-			name: "valid DockerHub payload",
-			payload: registryPingPayload{
-				Type:     6, // DockerHub
-				URL:      "registry-1.docker.io",
-				Username: "testuser",
-				Password: "testpass",
-			},
-			wantErr: false,
-		},
-		{
-			name: "valid custom registry payload",
-			payload: registryPingPayload{
-				Type:     3, // Custom
-				URL:      "registry.example.com",
-				Username: "admin",
-				Password: "secret",
-				TLS:      true,
-			},
-			wantErr: false,
-		},
-		{
-			name: "empty username returns error",
-			payload: registryPingPayload{
-				Type:     6,
-				URL:      "registry-1.docker.io",
-				Username: "",
-				Password: "testpass",
-			},
-			wantErr: true,
-			errMsg:  "Username and password are required",
-		},
-		{
-			name: "empty password returns error",
-			payload: registryPingPayload{
-				Type:     6,
-				URL:      "registry-1.docker.io",
-				Username: "testuser",
-				Password: "",
-			},
-			wantErr: true,
-			errMsg:  "Username and password are required",
-		},
-		{
-			name: "invalid registry type returns error",
-			payload: registryPingPayload{
-				Type:     99, // Invalid type
-				URL:      "registry-1.docker.io",
-				Username: "testuser",
-				Password: "testpass",
-			},
-			wantErr: true,
-			errMsg:  "Invalid registry type",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			err := tt.payload.Validate(nil)
-			if tt.wantErr {
-				require.Error(t, err)
-				if tt.errMsg != "" {
-					assert.Contains(t, err.Error(), tt.errMsg)
-				}
-			} else {
-				assert.NoError(t, err)
-			}
-		})
-	}
-}
-
-func TestHandler_pingRegistry(t *testing.T) {
-	_, store := datastore.MustNewTestStore(t, false, false)
-
-	handler := NewHandler(testhelpers.NewTestRequestBouncer())
-	handler.DataStore = store
-
-	tests := []struct {
-		name           string
-		payload        registryPingPayload
-		wantStatusCode int
-		wantSuccess    bool
-		checkResponse  func(t *testing.T, resp registryPingResponse)
-	}{
-		{
-			name: "invalid payload - empty username",
-			payload: registryPingPayload{
-				Type:     portainer.DockerHubRegistry,
-				URL:      "registry-1.docker.io",
-				Username: "",
-				Password: "testpass",
-			},
-			wantStatusCode: http.StatusBadRequest,
-		},
-		{
-			name: "invalid payload - empty password",
-			payload: registryPingPayload{
-				Type:     portainer.DockerHubRegistry,
-				URL:      "registry-1.docker.io",
-				Username: "testuser",
-				Password: "",
-			},
-			wantStatusCode: http.StatusBadRequest,
-		},
-		{
-			name: "invalid payload - invalid registry type",
-			payload: registryPingPayload{
-				Type:     99,
-				URL:      "registry-1.docker.io",
-				Username: "testuser",
-				Password: "testpass",
-			},
-			wantStatusCode: http.StatusBadRequest,
-		},
-		{
-			name: "valid payload with invalid credentials returns 200 with success=false",
-			payload: registryPingPayload{
-				Type:     portainer.DockerHubRegistry,
-				URL:      "registry-1.docker.io",
-				Username: "invalid-user",
-				Password: "invalid-pass",
-			},
-			wantStatusCode: http.StatusOK,
-			wantSuccess:    false,
-			checkResponse: func(t *testing.T, resp registryPingResponse) {
-				assert.False(t, resp.Success)
-				assert.Contains(t, resp.Message, "Access token invalid")
-			},
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			payloadBytes, err := json.Marshal(tt.payload)
-			require.NoError(t, err)
-
-			r := httptest.NewRequest(http.MethodPost, "/registries/ping", bytes.NewReader(payloadBytes))
-			w := httptest.NewRecorder()
-
-			// Set up security context
-			restrictedContext := &security.RestrictedRequestContext{
-				IsAdmin:         true,
-				UserID:          1,
-				UserMemberships: []portainer.TeamMembership{},
-			}
-			ctx := security.StoreRestrictedRequestContext(r, restrictedContext)
-			r = r.WithContext(ctx)
-
-			handlerErr := handler.pingRegistry(w, r)
-
-			if tt.wantStatusCode != http.StatusOK {
-				// For error cases, check the handler returns an error
-				require.NotNil(t, handlerErr)
-				assert.Equal(t, tt.wantStatusCode, handlerErr.StatusCode)
-			} else {
-				// For success cases (200), even if the ping failed
-				require.Nil(t, handlerErr)
-				assert.Equal(t, http.StatusOK, w.Code)
-
-				var resp registryPingResponse
-				err := json.Unmarshal(w.Body.Bytes(), &resp)
-				require.NoError(t, err)
-
-				assert.Equal(t, tt.wantSuccess, resp.Success)
-
-				if tt.checkResponse != nil {
-					tt.checkResponse(t, resp)
-				}
-			}
-		})
-	}
-}
-
-func TestHandler_pingRegistry_DockerHubURL(t *testing.T) {
-	_, store := datastore.MustNewTestStore(t, false, false)
-
-	handler := NewHandler(testhelpers.NewTestRequestBouncer())
-	handler.DataStore = store
-
-	t.Run("empty URL for DockerHub gets default URL", func(t *testing.T) {
-		payload := registryPingPayload{
-			Type:     portainer.DockerHubRegistry,
-			URL:      "", // Empty URL
-			Username: "testuser",
-			Password: "testpass",
-		}
-
-		payloadBytes, err := json.Marshal(payload)
-		require.NoError(t, err)
-
-		r := httptest.NewRequest(http.MethodPost, "/registries/ping", bytes.NewReader(payloadBytes))
-		w := httptest.NewRecorder()
-
-		restrictedContext := &security.RestrictedRequestContext{
-			IsAdmin:         true,
-			UserID:          1,
-			UserMemberships: []portainer.TeamMembership{},
-		}
-		ctx := security.StoreRestrictedRequestContext(r, restrictedContext)
-		r = r.WithContext(ctx)
-
-		handlerErr := handler.pingRegistry(w, r)
-
-		// Should succeed (handler returns nil), but the ping itself will fail with auth error
-		require.Nil(t, handlerErr)
-		assert.Equal(t, http.StatusOK, w.Code)
-
-		var resp registryPingResponse
-		err = json.Unmarshal(w.Body.Bytes(), &resp)
-		require.NoError(t, err)
-
-		// The ping will fail (invalid credentials), but that's expected
-		// We're just testing that the URL defaulting logic works
-		assert.False(t, resp.Success)
-		assert.Contains(t, resp.Message, "Access token invalid")
-	})
-}

api/http/handler/stacks/stack_test_helper.go

@@ -1,53 +0,0 @@
-package stacks
-
-import (
-	"io"
-	"net/http"
-	"net/http/httptest"
-
-	portainer "github.com/portainer/portainer/api"
-	"github.com/portainer/portainer/api/datastore"
-	"github.com/portainer/portainer/api/http/security"
-	"github.com/portainer/portainer/api/internal/authorization"
-)
-
-func mockCreateUser(store *datastore.Store) (*portainer.User, error) {
-	user := &portainer.User{ID: 1, Username: "testUser", Role: portainer.AdministratorRole, PortainerAuthorizations: authorization.DefaultPortainerAuthorizations()}
-	err := store.User().Create(user)
-	return user, err
-}
-
-func mockCreateEndpoint(store *datastore.Store) (*portainer.Endpoint, error) {
-	endpoint := &portainer.Endpoint{
-		ID:   1,
-		Name: "testEndpoint",
-		SecuritySettings: portainer.EndpointSecuritySettings{
-			AllowBindMountsForRegularUsers:            true,
-			AllowPrivilegedModeForRegularUsers:        true,
-			AllowVolumeBrowserForRegularUsers:         true,
-			AllowHostNamespaceForRegularUsers:         true,
-			AllowDeviceMappingForRegularUsers:         true,
-			AllowStackManagementForRegularUsers:       true,
-			AllowContainerCapabilitiesForRegularUsers: true,
-			AllowSysctlSettingForRegularUsers:         true,
-			EnableHostManagementFeatures:              true,
-		},
-	}
-
-	err := store.Endpoint().Create(endpoint)
-
-	return endpoint, err
-}
-
-func mockCreateStackRequestWithSecurityContext(method, target string, body io.Reader) *http.Request {
-	req := httptest.NewRequest(method,
-		target,
-		body)
-
-	ctx := security.StoreRestrictedRequestContext(req, &security.RestrictedRequestContext{
-		IsAdmin: true,
-		UserID:  portainer.UserID(1),
-	})
-
-	return req.WithContext(ctx)
-}

api/http/handler/stacks/stack_update.go

@@ -6,7 +6,6 @@ import (
 	"time"
 
 	portainer "github.com/portainer/portainer/api"
-	"github.com/portainer/portainer/api/dataservices"
 	httperrors "github.com/portainer/portainer/api/http/errors"
 	"github.com/portainer/portainer/api/http/security"
 	"github.com/portainer/portainer/api/stacks/deployments"
@@ -24,10 +23,6 @@ type updateComposeStackPayload struct {
 	StackFileContent string `example:"version: 3\n services:\n web:\n image:nginx"`
 	// A list of environment(endpoint) variables used during stack deployment
 	Env []portainer.Pair
-	// RepullImageAndRedeploy indicates whether to force repulling images and redeploying the stack
-	RepullImageAndRedeploy bool
-
-	// Deprecated(2.36): use RepullImageAndRedeploy instead for cleaner responsibility
 	// Force a pulling to current image with the original tag though the image is already the latest
 	PullImage bool `example:"false"`
 }
@@ -47,10 +42,6 @@ type updateSwarmStackPayload struct {
 	Env []portainer.Pair
 	// Prune services that are no longer referenced (only available for Swarm stacks)
 	Prune bool `example:"true"`
-	// RepullImageAndRedeploy indicates whether to force repulling images and redeploying the stack
-	RepullImageAndRedeploy bool
-
-	// Deprecated(2.36): use RepullImageAndRedeploy instead for cleaner responsibility
 	// Force a pulling to current image with the original tag though the image is already the latest
 	PullImage bool `example:"false"`
 }
@@ -87,6 +78,13 @@ func (handler *Handler) stackUpdate(w http.ResponseWriter, r *http.Request) *htt
 		return httperror.BadRequest("Invalid stack identifier route variable", err)
 	}
 
+	stack, err := handler.DataStore.Stack().Read(portainer.StackID(stackID))
+	if handler.DataStore.IsErrObjectNotFound(err) {
+		return httperror.NotFound("Unable to find a stack with the specified identifier inside the database", err)
+	} else if err != nil {
+		return httperror.InternalServerError("Unable to find a stack with the specified identifier inside the database", err)
+	}
+
 	// TODO: this is a work-around for stacks created with Portainer version >= 1.17.1
 	// The EndpointID property is not available for these stacks, this API endpoint
 	// can use the optional EndpointID query parameter to associate a valid environment(endpoint) identifier to the stack.
@@ -94,84 +92,63 @@ func (handler *Handler) stackUpdate(w http.ResponseWriter, r *http.Request) *htt
 	if err != nil {
 		return httperror.BadRequest("Invalid query parameter: endpointId", err)
 	}
-
-	var stack *portainer.Stack
-	err = handler.DataStore.UpdateTx(func(tx dataservices.DataStoreTx) error {
-		var httpErr *httperror.HandlerError
-		stack, httpErr = handler.updateStackInTx(tx, r, portainer.StackID(stackID), portainer.EndpointID(endpointID))
-		if httpErr != nil {
-			return httpErr
-		}
-		return nil
-	})
-	return response.TxResponse(w, stack, err)
-}
-
-func (handler *Handler) updateStackInTx(tx dataservices.DataStoreTx, r *http.Request, stackID portainer.StackID, endpointID portainer.EndpointID) (*portainer.Stack, *httperror.HandlerError) {
-	stack, err := tx.Stack().Read(stackID)
-	if tx.IsErrObjectNotFound(err) {
-		return nil, httperror.NotFound("Unable to find a stack with the specified identifier inside the database", err)
-	} else if err != nil {
-		return nil, httperror.InternalServerError("Unable to find a stack with the specified identifier inside the database", err)
+	if endpointID != int(stack.EndpointID) {
+		stack.EndpointID = portainer.EndpointID(endpointID)
 	}
 
-	if endpointID != 0 && endpointID != stack.EndpointID {
-		stack.EndpointID = endpointID
-	}
-
-	endpoint, err := tx.Endpoint().Endpoint(stack.EndpointID)
-	if tx.IsErrObjectNotFound(err) {
-		return nil, httperror.NotFound("Unable to find the environment associated to the stack inside the database", err)
+	endpoint, err := handler.DataStore.Endpoint().Endpoint(stack.EndpointID)
+	if handler.DataStore.IsErrObjectNotFound(err) {
+		return httperror.NotFound("Unable to find the environment associated to the stack inside the database", err)
 	} else if err != nil {
-		return nil, httperror.InternalServerError("Unable to find the environment associated to the stack inside the database", err)
+		return httperror.InternalServerError("Unable to find the environment associated to the stack inside the database", err)
 	}
 
 	if err := handler.requestBouncer.AuthorizedEndpointOperation(r, endpoint); err != nil {
-		return nil, httperror.Forbidden("Permission denied to access environment", err)
+		return httperror.Forbidden("Permission denied to access environment", err)
 	}
 
 	securityContext, err := security.RetrieveRestrictedRequestContext(r)
 	if err != nil {
-		return nil, httperror.InternalServerError("Unable to retrieve info from request context", err)
+		return httperror.InternalServerError("Unable to retrieve info from request context", err)
 	}
 
 	//only check resource control when it is a DockerSwarmStack or a DockerComposeStack
 	if stack.Type == portainer.DockerSwarmStack || stack.Type == portainer.DockerComposeStack {
-		resourceControl, err := tx.ResourceControl().ResourceControlByResourceIDAndType(stackutils.ResourceControlID(stack.EndpointID, stack.Name), portainer.StackResourceControl)
+		resourceControl, err := handler.DataStore.ResourceControl().ResourceControlByResourceIDAndType(stackutils.ResourceControlID(stack.EndpointID, stack.Name), portainer.StackResourceControl)
 		if err != nil {
-			return nil, httperror.InternalServerError("Unable to retrieve a resource control associated to the stack", err)
+			return httperror.InternalServerError("Unable to retrieve a resource control associated to the stack", err)
 		}
 
 		if access, err := handler.userCanAccessStack(securityContext, endpoint.ID, resourceControl); err != nil {
-			return nil, httperror.InternalServerError("Unable to verify user authorizations to validate stack access", err)
+			return httperror.InternalServerError("Unable to verify user authorizations to validate stack access", err)
 		} else if !access {
-			return nil, httperror.Forbidden("Access denied to resource", httperrors.ErrResourceAccessDenied)
+			return httperror.Forbidden("Access denied to resource", httperrors.ErrResourceAccessDenied)
 		}
 	}
 
 	if canManage, err := handler.userCanManageStacks(securityContext, endpoint); err != nil {
-		return nil, httperror.InternalServerError("Unable to verify user authorizations to validate stack deletion", err)
+		return httperror.InternalServerError("Unable to verify user authorizations to validate stack deletion", err)
 	} else if !canManage {
 		errMsg := "Stack editing is disabled for non-admin users"
 
-		return nil, httperror.Forbidden(errMsg, errors.New(errMsg))
+		return httperror.Forbidden(errMsg, errors.New(errMsg))
 	}
 
-	if err := handler.updateAndDeployStack(tx, r, stack, endpoint); err != nil {
-		return nil, err
+	if err := handler.updateAndDeployStack(r, stack, endpoint); err != nil {
+		return err
 	}
 
-	user, err := tx.User().Read(securityContext.UserID)
+	user, err := handler.DataStore.User().Read(securityContext.UserID)
 	if err != nil {
-		return nil, httperror.BadRequest("Cannot find context user", errors.Wrap(err, "failed to fetch the user"))
+		return httperror.BadRequest("Cannot find context user", errors.Wrap(err, "failed to fetch the user"))
 	}
 
 	stack.UpdatedBy = user.Username
 	stack.UpdateDate = time.Now().Unix()
 	stack.Status = portainer.StackStatusActive
 
-	if err := tx.Stack().Update(stack.ID, stack); err != nil {
-		return nil, httperror.InternalServerError("Unable to persist the stack changes inside the database", err)
+	if err := handler.DataStore.Stack().Update(stack.ID, stack); err != nil {
+		return httperror.InternalServerError("Unable to persist the stack changes inside the database", err)
 	}
 
 	if stack.GitConfig != nil && stack.GitConfig.Authentication != nil && stack.GitConfig.Authentication.Password != "" {
@@ -179,19 +156,19 @@ func (handler *Handler) updateStackInTx(tx dataservices.DataStoreTx, r *http.Req
 		stack.GitConfig.Authentication.Password = ""
 	}
 
-	return stack, nil
+	return response.JSON(w, stack)
 }
 
-func (handler *Handler) updateAndDeployStack(tx dataservices.DataStoreTx, r *http.Request, stack *portainer.Stack, endpoint *portainer.Endpoint) *httperror.HandlerError {
+func (handler *Handler) updateAndDeployStack(r *http.Request, stack *portainer.Stack, endpoint *portainer.Endpoint) *httperror.HandlerError {
 	switch stack.Type {
 	case portainer.DockerSwarmStack:
 		stack.Name = handler.SwarmStackManager.NormalizeStackName(stack.Name)
 
-		return handler.updateSwarmStack(tx, r, stack, endpoint)
+		return handler.updateSwarmStack(r, stack, endpoint)
 	case portainer.DockerComposeStack:
 		stack.Name = handler.ComposeStackManager.NormalizeStackName(stack.Name)
 
-		return handler.updateComposeStack(tx, r, stack, endpoint)
+		return handler.updateComposeStack(r, stack, endpoint)
 	case portainer.KubernetesStack:
 		return handler.updateKubernetesStack(r, stack, endpoint)
 	}
@@ -199,7 +176,7 @@ func (handler *Handler) updateAndDeployStack(tx dataservices.DataStoreTx, r *htt
 	return httperror.InternalServerError("Unsupported stack", errors.Errorf("unsupported stack type: %v", stack.Type))
 }
 
-func (handler *Handler) updateComposeStack(tx dataservices.DataStoreTx, r *http.Request, stack *portainer.Stack, endpoint *portainer.Endpoint) *httperror.HandlerError {
+func (handler *Handler) updateComposeStack(r *http.Request, stack *portainer.Stack, endpoint *portainer.Endpoint) *httperror.HandlerError {
 	// Must not be git based stack. stop the auto update job if there is any
 	if stack.AutoUpdate != nil {
 		deployments.StopAutoupdate(stack.ID, stack.AutoUpdate.JobID, handler.Scheduler)
@@ -214,7 +191,6 @@ func (handler *Handler) updateComposeStack(tx dataservices.DataStoreTx, r *http.
 		return httperror.BadRequest("Invalid request payload", err)
 	}
 
-	payload.RepullImageAndRedeploy = payload.RepullImageAndRedeploy || payload.PullImage
 	stack.Env = payload.Env
 
 	if stack.GitConfig != nil {
@@ -237,13 +213,14 @@ func (handler *Handler) updateComposeStack(tx dataservices.DataStoreTx, r *http.
 		return httperror.InternalServerError("Unable to retrieve info from request context", err)
 	}
 
-	composeDeploymentConfig, err := deployments.CreateComposeStackDeploymentConfigTx(tx, securityContext,
+	composeDeploymentConfig, err := deployments.CreateComposeStackDeploymentConfig(securityContext,
 		stack,
 		endpoint,
+		handler.DataStore,
 		handler.FileService,
 		handler.StackDeployer,
-		payload.RepullImageAndRedeploy,
-		payload.RepullImageAndRedeploy)
+		payload.PullImage,
+		false)
 	if err != nil {
 		if rollbackErr := handler.FileService.RollbackStackFile(stackFolder, stack.EntryPoint); rollbackErr != nil {
 			log.Warn().Err(rollbackErr).Msg("rollback stack file error")
@@ -266,7 +243,7 @@ func (handler *Handler) updateComposeStack(tx dataservices.DataStoreTx, r *http.
 	return nil
 }
 
-func (handler *Handler) updateSwarmStack(tx dataservices.DataStoreTx, r *http.Request, stack *portainer.Stack, endpoint *portainer.Endpoint) *httperror.HandlerError {
+func (handler *Handler) updateSwarmStack(r *http.Request, stack *portainer.Stack, endpoint *portainer.Endpoint) *httperror.HandlerError {
 	// Must not be git based stack. stop the auto update job if there is any
 	if stack.AutoUpdate != nil {
 		deployments.StopAutoupdate(stack.ID, stack.AutoUpdate.JobID, handler.Scheduler)
@@ -280,7 +257,7 @@ func (handler *Handler) updateSwarmStack(tx dataservices.DataStoreTx, r *http.Re
 	if err := request.DecodeAndValidateJSONPayload(r, &payload); err != nil {
 		return httperror.BadRequest("Invalid request payload", err)
 	}
-	payload.RepullImageAndRedeploy = payload.RepullImageAndRedeploy || payload.PullImage
+
 	stack.Env = payload.Env
 
 	if stack.GitConfig != nil {
@@ -303,13 +280,14 @@ func (handler *Handler) updateSwarmStack(tx dataservices.DataStoreTx, r *http.Re
 		return httperror.InternalServerError("Unable to retrieve info from request context", err)
 	}
 
-	swarmDeploymentConfig, err := deployments.CreateSwarmStackDeploymentConfigTx(tx, securityContext,
+	swarmDeploymentConfig, err := deployments.CreateSwarmStackDeploymentConfig(securityContext,
 		stack,
 		endpoint,
+		handler.DataStore,
 		handler.FileService,
 		handler.StackDeployer,
 		payload.Prune,
-		payload.RepullImageAndRedeploy)
+		payload.PullImage)
 	if err != nil {
 		if rollbackErr := handler.FileService.RollbackStackFile(stackFolder, stack.EntryPoint); rollbackErr != nil {
 			log.Warn().Err(rollbackErr).Msg("rollback stack file error")
@@ -318,14 +296,6 @@ func (handler *Handler) updateSwarmStack(tx dataservices.DataStoreTx, r *http.Re
 		return httperror.InternalServerError(err.Error(), err)
 	}
 
-	if stack.Option != nil {
-		stack.Option.Prune = payload.Prune
-	} else {
-		stack.Option = &portainer.StackOption{
-			Prune: payload.Prune,
-		}
-	}
-
 	// Deploy the stack
 	if err := swarmDeploymentConfig.Deploy(); err != nil {
 		if rollbackErr := handler.FileService.RollbackStackFile(stackFolder, stack.EntryPoint); rollbackErr != nil {

api/http/handler/stacks/stack_update_git.go

@@ -73,14 +73,6 @@ func (handler *Handler) stackUpdateGit(w http.ResponseWriter, r *http.Request) *
 		return httperror.InternalServerError(msg, errors.New(msg))
 	}
 
-	if payload.AutoUpdate != nil && payload.AutoUpdate.Webhook != "" &&
-		(stack.AutoUpdate == nil ||
-			(stack.AutoUpdate != nil && stack.AutoUpdate.Webhook != payload.AutoUpdate.Webhook)) {
-		if isUnique, err := handler.checkUniqueWebhookID(payload.AutoUpdate.Webhook); !isUnique || err != nil {
-			return httperror.Conflict("Webhook ID already exists", errors.New("webhook ID already exists"))
-		}
-	}
-
 	// TODO: this is a work-around for stacks created with Portainer version >= 1.17.1
 	// The EndpointID property is not available for these stacks, this API environment(endpoint)
 	// can use the optional EndpointID query parameter to associate a valid environment(endpoint) identifier to the stack.

api/http/handler/stacks/stack_update_git_redeploy.go

@@ -27,13 +27,10 @@ type stackGitRedployPayload struct {
 	RepositoryAuthorizationType gittypes.GitCredentialAuthType
 	Env                         []portainer.Pair
 	Prune                       bool
-	// RepullImageAndRedeploy indicates whether to force repulling images and redeploying the stack
-	RepullImageAndRedeploy bool
-
-	StackName string
-	// Deprecated(2.36): use RepullImageAndRedeploy instead for cleaner responsibility
 	// Force a pulling to current image with the original tag though the image is already the latest
 	PullImage bool `example:"false"`
+
+	StackName string
 }
 
 func (payload *stackGitRedployPayload) Validate(r *http.Request) error {
@@ -127,7 +124,7 @@ func (handler *Handler) stackGitRedeploy(w http.ResponseWriter, r *http.Request)
 	if err := request.DecodeAndValidateJSONPayload(r, &payload); err != nil {
 		return httperror.BadRequest("Invalid request payload", err)
 	}
-	payload.RepullImageAndRedeploy = payload.RepullImageAndRedeploy || payload.PullImage
+
 	stack.GitConfig.ReferenceName = payload.RepositoryReferenceName
 	stack.Env = payload.Env
 	if stack.Type == portainer.DockerSwarmStack {
@@ -171,7 +168,7 @@ func (handler *Handler) stackGitRedeploy(w http.ResponseWriter, r *http.Request)
 
 	defer clean()
 
-	if err := handler.deployStack(r, stack, payload.RepullImageAndRedeploy, endpoint); err != nil {
+	if err := handler.deployStack(r, stack, payload.PullImage, endpoint); err != nil {
 		return err
 	}
 

api/http/handler/stacks/stack_update_git_test.go

@@ -1,78 +0,0 @@
-package stacks
-
-import (
-	"bytes"
-	"net/http"
-	"net/http/httptest"
-	"strconv"
-	"testing"
-
-	portainer "github.com/portainer/portainer/api"
-	"github.com/portainer/portainer/api/datastore"
-	gittypes "github.com/portainer/portainer/api/git/types"
-	"github.com/portainer/portainer/api/http/security"
-	"github.com/portainer/portainer/api/internal/testhelpers"
-
-	"github.com/gofrs/uuid"
-	"github.com/segmentio/encoding/json"
-	"github.com/stretchr/testify/require"
-)
-
-func TestStackUpdateGitWebhookUniqueness(t *testing.T) {
-	webhook, err := uuid.NewV4()
-	require.NoError(t, err)
-
-	_, store := datastore.MustNewTestStore(t, false, false)
-
-	endpoint := &portainer.Endpoint{
-		ID:   123,
-		Name: "endpoint1",
-		Type: portainer.DockerEnvironment,
-	}
-	err = store.Endpoint().Create(endpoint)
-	require.NoError(t, err)
-
-	stack1 := portainer.Stack{
-		ID:         456,
-		EndpointID: endpoint.ID,
-		AutoUpdate: &portainer.AutoUpdateSettings{
-			Webhook: webhook.String(),
-		},
-		GitConfig: &gittypes.RepoConfig{
-			URL: "https://github.com/portainer/portainer.git",
-		},
-	}
-
-	err = store.Stack().Create(&stack1)
-	require.NoError(t, err)
-
-	stack2 := stack1
-	stack2.ID++
-	stack2.AutoUpdate = nil
-
-	err = store.Stack().Create(&stack2)
-	require.NoError(t, err)
-
-	handler := NewHandler(testhelpers.NewTestRequestBouncer())
-	handler.DataStore = store
-
-	payload := &stackGitUpdatePayload{
-		AutoUpdate: &portainer.AutoUpdateSettings{
-			Webhook: webhook.String(),
-		},
-	}
-
-	jsonPayload, err := json.Marshal(payload)
-	require.NoError(t, err)
-
-	url := "/stacks/" + strconv.Itoa(int(stack2.ID)) + "/git?endpointId=" + strconv.Itoa(int(endpoint.ID))
-	req := httptest.NewRequest(http.MethodPost, url, bytes.NewReader(jsonPayload))
-
-	rrc := &security.RestrictedRequestContext{}
-	req = req.WithContext(security.StoreRestrictedRequestContext(req, rrc))
-
-	rr := httptest.NewRecorder()
-	handler.ServeHTTP(rr, req)
-
-	require.Equal(t, http.StatusConflict, rr.Code)
-}

api/http/handler/stacks/stack_update_test.go

@@ -1,419 +0,0 @@
-package stacks
-
-import (
-	"bytes"
-	"encoding/json"
-	"fmt"
-	"net/http"
-	"net/http/httptest"
-	"path/filepath"
-	"strconv"
-	"testing"
-
-	"github.com/pkg/errors"
-	portainer "github.com/portainer/portainer/api"
-	"github.com/portainer/portainer/api/dataservices"
-	"github.com/portainer/portainer/api/datastore"
-	"github.com/portainer/portainer/api/filesystem"
-	"github.com/portainer/portainer/api/internal/testhelpers"
-	"github.com/portainer/portainer/api/stacks/deployments"
-	"github.com/portainer/portainer/api/stacks/stackutils"
-	"github.com/portainer/portainer/pkg/fips"
-	httperror "github.com/portainer/portainer/pkg/libhttp/error"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-)
-
-func Test_updateStackInTx(t *testing.T) {
-	t.Run("Transaction commits successfully - changes are persisted", func(t *testing.T) {
-		payload := &updateComposeStackPayload{
-			StackFileContent: "version: '3'\nservices:\n  web:\n    image: nginx:latest",
-			Env:              []portainer.Pair{{Name: "FOO", Value: "BAR"}},
-		}
-		stack := &portainer.Stack{
-			ID:         1,
-			Name:       "test-stack-1",
-			EntryPoint: "docker-compose.yml",
-			Type:       portainer.DockerComposeStack,
-		}
-		setup := setupUpdateStackInTxTest(t, stack, payload)
-
-		// Execute updateStackInTx within a successful transaction
-		err := setup.store.UpdateTx(func(tx dataservices.DataStoreTx) error {
-			_, handlerErr := setup.handler.updateStackInTx(tx, setup.req, setup.stack.ID, setup.endpoint.ID)
-			if handlerErr != nil {
-				return handlerErr
-			}
-			return nil
-		})
-		require.NoError(t, err, "transction should succeed")
-
-		// Verify the stack was updated in the database (transaction committed)
-		stackAfterCommit, err := setup.store.Stack().Read(setup.stack.ID)
-		require.NoError(t, err, "should be able to read stack after commit")
-		require.NotNil(t, stackAfterCommit)
-		require.Equal(t, "BAR", stackAfterCommit.Env[0].Value, "stack env variable should be updated")
-	})
-
-	t.Run("Transaction rollback on error - changes not persisted", func(t *testing.T) {
-		payload := &updateComposeStackPayload{
-			StackFileContent: "version: '3'\nservices:\n  web:\n    image: nginx:latest",
-			Env:              []portainer.Pair{{Name: "FOO", Value: "BAR"}},
-		}
-		stack := &portainer.Stack{
-			ID:         1,
-			Name:       "test-stack-1",
-			EntryPoint: "docker-compose.yml",
-			Type:       portainer.DockerComposeStack,
-		}
-		setup := setupUpdateStackInTxTest(t, stack, payload)
-
-		// Execute updateStackInTx within a transaction that we force to fail
-		err := setup.store.UpdateTx(func(tx dataservices.DataStoreTx) error {
-			updatedStack, handlerErr := setup.handler.updateStackInTx(tx, setup.req, setup.stack.ID, setup.endpoint.ID)
-			if handlerErr != nil {
-				return handlerErr
-			}
-
-			// Verify changes are visible within the transaction
-			assert.NotNil(t, updatedStack)
-			assert.Equal(t, setup.user.Username, updatedStack.UpdatedBy)
-			assert.NotZero(t, updatedStack.UpdateDate)
-
-			// Force the transaction to fail by returning an error
-			return errors.New("forced transaction failure")
-		})
-
-		// Verify the transaction failed
-		require.Error(t, err)
-		assert.Contains(t, err.Error(), "forced transaction failure")
-
-		// Verify the stack was NOT updated in the database (transaction rolled back)
-		stackAfterRollback, err := setup.store.Stack().Read(setup.stack.ID)
-		require.NoError(t, err)
-		require.Zero(t, stackAfterRollback.Env, "stack env variable should remain unchanged after rollback")
-	})
-
-	t.Run("Error: Stack not found returns NotFound httperror", func(t *testing.T) {
-		payload := &updateComposeStackPayload{
-			StackFileContent: "version: '3'\nservices:\n  web:\n    image: nginx:latest",
-		}
-		stack := &portainer.Stack{
-			ID:         1,
-			Name:       "test-stack-1",
-			EntryPoint: "docker-compose.yml",
-			Type:       portainer.DockerComposeStack,
-		}
-		setup := setupUpdateStackInTxTest(t, stack, payload)
-		setup.req.URL.Path = "/stacks/9999" // Non-existent stack ID
-
-		var handlerErr *httperror.HandlerError
-		_ = setup.store.UpdateTx(func(tx dataservices.DataStoreTx) error {
-			_, handlerErr = setup.handler.updateStackInTx(tx, setup.req, 9999, setup.endpoint.ID)
-			return handlerErr
-		})
-
-		require.NotNil(t, handlerErr, "handler error should be set")
-		assert.Equal(t, http.StatusNotFound, handlerErr.StatusCode, "should return 404 NotFound")
-		assert.Contains(t, handlerErr.Message, "Unable to find a stack", "error message should mention stack")
-	})
-
-	t.Run("Error: Endpoint not found returns NotFound httperror", func(t *testing.T) {
-		payload := &updateComposeStackPayload{
-			StackFileContent: "version: '3'\nservices:\n  web:\n    image: nginx:latest",
-		}
-		stack := &portainer.Stack{
-			ID:         1,
-			Name:       "test-stack-1",
-			EntryPoint: "docker-compose.yml",
-			Type:       portainer.DockerComposeStack,
-		}
-		setup := setupUpdateStackInTxTest(t, stack, payload)
-
-		var handlerErr *httperror.HandlerError
-		_ = setup.store.UpdateTx(func(tx dataservices.DataStoreTx) error {
-			_, handlerErr = setup.handler.updateStackInTx(tx, setup.req, stack.ID, 2999) // Non-existent endpoint ID
-			return nil
-		})
-
-		require.NotNil(t, handlerErr, "handler error should be set")
-		assert.Equal(t, http.StatusNotFound, handlerErr.StatusCode, "should return 404 NotFound")
-		assert.Contains(t, handlerErr.Message, "Unable to find the environment", "error message should mention environment")
-	})
-
-	t.Run("Error: user cannot access the stack", func(t *testing.T) {
-		payload := &updateComposeStackPayload{
-			StackFileContent: "version: '3'\nservices:\n  web:\n    image: nginx:latest",
-		}
-		stack := &portainer.Stack{
-			ID:         1,
-			Name:       "test-stack-1",
-			EntryPoint: "docker-compose.yml",
-			Type:       portainer.DockerComposeStack,
-		}
-		setup := setupUpdateStackInTxTest(t, stack, payload)
-		originalUser, err := setup.store.User().Read(setup.user.ID)
-		require.NoError(t, err, "error reading user")
-
-		// Modify the user's role to restrict access
-		originalUser.Role = portainer.StandardUserRole
-		err = setup.store.User().Update(originalUser.ID, originalUser)
-		require.NoError(t, err, "error updating user role")
-
-		var handlerErr *httperror.HandlerError
-		_ = setup.store.UpdateTx(func(tx dataservices.DataStoreTx) error {
-			_, handlerErr = setup.handler.updateStackInTx(tx, setup.req, stack.ID, stack.EndpointID)
-			return nil
-		})
-
-		require.NotNil(t, handlerErr, "handler error should be set")
-		assert.Equal(t, http.StatusForbidden, handlerErr.StatusCode, "should return 403 Forbidden")
-		assert.Contains(t, handlerErr.Message, "Access denied", "error message should mention access")
-	})
-
-	t.Run("Error: user not found", func(t *testing.T) {
-		payload := &updateComposeStackPayload{
-			StackFileContent: "version: '3'\nservices:\n  web:\n    image: nginx:latest",
-		}
-		stack := &portainer.Stack{
-			ID:         1,
-			Name:       "test-stack-1",
-			EntryPoint: "docker-compose.yml",
-			Type:       portainer.DockerComposeStack,
-		}
-		setup := setupUpdateStackInTxTest(t, stack, payload)
-		err := setup.store.User().Delete(setup.user.ID) // Delete the user to simulate "user not found"
-		require.NoError(t, err, "error deleting user")
-
-		var handlerErr *httperror.HandlerError
-		_ = setup.store.UpdateTx(func(tx dataservices.DataStoreTx) error {
-			_, handlerErr = setup.handler.updateStackInTx(tx, setup.req, stack.ID, stack.EndpointID)
-			return nil
-		})
-
-		require.NotNil(t, handlerErr, "handler error should be set")
-		assert.Equal(t, http.StatusInternalServerError, handlerErr.StatusCode, "should return 500 Internal Server Error")
-		assert.Contains(t, handlerErr.Message, "Unable to verify user authorizations to validate stack access", "error message should mention user authorizations")
-	})
-}
-
-func TestStackUpdate(t *testing.T) {
-	t.Helper()
-	_, store := datastore.MustNewTestStore(t, true, true)
-
-	testDataPath := filepath.Join(t.TempDir())
-	fileService, err := filesystem.NewService(testDataPath, "")
-	require.NoError(t, err, "error init file service")
-
-	// Create test user
-	_, err = mockCreateUser(store)
-	require.NoError(t, err, "error creating user")
-
-	// Create test endpoint
-	endpoint, err := mockCreateEndpoint(store)
-	require.NoError(t, err, "error creating endpoint")
-
-	// Create test stack
-	stack := &portainer.Stack{
-		ID:          1,
-		Name:        "test-stack-1",
-		EntryPoint:  "docker-compose.yml",
-		EndpointID:  endpoint.ID,
-		ProjectPath: fileService.GetDatastorePath() + fmt.Sprintf("/compose/%d", 1),
-		Type:        portainer.DockerSwarmStack,
-	}
-
-	err = store.Stack().Create(stack)
-	require.NoError(t, err, "error creating stack")
-
-	// Create resource control for the stack
-	resourceControl := &portainer.ResourceControl{
-		ID:                 portainer.ResourceControlID(stack.ID),
-		ResourceID:         stackutils.ResourceControlID(stack.EndpointID, stack.Name),
-		Type:               portainer.StackResourceControl,
-		AdministratorsOnly: false,
-	}
-	err = store.ResourceControl().Create(resourceControl)
-	require.NoError(t, err, "error creating resource control")
-
-	// Store initial stack file
-	_, err = fileService.StoreStackFileFromBytes(
-		strconv.Itoa(int(stack.ID)),
-		stack.EntryPoint,
-		[]byte("version: '3'\nservices:\n  web:\n    image: nginx:v1"),
-	)
-	require.NoError(t, err, "error storing stack file")
-
-	// Create handler
-	handler := NewHandler(testhelpers.NewTestRequestBouncer())
-	handler.DataStore = store
-	handler.FileService = fileService
-	handler.StackDeployer = testStackDeployer{}
-	handler.ComposeStackManager = testhelpers.NewComposeStackManager()
-	handler.SwarmStackManager = swarmStackManager{}
-
-	payload := &updateComposeStackPayload{
-		StackFileContent: "version: '3'\nservices:\n  web:\n    image: nginx:latest",
-	}
-	// Create mock request with security context
-	jsonPayload, err := json.Marshal(payload)
-	require.NoError(t, err)
-
-	t.Run("Endpoint is not provided in query param nor header", func(t *testing.T) {
-		req := mockCreateStackRequestWithSecurityContext(
-			http.MethodPut,
-			fmt.Sprintf("/stacks/%d", stack.ID),
-			bytes.NewBuffer(jsonPayload),
-		)
-
-		rec := httptest.NewRecorder()
-		handler.ServeHTTP(rec, req)
-
-		require.Equal(t, http.StatusBadRequest, rec.Code, "expected status BadRequest when endpoint is not provided")
-	})
-
-	t.Run("Stack doesn't exist", func(t *testing.T) {
-		req := mockCreateStackRequestWithSecurityContext(
-			http.MethodPut,
-			fmt.Sprintf("/stacks/test-stack-1?endpointId=%d", endpoint.ID),
-			bytes.NewBuffer(jsonPayload),
-		)
-
-		rec := httptest.NewRecorder()
-		handler.ServeHTTP(rec, req)
-
-		require.Equal(t, http.StatusBadRequest, rec.Code, "expected status NotFound when stack doesn't exist")
-	})
-
-	t.Run("Update stack successfully", func(t *testing.T) {
-		fips.InitFIPS(false)
-
-		req := mockCreateStackRequestWithSecurityContext(
-			http.MethodPut,
-			fmt.Sprintf("/stacks/%d?endpointId=%d", stack.ID, endpoint.ID),
-			bytes.NewBuffer(jsonPayload),
-		)
-
-		rec := httptest.NewRecorder()
-		handler.ServeHTTP(rec, req)
-
-		require.Equal(t, http.StatusOK, rec.Code, "expected status OK when stack is updated successfully")
-		var stackResponse portainer.Stack
-		err = json.NewDecoder(rec.Body).Decode(&stackResponse)
-		require.NoError(t, err, "error decoding response body")
-		require.NotZero(t, stackResponse.UpdateDate, "stack update date should be set")
-	})
-}
-
-// setupUpdateStackInTxTest creates a fresh test environment for each subtest
-type updateStackInTxTestSetup struct {
-	store           *datastore.Store
-	fileService     portainer.FileService
-	handler         *Handler
-	user            *portainer.User
-	endpoint        *portainer.Endpoint
-	stack           *portainer.Stack
-	resourceControl *portainer.ResourceControl
-	jsonPayload     []byte
-	req             *http.Request
-}
-
-func setupUpdateStackInTxTest(t *testing.T, stack *portainer.Stack, payload *updateComposeStackPayload) *updateStackInTxTestSetup {
-	t.Helper()
-
-	_, store := datastore.MustNewTestStore(t, true, true)
-
-	testDataPath := filepath.Join(t.TempDir())
-	fileService, err := filesystem.NewService(testDataPath, "")
-	require.NoError(t, err, "error init file service")
-
-	// Create test user
-	user, err := mockCreateUser(store)
-	require.NoError(t, err, "error creating user")
-
-	// Create test endpoint
-	endpoint, err := mockCreateEndpoint(store)
-	require.NoError(t, err, "error creating endpoint")
-
-	// Create test stack
-	stack.EndpointID = endpoint.ID
-	stack.ProjectPath = fileService.GetDatastorePath() + fmt.Sprintf("/compose/%d", stack.ID)
-
-	err = store.Stack().Create(stack)
-	require.NoError(t, err, "error creating stack")
-
-	// Create resource control for the stack
-	resourceControl := &portainer.ResourceControl{
-		ID:                 portainer.ResourceControlID(stack.ID),
-		ResourceID:         stackutils.ResourceControlID(stack.EndpointID, stack.Name),
-		Type:               portainer.StackResourceControl,
-		AdministratorsOnly: false,
-	}
-	err = store.ResourceControl().Create(resourceControl)
-	require.NoError(t, err, "error creating resource control")
-
-	// Store initial stack file
-	_, err = fileService.StoreStackFileFromBytes(
-		strconv.Itoa(int(stack.ID)),
-		stack.EntryPoint,
-		[]byte("version: '3'\nservices:\n  web:\n    image: nginx:v1"),
-	)
-	require.NoError(t, err, "error storing stack file")
-
-	// Create handler
-	handler := NewHandler(testhelpers.NewTestRequestBouncer())
-	handler.DataStore = store
-	handler.FileService = fileService
-	handler.StackDeployer = testStackDeployer{}
-	handler.ComposeStackManager = testhelpers.NewComposeStackManager()
-
-	// Create mock request with security context
-	jsonPayload, err := json.Marshal(payload)
-	require.NoError(t, err)
-
-	req := mockCreateStackRequestWithSecurityContext(
-		http.MethodPut,
-		fmt.Sprintf("/stacks/%d?endpointId=%d", stack.ID, endpoint.ID),
-		bytes.NewBuffer(jsonPayload),
-	)
-
-	return &updateStackInTxTestSetup{
-		store:           store,
-		fileService:     fileService,
-		handler:         handler,
-		user:            user,
-		endpoint:        endpoint,
-		stack:           stack,
-		resourceControl: resourceControl,
-		jsonPayload:     jsonPayload,
-		req:             req,
-	}
-}
-
-type swarmStackManager struct {
-	portainer.SwarmStackManager
-}
-
-func (manager swarmStackManager) NormalizeStackName(name string) string {
-	return name
-}
-
-type testStackDeployer struct {
-	deployments.StackDeployer
-}
-
-func (testStackDeployer) DeployComposeStack(stack *portainer.Stack, endpoint *portainer.Endpoint, registries []portainer.Registry, forcePullImage, forceRecreate bool) error {
-	return nil
-}
-
-func (testStackDeployer) DeploySwarmStack(stack *portainer.Stack, endpoint *portainer.Endpoint, registries []portainer.Registry, prune, pullImage bool) error {
-	return nil
-}
-
-func (testStackDeployer) DeployRemoteComposeStack(stack *portainer.Stack, endpoint *portainer.Endpoint, registries []portainer.Registry, forcePullImage, forceRecreate bool) error {
-	return nil
-}
-
-func (testStackDeployer) DeployRemoteSwarmStack(stack *portainer.Stack, endpoint *portainer.Endpoint, registries []portainer.Registry, prune, pullImage bool) error {
-	return nil
-}

api/http/middlewares/deprecated.go

@@ -29,12 +29,3 @@ func Deprecated(router http.Handler, urlBuilder func(w http.ResponseWriter, r *h
 		router.ServeHTTP(w, redirectedRequest)
 	})
 }
-
-// DeprecatedSimple is a middleware that marks an API route as deprecated
-//
-// if needed, use Deprecated with a custom urlBuilder
-func DeprecatedSimple(h http.Handler) http.Handler {
-	return Deprecated(h, func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-		return "", nil
-	})
-}

api/http/middlewares/deprecated_test.go

@@ -1,316 +0,0 @@
-package middlewares
-
-import (
-	"io"
-	"net/http"
-	"net/http/httptest"
-	"testing"
-
-	httperror "github.com/portainer/portainer/pkg/libhttp/error"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-)
-
-func TestDeprecated(t *testing.T) {
-	tests := []struct {
-		name               string
-		urlBuilder         func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError)
-		requestPath        string
-		expectedStatusCode int
-		expectedPath       string
-		expectRedirect     bool
-	}{
-		{
-			name: "empty URL - no redirect",
-			urlBuilder: func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-				return "", nil
-			},
-			requestPath:        "/api/old",
-			expectedStatusCode: http.StatusOK,
-			expectedPath:       "/api/old",
-			expectRedirect:     false,
-		},
-		{
-			name: "new URL provided - redirects",
-			urlBuilder: func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-				return "/api/new", nil
-			},
-			requestPath:        "/api/old",
-			expectedStatusCode: http.StatusOK,
-			expectedPath:       "/api/new",
-			expectRedirect:     true,
-		},
-		{
-			name: "urlBuilder returns error - returns error response",
-			urlBuilder: func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-				return "", httperror.BadRequest("invalid request", nil)
-			},
-			requestPath:        "/api/old",
-			expectedStatusCode: http.StatusBadRequest,
-			expectedPath:       "",
-			expectRedirect:     false,
-		},
-		{
-			name: "urlBuilder returns server error",
-			urlBuilder: func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-				return "", httperror.InternalServerError("server error", nil)
-			},
-			requestPath:        "/api/old",
-			expectedStatusCode: http.StatusInternalServerError,
-			expectedPath:       "",
-			expectRedirect:     false,
-		},
-		{
-			name: "dynamic URL based on request path",
-			urlBuilder: func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-				return "/v2" + r.URL.Path, nil
-			},
-			requestPath:        "/api/resource/123",
-			expectedStatusCode: http.StatusOK,
-			expectedPath:       "/v2/api/resource/123",
-			expectRedirect:     true,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			// Create a test handler that records the request path
-			var handledPath string
-			testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-				handledPath = r.URL.Path
-				w.WriteHeader(http.StatusOK)
-				w.Write([]byte("success"))
-			})
-
-			// Wrap with Deprecated middleware
-			wrappedHandler := Deprecated(testHandler, tt.urlBuilder)
-
-			// Create test request
-			req := httptest.NewRequest(http.MethodGet, tt.requestPath, nil)
-			rec := httptest.NewRecorder()
-
-			// Execute request
-			wrappedHandler.ServeHTTP(rec, req)
-
-			// Check status code
-			assert.Equal(t, tt.expectedStatusCode, rec.Code, "unexpected status code")
-
-			// For error cases, don't check the path
-			if tt.expectedStatusCode >= 400 {
-				return
-			}
-
-			// Check that the correct path was handled
-			if tt.expectRedirect {
-				assert.Equal(t, tt.expectedPath, handledPath, "path was not redirected correctly")
-			} else {
-				assert.Equal(t, tt.requestPath, handledPath, "original path was not preserved")
-			}
-
-			// Check response body for success cases
-			body, err := io.ReadAll(rec.Body)
-			require.NoError(t, err)
-			assert.Equal(t, "success", string(body), "unexpected response body")
-		})
-	}
-}
-
-func TestDeprecatedSimple(t *testing.T) {
-	// Create a test handler
-	testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		w.WriteHeader(http.StatusOK)
-		w.Write([]byte("test response"))
-	})
-
-	// Wrap with DeprecatedSimple middleware
-	wrappedHandler := DeprecatedSimple(testHandler)
-
-	// Create test request
-	req := httptest.NewRequest(http.MethodGet, "/api/test", nil)
-	rec := httptest.NewRecorder()
-
-	// Execute request
-	wrappedHandler.ServeHTTP(rec, req)
-
-	// Check that request was successful
-	assert.Equal(t, http.StatusOK, rec.Code, "unexpected status code")
-
-	// Check response body
-	body, err := io.ReadAll(rec.Body)
-	require.NoError(t, err)
-	assert.Equal(t, "test response", string(body), "unexpected response body")
-}
-
-func TestDeprecated_PreservesRequestContext(t *testing.T) {
-	// Test that the middleware preserves request context when redirecting
-	urlBuilder := func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-		return "/new-path", nil
-	}
-
-	var receivedRequest *http.Request
-	testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		receivedRequest = r
-		w.WriteHeader(http.StatusOK)
-	})
-
-	wrappedHandler := Deprecated(testHandler, urlBuilder)
-
-	req := httptest.NewRequest(http.MethodGet, "/old-path", nil)
-	rec := httptest.NewRecorder()
-
-	wrappedHandler.ServeHTTP(rec, req)
-
-	require.NotNil(t, receivedRequest, "request was not passed to handler")
-	assert.Equal(t, req.Context(), receivedRequest.Context(), "request context was not preserved")
-}
-
-func TestDeprecated_PreservesRequestMethod(t *testing.T) {
-	methods := []string{http.MethodGet, http.MethodPost, http.MethodPut, http.MethodDelete, http.MethodPatch}
-
-	urlBuilder := func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-		return "/new-path", nil
-	}
-
-	for _, method := range methods {
-		t.Run(method, func(t *testing.T) {
-			var receivedMethod string
-			testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-				receivedMethod = r.Method
-				w.WriteHeader(http.StatusOK)
-			})
-
-			wrappedHandler := Deprecated(testHandler, urlBuilder)
-
-			req := httptest.NewRequest(method, "/old-path", nil)
-			rec := httptest.NewRecorder()
-
-			wrappedHandler.ServeHTTP(rec, req)
-
-			assert.Equal(t, method, receivedMethod, "HTTP method was not preserved")
-		})
-	}
-}
-
-func TestDeprecated_PreservesRequestHeaders(t *testing.T) {
-	urlBuilder := func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-		return "/new-path", nil
-	}
-
-	var receivedHeaders http.Header
-	testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		receivedHeaders = r.Header
-		w.WriteHeader(http.StatusOK)
-	})
-
-	wrappedHandler := Deprecated(testHandler, urlBuilder)
-
-	req := httptest.NewRequest(http.MethodGet, "/old-path", nil)
-	req.Header.Set("Authorization", "Bearer token123")
-	req.Header.Set("Content-Type", "application/json")
-	rec := httptest.NewRecorder()
-
-	wrappedHandler.ServeHTTP(rec, req)
-
-	assert.Equal(t, "Bearer token123", receivedHeaders.Get("Authorization"), "Authorization header was not preserved")
-	assert.Equal(t, "application/json", receivedHeaders.Get("Content-Type"), "Content-Type header was not preserved")
-}
-
-func TestDeprecated_PreservesRequestBody(t *testing.T) {
-	urlBuilder := func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-		return "/new-path", nil
-	}
-
-	var receivedBody string
-	testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		body, _ := io.ReadAll(r.Body)
-		receivedBody = string(body)
-		w.WriteHeader(http.StatusOK)
-	})
-
-	wrappedHandler := Deprecated(testHandler, urlBuilder)
-
-	req := httptest.NewRequest(http.MethodPost, "/old-path", http.NoBody)
-	rec := httptest.NewRecorder()
-
-	wrappedHandler.ServeHTTP(rec, req)
-
-	// Body should be preserved (empty in this case since we used http.NoBody)
-	assert.Empty(t, receivedBody, "expected empty body")
-}
-
-func TestDeprecated_ErrorResponseFormat(t *testing.T) {
-	urlBuilder := func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-		return "", httperror.BadRequest("test error message", nil)
-	}
-
-	handlerCalled := false
-	testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		handlerCalled = true
-		w.WriteHeader(http.StatusOK)
-	})
-
-	wrappedHandler := Deprecated(testHandler, urlBuilder)
-
-	req := httptest.NewRequest(http.MethodGet, "/api/test", nil)
-	rec := httptest.NewRecorder()
-
-	wrappedHandler.ServeHTTP(rec, req)
-
-	assert.False(t, handlerCalled, "handler should not be called when urlBuilder returns error")
-	assert.Equal(t, http.StatusBadRequest, rec.Code, "unexpected status code")
-
-	// The httperror.WriteError function should have written the error response
-	body, err := io.ReadAll(rec.Body)
-	require.NoError(t, err)
-	assert.NotEmpty(t, body, "expected error response body")
-}
-
-func TestDeprecated_WithQueryParameters(t *testing.T) {
-	urlBuilder := func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-		return "/api/v2/resource", nil
-	}
-
-	var receivedQuery string
-	testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		receivedQuery = r.URL.RawQuery
-		w.WriteHeader(http.StatusOK)
-	})
-
-	wrappedHandler := Deprecated(testHandler, urlBuilder)
-
-	req := httptest.NewRequest(http.MethodGet, "/api/v1/resource?filter=active&sort=name", nil)
-	rec := httptest.NewRecorder()
-
-	wrappedHandler.ServeHTTP(rec, req)
-
-	assert.Equal(t, "filter=active&sort=name", receivedQuery, "query parameters were not preserved")
-}
-
-func TestDeprecated_WithMultipleRedirects(t *testing.T) {
-	// Test that multiple deprecated middleware can be chained
-	urlBuilder1 := func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-		return "/v2" + r.URL.Path, nil
-	}
-
-	urlBuilder2 := func(w http.ResponseWriter, r *http.Request) (string, *httperror.HandlerError) {
-		return "/api" + r.URL.Path, nil
-	}
-
-	var finalPath string
-	testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		finalPath = r.URL.Path
-		w.WriteHeader(http.StatusOK)
-	})
-
-	// Chain two deprecated middlewares
-	wrappedHandler := Deprecated(Deprecated(testHandler, urlBuilder2), urlBuilder1)
-
-	req := httptest.NewRequest(http.MethodGet, "/old", nil)
-	rec := httptest.NewRecorder()
-
-	wrappedHandler.ServeHTTP(rec, req)
-
-	// First middleware redirects to /v2/old
-	// Second middleware redirects to /api/v2/old
-	assert.Equal(t, "/api/v2/old", finalPath, "chained redirects did not work correctly")
-}

api/http/models/kubernetes/application.go

@@ -12,7 +12,7 @@ type K8sApplication struct {
 	Name                    string                                 `json:"Name"`
 	Image                   string                                 `json:"Image"`
 	Containers              []interface{}                          `json:"Containers,omitempty"`
-	Services                []corev1.Service                       `json:"Services" swaggerignore:"true"`
+	Services                []corev1.Service                       `json:"Services"`
 	CreationDate            time.Time                              `json:"CreationDate"`
 	ApplicationOwner        string                                 `json:"ApplicationOwner,omitempty"`
 	StackName               string                                 `json:"StackName,omitempty"`
@@ -38,9 +38,8 @@ type K8sApplication struct {
 	Labels                  map[string]string                      `json:"Labels,omitempty"`
 	Annotations             map[string]string                      `json:"Annotations,omitempty"`
 	Resource                K8sApplicationResource                 `json:"Resource,omitempty"`
-	HorizontalPodAutoscaler *autoscalingv2.HorizontalPodAutoscaler `json:"HorizontalPodAutoscaler,omitempty" swaggerignore:"true"`
+	HorizontalPodAutoscaler *autoscalingv2.HorizontalPodAutoscaler `json:"HorizontalPodAutoscaler,omitempty"`
 	CustomResourceMetadata  CustomResourceMetadata                 `json:"CustomResourceMetadata,omitempty"`
-	StackKind               string                                 `json:"StackKind,omitempty"`
 }
 
 type Metadata struct {
@@ -49,9 +48,7 @@ type Metadata struct {
 }
 
 type CustomResourceMetadata struct {
-	Name       string `json:"name"`
 	Kind       string `json:"kind"`
-	Scope      string `json:"scope"`
 	APIVersion string `json:"apiVersion"`
 	Plural     string `json:"plural"`
 }

api/http/proxy/factory/docker/transport.go

@@ -111,7 +111,7 @@ var prefixProxyFuncMap = map[string]func(*Transport, *http.Request, string) (*ht
 // ProxyDockerRequest intercepts a Docker API request and apply logic based
 // on the requested operation.
 func (transport *Transport) ProxyDockerRequest(request *http.Request) (*http.Response, error) {
-	// from : /v1.44/containers/{id}/json
+	// from : /v1.41/containers/{id}/json
 	// or   : /containers/{id}/json
 	// to   : /containers/{id}/json
 	unversionedPath := apiVersionRe.ReplaceAllString(request.URL.Path, "")

api/http/proxy/factory/reverse_proxy.go

@@ -1,6 +1,7 @@
 package factory
 
 import (
+	"net/http"
 	"net/http/httputil"
 	"net/url"
 	"strings"
@@ -22,41 +23,36 @@ var allowedHeaders = map[string]struct{}{
 	"X-Portainer-Volumename":    {},
 	"X-Registry-Auth":           {},
 	"X-Stream-Protocol-Version": {},
-	// WebSocket headers those are required for kubectl exec/attach/port-forward operations
-	"Sec-Websocket-Key":        {},
-	"Sec-Websocket-Version":    {},
-	"Sec-Websocket-Protocol":   {},
-	"Sec-Websocket-Extensions": {},
 }
 
 // newSingleHostReverseProxyWithHostHeader is based on NewSingleHostReverseProxy
 // from golang.org/src/net/http/httputil/reverseproxy.go and merely sets the Host
 // HTTP header, which NewSingleHostReverseProxy deliberately preserves.
 func NewSingleHostReverseProxyWithHostHeader(target *url.URL) *httputil.ReverseProxy {
-	return &httputil.ReverseProxy{Rewrite: createRewriteFn(target)}
+	return &httputil.ReverseProxy{Director: createDirector(target)}
 }
 
-func createRewriteFn(target *url.URL) func(*httputil.ProxyRequest) {
+func createDirector(target *url.URL) func(*http.Request) {
 	targetQuery := target.RawQuery
-	return func(proxyReq *httputil.ProxyRequest) {
-		proxyReq.Out.URL.Scheme = target.Scheme
-		proxyReq.Out.URL.Host = target.Host
-		proxyReq.Out.URL.Path = singleJoiningSlash(target.Path, proxyReq.In.URL.Path)
-		proxyReq.Out.Host = proxyReq.Out.URL.Host
-		if targetQuery == "" || proxyReq.Out.URL.RawQuery == "" {
-			proxyReq.Out.URL.RawQuery = targetQuery + proxyReq.Out.URL.RawQuery
+	return func(req *http.Request) {
+		req.URL.Scheme = target.Scheme
+		req.URL.Host = target.Host
+		req.URL.Path = singleJoiningSlash(target.Path, req.URL.Path)
+		req.Host = req.URL.Host
+		if targetQuery == "" || req.URL.RawQuery == "" {
+			req.URL.RawQuery = targetQuery + req.URL.RawQuery
 		} else {
-			proxyReq.Out.URL.RawQuery = targetQuery + "&" + proxyReq.Out.URL.RawQuery
+			req.URL.RawQuery = targetQuery + "&" + req.URL.RawQuery
 		}
-		if _, ok := proxyReq.Out.Header["User-Agent"]; !ok {
+		if _, ok := req.Header["User-Agent"]; !ok {
 			// explicitly disable User-Agent so it's not set to default value
-			proxyReq.Out.Header.Set("User-Agent", "")
+			req.Header.Set("User-Agent", "")
 		}
 
-		for k := range proxyReq.Out.Header {
+		for k := range req.Header {
 			if _, ok := allowedHeaders[k]; !ok {
 				// We use delete here instead of req.Header.Del because we want to delete non canonical headers.
-				delete(proxyReq.Out.Header, k)
+				delete(req.Header, k)
 			}
 		}
 	}

api/http/proxy/factory/reverse_proxy_test.go

@@ -1,9 +1,7 @@
 package factory
 
 import (
-	"context"
 	"net/http"
-	"net/http/httputil"
 	"net/url"
 	"testing"
 
@@ -11,7 +9,7 @@ import (
 	portainer "github.com/portainer/portainer/api"
 )
 
-func Test_createRewriteFn(t *testing.T) {
+func Test_createDirector(t *testing.T) {
 	testCases := []struct {
 		name        string
 		target      *url.URL
@@ -145,18 +143,10 @@ func Test_createRewriteFn(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			rewriteFn := createRewriteFn(tc.target)
-			proxyRequest := httputil.ProxyRequest{
-				In:  tc.req.Clone(context.Background()),
-				Out: tc.req.Clone(context.Background()),
-			}
-			rewriteFn(&proxyRequest)
+			director := createDirector(tc.target)
+			director(tc.req)
 
-			if diff := cmp.Diff(proxyRequest.In, tc.req, cmp.Comparer(compareRequests)); diff != "" {
-				t.Fatalf("rewriteFn modified in request: \n%s", diff)
-			}
-
-			if diff := cmp.Diff(proxyRequest.Out, tc.expectedReq, cmp.Comparer(compareRequests)); diff != "" {
+			if diff := cmp.Diff(tc.req, tc.expectedReq, cmp.Comparer(compareRequests)); diff != "" {
 				t.Fatalf("requests are different: \n%s", diff)
 			}
 		})

api/http/security/bouncer.go

@@ -535,7 +535,7 @@ func MWSecureHeaders(next http.Handler, hsts, csp bool) http.Handler {
 		}
 
 		if csp {
-			w.Header().Set("Content-Security-Policy", "script-src 'self' https://js.hsforms.net https://www.google.com/recaptcha/ https://www.gstatic.com/recaptcha/; object-src 'none'; frame-ancestors 'none'; frame-src https://www.google.com/recaptcha/ https://www.gstatic.com/recaptcha/")
+			w.Header().Set("Content-Security-Policy", "script-src 'self' cdn.matomo.cloud js.hsforms.net https://www.google.com/recaptcha/, https://www.gstatic.com/recaptcha/; object-src 'none'; frame-ancestors 'none'; frame-src https://www.google.com/recaptcha/ https://www.gstatic.com/recaptcha/")
 		}
 
 		w.Header().Set("X-Content-Type-Options", "nosniff")

api/internal/registryutils/get_registry_name.go

@@ -1,11 +0,0 @@
-package registryutils
-
-import (
-	"strconv"
-
-	portainer "github.com/portainer/portainer/api"
-)
-
-func RegistrySecretName(registryID portainer.RegistryID) string {
-	return "registry-" + strconv.Itoa(int(registryID))
-}

api/internal/testhelpers/datastore.go

@@ -113,7 +113,7 @@ type datastoreOption = func(d *testDatastore)
 // NewDatastore creates new instance of testDatastore.
 // Will apply options before returning, opts will be applied from left to right.
 func NewDatastore(options ...datastoreOption) *testDatastore {
-	conn, _ := database.NewDatabase("boltdb", "", nil, false)
+	conn, _ := database.NewDatabase("boltdb", "", nil)
 	d := testDatastore{connection: conn}
 
 	for _, o := range options {

api/internal/testhelpers/user_activity_service.go

@@ -1,12 +0,0 @@
-package testhelpers
-
-type userActivityService struct {
-}
-
-func NewUserActivityService() *userActivityService {
-	return &userActivityService{}
-}
-
-func (service *userActivityService) LogUserActivity(username string, context string, action string, payload []byte) error {
-	return nil
-}

api/kubernetes/cli/access.go

@@ -145,33 +145,21 @@ func (kcl *KubeClient) GetNonAdminNamespaces(userID int, teamIDs []int, isRestri
 }
 
 // GetIsKubeAdmin retrieves true if client is admin
-func (kcl *KubeClient) GetIsKubeAdmin() bool {
-	kcl.mu.Lock()
-	defer kcl.mu.Unlock()
-
-	return kcl.isKubeAdmin
+func (client *KubeClient) GetIsKubeAdmin() bool {
+	return client.IsKubeAdmin
 }
 
 // UpdateIsKubeAdmin sets whether the kube client is admin
-func (kcl *KubeClient) SetIsKubeAdmin(isKubeAdmin bool) {
-	kcl.mu.Lock()
-	defer kcl.mu.Unlock()
-
-	kcl.isKubeAdmin = isKubeAdmin
+func (client *KubeClient) SetIsKubeAdmin(isKubeAdmin bool) {
+	client.IsKubeAdmin = isKubeAdmin
 }
 
 // GetClientNonAdminNamespaces retrieves non-admin namespaces
-func (kcl *KubeClient) GetClientNonAdminNamespaces() []string {
-	kcl.mu.Lock()
-	defer kcl.mu.Unlock()
-
-	return kcl.nonAdminNamespaces
+func (client *KubeClient) GetClientNonAdminNamespaces() []string {
+	return client.NonAdminNamespaces
 }
 
 // UpdateClientNonAdminNamespaces sets the client non admin namespace list
-func (kcl *KubeClient) SetClientNonAdminNamespaces(nonAdminNamespaces []string) {
-	kcl.mu.Lock()
-	defer kcl.mu.Unlock()
-
-	kcl.nonAdminNamespaces = nonAdminNamespaces
+func (client *KubeClient) SetClientNonAdminNamespaces(nonAdminNamespaces []string) {
+	client.NonAdminNamespaces = nonAdminNamespaces
 }

api/kubernetes/cli/access_test.go

@@ -67,27 +67,3 @@ func Test_NamespaceAccessPoliciesDeleteNamespace_updatesPortainerConfig_whenConf
 		})
 	}
 }
-
-func TestKubeAdmin(t *testing.T) {
-	kcl := &KubeClient{}
-	require.False(t, kcl.GetIsKubeAdmin())
-
-	kcl.SetIsKubeAdmin(true)
-	require.True(t, kcl.GetIsKubeAdmin())
-
-	kcl.SetIsKubeAdmin(false)
-	require.False(t, kcl.GetIsKubeAdmin())
-}
-
-func TestClientNonAdminNamespaces(t *testing.T) {
-	kcl := &KubeClient{}
-
-	require.Empty(t, kcl.GetClientNonAdminNamespaces())
-
-	nss := []string{"ns1", "ns2"}
-	kcl.SetClientNonAdminNamespaces(nss)
-	require.Equal(t, nss, kcl.GetClientNonAdminNamespaces())
-
-	kcl.SetClientNonAdminNamespaces([]string{})
-	require.Empty(t, kcl.GetClientNonAdminNamespaces())
-}

api/kubernetes/cli/applications.go

@@ -28,7 +28,7 @@ type PortainerApplicationResources struct {
 // if the user is an admin, all namespaces in the current k8s environment(endpoint) are fetched using the fetchApplications function.
 // otherwise, namespaces the non-admin user has access to will be used to filter the applications based on the allowed namespaces.
 func (kcl *KubeClient) GetApplications(namespace, nodeName string) ([]models.K8sApplication, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchApplications(namespace, nodeName)
 	}
 
@@ -64,13 +64,9 @@ func (kcl *KubeClient) fetchApplications(namespace, nodeName string) ([]models.K
 // fetchApplicationsForNonAdmin fetches the applications in the namespaces the user has access to.
 // This function is called when the user is not an admin.
 func (kcl *KubeClient) fetchApplicationsForNonAdmin(namespace, nodeName string) ([]models.K8sApplication, error) {
-	nonAdminNamespaces := kcl.GetClientNonAdminNamespaces()
+	log.Debug().Msgf("Fetching applications for non-admin user: %v", kcl.NonAdminNamespaces)
 
-	log.Debug().
-		Strs("non_admin_namespaces", nonAdminNamespaces).
-		Msg("fetching applications for non-admin user")
-
-	if len(nonAdminNamespaces) == 0 {
+	if len(kcl.NonAdminNamespaces) == 0 {
 		return nil, nil
 	}
 
@@ -263,7 +259,6 @@ func populateApplicationFromDeployment(application *models.K8sApplication, deplo
 	application.ApplicationOwner = deployment.Labels["io.portainer.kubernetes.application.owner"]
 	application.StackID = deployment.Labels["io.portainer.kubernetes.application.stackid"]
 	application.StackName = deployment.Labels["io.portainer.kubernetes.application.stack"]
-	application.StackKind = deployment.Labels["io.portainer.kubernetes.application.stackKind"]
 	application.Labels = deployment.Labels
 	application.MatchLabels = deployment.Spec.Selector.MatchLabels
 	application.CreationDate = deployment.CreationTimestamp.Time
@@ -293,7 +288,6 @@ func populateApplicationFromStatefulSet(application *models.K8sApplication, stat
 	application.ApplicationOwner = statefulSet.Labels["io.portainer.kubernetes.application.owner"]
 	application.StackID = statefulSet.Labels["io.portainer.kubernetes.application.stackid"]
 	application.StackName = statefulSet.Labels["io.portainer.kubernetes.application.stack"]
-	application.StackKind = statefulSet.Labels["io.portainer.kubernetes.application.stackKind"]
 	application.Labels = statefulSet.Labels
 	application.MatchLabels = statefulSet.Spec.Selector.MatchLabels
 	application.CreationDate = statefulSet.CreationTimestamp.Time
@@ -323,7 +317,6 @@ func populateApplicationFromDaemonSet(application *models.K8sApplication, daemon
 	application.ApplicationOwner = daemonSet.Labels["io.portainer.kubernetes.application.owner"]
 	application.StackID = daemonSet.Labels["io.portainer.kubernetes.application.stackid"]
 	application.StackName = daemonSet.Labels["io.portainer.kubernetes.application.stack"]
-	application.StackKind = daemonSet.Labels["io.portainer.kubernetes.application.stackKind"]
 	application.Labels = daemonSet.Labels
 	application.MatchLabels = daemonSet.Spec.Selector.MatchLabels
 	application.CreationDate = daemonSet.CreationTimestamp.Time
@@ -354,7 +347,6 @@ func populateApplicationFromPod(application *models.K8sApplication, pod corev1.P
 	application.ApplicationOwner = pod.Labels["io.portainer.kubernetes.application.owner"]
 	application.StackID = pod.Labels["io.portainer.kubernetes.application.stackid"]
 	application.StackName = pod.Labels["io.portainer.kubernetes.application.stack"]
-	application.StackKind = pod.Labels["io.portainer.kubernetes.application.stackKind"]
 	application.Labels = pod.Labels
 	application.MatchLabels = pod.Labels
 	application.CreationDate = pod.CreationTimestamp.Time

api/kubernetes/cli/applications_test.go

@@ -312,7 +312,7 @@ func TestGetApplications(t *testing.T) {
 		kubeClient := &KubeClient{
 			cli:         fakeClient,
 			instanceID:  "test-instance",
-			isKubeAdmin: true,
+			IsKubeAdmin: true,
 		}
 
 		// Test cases
@@ -387,8 +387,8 @@ func TestGetApplications(t *testing.T) {
 		kubeClient := &KubeClient{
 			cli:                fakeClient,
 			instanceID:         "test-instance",
-			isKubeAdmin:        false,
-			nonAdminNamespaces: []string{namespace1},
+			IsKubeAdmin:        false,
+			NonAdminNamespaces: []string{namespace1},
 		}
 
 		// Test that only resources from allowed namespace are returned
@@ -447,7 +447,7 @@ func TestGetApplications(t *testing.T) {
 		kubeClient := &KubeClient{
 			cli:         fakeClient,
 			instanceID:  "test-instance",
-			isKubeAdmin: true,
+			IsKubeAdmin: true,
 		}
 
 		// Test filtering by node name

api/kubernetes/cli/client.go

@@ -42,8 +42,8 @@ type (
 		cli                kubernetes.Interface
 		instanceID         string
 		mu                 sync.Mutex
-		isKubeAdmin        bool
-		nonAdminNamespaces []string
+		IsKubeAdmin        bool
+		NonAdminNamespaces []string
 	}
 )
 
@@ -147,7 +147,6 @@ func (factory *ClientFactory) GetProxyKubeClient(endpointID, userID string) (*Ku
 	if ok {
 		return client.(*KubeClient), true
 	}
-
 	return nil, false
 }
 
@@ -180,8 +179,8 @@ func (factory *ClientFactory) CreateKubeClientFromKubeConfig(clusterID string, k
 	return &KubeClient{
 		cli:                cli,
 		instanceID:         factory.instanceID,
-		isKubeAdmin:        IsKubeAdmin,
-		nonAdminNamespaces: NonAdminNamespaces,
+		IsKubeAdmin:        IsKubeAdmin,
+		NonAdminNamespaces: NonAdminNamespaces,
 	}, nil
 }
 
@@ -194,7 +193,7 @@ func (factory *ClientFactory) createCachedPrivilegedKubeClient(endpoint *portain
 	return &KubeClient{
 		cli:         cli,
 		instanceID:  factory.instanceID,
-		isKubeAdmin: true,
+		IsKubeAdmin: true,
 	}, nil
 }
 
@@ -372,7 +371,6 @@ func (factory *ClientFactory) MigrateEndpointIngresses(e *portainer.Endpoint, da
 				log.Error().Err(err).Msgf("Error getting ingresses in environment %d", environment.ID)
 				return err
 			}
-
 			for _, ingress := range ingresses {
 				oldController, ok := ingress.Annotations["ingress.portainer.io/ingress-type"]
 				if !ok {

api/kubernetes/cli/cluster_role.go

@@ -16,7 +16,7 @@ import (
 // GetClusterRoles gets all the clusterRoles for at the cluster level in a k8s endpoint.
 // It returns a list of K8sClusterRole objects.
 func (kcl *KubeClient) GetClusterRoles() ([]models.K8sClusterRole, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchClusterRoles()
 	}
 

api/kubernetes/cli/cluster_role_binding.go

@@ -16,7 +16,7 @@ import (
 // GetClusterRoleBindings gets all the clusterRoleBindings for at the cluster level in a k8s endpoint.
 // It returns a list of K8sClusterRoleBinding objects.
 func (kcl *KubeClient) GetClusterRoleBindings() ([]models.K8sClusterRoleBinding, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchClusterRoleBindings()
 	}
 

api/kubernetes/cli/configmap.go

@@ -16,23 +16,18 @@ import (
 // if the user is an admin, all configMaps in the current k8s environment(endpoint) are fetched using the fetchConfigMaps function.
 // otherwise, namespaces the non-admin user has access to will be used to filter the configMaps based on the allowed namespaces.
 func (kcl *KubeClient) GetConfigMaps(namespace string) ([]models.K8sConfigMap, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchConfigMaps(namespace)
 	}
-
 	return kcl.fetchConfigMapsForNonAdmin(namespace)
 }
 
 // fetchConfigMapsForNonAdmin fetches the configMaps in the namespaces the user has access to.
 // This function is called when the user is not an admin.
 func (kcl *KubeClient) fetchConfigMapsForNonAdmin(namespace string) ([]models.K8sConfigMap, error) {
-	nonAdminNamespaces := kcl.GetClientNonAdminNamespaces()
+	log.Debug().Msgf("Fetching configMaps for non-admin user: %v", kcl.NonAdminNamespaces)
 
-	log.Debug().
-		Strs("non_admin_namespaces", nonAdminNamespaces).
-		Msg("fetching configMaps for non-admin user")
-
-	if len(nonAdminNamespaces) == 0 {
+	if len(kcl.NonAdminNamespaces) == 0 {
 		return nil, nil
 	}
 

api/kubernetes/cli/cronjob.go

@@ -15,7 +15,7 @@ import (
 // If the user is a kube admin, it returns all cronjobs in the namespace
 // Otherwise, it returns only the cronjobs in the non-admin namespaces
 func (kcl *KubeClient) GetCronJobs(namespace string) ([]models.K8sCronJob, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchCronJobs(namespace)
 	}
 

api/kubernetes/cli/cronjob_test.go

@@ -18,7 +18,7 @@ func (kcl *KubeClient) TestFetchCronJobs(t *testing.T) {
 	t.Run("admin client can fetch Cron Jobs from all namespaces", func(t *testing.T) {
 		kcl.cli = kfake.NewSimpleClientset()
 		kcl.instanceID = "test"
-		kcl.isKubeAdmin = true
+		kcl.IsKubeAdmin = true
 
 		cronJobs, err := kcl.GetCronJobs("")
 		if err != nil {
@@ -31,8 +31,8 @@ func (kcl *KubeClient) TestFetchCronJobs(t *testing.T) {
 	t.Run("non-admin client can fetch Cron Jobs from the default namespace only", func(t *testing.T) {
 		kcl.cli = kfake.NewSimpleClientset()
 		kcl.instanceID = "test"
-		kcl.isKubeAdmin = false
-		kcl.SetClientNonAdminNamespaces([]string{"default"})
+		kcl.IsKubeAdmin = false
+		kcl.NonAdminNamespaces = []string{"default"}
 
 		cronJobs, err := kcl.GetCronJobs("")
 		if err != nil {

api/kubernetes/cli/event.go

@@ -12,7 +12,7 @@ import (
 // If the user is a kube admin, it returns all events in the namespace
 // Otherwise, it returns only the events in the non-admin namespaces
 func (kcl *KubeClient) GetEvents(namespace string, resourceId string) ([]models.K8sEvent, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchAllEvents(namespace, resourceId)
 	}
 
@@ -22,7 +22,7 @@ func (kcl *KubeClient) GetEvents(namespace string, resourceId string) ([]models.
 // fetchEventsForNonAdmin returns all events in the given namespace and resource
 // It returns only the events in the non-admin namespaces
 func (kcl *KubeClient) fetchEventsForNonAdmin(namespace string, resourceId string) ([]models.K8sEvent, error) {
-	if len(kcl.GetClientNonAdminNamespaces()) == 0 {
+	if len(kcl.NonAdminNamespaces) == 0 {
 		return nil, nil
 	}
 

api/kubernetes/cli/event_test.go

@@ -19,7 +19,7 @@ func TestGetEvents(t *testing.T) {
 		kcl := &KubeClient{
 			cli:         kfake.NewSimpleClientset(),
 			instanceID:  "instance",
-			isKubeAdmin: true,
+			IsKubeAdmin: true,
 		}
 
 		event := corev1.Event{
@@ -47,8 +47,8 @@ func TestGetEvents(t *testing.T) {
 		kcl := &KubeClient{
 			cli:                kfake.NewSimpleClientset(),
 			instanceID:         "instance",
-			isKubeAdmin:        false,
-			nonAdminNamespaces: []string{"nonAdmin"},
+			IsKubeAdmin:        false,
+			NonAdminNamespaces: []string{"nonAdmin"},
 		}
 
 		event := corev1.Event{
@@ -77,8 +77,8 @@ func TestGetEvents(t *testing.T) {
 		kcl := &KubeClient{
 			cli:                kfake.NewSimpleClientset(),
 			instanceID:         "instance",
-			isKubeAdmin:        false,
-			nonAdminNamespaces: []string{"nonAdmin"},
+			IsKubeAdmin:        false,
+			NonAdminNamespaces: []string{"nonAdmin"},
 		}
 
 		event := corev1.Event{

api/kubernetes/cli/exec.go

@@ -12,16 +12,6 @@ import (
 	utilexec "k8s.io/client-go/util/exec"
 )
 
-var (
-	channelProtocolList = []string{
-		"v5.channel.k8s.io",
-		"v4.channel.k8s.io",
-		"v3.channel.k8s.io",
-		"v2.channel.k8s.io",
-		"channel.k8s.io",
-	}
-)
-
 // StartExecProcess will start an exec process inside a container located inside a pod inside a specific namespace
 // using the specified command. The stdin parameter will be bound to the stdin process and the stdout process will write
 // to the stdout parameter.
@@ -55,18 +45,10 @@ func (kcl *KubeClient) StartExecProcess(token string, useAdminToken bool, namesp
 		TTY:       true,
 	}, scheme.ParameterCodec)
 
-	exec, err := remotecommand.NewWebSocketExecutorForProtocols(
-		config,
-		"GET", // WebSocket uses GET for the upgrade request
-		req.URL().String(),
-		channelProtocolList...,
-	)
+	exec, err := remotecommand.NewSPDYExecutor(config, "POST", req.URL())
 	if err != nil {
-		exec, err = remotecommand.NewSPDYExecutor(config, "POST", req.URL())
-		if err != nil {
-			errChan <- err
-			return
-		}
+		errChan <- err
+		return
 	}
 
 	err = exec.StreamWithContext(context.TODO(), remotecommand.StreamOptions{

api/kubernetes/cli/ingress.go

@@ -87,22 +87,17 @@ func (kcl *KubeClient) GetIngress(namespace, ingressName string) (models.K8sIngr
 
 // GetIngresses gets all the ingresses for a given namespace in a k8s endpoint.
 func (kcl *KubeClient) GetIngresses(namespace string) ([]models.K8sIngressInfo, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchIngresses(namespace)
 	}
-
 	return kcl.fetchIngressesForNonAdmin(namespace)
 }
 
 // fetchIngressesForNonAdmin gets all the ingresses for non-admin users in a k8s endpoint.
 func (kcl *KubeClient) fetchIngressesForNonAdmin(namespace string) ([]models.K8sIngressInfo, error) {
-	nonAdminNamespaces := kcl.GetClientNonAdminNamespaces()
+	log.Debug().Msgf("Fetching ingresses for non-admin user: %v", kcl.NonAdminNamespaces)
 
-	log.Debug().
-		Strs("non_admin_namespaces", nonAdminNamespaces).
-		Msg("fetching ingresses for non-admin user")
-
-	if len(nonAdminNamespaces) == 0 {
+	if len(kcl.NonAdminNamespaces) == 0 {
 		return nil, nil
 	}
 

api/kubernetes/cli/ingress_test.go

@@ -1,15 +0,0 @@
-package cli
-
-import (
-	"testing"
-
-	"github.com/stretchr/testify/require"
-)
-
-func TestGetIngresses(t *testing.T) {
-	kcl := &KubeClient{}
-
-	ingresses, err := kcl.GetIngresses("default")
-	require.NoError(t, err)
-	require.Empty(t, ingresses)
-}

api/kubernetes/cli/job.go

@@ -19,7 +19,7 @@ import (
 // If the user is a kube admin, it returns all jobs in the namespace
 // Otherwise, it returns only the jobs in the non-admin namespaces
 func (kcl *KubeClient) GetJobs(namespace string, includeCronJobChildren bool) ([]models.K8sJob, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchJobs(namespace, includeCronJobChildren)
 	}
 

api/kubernetes/cli/job_test.go

@@ -21,7 +21,7 @@ func (kcl *KubeClient) TestFetchJobs(t *testing.T) {
 	t.Run("admin client can fetch jobs from all namespaces", func(t *testing.T) {
 		kcl.cli = kfake.NewSimpleClientset()
 		kcl.instanceID = "test"
-		kcl.isKubeAdmin = true
+		kcl.IsKubeAdmin = true
 
 		jobs, err := kcl.GetJobs("", false)
 		if err != nil {
@@ -34,8 +34,8 @@ func (kcl *KubeClient) TestFetchJobs(t *testing.T) {
 	t.Run("non-admin client can fetch jobs from the default namespace only", func(t *testing.T) {
 		kcl.cli = kfake.NewSimpleClientset()
 		kcl.instanceID = "test"
-		kcl.isKubeAdmin = false
-		kcl.SetClientNonAdminNamespaces([]string{"default"})
+		kcl.IsKubeAdmin = false
+		kcl.NonAdminNamespaces = []string{"default"}
 
 		jobs, err := kcl.GetJobs("", false)
 		if err != nil {

api/kubernetes/cli/namespace.go

@@ -40,10 +40,9 @@ func defaultSystemNamespaces() map[string]struct{} {
 // if the user is an admin, all namespaces in the current k8s environment(endpoint) are fetched using the fetchNamespaces function.
 // otherwise, namespaces the non-admin user has access to will be used to filter the namespaces based on the allowed namespaces.
 func (kcl *KubeClient) GetNamespaces() (map[string]portainer.K8sNamespaceInfo, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchNamespaces()
 	}
-
 	return kcl.fetchNamespacesForNonAdmin()
 }
 
@@ -53,7 +52,7 @@ func (kcl *KubeClient) fetchNamespacesForNonAdmin() (map[string]portainer.K8sNam
 		Str("context", "fetchNamespacesForNonAdmin").
 		Msg("Fetching namespaces for non-admin user")
 
-	if len(kcl.GetClientNonAdminNamespaces()) == 0 {
+	if len(kcl.NonAdminNamespaces) == 0 {
 		return nil, nil
 	}
 
@@ -143,7 +142,6 @@ func (kcl *KubeClient) CreateNamespace(info models.K8sNamespaceDetails) (*corev1
 			Str("context", "CreateNamespace").
 			Str("Namespace", info.Name).
 			Msg("Failed to create the namespace")
-
 		return nil, err
 	}
 
@@ -159,7 +157,7 @@ func (kcl *KubeClient) CreateNamespace(info models.K8sNamespaceDetails) (*corev1
 	return namespace, nil
 }
 
-// UpdateNamespace updates a namespace in a k8s endpoint.
+// UpdateIngress updates an ingress in a given namespace in a k8s endpoint.
 func (kcl *KubeClient) UpdateNamespace(info models.K8sNamespaceDetails) (*corev1.Namespace, error) {
 	portainerLabels := map[string]string{
 		namespaceNameLabel:  stackutils.SanitizeLabel(info.Name),
@@ -422,10 +420,8 @@ func (kcl *KubeClient) CombineNamespaceWithResourceQuota(namespace portainer.K8s
 // buildNonAdminNamespacesMap builds a map of non-admin namespaces.
 // the map is used to filter the namespaces based on the allowed namespaces.
 func (kcl *KubeClient) buildNonAdminNamespacesMap() map[string]struct{} {
-	nonAdminNamespaces := kcl.GetClientNonAdminNamespaces()
-	nonAdminNamespaceSet := make(map[string]struct{}, len(nonAdminNamespaces))
-
-	for _, namespace := range nonAdminNamespaces {
+	nonAdminNamespaceSet := make(map[string]struct{}, len(kcl.NonAdminNamespaces))
+	for _, namespace := range kcl.NonAdminNamespaces {
 		if !isSystemDefaultNamespace(namespace) {
 			nonAdminNamespaceSet[namespace] = struct{}{}
 		}

api/kubernetes/cli/namespace_test.go

@@ -178,7 +178,6 @@ func Test_ToggleSystemState(t *testing.T) {
 		expectedPolicies := map[string]portainer.K8sNamespaceAccessPolicy{
 			"ns2": {UserAccessPolicies: portainer.UserAccessPolicies{2: {RoleID: 0}}},
 		}
-
 		actualPolicies, err := kcl.GetNamespaceAccessPolicies()
 		require.NoError(t, err, "failed to fetch policies")
 		assert.Equal(t, expectedPolicies, actualPolicies)

api/kubernetes/cli/nodes_limits.go

@@ -46,9 +46,9 @@ func (kcl *KubeClient) GetNodesLimits() (portainer.K8sNodesLimits, error) {
 
 // GetMaxResourceLimits gets the maximum CPU and Memory limits(unused resources) of all nodes in the current k8s environment(endpoint) connection, minus the accumulated resourcequotas for all namespaces except the one we're editing (skipNamespace)
 // if skipNamespace is set to "" then all namespaces are considered
-func (kcl *KubeClient) GetMaxResourceLimits(skipNamespace string, overCommitEnabled bool, resourceOverCommitPercent int) (portainer.K8sNodeLimits, error) {
+func (client *KubeClient) GetMaxResourceLimits(skipNamespace string, overCommitEnabled bool, resourceOverCommitPercent int) (portainer.K8sNodeLimits, error) {
 	limits := portainer.K8sNodeLimits{}
-	nodes, err := kcl.cli.CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{})
+	nodes, err := client.cli.CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{})
 	if err != nil {
 		return limits, err
 	}
@@ -62,7 +62,7 @@ func (kcl *KubeClient) GetMaxResourceLimits(skipNamespace string, overCommitEnab
 	limits.Memory = memory / 1000000 // B to MB
 
 	if !overCommitEnabled {
-		namespaces, err := kcl.cli.CoreV1().Namespaces().List(context.TODO(), metav1.ListOptions{})
+		namespaces, err := client.cli.CoreV1().Namespaces().List(context.TODO(), metav1.ListOptions{})
 		if err != nil {
 			return limits, err
 		}
@@ -77,7 +77,7 @@ func (kcl *KubeClient) GetMaxResourceLimits(skipNamespace string, overCommitEnab
 			}
 
 			// minus accumulated resourcequotas for all namespaces except the one we're editing
-			resourceQuota, err := kcl.cli.CoreV1().ResourceQuotas(namespace.Name).List(context.TODO(), metav1.ListOptions{})
+			resourceQuota, err := client.cli.CoreV1().ResourceQuotas(namespace.Name).List(context.TODO(), metav1.ListOptions{})
 			if err != nil {
 				log.Debug().Msgf("error getting resourcequota for namespace %s: %s", namespace.Name, err)
 				continue // skip it

api/kubernetes/cli/pod_test.go

@@ -59,7 +59,6 @@ func Test_waitForPodStatus(t *testing.T) {
 
 		ctx, cancelFunc := context.WithTimeout(context.TODO(), 0*time.Second)
 		defer cancelFunc()
-
 		err = k.waitForPodStatus(ctx, v1.PodRunning, podSpec)
 		if !errors.Is(err, context.DeadlineExceeded) {
 			t.Errorf("waitForPodStatus should throw deadline exceeded error; err=%s", err)

api/kubernetes/cli/registries.go

@@ -2,6 +2,7 @@ package cli
 
 import (
 	"context"
+	"fmt"
 	"strconv"
 
 	portainer "github.com/portainer/portainer/api"
@@ -33,7 +34,7 @@ type (
 )
 
 func (kcl *KubeClient) DeleteRegistrySecret(registry portainer.RegistryID, namespace string) error {
-	if err := kcl.cli.CoreV1().Secrets(namespace).Delete(context.TODO(), registryutils.RegistrySecretName(registry), metav1.DeleteOptions{}); err != nil && !k8serrors.IsNotFound(err) {
+	if err := kcl.cli.CoreV1().Secrets(namespace).Delete(context.TODO(), kcl.RegistrySecretName(registry), metav1.DeleteOptions{}); err != nil && !k8serrors.IsNotFound(err) {
 		return errors.Wrap(err, "failed removing secret")
 	}
 
@@ -61,15 +62,11 @@ func (kcl *KubeClient) CreateRegistrySecret(registry *portainer.Registry, namesp
 	}
 
 	secret := &v1.Secret{
-		TypeMeta: metav1.TypeMeta{
-			APIVersion: "v1",
-			Kind:       "Secret",
-		},
+		TypeMeta: metav1.TypeMeta{},
 		ObjectMeta: metav1.ObjectMeta{
-			Name: registryutils.RegistrySecretName(registry.ID),
+			Name: kcl.RegistrySecretName(registry.ID),
 			Labels: map[string]string{
-				labelRegistryType:              strconv.Itoa(int(registry.Type)),
-				"app.kubernetes.io/managed-by": "portainer",
+				labelRegistryType: strconv.Itoa(int(registry.Type)),
 			},
 			Annotations: map[string]string{
 				annotationRegistryID: strconv.Itoa(int(registry.ID)),
@@ -102,3 +99,7 @@ func (cli *KubeClient) IsRegistrySecret(namespace, secretName string) (bool, err
 
 	return isSecret, nil
 }
+
+func (*KubeClient) RegistrySecretName(registryID portainer.RegistryID) string {
+	return fmt.Sprintf("registry-%d", registryID)
+}

api/kubernetes/cli/resource_quota.go

@@ -15,23 +15,18 @@ import (
 // if the user is an admin, all resource quotas in all namespaces are fetched.
 // otherwise, namespaces the non-admin user has access to will be used to filter the resource quotas.
 func (kcl *KubeClient) GetResourceQuotas(namespace string) (*[]corev1.ResourceQuota, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchResourceQuotas(namespace)
 	}
-
 	return kcl.fetchResourceQuotasForNonAdmin(namespace)
 }
 
 // fetchResourceQuotasForNonAdmin gets the resource quotas in the current k8s environment(endpoint) for a non-admin user.
 // the role of the user must have read access to the resource quotas in the defined namespaces.
 func (kcl *KubeClient) fetchResourceQuotasForNonAdmin(namespace string) (*[]corev1.ResourceQuota, error) {
-	nonAdminNamespaces := kcl.GetClientNonAdminNamespaces()
+	log.Debug().Msgf("Fetching resource quotas for non-admin user: %v", kcl.NonAdminNamespaces)
 
-	log.Debug().
-		Strs("non_admin_namespaces", nonAdminNamespaces).
-		Msg("fetching resource quotas for non-admin user")
-
-	if len(nonAdminNamespaces) == 0 {
+	if len(kcl.NonAdminNamespaces) == 0 {
 		return nil, nil
 	}
 

api/kubernetes/cli/resource_quota_test.go

@@ -1,15 +0,0 @@
-package cli
-
-import (
-	"testing"
-
-	"github.com/stretchr/testify/require"
-)
-
-func TestGetResourceQuotas(t *testing.T) {
-	kcl := &KubeClient{}
-
-	resourceQuotas, err := kcl.GetResourceQuotas("default")
-	require.NoError(t, err)
-	require.Empty(t, resourceQuotas)
-}

api/kubernetes/cli/role.go

@@ -15,7 +15,7 @@ import (
 // GetRoles gets all the roles for either at the cluster level or a given namespace in a k8s endpoint.
 // It returns a list of K8sRole objects.
 func (kcl *KubeClient) GetRoles(namespace string) ([]models.K8sRole, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchRoles(namespace)
 	}
 

api/kubernetes/cli/role_binding.go

@@ -15,7 +15,7 @@ import (
 // GetRoleBindings gets all the roleBindings for either at the cluster level or a given namespace in a k8s endpoint.
 // It returns a list of K8sRoleBinding objects.
 func (kcl *KubeClient) GetRoleBindings(namespace string) ([]models.K8sRoleBinding, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchRoleBindings(namespace)
 	}
 

api/kubernetes/cli/secret.go

@@ -23,23 +23,18 @@ const (
 // if the user is an admin, all secrets in the current k8s environment(endpoint) are fetched using the getSecrets function.
 // otherwise, namespaces the non-admin user has access to will be used to filter the secrets based on the allowed namespaces.
 func (kcl *KubeClient) GetSecrets(namespace string) ([]models.K8sSecret, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.getSecrets(namespace)
 	}
-
 	return kcl.getSecretsForNonAdmin(namespace)
 }
 
 // getSecretsForNonAdmin fetches the secrets in the namespaces the user has access to.
 // This function is called when the user is not an admin.
 func (kcl *KubeClient) getSecretsForNonAdmin(namespace string) ([]models.K8sSecret, error) {
-	nonAdminNamespaces := kcl.GetClientNonAdminNamespaces()
+	log.Debug().Msgf("Fetching secrets for non-admin user: %v", kcl.NonAdminNamespaces)
 
-	log.Debug().
-		Strs("non_admin_namespaces", nonAdminNamespaces).
-		Msg("fetching secrets for non-admin user")
-
-	if len(nonAdminNamespaces) == 0 {
+	if len(kcl.NonAdminNamespaces) == 0 {
 		return nil, nil
 	}
 

api/kubernetes/cli/service.go

@@ -15,10 +15,9 @@ import (
 // GetServices gets all the services for either at the cluster level or a given namespace in a k8s endpoint.
 // It returns a list of K8sServiceInfo objects.
 func (kcl *KubeClient) GetServices(namespace string) ([]models.K8sServiceInfo, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchServices(namespace)
 	}
-
 	return kcl.fetchServicesForNonAdmin(namespace)
 }
 
@@ -26,13 +25,9 @@ func (kcl *KubeClient) GetServices(namespace string) ([]models.K8sServiceInfo, e
 // the namespace will be coming from NonAdminNamespaces as non-admin users are restricted to certain namespaces.
 // it returns a list of K8sServiceInfo objects.
 func (kcl *KubeClient) fetchServicesForNonAdmin(namespace string) ([]models.K8sServiceInfo, error) {
-	nonAdminNamespaces := kcl.GetClientNonAdminNamespaces()
+	log.Debug().Msgf("Fetching services for non-admin user: %v", kcl.NonAdminNamespaces)
 
-	log.Debug().
-		Strs("non_admin_namespaces", nonAdminNamespaces).
-		Msg("fetching services for non-admin user")
-
-	if len(nonAdminNamespaces) == 0 {
+	if len(kcl.NonAdminNamespaces) == 0 {
 		return nil, nil
 	}
 

api/kubernetes/cli/service_account.go

@@ -16,7 +16,7 @@ import (
 // GetServiceAccounts gets all the service accounts for either at the cluster level or a given namespace in a k8s endpoint.
 // It returns a list of K8sServiceAccount objects.
 func (kcl *KubeClient) GetServiceAccounts(namespace string) ([]models.K8sServiceAccount, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchServiceAccounts(namespace)
 	}
 

api/kubernetes/cli/service_test.go

@@ -1,15 +0,0 @@
-package cli
-
-import (
-	"testing"
-
-	"github.com/stretchr/testify/require"
-)
-
-func TestGetServices(t *testing.T) {
-	kcl := &KubeClient{}
-
-	services, err := kcl.GetServices("default")
-	require.NoError(t, err)
-	require.Empty(t, services)
-}

api/kubernetes/cli/volumes.go

@@ -18,10 +18,9 @@ import (
 // If the user is not an admin, it fetches the volumes in the namespaces the user has access to.
 // It returns a list of K8sVolumeInfo.
 func (kcl *KubeClient) GetVolumes(namespace string) ([]models.K8sVolumeInfo, error) {
-	if kcl.GetIsKubeAdmin() {
+	if kcl.IsKubeAdmin {
 		return kcl.fetchVolumes(namespace)
 	}
-
 	return kcl.fetchVolumesForNonAdmin(namespace)
 }
 
@@ -49,13 +48,9 @@ func (kcl *KubeClient) GetVolume(namespace, volumeName string) (*models.K8sVolum
 // This function is called when the user is not an admin.
 // It fetches all the persistent volume claims, persistent volumes and storage classes in the namespaces the user has access to.
 func (kcl *KubeClient) fetchVolumesForNonAdmin(namespace string) ([]models.K8sVolumeInfo, error) {
-	nonAdminNamespaces := kcl.GetClientNonAdminNamespaces()
+	log.Debug().Msgf("Fetching volumes for non-admin user: %v", kcl.NonAdminNamespaces)
 
-	log.Debug().
-		Strs("non_admin_namespaces", nonAdminNamespaces).
-		Msg("fetching volumes for non-admin user")
-
-	if len(nonAdminNamespaces) == 0 {
+	if len(kcl.NonAdminNamespaces) == 0 {
 		return nil, nil
 	}
 

api/kubernetes/cli/volumes_test.go

@@ -1,15 +0,0 @@
-package cli
-
-import (
-	"testing"
-
-	"github.com/stretchr/testify/require"
-)
-
-func TestGetVolumes(t *testing.T) {
-	kcl := &KubeClient{}
-
-	volumes, err := kcl.GetVolumes("default")
-	require.NoError(t, err)
-	require.Empty(t, volumes)
-}

api/kubernetes/yaml.go

@@ -13,13 +13,11 @@ import (
 )
 
 const (
-	labelPortainerAppStack     = "io.portainer.kubernetes.application.stack"
-	labelPortainerAppStackID   = "io.portainer.kubernetes.application.stackid"
-	labelPortainerAppName      = "io.portainer.kubernetes.application.name"
-	labelPortainerAppOwner     = "io.portainer.kubernetes.application.owner"
-	labelPortainerAppOwnerId   = "io.portainer.kubernetes.application.owner.id"
-	labelPortainerAppKind      = "io.portainer.kubernetes.application.kind"
-	labelPortainerAppStackKind = "io.portainer.kubernetes.application.stackKind"
+	labelPortainerAppStack   = "io.portainer.kubernetes.application.stack"
+	labelPortainerAppStackID = "io.portainer.kubernetes.application.stackid"
+	labelPortainerAppName    = "io.portainer.kubernetes.application.name"
+	labelPortainerAppOwner   = "io.portainer.kubernetes.application.owner"
+	labelPortainerAppKind    = "io.portainer.kubernetes.application.kind"
 )
 
 // KubeAppLabels are labels applied to all resources deployed in a kubernetes stack
@@ -27,28 +25,18 @@ type KubeAppLabels struct {
 	StackID   int
 	StackName string
 	Owner     string
-	OwnerId   string
 	Kind      string
-	StackKind string
 }
 
 // ToMap converts KubeAppLabels to a map[string]string
 func (kal *KubeAppLabels) ToMap() map[string]string {
-	labels := map[string]string{
+	return map[string]string{
 		labelPortainerAppStackID: strconv.Itoa(kal.StackID),
 		labelPortainerAppStack:   stackutils.SanitizeLabel(kal.StackName),
 		labelPortainerAppName:    stackutils.SanitizeLabel(kal.StackName),
 		labelPortainerAppOwner:   stackutils.SanitizeLabel(kal.Owner),
 		labelPortainerAppKind:    kal.Kind,
-		labelPortainerAppOwnerId: kal.OwnerId,
 	}
-
-	// Add optional labels only if they are non-empty
-	if kal.StackKind != "" {
-		labels[labelPortainerAppStackKind] = kal.StackKind
-	}
-
-	return labels
 }
 
 // GetHelmAppLabels returns the labels to be applied to portainer deployed helm applications

api/kubernetes/yaml_test.go

@@ -40,7 +40,6 @@ metadata:
     io.portainer.kubernetes.application.kind: git
     io.portainer.kubernetes.application.name: best-name
     io.portainer.kubernetes.application.owner: best-owner
-    io.portainer.kubernetes.application.owner.id: ""
     io.portainer.kubernetes.application.stack: best-name
     io.portainer.kubernetes.application.stackid: "123"
   name: busybox
@@ -89,7 +88,6 @@ metadata:
     io.portainer.kubernetes.application.kind: git
     io.portainer.kubernetes.application.name: best-name
     io.portainer.kubernetes.application.owner: best-owner
-    io.portainer.kubernetes.application.owner.id: ""
     io.portainer.kubernetes.application.stack: best-name
     io.portainer.kubernetes.application.stackid: "123"
   name: busybox
@@ -179,7 +177,6 @@ items:
         io.portainer.kubernetes.application.kind: git
         io.portainer.kubernetes.application.name: best-name
         io.portainer.kubernetes.application.owner: best-owner
-        io.portainer.kubernetes.application.owner.id: ""
         io.portainer.kubernetes.application.stack: best-name
         io.portainer.kubernetes.application.stackid: "123"
       name: web
@@ -201,7 +198,6 @@ items:
         io.portainer.kubernetes.application.kind: git
         io.portainer.kubernetes.application.name: best-name
         io.portainer.kubernetes.application.owner: best-owner
-        io.portainer.kubernetes.application.owner.id: ""
         io.portainer.kubernetes.application.stack: best-name
         io.portainer.kubernetes.application.stackid: "123"
       name: redis
@@ -225,7 +221,6 @@ items:
         io.portainer.kubernetes.application.kind: git
         io.portainer.kubernetes.application.name: best-name
         io.portainer.kubernetes.application.owner: best-owner
-        io.portainer.kubernetes.application.owner.id: ""
         io.portainer.kubernetes.application.stack: best-name
         io.portainer.kubernetes.application.stackid: "123"
       name: web
@@ -308,7 +303,6 @@ metadata:
     io.portainer.kubernetes.application.kind: git
     io.portainer.kubernetes.application.name: best-name
     io.portainer.kubernetes.application.owner: best-owner
-    io.portainer.kubernetes.application.owner.id: ""
     io.portainer.kubernetes.application.stack: best-name
     io.portainer.kubernetes.application.stackid: "123"
   name: busybox
@@ -335,7 +329,6 @@ metadata:
     io.portainer.kubernetes.application.kind: git
     io.portainer.kubernetes.application.name: best-name
     io.portainer.kubernetes.application.owner: best-owner
-    io.portainer.kubernetes.application.owner.id: ""
     io.portainer.kubernetes.application.stack: best-name
     io.portainer.kubernetes.application.stackid: "123"
   name: web
@@ -355,7 +348,6 @@ metadata:
     io.portainer.kubernetes.application.kind: git
     io.portainer.kubernetes.application.name: best-name
     io.portainer.kubernetes.application.owner: best-owner
-    io.portainer.kubernetes.application.owner.id: ""
     io.portainer.kubernetes.application.stack: best-name
     io.portainer.kubernetes.application.stackid: "123"
   name: busybox
@@ -405,7 +397,6 @@ metadata:
     io.portainer.kubernetes.application.kind: git
     io.portainer.kubernetes.application.name: best-name
     io.portainer.kubernetes.application.owner: best-owner
-    io.portainer.kubernetes.application.owner.id: ""
     io.portainer.kubernetes.application.stack: best-name
     io.portainer.kubernetes.application.stackid: "123"
   name: web
@@ -628,7 +619,6 @@ metadata:
     io.portainer.kubernetes.application.kind: git
     io.portainer.kubernetes.application.name: best-name
     io.portainer.kubernetes.application.owner: best-owner
-    io.portainer.kubernetes.application.owner.id: ""
     io.portainer.kubernetes.application.stack: best-name
     io.portainer.kubernetes.application.stackid: "123"
 ---
@@ -640,7 +630,6 @@ metadata:
     io.portainer.kubernetes.application.kind: git
     io.portainer.kubernetes.application.name: best-name
     io.portainer.kubernetes.application.owner: best-owner
-    io.portainer.kubernetes.application.owner.id: ""
     io.portainer.kubernetes.application.stack: best-name
     io.portainer.kubernetes.application.stackid: "123"
 `

api/portainer.go

@@ -29,8 +29,6 @@ type (
 	AccessPolicy struct {
 		// Role identifier. Reference the role that will be associated to this access policy
 		RoleID RoleID `json:"RoleId" example:"1"`
-		// Namespaces is a list of namespaces that this access policy applies to. Only used for namespaced level roles
-		Namespaces []string `json:"Namespaces,omitempty"`
 	}
 
 	// AgentPlatform represents a platform type for an Agent
@@ -114,7 +112,6 @@ type (
 		AdminPasswordFile         *string
 		Assets                    *string
 		CSP                       *bool
-		CompactDB                 *bool
 		Data                      *string
 		FeatureFlags              *[]string
 		EnableEdgeComputeFeatures *bool
@@ -349,10 +346,6 @@ type (
 		DeploymentType EdgeStackDeploymentType `json:"DeploymentType"`
 		// Uses the manifest's namespaces instead of the default one
 		UseManifestNamespaces bool
-		// The username id which created this stack
-		CreatedByUserId string `example:"1"`
-		// The username which created this stack
-		CreatedBy string `example:"admin"`
 	}
 
 	EdgeStackStatusForEnv struct {
@@ -360,14 +353,6 @@ type (
 		Status     []EdgeStackDeploymentStatus
 		// EE only feature
 		DeploymentInfo StackDeploymentInfo
-		// RePullImage is a flag to indicate whether the auto update is trigger to re-pull image
-		RePullImage bool `json:"RePullImage,omitempty"`
-		// ForceRedeploy is a flag to indicate whether the force redeployment is set for the current
-		// deployment of the edge stack. The redeployment could be triggered by GitOps Update or manually by user.
-		ForceRedeploy bool `json:"ForceRedeploy,omitempty"`
-
-		// Deprecated(2.36): use ForceRedeploy and RePullImage instead for cleaner
-		// responsibility, but keep it for backward compatibility. To remove in future versions (2.44+)
 		// ReadyRePullImage is a flag to indicate whether the auto update is trigger to re-pull image
 		ReadyRePullImage bool `json:"ReadyRePullImage,omitempty"`
 	}
@@ -538,65 +523,6 @@ type (
 		Tags []string `json:"Tags,omitempty"`
 	}
 
-	PolicyChartSummary struct {
-		ChartName   string `json:"ChartName"`
-		Fingerprint string `json:"Fingerprint"`
-	}
-
-	PolicyChartStatus struct {
-		ChartName   string            `json:"chartName"`
-		Fingerprint string            `json:"fingerprint"`
-		Status      HelmInstallStatus `json:"status"`
-		Message     string            `json:"message"`
-		Namespace   string            `json:"namespace"`
-	}
-
-	ImageBundle struct {
-		FileName     string `json:"FileName"`
-		EncodedTarGz string `json:"EncodedTarGz"`
-	}
-
-	PolicyChartBundle struct {
-		PolicyChartSummary
-		EncodedTgz          string             `json:"EncodedTgz"`
-		Namespace           string             `json:"Namespace"`
-		PreReleaseManifest  string             `json:"PreReleaseManifest,omitempty"`
-		EncodedValues       string             `json:"EncodedValues"`
-		PreInstallDeletions []ResourceDeletion `json:"PreInstallDeletions,omitempty"`
-		PreInstallAdoptions []ResourceAdoption `json:"PreInstallAdoptions,omitempty"`
-	}
-
-	// ResourceDeletion identifies an existing Kubernetes resource to delete before policy install
-	ResourceDeletion struct {
-		APIVersion string `json:"apiVersion" example:"v1" yaml:"apiVersion"`
-		Kind       string `json:"kind" example:"Secret" yaml:"kind"`
-		Name       string `json:"name" example:"registry-1" yaml:"name"`
-		Namespace  string `json:"namespace,omitempty" example:"default" yaml:"namespace,omitempty"`
-	}
-
-	// ResourceAdoption identifies an existing Kubernetes resource to adopt into a Helm release
-	ResourceAdoption struct {
-		APIVersion string `json:"apiVersion" example:"v1" yaml:"apiVersion"`
-		Kind       string `json:"kind" example:"Secret" yaml:"kind"`
-		Name       string `json:"name" example:"registry-1" yaml:"name"`
-		Namespace  string `json:"namespace,omitempty" example:"default" yaml:"namespace,omitempty"`
-	}
-
-	// RestoreSettings contains instructions for restoring environment-level settings
-	RestoreSettings struct {
-		Manifest string `json:"manifest"` // Base64-encoded Kubernetes YAML manifest
-	}
-
-	// RestoreSettingsBundle maps restore type to restoration instructions
-	RestoreSettingsBundle map[PolicyType]RestoreSettings
-
-	PolicyID int
-
-	// PolicyType represents the type of policy
-	PolicyType string
-)
-
-type (
 	// EndpointGroupID represents an environment(endpoint) group identifier
 	EndpointGroupID int
 
@@ -927,11 +853,9 @@ type (
 	RegistryAccesses map[EndpointID]RegistryAccessPolicies
 
 	RegistryAccessPolicies struct {
-		// Docker specific fields (with docker, users/teams have access to a registry)
 		UserAccessPolicies UserAccessPolicies `json:"UserAccessPolicies"`
 		TeamAccessPolicies TeamAccessPolicies `json:"TeamAccessPolicies"`
-		// Kubernetes specific fields (with kubernetes, namespaces have access to a registry, if users/teams have access to the same namespace, they have access to the registry)
-		Namespaces []string `json:"Namespaces"`
+		Namespaces         []string           `json:"Namespaces"`
 	}
 
 	// RegistryID represents a registry identifier
@@ -1187,8 +1111,6 @@ type (
 	StackOption struct {
 		// Prune services that are no longer referenced
 		Prune bool `example:"false"`
-		// Enable atomic rollback on failure (Helm --atomic flag for Kubernetes Helm stacks)
-		HelmAtomic bool `example:"false"`
 	}
 
 	// StackID represents a stack identifier (it must be composed of Name + "_" + SwarmID to create a unique identifier)
@@ -1857,7 +1779,7 @@ type (
 
 const (
 	// APIVersion is the version number of the Portainer API
-	APIVersion = "2.37.0"
+	APIVersion = "2.34.0"
 	// Support annotation for the API version ("STS" for Short-Term Support or "LTS" for Long-Term Support)
 	APIVersionSupport = "STS"
 	// Edition is what this edition of Portainer is called
@@ -1922,8 +1844,6 @@ const (
 	TrustedOriginsEnvVar = "TRUSTED_ORIGINS"
 	// CSPEnvVar is the environment variable used to enable/disable the Content Security Policy
 	CSPEnvVar = "CSP"
-	// CompactDBEnvVar is the environment variable used to enable/disable the startup compaction of the database
-	CompactDBEnvVar = "COMPACT_DB"
 )
 
 // List of supported features
@@ -2430,24 +2350,3 @@ const (
 	ContainerEngineDocker = "docker"
 	ContainerEnginePodman = "podman"
 )
-
-const (
-	// PolicyType constants
-	RbacK8s        PolicyType = "rbac-k8s"
-	SecurityK8s    PolicyType = "security-k8s"
-	SetupK8s       PolicyType = "setup-k8s"
-	RegistryK8s    PolicyType = "registry-k8s"
-	RbacDocker     PolicyType = "rbac-docker"
-	SecurityDocker PolicyType = "security-docker"
-	SetupDocker    PolicyType = "setup-docker"
-	RegistryDocker PolicyType = "registry-docker"
-)
-
-type HelmInstallStatus string
-
-const (
-	HelmInstallStatusInstalling   HelmInstallStatus = "installing"
-	HelmInstallStatusInstalled    HelmInstallStatus = "installed"
-	HelmInstallStatusFailed       HelmInstallStatus = "failed"
-	HelmInstallStatusUninstalling HelmInstallStatus = "uninstalling"
-)

api/scheduler/scheduler_test.go

@@ -5,7 +5,6 @@ import (
 	"errors"
 	"sync/atomic"
 	"testing"
-	"testing/synctest"
 	"time"
 
 	"github.com/stretchr/testify/assert"
@@ -19,150 +18,136 @@ func requireNoShutdownErr(t *testing.T, fn func() error) {
 }
 
 func Test_ScheduledJobRuns(t *testing.T) {
-	synctest.Test(t, func(t *testing.T) {
-		s := NewScheduler(t.Context())
-		defer requireNoShutdownErr(t, s.Shutdown)
+	s := NewScheduler(context.Background())
+	defer requireNoShutdownErr(t, s.Shutdown)
 
-		ctx, cancel := context.WithTimeout(t.Context(), 2*jobInterval)
+	ctx, cancel := context.WithTimeout(context.Background(), 2*jobInterval)
 
-		var workDone bool
-		s.StartJobEvery(jobInterval, func() error {
-			workDone = true
+	var workDone bool
+	s.StartJobEvery(jobInterval, func() error {
+		workDone = true
 
-			cancel()
+		cancel()
 
-			return nil
-		})
-
-		<-ctx.Done()
-		assert.True(t, workDone, "value should been set in the job")
+		return nil
 	})
+
+	<-ctx.Done()
+	assert.True(t, workDone, "value should been set in the job")
 }
 
 func Test_JobCanBeStopped(t *testing.T) {
-	synctest.Test(t, func(t *testing.T) {
-		s := NewScheduler(t.Context())
-		defer requireNoShutdownErr(t, s.Shutdown)
+	s := NewScheduler(context.Background())
+	defer requireNoShutdownErr(t, s.Shutdown)
 
-		ctx, cancel := context.WithTimeout(t.Context(), 2*jobInterval)
+	ctx, cancel := context.WithTimeout(context.Background(), 2*jobInterval)
 
-		var workDone bool
-		jobID := s.StartJobEvery(jobInterval, func() error {
-			workDone = true
+	var workDone bool
+	jobID := s.StartJobEvery(jobInterval, func() error {
+		workDone = true
 
-			cancel()
+		cancel()
 
-			return nil
-		})
-
-		err := s.StopJob(jobID)
-		require.NoError(t, err)
-
-		<-ctx.Done()
-		assert.False(t, workDone, "job shouldn't had a chance to run")
+		return nil
 	})
+
+	err := s.StopJob(jobID)
+	require.NoError(t, err)
+
+	<-ctx.Done()
+	assert.False(t, workDone, "job shouldn't had a chance to run")
 }
 
 func Test_JobShouldStop_UponPermError(t *testing.T) {
-	synctest.Test(t, func(t *testing.T) {
-		s := NewScheduler(t.Context())
-		defer requireNoShutdownErr(t, s.Shutdown)
+	s := NewScheduler(context.Background())
+	defer requireNoShutdownErr(t, s.Shutdown)
 
-		var acc int
+	var acc int
 
-		ch := make(chan struct{})
-		s.StartJobEvery(jobInterval, func() error {
-			acc++
-			close(ch)
+	ch := make(chan struct{})
+	s.StartJobEvery(jobInterval, func() error {
+		acc++
+		close(ch)
 
-			return NewPermanentError(errors.New("failed"))
-		})
-
-		<-time.After(3 * jobInterval)
-		<-ch
-		assert.Equal(t, 1, acc, "job stop after the first run because it returns an error")
+		return NewPermanentError(errors.New("failed"))
 	})
+
+	<-time.After(3 * jobInterval)
+	<-ch
+	assert.Equal(t, 1, acc, "job stop after the first run because it returns an error")
 }
 
 func Test_JobShouldNotStop_UponError(t *testing.T) {
-	synctest.Test(t, func(t *testing.T) {
-		s := NewScheduler(t.Context())
-		defer requireNoShutdownErr(t, s.Shutdown)
+	s := NewScheduler(context.Background())
+	defer requireNoShutdownErr(t, s.Shutdown)
 
-		var acc atomic.Int64
+	var acc atomic.Int64
 
-		ch := make(chan struct{})
-		s.StartJobEvery(jobInterval, func() error {
-			if acc.Add(1) == 2 {
-				close(ch)
+	ch := make(chan struct{})
+	s.StartJobEvery(jobInterval, func() error {
+		if acc.Add(1) == 2 {
+			close(ch)
 
-				return NewPermanentError(errors.New("failed"))
-			}
+			return NewPermanentError(errors.New("failed"))
+		}
 
-			return errors.New("non-permanent error")
-		})
-
-		<-time.After(3 * jobInterval)
-		<-ch
-		assert.Equal(t, int64(2), acc.Load())
+		return errors.New("non-permanent error")
 	})
+
+	<-time.After(3 * jobInterval)
+	<-ch
+	assert.Equal(t, int64(2), acc.Load())
 }
 
 func Test_CanTerminateAllJobs_ByShuttingDownScheduler(t *testing.T) {
-	synctest.Test(t, func(t *testing.T) {
-		s := NewScheduler(t.Context())
+	s := NewScheduler(context.Background())
 
-		ctx, cancel := context.WithTimeout(t.Context(), 2*jobInterval)
+	ctx, cancel := context.WithTimeout(context.Background(), 2*jobInterval)
 
-		var workDone bool
-		s.StartJobEvery(jobInterval, func() error {
-			workDone = true
-			cancel()
+	var workDone bool
+	s.StartJobEvery(jobInterval, func() error {
+		workDone = true
+		cancel()
 
-			return nil
-		})
-
-		requireNoShutdownErr(t, s.Shutdown)
-
-		<-ctx.Done()
-		assert.False(t, workDone, "job shouldn't had a chance to run")
+		return nil
 	})
+
+	requireNoShutdownErr(t, s.Shutdown)
+
+	<-ctx.Done()
+	assert.False(t, workDone, "job shouldn't had a chance to run")
 }
 
 func Test_CanTerminateAllJobs_ByCancellingParentContext(t *testing.T) {
-	synctest.Test(t, func(t *testing.T) {
-		ctx, cancel := context.WithTimeout(t.Context(), 2*jobInterval)
-		s := NewScheduler(ctx)
-
-		var workDone bool
-		s.StartJobEvery(jobInterval, func() error {
-			workDone = true
-			cancel()
-
-			return nil
-		})
+	ctx, cancel := context.WithTimeout(context.Background(), 2*jobInterval)
+	s := NewScheduler(ctx)
 
+	var workDone bool
+	s.StartJobEvery(jobInterval, func() error {
+		workDone = true
 		cancel()
 
-		<-ctx.Done()
-		assert.False(t, workDone, "job shouldn't had a chance to run")
+		return nil
 	})
+
+	cancel()
+
+	<-ctx.Done()
+	assert.False(t, workDone, "job shouldn't had a chance to run")
 }
 
 func Test_StartJobEvery_Concurrently(t *testing.T) {
-	synctest.Test(t, func(t *testing.T) {
-		ctx, cancel := context.WithTimeout(context.Background(), 2*jobInterval)
-		s := NewScheduler(ctx)
+	ctx, cancel := context.WithTimeout(context.Background(), 2*jobInterval)
+	s := NewScheduler(ctx)
 
-		f := func() error {
-			return errors.New("error")
-		}
+	f := func() error {
+		return errors.New("error")
+	}
 
-		go s.StartJobEvery(jobInterval, f)
-		s.StartJobEvery(jobInterval, f)
+	go s.StartJobEvery(jobInterval, f)
+	s.StartJobEvery(jobInterval, f)
 
-		cancel()
+	cancel()
 
-		<-ctx.Done()
-	})
+	<-ctx.Done()
 }

api/stacks/deployments/deploy.go

@@ -121,7 +121,7 @@ func redeployWhenChangedSecondStage(
 	var gitCommitChangedOrForceUpdate bool
 
 	if !stack.FromAppTemplate {
-		updated, newHash, err := update.UpdateGitObject(gitService, fmt.Sprintf("stack:%d", stack.ID), stack.GitConfig, false, stack.ProjectPath)
+		updated, newHash, err := update.UpdateGitObject(gitService, fmt.Sprintf("stack:%d", stack.ID), stack.GitConfig, false, false, stack.ProjectPath)
 		if err != nil {
 			return err
 		}
@@ -131,10 +131,6 @@ func redeployWhenChangedSecondStage(
 			stack.UpdateDate = time.Now().Unix()
 			gitCommitChangedOrForceUpdate = updated
 		}
-
-		if stack.AutoUpdate != nil && stack.AutoUpdate.ForceUpdate {
-			gitCommitChangedOrForceUpdate = true
-		}
 	}
 
 	if !gitCommitChangedOrForceUpdate {

api/stacks/deployments/deployer_remote.go

@@ -55,11 +55,12 @@ func (d *stackDeployer) DeployRemoteComposeStack(
 	d.lock.Lock()
 	defer d.lock.Unlock()
 
-	options := portainer.ComposeOptions{Registries: registries}
+	d.swarmStackManager.Login(registries, endpoint)
+	defer d.swarmStackManager.Logout(endpoint)
 
 	// --force-recreate doesn't pull updated images
 	if forcePullImage {
-		if err := d.composeStackManager.Pull(context.TODO(), stack, endpoint, options); err != nil {
+		if err := d.composeStackManager.Pull(context.TODO(), stack, endpoint, portainer.ComposeOptions{}); err != nil {
 			return err
 		}
 	}

api/stacks/deployments/deployment_compose_config.go

@@ -25,19 +25,12 @@ type ComposeStackDeploymentConfig struct {
 }
 
 func CreateComposeStackDeploymentConfig(securityContext *security.RestrictedRequestContext, stack *portainer.Stack, endpoint *portainer.Endpoint, dataStore dataservices.DataStore, fileService portainer.FileService, deployer StackDeployer, forcePullImage, forceCreate bool) (*ComposeStackDeploymentConfig, error) {
-	return CreateComposeStackDeploymentConfigTx(dataStore, securityContext, stack, endpoint, fileService, deployer, forcePullImage, forceCreate)
-}
-
-// Alternate function that works within a transaction
-// We didn't update the original function to use a transaction because it would be a breaking change for many other files.
-// Let's do this only where necessary for now. This is also planed to be refactored in the future, but not prioritized right now.
-func CreateComposeStackDeploymentConfigTx(tx dataservices.DataStoreTx, securityContext *security.RestrictedRequestContext, stack *portainer.Stack, endpoint *portainer.Endpoint, fileService portainer.FileService, deployer StackDeployer, forcePullImage, forceCreate bool) (*ComposeStackDeploymentConfig, error) {
-	user, err := tx.User().Read(securityContext.UserID)
+	user, err := dataStore.User().Read(securityContext.UserID)
 	if err != nil {
 		return nil, fmt.Errorf("unable to load user information from the database: %w", err)
 	}
 
-	registries, err := tx.Registry().ReadAll()
+	registries, err := dataStore.Registry().ReadAll()
 	if err != nil {
 		return nil, fmt.Errorf("unable to retrieve registries from the database: %w", err)
 	}

api/stacks/deployments/deployment_swarm_config.go

@@ -24,19 +24,12 @@ type SwarmStackDeploymentConfig struct {
 }
 
 func CreateSwarmStackDeploymentConfig(securityContext *security.RestrictedRequestContext, stack *portainer.Stack, endpoint *portainer.Endpoint, dataStore dataservices.DataStore, fileService portainer.FileService, deployer StackDeployer, prune bool, pullImage bool) (*SwarmStackDeploymentConfig, error) {
-	return CreateSwarmStackDeploymentConfigTx(dataStore, securityContext, stack, endpoint, fileService, deployer, prune, pullImage)
-}
-
-// Alternate function that works within a transaction
-// We didn't update the original function to use a transaction because it would be a breaking change for many other files.
-// Let's do this only where necessary for now. This is also planed to be refactored in the future, but not prioritized right now.
-func CreateSwarmStackDeploymentConfigTx(tx dataservices.DataStoreTx, securityContext *security.RestrictedRequestContext, stack *portainer.Stack, endpoint *portainer.Endpoint, fileService portainer.FileService, deployer StackDeployer, prune bool, pullImage bool) (*SwarmStackDeploymentConfig, error) {
-	user, err := tx.User().Read(securityContext.UserID)
+	user, err := dataStore.User().Read(securityContext.UserID)
 	if err != nil {
 		return nil, fmt.Errorf("unable to load user information from the database: %w", err)
 	}
 
-	registries, err := tx.Registry().ReadAll()
+	registries, err := dataStore.Registry().ReadAll()
 	if err != nil {
 		return nil, fmt.Errorf("unable to retrieve registries from the database: %w", err)
 	}