Batch of fixes from the automated QA pass on develop. Each was reproduced and then verified fixed live (browser/curl); logic-bearing fixes have unit tests. Functional bugs: - #122 collab-token was capped by the anonymous public-share-AI throttler (5/min); skip all non-AUTH named throttlers on this auth-guarded, client-cached route. - #123 editor onAuthenticationFailed threw `jwtDecode(undefined)` and never reconnected; read the token via a ref, guard the decode (incl. missing exp), and refetch+reconnect on any auth failure. - #124 a slash command containing a space ("/Heading 1") inserted literal text; enable allowSpaces and close the menu when the query matches no items. - #125 space slug auto-gen produced uppercase initials for multi-word names; computeSpaceSlug now yields a lowercase alphanumeric slug. - #126 AI chat window position/size now persisted (atomWithStorage) across reload; also fixes a latent ResizeObserver-attach bug on first open. - #127 workspace name update accepted URLs; add @NoUrls (parity with setup). - #132 icon-columns 4/5 passed calc() into SVG width/height attrs (console spam); size via style. share-for-page query returns null instead of undefined. - #134 "Reindex now" counter looked stuck: reindex runs async; the client now polls coverage (bounded) so the counter climbs live; misleading server comment reworded. UX / consistency: - #128 add success toasts to favorite/label/avatar/member-(de)activate. - #129 "1 result found" pluralization; hide the single-option Type filter. - #130 replace raw Zod strings with friendly messages (name/password/group). - #131 unify "Untitled" casing in tree/breadcrumb/tab; stop force-uppercasing space-name chips; fix confirm-dialog labels (Cancel / Remove), invite placeholder typo, Export/Move-to-space labels. - #133 disable profile Save when clean; toast on unsupported avatar image; style the invalid-invitation page with a CTA; hide Share for read-only users; align the dictation "not configured" message; "Go to login page" typo. Tests: computeSpaceSlug, workspace-name NoUrls DTO, share-query null normalization, slash getSuggestionItems empty-close. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
101 lines
3.2 KiB
TypeScript
101 lines
3.2 KiB
TypeScript
import { useMemo } from "react";
|
|
import {
|
|
useQuery,
|
|
useInfiniteQuery,
|
|
useMutation,
|
|
useQueryClient,
|
|
} from "@tanstack/react-query";
|
|
import {
|
|
addFavorite,
|
|
removeFavorite,
|
|
getFavorites,
|
|
getFavoriteIds,
|
|
ToggleFavoriteParams,
|
|
} from "../services/favorite-service";
|
|
import { FavoriteType } from "../types/favorite.types";
|
|
import { notifications } from "@mantine/notifications";
|
|
import { useTranslation } from "react-i18next";
|
|
|
|
export function useFavoritesQuery(type?: FavoriteType, spaceId?: string) {
|
|
return useInfiniteQuery({
|
|
queryKey: ["favorites", type, spaceId],
|
|
queryFn: ({ pageParam }) =>
|
|
getFavorites({ type, spaceId, cursor: pageParam, limit: 15 }),
|
|
initialPageParam: undefined as string | undefined,
|
|
getNextPageParam: (lastPage) =>
|
|
lastPage.meta.hasNextPage ? lastPage.meta.nextCursor : undefined,
|
|
refetchOnMount: true,
|
|
});
|
|
}
|
|
|
|
export function useFavoriteIds(type: FavoriteType, spaceId?: string): Set<string> {
|
|
const { data } = useQuery({
|
|
queryKey: ["favorite-ids", type, spaceId],
|
|
queryFn: () => getFavoriteIds(type, spaceId),
|
|
refetchOnMount: true,
|
|
});
|
|
|
|
const items = data?.items;
|
|
return useMemo(() => new Set(items ?? []), [items]);
|
|
}
|
|
|
|
function getEntityId(variables: ToggleFavoriteParams): string | undefined {
|
|
if (variables.type === "page") return variables.pageId;
|
|
if (variables.type === "space") return variables.spaceId;
|
|
if (variables.type === "template") return variables.templateId;
|
|
return undefined;
|
|
}
|
|
|
|
export function useAddFavoriteMutation() {
|
|
const queryClient = useQueryClient();
|
|
const { t } = useTranslation();
|
|
|
|
return useMutation<void, Error, ToggleFavoriteParams>({
|
|
mutationFn: (data) => addFavorite(data),
|
|
onSuccess: (_result, variables) => {
|
|
const entityId = getEntityId(variables);
|
|
if (entityId) {
|
|
queryClient.setQueriesData<{ items: string[]; meta: any }>(
|
|
{ queryKey: ["favorite-ids", variables.type] },
|
|
(old) => {
|
|
if (!old) return old;
|
|
if (old.items.includes(entityId)) return old;
|
|
return { ...old, items: [...old.items, entityId] };
|
|
},
|
|
);
|
|
}
|
|
queryClient.invalidateQueries({
|
|
queryKey: ["favorites", variables.type],
|
|
});
|
|
// Notify on success so the action gives visible feedback (issue #128)
|
|
notifications.show({ message: t("Added to favorites") });
|
|
},
|
|
});
|
|
}
|
|
|
|
export function useRemoveFavoriteMutation() {
|
|
const queryClient = useQueryClient();
|
|
const { t } = useTranslation();
|
|
|
|
return useMutation<void, Error, ToggleFavoriteParams>({
|
|
mutationFn: (data) => removeFavorite(data),
|
|
onSuccess: (_result, variables) => {
|
|
const entityId = getEntityId(variables);
|
|
if (entityId) {
|
|
queryClient.setQueriesData<{ items: string[]; meta: any }>(
|
|
{ queryKey: ["favorite-ids", variables.type] },
|
|
(old) => {
|
|
if (!old) return old;
|
|
return { ...old, items: old.items.filter((id) => id !== entityId) };
|
|
},
|
|
);
|
|
}
|
|
queryClient.invalidateQueries({
|
|
queryKey: ["favorites", variables.type],
|
|
});
|
|
// Notify on success so the action gives visible feedback (issue #128)
|
|
notifications.show({ message: t("Removed from favorites") });
|
|
},
|
|
});
|
|
}
|