Batch of fixes from the automated QA pass on develop. Each was reproduced and then verified fixed live (browser/curl); logic-bearing fixes have unit tests. Functional bugs: - #122 collab-token was capped by the anonymous public-share-AI throttler (5/min); skip all non-AUTH named throttlers on this auth-guarded, client-cached route. - #123 editor onAuthenticationFailed threw `jwtDecode(undefined)` and never reconnected; read the token via a ref, guard the decode (incl. missing exp), and refetch+reconnect on any auth failure. - #124 a slash command containing a space ("/Heading 1") inserted literal text; enable allowSpaces and close the menu when the query matches no items. - #125 space slug auto-gen produced uppercase initials for multi-word names; computeSpaceSlug now yields a lowercase alphanumeric slug. - #126 AI chat window position/size now persisted (atomWithStorage) across reload; also fixes a latent ResizeObserver-attach bug on first open. - #127 workspace name update accepted URLs; add @NoUrls (parity with setup). - #132 icon-columns 4/5 passed calc() into SVG width/height attrs (console spam); size via style. share-for-page query returns null instead of undefined. - #134 "Reindex now" counter looked stuck: reindex runs async; the client now polls coverage (bounded) so the counter climbs live; misleading server comment reworded. UX / consistency: - #128 add success toasts to favorite/label/avatar/member-(de)activate. - #129 "1 result found" pluralization; hide the single-option Type filter. - #130 replace raw Zod strings with friendly messages (name/password/group). - #131 unify "Untitled" casing in tree/breadcrumb/tab; stop force-uppercasing space-name chips; fix confirm-dialog labels (Cancel / Remove), invite placeholder typo, Export/Move-to-space labels. - #133 disable profile Save when clean; toast on unsupported avatar image; style the invalid-invitation page with a CTA; hide Share for read-only users; align the dictation "not configured" message; "Go to login page" typo. Tests: computeSpaceSlug, workspace-name NoUrls DTO, share-query null normalization, slash getSuggestionItems empty-close. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
162 lines
4.9 KiB
TypeScript
162 lines
4.9 KiB
TypeScript
import {
|
|
keepPreviousData,
|
|
useInfiniteQuery,
|
|
useMutation,
|
|
useQuery,
|
|
useQueryClient,
|
|
} from "@tanstack/react-query";
|
|
import {
|
|
addLabelsToPage,
|
|
findPagesByLabel,
|
|
getLabelInfo,
|
|
getPageLabels,
|
|
getWorkspaceLabels,
|
|
removeLabelFromPage,
|
|
} from "@/features/label/services/label-service.ts";
|
|
import {
|
|
IAddLabels,
|
|
ILabel,
|
|
IRemoveLabel,
|
|
} from "@/features/label/types/label.types.ts";
|
|
import { IPagination } from "@/lib/types.ts";
|
|
import { notifications } from "@mantine/notifications";
|
|
import { useTranslation } from "react-i18next";
|
|
|
|
const PAGE_LABELS_KEY = (pageId: string) => ["page-labels", pageId];
|
|
const WORKSPACE_LABELS_KEY = (query?: string) => ["workspace-labels", query ?? ""];
|
|
|
|
export function usePageLabelsQuery(pageId: string | undefined) {
|
|
return useQuery({
|
|
queryKey: PAGE_LABELS_KEY(pageId ?? ""),
|
|
queryFn: () => getPageLabels({ pageId: pageId as string, limit: 100 }),
|
|
enabled: !!pageId,
|
|
});
|
|
}
|
|
|
|
export function useWorkspaceLabelsQuery(query: string, enabled: boolean) {
|
|
return useQuery({
|
|
queryKey: WORKSPACE_LABELS_KEY(query),
|
|
queryFn: () => getWorkspaceLabels({ type: "page", query, limit: 50 }),
|
|
enabled,
|
|
staleTime: 30 * 1000,
|
|
});
|
|
}
|
|
|
|
export function useAddLabelsMutation(pageId: string | undefined) {
|
|
const queryClient = useQueryClient();
|
|
const { t } = useTranslation();
|
|
|
|
return useMutation<ILabel[], Error, IAddLabels>({
|
|
mutationFn: (data) => addLabelsToPage(data),
|
|
onSuccess: (added) => {
|
|
queryClient.setQueryData<IPagination<ILabel>>(
|
|
PAGE_LABELS_KEY(pageId ?? ""),
|
|
(cache) => {
|
|
if (!cache) return cache;
|
|
const existing = new Set(cache.items.map((l) => l.id));
|
|
const additions = added.filter((l) => !existing.has(l.id));
|
|
if (additions.length === 0) return cache;
|
|
return { ...cache, items: [...cache.items, ...additions] };
|
|
},
|
|
);
|
|
|
|
queryClient.setQueriesData<IPagination<ILabel>>(
|
|
{ queryKey: ["workspace-labels"] },
|
|
(cache) => {
|
|
if (!cache) return cache;
|
|
const existing = new Set(cache.items.map((l) => l.id));
|
|
const additions = added.filter((l) => !existing.has(l.id));
|
|
if (additions.length === 0) return cache;
|
|
return {
|
|
...cache,
|
|
items: [...cache.items, ...additions].sort((a, b) =>
|
|
a.name.localeCompare(b.name),
|
|
),
|
|
};
|
|
},
|
|
);
|
|
|
|
queryClient.invalidateQueries({ queryKey: ["label-pages"] });
|
|
queryClient.invalidateQueries({ queryKey: ["label-info"] });
|
|
// Notify on success so the action gives visible feedback (issue #128)
|
|
notifications.show({ message: t("Label added") });
|
|
},
|
|
onError: (error: any) => {
|
|
notifications.show({
|
|
message: error?.response?.data?.message ?? t("Failed to add label"),
|
|
color: "red",
|
|
});
|
|
},
|
|
});
|
|
}
|
|
|
|
export function useRemoveLabelMutation(pageId: string | undefined) {
|
|
const queryClient = useQueryClient();
|
|
const { t } = useTranslation();
|
|
|
|
return useMutation<void, Error, IRemoveLabel>({
|
|
mutationFn: (data) => removeLabelFromPage(data),
|
|
onSuccess: (_data, variables) => {
|
|
const cache = queryClient.getQueryData<IPagination<ILabel>>(
|
|
PAGE_LABELS_KEY(pageId ?? ""),
|
|
);
|
|
if (cache) {
|
|
queryClient.setQueryData<IPagination<ILabel>>(
|
|
PAGE_LABELS_KEY(pageId ?? ""),
|
|
{
|
|
...cache,
|
|
items: cache.items.filter((l) => l.id !== variables.labelId),
|
|
},
|
|
);
|
|
}
|
|
queryClient.invalidateQueries({ queryKey: ["workspace-labels"] });
|
|
queryClient.invalidateQueries({ queryKey: ["label-pages"] });
|
|
queryClient.invalidateQueries({ queryKey: ["label-info"] });
|
|
// Notify on success so the action gives visible feedback (issue #128)
|
|
notifications.show({ message: t("Label removed") });
|
|
},
|
|
onError: () => {
|
|
notifications.show({
|
|
message: t("Failed to remove label"),
|
|
color: "red",
|
|
});
|
|
},
|
|
});
|
|
}
|
|
|
|
export function useLabelInfoQuery(name: string, spaceId?: string) {
|
|
return useQuery({
|
|
queryKey: ["label-info", name, spaceId ?? ""],
|
|
queryFn: () => getLabelInfo({ name, type: "page", spaceId }),
|
|
enabled: !!name,
|
|
placeholderData: keepPreviousData,
|
|
});
|
|
}
|
|
|
|
const LABEL_PAGES_LIMIT = 25;
|
|
|
|
export function useLabelPagesQuery(
|
|
name: string,
|
|
query: string,
|
|
spaceId?: string,
|
|
) {
|
|
return useInfiniteQuery({
|
|
queryKey: ["label-pages", name, query, spaceId ?? ""],
|
|
queryFn: ({ pageParam }) =>
|
|
findPagesByLabel({
|
|
name,
|
|
query,
|
|
spaceId,
|
|
cursor: pageParam,
|
|
limit: LABEL_PAGES_LIMIT,
|
|
}),
|
|
enabled: !!name,
|
|
initialPageParam: undefined as string | undefined,
|
|
getNextPageParam: (lastPage) =>
|
|
lastPage.meta.hasNextPage
|
|
? (lastPage.meta.nextCursor ?? undefined)
|
|
: undefined,
|
|
placeholderData: keepPreviousData,
|
|
});
|
|
}
|