c4ed4a4855
Review #6 (approve-with-comments) follow-ups: 1. canonicalize step 7 now strips bare footnoteDefinitions at ANY depth (stripFootnoteDefinitionsDeep), not just footnotesList, in BOTH copies. A definition hand-authored outside a list (e.g. nested in a callout via a raw-JSON write path) was left in place while a copy was also added to the rebuilt list -> duplicate, idempotent, self-perpetuating. Runs only in the rebuild path (after the lists are stripped); the fast-path / placement-keep branch is untouched. Added a shared-corpus case (bare def nested in a callout) to pin it in both mirrors. 2. markdown-clipboard: removed the dead top-level footnoteReference check in canonicalizePastedFootnotes (an inline atom is never a top-level slice child; only the descendants scan can find it). Test coverage: 4. New MCP binding tests (full-doc-write-canonicalize.test.mjs): update_page_json and copy_page_content canonicalize the persisted full doc, asserted via a new `replacePage` seam (symmetric to the existing `mutatePage` seam) so no live collab socket is needed. Routed both writers through the seam. 5. New server spec (file-import-task.service.footnote-canonicalize.spec.ts): the zip-import path (processGenericImport) canonicalizes footnotes — real markdown->HTML->JSON via a real ImportService over a temp-dir .md file, DB trx stubbed to capture the persisted page content. FileImportTaskService had no spec before. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
79 lines
3.1 KiB
JavaScript
79 lines
3.1 KiB
JavaScript
// Footnote-canonicalization binding tests for the MCP FULL-document write tools
|
|
// (issue #228, review #4): update_page_json and copy_page_content must persist a
|
|
// footnote-canonical doc. These override the `replacePage` seam (symmetric to the
|
|
// `mutatePage` seam used by the insert-footnote-wrapper test) to capture the
|
|
// persisted doc WITHOUT a live Hocuspocus collab socket. Symmetric to the
|
|
// server-side focus specs for createPage / updatePageContent('replace').
|
|
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { DocmostClient } from "../../build/client.js";
|
|
|
|
const para = (...c) => ({ type: "paragraph", content: c });
|
|
const ref = (id) => ({ type: "footnoteReference", attrs: { id } });
|
|
const def = (id, text) => ({
|
|
type: "footnoteDefinition",
|
|
attrs: { id },
|
|
content: [{ type: "paragraph", content: [{ type: "text", text }] }],
|
|
});
|
|
const list = (...d) => ({ type: "footnotesList", content: d });
|
|
|
|
function findAll(node, type, acc = []) {
|
|
if (!node || typeof node !== "object") return acc;
|
|
if (node.type === type) acc.push(node);
|
|
if (Array.isArray(node.content)) for (const c of node.content) findAll(c, type, acc);
|
|
return acc;
|
|
}
|
|
const defIds = (doc) => findAll(doc, "footnoteDefinition").map((d) => d.attrs.id);
|
|
|
|
function makeClient(sourceDoc) {
|
|
const calls = { replaced: [] };
|
|
class TestClient extends DocmostClient {
|
|
async ensureAuthenticated() {}
|
|
async getCollabTokenWithReauth() {
|
|
return "collab-token";
|
|
}
|
|
async getPageRaw(pageId) {
|
|
return { id: pageId, slugId: "s", title: "P", spaceId: "sp", content: sourceDoc };
|
|
}
|
|
async replacePage(pageId, doc, token, apiUrl) {
|
|
calls.replaced.push({ pageId, doc });
|
|
return { doc, verify: { ok: true } };
|
|
}
|
|
}
|
|
const client = new TestClient("http://127.0.0.1:1/api", "e@x.com", "pw");
|
|
return { client, calls };
|
|
}
|
|
|
|
test("update_page_json canonicalizes the persisted full doc (out-of-order -> reference order)", async () => {
|
|
const { client, calls } = makeClient();
|
|
const outOfOrder = {
|
|
type: "doc",
|
|
content: [
|
|
para({ type: "text", text: "x" }, ref("b"), ref("a")),
|
|
list(def("a", "A"), def("b", "B")),
|
|
],
|
|
};
|
|
await client.updatePageJson("p1", outOfOrder);
|
|
assert.equal(calls.replaced.length, 1);
|
|
// Definitions reordered to reference order [b, a] before persisting.
|
|
assert.deepEqual(defIds(calls.replaced[0].doc), ["b", "a"]);
|
|
assert.equal(findAll(calls.replaced[0].doc, "footnotesList").length, 1);
|
|
});
|
|
|
|
test("copy_page_content canonicalizes the persisted copy (orphan definition dropped)", async () => {
|
|
const sourceDoc = {
|
|
type: "doc",
|
|
content: [
|
|
para({ type: "text", text: "x" }, ref("a")),
|
|
list(def("a", "A"), def("orphan", "O")),
|
|
],
|
|
};
|
|
const { client, calls } = makeClient(sourceDoc);
|
|
const res = await client.copyPageContent("src", "dst");
|
|
assert.equal(calls.replaced.length, 1);
|
|
assert.equal(calls.replaced[0].pageId, "dst");
|
|
// The orphan definition is dropped by canonicalization before the copy lands.
|
|
assert.deepEqual(defIds(calls.replaced[0].doc), ["a"]);
|
|
assert.equal(res.success, true);
|
|
});
|