feat(ai-chat): сообщать агенту о правках пользователя между ходами (per-turn diff) #281

Open

agent_coder wants to merge 3 commits from feat/274-ai-chat-page-diff into develop

Author	SHA1	Message	Date
agent_coder	2f3d5d3783	docs: fix escapeAttr comment count (three, not four) (#274 review) The regex strips three attribute-breaking chars (" < >); the JSDoc said four. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-02 06:19:26 +03:00
agent_coder	6e681a9c66	fix(#274 ): escape page_changed injection surface, drop dead content_hash (review F1-F5) F1: escape the collaborative page title before interpolating into <page_changed page="..."> (and the pre-existing openedPage attr) — strip <>" and collapse whitespace, so a crafted title can't break out of the attribute into the system prompt (cross-user injection). F2: neutralize <page_changed>/</page_changed> occurrences inside the diff body so a crafted line can't close the block early. F3: remove the dead content_hash column (written every turn, never read) — migration, repo, service hashing + crypto import, db.d.ts, spec asserts. F4: test the best-effort catch branches (detectPageChange / snapshotOpenPage swallow errors and don't break the turn). F5: soften the overstated 'diff cannot smuggle instructions' comment to defense-in-depth framing referencing the F1/F2 mitigations + safety sandwich. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-02 05:43:46 +03:00
agent_coder	8c5b57ebfa	feat(ai-chat): notify the agent of user page edits between turns (closes #274 ) The agent rebuilds context from DB each turn and didn't know the user manually edited the open page since its last response, so it could overwrite those edits. Add a per-turn ephemeral <page_changed> note in the system prompt (twin of INTERRUPT_NOTE, self-clearing) carrying a unified Markdown diff of what changed since the END of the agent's previous turn. - New ai_chat_page_snapshots table (migration + hand-declared db.d.ts/entity types) storing the page Markdown per (chat,page) at each turn's end. - Pure computePageChange util (whitespace-normalized unified diff via the existing jsdiff dep, 6KB cap + getPage hint). - Turn start: if the open page's updatedAt moved past the snapshot, diff current vs snapshot; non-empty -> PAGE_CHANGED_NOTE in the safety sandwich. - Turn end: upsert the snapshot on EVERY terminal path (onFinish/onError/onAbort, once) so the agent's own edits are excluded by construction even on aborted turns. All best-effort (never breaks/latency-regresses a turn); fast path when updatedAt is unchanged. Server-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-02 01:54:00 +03:00

Author

SHA1

Message

Date

agent_coder

2f3d5d3783

docs: fix escapeAttr comment count (three, not four) (#274 review)

The regex strips three attribute-breaking chars (" < >); the JSDoc said four.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-02 06:19:26 +03:00

agent_coder

6e681a9c66

fix(#274 ): escape page_changed injection surface, drop dead content_hash (review F1-F5)

F1: escape the collaborative page title before interpolating into
    <page_changed page="..."> (and the pre-existing openedPage attr) — strip
    <>" and collapse whitespace, so a crafted title can't break out of the
    attribute into the system prompt (cross-user injection).
F2: neutralize <page_changed>/</page_changed> occurrences inside the diff body
    so a crafted line can't close the block early.
F3: remove the dead content_hash column (written every turn, never read) —
    migration, repo, service hashing + crypto import, db.d.ts, spec asserts.
F4: test the best-effort catch branches (detectPageChange / snapshotOpenPage
    swallow errors and don't break the turn).
F5: soften the overstated 'diff cannot smuggle instructions' comment to
    defense-in-depth framing referencing the F1/F2 mitigations + safety sandwich.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-02 05:43:46 +03:00

agent_coder

8c5b57ebfa

feat(ai-chat): notify the agent of user page edits between turns (closes #274 )

The agent rebuilds context from DB each turn and didn't know the user manually
edited the open page since its last response, so it could overwrite those edits.
Add a per-turn ephemeral <page_changed> note in the system prompt (twin of
INTERRUPT_NOTE, self-clearing) carrying a unified Markdown diff of what changed
since the END of the agent's previous turn.

- New ai_chat_page_snapshots table (migration + hand-declared db.d.ts/entity
  types) storing the page Markdown per (chat,page) at each turn's end.
- Pure computePageChange util (whitespace-normalized unified diff via the
  existing jsdiff dep, 6KB cap + getPage hint).
- Turn start: if the open page's updatedAt moved past the snapshot, diff current
  vs snapshot; non-empty -> PAGE_CHANGED_NOTE in the safety sandwich.
- Turn end: upsert the snapshot on EVERY terminal path (onFinish/onError/onAbort,
  once) so the agent's own edits are excluded by construction even on aborted
  turns.
All best-effort (never breaks/latency-regresses a turn); fast path when updatedAt
is unchanged. Server-only.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-02 01:54:00 +03:00

feat(ai-chat): сообщать агенту о правках пользователя между ходами (per-turn diff) #281

3 Commits