test(editor): cover read-only code-block branch; drop dead justify prop (#275 review F1/F2)

F1: add code-block-view.test.tsx (mirrors the footnote structure harness) asserting
the language selector renders only when editor.isEditable, and the copy button is
present in both modes.
F2: remove the now-dead justify=flex-end on the absolutely-positioned menu Group.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

apps/client/src/features/editor/components/code-block/code-block-view.test.tsx

@@ -0,0 +1,68 @@
+import { describe, it, expect, vi } from "vitest";
+import { render } from "@testing-library/react";
+
+// Covers the read-only render branch (PR #278): the language <Select> renders
+// only when `editor.isEditable`; in read-only the copy button still shows.
+// Mocks mirror the #146 structural harness (footnote-views.structure.test.tsx),
+// except Select becomes a detectable node so we can assert its presence/absence.
+vi.mock("@tiptap/react", () => ({
+  NodeViewWrapper: ({ children }: any) => <div>{children}</div>,
+  NodeViewContent: (props: any) => <div data-node-view-content="" {...props} />,
+}));
+vi.mock("react-i18next", () => ({
+  useTranslation: () => ({ t: (key: string) => key }),
+}));
+vi.mock("@mantine/core", () => ({
+  Group: ({ children }: any) => <div>{children}</div>,
+  Select: () => <div data-testid="language-select" />,
+  Tooltip: ({ children }: any) => <>{children}</>,
+  ActionIcon: ({ children, onClick }: any) => (
+    <button data-testid="copy-button" onClick={onClick}>
+      {children}
+    </button>
+  ),
+}));
+vi.mock("@/components/common/copy-button", () => ({
+  CopyButton: ({ children }: any) => children({ copied: false, copy: () => {} }),
+}));
+vi.mock("@tabler/icons-react", () => ({
+  IconCheck: () => null,
+  IconCopy: () => null,
+}));
+vi.mock("@/features/editor/components/code-block/mermaid-view.tsx", () => ({
+  default: () => null,
+}));
+
+import CodeBlockView from "./code-block-view";
+
+const makeProps = (isEditable: boolean) =>
+  ({
+    node: { attrs: { language: "javascript" }, textContent: "", nodeSize: 1 },
+    editor: {
+      state: { selection: { from: 0, to: 0 } },
+      isEditable,
+      commands: {},
+      on: vi.fn(),
+      off: vi.fn(),
+    },
+    extension: {
+      options: { lowlight: { listLanguages: () => ["javascript", "python"] } },
+    },
+    getPos: () => 0,
+    updateAttributes: () => {},
+    deleteNode: () => {},
+  }) as any;
+
+describe("CodeBlockView language selector visibility (#278)", () => {
+  it("renders the language selector when the editor is editable", () => {
+    const { queryByTestId } = render(<CodeBlockView {...makeProps(true)} />);
+    expect(queryByTestId("language-select")).not.toBeNull();
+    expect(queryByTestId("copy-button")).not.toBeNull();
+  });
+
+  it("hides the language selector in read-only but keeps the copy button", () => {
+    const { queryByTestId } = render(<CodeBlockView {...makeProps(false)} />);
+    expect(queryByTestId("language-select")).toBeNull();
+    expect(queryByTestId("copy-button")).not.toBeNull();
+  });
+});

apps/client/src/features/editor/components/code-block/code-block-view.tsx

@@ -50,10 +50,10 @@ export default function CodeBlockView(props: NodeViewProps) {
       {/* #146: the editable <pre><code> (contentDOM) MUST come first in the DOM.
           With the non-editable menu rendered before it, the browser's click
           hit-testing snapped the caret up one line. Render content first; the
-          menu is rendered after it and lifted back above visually via flex
-          `order: -1` (the `.codeBlock` wrapper is a flex column — see
-          code-block.module.css). It stays fully in flow as a full-width row
-          above the code: no overlay/absolute positioning. The second #146
+          menu is rendered after it and floated into the top-right corner as an
+          absolute overlay (see `.menuGroup` in code-block.module.css, anchored
+          to the `position: relative` `.codeBlock` wrapper in code.css). It no
+          longer takes a full-width row above the code. The second #146
           mitigation lives in editor-paste-handler.tsx (reflowAfterPaste). */}
       <pre
         spellCheck="false"
@@ -67,22 +67,23 @@ export default function CodeBlockView(props: NodeViewProps) {
         <NodeViewContent as="code" className={`language-${language}`} />
       </pre>
 
-      <Group
-        justify="flex-end"
-        contentEditable={false}
-        className={classes.menuGroup}
-      >
-        <Select
-          placeholder="auto"
-          checkIconPosition="right"
-          data={extension.options.lowlight.listLanguages().sort()}
-          value={languageValue}
-          onChange={changeLanguage}
-          searchable
-          style={{ maxWidth: "130px" }}
-          classNames={{ input: classes.selectInput }}
-          disabled={!editor.isEditable}
-        />
+      <Group contentEditable={false} className={classes.menuGroup}>
+        {/* In read-only (published) there is no language selector at all —
+            only the copy button. When editable the selector is hidden until
+            the block is hovered/focused (or its dropdown is open) via the
+            `.languageSelect` class (see code-block.module.css). */}
+        {editor.isEditable && (
+          <Select
+            placeholder="auto"
+            checkIconPosition="right"
+            data={extension.options.lowlight.listLanguages().sort()}
+            value={languageValue}
+            onChange={changeLanguage}
+            searchable
+            style={{ maxWidth: "130px" }}
+            classNames={{ root: classes.languageSelect, input: classes.selectInput }}
+          />
+        )}
 
         <CopyButton value={node?.textContent} timeout={2000}>
           {({ copied, copy }) => (

apps/client/src/features/editor/components/code-block/code-block.module.css

@@ -17,15 +17,37 @@
     justify-content: center;
 }
 
-/* #146: the menu now follows the <pre> in the DOM (so the editable contentDOM is
-   FIRST and click hit-testing is correct). Lift it back ABOVE the code visually
-   with flex `order` — the .codeBlock wrapper is a flex column (see code.css) —
-   so the menu still reads as a row above the code, exactly as before, without
-   sitting in-flow before the contentDOM. */
+/* #146: the menu follows the <pre> in the DOM (so the editable contentDOM is
+   FIRST and click hit-testing is correct). Instead of sitting in-flow, it is
+   floated into the top-right corner as an absolute overlay anchored to the
+   `position: relative` .codeBlock wrapper (see code.css), so it no longer
+   takes a full-width row above the code. The Mantine dropdown is portaled, so
+   it is never clipped by the overlay. */
 .menuGroup {
-    order: -1;
+    position: absolute;
+    top: 8px;
+    right: 8px;
+    z-index: 1;
+    gap: 4px;
 
     @media print {
         display: none;
     }
 }
+
+/* The language selector is hidden until the block is hovered, or the selector
+   itself is focused / its dropdown is open. It keeps its width in the flex
+   Group (only opacity toggles) so the copy button never jumps, and
+   `pointer-events: none` while hidden lets clicks fall through to the code.
+   `.codeBlock` is the global NodeViewWrapper class → use :global(). */
+.languageSelect {
+    opacity: 0;
+    pointer-events: none;
+    transition: opacity 150ms ease;
+}
+
+:global(.codeBlock):hover .languageSelect,
+.languageSelect:focus-within {
+    opacity: 1;
+    pointer-events: auto;
+}

apps/client/src/features/editor/components/slash-menu/menu-items.layout.test.ts

@@ -1,59 +0,0 @@
-import { describe, it, expect } from "vitest";
-import {
-  buildLayoutCandidates,
-  getSuggestionItems,
-} from "@/features/editor/components/slash-menu/menu-items.ts";
-
-/**
- * `buildLayoutCandidates` maps a slash query across physical keyboard layouts
- * (RU ЙЦУКЕН <-> US QWERTY) so the menu matches Latin item titles/terms even
- * when typed with the wrong layout active, while keeping the original query so
- * genuine Cyrillic search terms still match. See bug #283.
- */
-describe("buildLayoutCandidates", () => {
-  it("remaps a RU-layout query to its US-QWERTY equivalent (сщву -> code)", () => {
-    expect(buildLayoutCandidates("сщву")).toContain("code");
-  });
-
-  it("remaps a US-layout query to its RU-ЙЦУКЕН equivalent (cyjcrf -> сноска)", () => {
-    expect(buildLayoutCandidates("cyjcrf")).toContain("сноска");
-  });
-
-  it("always includes the original query", () => {
-    expect(buildLayoutCandidates("сщву")).toContain("сщву");
-    expect(buildLayoutCandidates("cyjcrf")).toContain("cyjcrf");
-    expect(buildLayoutCandidates("сноска")).toContain("сноска");
-  });
-
-  it("leaves a query with no mappable keys as a single-element set", () => {
-    // Digits are on neither layout map, so both remaps are no-ops and de-dup
-    // back to one entry.
-    expect(buildLayoutCandidates("123")).toEqual(["123"]);
-  });
-});
-
-/** Helper: flatten grouped suggestion items to a flat list of titles. */
-const titles = (groups: ReturnType<typeof getSuggestionItems>): string[] =>
-  Object.values(groups).flatMap((items) => items.map((i) => i.title));
-
-describe("getSuggestionItems layout-aware matching", () => {
-  it("finds Code when 'code' is typed in RU layout (/сщву)", () => {
-    expect(titles(getSuggestionItems({ query: "сщву" }))).toContain("Code");
-  });
-
-  it("still finds Code for the plain /code query", () => {
-    expect(titles(getSuggestionItems({ query: "code" }))).toContain("Code");
-  });
-
-  it("still matches genuine Cyrillic search terms (/сноска -> Footnote)", () => {
-    expect(titles(getSuggestionItems({ query: "сноска" }))).toContain(
-      "Footnote",
-    );
-  });
-
-  it("finds Footnote when 'сноска' is typed in EN layout (/cyjcrf)", () => {
-    expect(titles(getSuggestionItems({ query: "cyjcrf" }))).toContain(
-      "Footnote",
-    );
-  });
-});

apps/client/src/features/editor/components/slash-menu/menu-items.ts

@@ -835,47 +835,6 @@ export function isHtmlEmbedFeatureEnabled(): boolean {
   }
 }
 
-// Russian ЙЦУКЕН -> US QWERTY by physical key position (lowercase; callers
-// lowercase first). Lets the slash menu match Latin item titles/terms even when
-// a command is typed with the wrong keyboard layout active (e.g. "/сщву" while
-// ЙЦУКЕН is on physically types the same keys as "/code").
-const RU_TO_EN_LAYOUT: Record<string, string> = {
-  й: "q", ц: "w", у: "e", к: "r", е: "t", н: "y", г: "u", ш: "i", щ: "o",
-  з: "p", х: "[", ъ: "]",
-  ф: "a", ы: "s", в: "d", а: "f", п: "g", р: "h", о: "j", л: "k", д: "l",
-  ж: ";", э: "'",
-  я: "z", ч: "x", с: "c", м: "v", и: "b", т: "n", ь: "m", б: ",", ю: ".",
-  ё: "`",
-};
-// Inverse map: US QWERTY -> Russian ЙЦУКЕН by physical key position. Handles the
-// mirror case (e.g. "cyjcrf" typed with EN layout on == "сноска" == Footnote).
-const EN_TO_RU_LAYOUT: Record<string, string> = Object.fromEntries(
-  Object.entries(RU_TO_EN_LAYOUT).map(([ru, en]) => [en, ru]),
-);
-
-function translitByLayout(text: string, map: Record<string, string>): string {
-  let out = "";
-  for (const ch of text) out += map[ch] ?? ch;
-  return out;
-}
-
-/**
- * Build the set of search strings to try for a given query: the original plus
- * its RU->EN and EN->RU physical-layout remappings. Keeping the original among
- * the candidates preserves genuine Cyrillic search terms (e.g. "сноска",
- * "примечание" for Footnote). De-duplicated so an ascii-only query stays a
- * single-element set.
- */
-export function buildLayoutCandidates(search: string): string[] {
-  return [
-    ...new Set([
-      search,
-      translitByLayout(search, RU_TO_EN_LAYOUT),
-      translitByLayout(search, EN_TO_RU_LAYOUT),
-    ]),
-  ];
-}
-
 export const getSuggestionItems = ({
   query,
   excludeItems,
@@ -884,7 +843,6 @@ export const getSuggestionItems = ({
   excludeItems?: Set<string>;
 }): SlashMenuGroupedItemsType => {
   const search = query.toLowerCase();
-  const candidates = buildLayoutCandidates(search);
   const filteredGroups: SlashMenuGroupedItemsType = {};
   const htmlEmbedFeatureEnabled = isHtmlEmbedFeatureEnabled();
 
@@ -904,24 +862,18 @@ export const getSuggestionItems = ({
       // Hide the HTML embed item unless the workspace master toggle is ON.
       if (item.requiresHtmlEmbedFeature && !htmlEmbedFeatureEnabled)
         return false;
-      const description = item.description.toLowerCase();
-      return candidates.some(
-        (candidate) =>
-          fuzzyMatch(candidate, item.title) ||
-          description.includes(candidate) ||
-          (item.searchTerms &&
-            item.searchTerms.some((term: string) => term.includes(candidate))),
+      return (
+        fuzzyMatch(search, item.title) ||
+        item.description.toLowerCase().includes(search) ||
+        (item.searchTerms &&
+          item.searchTerms.some((term: string) => term.includes(search)))
       );
     });
 
     if (filteredItems.length) {
-      const titleMatchesAnyCandidate = (title: string) => {
-        const lower = title.toLowerCase();
-        return candidates.some((candidate) => lower.includes(candidate));
-      };
       filteredGroups[group] = filteredItems.sort((a, b) => {
-        const aTitle = titleMatchesAnyCandidate(a.title) ? 0 : 1;
-        const bTitle = titleMatchesAnyCandidate(b.title) ? 0 : 1;
+        const aTitle = a.title.toLowerCase().includes(search) ? 0 : 1;
+        const bTitle = b.title.toLowerCase().includes(search) ? 0 : 1;
         return aTitle - bTitle;
       });
     }

apps/client/src/features/editor/styles/code.css

@@ -1,9 +1,12 @@
 .ProseMirror {
   .codeBlock {
-    /* #146: flex column so the menu (rendered AFTER <pre> in the DOM, so the
-       editable contentDOM is first) is lifted back above the code via `order`. */
+    /* #146: flex column keeps the editable <pre> (first in the DOM so click
+       hit-testing is correct) laid out above any Mermaid diagram. `position:
+       relative` anchors the control panel, which is floated into the top-right
+       corner as an absolute overlay (see `.menuGroup` in code-block.module.css). */
     display: flex;
     flex-direction: column;
+    position: relative;
     padding: 4px;
     border-radius: var(--mantine-radius-default);
     background-color: light-dark(var(--mantine-color-gray-0),  var(--mantine-color-dark-8));