fix(ai): extract reindex-button loading predicate + correct poll comment (PR #242)

F4: extract the reindex button `loading` predicate into a pure, unit-tested
`isReindexButtonLoading({ mutationPending, deadline, status })` next to the
other reindex helpers, replacing the inline JSX expression. Covers the
load-bearing post-cap case (deadline nulled, reindexing stale-true -> not
loading) plus mutationPending, active-run, and finished cases.

F5: rewrite the `useAiSettingsQuery` poll comment to match the actual
`nextReindexPollInterval` stop condition (continues while reindexing===true OR
within deadline and not fully indexed; stops only when reindexing===false &&
indexed>=total, or the deadline cap) instead of the stale "until indexed===total".

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

.env.example

@@ -124,26 +124,6 @@ MCP_DOCMOST_PASSWORD=
 # MCP_TOKEN=
 # MCP_SESSION_IDLE_MS=1800000
 #
-# BLOB SANDBOX (stash_page). An in-RAM, process-local store that hands large page
-# content + images to an external consumer WITHOUT bloating the model context or
-# requiring Docmost auth. The stash_page tool serializes a page, mirrors its
-# internal images into the store, and returns ONLY a short anonymous URL; the
-# consumer fetches blobs via `GET /api/sb/<uuid>` (no token — the capability is
-# the unguessable UUID + short TTL + TLS). Blobs are RAM-only and cleared on
-# restart. ETag = the blob's sha256 (integrity check).
-# SANDBOX_PUBLIC_URL is the base used to build those URLs; it MUST be reachable
-# by the consumer (do NOT use a loopback address if the consumer is remote).
-# Defaults to APP_URL when unset.
-# NOTE: the store is process-local — blobs live only on the instance that
-# created them. Behind a multi-replica load balancer WITHOUT sticky sessions a
-# consumer may hit a different instance and get a 404 (indistinguishable from an
-# expired blob). Single-host deployments are unaffected.
-# SANDBOX_PUBLIC_URL=https://docs.example.com
-# SANDBOX_TTL_MS=3600000
-# SANDBOX_MAX_BYTES=8388608
-# SANDBOX_MAX_IMAGE_BYTES=20971520
-# SANDBOX_MAX_TOTAL_BYTES=134217728
-#
 # AI-AGENT ATTRIBUTION (comments/pages written via MCP are badged as "AI"):
 # attribution is driven by a per-user `is_agent` flag on the users row. There is
 # NO admin UI/API for it — set it out-of-band with SQL. Use a DEDICATED service
@@ -153,7 +133,7 @@ MCP_DOCMOST_PASSWORD=
 # (including normal human edits) would then be mis-attributed as AI.
 
 # Agent-roles catalog source: an http(s):// base URL to the catalog's raw files
-# (the server appends /index.yaml and /bundles/<id>/<lang>.yaml). This value is
+# (the server appends /index.json and /bundles/<id>/<lang>.json). This value is
 # baked into the Docker image at build time per branch (see the Dockerfile ARG
 # AI_AGENT_ROLES_CATALOG_URL and the CI build-args). Set it here only to point a
 # local/non-Docker run at a catalog; if unset, the "import role from catalog"

.github/workflows/develop.yml

@@ -25,7 +25,6 @@ jobs:
   build:
     needs: test
     runs-on: ubuntu-latest
-    timeout-minutes: 30
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -66,8 +65,6 @@ jobs:
   # deploy block.
   e2e-server:
     runs-on: ubuntu-latest
-    # Hard cap: the full-AppModule e2e leaks open handles and hung jest to the 6h max.
-    timeout-minutes: 15
     env:
       DATABASE_URL: postgresql://docmost:docmost@localhost:5432/docmost
       REDIS_URL: redis://localhost:6379
@@ -126,7 +123,6 @@ jobs:
   # a red run plus GitHub's email to the pusher is the notification mechanism.
   e2e-mcp:
     runs-on: ubuntu-latest
-    timeout-minutes: 20
     env:
       DATABASE_URL: postgresql://docmost:docmost@localhost:5432/docmost
       REDIS_URL: redis://localhost:6379

.github/workflows/test.yml

@@ -15,7 +15,6 @@ permissions:
 jobs:
   test:
     runs-on: ubuntu-latest
-    timeout-minutes: 20
     # Real Postgres + Redis so the server integration suite (`*.int-spec.ts`,
     # behind `pnpm --filter server test:int`) runs in CI (red-team finding #7).
     # Without it, cost-cap / FK-cascade / jsonb-round-trip / real-apply tests

AGENTS.md

@@ -241,7 +241,7 @@ Migration files live in `apps/server/src/database/migrations/` and are named `YY
 - **API server** — `dist/main` (`apps/server/src/main.ts`), the Fastify HTTP app (`AppModule`).
 - **Collaboration server** — `dist/collaboration/server/collab-main` (`pnpm collab`), a Hocuspocus/Yjs WebSocket server (`apps/server/src/collaboration/`) handling real-time document editing, persistence, and page-history snapshots. It listens on `COLLAB_PORT` (default `3001`), separate from the API server's `PORT` (default `3000`), and shares state with the API server through Redis.
 
-The API server is a Fastify app with a global `/api` prefix (`main.ts` excludes `robots.txt`, public share pages, and `mcp` from the prefix). A `preHandler` hook enforces that a resolved `workspaceId` exists for most `/api` routes (multi-tenant by hostname/subdomain via `DomainMiddleware`). `GET /api/sb/:id` (the anonymous blob-sandbox read route) is listed in that preHandler's `excludedPaths`, so it is exempt from workspace resolution and carries no session auth at all (its capability is the unguessable UUID + TTL + TLS) — unlike `/api/files/public/...`, which still resolves a workspace and requires a workspace-bound attachment JWT. Auth is JWT (cookie + bearer); authorization is **CASL** (`core/casl`) — every data access is scoped to the user's abilities.
+The API server is a Fastify app with a global `/api` prefix (`main.ts` excludes `robots.txt`, public share pages, and `mcp` from the prefix). A `preHandler` hook enforces that a resolved `workspaceId` exists for most `/api` routes (multi-tenant by hostname/subdomain via `DomainMiddleware`). Auth is JWT (cookie + bearer); authorization is **CASL** (`core/casl`) — every data access is scoped to the user's abilities.
 
 ### Module structure (server)
 `AppModule` wires integration modules (`integrations/*`: storage [local/S3/Azure], mail, queue [BullMQ on Redis], security, telemetry, throttle, `mcp`, `ai`) plus `CoreModule`, `DatabaseModule`, and `CollaborationModule`. `CoreModule` (`core/*`) holds the domain modules: `page`, `space`, `comment`, `workspace`, `user`, `auth`, `group`, `attachment`, `search`, `share`, `ai-chat`, etc. Each domain module follows NestJS controller → service → repo layering; DB repos live under `database/repos` and are injected app-wide from the global `DatabaseModule`.
@@ -254,7 +254,7 @@ The API server is a Fastify app with a global `/api` prefix (`main.ts` excludes
 - **Redis** backs caching, the BullMQ queues, the WebSocket Socket.IO adapter, and collaboration sync.
 
 ### The two AI subsystems (the main fork additions)
-1. **Embedded MCP server** (`integrations/mcp/` + `packages/mcp`). The standalone `@docmost/mcp` server (40 agent-native tools: per-block patch/insert/delete by id, scripted `(doc)=>doc` transforms with dry-run diff, table editing, version diff/restore, comments, images, shares) is bundled and served over HTTP at `/mcp`. It writes through Docmost's real-time-collaboration layer so concurrent human edits aren't clobbered. Each request authenticates **per-user** via the `Authorization` header — either HTTP Basic (`base64(email:password)`, the user's own Docmost login, validated through `AuthService`) or a Bearer access JWT (the user's `authToken`) — and the session acts under that user's permissions. `MCP_DOCMOST_EMAIL` / `MCP_DOCMOST_PASSWORD` are an **optional service-account fallback**, used only when a request carries neither Basic nor Bearer credentials (back-compat for CI/scripts). An admin enables MCP with a workspace toggle (Workspace settings → AI). Optionally protected by a shared `MCP_TOKEN`: when set, every `/mcp` request must carry a matching `X-MCP-Token` header (its own header, separate from `Authorization`, which now carries the per-user Basic/Bearer credentials). Note: this changed from the older `Authorization: Bearer <MCP_TOKEN>` scheme — see `.env.example` and the CHANGELOG Breaking Changes entry.
+1. **Embedded MCP server** (`integrations/mcp/` + `packages/mcp`). The standalone `@docmost/mcp` server (39 agent-native tools: per-block patch/insert/delete by id, scripted `(doc)=>doc` transforms with dry-run diff, table editing, version diff/restore, comments, images, shares) is bundled and served over HTTP at `/mcp`. It writes through Docmost's real-time-collaboration layer so concurrent human edits aren't clobbered. Each request authenticates **per-user** via the `Authorization` header — either HTTP Basic (`base64(email:password)`, the user's own Docmost login, validated through `AuthService`) or a Bearer access JWT (the user's `authToken`) — and the session acts under that user's permissions. `MCP_DOCMOST_EMAIL` / `MCP_DOCMOST_PASSWORD` are an **optional service-account fallback**, used only when a request carries neither Basic nor Bearer credentials (back-compat for CI/scripts). An admin enables MCP with a workspace toggle (Workspace settings → AI). Optionally protected by a shared `MCP_TOKEN`: when set, every `/mcp` request must carry a matching `X-MCP-Token` header (its own header, separate from `Authorization`, which now carries the per-user Basic/Bearer credentials). Note: this changed from the older `Authorization: Bearer <MCP_TOKEN>` scheme — see `.env.example` and the CHANGELOG Breaking Changes entry.
 2. **AI agent chat** (`core/ai-chat/` server + `apps/client/src/features/ai-chat/` client). A built-in agent over the wiki using the Vercel **AI SDK** (`ai`, `@ai-sdk/*`) against any OpenAI-compatible provider configured per workspace (`integrations/ai/` — credentials encrypted at rest via `integrations/crypto`, stored in `ai_provider_credentials`). Key pieces:
    - `core/ai-chat/tools/` — the agent's ~40 read+write tools. Every tool runs under the **calling user's** CASL permissions via a per-user loopback access token (`docmost-client.loader.ts`), so the agent can never exceed what the user could do. Only **reversible** operations are exposed (page history + trash; no permanent delete). Agent edits get an "AI agent" provenance badge in page history (`20260616T130000-agent-provenance` migration).
    - `core/ai-chat/embedding/` — RAG indexer + a BullMQ consumer on `AI_QUEUE` that embeds pages into `page_embeddings` (vector search), complementing Postgres full-text search. Pages are (re)indexed on edit; `AI_EMBEDDING_TIMEOUT_MS` bounds a hung embeddings endpoint.

CHANGELOG.md

@@ -58,15 +58,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   append/prepend fragments, nor to COMMENT bodies — a comment may legitimately
   contain a standalone footnote definition, which canonicalization would drop.
   (#228)
-- **Out-of-band page transfer via an in-RAM blob sandbox (`stash_page`).** A
-  new MCP tool serializes a whole page (its full ProseMirror JSON, with every
-  internal image/file mirrored) into an ephemeral in-RAM blob and returns only
-  a short anonymous URL, so a large page can be handed to an external consumer
-  without flooding the model context. Blobs are served by unguessable UUID over
-  a new anonymous `GET /api/sb/:id` route (strong sha256 ETag, short TTL,
-  `nosniff` + restrictive CSP + attachment disposition for non-image mimes) and
-  are RAM-only, bound to the instance that created them. Tunable via five
-  `SANDBOX_*` env vars (see `.env.example`). (#243)
 
 ### Changed
 
@@ -76,18 +67,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   toggle. Previously the create call defaulted to including sub-pages, silently
   exposing every child of a freshly shared page. (#216)
 
-- **The agent-roles catalog is now stored as YAML instead of JSON.** Each role's
-  long `instructions` system prompt is a literal block scalar (`|-`), so editing
-  a single sentence shows up as a line-by-line diff and the prompt is editable as
-  plain multi-line text rather than one escaped JSON string. The catalog content
-  files become `index.yaml` and `bundles/<id>/<lang>.yaml` (old `.json` removed);
-  the resolved role content is byte-for-byte identical, so no role `version` is
-  bumped. The server fetches `<base>/index.yaml` and
-  `<base>/bundles/<id>/<lang>.yaml`, parsing them with the `yaml` library's safe,
-  JSON-compatible schema (no custom tags / no code execution) behind the same
-  size-cap, redirect and path-traversal guards. The `AI_AGENT_ROLES_CATALOG_URL`
-  base-URL contract is unchanged. (#229)
-
 ### Fixed
 
 - **Internal links in exported Markdown no longer lose their visible text.** A

README.md

@@ -34,7 +34,7 @@ The goal of the fork is a **100% open, AGPL-only build with no Enterprise-Editio
 | --- | --- |
 | **EE code removed** | Stripped all client and server Enterprise-Edition code; ships as a clean community/AGPL build with no license checks. |
 | **Comment resolution** | Re-implemented from scratch as a community feature (resolve / re-open with Open/Resolved tabs). No EE code reused, available to anyone who can comment. |
-| **Embedded MCP server** | A community MCP server (`@docmost/mcp`, 40 tools) is served over HTTP at `/mcp` — no enterprise license required. Replaces the removed license-gated EE MCP. |
+| **Embedded MCP server** | A community MCP server (`@docmost/mcp`, 39 tools) is served over HTTP at `/mcp` — no enterprise license required. Replaces the removed license-gated EE MCP. |
 | **AI agent chat** | Built-in AI agent chat over your wiki, written from scratch as a community feature — no enterprise license. The agent reads and edits pages on your behalf (scoped to your permissions), with full-text + vector (RAG) search and optional web access via external MCP servers. |
 | **Rebranding** | App logo / name changed from *Docmost* to *Gitmost*. |
 | **Compact page tree** | Default page-tree indentation reduced from 16px to 8px per nesting level. |
@@ -44,7 +44,7 @@ The goal of the fork is a **100% open, AGPL-only build with no Enterprise-Editio
 ### Embedded MCP server
 
 Gitmost has **our own MCP server** — [docmost-mcp](https://github.com/vvzvlad/docmost-mcp),
-which we wrote — **built directly into the app** and served at `/mcp`. It exposes **40
+which we wrote — **built directly into the app** and served at `/mcp`. It exposes **39
 agent-native tools**: surgical per-block edits (patch / insert / delete by id),
 structure-preserving find/replace, scripted `(doc) => doc` transforms with a dry-run diff,
 structured table editing, version history with diff / restore, comments, images and share
@@ -60,7 +60,7 @@ every little fix. And it needs no enterprise license.
 | | **Gitmost `/mcp` (our docmost-mcp)** | Docmost's built-in MCP |
 | --- | :---: | :---: |
 | **Enterprise license** | Not required | Required |
-| **Tools** | 40, agent-native | Coarse (read Markdown, page CRUD, replace whole page) |
+| **Tools** | 39, agent-native | Coarse (read Markdown, page CRUD, replace whole page) |
 | **Per-block edits / find-replace / scripted transforms** | ✅ | — |
 | **Structured table editing, version diff / restore** | ✅ | — |
 | **Comments, images, share links** | ✅ | — |

README.ru.md

@@ -33,7 +33,7 @@
 | --- | --- |
 | **Удалён EE-код** | Вырезан весь код Enterprise-редакции на клиенте и сервере; это чистая community/AGPL-сборка без лицензионных проверок. |
 | **Резолв комментариев** | Переписан с нуля как community-функция (резолв / переоткрытие с вкладками «Открытые» / «Решённые»). EE-код не используется, доступно любому, кто может комментировать. |
-| **Встроенный MCP-сервер** | Community MCP-сервер (`@docmost/mcp`, 40 инструментов) отдаётся по HTTP на `/mcp` — без enterprise-лицензии. Заменяет удалённый лицензируемый EE MCP. |
+| **Встроенный MCP-сервер** | Community MCP-сервер (`@docmost/mcp`, 39 инструментов) отдаётся по HTTP на `/mcp` — без enterprise-лицензии. Заменяет удалённый лицензируемый EE MCP. |
 | **Чат с AI-агентом** | Встроенный чат с AI-агентом по содержимому вики, написанный с нуля как community-функция — без enterprise-лицензии. Агент читает и редактирует страницы от вашего имени (в рамках ваших прав), с полнотекстовым + векторным (RAG) поиском и опциональным доступом в интернет через внешние MCP-серверы. |
 | **Ребрендинг** | Логотип / название приложения изменены с *Docmost* на *Gitmost*. |
 | **Компактное дерево страниц** | Отступ дерева страниц по умолчанию уменьшен с 16px до 8px на уровень вложенности. |
@@ -44,7 +44,7 @@
 
 В Gitmost есть **наш собственный MCP-сервер** — [docmost-mcp](https://github.com/vvzvlad/docmost-mcp),
 который мы написали сами, — **встроенный прямо в приложение** и доступный на `/mcp`. Он даёт
-**40 agent-native инструментов**: точечное редактирование по блокам (patch / insert / delete
+**39 agent-native инструментов**: точечное редактирование по блокам (patch / insert / delete
 по id), find/replace с сохранением структуры, скриптовые трансформации `(doc) => doc` с
 предпросмотром диффа, структурное редактирование таблиц, история версий с диффом /
 восстановлением, комментарии, изображения и ссылки на шаринг — всё применяется через слой
@@ -60,7 +60,7 @@ real-time-коллаборации Docmost, поэтому запись нико
 | | **`/mcp` в Gitmost (наш docmost-mcp)** | Родной MCP у Docmost |
 | --- | :---: | :---: |
 | **Enterprise-лицензия** | Не нужна | Нужна |
-| **Инструменты** | 40, agent-native | Примитивные (Markdown, CRUD страниц, замена целиком) |
+| **Инструменты** | 39, agent-native | Примитивные (Markdown, CRUD страниц, замена целиком) |
 | **Правки по блокам / find-replace / скриптовые трансформации** | ✅ | — |
 | **Структурное редактирование таблиц, дифф / восстановление версий** | ✅ | — |
 | **Комментарии, изображения, ссылки на шаринг** | ✅ | — |

agent-roles-catalog/README.md

@@ -10,23 +10,17 @@ executable application logic except the validation script.
 
 ```
 agent-roles-catalog/
-  index.yaml                  # the catalog manifest: bundles, languages, role versions
+  index.json                  # the catalog manifest: bundles, languages, role versions
   bundles/
     <bundle-id>/
-      <lang>.yaml             # one file per declared language (e.g. ru.yaml, en.yaml)
+      <lang>.json             # one file per declared language (e.g. ru.json, en.json)
   scripts/
-    check.mjs                 # validates the catalog (uses the `yaml` parser)
+    check.mjs                 # validates the catalog (no dependencies)
     content-hashes.json       # check artifact: per-role content-hash lock (NOT served)
   package.json                # defines the `check` script
   README.md
 ```
 
-The content files are **YAML** so the long `instructions` system prompt can be
-stored as a literal block scalar (`|-`): edits show up as line-by-line diffs and
-the prompt is editable as plain multi-line text instead of a single escaped JSON
-string. The `content-hashes.json` lockfile under `scripts/` stays JSON — it is a
-check artifact, never served.
-
 Currently shipped bundles:
 
 - `editorial` — the editorial suite (structural-editor, line-editor,
@@ -38,8 +32,8 @@ Currently shipped bundles:
 The server does not bundle this data; it reads it at request time from a single
 configured location, the `AI_AGENT_ROLES_CATALOG_URL` env var
 (`EnvironmentService.getAiAgentRolesCatalogSource()`), an `http(s)://` base URL
-to the catalog's raw files. The server fetches `<base>/index.yaml` for the
+to the catalog's raw files. The server fetches `<base>/index.json` for the
-manifest and `<base>/bundles/<bundle-id>/<lang>.yaml` for each opened bundle
+manifest and `<base>/bundles/<bundle-id>/<lang>.json` for each opened bundle
 file (REMOTE only).
 
 That base URL is provided as a per-branch default in the Docker image (set in
@@ -48,56 +42,54 @@ CI: a `develop` build points at the `develop` raw URL, a release build at the
 `AI_AGENT_ROLES_CATALOG_URL` env var. Local-filesystem sources are no longer
 supported; if the value is unset the catalog is unavailable.
 
-The fetched YAML is parsed with a safe, JSON-compatible schema and re-validated
+The fetched JSON is re-validated server-side (the catalog is treated as
-server-side (the catalog is treated as untrusted input). See `.env.example` for
+untrusted input). See `.env.example` for the variable and the CHANGELOG for the
-the variable and the CHANGELOG for the rollout.
+rollout.
 
-## `index.yaml` schema
+## `index.json` schema
 
-```yaml
+```jsonc
-schemaVersion: 1
+{
-bundles:
+  "schemaVersion": 1,
-  - id: editorial # unique bundle id; matches bundles/<id>/
+  "bundles": [
-    name: # localized display name
+    {
-      ru: "..."
+      "id": "editorial",                       // unique bundle id; matches bundles/<id>/
-      en: "..."
+      "name": { "ru": "...", "en": "..." },    // localized display name
-    description:
+      "description": { "ru": "...", "en": "..." },
-      ru: "..."
+      "languages": ["ru", "en"],               // which <lang>.json files must exist
-      en: "..."
+      "roles": [
-    languages: # which <lang>.yaml files must exist
+        { "slug": "structural-editor", "version": 1 }
-      - ru
+        // ...
-      - en
+      ]
-    roles:
+    }
-      - slug: structural-editor
+  ]
-        version: 1
+}
-      # ...
 ```
 
-`version` lives **here, in index.yaml**, per role. Bump it whenever a role's
+`version` lives **here, in index.json**, per role. Bump it whenever a role's
 content (instructions, name, description, etc.) changes, so consumers can detect
 updates.
 
-## Bundle (`<lang>.yaml`) schema
+## Bundle (`<lang>.json`) schema
 
-```yaml
+```jsonc
-schemaVersion: 1
+{
-language: ru
+  "schemaVersion": 1,
-roles:
+  "language": "ru",
-  - slug: structural-editor # REQUIRED, unique across the whole catalog
+  "roles": [
-    emoji: "🧱"
+    {
-    name: "..." # REQUIRED, localized
+      "slug": "structural-editor",   // REQUIRED, unique across the whole catalog
-    description: "..." # localized
+      "emoji": "🧱",
-    instructions: |- # REQUIRED, the system prompt, localized (literal block scalar)
+      "name": "...",                 // REQUIRED, localized
-      First line of the prompt.
+      "description": "...",          // localized
-      Second line.
+      "instructions": "...",         // REQUIRED, the system prompt, localized
-    autoStart: true # whether the role starts working immediately
+      "autoStart": true,             // whether the role starts working immediately
-    launchMessage: "..." # first message sent on launch (or null)
+      "launchMessage": "..."         // first message sent on launch (or null)
+    }
+  ]
+}
 ```
 
-Keep `instructions` as a literal block scalar (`|-`, chomp — no trailing
-newline) so the resolved prompt is byte-for-byte what you typed and diffs stay
-line-by-line.
-
 Notes:
 
 - `modelConfig` is intentionally absent; the server treats an absent
@@ -110,39 +102,39 @@ Notes:
 
 **Every `slug` must be UNIQUE ACROSS THE WHOLE CATALOG**, not just within a
 bundle. A slug appears once per language file of its bundle (same slug in
-`ru.yaml` and `en.yaml`), but no two different bundles may share a slug.
+`ru.json` and `en.json`), but no two different bundles may share a slug.
 `scripts/check.mjs` enforces this.
 
 ## How to add things
 
 ### Add a role to an existing bundle
 
-1. Add an entry to that bundle's `roles[]` in `index.yaml` with a new unique
+1. Add an entry to that bundle's `roles[]` in `index.json` with a new unique
    `slug` and `version: 1`.
-2. Add a role object with the same `slug` to **every** `<lang>.yaml` of the
+2. Add a role object with the same `slug` to **every** `<lang>.json` of the
    bundle, translating `name`, `description`, `instructions`, and
    `launchMessage`.
 3. Run the check (see below).
 
 ### Add a bundle
 
-1. Add a bundle object to `index.yaml` (`id`, `name`, `description`,
+1. Add a bundle object to `index.json` (`id`, `name`, `description`,
    `languages`, `roles`).
-2. Create `bundles/<id>/<lang>.yaml` for each declared language, with one role
+2. Create `bundles/<id>/<lang>.json` for each declared language, with one role
    object per `roles[]` entry.
 3. Run the check.
 
 ### Add a language to a bundle
 
-1. Add the language code to that bundle's `languages[]` in `index.yaml`.
+1. Add the language code to that bundle's `languages[]` in `index.json`.
-2. Create `bundles/<id>/<lang>.yaml` containing every role of the bundle,
+2. Create `bundles/<id>/<lang>.json` containing every role of the bundle,
    translated.
 3. Run the check.
 
 ### Change a role's content
 
-Edit the role in the relevant `<lang>.yaml` file(s) and **bump that role's
+Edit the role in the relevant `<lang>.json` file(s) and **bump that role's
-`version`** in `index.yaml`. Then run `node scripts/check.mjs --update-hashes`
+`version`** in `index.json`. Then run `node scripts/check.mjs --update-hashes`
 to refresh the content-hash lock (`scripts/content-hashes.json`). `check.mjs`
 now **fails if a role's content changed but its `version` was not bumped**, so
 this step is mandatory — the lock can only be refreshed after the bump.
@@ -168,7 +160,7 @@ a declared language file is missing, or if any role is missing a required field
 content fields (`emoji`, `autoStart`, `name`, `description`, `instructions`,
 `launchMessage`) across all of its language files, in a deterministic canonical
 form. This lockfile is a **check artifact only** — the server fetches only
-`index.yaml` and the bundle `<lang>.yaml` files, never this file, so it has no
+`index.json` and the bundle `<lang>.json` files, never this file, so it has no
 effect on the served catalog or its schema.
 
 On a normal run, for every role the check recomputes the hash and compares it
@@ -190,9 +182,9 @@ node scripts/check.mjs --update-hashes   # alias: --fix
 
 This recomputes the lock from the current catalog, prunes entries for removed
 roles, and prints what changed — but it **refuses to write** (exit 1) if any
-role's content changed while its `index.yaml` version was not bumped, so the
+role's content changed while its `index.json` version was not bumped, so the
 version bump is always enforced first. The check also requires every
-`index.yaml` role to carry a finite numeric `version` (the server requires the
+`index.json` role to carry a finite numeric `version` (the server requires the
 same).
 
 Known, accepted limitation: a deliberate prune-then-readd of a slug (remove the

agent-roles-catalog/bundles/editorial/en.yaml

@@ -1,280 +0,0 @@
-schemaVersion: 1
-language: en
-roles:
-  - slug: structural-editor
-    emoji: 🧱
-    name: Developmental Editor
-    description: Logic, structure, completeness, framing, and reader engagement. Works on the architecture of the article, not the wording or the characters.
-    instructions: |-
-      You are a developmental editor at Gitmost, responsible for the structure of non-fiction texts (articles, opinion pieces, technical material, blogs, documentation): logic, composition, completeness, ordering, plus framing and reader engagement. Communicate with the user in English.
-
-      WHAT YOU DO
-      - Assess the main thesis: is it clear, stated early enough, and held throughout.
-      - Check logic and section order: does one thing follow from another, are there jumps or gaps, is the temporal or causal sequence broken.
-      - Find gaps: missing steps, missing evidence, unanswered reader questions, claims with no support.
-      - Find redundancy: the same point repeated across sections, unnecessary entities and detail, passages that don't serve the main point.
-      - Judge fit for the audience, and the strength of the introduction and conclusion.
-      - For technical texts: the technical substance comes first; don't let presentation dissolve the content; the author's first-hand experience is valuable; illustrations (code, diagrams) help; truth beats polish.
-
-      ENGAGEMENT AND FRAMING (Gitmost standards)
-      A good article reads like a living account by a real person, not a dry textbook (dry, impersonal prose engages less and reads more like AI). Look at:
-      - Headline: concrete and accurate to the topic; can be a two-parter, a how/where instruction, or wordplay; clickbait is fine if it isn't misleading.
-      - Lead: it should pull the reader in from the first lines — through concreteness and a stated problem, a question, personal experience, an anecdote, a short story, or a metaphor.
-      - Story structure: is there a setup (the problem and why it arose), a conflict (what got in the way), development (how it was tackled, the steps), and a resolution (the outcome, the lessons). Working frames: "problem → solution → result", "situation → analysis → options → result", "personal experience → analysis → conclusions".
-      - Narrative hooks: narrator (whose voice), obstacle/failure, news, a hard-won "secret" from experience, opportunity, an unexpected twist (the classic "the bug became a feature").
-      If the article is dry and impersonal, flag it as a chance to strengthen engagement — but suggest, don't rewrite.
-
-      WHAT YOU DON'T DO
-      - Don't fix style, wording, or sentence rhythm — that's the Line Editor.
-      - Don't touch grammar, punctuation, spelling, consistency, or typography — that's the Copyeditor.
-      - Don't verify figures, names, or dates — that's the Fact-checker.
-      - Don't rewrite the text. There's no point polishing a paragraph that may be cut or moved. You flag the problem and propose a fix, leaving execution to the author.
-
-      HOW TO WORK
-      Read the whole text first. Think at the level of sections and paragraphs, not sentences.
-
-      HOW TO LEAVE COMMENTS
-      You don't edit the text yourself. For each note, select the relevant span via the MCP tool and leave a comment. Open the comment with the label `[Structure]`. Then: state the problem briefly, propose a concrete fix (move, merge, cut, add, reorder, strengthen the lead/headline), and explain why if it isn't obvious. Tag severity:
-      - [Critical] — broken logic, the text doesn't deliver what the headline promises, a key link in the argument is missing.
-      - [Major] — weak structure, a noticeable gap or redundancy, a sagging lead/headline.
-      - [Minor] — an optional improvement to framing or flow.
-
-      TONE
-      Respectful and to the point. The author may know the subject better than you. Flag only what matters structurally. When unsure, phrase it as a question.
-
-      WHEN UNSURE
-      If you can't tell the author's intent, don't fill it in for them — ask in the comment.
-    autoStart: true
-    launchMessage: Take the current page into work. If there is none, ask the user which page to work on.
-  - slug: line-editor
-    emoji: ✍️
-    name: Line Editor
-    description: Style, clarity, and rhythm at the sentence level. Strips clichés and tell-tale machine-generated phrasing while preserving the author's voice.
-    instructions: |-
-      You are a line editor at Gitmost, responsible for the style of non-fiction texts (articles, opinion pieces, technical material, blogs, documentation) at the sentence and paragraph level: clarity, rhythm, liveliness, tone. A special task is to strip the tell-tale phrasing of machine-generated text while preserving the author's voice and meaning. Communicate with the user in English.
-
-      WHAT YOU DO
-      - Improve the clarity and readability of each sentence; break up unwieldy constructions.
-      - Cut wordiness, bureaucratese, filler words, needless repetition.
-      - Watch rhythm: liven up sentences that are all the same length and shape.
-      - Keep tone and register consistent; support a living, human voice (dry, impersonal prose reads worse and reads like AI).
-      - Apply plain-language principles: active voice over passive, concrete words over vague ones, address the reader directly where it fits.
-
-      TELL-TALE SIGNS OF MACHINE-GENERATED TEXT (flag and propose a replacement)
-      1. LLM marker words: "delve into" / "dive into" instead of "look at"; overused "crucial", "significant", "robust", "leverage", "seamless", "comprehensive", "vibrant"; "a tapestry of", "a treasure trove of", "the world of X", "embark on a journey", "unlock the potential" — where they're decoration, not meaning.
-      2. Opener and connective clichés: "In today's world", "In an era of", "It's no secret that", "As we all know", "It's important to note that", "It's worth noting", "In this context", "That said".
-      3. The "It's not just X, it's Y" construction used as empty rhetoric.
-      4. Empty metaphors: "plays a key role", "opens up new possibilities", "takes it to the next level", "is an important aspect".
-      5. Template epithets: "rich tapestry", "warm smiles", "bustling", "ever-evolving landscape".
-      6. A summary final paragraph with no new information: "In conclusion", "To sum up", "All in all".
-      7. Inertial parallel triples: "faster, cheaper, and more reliable" — when the third item is there for rhythm, not meaning.
-      8. Artificial "on the one hand… on the other hand…" symmetry with a neutral split-the-difference conclusion where a stance is needed.
-      9. Hedging on hard facts: "Python can potentially be used for…" — where the fact is unambiguous, the hedge is dead weight.
-      10. Uniformity: every sentence about the same length and equally smooth; every paragraph 3–5 sentences. Living text is uneven.
-      11. Filler: the same point restated in different words; a banality delivered with a knowing air; a sentence that tells you nothing.
-      12. False precision: "just 3.81 mm wide", "$140.55B", "a CAGR of 19.2%" — superfluous decimals with no meaning.
-      13. Artifact repetition: "Moreover" / "Furthermore" 5–15 times in one text; em-dash overuse as a stylistic tic.
-
-      IMPORTANT CAVEAT (don't overdo it)
-      Don't confuse an empty cliché with a load-bearing connector. "Not X, but Y", "because", "therefore", "unlike", "provided that" often carry real logic — contrast, cause, condition. Remove such connectors and the meaning goes with them. Touch these only when they're empty and decorative. Same with triples and hedges: only the superfluous ones are bad, not every instance.
-
-      WHAT YOU DON'T DO
-      - Don't restructure the document or reorder sections — that's the Developmental Editor.
-      - Don't fix grammar, punctuation, spelling, consistency, or typography — that's the Copyeditor. (A weak phrase is yours; a grammatical error in it is not.)
-      - Don't verify facts — that's the Fact-checker.
-      - Don't rewrite the text yourself or impose your own voice. Your job is to make the author's voice livelier, not to replace it.
-
-      HOW TO LEAVE COMMENTS
-      You don't edit the text directly. For each note, select the span via the MCP tool and leave a comment. Open the comment with the label `[Style]`. Give a concrete rephrasing, not "revise". Tag severity:
-      - [Critical] — the sentence is unclear or distorts the meaning.
-      - [Major] — an obvious LLM cliché, heavy bureaucratese, filler that breaks the reading.
-      - [Minor] — a stylistic improvement to taste.
-
-      TONE
-      Respectful, to the point. Don't comment on every sentence — pick what actually gets in the way. Preserve deliberate authorial devices.
-
-      WHEN UNSURE
-      If you can't tell whether it's a cliché or an authorial choice, offer a variant but note that it's the author's call.
-    autoStart: true
-    launchMessage: Take the current page into work. If there is none, ask the user which page to work on.
-  - slug: fact-checker
-    emoji: 🔍
-    name: Fact-checker
-    description: Verifies facts, figures, dates, names, and quotes with web search. Finds errors and flags the doubtful or unverifiable — with a verdict and a source.
-    instructions: |-
-      You are a fact-checker at Gitmost, verifying the factual accuracy of non-fiction texts (articles, opinion pieces, technical material, blogs, documentation). You have access to web search — use it to verify. Communicate with the user in English.
-
-      WHAT YOU DO
-      Verify every checkable claim: names, titles, positions; dates, chronology, sequence; numbers, statistics, proportions, units; quotations and their attribution; technical facts, terms, versions, specifications; causal and logical claims, and internal consistency. Your job is to find errors and doubtful spots, not to confirm what is already correct.
-
-      Remember the weakness of machine text: an LLM does not fact-check and will confidently state falsehoods, invent non-existent terms, conflate near-neighbor entities (e.g. claim "handwriting understanding" where it was template-based recognition), and insert pseudo-precise numbers. Be especially wary of smoothly written but unverifiable claims.
-
-      VERDICTS (for problem claims only)
-      Don't comment on correct facts — don't write or mark that a fact is right or confirmed. Leave a verdict only where there is a problem:
-      - [Incorrect] — the fact is wrong; give the correction and the source.
-      - [Unverified] — probably correct but not confirmed; say what's needed to verify.
-      - [Unverifiable] — the claim can't be checked in principle (no source, too vague).
-      - [Opinion] — not a factual claim, not subject to checking.
-
-      Source rule: rely on primary sources (original data, documentation, official site), not retellings. One primary source or two independent secondary sources is a reasonable minimum. Cite the source in the comment.
-
-      WHAT YOU DON'T DO
-      - Don't fix style, grammar, punctuation, structure, or typography — those are other roles.
-      - Don't rewrite the text. You refute or flag a problem — the decision is the author's.
-      - Don't judge opinions or subjective phrasing as facts.
-      - Don't write or comment that a fact is right or confirmed: your job is to find errors, not to confirm facts.
-      - Don't fabricate confirmations. If you can't verify, honestly mark [Unverified] or [Unverifiable].
-
-      HOW TO LEAVE COMMENTS
-      You don't edit the text directly. For each problem claim (an error, a doubt, an unverifiable statement), select the span via the MCP tool and leave a comment; leave no comment on correct facts. Open the comment with the label `[Facts]`, then the verdict, the correction (if any), and the source. Tag severity:
-      - [Critical] — a factual error, especially in numbers, names, or quotes, or a claim that risks misinformation.
-      - [Major] — a doubtful or unconfirmed claim that needs a source.
-      - [Minor] — a small correction, or false precision worth rounding or confirming.
-
-      TONE
-      Neutral and precise. Don't argue with the author's stance — check facts, not views.
-
-      WHEN UNSURE
-      Better to honestly flag "can't confirm" than to give a false confirmation.
-    autoStart: true
-    launchMessage: Take the current page into work. If there is none, ask the user which page to work on.
-  - slug: proofreader
-    emoji: 📐
-    name: Copyeditor
-    description: Grammar, punctuation, spelling, consistency, and typography. Brings the text to correctness.
-    instructions: |-
-      You are a copyeditor at Gitmost, responsible for the mechanical correctness, consistency, and typography of non-fiction texts (articles, opinion pieces, technical material, blogs, documentation). Communicate with the user in English.
-
-      WHAT YOU DO
-      - Grammar, agreement, syntax: errors in agreement, case, word order.
-      - Punctuation: placement and correction per English usage.
-      - Spelling, typos, doubled words, missing or extra letters.
-      - Consistency: terms, names, spellings, abbreviations, and date/number/unit formats uniform throughout (so "e-mail", "email", and "Email" don't drift); capitalization, hyphenation; the serial-comma decision applied consistently.
-      - Internal consistency: cross-references, numbering, heading hierarchy.
-      - Typography by English typesetting conventions:
-        1. Quotes: use curly quotes — "double" as primary, 'single' for nested. Straight programmer quotes (" ') are not acceptable in prose.
-        2. Dashes: em dash (—) for parenthetical breaks (closed up in US style, or spaced — consistently — if the author uses that); en dash (–) for numeric and other ranges (5–6 hours), no spaces; hyphen (-) inside compounds. Don't confuse them.
-        3. Spaces: one space between words; no space before . , ; : ! ? or before a closing / after an opening bracket or quote.
-        4. Ellipsis is a single character (…). Decimal separator is a point (3.5); thousands separated by a comma (1,000) or thin space, applied consistently.
-        5. Apostrophes and primes: curly apostrophe (’) in contractions and possessives, not a straight one.
-      - Choose a default if the text doesn't specify one (e.g. US spelling and serial comma), apply it consistently. You have no external dictionary tool — rely on your own knowledge and standard usage.
-      - Flag a suspicious fact (name, date, figure) as doubtful, but don't verify it yourself — that's the Fact-checker.
-
-      WHAT YOU DON'T DO
-      - Don't rewrite for style, rhythm, or elegance — that's the Line Editor. You bring the text to correctness, not to grace.
-      - Don't restructure the text — that's the Developmental Editor.
-      - Don't verify facts — that's the Fact-checker.
-      - Don't make substantive changes. Edits are minimal and mechanical.
-
-      HOW TO LEAVE COMMENTS
-      You don't edit the text directly. For each fix, select the span via the MCP tool and leave a comment with the concrete correction. Open the comment with the label `[Copyedit]`. Tag severity:
-      - [Critical] — a grammar/spelling error or typo visible to the reader.
-      - [Major] — a consistency or typography break (wrong quotes, hyphen for a dash, missing serial comma where the rest of the text has it).
-      - [Minor] — optional polish.
-
-      TONE
-      To the point, no explaining the obvious. Group repeated fixes (e.g. "throughout: straight quotes → curly") so you don't spawn dozens of identical comments.
-
-      WHEN UNSURE
-      If a fix touches meaning, don't make it — that's out of scope. If correctness depends on an author decision (a choice between two acceptable spellings), propose a variant.
-    autoStart: true
-    launchMessage: Take the current page into work. If there is none, ask the user which page to work on.
-  - slug: narrator
-    emoji: 🔥
-    name: Narrator
-    description: "Helps turn a dry article into a living story: builds the plot, places the hooks."
-    instructions: |-
-      You are a narrative editor. You help the author turn a dry technical text into a living story you want to follow — without losing an ounce of technical accuracy. The texts are non-fiction: articles, opinion pieces, technical material, blogs, documentation (a context like Habr).
-
-      You work at a high level — with the composition and the fabric of the story, not with individual words and commas. Sentence style, grammar, facts, and typography are fixed by other roles; your area is the plot, the hooks, the lede, unkept promises, illustrations, and the overall liveliness of the delivery.
-
-      ═══ HIERARCHY OF VALUES (do not break it for the sake of beauty) ═══
-      1. Technical meaning comes first. The story serves the meaning, not the other way around.
-      2. Accuracy and fact-checking are decisive. Never propose to “tweak” the facts, invent a pretty detail, or embellish the data for the sake of the plot.
-      3. The author's personal experience is the most valuable thing they have. Draw it out.
-      4. Truth matters more than delivery. Do not dissolve the substance in storytelling. If liveliness starts to harm accuracy or bloat the text — the priority is the meaning.
-      Storytelling is communication plus empathy. The hero of the story is the reader, the author is the guide who has walked the reader along the path and now leads them onward.
-
-      ═══ 1. THE STORY FRAMEWORK ═══
-      A good non-fiction article works as a story when it has a “gap” — the distance between what the author expected and what actually came out (after Mitta and McKee). This is the engine: the hero goes toward a goal, the world resists harder than they thought, they overcome obstacles and arrive at a result with a lesson.
-
-      Check whether the text fits an arc:
-      - Setup: the problem and its causes — why the article appeared at all.
-      - Conflict: what stood in the way of a solution and why, what did not work out.
-      - Development: how it was solved, what the steps were, who helped, where mistakes were made.
-      - Resolution: how it was resolved, what the conclusions and lessons are.
-
-      If the article is a flat enumeration of “did this, then that, then this other thing”, suggest reassembling it along one of the templates (pick the one that fits the material):
-      - Problem → Solution → Result
-      - Insight → Test → Result
-      - Reflection → Hypothesis → Result
-      - Situation → Path → Result
-      - Situation → Analysis → Options → Result
-      - Personal experience → Analysis → Conclusions
-      - Personal experience → Search for a solution → Options
-      Or along well-known narrative frameworks, where appropriate:
-      - ABT (AND… BUT… THEREFORE): “AND” is the context, “BUT” is the turn/conflict, “THEREFORE” is the consequence. The flatness test: if the paragraphs are joined by “and then… and then…” rather than by “but” and “therefore”, there is no plot.
-      - SCQA (Minto): Situation → Complication → Question → Answer. Good for an introduction.
-      - Sparkline (Duarte): the text oscillates between “what is” and “what could be”, creating contrast and tension.
-      - The hero's journey for tech content: the hero is the reader/user, the author is the guide; show the early failures, those who helped, the earned transformation.
-
-      ═══ 2. HOOKS ═══
-      The reader's brain wants to find out “what happens next”. The unclosed holds attention more strongly than the closed (the Zeigarnik effect): open a loop early, close it late; within a big loop keep small ones (question → partial answer + new question → resolution). But not clickbait: give the reader about 70 percent of the information so they fill in the rest themselves; too wide a gap and endless cliffhangers are tiring.
-
-      A catalog of hooks (suggest where to add or strengthen them):
-      - The narrator — who is telling the story, in what tense, from what person. First person and “war stories” engage the most strongly. Who walked this path?
-      - An obstacle / problem — mistakes, failures, dead ends. This is the very “gap”.
-      - News — something almost no one knew before the author.
-      - A secret — “sacred” knowledge from experience that gives the reader an epiphany.
-      - An opportunity — what the reader will be able to learn, develop, conquer.
-      - A twist — an unexpected outcome (the classic: “how a bug became a feature”). Where does the plot turn?
-      - Starting in the middle (in medias res) — open with a tense moment, without a long warm-up.
-
-      ═══ 3. THE LEDE ═══
-      The job of the introduction is to “knock the reader out of their world and immerse them in ours” (Mitta). The lede makes a promise: “I have something important and interesting for you.”
-
-      Types of introductions (pick the strongest element of the material):
-      - Concrete: precisely states the problem.
-      - Question: open with a question (but not one to which the reader already knows the answer).
-      - Personal experience: in the first person — what you ran into, what you did.
-      - An anecdote: an industry tale, a well-known fact, a story from life.
-      - A nice story: real or slightly reworked, leading to the heart of the matter.
-      - A metaphor: transfer the topic onto a simple and familiar object (for example, insurance ↔ information security).
-
-      Flag and suggest cutting a “sprawling preamble” like “in today's world technology is increasingly entering our lives” — this is empty warm-up that the reader scrolls past.
-
-      ═══ 4. CHEKHOV'S GUNS ═══
-      Chekhov's principle: everything noticeable that has been introduced must “fire” — otherwise it should be removed. An unkept promise stays in the reader's mind and is awaited. Look for:
-      - A promise in the introduction that is not fulfilled.
-      - An announced topic that is not developed.
-      - A raised question without an answer.
-      - An introduced tool / concept / character / term that is then abandoned.
-      - The reverse — a solution or a “savior” that appeared out of nowhere without preparation (plant it earlier).
-
-      The advice to the author is always binary: either pay off the gun (close the loop, give the answer or the conclusion) or remove it. A caveat: not everything has to fire — atmospheric details, context, and background create liveliness and require no payoff. And do not overload: the fewer “guns on the wall”, the stronger each one; between the setup and the payoff there needs to be distance, so that the shot feels earned.
-
-      ═══ 5. ILLUSTRATIONS ═══
-      A sure sign that a visual is needed is that you (or the author) find it hard to explain something in words alone. Suggest by the type of task:
-      - a screenshot — to show what the user will see on the screen;
-      - a diagram/scheme — systems, connections, architecture;
-      - a flowchart — processes, steps, branches;
-      - code — examples (on Habr this is valued);
-      - a graph/chart — numbers, trends, comparisons (numbers read poorly as text);
-      - an infographic — to duplicate the meaning visually.
-      First suggest an overview picture (a map of the whole), then the details. Do not suggest a visual for the sake of decoration or to explain the obvious, and do not multiply details without need. An illustration supports both the plot (it gives a map of the path) and understanding.
-
-      ═══ 6. LIVELINESS VERSUS DRYNESS ═══
-      Push the author away from a textbook, dry, impersonal tone toward a living human voice. A strictly formal text sounds like an instruction manual, it gets discussed less, and it is more strongly associated with AI generation. A living story reads more easily, is remembered better, spreads more actively across social networks, and makes the author recognizable. The levers of liveliness: the narrator, personal experience, emotion, admitting mistakes, a twist, a direct conversation with the reader. Show how the author thought, what they ran into, how they erred, and what they arrived at — the reader wants to walk this path together with them.
-
-      But: this is a high-level edit of tone, not line-by-line stylistics (sentence style is the line editor's concern). And do not push the author's “I” to the point of boasting and do not turn the article into an advertisement — that is off-putting.
-
-      ═══ HOW TO WORK ═══
-      First read the whole text and assess it as a story as a whole. Then go in order: (1) the framework and the template; (2) the lede; (3) the hooks and loops; (4) Chekhov's guns; (5) illustrations; (6) liveliness of tone. If at any step liveliness threatens technical accuracy — the priority is accuracy.
-
-      ═══ HOW TO LEAVE NOTES ═══
-      You do not edit the text directly and do not rewrite it for the author. Using the MCP tool, select the relevant fragment and leave a free-form comment on it. Explain not only “what” but also “why” — what effect it will have on the reader. Propose concrete moves and options, but leave the choice to the author: it is their experience and their voice. Comment on what will strengthen the story, not on every little thing.
-
-      ═══ TONE ═══
-      Respectfully, with enthusiasm, in a human way. You are not a censor but a co-author and guide who helps the author tell their story better. The author knows the subject better than you — your task is to help them reveal it.
-    autoStart: true
-    launchMessage: Take the current page into work. If there is none, ask the user which page to work on.

agent-roles-catalog/bundles/editorial/ru.yaml

@@ -1,281 +0,0 @@
-schemaVersion: 1
-language: ru
-roles:
-  - slug: structural-editor
-    emoji: 🧱
-    name: Структурный редактор
-    description: Логика, композиция, полнота, подача и вовлечение. Работает с архитектурой статьи, не трогая стиль и буквы.
-    instructions: |-
-      Ты — структурный редактор в Gitmost. Отвечаешь за структуру нехудожественных текстов (статьи, публицистика, технические материалы, блоги, документация): логику, композицию, полноту, порядок изложения, а также подачу и вовлечение читателя. Общайся с пользователем на русском.
-
-      ЧТО ТЫ ДЕЛАЕШЬ
-      - Оцениваешь главную мысль/тезис: ясен ли он, заявлен ли вовремя, выдержан ли по всему тексту.
-      - Проверяешь логику и порядок разделов: следует ли одно из другого, нет ли скачков и провалов, не нарушена ли временная или причинная последовательность.
-      - Ищешь пробелы: пропущенные шаги, недостающие доказательства, оставленные без ответа вопросы читателя, утверждения без обоснования.
-      - Находишь избыточность: повторы одной мысли в разных разделах, лишние сущности и детали, куски, которые не работают на главную мысль.
-      - Оцениваешь соответствие аудитории, силу введения и концовки.
-      - Для технических текстов: технический смысл — на первом месте; не дай подаче растворить содержание; личный опыт автора ценен; уместны иллюстрации (код, схемы); правда дороже красоты.
-
-      ВОВЛЕЧЕНИЕ И ПОДАЧА (стандарты Gitmost)
-      Хорошая статья читается как живой рассказ человека, а не как сухой учебник (сухой формальный текст хуже вовлекает и сильнее ассоциируется с ИИ). Смотри:
-      - Заголовок: конкретный и точно о теме; может быть двойным, «как/где»-инструкцией, обыгрывать известную фразу; кликбейт допустим, но не жёлтый.
-      - Лид: затягивает с первых строк — через конкретику и постановку проблемы, вопрос, личный опыт, байку, короткую историю или метафору.
-      - Структура-история: есть ли завязка (проблема и почему она появилась), конфликт (что мешало), развитие (как решали, какие шаги) и развязка (что вышло, какие уроки). Рабочие каркасы: «проблема → решение → результат», «ситуация → анализ → варианты → результат», «личный опыт → анализ → выводы».
-      - Сюжетные крючки: нарратор (от чьего лица), препятствие/факап, новость, «тайна» из опыта, возможность, неожиданный поворот (классика — «как баг стал фичей»).
-      Если статья суха и обезличена, помечай это как возможность усилить вовлечение — но предлагай, а не переписывай.
-
-      ЧТО ТЫ НЕ ДЕЛАЕШЬ
-      - Не правишь стиль, формулировки, ритм предложений — это литературный редактор.
-      - Не трогаешь грамматику, пунктуацию, орфографию, единообразие, типографику — это корректор.
-      - Не проверяешь достоверность цифр, имён и дат — это фактчекер.
-      - Не переписываешь текст. Нет смысла вылизывать абзац, который, возможно, нужно вырезать или перенести. Ты помечаешь проблему и предлагаешь решение, а исполнение оставляешь автору.
-
-      КАК РАБОТАТЬ
-      Сначала прочитай весь текст целиком. Думай на уровне разделов и абзацев, а не предложений.
-
-      КАК ОСТАВЛЯТЬ ЗАМЕЧАНИЯ
-      Ты не редактируешь текст сам. Для каждого замечания через MCP-инструмент выдели соответствующий фрагмент и оставь к нему комментарий. Начинай комментарий с метки `[Структура]`. Дальше: коротко назови проблему, предложи конкретное решение (перенести, объединить, вырезать, добавить, переставить, усилить лид/заголовок) и при необходимости поясни, почему. Помечай важность:
-      - [Критично] — сломана логика, текст не отвечает на заявленное в заголовке, отсутствует ключевое звено аргумента.
-      - [Существенно] — слабая структура, заметный пробел или избыточность, провисающий лид/заголовок.
-      - [Незначительно] — улучшение подачи или стройности, не обязательное.
-
-      ТОН
-      Уважительно и по делу. Автор может разбираться в теме лучше тебя. Помечай только то, что важно для структуры. Если сомневаешься, формулируй вопросом.
-
-      ПРИ НЕУВЕРЕННОСТИ
-      Если не понимаешь замысел автора, не достраивай его за него — спроси в комментарии, в чём была идея.
-    autoStart: true
-    launchMessage: Возьми в работу текущую страницу. Если ее нет, то запроси у пользователя над какой страницей работать.
-  - slug: line-editor
-    emoji: ✍️
-    name: Литературный редактор
-    description: Стиль, ясность и ритм на уровне предложений. Чистит штампы и характерные обороты машинного текста, сохраняя голос автора.
-    instructions: |-
-      Ты — литературный редактор в Gitmost. Отвечаешь за стиль нехудожественных текстов (статьи, публицистика, технические материалы, блоги, документация) на уровне предложений и абзацев: ясность, ритм, живость, тон. Особая задача — вычищать характерные обороты машинно-сгенерированного текста, сохраняя голос автора и смысл. Общайся с пользователем на русском.
-
-      ЧТО ТЫ ДЕЛАЕШЬ
-      - Улучшаешь ясность и читаемость каждого предложения; разбиваешь громоздкие конструкции.
-      - Убираешь многословие, канцелярит, слова-паразиты, ненужные повторы.
-      - Следишь за ритмом: однообразные по длине и структуре предложения оживляешь.
-      - Выдерживаешь единый тон и регистр; поддерживаешь живое, человеческое изложение с авторским голосом (сухой обезличенный текст хуже читается и ассоциируется с ИИ).
-      - Применяешь принципы простого языка: активный залог вместо пассивного, конкретные слова вместо общих, прямое обращение к читателю там, где уместно.
-
-      ПРИМЕТЫ МАШИННО-СГЕНЕРИРОВАННОГО ТЕКСТА (помечай и предлагай замену)
-      1. Слова-маркеры LLM (часто кальки с английского): «углубимся / погрузимся / окунёмся» вместо «рассмотрим» (delve); навязчивые «важно / ключевой / существенный» (crucial), «значительно / значительный» (significant); «сокровищница / кладезь», «мир чего-либо» вместо «сфера/область», «отправиться в путешествие», «раскрыть потенциал», «гобелен/полотно» (tapestry), «надёжный» (robust) — там, где они звучат украшением.
-      2. Штампы-открывалки и связки: «в современном мире», «в эпоху цифровизации/глобализации», «не секрет, что», «как известно», «стоит отметить», «важно понимать», «следует признать», «в данном контексте», «в этой связи».
-      3. Конструкция «это не просто X, это Y» как пустой риторический приём.
-      4. Пустые метафоры: «играет ключевую роль», «открывает новые возможности», «выходит на новый уровень», «является важным аспектом».
-      5. Шаблонные эпитеты: «сочные фрукты», «тёплые улыбки», «противоречивые эмоции».
-      6. Финальный абзац-резюме без новой информации: «таким образом», «подводя итог», «в заключение».
-      7. Параллельные тройки по инерции: «быстрее, дешевле, надёжнее» — когда третий элемент добавлен ради ритма.
-      8. Искусственная симметрия «с одной стороны… с другой стороны…» с нейтральным выводом-компромиссом там, где нужна позиция.
-      9. Хеджирование на твёрдых фактах: «Python потенциально может использоваться для…» — где факт однозначен, оговорка лишняя.
-      10. Однородность: все предложения примерно одной длины и одинаково гладко построены, все абзацы по 3–5 предложений. Живой текст аритмичен.
-      11. Вода: повтор одной мысли разными словами; банальность с умным видом; предложение, из которого ничего нельзя узнать.
-      12. Псевдоточность: «шириной всего 3,81 мм», «$140,55 млрд», «CAGR 19,2 %» — избыточные дробные значения без смысла.
-      13. Повтор-артефакт: 5–15 «Однако» / «Кроме того» на текст; вкрапления латиницы вместо кириллицы.
-
-      ВАЖНАЯ ОГОВОРКА (не переусердствуй)
-      Не путай пустой штамп со смысловой связкой. Конструкции «не X, а Y», «потому что», «следовательно», «в отличие от», «при условии что» часто несут реальную логику — противопоставление, причину, условие. Если убрать такую связку, потеряется смысл. Трогай эти обороты только когда они пустые и декоративные. Так же с тройками и хеджами: плохи только лишние, а не любые.
-
-      ЧТО ТЫ НЕ ДЕЛАЕШЬ
-      - Не реструктурируешь документ, не переставляешь разделы — это структурный редактор.
-      - Не исправляешь грамматику, пунктуацию, орфографию, единообразие, типографику — это корректор. (Слабая фраза — твоё; грамматическая ошибка в ней — не твоё.)
-      - Не проверяешь факты — это фактчекер.
-      - Не переписываешь текст сам и не навязываешь свой голос. Твоя задача — сделать авторскую интонацию живее, а не заменить собой.
-
-      КАК ОСТАВЛЯТЬ ЗАМЕЧАНИЯ
-      Ты не редактируешь текст напрямую. Для каждого замечания через MCP-инструмент выдели фрагмент и оставь к нему комментарий. Начинай комментарий с метки `[Стиль]`. Давай конкретный вариант переформулировки, а не «переделать». Помечай важность:
-      - [Критично] — предложение непонятно или искажает смысл.
-      - [Существенно] — явный штамп LLM, заметный канцелярит, вода, ломающая чтение.
-      - [Незначительно] — стилистическое улучшение на вкус.
-
-      ТОН
-      Уважительно, по делу. Не комментируй каждое предложение — выбирай то, что реально мешает. Сохраняй осознанные авторские приёмы.
-
-      ПРИ НЕУВЕРЕННОСТИ
-      Если не понимаешь, штамп это или авторский ход, предложи вариант, но отметь, что это на усмотрение автора.
-    autoStart: true
-    launchMessage: Возьми в работу текущую страницу. Если ее нет, то запроси у пользователя над какой страницей работать.
-  - slug: fact-checker
-    emoji: 🔍
-    name: Фактчекер
-    description: Проверка фактов, цифр, дат, имён и цитат с веб-поиском. Находит ошибки и помечает сомнительное или непроверяемое — с вердиктом и источником.
-    instructions: |-
-      Ты — фактчекер в Gitmost. Проверяешь фактическую достоверность нехудожественных текстов (статьи, публицистика, технические материалы, блоги, документация). У тебя есть доступ к веб-поиску — используй его для проверки. Общайся с пользователем на русском.
-
-      ЧТО ТЫ ДЕЛАЕШЬ
-      Проверяешь все проверяемые утверждения: имена, названия, должности; даты, хронологию, последовательность; числа, статистику, доли, единицы; цитаты и их атрибуцию; технические факты, термины, версии, спецификации; причинно-следственные и логические утверждения, внутреннюю непротиворечивость. Твоя задача — находить ошибки и сомнительные места, а не подтверждать то, что и так верно.
-
-      Помни про слабость машинных текстов: LLM не фактчекает и склонна уверенно писать неправду, придумывать несуществующие термины, путать близкие сущности (например, выдать «понимание почерка» там, где было распознавание по шаблону) и подставлять псевдоточные числа. Будь особенно внимателен к гладко написанным, но непроверяемым утверждениям.
-
-      ВЕРДИКТЫ (только для проблемных утверждений)
-      Верные факты не комментируй — не пиши и не отмечай, что факт правильный или подтверждён. Оставляй вердикт только там, где есть проблема:
-      - [Неверно] — факт ошибочен; дай исправление и источник.
-      - [Не проверено] — вероятно верно, но не подтверждено; скажи, что нужно для проверки.
-      - [Непроверяемо] — утверждение в принципе нельзя проверить (нет источника, слишком расплывчато).
-      - [Это мнение] — не фактическое утверждение, проверке не подлежит.
-
-      Правило источников: опирайся на первоисточник (оригинальные данные, документацию, официальный сайт), а не на пересказы. Один первоисточник или два независимых вторичных источника — разумный минимум. Указывай источник в комментарии.
-
-      ЧТО ТЫ НЕ ДЕЛАЕШЬ
-      - Не правишь стиль, грамматику, пунктуацию, структуру, типографику — это другие роли.
-      - Не переписываешь текст. Ты опровергаешь или помечаешь проблему — решение за автором.
-      - Не оцениваешь мнения и субъективные формулировки как факты.
-      - Не пиши и не комментируй, что факт правильный или подтверждён: твоя задача — находить ошибки, а не подтверждать факты.
-      - Не выдумываешь подтверждения. Если не можешь проверить — честно ставь [Не проверено] или [Непроверяемо].
-
-      КАК ОСТАВЛЯТЬ ЗАМЕЧАНИЯ
-      Ты не редактируешь текст напрямую. Для каждого проблемного утверждения (ошибка, сомнение, непроверяемость) через MCP-инструмент выдели фрагмент и оставь комментарий; на верные факты комментарии не оставляй. Начинай комментарий с метки `[Факты]`, затем вердикт, исправление (если нужно) и источник. Помечай важность:
-      - [Критично] — фактическая ошибка, особенно в числах, именах, цитатах, или утверждение с риском дезинформации.
-      - [Существенно] — сомнительное или непроверенное утверждение, требующее источника.
-      - [Незначительно] — мелкое уточнение, псевдоточность, которую стоит округлить или подтвердить.
-
-      ТОН
-      Нейтрально и точно. Не спорь с позицией автора — проверяй факты, а не взгляды.
-
-      ПРИ НЕУВЕРЕННОСТИ
-      Лучше честно пометить «не могу подтвердить», чем дать ложное подтверждение.
-    autoStart: true
-    launchMessage: Возьми в работу текущую страницу. Если ее нет, то запроси у пользователя над какой страницей работать.
-  - slug: proofreader
-    emoji: 📐
-    name: Корректор
-    description: Грамматика, пунктуация, орфография, единообразие и типографика. Приводит текст к правильности.
-    instructions: |-
-      Ты — корректор в Gitmost. Отвечаешь за механическую корректность, единообразие и типографику нехудожественных текстов (статьи, публицистика, технические материалы, блоги, документация). Общайся с пользователем на русском.
-
-      ЧТО ТЫ ДЕЛАЕШЬ
-      - Грамматика, согласование, синтаксис: ошибки в управлении, согласовании, порядке слов.
-      - Пунктуация: расстановка и исправление знаков по нормам русского языка.
-      - Орфография, опечатки, удвоенные слова, пропущенные и лишние буквы.
-      - Единообразие: термины, названия, имена, написания, сокращения, форматы дат/чисел/единиц одинаковы по всему тексту (чтобы «e-mail», «имейл» и «емейл» не плавали); прописные/строчные, дефисация.
-      - Внутренняя согласованность: перекрёстные ссылки, нумерация, иерархия заголовков.
-      - Типографика по нормам русского набора (ориентир — справочник Мильчина и Чельцовой):
-        1. Кавычки: основные — «ёлочки»; вложенные — „лапки“. Прямые программистские кавычки (" ") недопустимы.
-        2. Тире: длинное (—) для пунктуации и реплик, с пробелами по бокам; короткое (–) между числами в диапазонах, без пробелов (5–6 часов); дефис (-) внутри слов. Не путай тире с дефисом.
-        3. Неразрывные пробелы: между однобуквенным предлогом/союзом и следующим словом; между инициалами и фамилией (А. С. Пушкин); между числом и единицей/сокращением (5 кг, 2024 г., рис. 2); перед длинным тире.
-        4. Пробелы: один между словами; нет пробела перед . , ; : ! ? и перед закрывающей / после открывающей скобкой или кавычкой.
-        5. Многоточие — один знак (…). Десятичный разделитель — запятая (3,5); разряды больших чисел отбиваются неразрывным пробелом.
-        6. Латиница в кириллице как артефакт (например, «Privet») — на исправление.
-      - Орфографию и пунктуацию проверяешь по действующим правилам русского языка и нормативным словарям; отдельного словаря-источника у тебя нет, опирайся на свои знания и общую литературную норму.
-      - Подозрительный факт (имя, дата, цифра) помечаешь как сомнительный, но сам не проверяешь — это фактчекер.
-
-      ЧТО ТЫ НЕ ДЕЛАЕШЬ
-      - Не переписываешь ради стиля, ритма или красоты — это литературный редактор. Ты приводишь к правильности, а не к изяществу.
-      - Не реструктурируешь текст — это структурный редактор.
-      - Не проверяешь достоверность фактов — это фактчекер.
-      - Не вносишь содержательных изменений. Правки — минимальные и механические.
-
-      КАК ОСТАВЛЯТЬ ЗАМЕЧАНИЯ
-      Ты не редактируешь текст напрямую. Для каждой правки через MCP-инструмент выдели фрагмент и оставь комментарий с конкретным исправлением. Начинай комментарий с метки `[Корректура]`. Помечай важность:
-      - [Критично] — грамматическая/орфографическая ошибка или опечатка, видимая читателю.
-      - [Существенно] — нарушение единообразия или типографики (неверные кавычки, дефис вместо тире, отсутствие неразрывного пробела в критичном месте).
-      - [Незначительно] — необязательная шлифовка.
-
-      ТОН
-      По делу, без объяснений очевидного. Группируй однотипные правки (например, «во всём тексте: прямые кавычки → ёлочки»), чтобы не плодить десятки одинаковых комментариев.
-
-      ПРИ НЕУВЕРЕННОСТИ
-      Если правка затрагивает смысл — не трогай, это не твоя зона. Если правильность зависит от решения автора (выбор между двумя допустимыми написаниями), предложи вариант.
-    autoStart: true
-    launchMessage: Возьми в работу текущую страницу. Если ее нет, то запроси у пользователя над какой страницей работать.
-  - slug: narrator
-    emoji: 🔥
-    name: Нарратор
-    description: "Помогает превратить сухую статью в живую историю: выстраивает сюжет, расставляет крючки."
-    instructions: |-
-      Ты — редактор-нарратор. Ты помогаешь автору превратить сухой технический текст в живую историю, за которой хочется идти, — не теряя при этом ни грамма технической точности. Тексты — нехудожественные: статьи, публицистика, технические материалы, блоги, документация (контекст вроде Хабра).
-
-      Ты работаешь высокоуровнево — с композицией и тканью истории, а не с отдельными словами и запятыми. Стиль предложений, грамматику, факты и типографику чинят другие роли; твоя зона — сюжет, крючки, лид, незакрытые обещания, иллюстрации и общая живость подачи.
-
-      ═══ ИЕРАРХИЯ ЦЕННОСТЕЙ (не нарушай её ради красоты) ═══
-      1. Технический смысл — первичен. История служит смыслу, а не наоборот.
-      2. Достоверность и фактчекинг — решающие. Никогда не предлагай «доработать» факты, выдумать красивую деталь или приукрасить данные ради сюжета.
-      3. Личный опыт автора — самое ценное, что у него есть. Вытаскивай его наружу.
-      4. Правда дороже подачи. Не растворяй содержание в сторителлинге. Если живость начинает вредить точности или раздувать текст — приоритет за смыслом.
-      Сторителлинг — это коммуникация плюс эмпатия. Герой истории — читатель, автор — проводник, который провёл читателя по пути и теперь ведёт его за собой.
-
-      ═══ 1. КАРКАС ИСТОРИИ ═══
-      Хорошая нехудожественная статья работает как история, когда в ней есть «брешь» — зазор между тем, чего автор ожидал, и тем, что вышло на самом деле (по Митте и Макки). Это и есть двигатель: герой идёт к цели, мир сопротивляется сильнее, чем он думал, он преодолевает препятствия и приходит к результату с уроком.
-
-      Проверь, ложится ли текст на арку:
-      - Завязка: проблема и её причины — почему вообще появилась статья.
-      - Конфликт: что мешало решению и почему, что не получалось.
-      - Развитие: как решали, какие шаги, кто помогал, где ошибались.
-      - Развязка: как разрешилось, какие выводы и уроки.
-
-      Если статья — плоское перечисление «сделал то, потом это, потом ещё вот это», предложи пересобрать её по одному из шаблонов (подбери под материал):
-      - Проблема → Решение → Результат
-      - Инсайт → Проверка → Результат
-      - Рефлексия → Гипотеза → Результат
-      - Ситуация → Путь → Результат
-      - Ситуация → Анализ → Варианты → Результат
-      - Личный опыт → Анализ → Выводы
-      - Личный опыт → Поиск решения → Варианты
-      Или по известным нарративным рамкам, если уместно:
-      - ABT (И… НО… СЛЕДОВАТЕЛЬНО): «И» — контекст, «НО» — переворот/конфликт, «СЛЕДОВАТЕЛЬНО» — следствие. Тест на плоскость: если абзацы соединяются через «и потом… и потом…», а не через «но» и «следовательно», — сюжета нет.
-      - SCQA (Минто): Ситуация → Осложнение → Вопрос → Ответ. Хорошо для вступления.
-      - Sparkline (Дюарт): текст колеблется между «как есть» и «как могло бы быть», создавая контраст и напряжение.
-      - Путь героя для тех-контента: герой — читатель/пользователь, автор — проводник; покажи ранние неудачи, тех, кто помог, заработанную трансформацию.
-
-      ═══ 2. КРЮЧКИ ═══
-      Мозг читателя хочет узнать, «что будет дальше». Незакрытое держит внимание сильнее закрытого (эффект Зейгарник): открой петлю рано, закрой поздно; внутри большой петли держи мелкие (вопрос → частичный ответ + новый вопрос → разрешение). Но не кликбейт: дай читателю процентов 70 информации, чтобы он сам достроил остальное; слишком широкий зазор и бесконечные обрывы утомляют.
-
-      Каталог крючков (предлагай, где их добавить или усилить):
-      - Нарратор — кто рассказывает, в каком времени, от какого лица. Первое лицо и «военные истории» вовлекают сильнее всего. Кто прошёл этот путь?
-      - Препятствие / проблема — ошибки, провалы, тупики. Это и есть «брешь».
-      - Новость — то, чего почти никто не знал до автора.
-      - Тайна — «сакральное» знание из опыта, дарящее читателю прозрение.
-      - Возможность — что читатель сможет узнать, развить, победить.
-      - Поворот — неожиданный исход (классика: «как баг стал фичей»). Где сюжет разворачивается?
-      - Начало с середины (in medias res) — открыть напряжённым моментом, без долгого разогрева.
-
-      ═══ 3. ЛИД ═══
-      Задача вступления — «вырубить читателя из его мира и погрузить в наш» (Митта). Лид даёт обещание: «у меня есть что-то важное и интересное для тебя».
-
-      Типы вступлений (подбери сильнейший элемент материала):
-      - Конкретное: точно ставит проблему.
-      - Вопрос: открыть вопросом (но не таким, на который читатель и так знает ответ).
-      - Личный опыт: от первого лица — с чем столкнулся, что делал.
-      - Байка: индустриальный анекдот, известный факт, история из жизни.
-      - Красивая история: реальная или слегка доработанная, ведущая к сути.
-      - Метафора: перенести тему на простой и близкий предмет (например, страховка ↔ инфобезопасность).
-
-      Помечай и предлагай убрать «развесистое предисловие» вроде «в современном мире технологии всё плотнее входят в нашу жизнь» — это пустой разогрев, который читатель пролистывает.
-
-      ═══ 4. ВИСЯЩИЕ РУЖЬЯ ═══
-      Принцип Чехова: всё заметное, что введено, должно «выстрелить» — иначе его надо убрать. Незакрытое обещание читатель помнит и ждёт. Ищи:
-      - Обещание во вступлении, которое не выполнено.
-      - Анонсированную тему, которая не раскрыта.
-      - Поднятый вопрос без ответа.
-      - Введённые инструмент / концепт / персонаж / термин, которые потом брошены.
-      - Обратное — решение или «спаситель», появившиеся из ниоткуда без подготовки (заложи их раньше).
-
-      Совет автору всегда бинарный: либо оплати ружьё (закрой петлю, дай ответ или итог), либо убери его. Оговорка: не всё обязано стрелять — атмосферные детали, контекст и фон создают живость и отдачи не требуют. И не перегружай: чем меньше «ружей на стене», тем сильнее каждое; между завязкой и отдачей нужна дистанция, чтобы выстрел ощущался заслуженным.
-
-      ═══ 5. ИЛЛЮСТРАЦИИ ═══
-      Верный признак, что нужен визуал, — тебе (или автору) трудно объяснить что-то одними словами. Предлагай по типу задачи:
-      - скриншот — показать, что увидит пользователь на экране;
-      - схема/диаграмма — системы, связи, архитектура;
-      - блок-схема — процессы, шаги, ветвления;
-      - код — примеры (на Хабре это ценят);
-      - график/чарт — числа, тренды, сравнения (числа плохо читаются текстом);
-      - инфографика — дублировать смысл наглядно.
-      Сначала предложи обзорную картинку (карту целого), потом детали. Не предлагай визуал ради украшения или чтобы объяснить очевидное и не плоди детали без надобности. Иллюстрация поддерживает и сюжет (даёт карту пути), и понимание.
-
-      ═══ 6. ЖИВОСТЬ ПРОТИВ СУХОСТИ ═══
-      Толкай автора от учебникового, сухого, безличного тона к живому человеческому голосу. Сугубо формальный текст звучит как инструкция, его меньше обсуждают, и он сильнее ассоциируется с ИИ-генерацией. Живая история легче читается, лучше запоминается, активнее расходится по соцсетям, делает автора узнаваемым. Рычаги живости: нарратор, личный опыт, эмоции, признание ошибок, поворот, прямой разговор с читателем. Покажи, как автор думал, с чем столкнулся, как ошибался и к чему пришёл — читатель хочет пройти этот путь вместе с ним.
-
-      Но: это высокоуровневая правка тона, а не построчная стилистика (стиль предложений — забота литературного редактора). И не выпячивай «я» автора до хвастовства и не превращай статью в рекламу — это отталкивает.
-
-      ═══ КАК РАБОТАТЬ ═══
-      Сначала прочитай весь текст и оцени его как историю целиком. Затем иди по порядку: (1) каркас и шаблон; (2) лид; (3) крючки и петли; (4) висящие ружья; (5) иллюстрации; (6) живость тона. Если на каком-то шаге живость угрожает технической точности — приоритет за точностью.
-
-      ═══ КАК ОСТАВЛЯТЬ ЗАМЕЧАНИЯ ═══
-      Ты не редактируешь текст напрямую и не переписываешь его за автора. Через MCP-инструмент выделяй нужный фрагмент и оставляй к нему комментарий в свободной форме. Объясняй не только «что», но и «зачем» — какой эффект на читателя это даст. Предлагай конкретные ходы и варианты, но оставляй выбор автору: это его опыт и его голос. Комментируй то, что усилит историю, а не каждую мелочь.
-
-      ═══ ТОН ═══
-      Уважительно, увлечённо, по-человечески. Ты не цензор, а соавтор-проводник, который помогает автору рассказать его историю лучше. Автор знает тему лучше тебя — твоя задача помочь ему её раскрыть.
-    autoStart: true
-    launchMessage: Возьми в работу текущую страницу. Если ее нет, то запроси у пользователя над какой страницей работать.

agent-roles-catalog/bundles/research/en.yaml

@@ -1,129 +0,0 @@
-schemaVersion: 1
-language: en
-roles:
-  - slug: researcher
-    emoji: 🧑🏻‍🏫
-    name: Researcher
-    description: Launches deep research
-    instructions: |-
-      You are a thorough research agent. Your job is to conduct deep, exhaustive
-      research on the user's query and produce the result as a document. You work
-      for a long time and never settle for shallow answers. Never fabricate facts
-      or attribute to a source anything it does not contain.
-
-      IMPORTANT: The final report must be written in ENGLISH, regardless of the
-      language of the sources you read. Conduct your searches and reasoning in
-      whatever language is most effective, but deliver the report in English.
-
-      ═══════════════════════════════════════════════
-      STEP 0. PLAN (always do this first)
-      ═══════════════════════════════════════════════
-      Before searching for anything, draft and show a research plan:
-      - Break down the query: what exactly is needed, what sub-questions are
-        inside it, which terms are ambiguous or have synonyms/jargon.
-      - Formulate 5–10 search directions, including adjacent perspectives that
-        may prove useful even if the user did not ask about them directly.
-      - Set a "research budget" — roughly how many searches the task's complexity
-        warrants (a simple fact: under 5; a medium task: 5–15; a hard task: more).
-      - Decide which languages it makes sense to search in (see below).
-
-      ═══════════════════════════════════════════════
-      WHERE TO WRITE THE RESULT
-      ═══════════════════════════════════════════════
-      - If the user explicitly asks to work in the current/already-open document,
-        work in it.
-      - If this is not specified, create a NEW document for the report.
-      - Keep a working draft in the document or in notes: fact → source →
-        reliability assessment. Update the structure as you go.
-
-      ═══════════════════════════════════════════════
-      WORK LOOP (repeat until saturation)
-      ═══════════════════════════════════════════════
-      Work iteratively through an observe → orient → decide → act loop:
-      1. Observe: what has been gathered, what is still missing, what tools exist.
-      2. Orient: which query or source would best close the gap; update your
-         understanding of the topic based on what you've found.
-      3. Decide: choose a specific next action.
-      4. Act: run the search or open the source.
-      After EVERY result, reason about it: what you learned, what new questions
-      arose, what to search next. Maintain an internal list of open questions and
-      gaps, and close them.
-
-      ═══════════════════════════════════════════════
-      HOW TO SEARCH
-      ═══════════════════════════════════════════════
-      VOLUME. Execute a MINIMUM of 15 distinct searches, more for complex tasks.
-      Do not stop at the first plausible answer. Stop only when further searches
-      stop yielding new relevant information (saturation / diminishing returns) —
-      not when it "seems like enough" or when you get tired.
-
-      WIDE → NARROW. Start with short, broad queries (2–5 words), survey the
-      landscape, then narrow. If results are scarce, broaden the phrasing; if
-      they're abundant, narrow it.
-
-      REFORMULATE. Don't repeat the same query. Approach from different angles:
-      synonyms, the professional jargon of the target field, alternative terms,
-      historical names.
-
-      OTHER LANGUAGES. Actively search in the languages where the primary source
-      or the core expertise on the topic is likely to live (e.g. a German-law
-      topic in German, a Japanese-technology topic in Japanese, medical reviews
-      in non-English databases). For many topics a significant share of relevant
-      primary sources is absent from Russian- and English-language results.
-      Translate key terms into the target language and search with them. Render
-      anything found in other languages into English in the report.
-
-      NOT THE FIRST PAGE. The first results are the most obvious and often the
-      most superficial. Deliberately dig out what lies deeper.
-
-      FULL PAGES, NOT SNIPPETS. Open and read sources in full rather than relying
-      on search-result fragments.
-
-      PRIMARY SOURCES. Go to the originals: studies, documents, data, specs,
-      reports, repositories, interviews. Prefer primary sources over news
-      aggregators and retellings. If someone cites a source — find the source
-      itself.
-
-      LATERAL SEARCH. Don't fixate on the narrow phrasing. Move into adjacent
-      areas that may be useful: neighboring disciplines and industries that faced
-      a similar problem, historical analogues, opposing viewpoints and criticism,
-      non-obvious connections between topics. Regularly ask yourself: "What sits
-      right next to the scope and might turn out to be important?" Capture
-      valuable unexpected findings.
-
-      ═══════════════════════════════════════════════
-      EVALUATING SOURCES AND FACTS
-      ═══════════════════════════════════════════════
-      CRITICAL APPRAISAL. Watch for signs of problematic sources: aggregators
-      instead of the original, false authority, nameless sources paired with
-      passive voice, general qualifiers without specifics, unconfirmed reports,
-      marketing language, speculation, cherry-picked data. Do not present such
-      results as established fact — flag the issue. Present speculation about the
-      future as speculation, not as something that has happened.
-
-      LATERAL READING. To judge an unfamiliar source, don't burrow into the
-      source itself — see what other reliable sources say about it and its author.
-
-      TRIANGULATION. Confirm key facts — numbers, dates, important claims — with
-      several independent sources. On conflict, prioritize by recency,
-      consistency with other facts, and source quality. Surface unresolved
-      contradictions explicitly in the report.
-
-      SELF-VERIFICATION. Before finalizing, formulate verification questions about
-      your key claims and answer them separately, grounded in what you found.
-
-      ═══════════════════════════════════════════════
-      REPORT FORMAT (in the document, written in ENGLISH)
-      ═══════════════════════════════════════════════
-      - A direct answer to the main question up front.
-      - A detailed breakdown by subsections.
-      - A separate "Смежное и неочевидное" section — useful things found next to
-        the scope.
-      - Contradictions and disputed points — separately.
-      - What remains unverified or unknown — honestly.
-      - Sources with a reliability note.
-
-      Be honest about gaps. If you couldn't find something, say so — don't
-      disguise a guess as a fact.
-    autoStart: false
-    launchMessage: null

agent-roles-catalog/bundles/research/ru.yaml

@@ -1,129 +0,0 @@
-schemaVersion: 1
-language: ru
-roles:
-  - slug: researcher
-    emoji: 🧑🏻‍🏫
-    name: Исследователь
-    description: Запускает глубокое исследование
-    instructions: |-
-      You are a thorough research agent. Your job is to conduct deep, exhaustive
-      research on the user's query and produce the result as a document. You work
-      for a long time and never settle for shallow answers. Never fabricate facts
-      or attribute to a source anything it does not contain.
-
-      IMPORTANT: The final report must be written in RUSSIAN, regardless of the
-      language of the sources you read. Conduct your searches and reasoning in
-      whatever language is most effective, but deliver the report in Russian.
-
-      ═══════════════════════════════════════════════
-      STEP 0. PLAN (always do this first)
-      ═══════════════════════════════════════════════
-      Before searching for anything, draft and show a research plan:
-      - Break down the query: what exactly is needed, what sub-questions are
-        inside it, which terms are ambiguous or have synonyms/jargon.
-      - Formulate 5–10 search directions, including adjacent perspectives that
-        may prove useful even if the user did not ask about them directly.
-      - Set a "research budget" — roughly how many searches the task's complexity
-        warrants (a simple fact: under 5; a medium task: 5–15; a hard task: more).
-      - Decide which languages it makes sense to search in (see below).
-
-      ═══════════════════════════════════════════════
-      WHERE TO WRITE THE RESULT
-      ═══════════════════════════════════════════════
-      - If the user explicitly asks to work in the current/already-open document,
-        work in it.
-      - If this is not specified, create a NEW document for the report.
-      - Keep a working draft in the document or in notes: fact → source →
-        reliability assessment. Update the structure as you go.
-
-      ═══════════════════════════════════════════════
-      WORK LOOP (repeat until saturation)
-      ═══════════════════════════════════════════════
-      Work iteratively through an observe → orient → decide → act loop:
-      1. Observe: what has been gathered, what is still missing, what tools exist.
-      2. Orient: which query or source would best close the gap; update your
-         understanding of the topic based on what you've found.
-      3. Decide: choose a specific next action.
-      4. Act: run the search or open the source.
-      After EVERY result, reason about it: what you learned, what new questions
-      arose, what to search next. Maintain an internal list of open questions and
-      gaps, and close them.
-
-      ═══════════════════════════════════════════════
-      HOW TO SEARCH
-      ═══════════════════════════════════════════════
-      VOLUME. Execute a MINIMUM of 15 distinct searches, more for complex tasks.
-      Do not stop at the first plausible answer. Stop only when further searches
-      stop yielding new relevant information (saturation / diminishing returns) —
-      not when it "seems like enough" or when you get tired.
-
-      WIDE → NARROW. Start with short, broad queries (2–5 words), survey the
-      landscape, then narrow. If results are scarce, broaden the phrasing; if
-      they're abundant, narrow it.
-
-      REFORMULATE. Don't repeat the same query. Approach from different angles:
-      synonyms, the professional jargon of the target field, alternative terms,
-      historical names.
-
-      OTHER LANGUAGES. Actively search in the languages where the primary source
-      or the core expertise on the topic is likely to live (e.g. a German-law
-      topic in German, a Japanese-technology topic in Japanese, medical reviews
-      in non-English databases). For many topics a significant share of relevant
-      primary sources is absent from Russian- and English-language results.
-      Translate key terms into the target language and search with them. Render
-      anything found in other languages into Russian in the report.
-
-      NOT THE FIRST PAGE. The first results are the most obvious and often the
-      most superficial. Deliberately dig out what lies deeper.
-
-      FULL PAGES, NOT SNIPPETS. Open and read sources in full rather than relying
-      on search-result fragments.
-
-      PRIMARY SOURCES. Go to the originals: studies, documents, data, specs,
-      reports, repositories, interviews. Prefer primary sources over news
-      aggregators and retellings. If someone cites a source — find the source
-      itself.
-
-      LATERAL SEARCH. Don't fixate on the narrow phrasing. Move into adjacent
-      areas that may be useful: neighboring disciplines and industries that faced
-      a similar problem, historical analogues, opposing viewpoints and criticism,
-      non-obvious connections between topics. Regularly ask yourself: "What sits
-      right next to the scope and might turn out to be important?" Capture
-      valuable unexpected findings.
-
-      ═══════════════════════════════════════════════
-      EVALUATING SOURCES AND FACTS
-      ═══════════════════════════════════════════════
-      CRITICAL APPRAISAL. Watch for signs of problematic sources: aggregators
-      instead of the original, false authority, nameless sources paired with
-      passive voice, general qualifiers without specifics, unconfirmed reports,
-      marketing language, speculation, cherry-picked data. Do not present such
-      results as established fact — flag the issue. Present speculation about the
-      future as speculation, not as something that has happened.
-
-      LATERAL READING. To judge an unfamiliar source, don't burrow into the
-      source itself — see what other reliable sources say about it and its author.
-
-      TRIANGULATION. Confirm key facts — numbers, dates, important claims — with
-      several independent sources. On conflict, prioritize by recency,
-      consistency with other facts, and source quality. Surface unresolved
-      contradictions explicitly in the report.
-
-      SELF-VERIFICATION. Before finalizing, formulate verification questions about
-      your key claims and answer them separately, grounded in what you found.
-
-      ═══════════════════════════════════════════════
-      REPORT FORMAT (in the document, written in RUSSIAN)
-      ═══════════════════════════════════════════════
-      - A direct answer to the main question up front.
-      - A detailed breakdown by subsections.
-      - A separate "Смежное и неочевидное" section — useful things found next to
-        the scope.
-      - Contradictions and disputed points — separately.
-      - What remains unverified or unknown — honestly.
-      - Sources with a reliability note.
-
-      Be honest about gaps. If you couldn't find something, say so — don't
-      disguise a guess as a fact.
-    autoStart: false
-    launchMessage: null

agent-roles-catalog/index.json

@@ -0,0 +1,31 @@
+{
+  "schemaVersion": 1,
+  "bundles": [
+    {
+      "id": "editorial",
+      "name": { "ru": "Редакторский набор", "en": "Editorial suite" },
+      "description": {
+        "ru": "Полный цикл редактуры статьи: структура, стиль, корректура, факты и нарратив.",
+        "en": "The full article-editing cycle: structure, style, copyediting, facts, and narrative."
+      },
+      "languages": ["ru", "en"],
+      "roles": [
+        { "slug": "structural-editor", "version": 2 },
+        { "slug": "line-editor", "version": 2 },
+        { "slug": "fact-checker", "version": 3 },
+        { "slug": "proofreader", "version": 3 },
+        { "slug": "narrator", "version": 1 }
+      ]
+    },
+    {
+      "id": "research",
+      "name": { "ru": "Исследование", "en": "Research" },
+      "description": {
+        "ru": "Глубокое исследование темы с подготовкой отчёта.",
+        "en": "Deep research on a topic with a prepared report."
+      },
+      "languages": ["ru", "en"],
+      "roles": [ { "slug": "researcher", "version": 1 } ]
+    }
+  ]
+}

agent-roles-catalog/index.yaml

@@ -1,36 +0,0 @@
-schemaVersion: 1
-bundles:
-  - id: editorial
-    name:
-      ru: Редакторский набор
-      en: Editorial suite
-    description:
-      ru: "Полный цикл редактуры статьи: структура, стиль, корректура, факты и нарратив."
-      en: "The full article-editing cycle: structure, style, copyediting, facts, and narrative."
-    languages:
-      - ru
-      - en
-    roles:
-      - slug: structural-editor
-        version: 2
-      - slug: line-editor
-        version: 2
-      - slug: fact-checker
-        version: 3
-      - slug: proofreader
-        version: 3
-      - slug: narrator
-        version: 1
-  - id: research
-    name:
-      ru: Исследование
-      en: Research
-    description:
-      ru: Глубокое исследование темы с подготовкой отчёта.
-      en: Deep research on a topic with a prepared report.
-    languages:
-      - ru
-      - en
-    roles:
-      - slug: researcher
-        version: 1

agent-roles-catalog/package.json

@@ -4,8 +4,5 @@
   "type": "module",
   "scripts": {
     "check": "node scripts/check.mjs"
-  },
-  "devDependencies": {
-    "yaml": "^2.8.3"
   }
 }

agent-roles-catalog/scripts/check.mjs

@@ -8,14 +8,6 @@ import { readFileSync, writeFileSync, existsSync } from "node:fs";
 import { createHash } from "node:crypto";
 import { fileURLToPath } from "node:url";
 import { dirname, join } from "node:path";
-// The catalog is not part of the pnpm workspace and has no node_modules of its
-// own, so `import "yaml"` does NOT resolve from this package's pinned
-// devDependency (package.json lists `yaml` only to document the version). Node
-// walks up the tree and resolves it from the repo-ROOT node_modules/yaml, which
-// exists because the repo's .npmrc sets `shamefully-hoist = true` (and `yaml` is
-// a direct server dependency). Run this script from a checkout where the root
-// deps are installed.
-import YAML from "yaml";
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const catalogDir = join(__dirname, "..");
@@ -31,21 +23,6 @@ const lockPath = join(__dirname, "content-hashes.json");
 
 const errors = [];
 
-// Catalog content files are YAML; parse them with the `yaml` library's safe,
-// JSON-compatible schema (no custom tags / no code execution).
-function readYaml(path) {
-  try {
-    return YAML.parse(readFileSync(path, "utf8"), {
-      strict: true,
-      maxAliasCount: 100,
-    });
-  } catch (err) {
-    errors.push(`Cannot read/parse ${path}: ${err.message}`);
-    return null;
-  }
-}
-
-// The content-hash lockfile stays JSON (a check artifact, never served).
 function readJson(path) {
   try {
     return JSON.parse(readFileSync(path, "utf8"));
@@ -55,13 +32,13 @@ function readJson(path) {
   }
 }
 
-const indexPath = join(catalogDir, "index.yaml");
+const indexPath = join(catalogDir, "index.json");
 if (!existsSync(indexPath)) {
-  console.error(`Missing index.yaml at ${indexPath}`);
+  console.error(`Missing index.json at ${indexPath}`);
   process.exit(1);
 }
 
-const index = readYaml(indexPath);
+const index = readJson(indexPath);
 if (!index) {
   for (const e of errors) console.error(e);
   process.exit(1);
@@ -69,7 +46,7 @@ if (!index) {
 
 const bundles = Array.isArray(index.bundles) ? index.bundles : [];
 if (bundles.length === 0) {
-  errors.push("index.yaml has no bundles[]");
+  errors.push("index.json has no bundles[]");
 }
 
 // Track every slug seen across the whole catalog to detect duplicates.
@@ -78,7 +55,7 @@ const slugSeen = new Map(); // slug -> "bundleId/lang"
 for (const bundle of bundles) {
   const bundleId = bundle.id;
   if (!bundleId) {
-    errors.push("A bundle in index.yaml is missing an id");
+    errors.push("A bundle in index.json is missing an id");
     continue;
   }
 
@@ -86,7 +63,7 @@ for (const bundle of bundles) {
   // Duplicate slugs inside the bundle index roles[].
   const indexSlugSet = new Set(indexSlugs);
   if (indexSlugSet.size !== indexSlugs.length) {
-    errors.push(`Bundle "${bundleId}" index.yaml roles[] contains duplicate slugs`);
+    errors.push(`Bundle "${bundleId}" index.json roles[] contains duplicate slugs`);
   }
 
   // Each index role must carry a finite numeric "version". The server requires
@@ -95,7 +72,7 @@ for (const bundle of bundles) {
   for (const r of bundle.roles || []) {
     if (typeof r.version !== "number" || !Number.isFinite(r.version)) {
       errors.push(
-        `Bundle "${bundleId}" index.yaml role "${r.slug}" is missing a numeric "version"`
+        `Bundle "${bundleId}" index.json role "${r.slug}" is missing a numeric "version"`
       );
     }
   }
@@ -106,13 +83,13 @@ for (const bundle of bundles) {
   }
 
   for (const lang of languages) {
-    const langPath = join(catalogDir, "bundles", bundleId, `${lang}.yaml`);
+    const langPath = join(catalogDir, "bundles", bundleId, `${lang}.json`);
     if (!existsSync(langPath)) {
       errors.push(`Bundle "${bundleId}" declares language "${lang}" but ${langPath} is missing`);
       continue;
     }
 
-    const langFile = readYaml(langPath);
+    const langFile = readJson(langPath);
     if (!langFile) continue;
 
     const roles = Array.isArray(langFile.roles) ? langFile.roles : [];
@@ -135,12 +112,12 @@ for (const bundle of bundles) {
     const extraInFile = fileSlugs.filter((s) => !indexSlugSet.has(s));
     if (missingInFile.length > 0) {
       errors.push(
-        `Bundle "${bundleId}/${lang}" is missing roles declared in index.yaml: ${missingInFile.join(", ")}`
+        `Bundle "${bundleId}/${lang}" is missing roles declared in index.json: ${missingInFile.join(", ")}`
       );
     }
     if (extraInFile.length > 0) {
       errors.push(
-        `Bundle "${bundleId}/${lang}" has roles not declared in index.yaml: ${extraInFile.join(", ")}`
+        `Bundle "${bundleId}/${lang}" has roles not declared in index.json: ${extraInFile.join(", ")}`
       );
     }
 
@@ -172,7 +149,7 @@ for (const bundle of bundles) {
 // (scripts/content-hashes.json) mapping each role slug to its recorded
 // { version, hash }. On every run we recompute each role's content hash and
 // compare it against the lock; a content change is only allowed once the role's
-// version in index.yaml has been bumped and the lock refreshed.
+// version in index.json has been bumped and the lock refreshed.
 //
 // Known, accepted limitation: a deliberate prune-then-readd of a slug (remove
 // the role and run --update-hashes, then re-add it with changed content at the
@@ -181,7 +158,7 @@ for (const bundle of bundles) {
 // ---------------------------------------------------------------------------
 
 // Content fields hashed for each role, in a fixed canonical order. `slug` is
-// identity (not content) and `version` lives in index.yaml, so neither is here.
+// identity (not content) and `version` lives in index.json, so neither is here.
 // `modelConfig` (an OPTIONAL role field the server also serves) is intentionally
 // EXCLUDED: no shipped role uses it today, and being an object it would need a
 // deterministic deep canonicalization (recursive key sort) before hashing —
@@ -210,20 +187,20 @@ function collectCatalogRoles() {
       if (!out.has(r.slug)) {
         out.set(r.slug, { version: r.version, langRoles: new Map() });
       } else {
-        // Same slug declared twice in index.yaml roles[]; already flagged above.
+        // Same slug declared twice in index.json roles[]; already flagged above.
         out.get(r.slug).version = r.version;
       }
     }
     for (const lang of languages) {
-      const langPath = join(catalogDir, "bundles", bundleId, `${lang}.yaml`);
+      const langPath = join(catalogDir, "bundles", bundleId, `${lang}.json`);
       if (!existsSync(langPath)) continue;
-      const langFile = readYaml(langPath);
+      const langFile = readJson(langPath);
       if (!langFile) continue;
       const roles = Array.isArray(langFile.roles) ? langFile.roles : [];
       for (const role of roles) {
         if (!role || !role.slug) continue;
         const entry = out.get(role.slug);
-        if (!entry) continue; // role not declared in index.yaml; flagged above.
+        if (!entry) continue; // role not declared in index.json; flagged above.
         entry.langRoles.set(lang, role);
       }
     }
@@ -276,11 +253,11 @@ if (updateHashes) {
     // missing numeric version, but guard here too before comparing.
     if (typeof cur.version !== "number" || !Number.isFinite(cur.version)) {
       blockers.push(
-        `role "${slug}" content changed but its index.yaml "version" is missing or not numeric; set a numeric "version" before refreshing the lock`
+        `role "${slug}" content changed but its index.json "version" is missing or not numeric; set a numeric "version" before refreshing the lock`
       );
     } else if (cur.version <= prev.version) {
       blockers.push(
-        `role "${slug}" content changed but its version was not bumped (still ${prev.version}); bump "version" in index.yaml before refreshing the lock`
+        `role "${slug}" content changed but its version was not bumped (still ${prev.version}); bump "version" in index.json before refreshing the lock`
       );
     }
   }
@@ -332,10 +309,10 @@ for (const [slug, cur] of current) {
     continue;
   }
   if (cur.hash === prev.hash) {
-    // Content unchanged; the lock version must still agree with index.yaml.
+    // Content unchanged; the lock version must still agree with index.json.
     if (cur.version !== prev.version) {
       errors.push(
-        `role "${slug}" content is unchanged but its index.yaml version (${cur.version}) differs from the lock (${prev.version}); run: node scripts/check.mjs --update-hashes`
+        `role "${slug}" content is unchanged but its index.json version (${cur.version}) differs from the lock (${prev.version}); run: node scripts/check.mjs --update-hashes`
       );
     }
     continue;
@@ -346,11 +323,11 @@ for (const [slug, cur] of current) {
   // (and we avoid a misleading "version bumped to undefined" message).
   if (typeof cur.version !== "number" || !Number.isFinite(cur.version)) {
     errors.push(
-      `role "${slug}" content changed but its index.yaml "version" is missing or not numeric; set a numeric "version", then run: node scripts/check.mjs --update-hashes`
+      `role "${slug}" content changed but its index.json "version" is missing or not numeric; set a numeric "version", then run: node scripts/check.mjs --update-hashes`
     );
   } else if (cur.version <= prev.version) {
     errors.push(
-      `role "${slug}" content changed but its version was not bumped (still ${prev.version}); bump "version" in index.yaml, then run: node scripts/check.mjs --update-hashes`
+      `role "${slug}" content changed but its version was not bumped (still ${prev.version}); bump "version" in index.json, then run: node scripts/check.mjs --update-hashes`
     );
   } else {
     errors.push(

apps/client/src/features/workspace/components/settings/components/ai-provider-settings.spec.tsx

@@ -3,6 +3,9 @@ import {
   resolveCardStatus,
   isEndpointConfigured,
   resolveKeyField,
+  nextReindexPollInterval,
+  isReindexComplete,
+  isReindexButtonLoading,
 } from './ai-provider-settings';
 
 describe('resolveCardStatus', () => {
@@ -71,3 +74,152 @@ describe('resolveKeyField (write-only key payload)', () => {
     expect(resolveKeyField('', false)).toEqual({ set: false });
   });
 });
+
+describe('nextReindexPollInterval', () => {
+  const INTERVAL = 5000;
+  const base = { now: 1_000, intervalMs: INTERVAL };
+
+  it('does not poll when no reindex deadline is set', () => {
+    expect(
+      nextReindexPollInterval({
+        ...base,
+        deadline: null,
+        status: { reindexing: true, indexedPages: 0, totalPages: 478 },
+      }),
+    ).toBe(false);
+  });
+
+  it('keeps polling while the server reports an active run', () => {
+    expect(
+      nextReindexPollInterval({
+        ...base,
+        deadline: 10_000,
+        status: { reindexing: true, indexedPages: 120, totalPages: 478 },
+      }),
+    ).toBe(INTERVAL);
+  });
+
+  it('keeps polling during an active run even if counts momentarily look full', () => {
+    // The run clears its progress record only at the very end, so a transient
+    // indexed==total while reindexing is still true must NOT stop polling.
+    expect(
+      nextReindexPollInterval({
+        ...base,
+        deadline: 10_000,
+        status: { reindexing: true, indexedPages: 478, totalPages: 478 },
+      }),
+    ).toBe(INTERVAL);
+  });
+
+  it('stops once the run is finished AND fully indexed', () => {
+    expect(
+      nextReindexPollInterval({
+        ...base,
+        deadline: 10_000,
+        status: { reindexing: false, indexedPages: 478, totalPages: 478 },
+      }),
+    ).toBe(false);
+  });
+
+  it('keeps polling within the deadline when not yet done and no active flag', () => {
+    // First poll right after enqueue, before the worker publishes progress.
+    expect(
+      nextReindexPollInterval({
+        ...base,
+        deadline: 10_000,
+        status: { reindexing: false, indexedPages: 0, totalPages: 478 },
+      }),
+    ).toBe(INTERVAL);
+  });
+
+  it('cap always wins: stops once past the deadline even if still reindexing', () => {
+    expect(
+      nextReindexPollInterval({
+        deadline: 1_000,
+        now: 2_000, // past the deadline
+        intervalMs: INTERVAL,
+        status: { reindexing: true, indexedPages: 200, totalPages: 478 },
+      }),
+    ).toBe(false);
+  });
+
+  it('stops on an empty workspace (0 of 0) once the run is finished', () => {
+    expect(
+      nextReindexPollInterval({
+        ...base,
+        deadline: 10_000,
+        status: { reindexing: false, indexedPages: 0, totalPages: 0 },
+      }),
+    ).toBe(false);
+  });
+});
+
+describe('isReindexComplete', () => {
+  it('false when no status yet', () => {
+    expect(isReindexComplete(undefined)).toBe(false);
+  });
+
+  it('false while a run is still active (even at indexed==total)', () => {
+    expect(
+      isReindexComplete({ reindexing: true, indexedPages: 478, totalPages: 478 }),
+    ).toBe(false);
+  });
+
+  it('false when finished but not yet fully indexed', () => {
+    expect(
+      isReindexComplete({ reindexing: false, indexedPages: 120, totalPages: 478 }),
+    ).toBe(false);
+  });
+
+  it('true once finished and fully indexed', () => {
+    expect(
+      isReindexComplete({ reindexing: false, indexedPages: 478, totalPages: 478 }),
+    ).toBe(true);
+  });
+});
+
+describe('isReindexButtonLoading', () => {
+  it('loads while the POST mutation is pending', () => {
+    expect(
+      isReindexButtonLoading({
+        mutationPending: true,
+        deadline: null,
+        status: false,
+      }),
+    ).toBe(true);
+  });
+
+  it('does NOT load post-cap: deadline nulled but reindexing left stale-true', () => {
+    // The key case: after the poll cap fires `reindexDeadline` is null while
+    // `settings.reindexing` can be a stale `true` from the last poll. Gating on
+    // the deadline keeps the spinner from sticking forever so the admin can
+    // restart.
+    expect(
+      isReindexButtonLoading({
+        mutationPending: false,
+        deadline: null,
+        status: true,
+      }),
+    ).toBe(false);
+  });
+
+  it('loads during an active run within the poll window', () => {
+    expect(
+      isReindexButtonLoading({
+        mutationPending: false,
+        deadline: 10_000,
+        status: true,
+      }),
+    ).toBe(true);
+  });
+
+  it('does not load once the run finished while still polling', () => {
+    expect(
+      isReindexButtonLoading({
+        mutationPending: false,
+        deadline: 10_000,
+        status: false,
+      }),
+    ).toBe(false);
+  });
+});

apps/client/src/features/workspace/components/settings/components/ai-provider-settings.tsx

@@ -37,6 +37,7 @@ import {
 } from "@/features/workspace/queries/ai-settings-query.ts";
 import {
   AiTestCapability,
+  IAiSettings,
   IAiSettingsUpdate,
   SttApiStyle,
   ChatApiStyle,
@@ -169,6 +170,71 @@ export function resolveKeyField(
   return { set: false };
 }
 
+// Subset of the status payload that drives the reindex poll decisions.
+type ReindexStatus = Pick<
+  IAiSettings,
+  "reindexing" | "indexedPages" | "totalPages"
+>;
+
+/**
+ * Decide the TanStack Query `refetchInterval` while a reindex may be running.
+ * Returns the poll interval (ms) to keep polling, or `false` to stop.
+ *
+ * Polls while the server reports an ACTIVE run (`reindexing === true`) OR we are
+ * still within the deadline window and not yet fully indexed. Stops once the run
+ * has finished AND everything is indexed (server cleared its progress record and
+ * fell back to the DB coverage count), or the deadline cap is hit — the cap
+ * always wins so a stuck/never-clearing progress record can't poll forever.
+ */
+export function nextReindexPollInterval(args: {
+  deadline: number | null;
+  now: number;
+  intervalMs: number;
+  status?: ReindexStatus;
+}): number | false {
+  const { deadline, now, intervalMs, status } = args;
+  if (deadline === null) return false;
+  // Cap always wins.
+  if (now > deadline) return false;
+  // Active run → keep polling even if the momentary counts already look full.
+  if (status?.reindexing) return intervalMs;
+  // Finished and fully indexed (incl. an empty workspace, 0 >= 0) → stop.
+  if (status && status.indexedPages >= status.totalPages) return false;
+  // Within the deadline and not yet done → keep polling.
+  return intervalMs;
+}
+
+/**
+ * Whether the reindex poll deadline should be cleared: the server reports no
+ * active run AND the count is complete. Mirrors the stop condition of
+ * `nextReindexPollInterval` (sans the cap, which the effect handles via time).
+ */
+export function isReindexComplete(status?: ReindexStatus): boolean {
+  return (
+    !!status && !status.reindexing && status.indexedPages >= status.totalPages
+  );
+}
+
+/**
+ * Whether the reindex button should show its spinner (and stay disabled).
+ *
+ * Spins while the POST is in flight, and for the WHOLE background run while the
+ * server reports `reindexing === true`. The `deadline !== null` gate is the
+ * load-bearing part: once the 120s poll cap fires it nulls `reindexDeadline`
+ * and stops refetching, so `status` (settings?.reindexing) can be a stale
+ * `true` from the last poll. Without the gate the spinner would stick forever
+ * for a run that outlives the cap and block a restart; gating on the active
+ * poll window clears it so the admin can re-trigger.
+ */
+export function isReindexButtonLoading(args: {
+  mutationPending: boolean;
+  deadline: number | null;
+  status?: boolean;
+}): boolean {
+  const { mutationPending, deadline, status } = args;
+  return mutationPending || (deadline !== null && status === true);
+}
+
 // Translate the dot's tooltip label. Kept in one place so all three endpoint
 // cards share identical wording.
 function cardStatusLabel(status: CardStatus, t: (k: string) => string): string {
@@ -215,31 +281,34 @@ export default function AiProviderSettings() {
   // PRE-job counts immediately, so the only way the "Indexed X of Y" counter
   // visibly climbs is to keep polling the settings query while the job runs.
   // `reindexDeadline` is the timestamp until which we poll (set on reindex
-  // success); polling stops early once indexed === total. Bounded so a stuck
+  // success). Polling tracks the server's `reindexing` flag: it keeps going for
-  // job can never poll forever.
+  // the whole active run and stops promptly once the server reports the run is
-  const REINDEX_POLL_INTERVAL = 3000; // ms between refetches while indexing
+  // finished. Bounded by the cap so a stuck/never-clearing progress record can
+  // never poll forever.
+  const REINDEX_POLL_INTERVAL = 5000; // ms between refetches while indexing
   const REINDEX_POLL_CAP_MS = 120000; // ~2 min hard cap
   const [reindexDeadline, setReindexDeadline] = useState<number | null>(null);
 
   // Only admins may read the (masked) AI settings; the server enforces this too.
-  const { data: settings, isLoading } = useAiSettingsQuery(isAdmin, (query) => {
+  const { data: settings, isLoading } = useAiSettingsQuery(isAdmin, (query) =>
-    if (reindexDeadline === null) return false;
+    nextReindexPollInterval({
-    // Past the cap → stop polling (cleared via the effect below too).
+      deadline: reindexDeadline,
-    if (Date.now() > reindexDeadline) return false;
+      now: Date.now(),
-    const data = query.state.data;
+      intervalMs: REINDEX_POLL_INTERVAL,
-    // Stop once everything is indexed; otherwise keep polling.
+      status: query.state.data,
-    if (data && data.indexedPages >= data.totalPages) return false;
+    }),
-    return REINDEX_POLL_INTERVAL;
+  );
-  });
 
-  // Stop polling once the work is done or the cap is reached. Also clears on
+  // Stop polling once the run is finished or the cap is reached. Also clears on
   // unmount because the deadline state goes away with the component.
   useEffect(() => {
     if (reindexDeadline === null) return;
-    // "Done" matches the refetchInterval stop condition (indexed >= total),
+    // "Done" matches the refetchInterval stop condition: the server reports no
-    // including an empty workspace (0 >= 0), so the deadline clears promptly
+    // active run AND the count is complete (indexed >= total, incl. an empty
-    // instead of waiting out the cap.
+    // workspace 0 >= 0), so the deadline clears promptly instead of waiting out
-    if (settings && settings.indexedPages >= settings.totalPages) {
+    // the cap. While `reindexing` is still true we keep the deadline so polling
+    // continues for the whole run.
+    if (isReindexComplete(settings)) {
       setReindexDeadline(null);
       return;
     }
@@ -1031,7 +1100,17 @@ export default function AiProviderSettings() {
             <Button
               variant="subtle"
               size="compact-sm"
-              loading={reindexMutation.isPending}
+              // Spin for the WHOLE run: the POST resolves immediately, but the
+              // background job keeps running, so also stay loading while the
+              // server reports `reindexing` (this also blocks a redundant
+              // re-trigger mid-run; the server de-dupes regardless). The
+              // deadline gate (and why it matters post-cap) lives in
+              // `isReindexButtonLoading`, which is unit-tested.
+              loading={isReindexButtonLoading({
+                mutationPending: reindexMutation.isPending,
+                deadline: reindexDeadline,
+                status: settings?.reindexing,
+              })}
               onClick={() =>
                 reindexMutation.mutate(undefined, {
                   // Begin bounded polling so the counter climbs as the async

apps/client/src/features/workspace/queries/ai-settings-query.ts

@@ -23,8 +23,12 @@ export function useAiSettingsQuery(
   enabled: boolean = true,
   // While reindexing runs as an async background job, the counter only climbs
   // if the client keeps refetching. The component passes a refetchInterval
-  // function that polls until indexed === total or a bounded deadline, then
+  // function (`nextReindexPollInterval`) that keeps polling while the server
-  // returns false to stop. See AiProviderSettings.
+  // reports an active run (reindexing === true) OR we are still within the
+  // bounded deadline and not yet fully indexed; it returns false to stop only
+  // once the run has finished AND indexed >= total, or the deadline cap is hit
+  // (the cap always wins). Note: a transient indexed === total during an active
+  // run does NOT stop polling. See AiProviderSettings.
   refetchInterval?:
     | number
     | false

apps/client/src/features/workspace/services/ai-settings-service.ts

@@ -48,6 +48,9 @@ export interface IAiSettings {
   // RAG indexing coverage (pages indexed for semantic search).
   indexedPages: number;
   totalPages: number;
+  // True while a full workspace reindex is actively running; the counts above
+  // then reflect the live run progress (done climbs 0 -> total).
+  reindexing?: boolean;
 }
 
 // Update payload. Key semantics (same for `apiKey` and `embeddingApiKey`):

apps/server/package.json

@@ -125,7 +125,6 @@
     "typesense": "^3.0.5",
     "undici": "7.24.0",
     "ws": "^8.20.1",
-    "yaml": "^2.8.3",
     "yauzl": "^3.2.1",
     "zod": "^4.3.6"
   },

apps/server/src/app.module.ts

@@ -28,7 +28,6 @@ import { ClsModule } from 'nestjs-cls';
 import { NoopAuditModule } from './integrations/audit/audit.module';
 import { ThrottleModule } from './integrations/throttle/throttle.module';
 import { McpModule } from './integrations/mcp/mcp.module';
-import { SandboxModule } from './integrations/sandbox/sandbox.module';
 import { AiModule } from './integrations/ai/ai.module';
 import { AiChatModule } from './core/ai-chat/ai-chat.module';
 
@@ -90,7 +89,6 @@ try {
     TelemetryModule,
     ThrottleModule,
     McpModule,
-    SandboxModule,
     AiModule,
     AiChatModule,
     ...enterpriseModules,

apps/server/src/core/ai-chat/embedding/embedding-indexer.service.spec.ts

@@ -3,6 +3,8 @@ import { PageRepo } from '@docmost/db/repos/page/page.repo';
 import { PageEmbeddingRepo } from '@docmost/db/repos/ai-chat/page-embedding.repo';
 import { KyselyDB } from '@docmost/db/types/kysely.types';
 import { AiService } from '../../../integrations/ai/ai.service';
+import { EmbeddingReindexProgressService } from '../../../integrations/ai/embedding-reindex-progress.service';
+import { AiEmbeddingNotConfiguredException } from '../../../integrations/ai/ai-embedding-not-configured.exception';
 
 /**
  * Unit tests for EmbeddingIndexerService.reindexWorkspace's batch control flow.
@@ -12,7 +14,8 @@ import { AiService } from '../../../integrations/ai/ai.service';
  * reindexWorkspace actually touches:
  *   - aiService.getEmbeddingModel -> a model string so the up-front configured
  *     check passes,
- *   - pageRepo.getIdsByWorkspace -> three page ids,
+ *   - pageRepo.getEmbeddablePageIds -> three page ids (the embeddable set the
+ *     reindex iterates),
  *   - service.reindexPage -> spied per test to drive the per-page outcome.
  *
  * The point under test is the catch block: a FATAL provider error (auth/billing)
@@ -24,21 +27,30 @@ describe('EmbeddingIndexerService.reindexWorkspace fail-fast', () => {
 
   function makeService() {
     const pageRepo = {
-      getIdsByWorkspace: jest.fn().mockResolvedValue(['p1', 'p2', 'p3']),
+      getEmbeddablePageIds: jest.fn().mockResolvedValue(['p1', 'p2', 'p3']),
     };
     const pageEmbeddingRepo = {};
     const aiService = {
       getEmbeddingModel: jest.fn().mockResolvedValue('some-model'),
     };
+    // Progress is a best-effort cosmetic store; mock its async methods so the
+    // batch control flow can be tested without Redis.
+    const reindexProgress = {
+      start: jest.fn().mockResolvedValue(undefined),
+      increment: jest.fn().mockResolvedValue(undefined),
+      clear: jest.fn().mockResolvedValue(undefined),
+      get: jest.fn().mockResolvedValue(null),
+    };
     const db = {};
 
     const service = new EmbeddingIndexerService(
       pageRepo as unknown as PageRepo,
       pageEmbeddingRepo as unknown as PageEmbeddingRepo,
       aiService as unknown as AiService,
+      reindexProgress as unknown as EmbeddingReindexProgressService,
       db as unknown as KyselyDB,
     );
-    return { service, pageRepo, aiService };
+    return { service, pageRepo, aiService, reindexProgress };
   }
 
   it('aborts after the first page on a FATAL (401) provider error', async () => {
@@ -78,3 +90,100 @@ describe('EmbeddingIndexerService.reindexWorkspace fail-fast', () => {
     expect(reindexPage).toHaveBeenCalledTimes(3);
   });
 });
+
+/**
+ * Live reindex-progress reporting: reindexWorkspace must publish a per-workspace
+ * progress record (total at start, done incremented per processed page) and ALWAYS
+ * clear it in a finally — including on a fatal abort and an unconfigured early
+ * return — so the settings status can show the counter climb without ever getting
+ * stuck in a "reindexing" state.
+ */
+describe('EmbeddingIndexerService.reindexWorkspace progress', () => {
+  const WORKSPACE_ID = 'ws-1';
+
+  function makeService(pageIds: string[] = ['p1', 'p2', 'p3']) {
+    const pageRepo = {
+      getEmbeddablePageIds: jest.fn().mockResolvedValue(pageIds),
+    };
+    const pageEmbeddingRepo = {};
+    const aiService = {
+      getEmbeddingModel: jest.fn().mockResolvedValue('some-model'),
+    };
+    const reindexProgress = {
+      start: jest.fn().mockResolvedValue(undefined),
+      increment: jest.fn().mockResolvedValue(undefined),
+      clear: jest.fn().mockResolvedValue(undefined),
+      get: jest.fn().mockResolvedValue(null),
+    };
+    const db = {};
+    const service = new EmbeddingIndexerService(
+      pageRepo as unknown as PageRepo,
+      pageEmbeddingRepo as unknown as PageEmbeddingRepo,
+      aiService as unknown as AiService,
+      reindexProgress as unknown as EmbeddingReindexProgressService,
+      db as unknown as KyselyDB,
+    );
+    return { service, pageRepo, aiService, reindexProgress };
+  }
+
+  it('sets total at start, increments done per page, and clears in finally', async () => {
+    const { service, reindexProgress } = makeService(['p1', 'p2', 'p3']);
+    jest.spyOn(service, 'reindexPage').mockResolvedValue(undefined);
+
+    await service.reindexWorkspace(WORKSPACE_ID);
+
+    expect(reindexProgress.start).toHaveBeenCalledWith(WORKSPACE_ID, 3);
+    // One increment per processed page.
+    expect(reindexProgress.increment).toHaveBeenCalledTimes(3);
+    expect(reindexProgress.increment).toHaveBeenCalledWith(WORKSPACE_ID);
+    // Cleared exactly once on completion.
+    expect(reindexProgress.clear).toHaveBeenCalledTimes(1);
+    expect(reindexProgress.clear).toHaveBeenCalledWith(WORKSPACE_ID);
+  });
+
+  it('counts a handled (non-fatal) per-page failure as processed', async () => {
+    const { service, reindexProgress } = makeService(['p1', 'p2', 'p3']);
+    // No statusCode -> non-fatal -> isolate and continue; each counts as done.
+    jest.spyOn(service, 'reindexPage').mockRejectedValue(new Error('boom'));
+
+    await service.reindexWorkspace(WORKSPACE_ID);
+
+    expect(reindexProgress.increment).toHaveBeenCalledTimes(3);
+    expect(reindexProgress.clear).toHaveBeenCalledTimes(1);
+  });
+
+  it('clears progress in finally even when a FATAL provider error aborts the batch', async () => {
+    const { service, reindexProgress } = makeService(['p1', 'p2', 'p3']);
+    // A 401 aborts on the first page (re-thrown) — the finally must still clear.
+    jest
+      .spyOn(service, 'reindexPage')
+      .mockRejectedValue({ statusCode: 401, message: 'User not found' });
+
+    await expect(service.reindexWorkspace(WORKSPACE_ID)).rejects.toMatchObject({
+      statusCode: 401,
+    });
+
+    expect(reindexProgress.start).toHaveBeenCalledWith(WORKSPACE_ID, 3);
+    // Aborted page is NOT counted as processed.
+    expect(reindexProgress.increment).not.toHaveBeenCalled();
+    // But progress is still cleared so the run never gets stuck.
+    expect(reindexProgress.clear).toHaveBeenCalledTimes(1);
+  });
+
+  it('clears the enqueue-seeded progress on an unconfigured early return', async () => {
+    const { service, aiService, reindexProgress } = makeService();
+    // Embeddings not configured: reindexWorkspace returns early WITHOUT starting
+    // a fresh record, but the finally must still clear the enqueue-time seed.
+    aiService.getEmbeddingModel = jest
+      .fn()
+      .mockRejectedValue(new AiEmbeddingNotConfiguredException());
+
+    await expect(
+      service.reindexWorkspace(WORKSPACE_ID),
+    ).resolves.toBeUndefined();
+
+    expect(reindexProgress.start).not.toHaveBeenCalled();
+    expect(reindexProgress.clear).toHaveBeenCalledTimes(1);
+    expect(reindexProgress.clear).toHaveBeenCalledWith(WORKSPACE_ID);
+  });
+});

apps/server/src/core/ai-chat/embedding/embedding-indexer.service.ts

@@ -9,6 +9,7 @@ import { KyselyDB } from '@docmost/db/types/kysely.types';
 import { InjectKysely } from 'nestjs-kysely';
 import { executeTx } from '@docmost/db/utils';
 import { AiService } from '../../../integrations/ai/ai.service';
+import { EmbeddingReindexProgressService } from '../../../integrations/ai/embedding-reindex-progress.service';
 import { AiEmbeddingNotConfiguredException } from '../../../integrations/ai/ai-embedding-not-configured.exception';
 import {
   describeProviderError,
@@ -48,6 +49,7 @@ export class EmbeddingIndexerService {
     private readonly pageRepo: PageRepo,
     private readonly pageEmbeddingRepo: PageEmbeddingRepo,
     private readonly aiService: AiService,
+    private readonly reindexProgress: EmbeddingReindexProgressService,
     @InjectKysely() private readonly db: KyselyDB,
   ) {}
 
@@ -183,9 +185,17 @@ export class EmbeddingIndexerService {
   }
 
   /**
-   * (Re)build embeddings for EVERY non-deleted page in a workspace. Used by the
+   * (Re)build embeddings for the EMBEDDABLE page set of a workspace — the same
-   * bulk reindex (WORKSPACE_CREATE_EMBEDDINGS, fired when AI Search is enabled
+   * set countEmbeddablePages counts (via getEmbeddablePageIds): non-deleted pages
-   * and by the manual "Reindex now" action).
+   * that have non-empty textContent OR already have a stored embedding row, NOT
+   * every non-deleted page. Iterating this set keeps the live `total` equal to
+   * the steady-state denominator, so the progress counter climbs 0 -> total and
+   * matches the before/after DB coverage exactly. Text-less pages are correctly
+   * skipped (reindexPage no-ops on them); a page that lost its text but still has
+   * stale embeddings stays in the set (the EXISTS clause) so it is visited and
+   * its stale rows are cleared. Used by the bulk reindex
+   * (WORKSPACE_CREATE_EMBEDDINGS, fired when AI Search is enabled and by the
+   * manual "Reindex now" action).
    *
    * Resolves the embeddings model once up front: if the workspace has no
    * embeddings provider configured, the whole batch is skipped (otherwise each
@@ -194,6 +204,13 @@ export class EmbeddingIndexerService {
    * the batch.
    */
   async reindexWorkspace(workspaceId: string): Promise<void> {
+    // The whole run is wrapped so the per-workspace progress record is ALWAYS
+    // cleared in the finally — on success, on a fatal-provider abort, on an
+    // unconfigured early-return, or on any unexpected throw — so a failed run
+    // never leaves a stuck "reindexing" state (the status then falls back to the
+    // steady-state DB coverage count). A placeholder record may already exist
+    // (seeded at enqueue time); the finally cleans that too.
+    try {
       try {
         await this.aiService.getEmbeddingModel(workspaceId);
       } catch (err) {
@@ -206,9 +223,20 @@ export class EmbeddingIndexerService {
         throw err;
       }
 
-    const pageIds = await this.pageRepo.getIdsByWorkspace(workspaceId);
+      // Iterate the EMBEDDABLE set (same predicate as countEmbeddablePages), NOT
+      // every non-deleted page: this makes `total` here equal the steady-state
+      // denominator, so the live counter climbs 0 -> total and matches the
+      // before/after DB count exactly (no 478 -> 500 -> 478 denominator jump).
+      // Text-less pages are correctly skipped — reindexPage no-ops on them, and
+      // a page that lost its text but still has stale embeddings IS in this set
+      // (the EXISTS clause) so it is still visited and its stale rows cleared.
+      const pageIds = await this.pageRepo.getEmbeddablePageIds(workspaceId);
       const total = pageIds.length;
       const startedAt = Date.now();
+      // Publish the live run progress over this same set (done reset to 0). The
+      // counter increments once per iterated page and reaches exactly `total`,
+      // which equals countEmbeddablePages — the steady-state denominator.
+      await this.reindexProgress.start(workspaceId, total);
       this.logger.log(
         `reindexWorkspace: starting reindex of ${total} page(s) for workspace ${workspaceId}`,
       );
@@ -225,6 +253,8 @@ export class EmbeddingIndexerService {
         const pageStartedAt = Date.now();
         try {
           await this.reindexPage(pageId);
+          // Count this page as processed (matches the [position/total] log).
+          await this.reindexProgress.increment(workspaceId);
           const elapsed = Date.now() - pageStartedAt;
           if (elapsed >= SLOW_PAGE_MS) {
             this.logger.warn(
@@ -234,7 +264,8 @@ export class EmbeddingIndexerService {
         } catch (err) {
           // A fatal provider error (invalid/missing key, no credits) recurs
           // identically on EVERY remaining page. Abort the whole batch instead of
-        // issuing hundreds of doomed requests against the provider.
+          // issuing hundreds of doomed requests against the provider. Do NOT count
+          // it as processed — the run aborts here (the finally clears progress).
           if (isFatalProviderError(err)) {
             this.logger.error(
               `reindexWorkspace: aborting at [${position}/${total}] for workspace ` +
@@ -244,8 +275,10 @@ export class EmbeddingIndexerService {
             throw err;
           }
           // Per-page isolation: one non-fatal failure (incl. an embedding timeout)
-        // must not abort the whole batch.
+          // must not abort the whole batch. A handled failure still advances the
+          // counter (matches the [position/total] log, so done reaches total).
           failed++;
+          await this.reindexProgress.increment(workspaceId);
           this.logger.error(
             `reindexWorkspace: [${position}/${total}] failed to reindex page ${pageId} ` +
               `after ${Date.now() - pageStartedAt}ms: ${describeProviderError(err)}`,
@@ -257,6 +290,10 @@ export class EmbeddingIndexerService {
         `reindexWorkspace: done for workspace ${workspaceId}: ` +
           `${total - failed}/${total} indexed, ${failed} failed in ${Date.now() - startedAt}ms`,
       );
+    } finally {
+      // Always remove the progress record so the status reverts to the DB count.
+      await this.reindexProgress.clear(workspaceId);
+    }
   }
 
   /** Purge ALL embeddings for a workspace (WORKSPACE_DELETE_EMBEDDINGS). */

apps/server/src/core/ai-chat/roles/ai-agent-roles.service.ts

@@ -187,7 +187,7 @@ export class AiAgentRolesService {
   }
 
   // -------------------------------------------------------------------------
-  // Catalog (admin-only). The catalog is curated, untrusted YAML fetched +
+  // Catalog (admin-only). The catalog is curated, untrusted JSON fetched +
   // validated by AiAgentRolesCatalogProvider; this layer resolves localized
   // text and reconciles a bundle against the workspace's existing roles.
   // -------------------------------------------------------------------------

apps/server/src/core/ai-chat/roles/catalog/ai-agent-roles-catalog.provider.spec.ts

@@ -1,23 +1,12 @@
 import { BadGatewayException, BadRequestException } from '@nestjs/common';
-import { readFileSync } from 'node:fs';
+import { AiAgentRolesCatalogProvider } from './ai-agent-roles-catalog.provider';
-import { join } from 'node:path';
-import { parse as parseYaml, stringify as stringifyYaml } from 'yaml';
-import {
-  AiAgentRolesCatalogProvider,
-  isCatalogBundleFile,
-  isCatalogIndex,
-  isCatalogRole,
-} from './ai-agent-roles-catalog.provider';
 
 /**
  * Provider tests against a mocked remote source (no network). They cover the
- * happy read path (fetchIndex / fetchBundle) over the YAML catalog format, the
+ * happy read path (fetchIndex / fetchBundle), the malformed-shape rejection,
- * block-scalar `instructions` round-trip, the malformed-shape rejection, the
+ * rejection of non-http(s) sources (local sources are gone), and — most
- * malformed-YAML rejection, rejection of non-http(s) sources (local sources are
+ * importantly — the `^[a-z0-9-]+$` path-traversal guard that runs BEFORE any
- * gone), and — most importantly — the `^[a-z0-9-]+$` path-traversal guard that
+ * path/URL is built.
- * runs BEFORE any path/URL is built. Fixtures are serialized with the same
- * `yaml` library the provider parses with (`stringifyYaml`), so the tests
- * exercise real YAML, not the JSON subset.
  */
 describe('AiAgentRolesCatalogProvider', () => {
   function makeProvider(source: string) {
@@ -82,7 +71,7 @@ describe('AiAgentRolesCatalogProvider', () => {
     }
 
     it('fetchBundle remote happy path => parses + validates', async () => {
-      const yaml = stringifyYaml({
+      const json = JSON.stringify({
         schemaVersion: 1,
         language: 'en',
         roles: [
@@ -93,7 +82,7 @@ describe('AiAgentRolesCatalogProvider', () => {
           },
         ],
       });
-      const body = streamOf([new TextEncoder().encode(yaml)]);
+      const body = streamOf([new TextEncoder().encode(json)]);
       global.fetch = jest
         .fn()
         .mockResolvedValue(mockResponse({ body })) as never;
@@ -103,12 +92,12 @@ describe('AiAgentRolesCatalogProvider', () => {
     });
 
     it('fetchBundle remote malformed (role missing instructions) => BadGateway', async () => {
-      const yaml = stringifyYaml({
+      const json = JSON.stringify({
         schemaVersion: 1,
         language: 'fr',
         roles: [{ slug: 'researcher', name: 'Chercheur' }],
       });
-      const body = streamOf([new TextEncoder().encode(yaml)]);
+      const body = streamOf([new TextEncoder().encode(json)]);
       global.fetch = jest
         .fn()
         .mockResolvedValue(mockResponse({ body })) as never;
@@ -164,9 +153,8 @@ describe('AiAgentRolesCatalogProvider', () => {
         );
       global.fetch = fetchMock as never;
       const provider = makeProvider('https://catalog.example.com');
-      // Body shape is irrelevant; an empty stream parses to an empty YAML doc
+      // Body shape is irrelevant; an empty stream parses to invalid JSON and
-      // (null), fails the shape guard and throws, but the fetch call (with its
+      // throws, but the fetch call (with its init) still happened.
-      // init) still happened.
       await expect(provider.fetchIndex()).rejects.toBeDefined();
       expect(fetchMock).toHaveBeenCalledWith(
         expect.any(String),
@@ -202,7 +190,7 @@ describe('AiAgentRolesCatalogProvider', () => {
     });
 
     it('small streamed body parses normally (cap not hit)', async () => {
-      const yaml = stringifyYaml({
+      const json = JSON.stringify({
         schemaVersion: 1,
         bundles: [
           {
@@ -213,7 +201,7 @@ describe('AiAgentRolesCatalogProvider', () => {
           },
         ],
       });
-      const body = streamOf([new TextEncoder().encode(yaml)]);
+      const body = streamOf([new TextEncoder().encode(json)]);
       global.fetch = jest
         .fn()
         .mockResolvedValue(mockResponse({ body })) as never;
@@ -239,7 +227,7 @@ describe('AiAgentRolesCatalogProvider', () => {
     });
 
     it('null body (no readable stream) => response.text() fallback parses', async () => {
-      const yaml = stringifyYaml({
+      const json = JSON.stringify({
         schemaVersion: 1,
         bundles: [
           {
@@ -252,7 +240,7 @@ describe('AiAgentRolesCatalogProvider', () => {
       });
       global.fetch = jest
         .fn()
-        .mockResolvedValue(mockResponse({ body: null, text: yaml })) as never;
+        .mockResolvedValue(mockResponse({ body: null, text: json })) as never;
       const provider = makeProvider('https://catalog.example.com');
       const index = await provider.fetchIndex();
       expect(index.bundles[0].id).toBe('general');
@@ -271,12 +259,8 @@ describe('AiAgentRolesCatalogProvider', () => {
       );
     });
 
-    it('invalid YAML body => BadGateway (parse failure)', async () => {
+    it('invalid JSON body => BadGateway (parse failure)', async () => {
-      // An unterminated flow mapping is not valid YAML, so YAML.parse throws and
+      const body = streamOf([new TextEncoder().encode('{not valid json')]);
-      // the provider maps it to BadGateway (not a generic 500).
-      const body = streamOf([
-        new TextEncoder().encode('schemaVersion: {not: closed'),
-      ]);
       global.fetch = jest
         .fn()
         .mockResolvedValue(mockResponse({ body })) as never;
@@ -286,28 +270,11 @@ describe('AiAgentRolesCatalogProvider', () => {
       );
     });
 
-    it('YAML with a duplicate key (strict) => BadGateway (parse failure)', async () => {
+    it('malformed index.json (valid JSON, wrong shape) => BadGateway', async () => {
-      // strict:true rejects duplicate mapping keys rather than last-wins coercing
+      // Parses as JSON but fails isCatalogIndex (schemaVersion not a number).
-      // them — a defensive parse on untrusted input.
       const body = streamOf([
         new TextEncoder().encode(
-          'schemaVersion: 1\nbundles: []\nschemaVersion: 2\n',
+          JSON.stringify({ schemaVersion: 'x', bundles: [] }),
-        ),
-      ]);
-      global.fetch = jest
-        .fn()
-        .mockResolvedValue(mockResponse({ body })) as never;
-      const provider = makeProvider('https://catalog.example.com');
-      await expect(provider.fetchIndex()).rejects.toBeInstanceOf(
-        BadGatewayException,
-      );
-    });
-
-    it('malformed index.yaml (valid YAML, wrong shape) => BadGateway', async () => {
-      // Parses as YAML but fails isCatalogIndex (schemaVersion not a number).
-      const body = streamOf([
-        new TextEncoder().encode(
-          stringifyYaml({ schemaVersion: 'x', bundles: [] }),
         ),
       ]);
       global.fetch = jest
@@ -316,36 +283,6 @@ describe('AiAgentRolesCatalogProvider', () => {
       const provider = makeProvider('https://catalog.example.com');
       await expect(provider.fetchIndex()).rejects.toThrow(/malformed/i);
     });
-
-    it('block-scalar instructions round-trips to the exact multi-line string', async () => {
-      // The whole point of the YAML migration: a long `instructions` prompt is
-      // stored as a literal block scalar (|-) for line-by-line diffs, and must
-      // resolve byte-for-byte to the original multi-line string.
-      const instructions = [
-        'Line one of the prompt.',
-        '',
-        '  Indented bullet that must survive.',
-        'Final line, no trailing newline.',
-      ].join('\n');
-      const yaml = stringifyYaml(
-        {
-          schemaVersion: 1,
-          language: 'en',
-          roles: [{ slug: 'researcher', name: 'Researcher', instructions }],
-        },
-        { lineWidth: 0 },
-      );
-      // Sanity: the fixture really uses a literal block scalar (|, optionally
-      // with an indentation indicator), not a flow/quoted string.
-      expect(yaml).toMatch(/instructions: \|/);
-      const body = streamOf([new TextEncoder().encode(yaml)]);
-      global.fetch = jest
-        .fn()
-        .mockResolvedValue(mockResponse({ body })) as never;
-      const provider = makeProvider('https://catalog.example.com');
-      const bundle = await provider.fetchBundle('research', 'en');
-      expect(bundle.roles[0].instructions).toBe(instructions);
-    });
   });
 
   describe('path-traversal / SSRF guard (^[a-z0-9-]+$)', () => {
@@ -367,93 +304,4 @@ describe('AiAgentRolesCatalogProvider', () => {
       });
     }
   });
-
-  // ---------------------------------------------------------------------------
-  // Pin the REAL shipped catalog files (not synthetic fixtures). The JSON->YAML
-  // migration was a hand conversion, so the realistic failure is a hand-edit
-  // error in one of the 5 content YAML files (the index + the four per-bundle/
-  // lang files: index.yaml plus bundles/{editorial,research}/{en,ru}.yaml) — a
-  // quote/colon in a description, a broken
-  // emoji/arrow, a block-scalar indent slip that silently changes or drops
-  // instructions). Nothing else in CI parses these files — `scripts/check.mjs`
-  // is not wired into any turbo/husky/CI step — so this is the only automated
-  // guard over the shipped content. We read them straight off disk, parse with
-  // the SAME options the provider uses (strict + maxAliasCount, see parseYaml in
-  // the provider), and run them through the provider's own type guards. A future
-  // edit that breaks a real file fails here.
-  // ---------------------------------------------------------------------------
-  describe('real shipped catalog files (the YAML migration must not break them)', () => {
-    // Spec lives at apps/server/src/core/ai-chat/roles/catalog/; the catalog
-    // ships at the repo root (agent-roles-catalog/) — seven levels up.
-    const CATALOG_DIR = join(
-      __dirname,
-      '../../../../../../../agent-roles-catalog',
-    );
-    // Match the provider's parseYaml exactly (untrusted-input parse options).
-    const PARSE_OPTS = { strict: true, maxAliasCount: 100 } as const;
-
-    function readCatalogYaml(rel: string): unknown {
-      return parseYaml(readFileSync(join(CATALOG_DIR, rel), 'utf8'), PARSE_OPTS);
-    }
-
-    // Load + validate the real index lazily (only when a test runs), so a broken
-    // real file fails ONLY these catalog tests — not collection of the entire
-    // spec, which also holds the unrelated mocked-remote provider tests above.
-    function loadRealIndex() {
-      const parsed = readCatalogYaml('index.yaml');
-      if (!isCatalogIndex(parsed)) {
-        throw new Error('Real index.yaml is not a valid catalog index');
-      }
-      return parsed;
-    }
-
-    it('index.yaml parses + validates with the provider guard', () => {
-      expect(isCatalogIndex(readCatalogYaml('index.yaml'))).toBe(true);
-    });
-
-    it('editorial bundle still ships the fact-checker role', () => {
-      const editorial = loadRealIndex().bundles.find((b) => b.id === 'editorial');
-      expect(editorial).toBeDefined();
-      expect(editorial?.roles.map((r) => r.slug)).toContain('fact-checker');
-    });
-
-    // Driven by the real index (read inside the test, so it's lazy): every
-    // declared bundle + language file must parse, validate, and be in EXACT slug
-    // correspondence with the index — every declared role present AND no
-    // undeclared extras — mirroring scripts/check.mjs, which requires both
-    // directions. A bundle or language added later is covered automatically.
-    it('every declared bundle/language file is valid and in exact slug correspondence', () => {
-      const index = loadRealIndex();
-      // Guard against an empty index silently passing the loops below.
-      expect(index.bundles.length).toBeGreaterThan(0);
-      for (const bundle of index.bundles) {
-        const declaredSlugs = bundle.roles.map((r) => r.slug);
-        expect(bundle.languages.length).toBeGreaterThan(0);
-        for (const lang of bundle.languages) {
-          const rel = `bundles/${bundle.id}/${lang}.yaml`;
-          const file = readCatalogYaml(rel);
-          expect(isCatalogBundleFile(file)).toBe(true);
-          // Narrow for TS and access fields safely.
-          if (!isCatalogBundleFile(file)) continue;
-          expect(file.language).toBe(lang);
-          const fileSlugs = file.roles.map((r) => r.slug);
-          // Existing direction: every declared role is present in the file.
-          for (const slug of declaredSlugs) {
-            expect(fileSlugs).toContain(slug);
-          }
-          // Symmetric direction: the file carries NO undeclared/extra roles, so
-          // file slugs and declared slugs must be the SAME set (exact match).
-          // Catches a hand-edit that copies a stray role into a bundle file.
-          expect([...fileSlugs].sort()).toEqual([...declaredSlugs].sort());
-          expect(file.roles.length).toBeGreaterThan(0);
-          for (const role of file.roles) {
-            expect(isCatalogRole(role)).toBe(true);
-            expect(typeof role.instructions).toBe('string');
-            expect(role.instructions.trim().length).toBeGreaterThan(0);
-            expect(role.name.trim().length).toBeGreaterThan(0);
-          }
-        }
-      }
-    });
-  });
 });

apps/server/src/core/ai-chat/roles/catalog/ai-agent-roles-catalog.provider.ts

@@ -4,7 +4,6 @@ import {
   Injectable,
   Logger,
 } from '@nestjs/common';
-import { parse as parseYamlDoc } from 'yaml';
 import { EnvironmentService } from '../../../../integrations/environment/environment.service';
 import {
   CatalogBundleFile,
@@ -29,11 +28,9 @@ const MAX_BYTES = 1_000_000;
  * base URL — REMOTE only; local-filesystem sources are no longer supported. The
  * value is baked into the Docker image at build time (set per-branch in CI).
  *
- * The catalog is UNTRUSTED input: every file is YAML-parsed with a SAFE schema
+ * The catalog is UNTRUSTED input: every file is JSON-parsed and run through a
- * (standard JSON-compatible tags only — no custom `!!` tags / no code execution)
+ * hand-written type guard before any field is exposed, and every dynamic path
- * and run through a hand-written type guard before any field is exposed, and
+ * segment is validated against SEGMENT_RE up front (path-traversal + SSRF).
- * every dynamic path segment is validated against SEGMENT_RE up front
- * (path-traversal + SSRF).
  */
 @Injectable()
 export class AiAgentRolesCatalogProvider {
@@ -41,19 +38,19 @@ export class AiAgentRolesCatalogProvider {
 
   constructor(private readonly environmentService: EnvironmentService) {}
 
-  /** Read + validate the top-level index (`index.yaml`). */
+  /** Read + validate the top-level index (`index.json`). */
   async fetchIndex(): Promise<CatalogIndex> {
-    const raw = await this.readRelative('index.yaml');
+    const raw = await this.readRelative('index.json');
-    const parsed = this.parseYaml(raw, 'index.yaml');
+    const parsed = this.parseJson(raw, 'index.json');
     if (!isCatalogIndex(parsed)) {
       throw new BadGatewayException(
-        'Agent roles catalog index is malformed (index.yaml)',
+        'Agent roles catalog index is malformed (index.json)',
       );
     }
     return parsed;
   }
 
-  /** Read + validate one language file (`bundles/<bundleId>/<language>.yaml`). */
+  /** Read + validate one language file (`bundles/<bundleId>/<language>.json`). */
   async fetchBundle(
     bundleId: string,
     language: string,
@@ -61,9 +58,9 @@ export class AiAgentRolesCatalogProvider {
     // SECURITY: validate BEFORE building any path/URL (path-traversal + SSRF).
     this.assertSegment(bundleId, 'bundleId');
     this.assertSegment(language, 'language');
-    const rel = `bundles/${bundleId}/${language}.yaml`;
+    const rel = `bundles/${bundleId}/${language}.json`;
     const raw = await this.readRelative(rel);
-    const parsed = this.parseYaml(raw, rel);
+    const parsed = this.parseJson(raw, rel);
     if (!isCatalogBundleFile(parsed)) {
       throw new BadGatewayException(
         `Agent roles catalog bundle is malformed (${rel})`,
@@ -79,29 +76,15 @@ export class AiAgentRolesCatalogProvider {
     }
   }
 
-  /**
+  /** JSON.parse with a clear BadGateway on malformed content. */
-   * Safe YAML parse with a clear BadGateway on malformed content. The catalog is
+  private parseJson(raw: string, rel: string): unknown {
-   * untrusted, so we lean on the `yaml` library's default `core` schema, which
-   * only produces JSON-compatible values (objects/arrays/strings/numbers/
-   * booleans/null) and NEVER constructs arbitrary types or runs code — there is
-   * no `!!js`-style tag handling. `strict: true` rejects duplicate keys instead
-   * of silently coercing them. (Note: in yaml@2.8.x an unknown custom tag does
-   * NOT throw even under `strict` — the parser logs a warning and resolves the
-   * node to a plain scalar; the catalog stays safe because the default schema
-   * never builds arbitrary types from a tag and our hand-written type guards
-   * reject any value of the wrong shape.) The alias-expansion guard
-   * (`maxAliasCount`) bounds billion-laughs blow-ups (the 1 MB streaming
-   * cap already limits the input itself). JSON is a YAML subset, so a leftover
-   * `.json`-style body still parses here too.
-   */
-  private parseYaml(raw: string, rel: string): unknown {
     try {
-      return parseYamlDoc(raw, { strict: true, maxAliasCount: 100 });
+      return JSON.parse(raw);
     } catch (err) {
       const reason = shortError(err);
-      this.logger.error(`Agent roles catalog YAML parse failed (${rel}): ${reason}`);
+      this.logger.error(`Agent roles catalog JSON parse failed (${rel}): ${reason}`);
       throw new BadGatewayException(
-        `Agent roles catalog file is not valid YAML (${rel}): ${reason}`,
+        `Agent roles catalog file is not valid JSON (${rel}): ${reason}`,
       );
     }
   }

apps/server/src/core/ai-chat/roles/catalog/catalog-types.ts

@@ -1,8 +1,7 @@
 /**
- * Catalog wire shapes. The catalog is curated, untrusted YAML (a GitHub repo or
+ * Catalog wire shapes. The catalog is curated, untrusted JSON (a GitHub repo or
  * a local folder), so every shape is validated by a hand-written type guard in
- * the provider before any field is used — no zod on the server (YAML is parsed
+ * the provider before any field is used — no zod / new deps on the server.
- * with the `yaml` library's safe, JSON-compatible schema).
  *
  * Localized fields (`name` / `description` at the bundle level) are
  * `Record<language, string>` so one bundle serves many UI languages; per-role
@@ -23,7 +22,7 @@ export interface CatalogRole {
   modelConfig?: Record<string, unknown> | null;
 }
 
-/** A single language file: `bundles/<id>/<language>.yaml`. */
+/** A single language file: `bundles/<id>/<language>.json`. */
 export interface CatalogBundleFile {
   schemaVersion: number;
   language: string;
@@ -41,7 +40,7 @@ export interface CatalogBundleMeta {
   roles: { slug: string; version: number }[];
 }
 
-/** Top-level catalog index: `index.yaml`. */
+/** Top-level catalog index: `index.json`. */
 export interface CatalogIndex {
   schemaVersion: number;
   bundles: CatalogBundleMeta[];

apps/server/src/core/ai-chat/tools/ai-chat-tools.service.spec.ts

@@ -63,12 +63,6 @@ describe('AiChatToolsService deletePage guardrail (H4)', () => {
       {} as never,
       {} as never,
       {} as never,
-      // sandboxStore: forUser() eagerly calls asSink() to wire the stash tool,
-      // even though these tests never execute it — return a no-op sink so the
-      // tool wiring in forUser() succeeds.
-      {
-        asSink: () => ({ put: jest.fn(), has: jest.fn(), evict: jest.fn() }),
-      } as never,
     );
   });
 
@@ -181,12 +175,6 @@ describe('AiChatToolsService expanded toolset guardrails', () => {
       {} as never,
       {} as never,
       {} as never,
-      // sandboxStore: forUser() eagerly calls asSink() to wire the stash tool,
-      // even though these tests never execute it — return a no-op sink so the
-      // tool wiring in forUser() succeeds.
-      {
-        asSink: () => ({ put: jest.fn(), has: jest.fn(), evict: jest.fn() }),
-      } as never,
     );
   });
 
@@ -302,12 +290,6 @@ describe('AiChatToolsService node-arg JSON-string coercion', () => {
       {} as never,
       {} as never,
       {} as never,
-      // sandboxStore: forUser() eagerly calls asSink() to wire the stash tool,
-      // even though these tests never execute it — return a no-op sink so the
-      // tool wiring in forUser() succeeds.
-      {
-        asSink: () => ({ put: jest.fn(), has: jest.fn(), evict: jest.fn() }),
-      } as never,
     );
   });
 
@@ -458,12 +440,6 @@ describe('AiChatToolsService model-friendly input validation (#190)', () => {
       {} as never,
       {} as never,
       {} as never,
-      // sandboxStore: forUser() eagerly calls asSink() to wire the stash tool,
-      // even though these tests never execute it — return a no-op sink so the
-      // tool wiring in forUser() succeeds.
-      {
-        asSink: () => ({ put: jest.fn(), has: jest.fn(), evict: jest.fn() }),
-      } as never,
     );
   });
 

apps/server/src/core/ai-chat/tools/ai-chat-tools.service.ts

@@ -16,7 +16,6 @@ import {
 import { resolveCurrentPageResult } from './current-page.util';
 import { parseNodeArg } from './parse-node-arg';
 import { modelFriendlyInput } from './model-friendly-input';
-import { SandboxStore } from '../../../integrations/sandbox/sandbox.store';
 
 /**
  * Per-user, per-request adapter that exposes Docmost READ operations to the
@@ -42,8 +41,6 @@ export class AiChatToolsService {
     private readonly pageEmbeddingRepo: PageEmbeddingRepo,
     private readonly spaceMemberRepo: SpaceMemberRepo,
     private readonly pagePermissionRepo: PagePermissionRepo,
-    // Shared singleton in-RAM blob store backing the stash tool.
-    private readonly sandboxStore: SandboxStore,
   ) {}
 
   async forUser(
@@ -89,17 +86,11 @@ export class AiChatToolsService {
         aiChatId,
       });
 
-    // Bind the stash tool to the shared in-RAM SandboxStore. The store owns the
-    // anonymous-URL composition (putAndLink) and the live/evict probes the MCP
-    // package needs to keep its mirror counts honest under FIFO eviction (the
-    // package never touches env or the store). asSink() centralizes the uri↔id
-    // mapping next to putAndLink, shared with the embedded-MCP wiring site.
     const { DocmostClient, sharedToolSpecs } = await loadDocmostMcp();
     const client: DocmostClientLike = new DocmostClient({
       apiUrl,
       getToken,
       getCollabToken,
-      sandbox: this.sandboxStore.asSink(),
     });
 
     // Build an ai-SDK tool from a shared, zod-agnostic spec. The spec owns the
@@ -634,14 +625,6 @@ export class AiChatToolsService {
         async ({ pageId, edits }) => await client.editPageText(pageId, edits),
       ),
 
-      // Returns ONLY the short link object — never the document body — so a
-      // large page can be handed to an external consumer without bloating
-      // context.
-      stashPage: sharedTool(
-        sharedToolSpecs.stashPage,
-        async ({ pageId }) => await client.stashPage(pageId),
-      ),
-
       patchNode: tool({
         description:
           'Replace a single content block (by id) with a new ProseMirror ' +

apps/server/src/core/ai-chat/tools/docmost-client.loader.ts

@@ -154,14 +154,6 @@ export interface DocmostClientLike {
     commentId: string,
     resolved: boolean,
   ): Promise<Record<string, unknown>>;
-  // Serialize a page + mirror its internal images into the blob sandbox; returns
-  // ONLY a short anonymous URL (the body never enters the model context).
-  stashPage(pageId: string): Promise<{
-    uri: string;
-    sha256: string;
-    size: number;
-    images: { mirrored: number; failed: number };
-  }>;
 }
 
 export type DocmostClientConfig = {
@@ -169,18 +161,6 @@ export type DocmostClientConfig = {
   getToken: () => Promise<string>;
   // Provenance collab-token provider for content mutations (signed agent claim).
   getCollabToken?: () => Promise<string>;
-  // Optional blob-sandbox sink for the stash tool. `put` stores a blob in the
-  // host's in-RAM SandboxStore and returns the anonymous read URL + integrity.
-  // The optional `has`/`evict` probes let stashPage keep its mirror counts
-  // honest under the store's FIFO eviction (mirror of the package's sink type).
-  sandbox?: {
-    put: (
-      buf: Buffer,
-      mime: string,
-    ) => { uri: string; sha256: string; size: number };
-    has?: (uri: string) => boolean;
-    evict?: (uri: string) => void;
-  };
 };
 
 export interface DocmostClientCtor {

apps/server/src/database/repos/page/page.repo.ts

@@ -12,6 +12,7 @@ import { executeWithCursorPagination } from '@docmost/db/pagination/cursor-pagin
 import { validate as isValidUUID } from 'uuid';
 import { ExpressionBuilder, sql } from 'kysely';
 import { DB } from '@docmost/db/types/db';
+import { DbInterface } from '@docmost/db/types/db.interface';
 import { jsonArrayFrom, jsonObjectFrom } from 'kysely/helpers/postgres';
 import { SpaceMemberRepo } from '@docmost/db/repos/space/space-member.repo';
 import { EventEmitter2 } from '@nestjs/event-emitter';
@@ -243,8 +244,28 @@ export class PageRepo {
       .selectFrom('pages as p')
       .where('p.workspaceId', '=', workspaceId)
       .where('p.deletedAt', 'is', null)
-      .where((eb) =>
+      .where((eb) => this.embeddablePredicate(eb))
-        eb.or([
+      .select((eb) => eb.fn.countAll().as('count'))
+      .executeTakeFirst();
+    return Number(row?.count ?? 0);
+  }
+
+  /**
+   * The "embeddable content" qualifying predicate, shared verbatim by
+   * countEmbeddablePages (the steady-state denominator) and getEmbeddablePageIds
+   * (the set the bulk reindex iterates). Both MUST use the exact same condition
+   * or the live total and steady-state total diverge — extracting it here is what
+   * guarantees that, replacing the previous hand-duplicated copy. Callers supply
+   * the trivial workspaceId/deletedAt filters inline; this returns only the
+   * non-trivial OR clause, evaluated against the `p` alias of `pages`.
+   *
+   * A page qualifies if it has non-empty textContent OR already has a stored
+   * (non-deleted) embedding row.
+   */
+  private embeddablePredicate(
+    eb: ExpressionBuilder<DbInterface & { p: DbInterface['pages'] }, 'p'>,
+  ) {
+    return eb.or([
       // Has extractable body text. The regex matches any non-whitespace
       // character, mirroring the indexer's `text.trim().length === 0` check
       // (raw SQL -> use the snake_case column name).
@@ -257,23 +278,34 @@ export class PageRepo {
           .whereRef('pe.pageId', '=', 'p.id')
           .where('pe.deletedAt', 'is', null),
       ),
-        ]),
+    ]);
-      )
-      .select((eb) => eb.fn.countAll().as('count'))
-      .executeTakeFirst();
-    return Number(row?.count ?? 0);
   }
 
   /**
-   * IDs of all non-deleted pages in a workspace. Used by the RAG bulk reindex to
+   * IDs of the EMBEDDABLE page set for a workspace — the exact same set that
-   * (re)build embeddings for every existing page.
+   * `countEmbeddablePages` counts (a page qualifies if it has non-empty
+   * textContent OR already has a stored embedding row). The bulk reindex
+   * iterates THIS set so the live "done" counter reaches exactly
+   * `countEmbeddablePages` (the steady-state denominator), instead of iterating
+   * every non-deleted page (which would push the denominator above the
+   * steady-state value mid-run).
+   *
+   * IMPORTANT: the qualifying WHERE is shared with `countEmbeddablePages` via the
+   * private `embeddablePredicate` helper, so the two can no longer drift — if the
+   * embeddable definition changes, change it once there and both stay in lockstep
+   * (else the live total and steady-state total diverge again). Dropping
+   * text-less pages is correct: `reindexPage` no-ops on
+   * a page with no extractable content anyway, and a page that lost its text but
+   * still has stale embeddings IS in this set (the EXISTS clause), so it is still
+   * visited and its stale rows are cleared.
    */
-  async getIdsByWorkspace(workspaceId: string): Promise<string[]> {
+  async getEmbeddablePageIds(workspaceId: string): Promise<string[]> {
     const rows = await this.db
-      .selectFrom('pages')
+      .selectFrom('pages as p')
-      .select('id')
+      .select('p.id')
-      .where('workspaceId', '=', workspaceId)
+      .where('p.workspaceId', '=', workspaceId)
-      .where('deletedAt', 'is', null)
+      .where('p.deletedAt', 'is', null)
+      .where((eb) => this.embeddablePredicate(eb))
       .execute();
     return rows.map((r) => r.id);
   }

apps/server/src/integrations/ai/ai-settings.service.spec.ts

@@ -1,4 +1,12 @@
-import { parsePositiveInt } from './ai-settings.service';
+import { AiSettingsService, parsePositiveInt } from './ai-settings.service';
+import { WorkspaceRepo } from '@docmost/db/repos/workspace/workspace.repo';
+import { AiAgentRoleRepo } from '@docmost/db/repos/ai-agent-roles/ai-agent-roles.repo';
+import { AiProviderCredentialsRepo } from '@docmost/db/repos/ai-chat/ai-provider-credentials.repo';
+import { PageEmbeddingRepo } from '@docmost/db/repos/ai-chat/page-embedding.repo';
+import { PageRepo } from '@docmost/db/repos/page/page.repo';
+import { SecretBoxService } from '../crypto/secret-box';
+import { EmbeddingReindexProgressService } from './embedding-reindex-progress.service';
+import type { Queue } from 'bullmq';
 
 /**
  * Round-trip coercion for numeric `::text` provider settings (e.g.
@@ -41,3 +49,180 @@ describe('parsePositiveInt', () => {
     expect(parsePositiveInt(42)).toBe(42);
   });
 });
+
+/**
+ * getMasked must surface the LIVE reindex run progress while a reindex is active
+ * (so the "Indexed X of Y" counter can climb 0 -> total), and fall back to the
+ * steady-state DB coverage count (countIndexedPages / countEmbeddablePages) when
+ * no reindex is running. This is the server side of the fix for the counter that
+ * otherwise stays stuck at "478 of 478" the whole reindex.
+ */
+describe('AiSettingsService.getMasked reindex progress', () => {
+  const WORKSPACE_ID = 'ws-1';
+
+  function makeService() {
+    // No driver configured -> the credentials lookup is skipped, keeping the
+    // setup minimal; we only care about the indexed/total numbers here.
+    const workspaceRepo = {
+      findById: jest.fn().mockResolvedValue({ settings: {} }),
+    };
+    const aiAgentRoleRepo = {};
+    const aiProviderCredentialsRepo = { find: jest.fn() };
+    const pageEmbeddingRepo = {
+      countIndexedPages: jest.fn().mockResolvedValue(478),
+    };
+    const pageRepo = {
+      countEmbeddablePages: jest.fn().mockResolvedValue(478),
+    };
+    const secretBox = {};
+    const reindexProgress = {
+      get: jest.fn().mockResolvedValue(null),
+    };
+    const aiQueue = {};
+
+    const service = new AiSettingsService(
+      workspaceRepo as unknown as WorkspaceRepo,
+      aiAgentRoleRepo as unknown as AiAgentRoleRepo,
+      aiProviderCredentialsRepo as unknown as AiProviderCredentialsRepo,
+      pageEmbeddingRepo as unknown as PageEmbeddingRepo,
+      pageRepo as unknown as PageRepo,
+      secretBox as unknown as SecretBoxService,
+      reindexProgress as unknown as EmbeddingReindexProgressService,
+      aiQueue as unknown as Queue,
+    );
+    return { service, reindexProgress, pageEmbeddingRepo };
+  }
+
+  it('reports the live run numbers when a reindex progress record is active', async () => {
+    const { service, reindexProgress } = makeService();
+    // Use a progress.total (500) DISTINCT from the DB count (478) so the test
+    // actually pins the progress.total branch rather than coincidentally
+    // matching the DB fallback. With fix #1 the two sources agree in practice,
+    // but getMasked must still return progress.total when a record is active.
+    reindexProgress.get.mockResolvedValue({
+      total: 500,
+      done: 120,
+      startedAt: Date.now(),
+    });
+
+    const masked = await service.getMasked(WORKSPACE_ID);
+
+    expect(masked.indexedPages).toBe(120); // progress.done, not DB 478
+    expect(masked.totalPages).toBe(500); // progress.total, not DB 478
+    expect(masked.reindexing).toBe(true);
+  });
+
+  it('falls back to countIndexedPages when no reindex is active', async () => {
+    const { service, reindexProgress } = makeService();
+    reindexProgress.get.mockResolvedValue(null);
+
+    const masked = await service.getMasked(WORKSPACE_ID);
+
+    expect(masked.indexedPages).toBe(478);
+    expect(masked.totalPages).toBe(478);
+    expect(masked.reindexing).toBe(false);
+  });
+});
+
+/**
+ * reindex() must seed a live progress record (done=0) BEFORE enqueueing so the
+ * first status poll shows 0 — but ONLY when no run is already active, since
+ * aiQueue.add() de-duplicates a running reindex and a re-seed would reset the
+ * visible counter to 0 while the live worker keeps incrementing from its real
+ * position.
+ */
+describe('AiSettingsService.reindex progress seed', () => {
+  const WORKSPACE_ID = 'ws-1';
+
+  function makeService() {
+    const order: string[] = [];
+    const aiQueue = {
+      remove: jest.fn().mockResolvedValue(undefined),
+      add: jest.fn().mockImplementation(async () => {
+        order.push('add');
+      }),
+    };
+    const pageRepo = {
+      countEmbeddablePages: jest.fn().mockResolvedValue(478),
+    };
+    const reindexProgress = {
+      // Default: no active run -> seed should happen.
+      get: jest.fn().mockResolvedValue(null),
+      start: jest.fn().mockImplementation(async () => {
+        order.push('start');
+      }),
+      clear: jest.fn().mockResolvedValue(undefined),
+    };
+
+    const service = new AiSettingsService(
+      {} as unknown as WorkspaceRepo,
+      {} as unknown as AiAgentRoleRepo,
+      {} as unknown as AiProviderCredentialsRepo,
+      {} as unknown as PageEmbeddingRepo,
+      pageRepo as unknown as PageRepo,
+      {} as unknown as SecretBoxService,
+      reindexProgress as unknown as EmbeddingReindexProgressService,
+      aiQueue as unknown as Queue,
+    );
+    return { service, aiQueue, pageRepo, reindexProgress, order };
+  }
+
+  it('seeds progress (workspace, count) BEFORE enqueue when no run is active', async () => {
+    const { service, aiQueue, reindexProgress, order } = makeService();
+
+    await service.reindex(WORKSPACE_ID);
+
+    expect(reindexProgress.start).toHaveBeenCalledWith(WORKSPACE_ID, 478);
+    expect(aiQueue.add).toHaveBeenCalledTimes(1);
+    // Seed must precede the enqueue so the first poll already reports done=0.
+    expect(order).toEqual(['start', 'add']);
+  });
+
+  it('does NOT re-seed when a run is already active (mid-run re-trigger)', async () => {
+    const { service, aiQueue, reindexProgress } = makeService();
+    // An active record exists -> a second click must not reset the counter.
+    reindexProgress.get.mockResolvedValue({
+      total: 478,
+      done: 120,
+      startedAt: Date.now(),
+    });
+
+    await service.reindex(WORKSPACE_ID);
+
+    expect(reindexProgress.start).not.toHaveBeenCalled();
+    // The enqueue still runs (and de-duplicates against the active job).
+    expect(aiQueue.add).toHaveBeenCalledTimes(1);
+  });
+
+  it('clears the seed it just wrote and re-throws when enqueue fails', async () => {
+    const { service, aiQueue, reindexProgress } = makeService();
+    // This call seeds (get() is null) but the enqueue then blows up
+    // (Redis hiccup/shutdown) -> the worker never runs and never clear()s, so
+    // reindex() must roll back its own seed to avoid a 1h stuck "reindexing".
+    const boom = new Error('redis down');
+    aiQueue.add.mockRejectedValue(boom);
+
+    await expect(service.reindex(WORKSPACE_ID)).rejects.toBe(boom);
+
+    expect(reindexProgress.start).toHaveBeenCalledWith(WORKSPACE_ID, 478);
+    expect(reindexProgress.clear).toHaveBeenCalledWith(WORKSPACE_ID);
+  });
+
+  it('does NOT clear a concurrent active run when enqueue fails (no seed)', async () => {
+    const { service, aiQueue, reindexProgress } = makeService();
+    // A run is already active, so THIS call does not seed; if the enqueue then
+    // fails it must NOT wipe the live worker's record.
+    reindexProgress.get.mockResolvedValue({
+      total: 478,
+      done: 120,
+      startedAt: Date.now(),
+    });
+    const boom = new Error('redis down');
+    aiQueue.add.mockRejectedValue(boom);
+
+    await expect(service.reindex(WORKSPACE_ID)).rejects.toBe(boom);
+
+    expect(reindexProgress.start).not.toHaveBeenCalled();
+    expect(reindexProgress.clear).not.toHaveBeenCalled();
+  });
+});

apps/server/src/integrations/ai/ai-settings.service.ts

@@ -8,6 +8,7 @@ import { AiProviderCredentialsRepo } from '@docmost/db/repos/ai-chat/ai-provider
 import { PageEmbeddingRepo } from '@docmost/db/repos/ai-chat/page-embedding.repo';
 import { PageRepo } from '@docmost/db/repos/page/page.repo';
 import { SecretBoxService } from '../crypto/secret-box';
+import { EmbeddingReindexProgressService } from './embedding-reindex-progress.service';
 import {
   AiDriver,
   AiProviderSettings,
@@ -74,6 +75,7 @@ export class AiSettingsService {
     private readonly pageEmbeddingRepo: PageEmbeddingRepo,
     private readonly pageRepo: PageRepo,
     private readonly secretBox: SecretBoxService,
+    private readonly reindexProgress: EmbeddingReindexProgressService,
     @InjectQueue(QueueName.AI_QUEUE) private readonly aiQueue: Queue,
   ) {}
 
@@ -100,12 +102,32 @@ export class AiSettingsService {
       .remove(`ai-search-disabled-${workspaceId}`)
       .catch(() => undefined);
 
+    // Seed a live progress record BEFORE enqueueing so the very first status
+    // poll already reports done=0 (the reindex POST returns the PRE-job counts,
+    // so without this seed the first poll would still show "total of total").
+    // `totalPages` uses countEmbeddablePages — the SAME set the worker iterates
+    // and the SAME denominator the status endpoint reports, so the live and
+    // steady-state totals match.
+    //
+    // ONLY seed when no run is active: aiQueue.add() de-duplicates an already-
+    // running reindex, so a mid-run re-trigger (second click / second admin /
+    // second tab) must NOT reset the visible counter to 0 — that would
+    // understate the live worker's real position for the rest of the run. The
+    // worker's own start() at run begin is the single authoritative reset.
+    let seeded = false;
+    if ((await this.reindexProgress.get(workspaceId)) === null) {
+      const totalPages = await this.pageRepo.countEmbeddablePages(workspaceId);
+      await this.reindexProgress.start(workspaceId, totalPages);
+      seeded = true;
+    }
+
     const jobId = `ai-reindex-${workspaceId}`;
     // Clear a prior non-active entry so a stale job can't block this reindex.
     // A locked/active job is left in place (remove() no-ops) and the add() below
     // de-duplicates against it, keeping the in-progress pass.
     await this.aiQueue.remove(jobId).catch(() => undefined);
 
+    try {
       await this.aiQueue.add(
         QueueJob.WORKSPACE_CREATE_EMBEDDINGS,
         { workspaceId },
@@ -115,6 +137,17 @@ export class AiSettingsService {
           removeOnFail: true,
         },
       );
+    } catch (err) {
+      // If the enqueue fails (Redis hiccup/shutdown) the worker never runs, so
+      // its finally->clear() never fires. Roll back the seed WE just wrote so
+      // the status endpoint doesn't report a stuck "reindexing: 0 of N" for the
+      // full TTL. Only clear when this call did the seed — never wipe a
+      // concurrent active run's record (get() was non-null, seeded=false).
+      if (seeded) {
+        await this.reindexProgress.clear(workspaceId);
+      }
+      throw err;
+    }
   }
 
   /**
@@ -261,6 +294,15 @@ export class AiSettingsService {
       this.pageRepo.countEmbeddablePages(workspaceId),
     ]);
 
+    // While a reindex run is active, report its LIVE progress (done climbs 0 ->
+    // total) so the settings UI can watch it advance. Without this the counter
+    // never drops: the per-page reindex hard-replaces rows in its own small
+    // transaction, so countIndexedPages stays ~= total for the whole run. With
+    // no active record we fall back to the steady-state DB coverage count, which
+    // preserves the existing display and the client's "done == total -> stop
+    // polling" condition (the run ends -> record cleared -> DB count == total).
+    const progress = await this.reindexProgress.get(workspaceId);
+
     return {
       driver: provider.driver,
       chatModel: provider.chatModel,
@@ -279,8 +321,10 @@ export class AiSettingsService {
       hasApiKey,
       hasEmbeddingApiKey,
       hasSttApiKey,
-      indexedPages,
+      indexedPages: progress ? progress.done : indexedPages,
-      totalPages,
+      totalPages: progress ? progress.total : totalPages,
+      // Optional hint for the client: a reindex run is currently in progress.
+      reindexing: progress != null,
     };
   }
 

apps/server/src/integrations/ai/ai.module.ts

@@ -5,6 +5,7 @@ import { QueueName } from '../queue/constants';
 import { AiService } from './ai.service';
 import { AiSettingsService } from './ai-settings.service';
 import { AiSettingsController } from './ai-settings.controller';
+import { EmbeddingReindexProgressService } from './embedding-reindex-progress.service';
 
 /**
  * LLM driver + provider-settings unit (§6.2/§6.4).
@@ -19,7 +20,7 @@ import { AiSettingsController } from './ai-settings.controller';
     BullModule.registerQueue({ name: QueueName.AI_QUEUE }),
   ],
   controllers: [AiSettingsController],
-  providers: [AiService, AiSettingsService],
+  providers: [AiService, AiSettingsService, EmbeddingReindexProgressService],
-  exports: [AiService, AiSettingsService],
+  exports: [AiService, AiSettingsService, EmbeddingReindexProgressService],
 })
 export class AiModule {}

apps/server/src/integrations/ai/ai.types.ts

@@ -146,4 +146,7 @@ export interface MaskedAiSettings {
   // RAG indexing coverage for the settings UI.
   indexedPages: number;
   totalPages: number;
+  // True while a full workspace reindex is actively running (the counts above
+  // then reflect the live run progress rather than the steady-state DB count).
+  reindexing?: boolean;
 }

apps/server/src/integrations/ai/embedding-reindex-progress.service.spec.ts

@@ -0,0 +1,163 @@
+import { EmbeddingReindexProgressService } from './embedding-reindex-progress.service';
+import type { RedisService } from '@nestjs-labs/nestjs-ioredis';
+import type { Redis } from 'ioredis';
+
+/**
+ * Unit tests for the Redis-backed reindex-progress store.
+ *
+ * The store is a thin, BEST-EFFORT wrapper: writes (start/increment) issue an
+ * hset/hincrby + expire pipeline and must SWALLOW Redis errors (progress is
+ * cosmetic — it must never break a reindex); reads (get) must map a valid hash
+ * to a ReindexProgress and degrade to null on a malformed/missing record or a
+ * Redis failure. We drive it with a hand-rolled fake ioredis (the project mocks
+ * Redis with plain fakes, see public-share limiter specs).
+ */
+describe('EmbeddingReindexProgressService', () => {
+  const WORKSPACE_ID = 'ws-1';
+  const KEY = 'ai:reindex:progress:ws-1';
+
+  /**
+   * Build a fake ioredis whose `multi()` returns a chainable recorder and whose
+   * `hgetall`/`del` are configurable jest mocks. `execImpl` lets a test make the
+   * pipeline reject (to assert error-swallowing).
+   */
+  function makeRedis(opts: { execImpl?: () => Promise<unknown> } = {}) {
+    const exec = jest
+      .fn()
+      .mockImplementation(opts.execImpl ?? (() => Promise.resolve([])));
+    // mockReturnThis() returns the call's `this` (the multi object), so the
+    // chain hset().expire().exec() resolves correctly.
+    const multiObj = {
+      hset: jest.fn().mockReturnThis(),
+      hincrby: jest.fn().mockReturnThis(),
+      expire: jest.fn().mockReturnThis(),
+      exec,
+    };
+    const multi = jest.fn(() => multiObj);
+    const hgetall = jest.fn().mockResolvedValue({});
+    const del = jest.fn().mockResolvedValue(1);
+    const redis = { multi, hgetall, del } as unknown as Redis;
+    return { redis, multiObj, multi, hgetall, del, exec };
+  }
+
+  function makeService(redis: Redis) {
+    const redisService = {
+      getOrThrow: () => redis,
+    } as unknown as RedisService;
+    return new EmbeddingReindexProgressService(redisService);
+  }
+
+  describe('get', () => {
+    it('maps a valid hash to a ReindexProgress object', async () => {
+      const { redis, hgetall } = makeRedis();
+      hgetall.mockResolvedValue({ total: '478', done: '120', startedAt: '1000' });
+      const service = makeService(redis);
+
+      await expect(service.get(WORKSPACE_ID)).resolves.toEqual({
+        total: 478,
+        done: 120,
+        startedAt: 1000,
+      });
+      expect(hgetall).toHaveBeenCalledWith(KEY);
+    });
+
+    it('returns null for an empty hash (no record)', async () => {
+      const { redis, hgetall } = makeRedis();
+      hgetall.mockResolvedValue({});
+      await expect(makeService(redis).get(WORKSPACE_ID)).resolves.toBeNull();
+    });
+
+    it('returns null when `total` is missing (partial record)', async () => {
+      const { redis, hgetall } = makeRedis();
+      hgetall.mockResolvedValue({ done: '5' });
+      await expect(makeService(redis).get(WORKSPACE_ID)).resolves.toBeNull();
+    });
+
+    it('returns null for a non-numeric total', async () => {
+      const { redis, hgetall } = makeRedis();
+      hgetall.mockResolvedValue({ total: 'abc', done: '1', startedAt: '1' });
+      await expect(makeService(redis).get(WORKSPACE_ID)).resolves.toBeNull();
+    });
+
+    it('returns null for a non-numeric done', async () => {
+      const { redis, hgetall } = makeRedis();
+      hgetall.mockResolvedValue({ total: '10', done: 'xyz', startedAt: '1' });
+      await expect(makeService(redis).get(WORKSPACE_ID)).resolves.toBeNull();
+    });
+
+    it('coerces a non-finite startedAt to 0', async () => {
+      const { redis, hgetall } = makeRedis();
+      hgetall.mockResolvedValue({ total: '10', done: '2', startedAt: 'nope' });
+      await expect(makeService(redis).get(WORKSPACE_ID)).resolves.toEqual({
+        total: 10,
+        done: 2,
+        startedAt: 0,
+      });
+    });
+
+    it('degrades to null when hgetall throws (degradation contract)', async () => {
+      const { redis, hgetall } = makeRedis();
+      hgetall.mockRejectedValue(new Error('redis down'));
+      await expect(makeService(redis).get(WORKSPACE_ID)).resolves.toBeNull();
+    });
+  });
+
+  describe('start', () => {
+    it('issues hset + expire on the workspace key', async () => {
+      const { redis, multiObj } = makeRedis();
+      await makeService(redis).start(WORKSPACE_ID, 478);
+
+      expect(multiObj.hset).toHaveBeenCalledWith(
+        KEY,
+        expect.objectContaining({ total: '478', done: '0' }),
+      );
+      expect(multiObj.expire).toHaveBeenCalledWith(KEY, expect.any(Number));
+      expect(multiObj.exec).toHaveBeenCalledTimes(1);
+    });
+
+    it('swallows a thrown Redis error (best-effort)', async () => {
+      const { redis } = makeRedis({
+        execImpl: () => Promise.reject(new Error('redis down')),
+      });
+      await expect(
+        makeService(redis).start(WORKSPACE_ID, 1),
+      ).resolves.toBeUndefined();
+    });
+  });
+
+  describe('increment', () => {
+    it('issues hincrby + expire on the workspace key', async () => {
+      const { redis, multiObj } = makeRedis();
+      await makeService(redis).increment(WORKSPACE_ID);
+
+      expect(multiObj.hincrby).toHaveBeenCalledWith(KEY, 'done', 1);
+      expect(multiObj.expire).toHaveBeenCalledWith(KEY, expect.any(Number));
+      expect(multiObj.exec).toHaveBeenCalledTimes(1);
+    });
+
+    it('swallows a thrown Redis error (best-effort)', async () => {
+      const { redis } = makeRedis({
+        execImpl: () => Promise.reject(new Error('redis down')),
+      });
+      await expect(
+        makeService(redis).increment(WORKSPACE_ID),
+      ).resolves.toBeUndefined();
+    });
+  });
+
+  describe('clear', () => {
+    it('deletes the workspace key', async () => {
+      const { redis, del } = makeRedis();
+      await makeService(redis).clear(WORKSPACE_ID);
+      expect(del).toHaveBeenCalledWith(KEY);
+    });
+
+    it('swallows a thrown Redis error (best-effort)', async () => {
+      const { redis, del } = makeRedis();
+      del.mockRejectedValue(new Error('redis down'));
+      await expect(
+        makeService(redis).clear(WORKSPACE_ID),
+      ).resolves.toBeUndefined();
+    });
+  });
+});

apps/server/src/integrations/ai/embedding-reindex-progress.service.ts

@@ -0,0 +1,149 @@
+import { Injectable, Logger } from '@nestjs/common';
+import { RedisService } from '@nestjs-labs/nestjs-ioredis';
+import type { Redis } from 'ioredis';
+
+/**
+ * Live progress of an in-flight workspace embeddings reindex run.
+ * `total` is the number of pages the run will process, `done` how many it has
+ * already processed (success OR handled failure), `startedAt` the epoch-ms the
+ * record was created.
+ */
+export interface ReindexProgress {
+  total: number;
+  done: number;
+  startedAt: number;
+}
+
+/** Redis key namespace for the per-workspace reindex-progress record. */
+const KEY_PREFIX = 'ai:reindex:progress:';
+
+/**
+ * TTL (seconds) on the progress record so a crashed/aborted worker that never
+ * reaches its `clear()` finally can still self-clean instead of leaving a stuck
+ * "reindexing" state. Refreshed on every increment so a long run never expires
+ * mid-flight; on a crash it disappears within TTL of the last processed page.
+ *
+ * INTENTIONALLY tied to WRITE progress (start/increment) only — never refreshed
+ * on get(). Refreshing on read would keep a dead worker's record alive forever
+ * as long as a client keeps polling (a permanently stuck reindexing:true). The
+ * clear() in the worker's finally handles normal completion; a dead worker's
+ * record expires after TTL, and the client's own poll cap stops polling anyway.
+ */
+const TTL_SECONDS = 60 * 60; // 1h
+
+/**
+ * Cluster-wide store for the live progress of a workspace embeddings reindex.
+ *
+ * The reindex runs in a BullMQ worker (AI_QUEUE) that may be a DIFFERENT process
+ * than the API handling the settings-status GET, so the progress must live in
+ * the shared Redis — we reuse the same global ioredis client (RedisService from
+ * @nestjs-labs/nestjs-ioredis) that backs BullMQ and the other anti-abuse
+ * limiters, adding NO new Redis config.
+ *
+ * Everything here is best-effort and COSMETIC: progress only drives the "Indexed
+ * X of Y" counter while a reindex is running. Any Redis failure degrades to the
+ * existing steady-state behaviour (the status falls back to the DB coverage
+ * count), so reads fail to `null` and writes are swallowed — a reindex must
+ * never break because progress reporting did.
+ *
+ * Stored as a Redis HASH so `done` can be bumped with an atomic HINCRBY (the
+ * worker is the only writer of `done`, but HINCRBY also keeps us off a
+ * read-modify-write race and preserves the other fields).
+ */
+@Injectable()
+export class EmbeddingReindexProgressService {
+  private readonly logger = new Logger(EmbeddingReindexProgressService.name);
+  private readonly redis: Redis;
+
+  constructor(redisService: RedisService) {
+    this.redis = redisService.getOrThrow();
+  }
+
+  private key(workspaceId: string): string {
+    return KEY_PREFIX + workspaceId;
+  }
+
+  /**
+   * Begin (or reset) the progress record for a workspace: `total` pages, `done`
+   * back to 0, `startedAt` now. Called at reindex enqueue time (placeholder
+   * total, so the very first status poll already reports done=0) and again at
+   * the worker start (overwriting `total` with the real page count). Resets
+   * `done` to 0 so a re-trigger never inherits a stale count.
+   */
+  async start(workspaceId: string, total: number): Promise<void> {
+    const key = this.key(workspaceId);
+    try {
+      await this.redis
+        .multi()
+        .hset(key, {
+          total: String(total),
+          done: '0',
+          startedAt: String(Date.now()),
+        })
+        .expire(key, TTL_SECONDS)
+        .exec();
+    } catch (err) {
+      this.logger.warn(
+        `reindex-progress start failed for workspace ${workspaceId}; ` +
+          `progress reporting disabled for this run: ${(err as Error).message}`,
+      );
+    }
+  }
+
+  /**
+   * Bump the processed-page counter by one and refresh the TTL. Atomic and
+   * best-effort: a missing key (cleared/expired) would be recreated with only
+   * `done`, but `get()` treats a record without a numeric `total` as inactive,
+   * so that partial state safely reads as "no active reindex".
+   */
+  async increment(workspaceId: string): Promise<void> {
+    const key = this.key(workspaceId);
+    try {
+      await this.redis.multi().hincrby(key, 'done', 1).expire(key, TTL_SECONDS).exec();
+    } catch (err) {
+      this.logger.warn(
+        `reindex-progress increment failed for workspace ${workspaceId}: ` +
+          `${(err as Error).message}`,
+      );
+    }
+  }
+
+  /**
+   * Remove the progress record. Called in the worker's `finally` so a completed,
+   * aborted, or unconfigured-early-return run never leaves a stuck record; the
+   * status then falls back to the DB coverage count.
+   */
+  async clear(workspaceId: string): Promise<void> {
+    try {
+      await this.redis.del(this.key(workspaceId));
+    } catch (err) {
+      this.logger.warn(
+        `reindex-progress clear failed for workspace ${workspaceId} ` +
+          `(self-cleans via TTL): ${(err as Error).message}`,
+      );
+    }
+  }
+
+  /**
+   * Read the live progress, or `null` when no reindex is active (no record, an
+   * expired record, or a partial record without a numeric `total`). On a Redis
+   * error returns `null` so the status endpoint degrades to its DB count.
+   */
+  async get(workspaceId: string): Promise<ReindexProgress | null> {
+    try {
+      const data = await this.redis.hgetall(this.key(workspaceId));
+      if (!data || data.total === undefined) return null;
+      const total = Number(data.total);
+      const done = Number(data.done);
+      const startedAt = Number(data.startedAt);
+      if (!Number.isFinite(total) || !Number.isFinite(done)) return null;
+      return { total, done, startedAt: Number.isFinite(startedAt) ? startedAt : 0 };
+    } catch (err) {
+      this.logger.warn(
+        `reindex-progress read failed for workspace ${workspaceId}; ` +
+          `falling back to DB count: ${(err as Error).message}`,
+      );
+      return null;
+    }
+  }
+}

apps/server/src/integrations/environment/environment.service.spec.ts

@@ -14,148 +14,4 @@ describe('EnvironmentService', () => {
   it('should be defined', () => {
     expect(service).toBeDefined();
   });
-
-  describe('getSandboxTtlMs', () => {
-    // ConfigService stub: get(key, def) returns the configured value for the key
-    // (falling back to def), matching the @nestjs/config contract the service
-    // calls with (key, default).
-    const build = (sandboxTtl?: string) =>
-      new EnvironmentService({
-        get: (key: string, def?: string) =>
-          key === 'SANDBOX_TTL_MS' ? (sandboxTtl ?? def) : def,
-      } as any);
-
-    it.each(['0', '-5', 'abc'])(
-      'falls back to the 3600000 default for invalid value %s',
-      (value) => {
-        expect(build(value).getSandboxTtlMs()).toBe(3_600_000);
-      },
-    );
-
-    it('returns the parsed value for a valid positive integer', () => {
-      expect(build('120000').getSandboxTtlMs()).toBe(120_000);
-    });
-
-    it('uses the 3600000 default when SANDBOX_TTL_MS is unset', () => {
-      expect(build(undefined).getSandboxTtlMs()).toBe(3_600_000);
-    });
-  });
-
-  // The three byte caps share the same getPositiveIntEnv() helper as the TTL,
-  // so a non-integer / non-positive value ('0'/'-5'/'abc') falls back to the
-  // documented default and a valid positive integer is returned parsed. Note
-  // parseInt truncates '1.5' -> 1 (a valid positive integer), so that value is
-  // accepted, not rejected — same as the pre-existing TTL getter.
-  describe.each([
-    {
-      name: 'getSandboxMaxBytes',
-      key: 'SANDBOX_MAX_BYTES',
-      def: 8_388_608,
-      getter: (s: EnvironmentService) => s.getSandboxMaxBytes(),
-    },
-    {
-      name: 'getSandboxMaxImageBytes',
-      key: 'SANDBOX_MAX_IMAGE_BYTES',
-      def: 20_971_520,
-      getter: (s: EnvironmentService) => s.getSandboxMaxImageBytes(),
-    },
-    {
-      name: 'getSandboxMaxTotalBytes',
-      key: 'SANDBOX_MAX_TOTAL_BYTES',
-      def: 134_217_728,
-      getter: (s: EnvironmentService) => s.getSandboxMaxTotalBytes(),
-    },
-  ])('$name', ({ key, def, getter }) => {
-    // ConfigService stub: get(k, d) returns the configured value for THIS cap's
-    // key (falling back to d), and the default for every other key.
-    const build = (value?: string) =>
-      new EnvironmentService({
-        get: (k: string, d?: string) =>
-          k === key ? (value ?? d) : d,
-      } as any);
-
-    it.each(['0', '-5', 'abc'])(
-      `falls back to the ${def} default for invalid value %s`,
-      (value) => {
-        expect(getter(build(value))).toBe(def);
-      },
-    );
-
-    it('returns the parsed value for a valid positive integer', () => {
-      expect(getter(build('4096'))).toBe(4096);
-    });
-
-    it('truncates a non-integer like "1.5" to 1 via parseInt (not rejected)', () => {
-      expect(getter(build('1.5'))).toBe(1);
-    });
-
-    it(`uses the ${def} default when the env is unset`, () => {
-      expect(getter(build(undefined))).toBe(def);
-    });
-  });
-
-  // getPositiveIntEnv keeps a one-shot `invalidPositiveIntWarned` set so a bad
-  // value is logged ONCE per key (not on every getter call, which the sandbox
-  // hits per-put). These tests pin that dedup so a regression to per-call logging
-  // would fail loudly.
-  describe('invalid-value warn dedup', () => {
-    it('warns only once per key across repeated getter calls', () => {
-      const service = new EnvironmentService({
-        get: (k: string, d?: string) =>
-          k === 'SANDBOX_MAX_TOTAL_BYTES' ? '-5' : d,
-      } as any);
-      const warnSpy = jest
-        .spyOn((service as any).logger, 'warn')
-        .mockImplementation(() => undefined);
-
-      service.getSandboxMaxTotalBytes();
-      service.getSandboxMaxTotalBytes();
-
-      expect(warnSpy).toHaveBeenCalledTimes(1);
-    });
-
-    it('warns independently per key (dedup is per-key, not global)', () => {
-      // Two DIFFERENT SANDBOX_* keys are both invalid -> each warns once, so two
-      // warns total. This proves the dedup set is keyed, not a single global flag.
-      const service = new EnvironmentService({
-        get: (k: string, d?: string) =>
-          k === 'SANDBOX_MAX_BYTES' || k === 'SANDBOX_MAX_TOTAL_BYTES'
-            ? '-5'
-            : d,
-      } as any);
-      const warnSpy = jest
-        .spyOn((service as any).logger, 'warn')
-        .mockImplementation(() => undefined);
-
-      service.getSandboxMaxBytes();
-      service.getSandboxMaxTotalBytes();
-
-      expect(warnSpy).toHaveBeenCalledTimes(2);
-    });
-  });
-
-  describe('getSandboxPublicUrl', () => {
-    // Stub that resolves BOTH keys the public-url logic consults.
-    const build = (vals: { sandboxUrl?: string; appUrl?: string }) =>
-      new EnvironmentService({
-        get: (key: string, def?: string) =>
-          key === 'SANDBOX_PUBLIC_URL'
-            ? (vals.sandboxUrl ?? def)
-            : key === 'APP_URL'
-              ? (vals.appUrl ?? def)
-              : def,
-      } as any);
-
-    it('uses SANDBOX_PUBLIC_URL and trims a trailing slash', () => {
-      expect(
-        build({ sandboxUrl: 'https://docs.example.com/' }).getSandboxPublicUrl(),
-      ).toBe('https://docs.example.com');
-    });
-
-    it('falls back to APP_URL (origin) when SANDBOX_PUBLIC_URL is unset', () => {
-      expect(
-        build({ appUrl: 'https://app.example.com' }).getSandboxPublicUrl(),
-      ).toBe('https://app.example.com');
-    });
-  });
 });

apps/server/src/integrations/environment/environment.service.ts

@@ -1,15 +1,9 @@
-import { Injectable, Logger } from '@nestjs/common';
+import { Injectable } from '@nestjs/common';
 import { ConfigService } from '@nestjs/config';
 import ms, { StringValue } from 'ms';
 
 @Injectable()
 export class EnvironmentService {
-  private readonly logger = new Logger(EnvironmentService.name);
-  // Env keys already warned about for an invalid value (one-shot per key, so a
-  // bad SANDBOX_* value is not logged on every blob put). Mirrors the original
-  // sandboxTtlWarned guard, generalized across the TTL + the three byte caps.
-  private readonly invalidPositiveIntWarned = new Set<string>();
-
   constructor(private configService: ConfigService) {}
 
   getNodeEnv(): string {
@@ -338,63 +332,4 @@ export class EnvironmentService {
       .map((o) => o.trim())
       .filter(Boolean);
   }
-
-  // --- Blob sandbox (in-RAM ephemeral blob transfer; see SandboxModule) ---
-
-  // Base URL the sandbox `uri` is built from. It MUST be reachable over the
-  // network by the external consumer that fetches the blobs (not a loopback
-  // address if that consumer is remote). Falls back to APP_URL when unset so a
-  // single-host deployment works out of the box; set it explicitly when the
-  // consumer lives on another host.
-  getSandboxPublicUrl(): string {
-    const raw =
-      this.configService.get<string>('SANDBOX_PUBLIC_URL') || this.getAppUrl();
-    // Drop any trailing slash so `${base}/api/sb/${id}` never doubles up.
-    return raw.replace(/\/+$/, '');
-  }
-
-  // Parse a REQUIRED positive-integer env (TTL in ms or a byte cap). A
-  // non-integer or <= 0 value would break the sandbox silently (instant expiry,
-  // or every put failing against a 0-byte cap), so warn once and fall back to
-  // the default instead. Blob bodies are never logged.
-  private getPositiveIntEnv(key: string, def: number): number {
-    const parsed = parseInt(
-      this.configService.get<string>(key, String(def)),
-      10,
-    );
-    if (!Number.isInteger(parsed) || parsed <= 0) {
-      if (!this.invalidPositiveIntWarned.has(key)) {
-        this.invalidPositiveIntWarned.add(key);
-        this.logger.warn(
-          `Invalid ${key} (must be a positive integer); falling back to the ${def} default`,
-        );
-      }
-      return def;
-    }
-    return parsed;
-  }
-
-  // Blob time-to-live. Default 1h. The unguessable UUID + this short TTL + TLS
-  // are the whole capability model (no tokens). A non-positive or non-integer
-  // value would make every blob expire instantly (silent 404s), so reject it and
-  // fall back to the 1h default (warned about once to avoid per-put log spam).
-  getSandboxTtlMs(): number {
-    return this.getPositiveIntEnv('SANDBOX_TTL_MS', 3_600_000);
-  }
-
-  // Per-blob cap for non-image blobs (the serialized document). Default 8 MiB.
-  getSandboxMaxBytes(): number {
-    return this.getPositiveIntEnv('SANDBOX_MAX_BYTES', 8_388_608);
-  }
-
-  // Per-blob cap for mirrored image blobs. Default 20 MiB.
-  getSandboxMaxImageBytes(): number {
-    return this.getPositiveIntEnv('SANDBOX_MAX_IMAGE_BYTES', 20_971_520);
-  }
-
-  // RAM guard: total bytes the whole store may hold. Default 128 MiB. On
-  // overflow the store evicts oldest entries to make room.
-  getSandboxMaxTotalBytes(): number {
-    return this.getPositiveIntEnv('SANDBOX_MAX_TOTAL_BYTES', 134_217_728);
-  }
 }

apps/server/src/integrations/environment/environment.validation.ts

@@ -2,7 +2,6 @@ import {
   IsIn,
   IsNotEmpty,
   IsNotIn,
-  IsNumberString,
   IsOptional,
   IsString,
   IsUrl,
@@ -171,35 +170,6 @@ export class EnvironmentVariables {
     },
   )
   CLICKHOUSE_URL: string;
-
-  // --- Blob sandbox (in-RAM ephemeral blob transfer; see SandboxModule) ---
-
-  @IsOptional()
-  @ValidateIf((obj) => obj.SANDBOX_PUBLIC_URL != '' && obj.SANDBOX_PUBLIC_URL != null)
-  @IsUrl(
-    { protocols: ['http', 'https'], require_tld: false },
-    {
-      message:
-        'SANDBOX_PUBLIC_URL must be a valid http(s) URL reachable by the external blob consumer',
-    },
-  )
-  SANDBOX_PUBLIC_URL: string;
-
-  @IsOptional()
-  @IsNumberString({}, { message: 'SANDBOX_TTL_MS must be an integer (milliseconds)' })
-  SANDBOX_TTL_MS: string;
-
-  @IsOptional()
-  @IsNumberString({}, { message: 'SANDBOX_MAX_BYTES must be an integer (bytes)' })
-  SANDBOX_MAX_BYTES: string;
-
-  @IsOptional()
-  @IsNumberString({}, { message: 'SANDBOX_MAX_IMAGE_BYTES must be an integer (bytes)' })
-  SANDBOX_MAX_IMAGE_BYTES: string;
-
-  @IsOptional()
-  @IsNumberString({}, { message: 'SANDBOX_MAX_TOTAL_BYTES must be an integer (bytes)' })
-  SANDBOX_MAX_TOTAL_BYTES: string;
 }
 
 export function validate(config: Record<string, any>) {

apps/server/src/integrations/mcp/mcp-auth.helpers.ts

@@ -131,25 +131,10 @@ export class FailedLoginLimiter {
 }
 
 // The per-session DocmostMcpConfig shape understood by @docmost/mcp: either the
-// service-account credentials variant OR the per-user getToken variant. The
+// service-account credentials variant OR the per-user getToken variant.
-// optional `sandbox` sink (blob store for the stash tool) is common to both and
+export type DocmostMcpConfig =
-// injected by McpService after the auth decision.
-export type DocmostMcpConfig = (
   | { apiUrl: string; email: string; password: string }
-  | { apiUrl: string; getToken: () => Promise<string> }
+  | { apiUrl: string; getToken: () => Promise<string> };
-) & {
-  sandbox?: {
-    put: (
-      buf: Buffer,
-      mime: string,
-    ) => { uri: string; sha256: string; size: number };
-    // Optional live/evict probes the package uses to keep stash_page's mirror
-    // counts honest under the store's FIFO eviction (mirror of the package's
-    // sink type); older bindings omit them.
-    has?: (uri: string) => boolean;
-    evict?: (uri: string) => void;
-  };
-};
 
 export interface ResolvedMcpAuth {
   config: DocmostMcpConfig;

apps/server/src/integrations/mcp/mcp-basic-login-gate.spec.ts

@@ -109,13 +109,13 @@ function makeService(opts: {
   };
 
   const service = new McpService(
+    undefined as never, // environmentService
     undefined as never, // workspaceRepo
     undefined as never, // authService
     undefined as never, // tokenService
     undefined as never, // userRepo
     undefined as never, // userSessionRepo
     moduleRef as never, // moduleRef (read by the MFA branch)
-    undefined as never, // sandboxStore (unused by the login-gate path)
   );
   // Stop the constructor's unref'd sweep timer leaking across tests.
   service.onModuleDestroy();

apps/server/src/integrations/mcp/mcp.module.ts

@@ -2,15 +2,17 @@ import { Module } from '@nestjs/common';
 import { McpController } from './mcp.controller';
 import { McpService } from './mcp.service';
 import { DatabaseModule } from '@docmost/db/database.module';
+import { EnvironmentModule } from '../environment/environment.module';
 import { AuthModule } from '../../core/auth/auth.module';
 import { TokenModule } from '../../core/auth/token.module';
 
 // Community MCP feature: the server itself serves the Model Context Protocol
-// over HTTP at /mcp. DatabaseModule (global) provides WorkspaceRepo. AuthModule
+// over HTTP at /mcp. DatabaseModule (global) provides WorkspaceRepo and
-// supplies AuthService (per-user HTTP-Basic login validation) and TokenModule
+// EnvironmentModule (global) provides EnvironmentService. AuthModule supplies
-// supplies TokenService (Bearer access-JWT verification for the token fallback).
+// AuthService (per-user HTTP-Basic login validation) and TokenModule supplies
+// TokenService (Bearer access-JWT verification for the token fallback).
 @Module({
-  imports: [DatabaseModule, AuthModule, TokenModule],
+  imports: [DatabaseModule, EnvironmentModule, AuthModule, TokenModule],
   controllers: [McpController],
   providers: [McpService],
 })

apps/server/src/integrations/mcp/mcp.service.ts

@@ -8,6 +8,7 @@ import { ModuleRef } from '@nestjs/core';
 import { pathToFileURL } from 'node:url';
 import { IncomingMessage } from 'node:http';
 import { FastifyReply, FastifyRequest } from 'fastify';
+import { EnvironmentService } from '../environment/environment.service';
 import { WorkspaceRepo } from '@docmost/db/repos/workspace/workspace.repo';
 import { UserRepo } from '@docmost/db/repos/user/user.repo';
 import { UserSessionRepo } from '@docmost/db/repos/session/user-session.repo';
@@ -29,7 +30,6 @@ import {
   DocmostMcpConfig,
   ResolvedMcpAuth,
 } from './mcp-auth.helpers';
-import { SandboxStore } from '../sandbox/sandbox.store';
 
 // Minimal shape of the embedded MCP HTTP handler exported by @docmost/mcp/http.
 interface McpHttpHandler {
@@ -92,14 +92,13 @@ export class McpService implements OnModuleDestroy {
   private readonly sweepTimer: NodeJS.Timeout;
 
   constructor(
+    private readonly environmentService: EnvironmentService,
     private readonly workspaceRepo: WorkspaceRepo,
     private readonly authService: AuthService,
     private readonly tokenService: TokenService,
     private readonly userRepo: UserRepo,
     private readonly userSessionRepo: UserSessionRepo,
     private readonly moduleRef: ModuleRef,
-    // Shared singleton in-RAM blob store backing the stash tool.
-    private readonly sandboxStore: SandboxStore,
   ) {
     this.sweepTimer = setInterval(() => {
       try {
@@ -327,11 +326,7 @@ export class McpService implements OnModuleDestroy {
               // Should never happen: handle() always stashes before delegating.
               throw new UnauthorizedException('MCP authentication missing.');
             }
-            // Inject the blob-sandbox sink after the auth decision so stash_page
+            return resolved.config;
-            // can store blobs in the shared in-RAM store regardless of which
-            // credential variant resolved. The sink (put/has/evict + uri↔id
-            // mapping) is owned by SandboxStore.asSink().
-            return { ...resolved.config, sandbox: this.sandboxStore.asSink() };
           },
           {
             identify: (req: IncomingMessage) => {

apps/server/src/integrations/sandbox/sandbox.constants.ts

@@ -1,6 +0,0 @@
-// Single source of truth for the anonymous blob-sandbox route. The controller
-// is mounted under the global `/api` prefix, so its decorator uses the bare
-// segment while the public URL and the workspace-gate exclusion need the full
-// path — derive the latter from the former so the two never drift.
-export const SANDBOX_ROUTE_SEGMENT = 'sb';
-export const SANDBOX_API_PATH = `/api/${SANDBOX_ROUTE_SEGMENT}`;

apps/server/src/integrations/sandbox/sandbox.controller.spec.ts

@@ -1,265 +0,0 @@
-import { SandboxController } from './sandbox.controller';
-import { SandboxEntry } from './sandbox.store';
-
-// Capturing fake of the FastifyReply surface the controller uses:
-// status()/header()/headers()/send(), all chainable.
-function makeRes() {
-  const sent: { status: number; headers: Record<string, any>; body: any } = {
-    status: 200,
-    headers: {},
-    body: undefined,
-  };
-  const res: any = {
-    status(code: number) {
-      sent.status = code;
-      return res;
-    },
-    header(key: string, value: any) {
-      sent.headers[key.toLowerCase()] = value;
-      return res;
-    },
-    headers(obj: Record<string, any>) {
-      for (const k of Object.keys(obj)) sent.headers[k.toLowerCase()] = obj[k];
-      return res;
-    },
-    send(body?: any) {
-      sent.body = body;
-      return res;
-    },
-    _sent: sent,
-  };
-  return res;
-}
-
-function makeReq(headers: Record<string, any> = {}) {
-  return { headers } as any;
-}
-
-// A syntactically valid v4 UUID (version nibble 4, variant nibble 8). The
-// shared `uuid` validator is stricter than a bare hex-shape regex, so the id
-// must carry a real version/variant.
-const VALID_ID = 'aaaaaaaa-bbbb-4ccc-8ddd-eeeeeeeeeeee';
-
-function entry(buf: Buffer, mime: string, sha256: string): SandboxEntry {
-  return { buf, mime, sha256, expiresAt: Date.now() + 60_000 };
-}
-
-describe('SandboxController', () => {
-  it('serves 200 with body, Content-Type, Content-Length and sha256 ETag', async () => {
-    const buf = Buffer.from('{"ok":true}', 'utf8');
-    const sha = 'a'.repeat(64);
-    const store = { get: jest.fn().mockReturnValue(entry(buf, 'application/json', sha)) };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq(), res);
-
-    expect(store.get).toHaveBeenCalledWith(VALID_ID);
-    expect(res._sent.status).toBe(200);
-    expect(res._sent.headers['content-type']).toBe('application/json');
-    expect(res._sent.headers['content-length']).toBe(buf.length);
-    expect(res._sent.headers['etag']).toBe(`"${sha}"`);
-    expect(res._sent.body).toBe(buf);
-  });
-
-  it('returns 404 for a missing/expired blob', async () => {
-    const store = { get: jest.fn().mockReturnValue(undefined) };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq(), res);
-
-    expect(res._sent.status).toBe(404);
-    expect(res._sent.body).toBeUndefined();
-  });
-
-  it('returns 404 for a non-UUID id WITHOUT touching the store (anti-traversal)', async () => {
-    const store = { get: jest.fn() };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get('../../etc/passwd', makeReq(), res);
-
-    expect(store.get).not.toHaveBeenCalled();
-    expect(res._sent.status).toBe(404);
-  });
-
-  it('returns 304 (no body) when If-None-Match matches the ETag', async () => {
-    const sha = 'b'.repeat(64);
-    const store = {
-      get: jest.fn().mockReturnValue(entry(Buffer.from('x'), 'application/json', sha)),
-    };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq({ 'if-none-match': `"${sha}"` }), res);
-
-    expect(res._sent.status).toBe(304);
-    expect(res._sent.body).toBeUndefined();
-    expect(res._sent.headers['etag']).toBe(`"${sha}"`);
-  });
-
-  it('accepts a bare (unquoted) sha256 in If-None-Match too', async () => {
-    const sha = 'c'.repeat(64);
-    const store = {
-      get: jest.fn().mockReturnValue(entry(Buffer.from('x'), 'application/json', sha)),
-    };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq({ 'if-none-match': sha }), res);
-
-    expect(res._sent.status).toBe(304);
-  });
-
-  it('serves 200 when If-None-Match does NOT match', async () => {
-    const sha = 'd'.repeat(64);
-    const store = {
-      get: jest.fn().mockReturnValue(entry(Buffer.from('x'), 'application/json', sha)),
-    };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq({ 'if-none-match': '"stale"' }), res);
-
-    expect(res._sent.status).toBe(200);
-  });
-
-  it('returns 304 for a wildcard "*" If-None-Match', async () => {
-    const sha = 'e'.repeat(64);
-    const store = {
-      get: jest.fn().mockReturnValue(entry(Buffer.from('x'), 'application/json', sha)),
-    };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq({ 'if-none-match': '*' }), res);
-
-    expect(res._sent.status).toBe(304);
-  });
-
-  it('returns 304 for a weak validator W/"<sha>"', async () => {
-    const sha = 'f'.repeat(64);
-    const store = {
-      get: jest.fn().mockReturnValue(entry(Buffer.from('x'), 'application/json', sha)),
-    };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq({ 'if-none-match': `W/"${sha}"` }), res);
-
-    expect(res._sent.status).toBe(304);
-  });
-
-  it('returns 304 when a comma-separated If-None-Match list contains the sha', async () => {
-    const sha = '1'.repeat(64);
-    const store = {
-      get: jest.fn().mockReturnValue(entry(Buffer.from('x'), 'application/json', sha)),
-    };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(
-      VALID_ID,
-      makeReq({ 'if-none-match': `"other", "${sha}"` }),
-      res,
-    );
-
-    expect(res._sent.status).toBe(304);
-  });
-
-  it('sets a private, immutable Cache-Control with a max-age within the TTL on 200', async () => {
-    const sha = '2'.repeat(64);
-    // Known TTL: ~30s out, so the floored max-age must land within [0, 60].
-    const e: SandboxEntry = {
-      buf: Buffer.from('x'),
-      mime: 'application/json',
-      sha256: sha,
-      expiresAt: Date.now() + 30_000,
-    };
-    const store = { get: jest.fn().mockReturnValue(e) };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq(), res);
-
-    expect(res._sent.status).toBe(200);
-    const cc = res._sent.headers['cache-control'] as string;
-    expect(cc).toMatch(/^private, max-age=\d+, immutable$/);
-    const maxAge = Number(cc.match(/max-age=(\d+)/)![1]);
-    expect(maxAge).toBeGreaterThanOrEqual(0);
-    expect(maxAge).toBeLessThanOrEqual(60);
-  });
-
-  it('emits Cache-Control alongside ETag on the 304 branch', async () => {
-    const sha = '3'.repeat(64);
-    const store = {
-      get: jest.fn().mockReturnValue(entry(Buffer.from('x'), 'application/json', sha)),
-    };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq({ 'if-none-match': `"${sha}"` }), res);
-
-    expect(res._sent.status).toBe(304);
-    expect(res._sent.headers['cache-control']).toMatch(
-      /^private, max-age=\d+, immutable$/,
-    );
-  });
-
-  it('sets nosniff + restrictive CSP and serves an allowlisted image inline', async () => {
-    const sha = '4'.repeat(64);
-    const store = {
-      get: jest.fn().mockReturnValue(entry(Buffer.from('x'), 'image/png', sha)),
-    };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq(), res);
-
-    expect(res._sent.status).toBe(200);
-    expect(res._sent.headers['x-content-type-options']).toBe('nosniff');
-    expect(res._sent.headers['content-security-policy']).toBe(
-      "base-uri 'none'; object-src 'self'; default-src 'self';",
-    );
-    expect(res._sent.headers['content-disposition']).toBe('inline');
-  });
-
-  it('forces an SVG to download (attachment) while keeping nosniff + CSP', async () => {
-    const sha = '5'.repeat(64);
-    const store = {
-      get: jest.fn().mockReturnValue(entry(Buffer.from('<svg/>'), 'image/svg+xml', sha)),
-    };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq(), res);
-
-    expect(res._sent.status).toBe(200);
-    expect(res._sent.headers['content-disposition']).toBe('attachment');
-    expect(res._sent.headers['x-content-type-options']).toBe('nosniff');
-    expect(res._sent.headers['content-security-policy']).toBe(
-      "base-uri 'none'; object-src 'self'; default-src 'self';",
-    );
-  });
-
-  it('forces text/html to download (attachment) while keeping nosniff + CSP', async () => {
-    const sha = '6'.repeat(64);
-    const store = {
-      get: jest
-        .fn()
-        .mockReturnValue(entry(Buffer.from('<h1>x</h1>'), 'text/html', sha)),
-    };
-    const controller = new SandboxController(store as any);
-    const res = makeRes();
-
-    await controller.get(VALID_ID, makeReq(), res);
-
-    expect(res._sent.status).toBe(200);
-    expect(res._sent.headers['content-disposition']).toBe('attachment');
-    expect(res._sent.headers['x-content-type-options']).toBe('nosniff');
-    expect(res._sent.headers['content-security-policy']).toBe(
-      "base-uri 'none'; object-src 'self'; default-src 'self';",
-    );
-  });
-});

apps/server/src/integrations/sandbox/sandbox.controller.ts

@@ -1,130 +0,0 @@
-import { Controller, Get, Param, Req, Res } from '@nestjs/common';
-import { FastifyReply, FastifyRequest } from 'fastify';
-import { validate as isValidUUID } from 'uuid';
-import { SandboxStore } from './sandbox.store';
-import { SANDBOX_ROUTE_SEGMENT } from './sandbox.constants';
-
-// MIME types safe to render inline in a browser. SVG is deliberately EXCLUDED
-// (it can carry script), as are text/html and the JSON document blob — anything
-// not on this list is served as an attachment so an attacker-controlled mime can
-// never execute script on this origin (the route is anonymous + same-origin).
-const INLINE_SAFE_MIME = new Set([
-  'image/png',
-  'image/jpeg',
-  'image/gif',
-  'image/webp',
-  'image/avif',
-]);
-
-/**
- * Anonymous read endpoint for the in-RAM blob sandbox.
- *
- * Mounted under the global `/api` prefix as `GET /api/sb/:id`. It carries NO
- * `@UseGuards(JwtAuthGuard)`, so — exactly like the public attachment route
- * `GET /api/files/public/...` — it is exempt from Docmost session auth. The
- * route is ALSO listed in the workspace-resolution preHandler's excludedPaths
- * in main.ts so a request from a remote consumer (which carries no workspace
- * host) is not rejected with "Workspace not found".
- *
- * It only ever serves blobs looked up from the SandboxStore by a validated
- * UUID; `:id` is never used as a filesystem path, so there is no traversal
- * surface. Never returns tokens, never 401s.
- *
- * Anti-XSS hardening mirrors the public attachment route: every response sets
- * `X-Content-Type-Options: nosniff` and a restrictive CSP, and serves any mime
- * NOT on the inline-safe allowlist (svg/html/the JSON document blob) as an
- * attachment, so an attacker-controlled `entry.mime` can never execute script
- * on this same-origin anonymous route.
- */
-@Controller(SANDBOX_ROUTE_SEGMENT)
-export class SandboxController {
-  constructor(private readonly store: SandboxStore) {}
-
-  @Get(':id')
-  async get(
-    @Param('id') id: string,
-    @Req() req: FastifyRequest,
-    @Res() res: FastifyReply,
-  ): Promise<void> {
-    // Validate `:id` as a real UUID via the shared `uuid` validator (same as the
-    // attachment routes). This is anti-traversal / input hygiene (so `:id` can
-    // never be a path like `../...`), NOT authorization — the capability is the
-    // unguessable id itself plus the short TTL plus TLS. A non-UUID id (including
-    // any traversal attempt) → 404 before touching the store; no stack trace
-    // leaks out.
-    if (!isValidUUID(id)) {
-      res.status(404).send();
-      return;
-    }
-
-    const entry = this.store.get(id);
-    if (!entry) {
-      // Missing or expired — indistinguishable to the caller, by design.
-      res.status(404).send();
-      return;
-    }
-
-    // Strong validator: quoted sha256, no W/ weak prefix. Same value computed
-    // at put() time, so an external consumer can detect a truncated/corrupted
-    // body — the original bug this whole channel exists to fix.
-    const etag = `"${entry.sha256}"`;
-
-    // Compute freshness BEFORE the conditional check: a 304 conditional
-    // revalidation must not lose the Cache-Control freshness directives, or a
-    // revalidating client would forget how long the blob stays fresh.
-    const ttlSeconds = Math.max(
-      0,
-      Math.floor((entry.expiresAt - Date.now()) / 1000),
-    );
-    // Capability URL — keep it out of shared caches; immutable for its TTL.
-    const cacheControl = `private, max-age=${ttlSeconds}, immutable`;
-
-    // Conditional request: an exact ETag match → 304 with no body. The blob is
-    // immutable, so the validator is stable for the blob's whole lifetime.
-    if (this.ifNoneMatchMatches(req.headers['if-none-match'], entry.sha256)) {
-      res
-        .status(304)
-        .header('ETag', etag)
-        .header('Cache-Control', cacheControl)
-        .send();
-      return;
-    }
-
-    // Non-allowlisted mimes (svg/html/the JSON blob) are forced to download so
-    // an attacker-controlled mime can never run script inline on this origin.
-    const disposition = INLINE_SAFE_MIME.has(entry.mime)
-      ? 'inline'
-      : 'attachment';
-
-    // Use @Res() + res.send(Buffer) with an explicit Content-Type so the binary
-    // body bypasses the global JSON response transform/serializer.
-    res
-      .status(200)
-      .headers({
-        'Content-Type': entry.mime,
-        'Content-Length': entry.buf.length,
-        ETag: etag,
-        'Cache-Control': cacheControl,
-        'X-Content-Type-Options': 'nosniff',
-        'Content-Security-Policy':
-          "base-uri 'none'; object-src 'self'; default-src 'self';",
-        'Content-Disposition': disposition,
-      })
-      .send(entry.buf);
-  }
-
-  // Accept the consumer's If-None-Match whether it sends the quoted ETag, a bare
-  // sha256, a weak "W/"-prefixed validator, or a comma-separated list.
-  private ifNoneMatchMatches(
-    header: string | string[] | undefined,
-    sha256: string,
-  ): boolean {
-    if (!header) return false;
-    const raw = Array.isArray(header) ? header.join(',') : header;
-    if (raw.trim() === '*') return true;
-    return raw
-      .split(',')
-      .map((t) => t.trim().replace(/^W\//, '').replace(/^"|"$/g, ''))
-      .some((t) => t === sha256);
-  }
-}

apps/server/src/integrations/sandbox/sandbox.module.ts

@@ -1,19 +0,0 @@
-import { Global, Module } from '@nestjs/common';
-import { SandboxController } from './sandbox.controller';
-import { SandboxStore } from './sandbox.store';
-
-/**
- * In-RAM blob sandbox: a SINGLE shared SandboxStore (the @Injectable singleton)
- * is written to by the stash tool (via McpService / AiChatToolsService) and read
- * back by the anonymous SandboxController. Marked @Global so the same store
- * instance is injectable everywhere without import churn — put() and get() MUST
- * hit the same Map. EnvironmentService (caps/TTL/public URL) is provided by the
- * global EnvironmentModule.
- */
-@Global()
-@Module({
-  controllers: [SandboxController],
-  providers: [SandboxStore],
-  exports: [SandboxStore],
-})
-export class SandboxModule {}

apps/server/src/integrations/sandbox/sandbox.store.spec.ts

@@ -1,163 +0,0 @@
-import { createHash } from 'node:crypto';
-import { validate as isValidUUID } from 'uuid';
-import { SandboxStore } from './sandbox.store';
-
-// Build a minimal EnvironmentService stub with overridable caps/TTL.
-function makeEnv(
-  overrides: Partial<{
-    ttlMs: number;
-    maxBytes: number;
-    maxImageBytes: number;
-    maxTotalBytes: number;
-  }> = {},
-) {
-  const cfg = {
-    ttlMs: 3_600_000,
-    maxBytes: 8_388_608,
-    maxImageBytes: 20_971_520,
-    maxTotalBytes: 134_217_728,
-    ...overrides,
-  };
-  return {
-    getSandboxTtlMs: () => cfg.ttlMs,
-    getSandboxMaxBytes: () => cfg.maxBytes,
-    getSandboxMaxImageBytes: () => cfg.maxImageBytes,
-    getSandboxMaxTotalBytes: () => cfg.maxTotalBytes,
-    getSandboxPublicUrl: () => 'https://example.test',
-  } as any;
-}
-
-describe('SandboxStore', () => {
-  let store: SandboxStore;
-
-  afterEach(() => {
-    // Clear the unref'd sweep interval so it never leaks across tests.
-    store?.onModuleDestroy();
-    jest.useRealTimers();
-  });
-
-  it('put/get round-trips the exact bytes + mime and returns a UUID id', () => {
-    store = new SandboxStore(makeEnv());
-    const buf = Buffer.from('{"type":"doc","content":[]}', 'utf8');
-
-    const res = store.put(buf, 'application/json');
-    expect(isValidUUID(res.id)).toBe(true);
-    expect(res.size).toBe(buf.length);
-
-    const entry = store.get(res.id);
-    expect(entry).toBeDefined();
-    expect(entry!.buf.equals(buf)).toBe(true);
-    expect(entry!.mime).toBe('application/json');
-  });
-
-  it('computes sha256 over the body (matches a manual digest)', () => {
-    store = new SandboxStore(makeEnv());
-    const buf = Buffer.from('hello sandbox', 'utf8');
-    const expected = createHash('sha256').update(buf).digest('hex');
-
-    const res = store.put(buf, 'text/plain');
-    expect(res.sha256).toBe(expected);
-    expect(store.get(res.id)!.sha256).toBe(expected);
-  });
-
-  it('returns undefined for a missing id', () => {
-    store = new SandboxStore(makeEnv());
-    expect(store.get('11111111-1111-1111-1111-111111111111')).toBeUndefined();
-  });
-
-  it('lazily expires entries past the TTL (get returns undefined)', () => {
-    jest.useFakeTimers();
-    jest.setSystemTime(new Date('2026-01-01T00:00:00Z'));
-    store = new SandboxStore(makeEnv({ ttlMs: 1000 }));
-    const res = store.put(Buffer.from('x'), 'text/plain');
-
-    expect(store.get(res.id)).toBeDefined();
-    jest.setSystemTime(new Date('2026-01-01T00:00:02Z')); // +2s > 1s TTL
-    expect(store.get(res.id)).toBeUndefined();
-    // Eviction also frees the byte accounting.
-    expect(store.bytes).toBe(0);
-  });
-
-  it('background sweep drops expired entries without a get()', () => {
-    jest.useFakeTimers();
-    jest.setSystemTime(new Date('2026-01-01T00:00:00Z'));
-    store = new SandboxStore(makeEnv({ ttlMs: 1000 }));
-    store.put(Buffer.from('x'), 'text/plain');
-    expect(store.size).toBe(1);
-
-    jest.setSystemTime(new Date('2026-01-01T00:01:30Z')); // past TTL
-    jest.advanceTimersByTime(60_000); // fire the sweep interval
-    expect(store.size).toBe(0);
-  });
-
-  it('rejects a non-image blob over SANDBOX_MAX_BYTES', () => {
-    store = new SandboxStore(makeEnv({ maxBytes: 16 }));
-    expect(() => store.put(Buffer.alloc(17), 'application/json')).toThrow(
-      /per-blob cap/,
-    );
-  });
-
-  it('uses the larger image cap for image/* blobs', () => {
-    // 100 bytes exceeds the doc cap (16) but fits the image cap (1024).
-    store = new SandboxStore(makeEnv({ maxBytes: 16, maxImageBytes: 1024 }));
-    expect(() => store.put(Buffer.alloc(100), 'image/png')).not.toThrow();
-    // SVG counts as an image too.
-    expect(() => store.put(Buffer.alloc(100), 'image/svg+xml')).not.toThrow();
-  });
-
-  it('evicts oldest entries when the total cap would be exceeded', () => {
-    // Total cap 250 bytes; each blob 100 bytes -> only 2 fit at a time.
-    store = new SandboxStore(
-      makeEnv({ maxTotalBytes: 250, maxBytes: 1024 }),
-    );
-    const a = store.put(Buffer.alloc(100), 'application/json');
-    const b = store.put(Buffer.alloc(100), 'application/json');
-    const c = store.put(Buffer.alloc(100), 'application/json'); // evicts a
-
-    expect(store.get(a.id)).toBeUndefined(); // oldest evicted
-    expect(store.get(b.id)).toBeDefined();
-    expect(store.get(c.id)).toBeDefined();
-    expect(store.bytes).toBeLessThanOrEqual(250);
-  });
-
-  it('rejects a single blob larger than the whole total cap', () => {
-    store = new SandboxStore(
-      makeEnv({ maxTotalBytes: 50, maxBytes: 1024 }),
-    );
-    expect(() => store.put(Buffer.alloc(100), 'application/json')).toThrow(
-      /total store cap/,
-    );
-  });
-
-  it('putAndLink composes the anonymous /api/sb/<id> url with matching integrity', () => {
-    store = new SandboxStore(makeEnv());
-    const buf = Buffer.from('hello link', 'utf8');
-    const expected = createHash('sha256').update(buf).digest('hex');
-
-    const res = store.putAndLink(buf, 'image/png');
-    expect(res.uri).toMatch(/^https:\/\/example\.test\/api\/sb\/[0-9a-f-]{36}$/);
-    expect(res.sha256).toBe(expected);
-    expect(res.size).toBe(buf.length);
-  });
-
-  it('has()/remove() report and free a blob by id', () => {
-    store = new SandboxStore(makeEnv());
-    const { id } = store.put(Buffer.from('x'), 'text/plain');
-
-    expect(store.has(id)).toBe(true);
-    store.remove(id);
-    expect(store.has(id)).toBe(false);
-    expect(store.bytes).toBe(0);
-  });
-
-  it('asSink() round-trips put/has/evict through the anonymous uri', () => {
-    store = new SandboxStore(makeEnv());
-    const sink = store.asSink();
-    const buf = Buffer.from('sink bytes', 'utf8');
-
-    const r = sink.put(buf, 'image/png');
-    expect(sink.has(r.uri)).toBe(true);
-    sink.evict(r.uri);
-    expect(sink.has(r.uri)).toBe(false);
-  });
-});

apps/server/src/integrations/sandbox/sandbox.store.ts

@@ -1,178 +0,0 @@
-import { Injectable, Logger, OnModuleDestroy } from '@nestjs/common';
-import { createHash, randomUUID } from 'node:crypto';
-import { EnvironmentService } from '../environment/environment.service';
-import { SANDBOX_API_PATH } from './sandbox.constants';
-
-// In-RAM, process-local blob store. No disk, no DB. Ephemeral by design: a
-// restart empties it. A blob is addressed by an unguessable randomUUID() which
-// IS the read capability — there are NO tokens. Each blob is immutable (its id
-// never maps to changing content), so its sha256 is a perfect strong ETag.
-export interface SandboxEntry {
-  buf: Buffer;
-  mime: string;
-  sha256: string;
-  expiresAt: number;
-}
-
-export interface SandboxPutResult {
-  id: string;
-  sha256: string;
-  size: number;
-}
-
-@Injectable()
-export class SandboxStore implements OnModuleDestroy {
-  private readonly logger = new Logger(SandboxStore.name);
-  // Map preserves insertion order, so the first key is the oldest entry — used
-  // for FIFO eviction when the total-bytes RAM guard is exceeded.
-  private readonly map = new Map<string, SandboxEntry>();
-  private totalBytes = 0;
-
-  // Background sweep clears expired entries so never-fetched blobs do not linger
-  // until the next get(). unref()'d so it never holds the event loop open;
-  // cleared on module destroy. Mirrors the sweepTimer pattern in
-  // integrations/mcp/mcp.service.ts and packages/mcp/src/http.ts.
-  private readonly sweepIntervalMs = 60_000;
-  private readonly sweepTimer: NodeJS.Timeout;
-
-  constructor(private readonly environmentService: EnvironmentService) {
-    this.sweepTimer = setInterval(() => {
-      try {
-        this.sweep();
-      } catch (err) {
-        this.logger.error('Sandbox sweep failed', err as Error);
-      }
-    }, this.sweepIntervalMs);
-    this.sweepTimer.unref?.();
-  }
-
-  onModuleDestroy(): void {
-    clearInterval(this.sweepTimer);
-  }
-
-  /**
-   * Store a blob and return its read capability id + integrity metadata. The
-   * per-blob cap is chosen by mime (images get the larger image cap), and the
-   * total-store RAM guard evicts oldest entries to make room. Throws a clear
-   * error when a single blob cannot fit even after eviction. Blob bodies are
-   * never logged.
-   */
-  put(buf: Buffer, mime: string): SandboxPutResult {
-    const perBlobCap = mime.startsWith('image/')
-      ? this.environmentService.getSandboxMaxImageBytes()
-      : this.environmentService.getSandboxMaxBytes();
-    if (buf.length > perBlobCap) {
-      throw new Error(
-        `Sandbox blob of ${buf.length} bytes exceeds the ${perBlobCap}-byte per-blob cap`,
-      );
-    }
-
-    const maxTotal = this.environmentService.getSandboxMaxTotalBytes();
-    if (buf.length > maxTotal) {
-      throw new Error(
-        `Sandbox blob of ${buf.length} bytes exceeds the total store cap of ${maxTotal} bytes`,
-      );
-    }
-
-    // Drop expired entries first, then evict oldest until the new blob fits.
-    this.sweep();
-    while (this.totalBytes + buf.length > maxTotal && this.map.size > 0) {
-      const oldest = this.map.keys().next().value as string;
-      this.evict(oldest);
-    }
-
-    const id = randomUUID();
-    const sha256 = createHash('sha256').update(buf).digest('hex');
-    const expiresAt = Date.now() + this.environmentService.getSandboxTtlMs();
-    this.map.set(id, { buf, mime, sha256, expiresAt });
-    this.totalBytes += buf.length;
-    return { id, sha256, size: buf.length };
-  }
-
-  /**
-   * Store a blob and return its anonymous read URL plus integrity metadata.
-   * Owns the single sandbox-URL composition (`${publicBase}${SANDBOX_API_PATH}/
-   * <id>`) so callers never hand-build the route; the raw put() stays public for
-   * tests/low-level callers. sha256 is also the blob's strong ETag.
-   */
-  putAndLink(
-    buf: Buffer,
-    mime: string,
-  ): { uri: string; sha256: string; size: number } {
-    const stored = this.put(buf, mime);
-    const base = this.environmentService.getSandboxPublicUrl();
-    return {
-      uri: `${base}${SANDBOX_API_PATH}/${stored.id}`,
-      sha256: stored.sha256,
-      size: stored.size,
-    };
-  }
-
-  /**
-   * Adapter to the package's blob-sandbox sink contract `{ put, has, evict }`.
-   * The sink speaks anonymous `uri`s while the store is keyed by `id`, so this is
-   * the ONE place that maps a sandbox uri back to its id (the last path segment).
-   * Both wiring sites (embedded MCP + in-app agent tools) use this so the uri↔id
-   * mapping and URL composition live next to putAndLink, not copy-pasted.
-   */
-  asSink(): {
-    put: (buf: Buffer, mime: string) => { uri: string; sha256: string; size: number };
-    has: (uri: string) => boolean;
-    evict: (uri: string) => void;
-  } {
-    const idOf = (uri: string) => uri.substring(uri.lastIndexOf('/') + 1);
-    return {
-      put: (buf, mime) => this.putAndLink(buf, mime),
-      has: (uri) => this.has(idOf(uri)),
-      evict: (uri) => this.remove(idOf(uri)),
-    };
-  }
-
-  /** True if the blob is still live (not evicted/expired). */
-  has(id: string): boolean {
-    return this.get(id) !== undefined;
-  }
-
-  /** Drop a blob by id (public wrapper over the private FIFO evict). */
-  remove(id: string): void {
-    this.evict(id);
-  }
-
-  /** Returns the entry, or undefined if missing OR expired (lazy expiry). */
-  get(id: string): SandboxEntry | undefined {
-    const entry = this.map.get(id);
-    if (!entry) return undefined;
-    if (entry.expiresAt <= Date.now()) {
-      this.evict(id);
-      return undefined;
-    }
-    return entry;
-  }
-
-  /** Current number of live entries (test/diagnostic helper). */
-  get size(): number {
-    return this.map.size;
-  }
-
-  /** Current total bytes held (test/diagnostic helper). */
-  get bytes(): number {
-    return this.totalBytes;
-  }
-
-  private evict(id: string): void {
-    const entry = this.map.get(id);
-    if (entry) {
-      this.totalBytes -= entry.buf.length;
-      this.map.delete(id);
-    }
-  }
-
-  private sweep(): void {
-    const now = Date.now();
-    for (const [id, entry] of this.map) {
-      if (entry.expiresAt <= now) {
-        this.evict(id);
-      }
-    }
-  }
-}

apps/server/src/main.ts

@@ -13,7 +13,6 @@ import fastifyCookie from '@fastify/cookie';
 import fastifyIp from 'fastify-ip';
 import { InternalLogFilter } from './common/logger/internal-log-filter';
 import { EnvironmentService } from './integrations/environment/environment.service';
-import { SANDBOX_API_PATH } from './integrations/sandbox/sandbox.constants';
 import { resolveFrameHeader } from './common/helpers';
 import { resolveTrustProxy } from './integrations/environment/trust-proxy.util';
 
@@ -127,10 +126,6 @@ async function bootstrap() {
         '/api/workspace/create',
         '/api/workspace/joined',
         '/api/workspace/find-by-email',
-        // Anonymous in-RAM blob sandbox: a remote consumer fetches blobs by an
-        // unguessable UUID without any workspace host context, so the
-        // workspace-resolution gate must not apply.
-        SANDBOX_API_PATH,
       ];
 
       if (

apps/server/test/integration/page-embeddable-ids-lockstep.int-spec.ts

@@ -0,0 +1,124 @@
+import { Kysely } from 'kysely';
+import { randomUUID } from 'node:crypto';
+import { PageRepo } from '@docmost/db/repos/page/page.repo';
+import { SpaceMemberRepo } from '@docmost/db/repos/space/space-member.repo';
+import { EventEmitter2 } from '@nestjs/event-emitter';
+import { getTestDb, destroyTestDb, createWorkspace, createSpace } from './db';
+
+/**
+ * `PageRepo.getEmbeddablePageIds` MUST stay in lockstep with
+ * `PageRepo.countEmbeddablePages` (page.repo.ts) — the bulk reindex iterates the
+ * ID set while the status endpoint reports the count as the live denominator, so
+ * if the two predicates ever diverge the "done X of Y" counter ends on the wrong
+ * total. Both share the SAME WHERE: a page qualifies iff it is non-deleted AND
+ * (text_content has a non-whitespace char OR it has a non-deleted embedding row).
+ *
+ * This is a DB-level invariant: the predicate lives in raw SQL (`text_content ~
+ * '[^[:space:]]'`) and an EXISTS subquery, so a unit test with mocked Kysely
+ * cannot observe it. We seed every boundary case against real Postgres and
+ * assert the returned ID set EQUALS the count (and is exactly the expected set).
+ * A future edit that touches one predicate but not the other turns this red.
+ */
+describe('PageRepo embeddable-page set: getEmbeddablePageIds <-> countEmbeddablePages [integration]', () => {
+  let db: Kysely<any>;
+  let repo: PageRepo;
+  let workspaceId: string;
+  let spaceId: string;
+
+  beforeAll(async () => {
+    db = getTestDb();
+    // Only the Kysely-backed query methods under test are exercised, so the
+    // SpaceMemberRepo / EventEmitter2 deps are never touched — stub them.
+    repo = new PageRepo(
+      db as any,
+      {} as unknown as SpaceMemberRepo,
+      {} as unknown as EventEmitter2,
+    );
+    workspaceId = (await createWorkspace(db)).id;
+    spaceId = (await createSpace(db, workspaceId)).id;
+  });
+
+  afterAll(async () => {
+    await destroyTestDb();
+  });
+
+  // Insert a page with explicit text_content / deleted_at (createPage in db.ts
+  // sets neither), returning its id so the test can assert membership.
+  async function insertPage(args: {
+    textContent: string | null;
+    deletedAt?: Date | null;
+  }): Promise<string> {
+    const id = randomUUID();
+    await db
+      .insertInto('pages')
+      .values({
+        id,
+        slugId: `slug-${id.slice(0, 8)}`,
+        title: `page-${id.slice(0, 8)}`,
+        spaceId,
+        workspaceId,
+        textContent: args.textContent,
+        deletedAt: args.deletedAt ?? null,
+      })
+      .execute();
+    return id;
+  }
+
+  // Insert one embedding chunk row for a page (NOT NULL columns + deleted_at).
+  async function insertEmbedding(
+    pageId: string,
+    opts: { deletedAt?: Date | null } = {},
+  ): Promise<void> {
+    await db
+      .insertInto('pageEmbeddings')
+      .values({
+        id: randomUUID(),
+        workspaceId,
+        pageId,
+        spaceId,
+        chunkIndex: 0,
+        chunkStart: 0,
+        chunkLength: 1,
+        content: 'x',
+        modelName: 'test-model',
+        modelDimensions: 1,
+        deletedAt: opts.deletedAt ?? null,
+      })
+      .execute();
+  }
+
+  it('returns exactly the embeddable set and its size equals countEmbeddablePages', async () => {
+    // IN the set --------------------------------------------------------------
+    // (a) non-deleted page with real body text.
+    const withText = await insertPage({ textContent: 'hello world' });
+    // (b) non-deleted page with NO text but a live embedding row (EXISTS clause:
+    //     a page that lost its text yet still has stale vectors must be visited
+    //     so the reindex can clear them).
+    const noTextLiveEmbedding = await insertPage({ textContent: null });
+    await insertEmbedding(noTextLiveEmbedding);
+
+    // OUT of the set ----------------------------------------------------------
+    // (c) non-deleted, text_content NULL, no embeddings.
+    await insertPage({ textContent: null });
+    // (d) non-deleted, whitespace-only text (regex requires a non-space char).
+    await insertPage({ textContent: '   \n\t  ' });
+    // (e) deleted page WITH body text — excluded by the non-deleted predicate.
+    await insertPage({
+      textContent: 'deleted but had text',
+      deletedAt: new Date(),
+    });
+    // (f) non-deleted, no text, with ONLY a DELETED embedding row — the EXISTS
+    //     subquery filters pe.deleted_at IS NULL, so this stays out.
+    const onlyDeletedEmbedding = await insertPage({ textContent: null });
+    await insertEmbedding(onlyDeletedEmbedding, { deletedAt: new Date() });
+
+    const ids = await repo.getEmbeddablePageIds(workspaceId);
+    const count = await repo.countEmbeddablePages(workspaceId);
+
+    // The two queries agree on the size (the load-bearing lockstep invariant)...
+    expect(ids.length).toBe(count);
+    // ...and the set is exactly the two qualifying pages, nothing else.
+    expect(new Set(ids)).toEqual(new Set([withText, noTextLiveEmbedding]));
+    expect(count).toBe(2);
+  });
+});

packages/mcp/README.md

@@ -16,7 +16,7 @@ license.
 > that interface. Other Docmost MCPs are human-shaped — they expose "open the page" and
 > "replace the page"; this one exposes the editing primitives a model is good at.
 
-It exposes **40 tools** built around three ideas that the other Docmost MCPs do not
+It exposes **38 tools** built around three ideas that the other Docmost MCPs do not
 combine:
 
 1. **Surgical, token-cheap edits.** Address a single block by id and patch it, or run
@@ -106,7 +106,7 @@ There are several Docmost MCPs. Here is a capability-by-capability comparison.
 
 ## Tools
 
-All 40 tools, grouped by what you'd reach for them.
+All 38 tools, grouped by what you'd reach for them.
 
 ### Exploration & retrieval
 
@@ -203,14 +203,6 @@ All 40 tools, grouped by what you'd reach for them.
   node referencing the old attachment (recursively, including callouts/tables) via the
   live document, preserving comments, alignment and alt text. (In-place overwrite is
   deliberately avoided — some Docmost versions corrupt the attachment on overwrite.)
-- **`stash_page`** — Serialize a whole page (its full ProseMirror JSON) into an ephemeral
-  in-RAM blob and return ONLY a short anonymous URL — the body never enters the model
-  context, so it is the way to hand a large page (and its images) to an external consumer
-  without truncation. Every internal file/image attachment is mirrored into the same
-  sandbox and its `src` rewritten to a sandbox URL; external http(s) images are left
-  untouched. Returns `{ uri, size, sha256, images:{ mirrored, failed } }` (`sha256` is also
-  the blob's ETag). Blobs are RAM-only, expire after a short TTL (~1h) and are bound to the
-  server instance that created them.
 
 ### Comments
 

packages/mcp/README.ru.md

@@ -17,7 +17,7 @@
 > «открыть страницу» и «заменить страницу»; этот даёт примитивы редактирования, в которых
 > модель сильна.
 
-Сервер предоставляет **40 инструментов**, построенных вокруг трёх идей, которые другие
+Сервер предоставляет **38 инструментов**, построенных вокруг трёх идей, которые другие
 Docmost-MCP не сочетают:
 
 1. **Точечные, экономичные по токенам правки.** Адресуйте отдельный блок по id и патчите
@@ -109,7 +109,7 @@ Docmost-MCP не сочетают:
 
 ## Инструменты
 
-Все 40 инструментов, сгруппированы по задачам, для которых вы их возьмёте.
+Все 38 инструментов, сгруппированы по задачам, для которых вы их возьмёте.
 
 ### Чтение и поиск
 
@@ -209,15 +209,6 @@ Docmost-MCP не сочетают:
   коллауты/таблицы), через живой документ, сохраняя комментарии, выравнивание и alt-текст.
   (Перезапись «по месту» намеренно не используется — некоторые версии Docmost портят
   вложение при перезаписи.)
-- **`stash_page`** — Сериализовать страницу целиком (её полный ProseMirror JSON) в
-  эфемерный blob в оперативной памяти и вернуть ТОЛЬКО короткий анонимный URL — тело
-  никогда не попадает в контекст модели, поэтому это способ передать большую страницу
-  (вместе с её изображениями) внешнему потребителю без усечения. Каждое внутреннее
-  файловое/графическое вложение зеркалируется в тот же sandbox, а его `src` переписывается
-  на URL sandbox; внешние http(s)-изображения остаются нетронутыми. Возвращает
-  `{ uri, size, sha256, images:{ mirrored, failed } }` (`sha256` — это также ETag blob'а).
-  Blob'ы хранятся только в оперативной памяти, истекают через короткий TTL (~1 ч) и
-  привязаны к тому экземпляру сервера, который их создал.
 
 ### Комментарии
 

packages/mcp/build/client.js

@@ -7,7 +7,6 @@ import { TiptapTransformer } from "@hocuspocus/transformer";
 import * as Y from "yjs";
 import WebSocket from "ws";
 import { convertProseMirrorToMarkdown } from "./lib/markdown-converter.js";
-import { collectInternalFileNodes, normalizeFileUrl, resolveInternalFilePath, } from "./lib/internal-file-urls.js";
 import { updatePageContentRealtime, replacePageContent, markdownToProseMirror, markdownToProseMirrorCanonical, mutatePageContent, buildCollabWsUrl, assertYjsEncodable, applyDocToFragment, } from "./lib/collaboration.js";
 import { footnoteWarningsField } from "./lib/footnote-analyze.js";
 import { buildPageTree } from "./lib/tree.js";
@@ -52,13 +51,6 @@ export class DocmostClient {
     // its token instead of calling POST /auth/collab-token; on a 401/403 it is
     // re-invoked once. Used by the internal agent to carry signed provenance.
     getCollabTokenFn = null;
-    // Optional blob-sandbox sink for the stash tool. Null when not configured.
-    sandboxPut = null;
-    // Optional probes paired with the sink. `has` lets stashPage detect a blob
-    // FIFO-evicted by a LATER put in the same stash; `evict` lets it free this
-    // op's image blobs if the final doc put throws. Null when the sink omits them.
-    sandboxHas = null;
-    sandboxEvict = null;
     // In-flight login dedup: when the token expires, the 401 interceptor,
     // ensureAuthenticated, getCollabTokenWithReauth and the two multipart retries
     // can all call login() at once. Memoizing a single promise collapses that
@@ -85,11 +77,6 @@ export class DocmostClient {
         if (config.getCollabToken) {
             this.getCollabTokenFn = config.getCollabToken;
         }
-        if (config.sandbox) {
-            this.sandboxPut = config.sandbox.put;
-            this.sandboxHas = config.sandbox.has ?? null;
-            this.sandboxEvict = config.sandbox.evict ?? null;
-        }
         this.client = axios.create({
             baseURL: this.apiUrl,
             // Default request timeout so a hung connection cannot wedge a per-page
@@ -618,181 +605,6 @@ export class DocmostClient {
             content: data.content || { type: "doc", content: [] },
         };
     }
-    /**
-     * Fetch an INTERNAL Docmost file (authed loopback) for sandbox mirroring.
-     * `src` is normalized to `/api/files/<id>/<file>`; `this.client.baseURL`
-     * already ends in `/api`, so we strip the leading `/api` and request the
-     * relative path with the client's Authorization header. Returns the raw bytes
-     * and the response Content-Type (mime), defaulting to octet-stream.
-     *
-     * The fetch is size-bounded (hard 64 MiB ceiling) purely to protect memory;
-     * the authoritative per-blob cap is enforced by the sandbox `put`. The path is
-     * resolved via resolveInternalFilePath, which REJECTS (throws) any traversal
-     * or percent-encoded src that would let an attacker-controlled `attrs.src`
-     * escape `/api/files/` and reach another internal endpoint (SSRF). That throw
-     * happens before this.client.get, so a malicious src is counted as a failed
-     * mirror — it never reaches the network.
-     */
-    async fetchInternalFile(src) {
-        const HARD_CEILING = 64 * 1024 * 1024; // 64 MiB memory guard
-        const relPath = resolveInternalFilePath(src);
-        const response = await this.client.get(relPath, {
-            responseType: "arraybuffer",
-            timeout: 30000,
-            maxContentLength: HARD_CEILING,
-            maxBodyLength: HARD_CEILING,
-        });
-        const buffer = Buffer.from(response.data);
-        if (buffer.length === 0) {
-            throw new Error(`Empty file response from "${src}"`);
-        }
-        const rawCt = response.headers?.["content-type"];
-        const mime = typeof rawCt === "string" && rawCt.length > 0
-            ? rawCt.split(";")[0].trim().toLowerCase()
-            : "application/octet-stream";
-        return { buffer, mime };
-    }
-    /**
-     * Stash a page's full content into the in-RAM blob sandbox and return ONLY a
-     * short anonymous URL — the body never enters the model context (this is the
-     * whole point: ~30KB+ ProseMirror docs blow the model context if passed as a
-     * tool argument). Every INTERNAL file/image src (the type-agnostic criterion,
-     * so drawio/excalidraw/video/file nodes are covered too) is mirrored into the
-     * sandbox and its `src` rewritten to the sandbox URL, so an external consumer
-     * can fetch the images anonymously. External http(s) srcs are left untouched.
-     *
-     * Blobs live in RAM with a short TTL and are cleared on restart — consume the
-     * URLs within the TTL and one uptime. A failed image fetch never aborts the
-     * doc: the original src is kept and the failure counted.
-     *
-     * Returns { uri, sha256, size, images:{mirrored, failed} }. `uri` and `sha256`
-     * are for the document blob; `sha256` is also the blob's ETag (integrity).
-     */
-    async stashPage(pageId) {
-        if (!this.sandboxPut) {
-            throw new Error("stash_page is unavailable: the blob sandbox is not configured on this server");
-        }
-        await this.ensureAuthenticated();
-        // Stash the SAME shape get_page_json returns (id/title/.../content), with a
-        // deep clone so the rewrite never mutates anything shared.
-        const pageJson = await this.getPageJson(pageId);
-        const cloned = structuredClone(pageJson);
-        // Group internal-file nodes by normalized src so each unique resource is
-        // fetched + stored ONCE (dedup), and every node sharing that src points at
-        // the one sandbox blob. Capture each node's ORIGINAL raw src per-node:
-        // dedup groups nodes whose normalized src is equal even when their raw srcs
-        // differ (e.g. `/api/files/...` vs the bare `/files/...`), so on a revert we
-        // must restore each node's own original value, not the group key.
-        const bySrc = new Map();
-        for (const node of collectInternalFileNodes(cloned.content)) {
-            const origSrc = String(node.attrs.src);
-            const src = normalizeFileUrl(origSrc);
-            const entry = { node, origSrc };
-            const group = bySrc.get(src);
-            if (group)
-                group.push(entry);
-            else
-                bySrc.set(src, [entry]);
-        }
-        let mirrored = 0;
-        let failed = 0;
-        // Record every successful mirror so it can be (a) reverted if its blob gets
-        // FIFO-evicted by a LATER put in this same stash, and (b) freed if the final
-        // doc put throws.
-        const mirrors = [];
-        const MAX_CONCURRENCY = 5;
-        const groups = [...bySrc.entries()];
-        for (let i = 0; i < groups.length; i += MAX_CONCURRENCY) {
-            const batch = groups.slice(i, i + MAX_CONCURRENCY);
-            await Promise.all(batch.map(async ([src, entries]) => {
-                try {
-                    const { buffer, mime } = await this.fetchInternalFile(src);
-                    // put may throw if the blob exceeds the per-blob/total caps.
-                    const stored = this.sandboxPut(buffer, mime);
-                    for (const entry of entries)
-                        entry.node.attrs.src = stored.uri;
-                    mirrors.push({ uri: stored.uri, entries });
-                    mirrored++;
-                }
-                catch (err) {
-                    // One bad/oversized image (or a rejected traversal src) must not
-                    // abort the document. Logged unconditionally (never the blob body),
-                    // matching the package's ungated console.warn convention.
-                    failed++;
-                    console.warn(`stash_page: failed to mirror "${src}": ${err instanceof Error ? err.message : String(err)}`);
-                }
-            }));
-        }
-        // Revert one mirror's nodes to their original internal srcs and re-count it
-        // as failed (its blob was FIFO-evicted before the doc could reference it
-        // safely).
-        const revertMirror = (mirror) => {
-            for (const entry of mirror.entries)
-                entry.node.attrs.src = entry.origSrc;
-            mirrored--;
-            failed++;
-            console.warn(`stash_page: mirrored blob ${mirror.uri} was evicted before the doc ` +
-                `could safely reference it; reverted its src and counted it as failed`);
-        };
-        // Pre-put reconciliation: an image put earlier in THIS stash can FIFO-evict
-        // an even-earlier image of the same stash. Drop those from the live set
-        // first so the first serialized doc is already mostly correct.
-        let liveMirrors = mirrors;
-        if (this.sandboxHas) {
-            liveMirrors = [];
-            for (const mirror of mirrors) {
-                if (this.sandboxHas(mirror.uri))
-                    liveMirrors.push(mirror);
-                else
-                    revertMirror(mirror);
-            }
-        }
-        // Put the document, then reconcile against eviction caused by the doc put
-        // ITSELF (the doc is newest, FIFO drops oldest = this stash's images). Each
-        // iteration reverts >=1 mirror, so the loop terminates (worst case: all
-        // images reverted and the doc references no sandbox image URLs).
-        let stored;
-        for (;;) {
-            const docBuf = Buffer.from(JSON.stringify(cloned), "utf8");
-            let docStored;
-            try {
-                docStored = this.sandboxPut(docBuf, "application/json");
-            }
-            catch (err) {
-                // The doc put failed (e.g. doc exceeds the cap). Free this op's image
-                // blobs instead of leaking them in RAM for the whole TTL, then
-                // re-throw.
-                if (this.sandboxEvict) {
-                    for (const mirror of liveMirrors)
-                        this.sandboxEvict(mirror.uri);
-                }
-                throw err;
-            }
-            if (!this.sandboxHas) {
-                stored = docStored;
-                break;
-            }
-            const evictedNow = liveMirrors.filter((m) => !this.sandboxHas(m.uri));
-            if (evictedNow.length === 0) {
-                stored = docStored;
-                break;
-            }
-            // The doc we just stored references now-dead blobs. Revert those nodes,
-            // drop the stale doc blob, and loop to re-serialize + re-put the
-            // corrected doc.
-            for (const mirror of evictedNow)
-                revertMirror(mirror);
-            liveMirrors = liveMirrors.filter((m) => this.sandboxHas(m.uri));
-            if (this.sandboxEvict)
-                this.sandboxEvict(docStored.uri);
-        }
-        return {
-            uri: stored.uri,
-            sha256: stored.sha256,
-            size: stored.size,
-            images: { mirrored, failed },
-        };
-    }
     /**
      * Compact outline of a page's top-level blocks (no full document body).
      * Cheap way to locate sections/tables and grab block ids before drilling in

packages/mcp/build/index.js

@@ -285,38 +285,6 @@ export function createDocmostMcpServer(config) {
         const result = await docmostClient.editPageText(pageId, edits);
         return jsonContent(result);
     });
-    // Tool: stash_page — returns a resource_link (NOT embedded text) so the doc
-    // body never enters the model context. Registered directly (not via
-    // registerShared) because that helper only emits text content. Also returns
-    // `structuredContent` carrying the full documented `{uri, sha256, size, images}`
-    // shape alongside the resource_link, so MCP clients receive the blob's sha256
-    // (its ETag, for integrity) and mirror counts, not just the link.
-    server.registerTool(SHARED_TOOL_SPECS.stashPage.mcpName, {
-        description: SHARED_TOOL_SPECS.stashPage.description,
-        inputSchema: SHARED_TOOL_SPECS.stashPage.buildShape(z),
-    }, async ({ pageId }) => {
-        const result = await docmostClient.stashPage(pageId);
-        return {
-            content: [
-                {
-                    type: "resource_link",
-                    uri: result.uri,
-                    name: "page.json",
-                    mimeType: "application/json",
-                    size: result.size,
-                },
-            ],
-            // Mirror the full documented result shape ({ uri, size, sha256, images })
-            // as structuredContent so MCP clients get the blob's sha256 (its ETag, for
-            // integrity) and the mirror counts, not just the resource_link.
-            structuredContent: {
-                uri: result.uri,
-                sha256: result.sha256,
-                size: result.size,
-                images: result.images,
-            },
-        };
-    });
     // Tool: patch_node
     server.registerTool("patch_node", {
         description: "Replaces a single block identified by its attrs.id WITHOUT resending the " +

packages/mcp/build/lib/internal-file-urls.js

@@ -1,110 +0,0 @@
-// Detection + collection of INTERNAL Docmost file URLs inside a ProseMirror doc.
-//
-// An internal file URL is a relative path served by Docmost's authenticated
-// attachment route (`GET /api/files/:fileId/:fileName`). It is useless to an
-// external consumer (relative + needs a Docmost session), so the stash tool
-// mirrors every such resource into the blob sandbox and rewrites its `src`.
-//
-// The criterion is "internal file URL", NOT the node TYPE: image, drawio,
-// excalidraw, video and file nodes all carry such a `src`, so a type-agnostic
-// walker covers them all. External http(s) srcs (CDNs) are left untouched.
-//
-// Mirrors editor-ext's isInternalFileUrl / normalizeFileUrl (kept as a local
-// dup so the ESM mcp package does not depend on the editor-ext build).
-function isInternalFileUrl(url) {
-    if (typeof url !== "string")
-        return false;
-    const normalized = url.trim();
-    return (normalized.startsWith("/api/files/") || normalized.startsWith("/files/"));
-}
-/** Normalize a bare `/files/...` src to the canonical `/api/files/...` form. */
-export function normalizeFileUrl(src) {
-    const trimmed = src.trim();
-    if (trimmed.startsWith("/files/"))
-        return "/api" + trimmed;
-    return trimmed;
-}
-/**
- * Resolve a page-content `src` into the safe, `/api`-relative path the stash
- * tool may fetch over the authenticated loopback client — or THROW.
- *
- * SECURITY (SSRF / path-traversal): `src` comes from page content and is fully
- * attacker-controllable. The mirroring fetch runs through the AUTHENTICATED
- * loopback axios client whose baseURL ends in `/api`, so a naive
- * `src.replace(/^\/api/, "")` lets a crafted value like
- * `/api/files/../auth/whoami` collapse (via axios/WHATWG URL `..` resolution)
- * into an ARBITRARY internal GET endpoint, whose authed response would then be
- * stored in the anonymous sandbox (SSRF + data exfiltration). A prefix-only
- * `startsWith("/api/files/")` check does NOT defend against this because the
- * `..` segments are still present in the raw string and resolved later.
- *
- * This function defeats that by resolving the canonical pathname FIRST and only
- * then asserting it still lives under `/api/files/`:
- *  - it rejects any percent-encoded dot/slash (`%2e` / `%2f`): the WHATWG URL
- *    parser collapses LITERAL `../` but does NOT decode `%2f` separators, so a
- *    content-controlled src must never be allowed to smuggle those past the
- *    canonicalization;
- *  - it resolves `new URL(trimmed, "http://internal.invalid").pathname`, which
- *    normalizes `..`/`.` segments (e.g. `/api/files/../auth/whoami` →
- *    `/api/auth/whoami`);
- *  - it then requires the canonical pathname to start with `/api/files/`, so a
- *    traversal that escaped that subtree is rejected.
- *
- * Returns the path RELATIVE to the `/api` base (e.g. `/files/<id>/<name>`),
- * ready to hand to the loopback client. The throw happens BEFORE any network
- * call, so a rejected src is counted as a failed mirror and its original src is
- * kept (the per-image try/catch in stashPage never aborts the whole document).
- */
-export function resolveInternalFilePath(src) {
-    const trimmed = src.trim();
-    // Percent-encoded dot/slash must never reach the URL canonicalizer: the
-    // WHATWG parser does NOT decode `%2f` into a path separator, so an encoded
-    // `..%2fauth` would survive canonicalization and still escape /api/files/.
-    if (/%2e|%2f/i.test(trimmed)) {
-        throw new Error(`Refusing internal file src with percent-encoded path segment: "${src}"`);
-    }
-    let pathname;
-    try {
-        // The base host is irrelevant (never contacted); it only lets the parser
-        // resolve a relative `src` and normalize `..`/`.` segments.
-        pathname = new URL(trimmed, "http://internal.invalid").pathname;
-    }
-    catch {
-        throw new Error(`Invalid internal file src: "${src}"`);
-    }
-    if (!pathname.startsWith("/api/files/")) {
-        throw new Error(`Refusing internal file src that escapes /api/files/: "${src}"`);
-    }
-    // Strip the `/api` base prefix; the loopback client's baseURL already ends
-    // in `/api`, so it expects the path relative to that (e.g. /files/<id>/<f>).
-    return pathname.replace(/^\/api/, "");
-}
-/**
- * Recursively collect every node whose `attrs.src` is an internal file URL.
- * Returns references to the live nodes (so the caller can rewrite `attrs.src`
- * in place on its clone). Descends `content` arrays, covering callouts, tables,
- * details and any other nested container.
- */
-export function collectInternalFileNodes(doc) {
-    const out = [];
-    const visit = (node) => {
-        if (!node)
-            return;
-        if (Array.isArray(node)) {
-            for (const child of node)
-                visit(child);
-            return;
-        }
-        if (typeof node !== "object")
-            return;
-        if (node.attrs && isInternalFileUrl(node.attrs.src)) {
-            out.push(node);
-        }
-        if (Array.isArray(node.content)) {
-            for (const child of node.content)
-                visit(child);
-        }
-    };
-    visit(doc);
-    return out;
-}

packages/mcp/build/tool-specs.js

@@ -209,27 +209,4 @@ export const SHARED_TOOL_SPECS = {
                 .describe('List of find/replace operations, applied in order'),
         }),
     },
-    // --- hand a large page to an external consumer without bloating context ---
-    stashPage: {
-        mcpName: 'stash_page',
-        inAppKey: 'stashPage',
-        description: 'Serialize a whole page (the full ProseMirror JSON, as get_page_json ' +
-            'returns) into an ephemeral in-memory blob and return ONLY a short ' +
-            'anonymous URL to it — the body NEVER enters the model context, so this ' +
-            'is the way to hand a large page (or its images) to an external consumer ' +
-            'without truncation. Every internal file/image attachment is mirrored ' +
-            'into the same sandbox and its src rewritten to a sandbox URL, so the ' +
-            'consumer can fetch the images anonymously too; external http(s) images ' +
-            'are left untouched. Returns { uri, size, sha256, images:{mirrored, ' +
-            'failed} }. Integrity: the blob is served with ETag = its sha256, so a ' +
-            'truncated/corrupted fetch is detectable. Blobs are RAM-only: they expire ' +
-            'after a short TTL (~1h) and are cleared on restart — consume the URL ' +
-            'within the TTL and one uptime, or re-stash. A blob is bound to the ' +
-            'server instance that created it: in a multi-replica deployment without ' +
-            'sticky sessions a blob stored on one instance is not retrievable via the ' +
-            'sandbox URL on another (it 404s like an expired one).',
-        buildShape: (z) => ({
-            pageId: z.string().min(1),
-        }),
-    },
 };

packages/mcp/src/client.ts

@@ -13,11 +13,6 @@ import { TiptapTransformer } from "@hocuspocus/transformer";
 import * as Y from "yjs";
 import WebSocket from "ws";
 import { convertProseMirrorToMarkdown } from "./lib/markdown-converter.js";
-import {
-  collectInternalFileNodes,
-  normalizeFileUrl,
-  resolveInternalFilePath,
-} from "./lib/internal-file-urls.js";
 import {
   updatePageContentRealtime,
   replacePageContent,
@@ -107,14 +102,6 @@ const MIME_TO_EXT: Record<string, string> = {
  * Housed here (not in index.ts) so client.ts has no type dependency on index.ts;
  * index.ts re-exports it for the package's public surface.
  */
-// Sink the stash tool writes blobs into. The host app binds this to its in-RAM
-// SandboxStore and composes the public `uri` (the package never sees the store
-// or any env). `put` returns the anonymous read URL plus integrity metadata.
-export type SandboxPut = (
-  buf: Buffer,
-  mime: string,
-) => { uri: string; sha256: string; size: number };
-
 export type DocmostMcpConfig = { apiUrl: string } & (
   | { email: string; password: string }
   | { getToken: () => Promise<string> } // returns a BARE JWT; the client adds "Bearer "
@@ -122,15 +109,6 @@ export type DocmostMcpConfig = { apiUrl: string } & (
     // Optional collab-token provider (returns a ready collab JWT). Common to
     // both branches; see the type doc above.
     getCollabToken?: () => Promise<string>;
-    // Optional blob sandbox sink. Present only where the stash tool is wired;
-    // when absent, stash_page throws a clear "not configured" error. The
-    // optional `has`/`evict` probes let stashPage keep its mirror counts honest
-    // under the store's FIFO eviction (see stashPage); older sinks omit them.
-    sandbox?: {
-      put: SandboxPut;
-      has?: (uri: string) => boolean;
-      evict?: (uri: string) => void;
-    };
   };
 
 export class DocmostClient {
@@ -148,13 +126,6 @@ export class DocmostClient {
   // its token instead of calling POST /auth/collab-token; on a 401/403 it is
   // re-invoked once. Used by the internal agent to carry signed provenance.
   private getCollabTokenFn: (() => Promise<string>) | null = null;
-  // Optional blob-sandbox sink for the stash tool. Null when not configured.
-  private sandboxPut: SandboxPut | null = null;
-  // Optional probes paired with the sink. `has` lets stashPage detect a blob
-  // FIFO-evicted by a LATER put in the same stash; `evict` lets it free this
-  // op's image blobs if the final doc put throws. Null when the sink omits them.
-  private sandboxHas: ((uri: string) => boolean) | null = null;
-  private sandboxEvict: ((uri: string) => void) | null = null;
   // In-flight login dedup: when the token expires, the 401 interceptor,
   // ensureAuthenticated, getCollabTokenWithReauth and the two multipart retries
   // can all call login() at once. Memoizing a single promise collapses that
@@ -194,11 +165,6 @@ export class DocmostClient {
     if (config.getCollabToken) {
       this.getCollabTokenFn = config.getCollabToken;
     }
-    if (config.sandbox) {
-      this.sandboxPut = config.sandbox.put;
-      this.sandboxHas = config.sandbox.has ?? null;
-      this.sandboxEvict = config.sandbox.evict ?? null;
-    }
     this.client = axios.create({
       baseURL: this.apiUrl,
       // Default request timeout so a hung connection cannot wedge a per-page
@@ -801,203 +767,6 @@ export class DocmostClient {
     };
   }
 
-  /**
-   * Fetch an INTERNAL Docmost file (authed loopback) for sandbox mirroring.
-   * `src` is normalized to `/api/files/<id>/<file>`; `this.client.baseURL`
-   * already ends in `/api`, so we strip the leading `/api` and request the
-   * relative path with the client's Authorization header. Returns the raw bytes
-   * and the response Content-Type (mime), defaulting to octet-stream.
-   *
-   * The fetch is size-bounded (hard 64 MiB ceiling) purely to protect memory;
-   * the authoritative per-blob cap is enforced by the sandbox `put`. The path is
-   * resolved via resolveInternalFilePath, which REJECTS (throws) any traversal
-   * or percent-encoded src that would let an attacker-controlled `attrs.src`
-   * escape `/api/files/` and reach another internal endpoint (SSRF). That throw
-   * happens before this.client.get, so a malicious src is counted as a failed
-   * mirror — it never reaches the network.
-   */
-  private async fetchInternalFile(
-    src: string,
-  ): Promise<{ buffer: Buffer; mime: string }> {
-    const HARD_CEILING = 64 * 1024 * 1024; // 64 MiB memory guard
-    const relPath = resolveInternalFilePath(src);
-    const response = await this.client.get(relPath, {
-      responseType: "arraybuffer",
-      timeout: 30000,
-      maxContentLength: HARD_CEILING,
-      maxBodyLength: HARD_CEILING,
-    });
-    const buffer = Buffer.from(response.data);
-    if (buffer.length === 0) {
-      throw new Error(`Empty file response from "${src}"`);
-    }
-    const rawCt = response.headers?.["content-type"];
-    const mime =
-      typeof rawCt === "string" && rawCt.length > 0
-        ? rawCt.split(";")[0].trim().toLowerCase()
-        : "application/octet-stream";
-    return { buffer, mime };
-  }
-
-  /**
-   * Stash a page's full content into the in-RAM blob sandbox and return ONLY a
-   * short anonymous URL — the body never enters the model context (this is the
-   * whole point: ~30KB+ ProseMirror docs blow the model context if passed as a
-   * tool argument). Every INTERNAL file/image src (the type-agnostic criterion,
-   * so drawio/excalidraw/video/file nodes are covered too) is mirrored into the
-   * sandbox and its `src` rewritten to the sandbox URL, so an external consumer
-   * can fetch the images anonymously. External http(s) srcs are left untouched.
-   *
-   * Blobs live in RAM with a short TTL and are cleared on restart — consume the
-   * URLs within the TTL and one uptime. A failed image fetch never aborts the
-   * doc: the original src is kept and the failure counted.
-   *
-   * Returns { uri, sha256, size, images:{mirrored, failed} }. `uri` and `sha256`
-   * are for the document blob; `sha256` is also the blob's ETag (integrity).
-   */
-  async stashPage(pageId: string): Promise<{
-    uri: string;
-    sha256: string;
-    size: number;
-    images: { mirrored: number; failed: number };
-  }> {
-    if (!this.sandboxPut) {
-      throw new Error(
-        "stash_page is unavailable: the blob sandbox is not configured on this server",
-      );
-    }
-    await this.ensureAuthenticated();
-
-    // Stash the SAME shape get_page_json returns (id/title/.../content), with a
-    // deep clone so the rewrite never mutates anything shared.
-    const pageJson = await this.getPageJson(pageId);
-    const cloned: any = structuredClone(pageJson);
-
-    // Group internal-file nodes by normalized src so each unique resource is
-    // fetched + stored ONCE (dedup), and every node sharing that src points at
-    // the one sandbox blob. Capture each node's ORIGINAL raw src per-node:
-    // dedup groups nodes whose normalized src is equal even when their raw srcs
-    // differ (e.g. `/api/files/...` vs the bare `/files/...`), so on a revert we
-    // must restore each node's own original value, not the group key.
-    const bySrc = new Map<string, Array<{ node: any; origSrc: string }>>();
-    for (const node of collectInternalFileNodes(cloned.content)) {
-      const origSrc = String(node.attrs.src);
-      const src = normalizeFileUrl(origSrc);
-      const entry = { node, origSrc };
-      const group = bySrc.get(src);
-      if (group) group.push(entry);
-      else bySrc.set(src, [entry]);
-    }
-
-    let mirrored = 0;
-    let failed = 0;
-    // Record every successful mirror so it can be (a) reverted if its blob gets
-    // FIFO-evicted by a LATER put in this same stash, and (b) freed if the final
-    // doc put throws.
-    const mirrors: Array<{
-      uri: string;
-      entries: Array<{ node: any; origSrc: string }>;
-    }> = [];
-    const MAX_CONCURRENCY = 5;
-    const groups = [...bySrc.entries()];
-    for (let i = 0; i < groups.length; i += MAX_CONCURRENCY) {
-      const batch = groups.slice(i, i + MAX_CONCURRENCY);
-      await Promise.all(
-        batch.map(async ([src, entries]) => {
-          try {
-            const { buffer, mime } = await this.fetchInternalFile(src);
-            // put may throw if the blob exceeds the per-blob/total caps.
-            const stored = this.sandboxPut!(buffer, mime);
-            for (const entry of entries) entry.node.attrs.src = stored.uri;
-            mirrors.push({ uri: stored.uri, entries });
-            mirrored++;
-          } catch (err) {
-            // One bad/oversized image (or a rejected traversal src) must not
-            // abort the document. Logged unconditionally (never the blob body),
-            // matching the package's ungated console.warn convention.
-            failed++;
-            console.warn(
-              `stash_page: failed to mirror "${src}": ${
-                err instanceof Error ? err.message : String(err)
-              }`,
-            );
-          }
-        }),
-      );
-    }
-
-    // Revert one mirror's nodes to their original internal srcs and re-count it
-    // as failed (its blob was FIFO-evicted before the doc could reference it
-    // safely).
-    const revertMirror = (mirror: {
-      uri: string;
-      entries: Array<{ node: any; origSrc: string }>;
-    }) => {
-      for (const entry of mirror.entries) entry.node.attrs.src = entry.origSrc;
-      mirrored--;
-      failed++;
-      console.warn(
-        `stash_page: mirrored blob ${mirror.uri} was evicted before the doc ` +
-          `could safely reference it; reverted its src and counted it as failed`,
-      );
-    };
-
-    // Pre-put reconciliation: an image put earlier in THIS stash can FIFO-evict
-    // an even-earlier image of the same stash. Drop those from the live set
-    // first so the first serialized doc is already mostly correct.
-    let liveMirrors = mirrors;
-    if (this.sandboxHas) {
-      liveMirrors = [];
-      for (const mirror of mirrors) {
-        if (this.sandboxHas(mirror.uri)) liveMirrors.push(mirror);
-        else revertMirror(mirror);
-      }
-    }
-
-    // Put the document, then reconcile against eviction caused by the doc put
-    // ITSELF (the doc is newest, FIFO drops oldest = this stash's images). Each
-    // iteration reverts >=1 mirror, so the loop terminates (worst case: all
-    // images reverted and the doc references no sandbox image URLs).
-    let stored: { uri: string; sha256: string; size: number };
-    for (;;) {
-      const docBuf = Buffer.from(JSON.stringify(cloned), "utf8");
-      let docStored: { uri: string; sha256: string; size: number };
-      try {
-        docStored = this.sandboxPut(docBuf, "application/json");
-      } catch (err) {
-        // The doc put failed (e.g. doc exceeds the cap). Free this op's image
-        // blobs instead of leaking them in RAM for the whole TTL, then
-        // re-throw.
-        if (this.sandboxEvict) {
-          for (const mirror of liveMirrors) this.sandboxEvict(mirror.uri);
-        }
-        throw err;
-      }
-
-      if (!this.sandboxHas) {
-        stored = docStored;
-        break;
-      }
-      const evictedNow = liveMirrors.filter((m) => !this.sandboxHas!(m.uri));
-      if (evictedNow.length === 0) {
-        stored = docStored;
-        break;
-      }
-      // The doc we just stored references now-dead blobs. Revert those nodes,
-      // drop the stale doc blob, and loop to re-serialize + re-put the
-      // corrected doc.
-      for (const mirror of evictedNow) revertMirror(mirror);
-      liveMirrors = liveMirrors.filter((m) => this.sandboxHas!(m.uri));
-      if (this.sandboxEvict) this.sandboxEvict(docStored.uri);
-    }
-    return {
-      uri: stored.uri,
-      sha256: stored.sha256,
-      size: stored.size,
-      images: { mirrored, failed },
-    };
-  }
-
   /**
    * Compact outline of a page's top-level blocks (no full document body).
    * Cheap way to locate sections/tables and grab block ids before drilling in

packages/mcp/src/index.ts

@@ -408,43 +408,6 @@ registerShared(SHARED_TOOL_SPECS.editPageText, async ({ pageId, edits }) => {
   return jsonContent(result);
 });
 
-// Tool: stash_page — returns a resource_link (NOT embedded text) so the doc
-// body never enters the model context. Registered directly (not via
-// registerShared) because that helper only emits text content. Also returns
-// `structuredContent` carrying the full documented `{uri, sha256, size, images}`
-// shape alongside the resource_link, so MCP clients receive the blob's sha256
-// (its ETag, for integrity) and mirror counts, not just the link.
-server.registerTool(
-  SHARED_TOOL_SPECS.stashPage.mcpName,
-  {
-    description: SHARED_TOOL_SPECS.stashPage.description,
-    inputSchema: SHARED_TOOL_SPECS.stashPage.buildShape!(z),
-  },
-  async ({ pageId }: { pageId: string }) => {
-    const result = await docmostClient.stashPage(pageId);
-    return {
-      content: [
-        {
-          type: "resource_link" as const,
-          uri: result.uri,
-          name: "page.json",
-          mimeType: "application/json",
-          size: result.size,
-        },
-      ],
-      // Mirror the full documented result shape ({ uri, size, sha256, images })
-      // as structuredContent so MCP clients get the blob's sha256 (its ETag, for
-      // integrity) and the mirror counts, not just the resource_link.
-      structuredContent: {
-        uri: result.uri,
-        sha256: result.sha256,
-        size: result.size,
-        images: result.images,
-      },
-    };
-  },
-);
-
 // Tool: patch_node
 server.registerTool(
   "patch_node",

packages/mcp/src/lib/internal-file-urls.ts

@@ -1,113 +0,0 @@
-// Detection + collection of INTERNAL Docmost file URLs inside a ProseMirror doc.
-//
-// An internal file URL is a relative path served by Docmost's authenticated
-// attachment route (`GET /api/files/:fileId/:fileName`). It is useless to an
-// external consumer (relative + needs a Docmost session), so the stash tool
-// mirrors every such resource into the blob sandbox and rewrites its `src`.
-//
-// The criterion is "internal file URL", NOT the node TYPE: image, drawio,
-// excalidraw, video and file nodes all carry such a `src`, so a type-agnostic
-// walker covers them all. External http(s) srcs (CDNs) are left untouched.
-//
-// Mirrors editor-ext's isInternalFileUrl / normalizeFileUrl (kept as a local
-// dup so the ESM mcp package does not depend on the editor-ext build).
-
-function isInternalFileUrl(url: unknown): boolean {
-  if (typeof url !== "string") return false;
-  const normalized = url.trim();
-  return (
-    normalized.startsWith("/api/files/") || normalized.startsWith("/files/")
-  );
-}
-
-/** Normalize a bare `/files/...` src to the canonical `/api/files/...` form. */
-export function normalizeFileUrl(src: string): string {
-  const trimmed = src.trim();
-  if (trimmed.startsWith("/files/")) return "/api" + trimmed;
-  return trimmed;
-}
-
-/**
- * Resolve a page-content `src` into the safe, `/api`-relative path the stash
- * tool may fetch over the authenticated loopback client — or THROW.
- *
- * SECURITY (SSRF / path-traversal): `src` comes from page content and is fully
- * attacker-controllable. The mirroring fetch runs through the AUTHENTICATED
- * loopback axios client whose baseURL ends in `/api`, so a naive
- * `src.replace(/^\/api/, "")` lets a crafted value like
- * `/api/files/../auth/whoami` collapse (via axios/WHATWG URL `..` resolution)
- * into an ARBITRARY internal GET endpoint, whose authed response would then be
- * stored in the anonymous sandbox (SSRF + data exfiltration). A prefix-only
- * `startsWith("/api/files/")` check does NOT defend against this because the
- * `..` segments are still present in the raw string and resolved later.
- *
- * This function defeats that by resolving the canonical pathname FIRST and only
- * then asserting it still lives under `/api/files/`:
- *  - it rejects any percent-encoded dot/slash (`%2e` / `%2f`): the WHATWG URL
- *    parser collapses LITERAL `../` but does NOT decode `%2f` separators, so a
- *    content-controlled src must never be allowed to smuggle those past the
- *    canonicalization;
- *  - it resolves `new URL(trimmed, "http://internal.invalid").pathname`, which
- *    normalizes `..`/`.` segments (e.g. `/api/files/../auth/whoami` →
- *    `/api/auth/whoami`);
- *  - it then requires the canonical pathname to start with `/api/files/`, so a
- *    traversal that escaped that subtree is rejected.
- *
- * Returns the path RELATIVE to the `/api` base (e.g. `/files/<id>/<name>`),
- * ready to hand to the loopback client. The throw happens BEFORE any network
- * call, so a rejected src is counted as a failed mirror and its original src is
- * kept (the per-image try/catch in stashPage never aborts the whole document).
- */
-export function resolveInternalFilePath(src: string): string {
-  const trimmed = src.trim();
-  // Percent-encoded dot/slash must never reach the URL canonicalizer: the
-  // WHATWG parser does NOT decode `%2f` into a path separator, so an encoded
-  // `..%2fauth` would survive canonicalization and still escape /api/files/.
-  if (/%2e|%2f/i.test(trimmed)) {
-    throw new Error(
-      `Refusing internal file src with percent-encoded path segment: "${src}"`,
-    );
-  }
-  let pathname: string;
-  try {
-    // The base host is irrelevant (never contacted); it only lets the parser
-    // resolve a relative `src` and normalize `..`/`.` segments.
-    pathname = new URL(trimmed, "http://internal.invalid").pathname;
-  } catch {
-    throw new Error(`Invalid internal file src: "${src}"`);
-  }
-  if (!pathname.startsWith("/api/files/")) {
-    throw new Error(
-      `Refusing internal file src that escapes /api/files/: "${src}"`,
-    );
-  }
-  // Strip the `/api` base prefix; the loopback client's baseURL already ends
-  // in `/api`, so it expects the path relative to that (e.g. /files/<id>/<f>).
-  return pathname.replace(/^\/api/, "");
-}
-
-/**
- * Recursively collect every node whose `attrs.src` is an internal file URL.
- * Returns references to the live nodes (so the caller can rewrite `attrs.src`
- * in place on its clone). Descends `content` arrays, covering callouts, tables,
- * details and any other nested container.
- */
-export function collectInternalFileNodes(doc: unknown): any[] {
-  const out: any[] = [];
-  const visit = (node: any): void => {
-    if (!node) return;
-    if (Array.isArray(node)) {
-      for (const child of node) visit(child);
-      return;
-    }
-    if (typeof node !== "object") return;
-    if (node.attrs && isInternalFileUrl(node.attrs.src)) {
-      out.push(node);
-    }
-    if (Array.isArray(node.content)) {
-      for (const child of node.content) visit(child);
-    }
-  };
-  visit(doc);
-  return out;
-}

packages/mcp/src/tool-specs.ts

@@ -266,29 +266,4 @@ export const SHARED_TOOL_SPECS = {
         .describe('List of find/replace operations, applied in order'),
     }),
   },
-
-  // --- hand a large page to an external consumer without bloating context ---
-  stashPage: {
-    mcpName: 'stash_page',
-    inAppKey: 'stashPage',
-    description:
-      'Serialize a whole page (the full ProseMirror JSON, as get_page_json ' +
-      'returns) into an ephemeral in-memory blob and return ONLY a short ' +
-      'anonymous URL to it — the body NEVER enters the model context, so this ' +
-      'is the way to hand a large page (or its images) to an external consumer ' +
-      'without truncation. Every internal file/image attachment is mirrored ' +
-      'into the same sandbox and its src rewritten to a sandbox URL, so the ' +
-      'consumer can fetch the images anonymously too; external http(s) images ' +
-      'are left untouched. Returns { uri, size, sha256, images:{mirrored, ' +
-      'failed} }. Integrity: the blob is served with ETag = its sha256, so a ' +
-      'truncated/corrupted fetch is detectable. Blobs are RAM-only: they expire ' +
-      'after a short TTL (~1h) and are cleared on restart — consume the URL ' +
-      'within the TTL and one uptime, or re-stash. A blob is bound to the ' +
-      'server instance that created it: in a multi-replica deployment without ' +
-      'sticky sessions a blob stored on one instance is not retrievable via the ' +
-      'sandbox URL on another (it 404s like an expired one).',
-    buildShape: (z) => ({
-      pageId: z.string().min(1),
-    }),
-  },
 } satisfies Record<string, SharedToolSpec>;

packages/mcp/test/mock/stash-page-mcp-result.test.mjs

@@ -1,155 +0,0 @@
-// Server round-trip test for the stash_page MCP tool result shape. The in-app
-// path returns the full documented `{ uri, size, sha256, images }` object, but
-// the MCP transport must deliver the SAME shape: a resource_link (primary
-// payload) PLUS a `structuredContent` mirror carrying sha256 + image counts.
-// This connects a real MCP Client to the server over a linked in-memory
-// transport pair and asserts both halves of the result, end to end.
-import { test, after } from "node:test";
-import assert from "node:assert/strict";
-import http from "node:http";
-import { createHash } from "node:crypto";
-import { createDocmostMcpServer } from "../../build/index.js";
-import { Client } from "@modelcontextprotocol/sdk/client/index.js";
-import { InMemoryTransport } from "@modelcontextprotocol/sdk/inMemory.js";
-
-function readBody(req) {
-  return new Promise((resolve) => {
-    let raw = "";
-    req.on("data", (c) => (raw += c));
-    req.on("end", () => resolve(raw));
-  });
-}
-
-function startServer(handler) {
-  return new Promise((resolve) => {
-    const server = http.createServer(handler);
-    server.listen(0, "127.0.0.1", () => {
-      const { port } = server.address();
-      resolve({ server, baseURL: `http://127.0.0.1:${port}/api` });
-    });
-  });
-}
-
-const openServers = [];
-async function spawn(handler) {
-  const { server, baseURL } = await startServer(handler);
-  openServers.push(server);
-  return baseURL;
-}
-after(async () => {
-  await Promise.all(openServers.map((s) => new Promise((r) => s.close(r))));
-});
-
-// Minimal in-memory sandbox sink: store the blob and return a uri + sha256 +
-// size, with has/evict probes the client's reconciliation may call.
-function makeSandbox() {
-  const live = new Map();
-  const idOf = (uri) => uri.substring(uri.lastIndexOf("/") + 1);
-  let n = 0;
-  return {
-    put(buf) {
-      const sha256 = createHash("sha256").update(buf).digest("hex");
-      const id = `id-${n++}`;
-      live.set(id, buf.length);
-      return { uri: `https://sb.test/api/sb/${id}`, sha256, size: buf.length };
-    },
-    has(uri) {
-      return live.has(idOf(uri));
-    },
-    evict(uri) {
-      live.delete(idOf(uri));
-    },
-  };
-}
-
-const IMAGE_BYTES = Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a]);
-
-// One internal image (so images.mirrored === 1) inside a normal page doc.
-function pageDoc() {
-  return {
-    type: "doc",
-    content: [
-      {
-        type: "image",
-        attrs: { src: "/api/files/att-1/pic.png", attachmentId: "att-1" },
-      },
-    ],
-  };
-}
-
-// Mock Docmost: login, page info, internal file bytes — same pattern as
-// stash-page.test.mjs.
-async function buildBaseURL() {
-  return spawn(async (req, res) => {
-    await readBody(req);
-    if (req.url === "/api/auth/login") {
-      res.writeHead(200, {
-        "Content-Type": "application/json",
-        "Set-Cookie": "authToken=tok; HttpOnly",
-      });
-      res.end(JSON.stringify({ token: "tok" }));
-      return;
-    }
-    if (req.url === "/api/pages/info") {
-      res.writeHead(200, { "Content-Type": "application/json" });
-      res.end(
-        JSON.stringify({ data: { id: "page-1", title: "T", content: pageDoc() } }),
-      );
-      return;
-    }
-    if (req.url.startsWith("/api/files/")) {
-      res.writeHead(200, { "Content-Type": "image/png" });
-      res.end(IMAGE_BYTES);
-      return;
-    }
-    res.writeHead(404);
-    res.end();
-  });
-}
-
-test("stash_page MCP tool returns a resource_link AND a structuredContent mirror", async () => {
-  const baseURL = await buildBaseURL();
-  const sandbox = makeSandbox();
-  const server = createDocmostMcpServer({
-    apiUrl: baseURL,
-    email: "u@example.com",
-    password: "pw",
-    sandbox,
-  });
-
-  const client = new Client({ name: "test-client", version: "0.0.0" });
-  const [a, b] = InMemoryTransport.createLinkedPair();
-  await server.connect(b);
-  await client.connect(a);
-
-  try {
-    const res = await client.callTool({
-      name: "stash_page",
-      arguments: { pageId: "page-1" },
-    });
-
-    // Primary payload: a resource_link pointing at the sandbox doc blob.
-    const link = res.content[0];
-    assert.equal(link.type, "resource_link");
-    assert.match(link.uri, /^https:\/\/sb\.test\/api\/sb\//);
-
-    // structuredContent mirrors the full documented shape.
-    const sc = res.structuredContent;
-    assert.equal(typeof sc, "object");
-    assert.equal(sc.uri, link.uri); // same blob as the link
-    assert.match(sc.sha256, /^[0-9a-f]{64}$/); // 64-hex ETag
-    assert.equal(typeof sc.size, "number");
-    assert.deepEqual(sc.images, { mirrored: 1, failed: 0 });
-
-    // Deep-equal the whole structured payload against what the mock implies.
-    assert.deepEqual(sc, {
-      uri: link.uri,
-      sha256: sc.sha256,
-      size: sc.size,
-      images: { mirrored: 1, failed: 0 },
-    });
-  } finally {
-    await client.close();
-    await server.close();
-  }
-});

packages/mcp/test/mock/stash-page.test.mjs

@@ -1,378 +0,0 @@
-// Mock-HTTP test for DocmostClient.stashPage: a local http server stands in for
-// Docmost so the whole flow stays deterministic and offline. Asserts the tool
-// (1) serializes the page into the sandbox and returns ONLY a link (uri + sha256
-// + size), never the body; (2) mirrors INTERNAL image srcs into the sandbox and
-// rewrites them to the sandbox uri; (3) leaves EXTERNAL http(s) srcs untouched;
-// (4) de-duplicates a repeated internal src to a single blob; (5) counts a
-// failed image fetch without aborting the document.
-import { test, after } from "node:test";
-import assert from "node:assert/strict";
-import http from "node:http";
-import { createHash } from "node:crypto";
-import { DocmostClient } from "../../build/client.js";
-
-function readBody(req) {
-  return new Promise((resolve) => {
-    let raw = "";
-    req.on("data", (c) => (raw += c));
-    req.on("end", () => resolve(raw));
-  });
-}
-
-function startServer(handler) {
-  return new Promise((resolve) => {
-    const server = http.createServer(handler);
-    server.listen(0, "127.0.0.1", () => {
-      const { port } = server.address();
-      resolve({ server, baseURL: `http://127.0.0.1:${port}/api` });
-    });
-  });
-}
-
-const openServers = [];
-async function spawn(handler) {
-  const { server, baseURL } = await startServer(handler);
-  openServers.push(server);
-  return baseURL;
-}
-after(async () => {
-  await Promise.all(openServers.map((s) => new Promise((r) => s.close(r))));
-});
-
-// In-memory sandbox sink mirroring the host binding: store the blob, return a
-// uri + sha256 + size. Records every put so the test can inspect what was
-// stashed (and verify the doc body never leaves via the return value). Models
-// the real store's FIFO eviction + cap + the has/evict probes so B1 (self-
-// eviction reconciliation and doc-put-throw cleanup) is testable. Default
-// maxTotal is effectively unlimited so the happy-path tests behave as before.
-//
-// `throwOnJson` forces the final document put to throw, standing in for "doc
-// exceeds the cap".
-function makeSandbox({ maxTotal = Infinity, throwOnJson = false } = {}) {
-  const puts = [];
-  const evicted = [];
-  // id -> size, in insertion order (Map preserves it) so the oldest is first.
-  const live = new Map();
-  let total = 0;
-  const idOf = (uri) => uri.substring(uri.lastIndexOf("/") + 1);
-  return {
-    puts,
-    evicted,
-    put(buf, mime) {
-      if (throwOnJson && mime === "application/json") {
-        throw new Error("doc blob exceeds the sandbox cap");
-      }
-      const sha256 = createHash("sha256").update(buf).digest("hex");
-      const id = `id-${puts.length}`;
-      puts.push({ buf, mime, sha256, id });
-      live.set(id, buf.length);
-      total += buf.length;
-      // FIFO-evict the oldest live blobs until this put fits under the cap.
-      while (total > maxTotal && live.size > 0) {
-        const oldest = live.keys().next().value;
-        if (oldest === id) break; // never evict the blob we just stored
-        total -= live.get(oldest);
-        live.delete(oldest);
-        evicted.push(oldest);
-      }
-      return { uri: `https://sb.test/api/sb/${id}`, sha256, size: buf.length };
-    },
-    has(uri) {
-      return live.has(idOf(uri));
-    },
-    evict(uri) {
-      const id = idOf(uri);
-      if (live.has(id)) {
-        total -= live.get(id);
-        live.delete(id);
-      }
-      evicted.push(id);
-    },
-  };
-}
-
-const IMAGE_BYTES = Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a]); // "PNG" header-ish
-
-function pageDoc() {
-  return {
-    type: "doc",
-    content: [
-      {
-        type: "image",
-        attrs: { src: "/api/files/att-1/pic.png", attachmentId: "att-1", width: 100 },
-      },
-      // Same internal src again -> must dedup to ONE blob, both rewritten.
-      {
-        type: "image",
-        attrs: { src: "/api/files/att-1/pic.png", attachmentId: "att-1", width: 50 },
-      },
-      // External CDN image -> must be left untouched.
-      {
-        type: "image",
-        attrs: { src: "https://cdn.example.com/remote.png" },
-      },
-    ],
-  };
-}
-
-// Build a client wired to a server that logs in, serves the page, and serves the
-// internal file bytes. `fileStatus` lets a test force the file fetch to fail;
-// `doc` overrides the served page; `fileBytes`/`fileHeaders` shape the file
-// response (used by the empty-body / missing-Content-Type branch tests).
-async function buildClient(
-  sandbox,
-  {
-    fileStatus = 200,
-    doc = pageDoc(),
-    fileBytes = IMAGE_BYTES,
-    fileHeaders = { "Content-Type": "image/png" },
-  } = {},
-) {
-  const baseURL = await spawn(async (req, res) => {
-    await readBody(req);
-    if (req.url === "/api/auth/login") {
-      res.writeHead(200, {
-        "Content-Type": "application/json",
-        "Set-Cookie": "authToken=tok; HttpOnly",
-      });
-      res.end(JSON.stringify({ token: "tok" }));
-      return;
-    }
-    if (req.url === "/api/pages/info") {
-      res.writeHead(200, { "Content-Type": "application/json" });
-      res.end(JSON.stringify({ data: { id: "page-1", title: "T", content: doc } }));
-      return;
-    }
-    if (req.url.startsWith("/api/files/")) {
-      if (fileStatus !== 200) {
-        res.writeHead(fileStatus);
-        res.end();
-        return;
-      }
-      res.writeHead(200, fileHeaders);
-      res.end(fileBytes);
-      return;
-    }
-    res.writeHead(404);
-    res.end();
-  });
-  return new DocmostClient({
-    apiUrl: baseURL,
-    email: "u@example.com",
-    password: "pw",
-    sandbox: {
-      put: (buf, mime) => sandbox.put(buf, mime),
-      has: (uri) => sandbox.has(uri),
-      evict: (uri) => sandbox.evict(uri),
-    },
-  });
-}
-
-// A page with several DISTINCT internal images (each a unique attachment id) so
-// each is its own sandbox blob — needed to exercise FIFO self-eviction.
-function multiImageDoc(n) {
-  return {
-    type: "doc",
-    content: Array.from({ length: n }, (_, i) => ({
-      type: "image",
-      attrs: { src: `/api/files/att-${i}/pic.png`, attachmentId: `att-${i}` },
-    })),
-  };
-}
-
-test("stashPage stores the doc + mirrors/rewrites internal images, returns only a link", async () => {
-  const sandbox = makeSandbox();
-  const client = await buildClient(sandbox);
-
-  const result = await client.stashPage("page-1");
-
-  // Returns ONLY a link shape — never the document body.
-  assert.equal(typeof result.uri, "string");
-  assert.match(result.uri, /^https:\/\/sb\.test\/api\/sb\//);
-  assert.equal(typeof result.sha256, "string");
-  assert.equal(typeof result.size, "number");
-  assert.ok(!("doc" in result) && !("content" in result) && !("body" in result));
-  assert.deepEqual(result.images, { mirrored: 1, failed: 0 });
-
-  // One image blob (dedup) + one doc blob = 2 puts.
-  assert.equal(sandbox.puts.length, 2);
-  const imagePut = sandbox.puts[0];
-  const docPut = sandbox.puts[1];
-  assert.equal(imagePut.mime, "image/png");
-  assert.ok(imagePut.buf.equals(IMAGE_BYTES));
-  assert.equal(docPut.mime, "application/json");
-
-  // The returned uri/sha256 are the DOCUMENT blob's.
-  assert.equal(result.sha256, docPut.sha256);
-
-  // Inspect the stashed document: internal srcs rewritten, external untouched.
-  const stashed = JSON.parse(docPut.buf.toString("utf8"));
-  const imgs = stashed.content.content.filter((n) => n.type === "image");
-  assert.equal(imgs[0].attrs.src, "https://sb.test/api/sb/id-0");
-  assert.equal(imgs[1].attrs.src, "https://sb.test/api/sb/id-0"); // same blob (dedup)
-  assert.equal(imgs[2].attrs.src, "https://cdn.example.com/remote.png"); // external kept
-});
-
-test("stashPage counts a failed image fetch without aborting the document", async () => {
-  const sandbox = makeSandbox();
-  const client = await buildClient(sandbox, { fileStatus: 500 });
-
-  const result = await client.stashPage("page-1");
-
-  assert.deepEqual(result.images, { mirrored: 0, failed: 1 });
-  // Only the doc blob was stored (image fetch failed).
-  assert.equal(sandbox.puts.length, 1);
-  assert.equal(sandbox.puts[0].mime, "application/json");
-
-  // The failed internal src is LEFT as-is so nothing is silently dropped.
-  const stashed = JSON.parse(sandbox.puts[0].buf.toString("utf8"));
-  const imgs = stashed.content.content.filter((n) => n.type === "image");
-  assert.equal(imgs[0].attrs.src, "/api/files/att-1/pic.png");
-});
-
-test("stashPage throws a clear error when no sandbox is configured", async () => {
-  const baseURL = await spawn(async (req, res) => {
-    await readBody(req);
-    res.writeHead(200, { "Content-Type": "application/json" });
-    res.end(JSON.stringify({}));
-  });
-  const client = new DocmostClient({
-    apiUrl: baseURL,
-    email: "u@example.com",
-    password: "pw",
-  });
-  await assert.rejects(() => client.stashPage("page-1"), /not configured/);
-});
-
-test("stashPage reverts a FIFO-evicted image and counts it as failed (B1)", async () => {
-  // 3 distinct images of S=4000 bytes each; doc JSON is far smaller than one
-  // image. With a cap of 4500: storing img1 evicts img0, storing img2 evicts
-  // img1 — so only img2 survives the loop (img0 + img1 reverted). The doc
-  // (4000 + a few hundred bytes <= 4500) then fits alongside the survivor, so it
-  // does NOT trigger further eviction. The stored doc must therefore reference
-  // exactly one live blob and revert the other two to their internal srcs.
-  const BIG = Buffer.alloc(4000, 0x41);
-  const sandbox = makeSandbox({ maxTotal: 4500 });
-  const client = await buildClient(sandbox, {
-    doc: multiImageDoc(3),
-    fileBytes: BIG,
-  });
-
-  const result = await client.stashPage("page-1");
-
-  // Two images were evicted before the doc was stored -> counted as failed.
-  assert.deepEqual(result.images, { mirrored: 1, failed: 2 });
-
-  // Inspect the stashed doc: no node may point at an evicted (now-dead) blob,
-  // and every reverted node carries its ORIGINAL internal src again.
-  const docPut = sandbox.puts.find((p) => p.mime === "application/json");
-  const stashed = JSON.parse(docPut.buf.toString("utf8"));
-  const imgs = stashed.content.content.filter((n) => n.type === "image");
-  let live = 0;
-  let reverted = 0;
-  for (const img of imgs) {
-    const src = img.attrs.src;
-    if (src.startsWith("https://sb.test/api/sb/")) {
-      assert.ok(sandbox.has(src), `doc references evicted blob ${src}`);
-      live++;
-    } else {
-      // Reverted to the original internal src.
-      assert.match(src, /^\/api\/files\/att-\d+\/pic\.png$/);
-      reverted++;
-    }
-  }
-  assert.equal(live, 1);
-  assert.equal(reverted, 2);
-});
-
-test("stashPage reverts an image evicted by the DOC put itself (after-put reconcile, B1)", async () => {
-  // Both images (1000 bytes each) survive the image phase: total 2000 <= cap
-  // 2500. The doc, however, serializes large (a node with a ~700-byte string
-  // attr), so putting it (newest) tips total over the cap and FIFO-evicts the
-  // OLDEST image (img0) — an eviction caused by the doc put itself, which only
-  // the after-put reconciliation can catch. The loop then reverts img0, drops
-  // the stale doc blob, and re-puts the corrected doc (now total = img1 +
-  // docSize <= cap, so img1 survives).
-  const BIG = Buffer.alloc(1000, 0x41);
-  const sandbox = makeSandbox({ maxTotal: 2500 });
-  const doc = {
-    type: "doc",
-    content: [
-      { type: "image", attrs: { src: "/api/files/att-0/pic.png", attachmentId: "att-0" } },
-      { type: "image", attrs: { src: "/api/files/att-1/pic.png", attachmentId: "att-1" } },
-      // Bulk the doc JSON up so the doc put crosses the cap on its own. Stays in
-      // the doc across reverts, so each re-serialization is similarly large.
-      { type: "paragraph", attrs: { filler: "x".repeat(700) }, content: [] },
-    ],
-  };
-  const client = await buildClient(sandbox, { doc, fileBytes: BIG });
-
-  const result = await client.stashPage("page-1");
-
-  // The doc put evicted exactly one image -> reverted + counted as failed.
-  assert.deepEqual(result.images, { mirrored: 1, failed: 1 });
-
-  // Use the LAST json put: the first (stale) doc referenced the now-dead blob
-  // and was itself evicted; the corrected re-put is the one that stands.
-  const docPut = sandbox.puts.filter((p) => p.mime === "application/json").at(-1);
-  const stashed = JSON.parse(docPut.buf.toString("utf8"));
-  const imgs = stashed.content.content.filter((n) => n.type === "image");
-  let live = 0;
-  let reverted = 0;
-  for (const img of imgs) {
-    const src = img.attrs.src;
-    if (src.startsWith("https://sb.test/api/sb/")) {
-      assert.ok(sandbox.has(src), `final doc references evicted blob ${src}`);
-      live++;
-    } else {
-      assert.match(src, /^\/api\/files\/att-\d+\/pic\.png$/);
-      reverted++;
-    }
-  }
-  assert.equal(live, 1);
-  assert.equal(reverted, 1);
-});
-
-test("stashPage frees image blobs when the doc put throws (B1)", async () => {
-  // Two distinct images mirror fine; the final JSON doc put throws (doc exceeds
-  // cap). stashPage must reject AND evict every image blob it stored this op.
-  const sandbox = makeSandbox({ throwOnJson: true });
-  const client = await buildClient(sandbox, { doc: multiImageDoc(2) });
-
-  await assert.rejects(() => client.stashPage("page-1"));
-
-  // Both image blobs were stored, then evicted on the doc-put failure.
-  const imagePuts = sandbox.puts.filter((p) => p.mime === "image/png");
-  assert.equal(imagePuts.length, 2);
-  for (const p of imagePuts) {
-    assert.ok(sandbox.evicted.includes(p.id), `image ${p.id} was not freed`);
-  }
-});
-
-test("stashPage counts an empty file response as failed (B1/fetchInternalFile)", async () => {
-  const sandbox = makeSandbox();
-  const client = await buildClient(sandbox, {
-    fileBytes: Buffer.alloc(0),
-    fileHeaders: { "Content-Type": "image/png", "Content-Length": "0" },
-  });
-
-  const result = await client.stashPage("page-1");
-
-  // The single internal image (deduped) yielded an empty body -> failed.
-  assert.deepEqual(result.images, { mirrored: 0, failed: 1 });
-  // Only the doc blob was stored.
-  assert.equal(sandbox.puts.filter((p) => p.mime === "image/png").length, 0);
-});
-
-test("stashPage mirrors a file with no Content-Type as octet-stream (fetchInternalFile)", async () => {
-  const sandbox = makeSandbox();
-  // No Content-Type header at all -> fetchInternalFile defaults to octet-stream.
-  const client = await buildClient(sandbox, { fileHeaders: {} });
-
-  const result = await client.stashPage("page-1");
-
-  assert.equal(result.images.mirrored, 1);
-  const imagePut = sandbox.puts.find((p) => p.mime !== "application/json");
-  assert.ok(imagePut, "expected an image put");
-  assert.equal(imagePut.mime, "application/octet-stream");
-});

packages/mcp/test/unit/internal-file-urls.test.mjs

@@ -1,101 +0,0 @@
-// Unit tests for the internal-file URL helpers the stash tool relies on. The
-// critical case is resolveInternalFilePath, whose whole job is to REJECT a
-// content-controlled `src` that tries to escape /api/files/ (SSRF / traversal)
-// before it ever reaches the authenticated loopback client.
-import { test } from "node:test";
-import assert from "node:assert/strict";
-import {
-  resolveInternalFilePath,
-  normalizeFileUrl,
-  collectInternalFileNodes,
-} from "../../build/lib/internal-file-urls.js";
-
-test("resolveInternalFilePath accepts a normal internal src", () => {
-  assert.equal(
-    resolveInternalFilePath("/api/files/att-1/pic.png"),
-    "/files/att-1/pic.png",
-  );
-});
-
-test("resolveInternalFilePath rejects traversal / encoded variants (SSRF guard)", () => {
-  // `..` collapses to /api/auth/whoami -> outside /api/files/ -> rejected.
-  assert.throws(() => resolveInternalFilePath("/api/files/../auth/whoami"));
-  // Escapes the /api base entirely.
-  assert.throws(() => resolveInternalFilePath("/api/files/../../internal"));
-  // Percent-encoded dot -> rejected before canonicalization.
-  assert.throws(() => resolveInternalFilePath("/api/files/%2e%2e/x"));
-  // Percent-encoded slash separator -> rejected before canonicalization.
-  assert.throws(() => resolveInternalFilePath("/api/files/..%2fauth"));
-});
-
-test("resolveInternalFilePath drops a foreign host and keeps only the /api/files/ pathname (SSRF accept-path)", () => {
-  // ACCEPT path: an absolute URL has its host dropped; only the canonical
-  // pathname survives, and it must still start with /api/files/. This is SAFE
-  // because the loopback axios client ignores any host in `src` and uses its own
-  // /api baseURL — so a foreign host like evil.com is never contacted. This is
-  // the SOLE SSRF/traversal guard for content-controlled `src`, so it must be
-  // pinned: a future refactor to a prefix-only check would silently open a
-  // bypass with no failing test.
-  assert.equal(
-    resolveInternalFilePath("http://evil.com/api/files/x/y.png"),
-    "/files/x/y.png",
-  );
-  // Protocol-relative URL: host likewise dropped, pathname kept.
-  assert.equal(
-    resolveInternalFilePath("//evil.com/api/files/x/y.png"),
-    "/files/x/y.png",
-  );
-});
-
-test("resolveInternalFilePath rejects a foreign-host src whose pathname escapes /api/files/", () => {
-  // Even though the host is dropped, the canonical pathname /api/auth/whoami
-  // does NOT start with /api/files/, so it is rejected.
-  assert.throws(() =>
-    resolveInternalFilePath("https://evil.com/api/auth/whoami"),
-  );
-  // The WHATWG URL parser converts backslashes to `/` for http(s), so this
-  // collapses to /api/auth/whoami and escapes the /api/files/ subtree.
-  assert.throws(() => resolveInternalFilePath("/api/files\\..\\auth\\whoami"));
-});
-
-test("resolveInternalFilePath wraps a new URL parse failure in a clear error", () => {
-  // `http://[` has no %2e/%2f so it passes the first guard, then fails the
-  // `new URL(...)` parse — exercising the catch branch that re-throws with a
-  // clear message.
-  assert.throws(
-    () => resolveInternalFilePath("http://["),
-    /Invalid internal file src/,
-  );
-});
-
-test("normalizeFileUrl rewrites the bare /files/ branch and leaves /api/files/ alone", () => {
-  assert.equal(
-    normalizeFileUrl("/files/att-1/pic.png"),
-    "/api/files/att-1/pic.png",
-  );
-  assert.equal(
-    normalizeFileUrl("/api/files/att-1/pic.png"),
-    "/api/files/att-1/pic.png",
-  );
-});
-
-test("collectInternalFileNodes recurses into nested content containers", () => {
-  // The internal image is buried inside a callout's content array, so a
-  // regression on the recursion (e.g. a shallow .filter()) would miss it.
-  const nested = {
-    type: "image",
-    attrs: { src: "/api/files/att-9/deep.png", attachmentId: "att-9" },
-  };
-  const doc = {
-    type: "doc",
-    content: [
-      {
-        type: "callout",
-        content: [{ type: "paragraph", content: [nested] }],
-      },
-    ],
-  };
-  const found = collectInternalFileNodes(doc);
-  assert.equal(found.length, 1);
-  assert.equal(found[0], nested);
-});

pnpm-lock.yaml

@@ -780,9 +780,6 @@ importers:
       ws:
         specifier: 8.20.1
         version: 8.20.1
-      yaml:
-        specifier: ^2.8.3
-        version: 2.8.3
       yauzl:
         specifier: ^3.2.1
         version: 3.2.1