fix(qa): resolve QA-pass issues #122–#134
Batch of fixes from the automated QA pass on develop. Each was reproduced and then verified fixed live (browser/curl); logic-bearing fixes have unit tests. Functional bugs: - #122 collab-token was capped by the anonymous public-share-AI throttler (5/min); skip all non-AUTH named throttlers on this auth-guarded, client-cached route. - #123 editor onAuthenticationFailed threw `jwtDecode(undefined)` and never reconnected; read the token via a ref, guard the decode (incl. missing exp), and refetch+reconnect on any auth failure. - #124 a slash command containing a space ("/Heading 1") inserted literal text; enable allowSpaces and close the menu when the query matches no items. - #125 space slug auto-gen produced uppercase initials for multi-word names; computeSpaceSlug now yields a lowercase alphanumeric slug. - #126 AI chat window position/size now persisted (atomWithStorage) across reload; also fixes a latent ResizeObserver-attach bug on first open. - #127 workspace name update accepted URLs; add @NoUrls (parity with setup). - #132 icon-columns 4/5 passed calc() into SVG width/height attrs (console spam); size via style. share-for-page query returns null instead of undefined. - #134 "Reindex now" counter looked stuck: reindex runs async; the client now polls coverage (bounded) so the counter climbs live; misleading server comment reworded. UX / consistency: - #128 add success toasts to favorite/label/avatar/member-(de)activate. - #129 "1 result found" pluralization; hide the single-option Type filter. - #130 replace raw Zod strings with friendly messages (name/password/group). - #131 unify "Untitled" casing in tree/breadcrumb/tab; stop force-uppercasing space-name chips; fix confirm-dialog labels (Cancel / Remove), invite placeholder typo, Export/Move-to-space labels. - #133 disable profile Save when clean; toast on unsupported avatar image; style the invalid-invitation page with a CTA; hide Share for read-only users; align the dictation "not configured" message; "Go to login page" typo. Tests: computeSpaceSlug, workspace-name NoUrls DTO, share-query null normalization, slash getSuggestionItems empty-close. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,61 @@
|
||||
import { afterEach, beforeEach, describe, expect, it } from "vitest";
|
||||
import { getSuggestionItems } from "./menu-items";
|
||||
|
||||
// The slash-command `allow` callback (slash-command.ts) keeps the popup active
|
||||
// only while at least one item matches the current query:
|
||||
// const groups = getSuggestionItems({ query });
|
||||
// const hasMatches = Object.values(groups).some((items) => items.length > 0);
|
||||
// return hasMatches;
|
||||
// With `allowSpaces: true`, a non-empty query that matches nothing must collapse
|
||||
// to an empty result so `allow` returns false and the menu closes (instead of
|
||||
// leaving literal "/todo abc" text behind). These tests pin that contract at the
|
||||
// `getSuggestionItems` boundary, which is the unit-testable half of `allow`.
|
||||
|
||||
const KEY = "currentUser";
|
||||
|
||||
function hasMatches(query: string): boolean {
|
||||
// Mirror the exact predicate used by slash-command.ts `allow`.
|
||||
const groups = getSuggestionItems({ query });
|
||||
return Object.values(groups).some((items) => items.length > 0);
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
// Default workspace state: HTML-embed feature OFF (matches production default).
|
||||
localStorage.setItem(KEY, JSON.stringify({ workspace: { settings: {} } }));
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
localStorage.clear();
|
||||
});
|
||||
|
||||
describe("getSuggestionItems — empty-query close behavior (slash `allow`)", () => {
|
||||
it("keeps the menu allowed for a query that matches items", () => {
|
||||
expect(hasMatches("h1")).toBe(true);
|
||||
});
|
||||
|
||||
it("keeps the menu allowed for a multi-word matching query", () => {
|
||||
// "Heading 1" is a multi-word title kept alive by allowSpaces.
|
||||
expect(hasMatches("Heading 1")).toBe(true);
|
||||
});
|
||||
|
||||
it("closes the menu (no matches) for a non-empty query that matches nothing", () => {
|
||||
expect(hasMatches("zzzznomatch")).toBe(false);
|
||||
});
|
||||
|
||||
it("closes the menu for a space-bearing non-matching query", () => {
|
||||
// The exact case the allowSpaces fix targets: "/todo abc" matches nothing.
|
||||
expect(hasMatches("todo abc")).toBe(false);
|
||||
});
|
||||
|
||||
it("returns an empty result object for a no-match query", () => {
|
||||
expect(getSuggestionItems({ query: "zzzznomatch" })).toEqual({});
|
||||
});
|
||||
|
||||
it("returns a non-empty result for the 'Heading 1' query", () => {
|
||||
const groups = getSuggestionItems({ query: "Heading 1" });
|
||||
const titles = Object.values(groups)
|
||||
.flat()
|
||||
.map((item) => item.title);
|
||||
expect(titles).toContain("Heading 1");
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user