99a372fb88
* feat(useractivity): introduce backend for useractivity logging (#213) * refactor(useractivity): move query and logs to base type * feat(useractivity): cleanup user activity logs * feat(useractivity): log an activity * refactor(useractivity): create generic get logs function * fix(api): hide unused function * refactor(useractivity): create generic get logs function * feat(useractivity): get user activity logs * feat(http/ua): add http get logs handler * refactor(http/ua): rename logs_list file * feat(useractivity): fetch logs as csv * feat(useractivity): save payload as bytes * style(useractivity): doc the count parameter * feat(useractivity): introduce UI for user activity logs (#220) * feat(useractivity): add useractivity page * feat(useractivity): get logs from server * feat(useractivity): show logs in datatable * fix(useractivity): save logs as csv * feat(useractivity): show logs payload * feat(useractivity): sort desc by default * feat(useractivity): parse object * fix(useractivity): expect base64 payload * feat(useractivity): show message when missing logs * feat(useractivity): log api (#215) * feat(templates): log write methods * refactor(useractivity): move middleware * feat(dockerhub): log update docker settings * feat(edgegroup): log write * feat(edgejobs): log write request * feat(useractivity): return bytes to user * fix(customtemplates): set activity context * feat(edgestacks): log activities * feat(endpointgroup): log activities * feat(endpoint): log write activities * feat(licenses): log write activities * feat(registries): log activitites * feat(resource_control): log user activity * feat(settings): log update * feat(stacks): log activity * feat(tags): log user activitiy * feat(teammembership): log user activity * feat(teams): log write activities * feat(useractivity): get default context * feat(http/upload): log upload tls * feat(users): log user activities * fix(settings): clean payload * feat(webhook): log user activities * feat(websocket): log activities * feat(docker): log write activities * refactor(useractivity): move log proxy * feat(azure): log write activity * refactor(kube): use basic transport for all transports * feat(kube): log kube activity * fix(useractivity): parse body * refactor(kuberenetes): log requests only if success * refactor(docker): log requests only if success * refactor(azure): log requests only if success * feat(gitlab): log activity * feat(registries): log proxy request Co-authored-by: Chaim Lev-Ari <chiptus@gmail.com> * feat(activity-logs): save pagination limit * feat(useractivity): remove config payload * fix(docker): log request after success * refactor(http): move copy body to utils * feat(kuberentes): remove config values * feat(useractivity): copy body before request * fix(useractivity): fix column size * feat(useractivity): filter json payloads * refactor(useractivity): log with same logic * fix(useractivity/csv): export same columns as datatable * fix(useractivity): replace context with endpoint * fix(user-activity): rename tables * feat(endpoint): clear azure key * feat(stacks): omit empty migrate values * fix(stacks): add back import * feat(endpoints): log update settings * fix(registry): clear password value * feat(registry): omit update empty value * fix(registries): don't return from unauthorized azure request * fix(useractivity): log any payload similar to json * feat(useractivity): ignoer binary upload * fix(useractivity): refresh user activity logs * feat(useractivity): use [REDACTED] for cleared credential (#265) * feat(docker/services): log force update service * feat(useractivity): log username when available * feat(webhooks): remove logging of execute * refactor(http): replace redacted values * style(kube): remove commented code * feat(http/kube): proxy local requests * feat(useractivity): log patch method * fix(datatables): use unique filter id * fix kube settings update * fix: EE-527 set payload to [REDACTED] when update kube config * refactor(http/k8s): rename proxy function * EE-530: a dummy fix of exec activity log for a local kube setup Co-authored-by: Dmitry Salakhov <to@dimasalakhov.com> Co-authored-by: Hui <arris_li@hotmail.com> Co-authored-by: Simon Meng <simon.meng@portainer.io>
410 lines
10 KiB
Go
410 lines
10 KiB
Go
package useractivity
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
portainer "github.com/portainer/portainer/api"
|
|
)
|
|
|
|
func BenchmarkAuthLog(b *testing.B) {
|
|
defer timeTrack(time.Now(), "AuthActivityLog")
|
|
|
|
// https://github.com/golang/go/issues/41062
|
|
// bug in go 1.15 causes b.TempDir() to break in benchmarks
|
|
// TODO remove in go 1.16
|
|
|
|
err := os.RemoveAll("./useractivity.db")
|
|
if err != nil {
|
|
b.Fatalf("Failed removing db: %s", err)
|
|
}
|
|
|
|
store, err := setup("")
|
|
if err != nil {
|
|
b.Fatalf("Failed setup: %s", err)
|
|
}
|
|
|
|
defer store.Close()
|
|
|
|
for i := 0; i < 100; i++ {
|
|
_, err = store.LogAuthActivity("username", "endpoint", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
b.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
}
|
|
|
|
count, err := store.db.Count(&portainer.AuthActivityLog{})
|
|
if err != nil {
|
|
fmt.Println(err)
|
|
}
|
|
|
|
fmt.Printf("Number of logs: %d\n", count)
|
|
|
|
}
|
|
|
|
const (
|
|
testType = portainer.AuthenticationActivityType(0)
|
|
)
|
|
|
|
func TestAddActivity(t *testing.T) {
|
|
store, err := setup(t.TempDir())
|
|
if err != nil {
|
|
t.Fatalf("Failed setup: %s", err)
|
|
}
|
|
|
|
defer store.Close()
|
|
|
|
_, err = store.LogAuthActivity("username", "endpoint", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
count, err := store.db.Count(&portainer.AuthActivityLog{})
|
|
if err != nil {
|
|
t.Fatalf("Failed counting activities: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, 1, count, "Store should have one element")
|
|
}
|
|
|
|
func TestGetAuthLogs(t *testing.T) {
|
|
store, err := setup(t.TempDir())
|
|
if err != nil {
|
|
t.Fatalf("Failed setup: %s", err)
|
|
}
|
|
|
|
defer store.Close()
|
|
|
|
log1, err := store.LogAuthActivity("username1", "endpoint1", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log2, err := store.LogAuthActivity("username2", "endpoint2", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log3, err := store.LogAuthActivity("username3", "endpoint3", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
logs, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{})
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, []*portainer.AuthActivityLog{log1, log2, log3}, logs)
|
|
}
|
|
|
|
func TestGetAuthLogsByTimestamp(t *testing.T) {
|
|
store, err := setup(t.TempDir())
|
|
if err != nil {
|
|
t.Fatalf("Failed setup: %s", err)
|
|
}
|
|
|
|
defer store.Close()
|
|
|
|
log1, err := store.LogAuthActivity("username1", "endpoint1", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
time.Sleep(time.Second * 1)
|
|
|
|
log2, err := store.LogAuthActivity("username2", "endpoint2", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
time.Sleep(time.Second * 1)
|
|
|
|
log3, err := store.LogAuthActivity("username3", "endpoint3", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
logs, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
UserActivityLogBaseQuery: portainer.UserActivityLogBaseQuery{
|
|
BeforeTimestamp: log3.Timestamp - 1,
|
|
AfterTimestamp: log1.Timestamp + 1,
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, log2, logs[0], "logs are not equal")
|
|
}
|
|
|
|
func TestGetAuthLogsByKeyword(t *testing.T) {
|
|
store, err := setup(t.TempDir())
|
|
if err != nil {
|
|
t.Fatalf("Failed setup: %s", err)
|
|
}
|
|
|
|
defer store.Close()
|
|
|
|
log1, err := store.LogAuthActivity("username1", "endpoint1", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log2, err := store.LogAuthActivity("username2", "endpoint2", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log3, err := store.LogAuthActivity("username3", "endpoint3", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
// like
|
|
shouldHaveAllLogs, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
UserActivityLogBaseQuery: portainer.UserActivityLogBaseQuery{
|
|
Keyword: "username",
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, []*portainer.AuthActivityLog{log1, log2, log3}, shouldHaveAllLogs)
|
|
|
|
// username
|
|
shouldHaveOnlyLog1, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
UserActivityLogBaseQuery: portainer.UserActivityLogBaseQuery{
|
|
Keyword: "username1",
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, log1, shouldHaveOnlyLog1[0])
|
|
|
|
// origin
|
|
shouldHaveOnlyLog3, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
UserActivityLogBaseQuery: portainer.UserActivityLogBaseQuery{
|
|
Keyword: "endpoint3",
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, log3, shouldHaveOnlyLog3[0])
|
|
}
|
|
|
|
func TestGetAuthLogsByContext(t *testing.T) {
|
|
store, err := setup(t.TempDir())
|
|
if err != nil {
|
|
t.Fatalf("Failed setup: %s", err)
|
|
}
|
|
|
|
defer store.Close()
|
|
|
|
log1, err := store.LogAuthActivity("username1", "endpoint1", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log2, err := store.LogAuthActivity("username2", "endpoint2", portainer.AuthenticationLDAP, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log3, err := store.LogAuthActivity("username3", "endpoint3", portainer.AuthenticationOAuth, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
// one type
|
|
shouldHaveLog2, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
ContextTypes: []portainer.AuthenticationMethod{
|
|
portainer.AuthenticationLDAP,
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, []*portainer.AuthActivityLog{log2}, shouldHaveLog2)
|
|
|
|
// two types
|
|
shouldHaveLog1And3, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
ContextTypes: []portainer.AuthenticationMethod{
|
|
portainer.AuthenticationInternal,
|
|
portainer.AuthenticationOAuth,
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, []*portainer.AuthActivityLog{log1, log3}, shouldHaveLog1And3)
|
|
}
|
|
|
|
func TestGetAuthLogsByType(t *testing.T) {
|
|
store, err := setup(t.TempDir())
|
|
if err != nil {
|
|
t.Fatalf("Failed setup: %s", err)
|
|
}
|
|
|
|
defer store.Close()
|
|
|
|
log1, err := store.LogAuthActivity("username1", "endpoint1", portainer.AuthenticationInternal, portainer.AuthenticationActivityFailure)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log2, err := store.LogAuthActivity("username2", "endpoint2", portainer.AuthenticationLDAP, portainer.AuthenticationActivityLogOut)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log3, err := store.LogAuthActivity("username3", "endpoint3", portainer.AuthenticationOAuth, portainer.AuthenticationActivitySuccess)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
// one type
|
|
shouldHaveLog2, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
ActivityTypes: []portainer.AuthenticationActivityType{
|
|
portainer.AuthenticationActivityLogOut,
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, []*portainer.AuthActivityLog{log2}, shouldHaveLog2)
|
|
|
|
// two types
|
|
shouldHaveLog1And3, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
ActivityTypes: []portainer.AuthenticationActivityType{
|
|
portainer.AuthenticationActivityFailure,
|
|
portainer.AuthenticationActivitySuccess,
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, []*portainer.AuthActivityLog{log1, log3}, shouldHaveLog1And3)
|
|
}
|
|
|
|
func TestGetAuthLogsSortOrderAndPaginate(t *testing.T) {
|
|
store, err := setup(t.TempDir())
|
|
if err != nil {
|
|
t.Fatalf("Failed setup: %s", err)
|
|
}
|
|
|
|
defer store.Close()
|
|
|
|
log1, err := store.LogAuthActivity("username1", "endpoint1", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log2, err := store.LogAuthActivity("username2", "endpoint2", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log3, err := store.LogAuthActivity("username3", "endpoint3", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log4, err := store.LogAuthActivity("username4", "endpoint4", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
shouldBeLog4AndLog3, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
UserActivityLogBaseQuery: portainer.UserActivityLogBaseQuery{
|
|
SortDesc: true,
|
|
SortBy: "Username",
|
|
Offset: 0,
|
|
Limit: 2,
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, []*portainer.AuthActivityLog{log4, log3}, shouldBeLog4AndLog3)
|
|
|
|
shouldBeLog2AndLog1, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
UserActivityLogBaseQuery: portainer.UserActivityLogBaseQuery{
|
|
SortDesc: true,
|
|
SortBy: "Username",
|
|
Offset: 2,
|
|
Limit: 2,
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, []*portainer.AuthActivityLog{log2, log1}, shouldBeLog2AndLog1)
|
|
}
|
|
|
|
func TestGetAuthLogsDesc(t *testing.T) {
|
|
store, err := setup(t.TempDir())
|
|
if err != nil {
|
|
t.Fatalf("Failed setup: %s", err)
|
|
}
|
|
|
|
defer store.Close()
|
|
|
|
log1, err := store.LogAuthActivity("username1", "endpoint1", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log2, err := store.LogAuthActivity("username2", "endpoint2", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
log3, err := store.LogAuthActivity("username3", "endpoint3", portainer.AuthenticationInternal, testType)
|
|
if err != nil {
|
|
t.Fatalf("Failed adding activity log: %s", err)
|
|
}
|
|
|
|
logs, _, err := store.GetAuthLogs(portainer.AuthLogsQuery{
|
|
UserActivityLogBaseQuery: portainer.UserActivityLogBaseQuery{
|
|
SortDesc: true,
|
|
},
|
|
})
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed fetching logs: %s", err)
|
|
}
|
|
|
|
assert.Equal(t, []*portainer.AuthActivityLog{log3, log2, log1}, logs)
|
|
}
|
|
|
|
func timeTrack(start time.Time, name string) {
|
|
elapsed := time.Since(start)
|
|
fmt.Printf("%s took %s\n", name, elapsed)
|
|
}
|