diff --git a/api/http/handler/endpoints/endpoint_association_delete.go b/api/http/handler/endpoints/endpoint_association_delete.go index 2ef6fe6c4..cc339d159 100644 --- a/api/http/handler/endpoints/endpoint_association_delete.go +++ b/api/http/handler/endpoints/endpoint_association_delete.go @@ -4,14 +4,15 @@ import ( "encoding/base64" "errors" "fmt" + "net/http" + "regexp" + "strings" + httperror "github.com/portainer/libhttp/error" "github.com/portainer/libhttp/request" "github.com/portainer/libhttp/response" portainer "github.com/portainer/portainer/api" bolterrors "github.com/portainer/portainer/api/bolt/errors" - "net/http" - "regexp" - "strings" ) // @id EndpointAssociationDelete @@ -26,7 +27,7 @@ import ( // @failure 400 "Invalid request" // @failure 404 "Endpoint not found" // @failure 500 "Server error" -// @router /api/endpoints/:id/association [put] +// @router /api/endpoints/{id}/association [put] func (handler *Handler) endpointAssociationDelete(w http.ResponseWriter, r *http.Request) *httperror.HandlerError { endpointID, err := request.RetrieveNumericRouteVariableValue(r, "id") if err != nil { @@ -84,5 +85,5 @@ func (handler *Handler) updateEdgeKey(edgeKey string) (string, error) { func getPort(url string) string { items := strings.Split(url, ":") - return items[len(items) - 1] + return items[len(items)-1] } diff --git a/api/http/handler/helm/helm_delete.go b/api/http/handler/helm/helm_delete.go index 7939c253f..c4a9234fe 100644 --- a/api/http/handler/helm/helm_delete.go +++ b/api/http/handler/helm/helm_delete.go @@ -17,14 +17,15 @@ import ( // @security jwt // @accept json // @produce json -// @param release query string true "The name of the release/application to uninstall" +// @param id path int true "Endpoint identifier" +// @param release path string true "The name of the release/application to uninstall" // @param namespace query string true "An optional namespace" // @success 204 "Success" // @failure 400 "Invalid endpoint id or bad request" // @failure 401 "Unauthorized" // @failure 404 "Endpoint or ServiceAccount not found" // @failure 500 "Server error or helm error" -// @router /endpoints/:id/kubernetes/helm/{release} [delete] +// @router /endpoints/{id}/kubernetes/helm/{release} [delete] func (handler *Handler) helmDelete(w http.ResponseWriter, r *http.Request) *httperror.HandlerError { release, err := request.RetrieveRouteVariableValue(r, "release") if err != nil { diff --git a/api/http/handler/helm/helm_install.go b/api/http/handler/helm/helm_install.go index 33860ad7f..bf89e99f2 100644 --- a/api/http/handler/helm/helm_install.go +++ b/api/http/handler/helm/helm_install.go @@ -36,12 +36,13 @@ var errChartNameInvalid = errors.New("invalid chart name. " + // @security jwt // @accept json // @produce json +// @param id path int true "Endpoint identifier" // @param payload body installChartPayload true "Chart details" // @success 201 {object} release.Release "Created" // @failure 401 "Unauthorized" // @failure 404 "Endpoint or ServiceAccount not found" // @failure 500 "Server error" -// @router /endpoints/:id/kubernetes/helm [post] +// @router /endpoints/{id}/kubernetes/helm [post] func (handler *Handler) helmInstall(w http.ResponseWriter, r *http.Request) *httperror.HandlerError { var payload installChartPayload err := request.DecodeAndValidateJSONPayload(r, &payload) diff --git a/api/http/handler/helm/helm_list.go b/api/http/handler/helm/helm_list.go index f943a31ef..26246920a 100644 --- a/api/http/handler/helm/helm_list.go +++ b/api/http/handler/helm/helm_list.go @@ -17,6 +17,7 @@ import ( // @security jwt // @accept json // @produce json +// @param id path int true "Endpoint identifier" // @param namespace query string true "specify an optional namespace" // @param filter query string true "specify an optional filter" // @param selector query string true "specify an optional selector" @@ -25,7 +26,7 @@ import ( // @failure 401 "Unauthorized" // @failure 404 "Endpoint or ServiceAccount not found" // @failure 500 "Server error" -// @router /endpoints/:id/kubernetes/helm [get] +// @router /endpoints/{id}/kubernetes/helm [get] func (handler *Handler) helmList(w http.ResponseWriter, r *http.Request) *httperror.HandlerError { clusterAccess, httperr := handler.getHelmClusterAccess(r) if httperr != nil { diff --git a/api/http/handler/helm/helm_show.go b/api/http/handler/helm/helm_show.go index 220e33ab4..5ae2017ab 100644 --- a/api/http/handler/helm/helm_show.go +++ b/api/http/handler/helm/helm_show.go @@ -19,7 +19,7 @@ import ( // @tags helm_chart // @param repo query string true "Helm repository URL" // @param chart query string true "Chart name" -// @param command path string false "chart/values/readme" +// @param command path string true "chart/values/readme" // @security jwt // @accept json // @produce text/plain diff --git a/api/http/handler/helm/user_helm_repos.go b/api/http/handler/helm/user_helm_repos.go index 31df98d78..46eb65db7 100644 --- a/api/http/handler/helm/user_helm_repos.go +++ b/api/http/handler/helm/user_helm_repos.go @@ -36,12 +36,13 @@ func (p *addHelmRepoUrlPayload) Validate(_ *http.Request) error { // @security jwt // @accept json // @produce json +// @param id path int true "Endpoint identifier" // @param payload body addHelmRepoUrlPayload true "Helm Repository" // @success 200 {object} portainer.HelmUserRepository "Success" // @failure 400 "Invalid request" // @failure 403 "Permission denied" // @failure 500 "Server error" -// @router /endpoints/:id/kubernetes/helm/repositories [post] +// @router /endpoints/{id}/kubernetes/helm/repositories [post] func (handler *Handler) userCreateHelmRepo(w http.ResponseWriter, r *http.Request) *httperror.HandlerError { tokenData, err := security.RetrieveTokenData(r) if err != nil { @@ -99,7 +100,7 @@ func (handler *Handler) userCreateHelmRepo(w http.ResponseWriter, r *http.Reques // @failure 400 "Invalid request" // @failure 403 "Permission denied" // @failure 500 "Server error" -// @router /endpoints/:id/kubernetes/helm/repositories [get] +// @router /endpoints/{id}/kubernetes/helm/repositories [get] func (handler *Handler) userGetHelmRepos(w http.ResponseWriter, r *http.Request) *httperror.HandlerError { tokenData, err := security.RetrieveTokenData(r) if err != nil { diff --git a/api/http/handler/stacks/stack_update_git_redeploy.go b/api/http/handler/stacks/stack_update_git_redeploy.go index 9b9d485ee..cebba9cdc 100644 --- a/api/http/handler/stacks/stack_update_git_redeploy.go +++ b/api/http/handler/stacks/stack_update_git_redeploy.go @@ -53,7 +53,7 @@ func (payload *stackGitRedployPayload) Validate(r *http.Request) error { // @failure 403 "Permission denied" // @failure 404 "Not found" // @failure 500 "Server error" -// @router /stacks/:id/git/redeploy [put] +// @router /stacks/{id}/git/redeploy [put] func (handler *Handler) stackGitRedeploy(w http.ResponseWriter, r *http.Request) *httperror.HandlerError { stackID, err := request.RetrieveNumericRouteVariableValue(r, "id") if err != nil {