fix(#29 review r1): stack-delete leak, rollback/retention/version tests, UX trap

F3: deleting a file-based stack now removes the stack ROOT (compose/{id}) via a
new removeStackProjectDir helper, not stack.ProjectPath (which the PR repointed to
compose/{id}/v{N}) — old version dirs + parent no longer leak. Git stacks unchanged.
F1: tests for validateRollbackTarget (rejects 0/neg/>current/hole) and the rollback
snapshot (client content ignored, target read from disk, monotonic new version, note).
F2: tests for pruneStackFileVersionDirs (deletes given dirs, swallows errors) + the
post-commit gate contract + a monotonic-version regression guard.
F4: handler tests for ?version= (negative/out-of-range -> 400, valid version served,
legacy fallback).
F5: swagger @param version on GET file; @version 2.44.0 (handler.go) + package.json
2.44.0, matching APIVersion.
F6: the version selector no longer sets rollbackTo for the current/top version and
clears it on a manual buffer edit (so edits are honored, not silently discarded);
returning to the current version restores the current content. Distinguishes real
user edits from the programmatic version-load (CodeMirror ExternalChange).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

This commit is contained in:

agent_coder

2026-07-02 17:28:52 +03:00

parent d0d3c068ba

commit bb68acfbf6

8 changed files with 616 additions and 11 deletions

									
										api/http/handler/stacks/stack_file.go
									
		+1
		
												View File
												
				@@ -30,6 +30,7 @@ type stackFileResponse struct {

				// @security jwt

				// @produce json

				// @param id path int true "Stack identifier"

				// @param version query int false "return this file version (file-based stacks)"

				// @success 200 {object} stackFileResponse "Success"

				// @failure 400 "Invalid request"

				// @failure 403 "Permission denied"