diff --git a/api/http/handler/stacks/create_compose_stack.go b/api/http/handler/stacks/create_compose_stack.go index de4aeecdc..1e0c62746 100644 --- a/api/http/handler/stacks/create_compose_stack.go +++ b/api/http/handler/stacks/create_compose_stack.go @@ -212,10 +212,8 @@ func (payload *composeStackFromGitRepositoryPayload) Validate(r *http.Request) e if payload.RepositoryAuthentication && len(payload.RepositoryPassword) == 0 { return errors.New("Invalid repository credentials. Password must be specified when authentication is enabled") } - if err := update.ValidateAutoUpdateSettings(payload.AutoUpdate); err != nil { - return err - } - return nil + + return update.ValidateAutoUpdateSettings(payload.AutoUpdate) } // @id StackCreateDockerStandaloneRepository diff --git a/api/http/handler/stacks/create_swarm_stack.go b/api/http/handler/stacks/create_swarm_stack.go index b176605bc..59e4cad74 100644 --- a/api/http/handler/stacks/create_swarm_stack.go +++ b/api/http/handler/stacks/create_swarm_stack.go @@ -149,10 +149,8 @@ func (payload *swarmStackFromGitRepositoryPayload) Validate(r *http.Request) err if payload.RepositoryAuthentication && len(payload.RepositoryPassword) == 0 { return errors.New("Invalid repository credentials. Password must be specified when authentication is enabled") } - if err := update.ValidateAutoUpdateSettings(payload.AutoUpdate); err != nil { - return err - } - return nil + + return update.ValidateAutoUpdateSettings(payload.AutoUpdate) } func createStackPayloadFromSwarmGitPayload(name, swarmID, repoUrl, repoReference, repoUsername, repoPassword string, repoAuthentication bool, composeFile string, additionalFiles []string, autoUpdate *portainer.AutoUpdateSettings, env []portainer.Pair, fromAppTemplate bool, repoSkipSSLVerify bool) stackbuilders.StackPayload { diff --git a/api/internal/endpointutils/endpointutils.go b/api/internal/endpointutils/endpointutils.go index 02f0f89b5..9fba5c0ea 100644 --- a/api/internal/endpointutils/endpointutils.go +++ b/api/internal/endpointutils/endpointutils.go @@ -259,8 +259,5 @@ func InitializeEdgeEndpointRelation(endpoint *portainer.Endpoint, tx dataservice EdgeStacks: make(map[portainer.EdgeStackID]bool), } - if err := tx.EndpointRelation().Create(relation); err != nil { - return err - } - return nil + return tx.EndpointRelation().Create(relation) }