From 1f5762b8c8fd0626e0d343dec41a3c862a6f44ce Mon Sep 17 00:00:00 2001 From: Chaim Lev-Ari Date: Sun, 1 Mar 2026 12:14:47 +0200 Subject: [PATCH] fix(settings/auth): fix a11y labels (#1963) --- .../BoxSelector/BoxSelectorAngular.ts | 2 + app/portainer/components/BoxSelector/index.ts | 1 + .../oauth-providers-selector.html | 4 +- .../oauth-settings/oauth-settings.html | 2 +- .../ldap-connectivity-check.html | 2 +- .../ldap-custom-group-search.html | 158 +++++++++--------- .../ldap-custom-user-search.html | 115 +++++++------ .../ldap-group-search-item.html | 8 +- .../ldap-group-search/ldap-group-search.html | 52 +++--- .../ldap-settings-test-login.html | 118 ++++++------- .../ldap/ldap-settings/ldap-settings.html | 3 +- .../ldap-user-search-item.html | 4 +- .../ldap-user-search/ldap-user-search.html | 66 ++++---- .../settingsAuthentication.html | 2 +- .../BoxSelector/BoxOption.module.css | 4 - .../components/BoxSelector/BoxOption.tsx | 1 + .../components/BoxSelector/BoxSelector.tsx | 58 ++++--- .../AuthenticationMethodSelector.tsx | 16 +- 18 files changed, 319 insertions(+), 297 deletions(-) diff --git a/app/portainer/components/BoxSelector/BoxSelectorAngular.ts b/app/portainer/components/BoxSelector/BoxSelectorAngular.ts index 03d310285..71279d61a 100644 --- a/app/portainer/components/BoxSelector/BoxSelectorAngular.ts +++ b/app/portainer/components/BoxSelector/BoxSelectorAngular.ts @@ -36,6 +36,7 @@ export const BoxSelectorAngular: IComponentOptions = { options="$ctrl.options" radio-name="$ctrl.radioName" slim="$ctrl.slim" + label="$ctrl.label" >`, bindings: { value: '<', @@ -43,6 +44,7 @@ export const BoxSelectorAngular: IComponentOptions = { options: '<', radioName: '<', slim: '<', + label: '<', }, require: { formCtrl: '^form', diff --git a/app/portainer/components/BoxSelector/index.ts b/app/portainer/components/BoxSelector/index.ts index f7bd1d768..764f177f9 100644 --- a/app/portainer/components/BoxSelector/index.ts +++ b/app/portainer/components/BoxSelector/index.ts @@ -18,6 +18,7 @@ const BoxSelectorReact = react2angular(BoxSelector, [ 'error', 'useGridLayout', 'className', + 'label', ]); export const boxSelectorModule = angular diff --git a/app/portainer/oauth/components/oauth-providers-selector/oauth-providers-selector.html b/app/portainer/oauth/components/oauth-providers-selector/oauth-providers-selector.html index 158a10259..af7c82384 100644 --- a/app/portainer/oauth/components/oauth-providers-selector/oauth-providers-selector.html +++ b/app/portainer/oauth/components/oauth-providers-selector/oauth-providers-selector.html @@ -1,3 +1 @@ -
Provider
- - + diff --git a/app/portainer/oauth/components/oauth-settings/oauth-settings.html b/app/portainer/oauth/components/oauth-settings/oauth-settings.html index eac87a4b7..c97bea427 100644 --- a/app/portainer/oauth/components/oauth-settings/oauth-settings.html +++ b/app/portainer/oauth/components/oauth-settings/oauth-settings.html @@ -100,7 +100,7 @@
-