feat(app/sources): source create view (#2680)

Co-authored-by: Chaim Lev-Ari <chaim.lev-ari@portainer.io>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

api/http/handler/gitops/sources/create_git.go

@@ -8,6 +8,7 @@ import (
 	portainer "github.com/portainer/portainer/api"
 	"github.com/portainer/portainer/api/dataservices"
 	gittypes "github.com/portainer/portainer/api/git/types"
+	"github.com/portainer/portainer/api/gitops/workflows"
 	httperror "github.com/portainer/portainer/pkg/libhttp/error"
 	"github.com/portainer/portainer/pkg/libhttp/request"
 	"github.com/portainer/portainer/pkg/libhttp/response"
@@ -15,10 +16,8 @@ import (
 
 // GitAuthenticationPayload holds authentication parameters for a git source
 type GitAuthenticationPayload struct {
-	Username          string                         `json:"username"`
-	Password          string                         `json:"password"`
-	Provider          gittypes.GitProvider           `json:"provider"`
-	AuthorizationType gittypes.GitCredentialAuthType `json:"authorizationType"`
+	Username string `json:"username"`
+	Password string `json:"password"`
 }
 
 // GitSourceCreatePayload holds the parameters for creating a git-backed source
@@ -38,38 +37,10 @@ func (payload *GitSourceCreatePayload) Validate(_ *http.Request) error {
 	return nil
 }
 
-// BuildGitSource constructs a portainer.Source from a GitSourceCreatePayload
-func BuildGitSource(payload GitSourceCreatePayload) *portainer.Source {
-	gitConfig := &gittypes.RepoConfig{
-		URL:           payload.URL,
-		TLSSkipVerify: payload.TLSSkipVerify,
-	}
-
-	if payload.Authentication != nil {
-		gitConfig.Authentication = &gittypes.GitAuthentication{
-			Username:          payload.Authentication.Username,
-			Password:          payload.Authentication.Password,
-			Provider:          payload.Authentication.Provider,
-			AuthorizationType: payload.Authentication.AuthorizationType,
-		}
-	}
-
-	name := payload.Name
-	if strings.TrimSpace(name) == "" {
-		name = gittypes.RepoName(payload.URL)
-	}
-
-	return &portainer.Source{
-		Name: name,
-		Type: portainer.SourceTypeGit,
-		Git:  gitConfig,
-	}
-}
-
 // @id GitOpsSourcesCreateGit
 // @summary Create a Git source
 // @description Creates a new GitOps source backed by a Git repository.
-// @description **Access policy**: admin
+// @description **Access policy**: administrator
 // @tags gitops
 // @security ApiKeyAuth
 // @security jwt
@@ -79,6 +50,7 @@ func BuildGitSource(payload GitSourceCreatePayload) *portainer.Source {
 // @success 201 {object} portainer.Source
 // @failure 400 "Invalid request payload"
 // @failure 403 "Access denied"
+// @failure 409 "A source with this URL and credentials already exists"
 // @failure 500 "Server error"
 // @router /gitops/sources/git [post]
 func (h *Handler) gitSourceCreate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
@@ -88,11 +60,28 @@ func (h *Handler) gitSourceCreate(w http.ResponseWriter, r *http.Request) *httpe
 		return httperror.BadRequest("Invalid request payload", err)
 	}
 
-	src := BuildGitSource(payload)
+	src, err := BuildGitSource(payload)
+	if err != nil {
+		return httperror.BadRequest("Invalid request payload", err)
+	}
+
+	username, password := "", ""
+	if payload.Authentication != nil {
+		username = payload.Authentication.Username
+		password = payload.Authentication.Password
+	}
 
 	if err := h.dataStore.UpdateTx(func(tx dataservices.DataStoreTx) error {
+		if isUnique, err := workflows.ValidateUniqueSource(tx, payload.URL, username, password, 0); err != nil {
+			return err
+		} else if !isUnique {
+			return ErrDuplicateSource
+		}
+
 		return tx.Source().Create(src)
-	}); err != nil {
+	}); errors.Is(err, ErrDuplicateSource) {
+		return httperror.Conflict("A source with this URL and credentials already exists", err)
+	} else if err != nil {
 		return httperror.InternalServerError("Unable to create source", err)
 	}
 
@@ -100,3 +89,42 @@ func (h *Handler) gitSourceCreate(w http.ResponseWriter, r *http.Request) *httpe
 
 	return response.JSONWithStatus(w, src, http.StatusCreated)
 }
+
+// BuildGitSource constructs a portainer.Source from a GitSourceCreatePayload
+func BuildGitSource(payload GitSourceCreatePayload) (*portainer.Source, error) {
+	src := BuildBaseGitSource(payload)
+	src.Git.Authentication = BuildAuth(payload.Authentication)
+
+	return src, nil
+}
+
+// BuildBaseGitSource constructs the source skeleton (name, URL, TLS) without
+// authentication.
+func BuildBaseGitSource(payload GitSourceCreatePayload) *portainer.Source {
+	name := payload.Name
+	if strings.TrimSpace(name) == "" {
+		name = gittypes.RepoName(payload.URL)
+	}
+
+	return &portainer.Source{
+		Name: name,
+		Type: portainer.SourceTypeGit,
+		Git: &gittypes.RepoConfig{
+			URL:           payload.URL,
+			TLSSkipVerify: payload.TLSSkipVerify,
+		},
+	}
+}
+
+// BuildAuth constructs basic git authentication from the payload, returning nil
+// when no authentication is provided.
+func BuildAuth(payload *GitAuthenticationPayload) *gittypes.GitAuthentication {
+	if payload == nil {
+		return nil
+	}
+
+	return &gittypes.GitAuthentication{
+		Username: payload.Username,
+		Password: payload.Password,
+	}
+}