claude code agent 227
24b903aaf3
The git-sync converter + engine source lived only on the #119 branch; develop had just the dead compiled build/. Bring the whole package (src + ~700 tests) onto develop under CI, with NO consumer wired — git-sync stays fully inert in develop (nothing in apps/server imports it), so runtime behavior is unchanged. This unblocks #293 (extract the shared converter package from the landed source) and lets #119's functionality land LAST, already writing the canonical format (per the #326 landing order). - packages/git-sync: src (lib converter + engine) + test corpus + configs. - Remove develop's dead committed packages/git-sync/build/; gitignore it (built in CI/Docker via pnpm build, never committed — no src/build drift). - pnpm-lock.yaml: add the @docmost/git-sync importer (a missing workspace package in the lock is a CI blocker). `pnpm install --frozen-lockfile` passes. - NO server integration / loader / Dockerfile runtime changes (those come with #119 at step 6). Verified: tsc clean; vitest 711 passed | 1 expected-fail, 0 failures, 0 type errors; pnpm --frozen-lockfile EXIT 0; apps/server has no git-sync import. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
58 lines
2.5 KiB
TypeScript
58 lines
2.5 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { getSchema } from "@tiptap/core";
|
|
|
|
import { markdownToProseMirror } from "../src/lib/markdown-to-prosemirror";
|
|
import { docmostExtensions } from "../src/lib/docmost-schema";
|
|
|
|
// REGRESSION LOCK for the stripEmptyParagraphs schema-validity guard.
|
|
//
|
|
// markdownToProseMirror removes empty `paragraph` nodes that the import leaves
|
|
// behind when a block atom (e.g. a block image) is hoisted out of marked's
|
|
// wrapping <p> — they cause phantom blank-gap diffs on every sync. But several
|
|
// schema nodes REQUIRE non-empty block content (`content: "block+"`): tableCell,
|
|
// tableHeader, blockquote, column, callout, and the doc root. For an empty one of
|
|
// those, generateJSON materializes a single empty paragraph as its OBLIGATORY
|
|
// content. Stripping that would produce a schema-INVALID doc (`content: []`),
|
|
// which crashes any consumer that validates the public markdownToProseMirror
|
|
// output via ProseMirror's Node.check() / nodeFromJSON. The guard keeps one empty
|
|
// paragraph when removal would empty such a container; these tests pin that.
|
|
|
|
const schema = getSchema(docmostExtensions as any);
|
|
|
|
/** Throws if the JSON doc is not valid against the Docmost schema. */
|
|
function assertSchemaValid(doc: unknown): void {
|
|
schema.nodeFromJSON(doc).check();
|
|
}
|
|
|
|
describe("stripEmptyParagraphs keeps the import schema-valid", () => {
|
|
it("an empty GFM table cell round-trips to a schema-valid doc", async () => {
|
|
const doc = await markdownToProseMirror(
|
|
"| a | |\n|---|---|\n| x | y |\n",
|
|
);
|
|
expect(() => assertSchemaValid(doc)).not.toThrow();
|
|
});
|
|
|
|
it("an empty blockquote stays schema-valid", async () => {
|
|
const doc = await markdownToProseMirror("> \n");
|
|
expect(() => assertSchemaValid(doc)).not.toThrow();
|
|
});
|
|
|
|
it("an empty document stays schema-valid", async () => {
|
|
const doc = await markdownToProseMirror("\n\n");
|
|
expect(() => assertSchemaValid(doc)).not.toThrow();
|
|
});
|
|
|
|
it("still removes the empty hoist-artifact paragraph beside a block image", async () => {
|
|
const doc = await markdownToProseMirror("p\n\n\n\nq\n");
|
|
const emptyParas = ((doc as { content?: any[] }).content ?? []).filter(
|
|
(n: any) =>
|
|
n.type === "paragraph" &&
|
|
(!Array.isArray(n.content) || n.content.length === 0),
|
|
);
|
|
// The artifact paragraph must be gone (no phantom blank-gap on re-export)...
|
|
expect(emptyParas).toHaveLength(0);
|
|
// ...and the result is still a valid doc.
|
|
expect(() => assertSchemaValid(doc)).not.toThrow();
|
|
});
|
|
});
|