agent_coder
e9e4c1028d
The editor lagged while typing (worse with doc size, and under collaboration the same cost is paid for every REMOTE keystroke). ProseMirror itself was fine — the overhead was the surrounding work done on every transaction. Behavior is 1:1; only WHEN work runs changed. - getJSON() off the keystroke path: `onUpdate` no longer serializes the whole doc synchronously — the serialization now runs inside a 3s debounce (new hook use-page-content-cache.ts), flushed on unmount so the last snapshot isn't lost. - footnote numbering: merged 3 per-docChanged O(n) doc walks into one, and short-circuit the whole-doc renumber when the doc has no footnotes and the transaction didn't insert one (step-slice scan — covers typing/paste/collab). - toolbar: replaced per-keystroke `editor.can().undo()/.redo()` dry-runs with cheap history-depth reads (Yjs undoManager stack length / pm-history depth). - render side-effect bug: `remote.attach()` moved out of the render body into a useEffect. - debounced the TOC all-headings rescan and memoized the slash-command suggestion build (was rebuilt twice per keystroke). - node menus (image/video/audio/pdf/callout/subpages): the per-transaction selectors early-return a cheap isActive check instead of running getAttributes + multiple alignment probes while their node type is inactive (shouldShow still controls display — appears exactly when it did). - code blocks: the global selectionUpdate listener is now added only for mermaid blocks (the only consumer of the selected state), eliminating N listeners + N setStates per caret move for normal code blocks. Deferred (documented, collab hot-path risk): full conditional menu MOUNTING (menu-less-frame risk on same-tx context switch) and code-block re-tokenization debounce / language-persist (self-dispatching meta tx + node-attr writes interact with collab/undo). The route split from #342 already keeps lowlight off startup. Gate: editor-ext build + 252/252 tests, client editor tests pass, tsc --noEmit 0, client build ok. New tests: footnote no-footnote-doc → 0 traversals + numbering unchanged; page-content-cache onUpdate-no-sync-getJSON + flush-on-unmount. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
101 lines
3.3 KiB
TypeScript
101 lines
3.3 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
|
|
import { renderHook, act } from "@testing-library/react";
|
|
import type { MutableRefObject } from "react";
|
|
import type { Editor } from "@tiptap/react";
|
|
|
|
// Mock the app entry so importing the hook doesn't boot the whole app; the hook
|
|
// only needs queryClient's cache read/write, which we stub here. Declared via
|
|
// vi.hoisted so the spies exist before the hoisted vi.mock factory runs.
|
|
const { getQueryData, setQueryData } = vi.hoisted(() => ({
|
|
getQueryData: vi.fn(() => undefined as unknown),
|
|
setQueryData: vi.fn(),
|
|
}));
|
|
vi.mock("@/main.tsx", () => ({
|
|
queryClient: { getQueryData, setQueryData },
|
|
}));
|
|
|
|
import { usePageContentCache } from "./use-page-content-cache";
|
|
|
|
const SNAPSHOT = { type: "doc", content: [] };
|
|
|
|
function makeFakeEditor(overrides: Partial<Editor> = {}): Editor {
|
|
return {
|
|
isEmpty: false,
|
|
isDestroyed: false,
|
|
getJSON: vi.fn(() => SNAPSHOT),
|
|
...overrides,
|
|
} as unknown as Editor;
|
|
}
|
|
|
|
describe("usePageContentCache (#343 PART 3) — getJSON off the keystroke path", () => {
|
|
beforeEach(() => {
|
|
vi.useFakeTimers();
|
|
vi.clearAllMocks();
|
|
// A cached page exists so the write path runs.
|
|
getQueryData.mockReturnValue({ id: "p1", content: {} });
|
|
});
|
|
afterEach(() => {
|
|
vi.useRealTimers();
|
|
});
|
|
|
|
it("onUpdate (calling the debounced fn) does NOT call getJSON synchronously", () => {
|
|
const editor = makeFakeEditor();
|
|
const editorRef = { current: editor } as MutableRefObject<Editor | null>;
|
|
|
|
const { result } = renderHook(() =>
|
|
usePageContentCache(editorRef, "slug-1", 3000),
|
|
);
|
|
|
|
// Simulate a keystroke's onUpdate -> only schedules the debounce.
|
|
act(() => {
|
|
result.current();
|
|
result.current();
|
|
result.current();
|
|
});
|
|
|
|
// The whole-doc serialization must NOT have happened yet.
|
|
expect(editor.getJSON).not.toHaveBeenCalled();
|
|
expect(setQueryData).not.toHaveBeenCalled();
|
|
|
|
// Once the debounce window elapses, getJSON runs exactly once (not per call).
|
|
act(() => vi.advanceTimersByTime(3000));
|
|
expect(editor.getJSON).toHaveBeenCalledTimes(1);
|
|
expect(setQueryData).toHaveBeenCalledWith(["pages", "slug-1"], {
|
|
id: "p1",
|
|
content: SNAPSHOT,
|
|
});
|
|
});
|
|
|
|
it("flushes the pending snapshot on unmount so the last edit isn't lost", () => {
|
|
const editor = makeFakeEditor();
|
|
const editorRef = { current: editor } as MutableRefObject<Editor | null>;
|
|
|
|
const { result, unmount } = renderHook(() =>
|
|
usePageContentCache(editorRef, "slug-1", 3000),
|
|
);
|
|
|
|
act(() => result.current());
|
|
expect(editor.getJSON).not.toHaveBeenCalled();
|
|
|
|
// Navigation/unmount must flush (not drop) the pending write.
|
|
act(() => unmount());
|
|
expect(editor.getJSON).toHaveBeenCalledTimes(1);
|
|
expect(setQueryData).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("skips the write when the editor is destroyed (flush racing teardown)", () => {
|
|
const editor = makeFakeEditor({ isDestroyed: true });
|
|
const editorRef = { current: editor } as MutableRefObject<Editor | null>;
|
|
|
|
const { result } = renderHook(() =>
|
|
usePageContentCache(editorRef, "slug-1", 3000),
|
|
);
|
|
|
|
act(() => result.current());
|
|
act(() => vi.advanceTimersByTime(3000));
|
|
|
|
expect(editor.getJSON).not.toHaveBeenCalled();
|
|
expect(setQueryData).not.toHaveBeenCalled();
|
|
});
|
|
});
|