90d3fab483
Add ~330 tests across server (Jest), client (Vitest), editor-ext (Vitest)
and packages/mcp (node:test) for the gitmost features added since
053a9c0d: AI chat, AI agent roles, public-share assistant, MCP per-user
auth, HTML embed, page templates/embed, realtime tree, tree
expand/collapse, and the AI-settings UI.
Test-tooling fixes (prerequisite, were silently hiding coverage):
- Repair 3 page-template specs broken by the 11-arg TransclusionService
constructor; they never compiled, so template access-control / content
-leak / unsync-strip coverage was fictitious.
- Build @docmost/editor-ext before server tests via a `pretest` hook;
the stale dist omitted the new HtmlEmbed/PageEmbed exports (TS2305).
- Let jest resolve the .tsx email templates: add `tsx` to
moduleFileExtensions and widen the ts-jest transform to (t|j)sx?.
Behaviour-preserving "extract pure core" refactors that the tests drive:
- server: resolveShareAssistantRequest + uiMessageTextLength
(public-share controller), decideBasicGate + mapAuthResultToResponse
(mcp), buildErrorAssistantRecord (ai-chat), jsonbObject export (roles).
- client: render-raw-html + shouldExecute/canEdit, decide-embed-state,
page-embed picker utils, tree-socket reducers, open/close branch maps,
isEndpointConfigured/resolveKeyField; buildTreeWithChildren now treats
a permission-trimmed orphan as a root instead of crashing.
Deferred (need a test DB or HTTP harness, documented in the specs):
repo-level Postgres integration tests and the public-share XFF E2E.
Pre-existing DI/lib0-ESM suite failures are untouched and out of scope.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
59 lines
2.2 KiB
TypeScript
59 lines
2.2 KiB
TypeScript
import { PAGE_EMBED_MAX_DEPTH } from "./page-embed-ancestry-context";
|
|
import type { PageTemplateLookup } from "@/features/page-embed/types/page-embed.types";
|
|
|
|
/**
|
|
* The render outcome of a single pageEmbed node, decided BEFORE rendering a
|
|
* nested editor. Kept pure (no React) so the cycle / depth / access / not-found
|
|
* branch logic is unit-testable in isolation; the node view maps each outcome
|
|
* to a placeholder or the embedded content.
|
|
*/
|
|
export type EmbedState =
|
|
| "no_source" // no sourcePageId picked yet
|
|
| "cycle" // self-embed or an ancestor already shows this page
|
|
| "too_deep" // nesting depth limit reached
|
|
| "unavailable" // no lookup context (e.g. public share)
|
|
| "loading" // context present, result not back yet
|
|
| "ok" // resolved template content to render
|
|
| "no_access" // server says the viewer can't see the page
|
|
| "not_found"; // server says the page no longer exists
|
|
|
|
export interface DecideEmbedStateInput {
|
|
sourcePageId: string | null;
|
|
/** sourcePageIds of every ancestor pageEmbed up the render tree. */
|
|
chain: string[];
|
|
/** Host page id; a top-level self-embed must be caught against it. */
|
|
hostPageId: string | null;
|
|
/** Whether a lookup context is mounted (false on public shares in MVP). */
|
|
available: boolean;
|
|
/** The lookup result, or null while still loading. */
|
|
result: PageTemplateLookup | null;
|
|
}
|
|
|
|
/**
|
|
* Decide what a pageEmbed should render. The order matters: cycle and depth
|
|
* guards run first (before any lookup is even consulted), then availability,
|
|
* then the resolved result. Mirrors the branch ladder in PageEmbedBody.
|
|
*/
|
|
export function decideEmbedState({
|
|
sourcePageId,
|
|
chain,
|
|
hostPageId,
|
|
available,
|
|
result,
|
|
}: DecideEmbedStateInput): EmbedState {
|
|
if (!sourcePageId) return "no_source";
|
|
|
|
// Self-embed or a source already present in the ancestor chain → cycle.
|
|
const isCycle = chain.includes(sourcePageId) || hostPageId === sourcePageId;
|
|
if (isCycle) return "cycle";
|
|
|
|
if (chain.length >= PAGE_EMBED_MAX_DEPTH) return "too_deep";
|
|
|
|
if (!available) return "unavailable";
|
|
if (!result) return "loading";
|
|
|
|
if (!("status" in result)) return "ok";
|
|
if (result.status === "no_access") return "no_access";
|
|
return "not_found";
|
|
}
|