90d3fab483
Add ~330 tests across server (Jest), client (Vitest), editor-ext (Vitest)
and packages/mcp (node:test) for the gitmost features added since
053a9c0d: AI chat, AI agent roles, public-share assistant, MCP per-user
auth, HTML embed, page templates/embed, realtime tree, tree
expand/collapse, and the AI-settings UI.
Test-tooling fixes (prerequisite, were silently hiding coverage):
- Repair 3 page-template specs broken by the 11-arg TransclusionService
constructor; they never compiled, so template access-control / content
-leak / unsync-strip coverage was fictitious.
- Build @docmost/editor-ext before server tests via a `pretest` hook;
the stale dist omitted the new HtmlEmbed/PageEmbed exports (TS2305).
- Let jest resolve the .tsx email templates: add `tsx` to
moduleFileExtensions and widen the ts-jest transform to (t|j)sx?.
Behaviour-preserving "extract pure core" refactors that the tests drive:
- server: resolveShareAssistantRequest + uiMessageTextLength
(public-share controller), decideBasicGate + mapAuthResultToResponse
(mcp), buildErrorAssistantRecord (ai-chat), jsonbObject export (roles).
- client: render-raw-html + shouldExecute/canEdit, decide-embed-state,
page-embed picker utils, tree-socket reducers, open/close branch maps,
isEndpointConfigured/resolveKeyField; buildTreeWithChildren now treats
a permission-trimmed orphan as a root instead of crashing.
Deferred (need a test DB or HTTP harness, documented in the specs):
repo-level Postgres integration tests and the public-share XFF E2E.
Pre-existing DI/lib0-ESM suite failures are untouched and out of scope.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
74 lines
2.9 KiB
TypeScript
74 lines
2.9 KiB
TypeScript
/**
|
|
* Pure DOM helpers for the HTML embed node view. Kept out of the React
|
|
* component so the script re-creation/execution mechanism and the execution/
|
|
* edit policy can be unit-tested against a bare jsdom container with no
|
|
* Tiptap/Mantine providers.
|
|
*/
|
|
|
|
/**
|
|
* Inject raw HTML (including <script> tags) into `container`, executing any
|
|
* scripts.
|
|
*
|
|
* Setting `innerHTML` does NOT run inline or external <script> tags the browser
|
|
* parses that way: the HTML spec marks scripts inserted via innerHTML as
|
|
* "already started" so they never execute. To get the tracker/analytics
|
|
* use-case working we walk the freshly-parsed scripts and replace each with a
|
|
* brand-new <script> element copying its attributes and inline code. A
|
|
* programmatically created+inserted <script> DOES execute, so this restores
|
|
* normal script behaviour in the wiki origin (Variant C).
|
|
*/
|
|
export function renderRawHtml(container: HTMLElement, source: string): void {
|
|
// Clear any previous render (re-render on source change).
|
|
container.innerHTML = "";
|
|
if (!source) return;
|
|
|
|
container.innerHTML = source;
|
|
|
|
// Use the container's own document so the helper works against any document
|
|
// (the live page or a standalone jsdom instance in tests), not just the
|
|
// ambient global `document`.
|
|
const doc = container.ownerDocument;
|
|
const scripts = Array.from(container.querySelectorAll("script"));
|
|
for (const oldScript of scripts) {
|
|
const newScript = doc.createElement("script");
|
|
// Copy every attribute (src, type, async, defer, data-*, etc.).
|
|
for (const attr of Array.from(oldScript.attributes)) {
|
|
newScript.setAttribute(attr.name, attr.value);
|
|
}
|
|
// Copy inline code.
|
|
newScript.text = oldScript.textContent ?? "";
|
|
// Replacing the node in place triggers execution.
|
|
oldScript.parentNode?.replaceChild(newScript, oldScript);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Execution policy split by editor mode:
|
|
* - READ-ONLY / public-share view: the SERVER already decided whether to
|
|
* include the embed (it strips htmlEmbed from shared content when the
|
|
* workspace toggle is OFF). An anonymous viewer has no workspace and thus
|
|
* reads `featureEnabled` as false, so we must NOT gate execution on it here
|
|
* — we execute exactly the `source` the server chose to serve.
|
|
* - EDITABLE editor (admin authoring): keep gating on the per-workspace toggle
|
|
* so an admin sees the inert placeholder when the feature is OFF.
|
|
*/
|
|
export function shouldExecute(
|
|
isEditable: boolean,
|
|
featureEnabled: boolean,
|
|
): boolean {
|
|
return !isEditable || featureEnabled;
|
|
}
|
|
|
|
/**
|
|
* The edit affordance is only meaningful in edit mode, is restricted to admins
|
|
* (the server strips the node for non-admins anyway), and is offered only when
|
|
* the workspace feature toggle is ON.
|
|
*/
|
|
export function canEdit(
|
|
isEditable: boolean,
|
|
isAdmin: boolean,
|
|
featureEnabled: boolean,
|
|
): boolean {
|
|
return isEditable && isAdmin && featureEnabled;
|
|
}
|