claude_code
4af21494af
Root cause (confirmed via Chrome DevTools on the live app): the reading-position
restore jittered on reload — it landed at the saved spot, jumped to the top, then
back. The jump was NOT a height collapse: the title editor auto-focuses ~300ms
after mount, and TipTap's focus scrolls the focused node into view. Since the
title sits at the top of the page, that yanked window scroll to the top.
Minimal fix (the fast restore mechanism is left unchanged):
- Focus the title with { scrollIntoView: false } so placing the caret no longer
moves the viewport.
- Skip the title auto-focus entirely when a saved reading position will be
restored (otherwise the caret lands in the now-off-screen title). Exported
hasSavedReadingPosition() as the single source of truth.
- Extracted the decision into a testable useTitleAutofocus hook (which also adds
a clearTimeout cleanup, fixing a pre-existing uncancelled/destroyed-editor
timer), and covered it + hasSavedReadingPosition with unit tests.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
51 lines
1.7 KiB
TypeScript
51 lines
1.7 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
|
|
import { renderHook, act } from "@testing-library/react";
|
|
import { useTitleAutofocus } from "./use-title-autofocus";
|
|
|
|
const KEY_PREFIX = "gitmost:scroll-position:";
|
|
|
|
function fakeEditor(overrides = {}) {
|
|
return { isInitialized: true, commands: { focus: vi.fn() }, ...overrides } as any;
|
|
}
|
|
|
|
describe("useTitleAutofocus", () => {
|
|
beforeEach(() => {
|
|
window.sessionStorage.clear();
|
|
vi.useFakeTimers();
|
|
});
|
|
afterEach(() => {
|
|
vi.useRealTimers();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it("skips auto-focus when a saved reading position exists", () => {
|
|
window.sessionStorage.setItem(`${KEY_PREFIX}saved`, "500");
|
|
const editor = fakeEditor();
|
|
renderHook(() => useTitleAutofocus(editor, "saved"));
|
|
act(() => vi.advanceTimersByTime(300));
|
|
expect(editor.commands.focus).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("auto-focuses a new page (no saved position) with scrollIntoView: false", () => {
|
|
const editor = fakeEditor();
|
|
renderHook(() => useTitleAutofocus(editor, "fresh"));
|
|
act(() => vi.advanceTimersByTime(300));
|
|
expect(editor.commands.focus).toHaveBeenCalledWith("end", { scrollIntoView: false });
|
|
});
|
|
|
|
it("does not focus before initialization", () => {
|
|
const editor = fakeEditor({ isInitialized: false });
|
|
renderHook(() => useTitleAutofocus(editor, "fresh2"));
|
|
act(() => vi.advanceTimersByTime(300));
|
|
expect(editor.commands.focus).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("cancels the pending focus on unmount", () => {
|
|
const editor = fakeEditor();
|
|
const { unmount } = renderHook(() => useTitleAutofocus(editor, "fresh3"));
|
|
unmount();
|
|
act(() => vi.advanceTimersByTime(300));
|
|
expect(editor.commands.focus).not.toHaveBeenCalled();
|
|
});
|
|
});
|