a6ff7623db
The editor lagged while typing (worse with doc size, and under collaboration the same cost is paid for every REMOTE keystroke). ProseMirror itself was fine — the overhead was the surrounding work done on every transaction. Behavior is 1:1; only WHEN work runs changed. - getJSON() off the keystroke path: `onUpdate` no longer serializes the whole doc synchronously — the serialization now runs inside a 3s debounce (new hook use-page-content-cache.ts), flushed on unmount so the last snapshot isn't lost. - footnote numbering: merged 3 per-docChanged O(n) doc walks into one, and short-circuit the whole-doc renumber when the doc has no footnotes and the transaction didn't insert one (step-slice scan — covers typing/paste/collab). - toolbar: replaced per-keystroke `editor.can().undo()/.redo()` dry-runs with cheap history-depth reads (Yjs undoManager stack length / pm-history depth). - render side-effect bug: `remote.attach()` moved out of the render body into a useEffect. - debounced the TOC all-headings rescan and memoized the slash-command suggestion build (was rebuilt twice per keystroke). - node menus (image/video/audio/pdf/callout/subpages): the per-transaction selectors early-return a cheap isActive check instead of running getAttributes + multiple alignment probes while their node type is inactive (shouldShow still controls display — appears exactly when it did). - code blocks: the global selectionUpdate listener is now added only for mermaid blocks (the only consumer of the selected state), eliminating N listeners + N setStates per caret move for normal code blocks. Deferred (documented, collab hot-path risk): full conditional menu MOUNTING (menu-less-frame risk on same-tx context switch) and code-block re-tokenization debounce / language-persist (self-dispatching meta tx + node-attr writes interact with collab/undo). The route split from #342 already keeps lowlight off startup. Gate: editor-ext build + 252/252 tests, client editor tests pass, tsc --noEmit 0, client build ok. New tests: footnote no-footnote-doc → 0 traversals + numbering unchanged; page-content-cache onUpdate-no-sync-getJSON + flush-on-unmount. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
153 lines
4.3 KiB
TypeScript
153 lines
4.3 KiB
TypeScript
import { BubbleMenu as BaseBubbleMenu } from "@tiptap/react/menus";
|
|
import { findParentNode, posToDOMRect, useEditorState } from "@tiptap/react";
|
|
import { useCallback } from "react";
|
|
import { Node as PMNode } from "@tiptap/pm/model";
|
|
import { isEditorReady } from "@docmost/editor-ext";
|
|
import {
|
|
EditorMenuProps,
|
|
ShouldShowProps,
|
|
} from "@/features/editor/components/table/types/types.ts";
|
|
import { ActionIcon, Tooltip } from "@mantine/core";
|
|
import {
|
|
IconPaperclip,
|
|
IconTrash,
|
|
} from "@tabler/icons-react";
|
|
import { useTranslation } from "react-i18next";
|
|
import classes from "../common/toolbar-menu.module.css";
|
|
|
|
export function PdfMenu({ editor }: EditorMenuProps) {
|
|
const { t } = useTranslation();
|
|
|
|
const editorState = useEditorState({
|
|
editor,
|
|
selector: (ctx) => {
|
|
if (!ctx.editor) {
|
|
return null;
|
|
}
|
|
|
|
// #343 PART 1: skip getAttributes unless a pdf node is active. The menu
|
|
// only shows for an active pdf node (shouldShow), so the null state while
|
|
// inactive is never rendered — behavior unchanged.
|
|
if (!ctx.editor.isActive("pdf")) {
|
|
return null;
|
|
}
|
|
|
|
const pdfAttrs = ctx.editor.getAttributes("pdf");
|
|
|
|
return {
|
|
isPdf: ctx.editor.isActive("pdf"),
|
|
src: pdfAttrs?.src || null,
|
|
name: pdfAttrs?.name || null,
|
|
attachmentId: pdfAttrs?.attachmentId || null,
|
|
};
|
|
},
|
|
});
|
|
|
|
const shouldShow = useCallback(
|
|
({ state }: ShouldShowProps) => {
|
|
if (!state || !isEditorReady(editor)) return false;
|
|
if (!editor.isActive("pdf")) return false;
|
|
|
|
const { selection } = state;
|
|
const dom = editor.view.nodeDOM(selection.from) as HTMLElement | null;
|
|
if (!dom) return false;
|
|
|
|
return !!dom.querySelector("[data-pdf-error]");
|
|
},
|
|
[editor],
|
|
);
|
|
|
|
const getReferencedVirtualElement = useCallback(() => {
|
|
if (!isEditorReady(editor)) return;
|
|
const { selection } = editor.state;
|
|
const predicate = (node: PMNode) => node.type.name === "pdf";
|
|
const parent = findParentNode(predicate)(selection);
|
|
|
|
if (parent) {
|
|
const dom = editor.view.nodeDOM(parent?.pos) as HTMLElement;
|
|
const domRect = dom.getBoundingClientRect();
|
|
return {
|
|
getBoundingClientRect: () => domRect,
|
|
getClientRects: () => [domRect],
|
|
};
|
|
}
|
|
|
|
const domRect = posToDOMRect(editor.view, selection.from, selection.to);
|
|
return {
|
|
getBoundingClientRect: () => domRect,
|
|
getClientRects: () => [domRect],
|
|
};
|
|
}, [editor]);
|
|
|
|
const handleConvertToAttachment = useCallback(() => {
|
|
if (!editorState?.src) return;
|
|
|
|
const { selection } = editor.state;
|
|
const { from } = selection;
|
|
const node = editor.state.doc.nodeAt(from);
|
|
if (!node || node.type.name !== "pdf") return;
|
|
|
|
editor
|
|
.chain()
|
|
.insertContentAt(
|
|
{ from, to: from + node.nodeSize },
|
|
{
|
|
type: "attachment",
|
|
attrs: {
|
|
url: node.attrs.src,
|
|
name: node.attrs.name,
|
|
attachmentId: node.attrs.attachmentId,
|
|
size: node.attrs.size,
|
|
mime: "application/pdf",
|
|
},
|
|
},
|
|
)
|
|
.run();
|
|
}, [editor, editorState]);
|
|
|
|
const handleDelete = useCallback(() => {
|
|
editor.commands.deleteSelection();
|
|
}, [editor]);
|
|
|
|
return (
|
|
<BaseBubbleMenu
|
|
editor={editor}
|
|
pluginKey={`pdf-menu`}
|
|
updateDelay={0}
|
|
getReferencedVirtualElement={getReferencedVirtualElement}
|
|
options={{
|
|
placement: "top",
|
|
offset: 8,
|
|
flip: false,
|
|
}}
|
|
shouldShow={shouldShow}
|
|
>
|
|
<div className={classes.toolbar}>
|
|
<Tooltip position="top" label={t("Convert to attachment")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={handleConvertToAttachment}
|
|
size="lg"
|
|
aria-label={t("Convert to attachment")}
|
|
variant="subtle"
|
|
>
|
|
<IconPaperclip size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
|
|
<Tooltip position="top" label={t("Delete")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={handleDelete}
|
|
size="lg"
|
|
aria-label={t("Delete")}
|
|
variant="subtle"
|
|
>
|
|
<IconTrash size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
</div>
|
|
</BaseBubbleMenu>
|
|
);
|
|
}
|
|
|
|
export default PdfMenu;
|