7705d44fc6
Architecture & design: - Arch A: introduce resolveProvenance() as the single source of truth for deriving a write's actor/aiChatId from the SIGNED identity, and wire it into BOTH transport seams — the REST jwt.strategy and the collab authentication.extension. Previously the collab seam derived actor from the token claim alone and ignored user.isAgent, so a flagged service account's page-content edits over the websocket persisted as lastUpdatedSource='user', drifting from REST. The seams now share one resolver and can't diverge. - Arch B: drop AiAgentBadge's page-history coupling. The generic ui/ badge no longer imports historyAtoms; it exposes an onActivate callback fired after the deep-link, and the history row passes onActivate to close its own modal. Suggestions/warnings: - S1: soften the jwt.strategy provenance comment (applies to every REST write). - S2/suggestion-3: drop the redundant comment-list-item null-aiChatId test (covered by ai-agent-badge.test.tsx). - S3: de-duplicate jwt.strategy.spec test #3 (the no-claim→'user' half duplicated test #2); keep only the signed actor='agent' claim assertion. - W2: add keyboard-activation tests for the badge (Enter/Space, unrelated key). - W3: flip the design doc status to "реализовано (#143)". Tests: - new auth-provenance.decorator.spec.ts unit-tests resolveProvenance + agentSourceFields. - new collab-seam test: is_agent user with no claim → actor='agent' (Arch A regression guard). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
60 lines
2.3 KiB
TypeScript
60 lines
2.3 KiB
TypeScript
import { describe, it, expect, vi } from "vitest";
|
|
import { render, screen } from "@testing-library/react";
|
|
import { MantineProvider } from "@mantine/core";
|
|
import { IComment } from "@/features/comment/types/comment.types";
|
|
|
|
// matchMedia (read by MantineProvider) is stubbed globally in vitest.setup.ts.
|
|
|
|
// The comment mutation hooks reach out to react-query/network — stub them so the
|
|
// component renders in isolation. We only assert the AI-badge rendering branch.
|
|
vi.mock("@/features/comment/queries/comment-query", () => ({
|
|
useDeleteCommentMutation: () => ({ mutateAsync: vi.fn() }),
|
|
useResolveCommentMutation: () => ({ mutateAsync: vi.fn() }),
|
|
useUpdateCommentMutation: () => ({ mutateAsync: vi.fn() }),
|
|
}));
|
|
|
|
// CommentEditor pulls in the full TipTap editor stack; replace it with a stub.
|
|
vi.mock("@/features/comment/components/comment-editor", () => ({
|
|
default: () => <div data-testid="comment-editor" />,
|
|
}));
|
|
|
|
import CommentListItem from "./comment-list-item";
|
|
|
|
const baseComment = (over?: Partial<IComment>): IComment =>
|
|
({
|
|
id: "c-1",
|
|
content: JSON.stringify({ type: "doc", content: [] }),
|
|
creatorId: "user-1",
|
|
pageId: "page-1",
|
|
workspaceId: "ws-1",
|
|
createdAt: new Date(),
|
|
creator: { id: "user-1", name: "Service Bot", avatarUrl: null } as any,
|
|
...over,
|
|
}) as IComment;
|
|
|
|
function renderItem(comment: IComment) {
|
|
return render(
|
|
<MantineProvider>
|
|
<CommentListItem comment={comment} pageId="page-1" canComment={true} />
|
|
</MantineProvider>,
|
|
);
|
|
}
|
|
|
|
describe("CommentListItem — AI badge", () => {
|
|
it('renders the AI-agent badge when createdSource === "agent"', () => {
|
|
renderItem(baseComment({ createdSource: "agent", aiChatId: null }));
|
|
expect(screen.getByText("AI-agent")).toBeDefined();
|
|
expect(screen.getByText("Service Bot")).toBeDefined();
|
|
});
|
|
|
|
it('does NOT render the badge for a normal user comment (createdSource "user")', () => {
|
|
renderItem(baseComment({ createdSource: "user" }));
|
|
expect(screen.queryByText("AI-agent")).toBeNull();
|
|
expect(screen.getByText("Service Bot")).toBeDefined();
|
|
});
|
|
|
|
// The non-clickable (null aiChatId) branch is a property of AiAgentBadge itself
|
|
// and is covered in ai-agent-badge.test.tsx; this integration suite only needs
|
|
// the insertion gate (agent → badge, user → no badge) above (#143 review).
|
|
});
|