The html-embed feature toggle was enforced CLIENT-side in the NodeView (reads settings.htmlEmbed from the logged-in workspace), so an anonymous public-share viewer — who has no workspace context — always saw it as OFF and got a placeholder instead of the executing embed. That broke the whole point (a tracker must run for anonymous visitors). Make it server-authoritative: - share.service prepareContentForShare (the single path both share-content flows use) strips htmlEmbed from served content when the workspace toggle is OFF; both callers (updatePublicAttachments host page + lookupTransclusionForShare) resolve the toggle once and pass it. Fail-closed: missing workspace -> OFF -> stripped. - NodeView executes whatever it was served in read-only/share mode (shouldExecute = !editor.isEditable || htmlEmbedEnabled); the disabled placeholder now only shows in the editable editor when OFF. Net: anonymous share + toggle ON -> server serves the (admin-authored) embed -> it executes for everyone; toggle OFF -> stripped server-side from every share-content path (true kill switch); a non-admin embed can never be served (save-path strip). No XSS regression in the editable editor. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
186 lines
7.0 KiB
TypeScript
186 lines
7.0 KiB
TypeScript
import { NodeViewProps, NodeViewWrapper } from "@tiptap/react";
|
|
import React, { useCallback, useEffect, useRef, useState } from "react";
|
|
import clsx from "clsx";
|
|
import {
|
|
ActionIcon,
|
|
Button,
|
|
Group,
|
|
Modal,
|
|
Text,
|
|
Textarea,
|
|
} from "@mantine/core";
|
|
import { IconCode, IconEdit } from "@tabler/icons-react";
|
|
import { useTranslation } from "react-i18next";
|
|
import { useAtomValue } from "jotai";
|
|
import useUserRole from "@/hooks/use-user-role.tsx";
|
|
import { workspaceAtom } from "@/features/user/atoms/current-user-atom.ts";
|
|
import classes from "./html-embed-view.module.css";
|
|
|
|
/**
|
|
* Inject raw HTML (including <script> tags) into `container`, executing any
|
|
* scripts.
|
|
*
|
|
* Setting `innerHTML` does NOT run inline or external <script> tags the browser
|
|
* parses that way: the HTML spec marks scripts inserted via innerHTML as
|
|
* "already started" so they never execute. To get the tracker/analytics
|
|
* use-case working we walk the freshly-parsed scripts and replace each with a
|
|
* brand-new <script> element copying its attributes and inline code. A
|
|
* programmatically created+inserted <script> DOES execute, so this restores
|
|
* normal script behaviour in the wiki origin (Variant C).
|
|
*/
|
|
function renderRawHtml(container: HTMLElement, source: string) {
|
|
// Clear any previous render (re-render on source change).
|
|
container.innerHTML = "";
|
|
if (!source) return;
|
|
|
|
container.innerHTML = source;
|
|
|
|
const scripts = Array.from(container.querySelectorAll("script"));
|
|
for (const oldScript of scripts) {
|
|
const newScript = document.createElement("script");
|
|
// Copy every attribute (src, type, async, defer, data-*, etc.).
|
|
for (const attr of Array.from(oldScript.attributes)) {
|
|
newScript.setAttribute(attr.name, attr.value);
|
|
}
|
|
// Copy inline code.
|
|
newScript.text = oldScript.textContent ?? "";
|
|
// Replacing the node in place triggers execution.
|
|
oldScript.parentNode?.replaceChild(newScript, oldScript);
|
|
}
|
|
}
|
|
|
|
export default function HtmlEmbedView(props: NodeViewProps) {
|
|
const { t } = useTranslation();
|
|
const { node, selected, updateAttributes, editor } = props;
|
|
const { source } = node.attrs as { source: string };
|
|
const { isAdmin } = useUserRole();
|
|
|
|
// Defense in depth: only execute the raw HTML/JS when the workspace HTML embed
|
|
// feature toggle is ON. When OFF (the default), we render a neutral disabled
|
|
// placeholder and inject nothing — so turning the feature off neutralizes
|
|
// existing embeds at render time as well as on the next server-side save.
|
|
const workspace = useAtomValue(workspaceAtom);
|
|
const htmlEmbedEnabled = workspace?.settings?.htmlEmbed === true;
|
|
|
|
// Execution policy split by editor mode:
|
|
// - READ-ONLY / public-share view: the SERVER already decided whether to
|
|
// include the embed (it strips htmlEmbed from shared content when the
|
|
// workspace toggle is OFF). An anonymous viewer has no workspace and thus
|
|
// reads `htmlEmbedEnabled` as false, so we must NOT gate execution on it
|
|
// here — we execute exactly the `source` the server chose to serve.
|
|
// - EDITABLE editor (admin authoring): keep gating on the per-workspace
|
|
// toggle so an admin sees the inert placeholder when the feature is OFF.
|
|
const shouldExecute = !editor.isEditable || htmlEmbedEnabled;
|
|
|
|
const contentRef = useRef<HTMLDivElement | null>(null);
|
|
const [modalOpen, setModalOpen] = useState(false);
|
|
const [draft, setDraft] = useState<string>(source || "");
|
|
|
|
// (Re)render the raw source whenever it changes. This runs in BOTH the
|
|
// editable editor and the read-only / public-share editor (same NodeView),
|
|
// so trackers fire for readers too — that is the intended behaviour. When the
|
|
// feature toggle is OFF we clear the container and inject/execute nothing.
|
|
useEffect(() => {
|
|
if (!contentRef.current) return;
|
|
if (shouldExecute) {
|
|
renderRawHtml(contentRef.current, source || "");
|
|
} else {
|
|
contentRef.current.innerHTML = "";
|
|
}
|
|
}, [source, shouldExecute]);
|
|
|
|
const openEditor = useCallback(() => {
|
|
setDraft(source || "");
|
|
setModalOpen(true);
|
|
}, [source]);
|
|
|
|
const onSave = useCallback(() => {
|
|
if (editor.isEditable) {
|
|
updateAttributes({ source: draft });
|
|
}
|
|
setModalOpen(false);
|
|
}, [draft, editor.isEditable, updateAttributes]);
|
|
|
|
// The edit affordance is only meaningful in edit mode, is restricted to admins
|
|
// (the server strips the node for non-admins anyway), and is offered only when
|
|
// the workspace feature toggle is ON.
|
|
const canEdit = editor.isEditable && isAdmin && htmlEmbedEnabled;
|
|
|
|
return (
|
|
<NodeViewWrapper
|
|
data-drag-handle
|
|
className={clsx(classes.htmlEmbedNodeView, {
|
|
[classes.htmlEmbedSelected]: selected,
|
|
})}
|
|
>
|
|
{canEdit && (
|
|
<div className={classes.htmlEmbedToolbar}>
|
|
<ActionIcon
|
|
variant="default"
|
|
size="sm"
|
|
aria-label={t("Edit HTML embed")}
|
|
onClick={openEditor}
|
|
>
|
|
<IconEdit size={16} />
|
|
</ActionIcon>
|
|
</div>
|
|
)}
|
|
|
|
{!shouldExecute ? (
|
|
// Feature disabled for this workspace AND we're in the editable editor:
|
|
// never inject/execute the source. Show a neutral placeholder so an
|
|
// existing embed is visibly inert for the authoring admin. Read-only /
|
|
// share viewers never hit this branch (`shouldExecute` is always true
|
|
// there) — they execute exactly the source the server chose to serve.
|
|
<div className={classes.htmlEmbedPlaceholder}>
|
|
<IconCode size={18} />
|
|
<Text size="sm">
|
|
{t("HTML embed is disabled in this workspace")}
|
|
</Text>
|
|
</div>
|
|
) : source ? (
|
|
// Raw HTML/CSS/JS rendered into the wiki origin. Scripts are re-created
|
|
// in renderRawHtml so they execute.
|
|
<div ref={contentRef} className={classes.htmlEmbedContent} />
|
|
) : canEdit ? (
|
|
<div className={classes.htmlEmbedPlaceholder} onClick={openEditor}>
|
|
<IconCode size={18} />
|
|
<Text size="sm">{t("Click to add HTML / CSS / JS")}</Text>
|
|
</div>
|
|
) : (
|
|
// Empty source, non-editor: render nothing visible.
|
|
<div ref={contentRef} className={classes.htmlEmbedContent} />
|
|
)}
|
|
|
|
<Modal
|
|
opened={modalOpen}
|
|
onClose={() => setModalOpen(false)}
|
|
title={t("Edit HTML embed")}
|
|
size="lg"
|
|
>
|
|
<Text size="xs" c="dimmed" mb="xs">
|
|
{t(
|
|
"This HTML/CSS/JS runs in the page origin for everyone who views it. Admins only.",
|
|
)}
|
|
</Text>
|
|
<Textarea
|
|
autosize
|
|
minRows={10}
|
|
maxRows={24}
|
|
value={draft}
|
|
onChange={(e) => setDraft(e.currentTarget.value)}
|
|
placeholder={t("<script>...</script>")}
|
|
styles={{ input: { fontFamily: "monospace" } }}
|
|
data-autofocus
|
|
/>
|
|
<Group justify="flex-end" mt="md">
|
|
<Button variant="default" onClick={() => setModalOpen(false)}>
|
|
{t("Cancel")}
|
|
</Button>
|
|
<Button onClick={onSave}>{t("Save")}</Button>
|
|
</Group>
|
|
</Modal>
|
|
</NodeViewWrapper>
|
|
);
|
|
}
|