a6ff7623db
The editor lagged while typing (worse with doc size, and under collaboration the same cost is paid for every REMOTE keystroke). ProseMirror itself was fine — the overhead was the surrounding work done on every transaction. Behavior is 1:1; only WHEN work runs changed. - getJSON() off the keystroke path: `onUpdate` no longer serializes the whole doc synchronously — the serialization now runs inside a 3s debounce (new hook use-page-content-cache.ts), flushed on unmount so the last snapshot isn't lost. - footnote numbering: merged 3 per-docChanged O(n) doc walks into one, and short-circuit the whole-doc renumber when the doc has no footnotes and the transaction didn't insert one (step-slice scan — covers typing/paste/collab). - toolbar: replaced per-keystroke `editor.can().undo()/.redo()` dry-runs with cheap history-depth reads (Yjs undoManager stack length / pm-history depth). - render side-effect bug: `remote.attach()` moved out of the render body into a useEffect. - debounced the TOC all-headings rescan and memoized the slash-command suggestion build (was rebuilt twice per keystroke). - node menus (image/video/audio/pdf/callout/subpages): the per-transaction selectors early-return a cheap isActive check instead of running getAttributes + multiple alignment probes while their node type is inactive (shouldShow still controls display — appears exactly when it did). - code blocks: the global selectionUpdate listener is now added only for mermaid blocks (the only consumer of the selected state), eliminating N listeners + N setStates per caret move for normal code blocks. Deferred (documented, collab hot-path risk): full conditional menu MOUNTING (menu-less-frame risk on same-tx context switch) and code-block re-tokenization debounce / language-persist (self-dispatching meta tx + node-attr writes interact with collab/undo). The route split from #342 already keeps lowlight off startup. Gate: editor-ext build + 252/252 tests, client editor tests pass, tsc --noEmit 0, client build ok. New tests: footnote no-footnote-doc → 0 traversals + numbering unchanged; page-content-cache onUpdate-no-sync-getJSON + flush-on-unmount. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
347 lines
10 KiB
TypeScript
347 lines
10 KiB
TypeScript
import { BubbleMenu as BaseBubbleMenu } from "@tiptap/react/menus";
|
|
import { findParentNode, posToDOMRect, useEditorState } from "@tiptap/react";
|
|
import React, { useCallback, useRef } from "react";
|
|
import { Node as PMNode } from "@tiptap/pm/model";
|
|
import { isEditorReady } from "@docmost/editor-ext";
|
|
import {
|
|
EditorMenuProps,
|
|
ShouldShowProps,
|
|
} from "@/features/editor/components/table/types/types.ts";
|
|
import { ActionIcon, Tooltip } from "@mantine/core";
|
|
import clsx from "clsx";
|
|
import {
|
|
IconLayoutAlignCenter,
|
|
IconLayoutAlignLeft,
|
|
IconLayoutAlignRight,
|
|
IconFloatLeft,
|
|
IconFloatRight,
|
|
IconLayoutColumns,
|
|
IconDownload,
|
|
IconRefresh,
|
|
IconTrash,
|
|
} from "@tabler/icons-react";
|
|
import { useTranslation } from "react-i18next";
|
|
import { getFileUrl } from "@/lib/config.ts";
|
|
import { uploadImageAction } from "@/features/editor/components/image/upload-image-action.tsx";
|
|
import { useAltTextControl } from "@/features/editor/components/common/use-alt-text-control.tsx";
|
|
import { useCaptionControl } from "@/features/editor/components/common/use-caption-control.tsx";
|
|
import classes from "../common/toolbar-menu.module.css";
|
|
|
|
export function ImageMenu({ editor }: EditorMenuProps) {
|
|
const { t } = useTranslation();
|
|
const fileInputRef = useRef<HTMLInputElement>(null);
|
|
|
|
const editorState = useEditorState({
|
|
editor,
|
|
selector: (ctx) => {
|
|
if (!ctx.editor) {
|
|
return null;
|
|
}
|
|
|
|
// #343 PART 1: skip the expensive per-keystroke work (getAttributes + the
|
|
// alignment isActive() probes) unless an image is actually active. The
|
|
// menu is only shown when an image is active (see shouldShow), so a null
|
|
// state while inactive is never rendered — behavior is unchanged.
|
|
if (!ctx.editor.isActive("image")) {
|
|
return null;
|
|
}
|
|
|
|
const imageAttrs = ctx.editor.getAttributes("image");
|
|
|
|
return {
|
|
isImage: ctx.editor.isActive("image"),
|
|
isAlignLeft: ctx.editor.isActive("image", { align: "left" }),
|
|
isAlignCenter: ctx.editor.isActive("image", { align: "center" }),
|
|
isAlignRight: ctx.editor.isActive("image", { align: "right" }),
|
|
isFloatLeft: ctx.editor.isActive("image", { align: "floatLeft" }),
|
|
isFloatRight: ctx.editor.isActive("image", { align: "floatRight" }),
|
|
isInline: ctx.editor.isActive("image", { align: "inline" }),
|
|
src: imageAttrs?.src || null,
|
|
alt: imageAttrs?.alt || "",
|
|
caption: imageAttrs?.caption || "",
|
|
};
|
|
},
|
|
});
|
|
|
|
const shouldShow = useCallback(
|
|
({ state }: ShouldShowProps) => {
|
|
if (!state) {
|
|
return false;
|
|
}
|
|
|
|
return editor.isActive("image") && editor.getAttributes("image").src;
|
|
},
|
|
[editor],
|
|
);
|
|
|
|
const getReferencedVirtualElement = useCallback(() => {
|
|
if (!isEditorReady(editor)) return;
|
|
const { selection } = editor.state;
|
|
const predicate = (node: PMNode) => node.type.name === "image";
|
|
const parent = findParentNode(predicate)(selection);
|
|
|
|
if (parent) {
|
|
const dom = editor.view.nodeDOM(parent?.pos) as HTMLElement;
|
|
const domRect = dom.getBoundingClientRect();
|
|
return {
|
|
getBoundingClientRect: () => domRect,
|
|
getClientRects: () => [domRect],
|
|
};
|
|
}
|
|
|
|
const domRect = posToDOMRect(editor.view, selection.from, selection.to);
|
|
return {
|
|
getBoundingClientRect: () => domRect,
|
|
getClientRects: () => [domRect],
|
|
};
|
|
}, [editor]);
|
|
|
|
const alignImageLeft = useCallback(() => {
|
|
editor
|
|
.chain()
|
|
.focus(undefined, { scrollIntoView: false })
|
|
.setImageAlign("left")
|
|
.run();
|
|
}, [editor]);
|
|
|
|
const alignImageCenter = useCallback(() => {
|
|
editor
|
|
.chain()
|
|
.focus(undefined, { scrollIntoView: false })
|
|
.setImageAlign("center")
|
|
.run();
|
|
}, [editor]);
|
|
|
|
const alignImageRight = useCallback(() => {
|
|
editor
|
|
.chain()
|
|
.focus(undefined, { scrollIntoView: false })
|
|
.setImageAlign("right")
|
|
.run();
|
|
}, [editor]);
|
|
|
|
const alignImageFloatLeft = useCallback(() => {
|
|
editor
|
|
.chain()
|
|
.focus(undefined, { scrollIntoView: false })
|
|
.setImageAlign("floatLeft")
|
|
.run();
|
|
}, [editor]);
|
|
|
|
const alignImageFloatRight = useCallback(() => {
|
|
editor
|
|
.chain()
|
|
.focus(undefined, { scrollIntoView: false })
|
|
.setImageAlign("floatRight")
|
|
.run();
|
|
}, [editor]);
|
|
|
|
const alignImageInline = useCallback(() => {
|
|
editor
|
|
.chain()
|
|
.focus(undefined, { scrollIntoView: false })
|
|
.setImageAlign("inline")
|
|
.run();
|
|
}, [editor]);
|
|
|
|
const handleDownload = useCallback(() => {
|
|
if (!editorState?.src) return;
|
|
const url = getFileUrl(editorState.src);
|
|
const a = document.createElement("a");
|
|
a.href = url;
|
|
a.download = "";
|
|
a.click();
|
|
}, [editorState?.src]);
|
|
|
|
const handleReplace = useCallback(() => {
|
|
fileInputRef.current?.click();
|
|
}, []);
|
|
|
|
const handleFileChange = useCallback(
|
|
(e: React.ChangeEvent<HTMLInputElement>) => {
|
|
const file = e.target.files?.[0];
|
|
if (!file) return;
|
|
|
|
// @ts-ignore
|
|
const pageId = editor.storage?.pageId;
|
|
if (pageId) {
|
|
const pos = editor.state.selection.from;
|
|
uploadImageAction(file, editor, pos, pageId);
|
|
}
|
|
// Reset so the same file can be selected again
|
|
e.target.value = "";
|
|
},
|
|
[editor],
|
|
);
|
|
|
|
const handleDelete = useCallback(() => {
|
|
editor.commands.deleteSelection();
|
|
}, [editor]);
|
|
|
|
const {
|
|
button: altTextButton,
|
|
panel: altTextPanel,
|
|
isEditing: isEditingAlt,
|
|
} = useAltTextControl({
|
|
editor,
|
|
nodeName: "image",
|
|
currentAlt: editorState?.alt || "",
|
|
});
|
|
|
|
const {
|
|
button: captionButton,
|
|
panel: captionPanel,
|
|
isEditing: isEditingCaption,
|
|
} = useCaptionControl({
|
|
editor,
|
|
nodeName: "image",
|
|
currentCaption: editorState?.caption || "",
|
|
});
|
|
|
|
return (
|
|
<BaseBubbleMenu
|
|
editor={editor}
|
|
pluginKey={`image-menu`}
|
|
updateDelay={0}
|
|
getReferencedVirtualElement={getReferencedVirtualElement}
|
|
options={{
|
|
placement: "top",
|
|
offset: 8,
|
|
flip: false,
|
|
}}
|
|
shouldShow={shouldShow}
|
|
>
|
|
{isEditingAlt ? (
|
|
altTextPanel
|
|
) : isEditingCaption ? (
|
|
captionPanel
|
|
) : (
|
|
<div className={classes.toolbar}>
|
|
<Tooltip position="top" label={t("Align left")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={alignImageLeft}
|
|
size="lg"
|
|
aria-label={t("Align left")}
|
|
variant="subtle"
|
|
className={clsx({ [classes.active]: editorState?.isAlignLeft })}
|
|
>
|
|
<IconLayoutAlignLeft size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
|
|
<Tooltip position="top" label={t("Align center")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={alignImageCenter}
|
|
size="lg"
|
|
aria-label={t("Align center")}
|
|
variant="subtle"
|
|
className={clsx({ [classes.active]: editorState?.isAlignCenter })}
|
|
>
|
|
<IconLayoutAlignCenter size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
|
|
<Tooltip position="top" label={t("Align right")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={alignImageRight}
|
|
size="lg"
|
|
aria-label={t("Align right")}
|
|
variant="subtle"
|
|
className={clsx({ [classes.active]: editorState?.isAlignRight })}
|
|
>
|
|
<IconLayoutAlignRight size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
|
|
<Tooltip position="top" label={t("Float left (wrap text)")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={alignImageFloatLeft}
|
|
size="lg"
|
|
aria-label={t("Float left (wrap text)")}
|
|
variant="subtle"
|
|
className={clsx({ [classes.active]: editorState?.isFloatLeft })}
|
|
>
|
|
<IconFloatLeft size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
|
|
<Tooltip position="top" label={t("Float right (wrap text)")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={alignImageFloatRight}
|
|
size="lg"
|
|
aria-label={t("Float right (wrap text)")}
|
|
variant="subtle"
|
|
className={clsx({ [classes.active]: editorState?.isFloatRight })}
|
|
>
|
|
<IconFloatRight size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
|
|
<Tooltip position="top" label={t("Inline (side by side)")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={alignImageInline}
|
|
size="lg"
|
|
aria-label={t("Inline (side by side)")}
|
|
variant="subtle"
|
|
className={clsx({ [classes.active]: editorState?.isInline })}
|
|
>
|
|
<IconLayoutColumns size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
|
|
<div className={classes.divider} />
|
|
|
|
{altTextButton}
|
|
|
|
{captionButton}
|
|
|
|
<div className={classes.divider} />
|
|
|
|
<Tooltip position="top" label={t("Download")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={handleDownload}
|
|
size="lg"
|
|
aria-label={t("Download")}
|
|
variant="subtle"
|
|
>
|
|
<IconDownload size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
|
|
<Tooltip position="top" label={t("Replace image")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={handleReplace}
|
|
size="lg"
|
|
aria-label={t("Replace image")}
|
|
variant="subtle"
|
|
>
|
|
<IconRefresh size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
|
|
<Tooltip position="top" label={t("Delete")} withinPortal={false}>
|
|
<ActionIcon
|
|
onClick={handleDelete}
|
|
size="lg"
|
|
aria-label={t("Delete")}
|
|
variant="subtle"
|
|
>
|
|
<IconTrash size={18} />
|
|
</ActionIcon>
|
|
</Tooltip>
|
|
</div>
|
|
)}
|
|
|
|
<input
|
|
ref={fileInputRef}
|
|
type="file"
|
|
accept="image/*"
|
|
style={{ display: "none" }}
|
|
onChange={handleFileChange}
|
|
/>
|
|
</BaseBubbleMenu>
|
|
);
|
|
}
|
|
|
|
export default ImageMenu;
|