Adds footnotes: a superscript marker in the text linked to an editable definition in a Footnotes section at the end of the page, with auto-numbering and a read-only hover popover. Chose the reference+definitions model (3 plain nodes) over an inline atom with a sub-editor specifically for collaboration safety. editor-ext (packages/editor-ext/src/lib/footnote/): - footnoteReference (inline atom, id), footnotesList (block, last child), footnoteDefinition (paragraph+, id). renderHTML emits sup[data-footnote-ref] / section[data-footnotes] / div[data-footnote-def]; parse-rule priority makes the empty reference win over the Superscript mark (else it is dropped on the server save). - numbering: a decoration-only plugin (pure function of doc order) -> every client computes identical numbers, no document mutation, Yjs-safe. - sync plugin: single-pass, always SYNC_META-tagged and skipping remote txns (terminates, no loop), idempotent; canonicalizes to one trailing footnotesList (merging duplicates), creates missing definitions, drops orphans, and coexists with TrailingNode. Disabled in read-only. - commands setFootnote (one tx: reference + definition at the matching index + focus) / removeFootnote (cascade, one undo) / scrollTo*. slash /footnote. client: superscript NodeView + floating-ui read-only popover; bottom-list and definition NodeViews; registered in mainExtensions. server: the three nodes registered in tiptapExtensions so collab/save/export keep them. Round-trip regression spec guards the Superscript parse-priority. markdown: turndown/marked round-trip to pandoc/GFM [^id] (+ a code-fence guard so footnote-like lines inside code blocks are not extracted). MCP mirror: schema + markdown-converter + commentsToFootnotes rewritten to real footnote nodes + diff marker counting; NUL sentinels written as \u0000 escapes. v2 follow-ups (per plan): definition reordering on reference move, id-collision regeneration on paste, multiple references to one footnote. Implements docs/footnotes-plan.md (variant B). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
121 lines
3.7 KiB
JavaScript
121 lines
3.7 KiB
JavaScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import { convertProseMirrorToMarkdown } from "../../build/lib/markdown-converter.js";
|
|
import { markdownToProseMirror } from "../../build/lib/collaboration.js";
|
|
|
|
/** Recursively collect every node of `type`. */
|
|
function findAll(node, type, acc = []) {
|
|
if (!node || typeof node !== "object") return acc;
|
|
if (node.type === type) acc.push(node);
|
|
if (Array.isArray(node.content)) {
|
|
for (const c of node.content) findAll(c, type, acc);
|
|
}
|
|
return acc;
|
|
}
|
|
|
|
const footnoteDoc = {
|
|
type: "doc",
|
|
content: [
|
|
{
|
|
type: "paragraph",
|
|
content: [
|
|
{ type: "text", text: "Water" },
|
|
{ type: "footnoteReference", attrs: { id: "fn1" } },
|
|
{ type: "text", text: " and clay" },
|
|
{ type: "footnoteReference", attrs: { id: "fn2" } },
|
|
{ type: "text", text: "." },
|
|
],
|
|
},
|
|
{
|
|
type: "footnotesList",
|
|
content: [
|
|
{
|
|
type: "footnoteDefinition",
|
|
attrs: { id: "fn1" },
|
|
content: [
|
|
{ type: "paragraph", content: [{ type: "text", text: "First note." }] },
|
|
],
|
|
},
|
|
{
|
|
type: "footnoteDefinition",
|
|
attrs: { id: "fn2" },
|
|
content: [
|
|
{ type: "paragraph", content: [{ type: "text", text: "Second note." }] },
|
|
],
|
|
},
|
|
],
|
|
},
|
|
],
|
|
};
|
|
|
|
test("JSON -> Markdown emits pandoc footnote syntax", () => {
|
|
const md = convertProseMirrorToMarkdown(footnoteDoc);
|
|
assert.match(md, /\[\^fn1\]/);
|
|
assert.match(md, /\[\^fn2\]/);
|
|
assert.match(md, /\[\^fn1\]: First note\./);
|
|
assert.match(md, /\[\^fn2\]: Second note\./);
|
|
});
|
|
|
|
test("Markdown -> JSON rebuilds footnote nodes", async () => {
|
|
const md = convertProseMirrorToMarkdown(footnoteDoc);
|
|
const json = await markdownToProseMirror(md);
|
|
|
|
const refs = findAll(json, "footnoteReference");
|
|
const list = findAll(json, "footnotesList");
|
|
const defs = findAll(json, "footnoteDefinition");
|
|
|
|
assert.equal(refs.length, 2);
|
|
assert.deepEqual(
|
|
refs.map((r) => r.attrs.id),
|
|
["fn1", "fn2"],
|
|
);
|
|
assert.equal(list.length, 1);
|
|
assert.equal(defs.length, 2);
|
|
assert.deepEqual(
|
|
defs.map((d) => d.attrs.id),
|
|
["fn1", "fn2"],
|
|
);
|
|
});
|
|
|
|
test("JSON -> MD -> JSON preserves footnote ids and text", async () => {
|
|
const md = convertProseMirrorToMarkdown(footnoteDoc);
|
|
const json = await markdownToProseMirror(md);
|
|
const md2 = convertProseMirrorToMarkdown(json);
|
|
|
|
// The second markdown serialization carries the same markers + definitions.
|
|
assert.match(md2, /\[\^fn1\]/);
|
|
assert.match(md2, /\[\^fn2\]/);
|
|
assert.match(md2, /\[\^fn1\]: First note\./);
|
|
assert.match(md2, /\[\^fn2\]: Second note\./);
|
|
});
|
|
|
|
test("a [^id]: line inside a fenced code block is NOT treated as a definition", async () => {
|
|
// Markdown that DOCUMENTS footnote syntax inside a code fence. The example
|
|
// definition line must be preserved verbatim inside the code block and not
|
|
// pulled out into a real footnotesList / footnoteDefinition.
|
|
const md = [
|
|
"Intro text.",
|
|
"",
|
|
"```markdown",
|
|
"Body[^demo]",
|
|
"",
|
|
"[^demo]: example definition",
|
|
"```",
|
|
"",
|
|
"Outro.",
|
|
].join("\n");
|
|
|
|
const json = await markdownToProseMirror(md);
|
|
|
|
// No real footnote nodes were extracted from the code block.
|
|
assert.equal(findAll(json, "footnotesList").length, 0);
|
|
assert.equal(findAll(json, "footnoteDefinition").length, 0);
|
|
|
|
// The example definition line survives somewhere in the code block text.
|
|
const codeBlocks = findAll(json, "codeBlock");
|
|
assert.ok(codeBlocks.length >= 1, "code block present");
|
|
const codeText = JSON.stringify(json);
|
|
assert.match(codeText, /\[\^demo\]: example definition/);
|
|
});
|