f020739bfd
1. gitRemote is NOT yet consumed (the vendored engine has no remote-push path,
SPEC §7). Corrected the buildSettings docstring (it wrongly called gitRemote
"load-bearing") and marked the env -> validation -> getter -> buildSettings
chain as inert SCAFFOLDING for the deferred remote-push feature at all three
sites. Kept the wiring (harmless; removing only churns).
2. .env.example: document that GIT_SYNC_REMOTE_TEMPLATE substitutes the literal
"{spaceId}" per-space (with the example), so an operator doesn't point every
space at one remote.
3. Extracted the copy-pasted CJS->ESM dynamic-import bridge
(`new Function('s','return import(s)')`) into one shared
common/helpers/esm-import.ts; git-sync.loader, docmost-client.loader and
mcp.service now import it and keep their own typed loadX() wrappers.
Deferred (notes only, not implemented):
- lcs.ts + three-way-merge.ts could move into packages/git-sync, but that engine
is vendored (manual re-sync) — added a one-line note at three-way-merge.ts to
revisit once the re-sync story is settled.
- schema-core single source + BullMQ/fencing remain documented from prior rounds.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
19 lines
836 B
TypeScript
19 lines
836 B
TypeScript
/**
|
|
* Dynamic ESM import bridge for a CommonJS build.
|
|
*
|
|
* The server compiles with `module: commonjs`, and TypeScript downlevels a
|
|
* literal `import()` expression to `require()` — which cannot load an ESM-only
|
|
* package (`@docmost/mcp`, `@docmost/git-sync`). Indirecting through `new
|
|
* Function` hides the `import()` from the TS downleveler so the REAL dynamic
|
|
* `import()` survives to runtime and can load ESM from CommonJS.
|
|
*
|
|
* This is the single shared copy of that bridge. The per-package typed loaders
|
|
* (git-sync.loader.ts, docmost-client.loader.ts, mcp.service.ts) import this and
|
|
* keep their own typed `loadX()` wrappers (require.resolve + pathToFileURL +
|
|
* memoization) on top.
|
|
*/
|
|
export const esmImport = new Function(
|
|
'specifier',
|
|
'return import(specifier)',
|
|
) as (specifier: string) => Promise<unknown>;
|