1cfad1f6fb
PR #172 fixed the jsonb double-encoding for `tool_allowlist` but the same class of bug, and the same re-derived workaround, remained elsewhere. 1. model_config (agent roles): jsonbObject still used the buggy `::jsonb` bind, so `ai_agent_roles.model_config` round-tripped as a jsonb STRING SCALAR. The read-path `typeof === 'object'` check then failed and the model override was SILENTLY dropped (role fell back to the default model). Fixed to `::text::jsonb` and added `parseModelConfig` + `normalizeRow` so every read self-heals already-corrupted rows (no migration). 2. Centralized the write workaround as `jsonbBind()` in database/utils.ts — one implementation with one explanation of the quirk — replacing the per-repo `jsonbArray` (mcp) and `jsonbObject` (roles). 3. Integration coverage (the fix is a DB round-trip a unit test cannot see; the read-side parser MASKS a write regression): new ai-mcp-server-repo.int-spec asserts `jsonb_typeof(tool_allowlist)='array'` after insert + heals a seeded string-scalar row; ai-agent-roles-repo int-spec gains the same for `model_config` (`'object'` + heal). 4. Updated the stale `ai-mcp-servers.types.ts` comment (the driver returns a JSON string for legacy rows; the repo normalizes every read). 5. Fail-open logging: a corrupt tool_allowlist degrades to "no restriction" (agent gets ALL tools) — normalizeRow now warns (server id only, never contents) so the silent widening leaves a trace. 6. Simplified parseToolAllowlist (normalize the string once, then a single array-of-strings check) — identical behaviour, all 12 cases still pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
39 lines
1.4 KiB
TypeScript
39 lines
1.4 KiB
TypeScript
import { jsonbBind } from './utils';
|
|
|
|
/**
|
|
* Unit tests for jsonbBind: THE shared helper that encodes a JS array/object as
|
|
* a jsonb bind (or null when there is nothing to persist). It is the last line
|
|
* of defence before a jsonb column write, so the null-vs-bind decision is what
|
|
* matters here. We assert only null vs non-null because the non-null value is a
|
|
* kysely `sql` template fragment whose internal shape is an implementation
|
|
* detail of the SQL tag (the `::text::jsonb` double-encoding fix is verified
|
|
* end-to-end by the repo integration specs, where a real DB round-trip can
|
|
* actually observe `jsonb_typeof`).
|
|
*/
|
|
describe('jsonbBind', () => {
|
|
it('returns null for null / undefined', () => {
|
|
expect(jsonbBind(null)).toBeNull();
|
|
expect(jsonbBind(undefined)).toBeNull();
|
|
});
|
|
|
|
it('returns null for an empty array (nothing to persist)', () => {
|
|
expect(jsonbBind([])).toBeNull();
|
|
});
|
|
|
|
it('returns null for an empty object (nothing to persist)', () => {
|
|
expect(jsonbBind({})).toBeNull();
|
|
});
|
|
|
|
it('returns a (non-null) bind for a non-empty array', () => {
|
|
const out = jsonbBind(['search', 'crawl']);
|
|
expect(out).not.toBeNull();
|
|
expect(out).toBeDefined();
|
|
});
|
|
|
|
it('returns a (non-null) bind for a non-empty object', () => {
|
|
const out = jsonbBind({ driver: 'gemini', chatModel: 'gemini-2.0-flash' });
|
|
expect(out).not.toBeNull();
|
|
expect(out).toBeDefined();
|
|
});
|
|
});
|