Add ~330 tests across server (Jest), client (Vitest), editor-ext (Vitest)
and packages/mcp (node:test) for the gitmost features added since
053a9c0d: AI chat, AI agent roles, public-share assistant, MCP per-user
auth, HTML embed, page templates/embed, realtime tree, tree
expand/collapse, and the AI-settings UI.
Test-tooling fixes (prerequisite, were silently hiding coverage):
- Repair 3 page-template specs broken by the 11-arg TransclusionService
constructor; they never compiled, so template access-control / content
-leak / unsync-strip coverage was fictitious.
- Build @docmost/editor-ext before server tests via a `pretest` hook;
the stale dist omitted the new HtmlEmbed/PageEmbed exports (TS2305).
- Let jest resolve the .tsx email templates: add `tsx` to
moduleFileExtensions and widen the ts-jest transform to (t|j)sx?.
Behaviour-preserving "extract pure core" refactors that the tests drive:
- server: resolveShareAssistantRequest + uiMessageTextLength
(public-share controller), decideBasicGate + mapAuthResultToResponse
(mcp), buildErrorAssistantRecord (ai-chat), jsonbObject export (roles).
- client: render-raw-html + shouldExecute/canEdit, decide-embed-state,
page-embed picker utils, tree-socket reducers, open/close branch maps,
isEndpointConfigured/resolveKeyField; buildTreeWithChildren now treats
a permission-trimmed orphan as a root instead of crashing.
Deferred (need a test DB or HTTP harness, documented in the specs):
repo-level Postgres integration tests and the public-share XFF E2E.
Pre-existing DI/lib0-ESM suite failures are untouched and out of scope.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
28 lines
840 B
TypeScript
28 lines
840 B
TypeScript
import type { IPage } from "@/features/page/types/page.types";
|
|
import type { SearchSuggestionParams } from "@/features/search/types/search.types";
|
|
|
|
/**
|
|
* Self-embed guard at insertion time: drop the host page (and any null/blank
|
|
* entries) from the picker results so the current page can't embed itself.
|
|
*/
|
|
export function excludeHost(
|
|
pages: IPage[],
|
|
hostPageId: string | undefined,
|
|
): IPage[] {
|
|
return pages.filter((p) => p && p.id !== hostPageId);
|
|
}
|
|
|
|
/**
|
|
* Build the search-suggestions query for the template picker. Always restricts
|
|
* to template-flagged pages (`onlyTemplates`) and includes pages, mirroring the
|
|
* inline query args in PageEmbedPicker.
|
|
*/
|
|
export function buildPickerQuery(query: string): SearchSuggestionParams {
|
|
return {
|
|
query,
|
|
includePages: true,
|
|
onlyTemplates: true,
|
|
limit: 20,
|
|
};
|
|
}
|