agent_coder
0f4b03d89f
This actually lands F1+F2 (round 1 pushed only the test rename by mistake). F1: only the ORIGINAL query matches without length limits; remapped (wrong-layout) candidates must be >= 3 chars before they can match, via a shared candidateMatchesItem helper applied to both the item filter and the tie-break sort. Stops a 1-2 char ASCII query from spuriously substring-matching Cyrillic searchTerms (/cy->сн no longer hits 'сноска', /b->и no longer hits 'примечание'), while keeping real wrong-layout commands (/сщву->Code, /cyjcrf->Footnote), genuine short queries (/p, /h1) and Cyrillic terms (/сноска->Footnote) working. F2: reword the buildLayoutCandidates JSDoc (an ASCII query yields multiple candidates; dedup only collapses when nothing is remappable). Adds negative tests for /cy and /b. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
76 lines
3.0 KiB
TypeScript
76 lines
3.0 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import {
|
|
buildLayoutCandidates,
|
|
getSuggestionItems,
|
|
} from "@/features/editor/components/slash-menu/menu-items.ts";
|
|
|
|
/**
|
|
* `buildLayoutCandidates` maps a slash query across physical keyboard layouts
|
|
* (RU ЙЦУКЕН <-> US QWERTY) so the menu matches Latin item titles/terms even
|
|
* when typed with the wrong layout active, while keeping the original query so
|
|
* genuine Cyrillic search terms still match. See bug #283.
|
|
*/
|
|
describe("buildLayoutCandidates", () => {
|
|
it("remaps a RU-layout query to its US-QWERTY equivalent (сщву -> code)", () => {
|
|
expect(buildLayoutCandidates("сщву")).toContain("code");
|
|
});
|
|
|
|
it("remaps a US-layout query to its RU-ЙЦУКЕН equivalent (cyjcrf -> сноска)", () => {
|
|
expect(buildLayoutCandidates("cyjcrf")).toContain("сноска");
|
|
});
|
|
|
|
it("always includes the original query", () => {
|
|
expect(buildLayoutCandidates("сщву")).toContain("сщву");
|
|
expect(buildLayoutCandidates("cyjcrf")).toContain("cyjcrf");
|
|
expect(buildLayoutCandidates("сноска")).toContain("сноска");
|
|
});
|
|
|
|
it("leaves a query with no mappable keys as a single-element set", () => {
|
|
// Digits are on neither layout map, so both remaps are no-ops and de-dup
|
|
// back to one entry.
|
|
expect(buildLayoutCandidates("123")).toEqual(["123"]);
|
|
});
|
|
});
|
|
|
|
/** Helper: flatten grouped suggestion items to a flat list of titles. */
|
|
const titles = (groups: ReturnType<typeof getSuggestionItems>): string[] =>
|
|
Object.values(groups).flatMap((items) => items.map((i) => i.title));
|
|
|
|
describe("getSuggestionItems layout-aware matching", () => {
|
|
it("finds Code when 'code' is typed in RU layout (/сщву)", () => {
|
|
expect(titles(getSuggestionItems({ query: "сщву" }))).toContain("Code");
|
|
});
|
|
|
|
it("still finds Code for the plain /code query", () => {
|
|
expect(titles(getSuggestionItems({ query: "code" }))).toContain("Code");
|
|
});
|
|
|
|
it("still matches genuine Cyrillic search terms (/сноска -> Footnote)", () => {
|
|
expect(titles(getSuggestionItems({ query: "сноска" }))).toContain(
|
|
"Footnote",
|
|
);
|
|
});
|
|
|
|
it("finds Footnote when 'сноска' is typed in EN layout (/cyjcrf)", () => {
|
|
expect(titles(getSuggestionItems({ query: "cyjcrf" }))).toContain(
|
|
"Footnote",
|
|
);
|
|
});
|
|
|
|
it("does not surface Footnote for a short wrong-layout query (/cy)", () => {
|
|
// "cy" EN->RU remaps to "сн", a substring of the "сноска" searchTerm, but
|
|
// the gate blocks it because the remapped candidate is < 3 chars.
|
|
expect(titles(getSuggestionItems({ query: "cy" }))).not.toContain(
|
|
"Footnote",
|
|
);
|
|
});
|
|
|
|
it("does not surface Footnote for a single-char wrong-layout query (/b)", () => {
|
|
// "b" EN->RU remaps to "и", a substring of the "примечание" searchTerm, but
|
|
// the gate blocks it because the remapped candidate is < 3 chars.
|
|
expect(titles(getSuggestionItems({ query: "b" }))).not.toContain(
|
|
"Footnote",
|
|
);
|
|
});
|
|
});
|