vvzvlad/gitmost
1
0
Fork 0
Code Issues 14 Pull Requests 12 Packages Projects Releases Activity

[test][page-templates] Cover duplicatePage pageEmbed remap + template reference sync #32

New Issue
Closed
opened 2026-06-20 20:35:47 +03:00 by Ghost · 0 comments
Ghost commented 2026-06-20 20:35:47 +03:00
Copy Link

From review of #17 (merged to develop).

Untested high-risk logic:

  • apps/server/src/core/page/services/page.service.ts duplicatePage: remap of pageEmbed.sourcePageId (remap to the copy when the source is in the copied set, otherwise keep the original). A bug here silently breaks template duplication.
  • apps/server/src/core/page/transclusion/transclusion.service.ts syncPageTemplateReferences: the toDelete branch (removing stale references when the host page is edited) is not covered.
  • insertTemplateReferencesForPages multi-workspace grouping/filtering branch is not covered.

Add jest coverage mirroring the existing transclusion specs.

Severity: medium.

From review of #17 (merged to develop). Untested high-risk logic: - `apps/server/src/core/page/services/page.service.ts` `duplicatePage`: remap of `pageEmbed.sourcePageId` (remap to the copy when the source is in the copied set, otherwise keep the original). A bug here silently breaks template duplication. - `apps/server/src/core/page/transclusion/transclusion.service.ts` `syncPageTemplateReferences`: the `toDelete` branch (removing stale references when the host page is edited) is not covered. - `insertTemplateReferencesForPages` multi-workspace grouping/filtering branch is not covered. Add jest coverage mirroring the existing transclusion specs. Severity: medium.
Ghost closed this issue 2026-06-21 02:05:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 epic
Large multi-phase effort spanning many changes
 feature
New functionality request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 idea
Idea / proposal for discussion
 invalid
This doesn't seem right
 needs-human
эскалация: нужно решение человека
 question
Further information is requested
 refactor
Code cleanup / refactoring
 review/approved
в последнем ревью нет открытых blocking-находок
 review/changes-requested
последнее ревью оставило открытые blocking-находки
 review/needs
head не ревьюился (head != reviewed_head)
 security
Security / hardening issue
 status/blocked
ждёт зависимость blocked_by
 status/done
закрыто и проверено
 status/in-progress
в активной работе (мягкая заявка)
 status/ready
специфицировано, не заблокировано, ждёт исполнителя
 test
Test coverage / test infrastructure
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent_coder agent_reviewer vvzvlad
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vvzvlad/gitmost#32
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?