vvzvlad/gitmost
1
0
Fork 0
Code Issues 14 Pull Requests 12 Packages Projects Releases Activity

html-embed: conservative collab strip removes admin's embed on a non-admin co-editor's store #29

New Issue
Closed
opened 2026-06-20 20:31:53 +03:00 by Ghost · 0 comments
Ghost commented 2026-06-20 20:31:53 +03:00
Copy Link

Found in security review of PR #16 (merged in 7a03321d).

Severity: low (data-loss / availability; documented, intentional).

The collab persist strip keys to the storing connection's user. If a non-admin co-editor stores while an admin's legitimately-authored embed exists and their store does not re-add it, the embed is stripped and the admin must re-add it.

  • File: apps/server/src/collaboration/extensions/persistence.extension.ts (~L154-164).
  • Currently fail-closed and intentional, documented in-code.

Possible refinement: diff against the previously persisted admin-authored embeds so an admin's embed survives a non-admin's unrelated store.

Found in security review of PR #16 (merged in 7a03321d). **Severity: low (data-loss / availability; documented, intentional).** The collab persist strip keys to the storing connection's user. If a non-admin co-editor stores while an admin's legitimately-authored embed exists and their store does not re-add it, the embed is stripped and the admin must re-add it. - File: `apps/server/src/collaboration/extensions/persistence.extension.ts` (~L154-164). - Currently fail-closed and intentional, documented in-code. **Possible refinement:** diff against the previously persisted admin-authored embeds so an admin's embed survives a non-admin's unrelated store.
Ghost added the bug label 2026-06-21 02:27:21 +03:00
Ghost closed this issue 2026-06-21 03:02:07 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 epic
Large multi-phase effort spanning many changes
 feature
New functionality request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 idea
Idea / proposal for discussion
 invalid
This doesn't seem right
 needs-human
эскалация: нужно решение человека
 question
Further information is requested
 refactor
Code cleanup / refactoring
 review/approved
в последнем ревью нет открытых blocking-находок
 review/changes-requested
последнее ревью оставило открытые blocking-находки
 review/needs
head не ревьюился (head != reviewed_head)
 security
Security / hardening issue
 status/blocked
ждёт зависимость blocked_by
 status/done
закрыто и проверено
 status/in-progress
в активной работе (мягкая заявка)
 status/ready
специфицировано, не заблокировано, ждёт исполнителя
 test
Test coverage / test infrastructure
 wontfix
This will not be worked on
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent_coder agent_reviewer vvzvlad
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vvzvlad/gitmost#29
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?