feat(tree): Expand all / Collapse all for the space page tree #23

vvzvlad · 2026-06-20T17:40:17+03:00

vvzvlad commented

2026-06-20 17:40:17 +03:00

Space page tree gets Expand all / Collapse all (full-stack). Based on the agent227 implementation with three cleanups borrowed from the sibling impl (extracted tree-walk helpers into tree/utils, reused SidebarPageDto instead of a duplicate DTO, typed the client fetch) plus a menu close-behavior fix: Expand all now closes the menu, consistent with Collapse all.

vvzvlad added 4 commits 2026-06-20 17:40:18 +03:00

feat(tree): Expand all / Collapse all for the space page tree b81819ef63

Adds a server-authoritative whole-tree endpoint and sidebar menu commands
so a deep space tree can be expanded in one request instead of a per-level
BFS storm.

Server:
- POST /pages/tree (SidebarPageTreeDto: spaceId | pageId), same CASL space
  scoping as /sidebar-pages. Returns the whole space tree / subtree as a flat
  list in the sidebar item shape (id, slugId, title, icon, position,
  parentPageId, spaceId, hasChildren, canEdit), ordered by position
  (collate C byte order), content never fetched.
- page.service.getSidebarPagesTree reproduces getSidebarPages' two-branch
  permission model: open space -> spaceCanEdit; restricted space -> seed the
  full descendant set then prune via filterAccessibleTreePages +
  filterAccessiblePageIdsWithPermissions (keeps restricted-but-granted pages,
  prunes inaccessible subtrees). hasChildren is derived from the final
  filtered set so it can never reveal inaccessible children.
- page.repo.getSpaceDescendants: recursive CTE seeded by space roots.

Client:
- SpaceTree is forwardRef exposing expandAll/collapseAll/isExpanding;
  expandAll fetches the whole tree once, replaces current-space nodes, opens
  every branch (current space only), aborts on space switch, surfaces real
  errors; collapseAll collapses only current-space ids (shared open-map).
- SpaceMenu gains Expand all / Collapse all items (no admin gate).

Implements docs/backlog/tree-expand-collapse-all.md.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

docs: remove implemented tree-expand-collapse-all backlog plan b38b71eb51

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

refactor(tree): borrow cleanups from the sibling expand-all impl 234ae759f5

- extract collectAllIds / collectBranchIds into tree/utils and use them in
  space-tree.tsx instead of inline closures
- drop the duplicate SidebarPageTreeDto, reuse the existing SidebarPageDto
  for the /pages/tree endpoint
- type the getSpaceTree client call as api.post<{ items: IPage[] }>

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(tree): close the space menu after Expand all 949a251553

Expand all kept the menu open (closeMenuOnClick={false}) while Collapse all
closed it. Make both close on click for consistent behavior, and drop the
now-pointless in-menu isExpanding loading state.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Ghost merged commit b20ffd1b91 into develop

2026-06-20 17:40:30 +03:00

Ghost referenced this issue from a commit

2026-06-20 17:40:32 +03:00

Merge pull request 'feat(tree): Expand all / Collapse all for the space page tree' (#23) from feat/tree-expand-collapse-all-agent227 into develop

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vvzvlad/gitmost#23