test: cover resolveShareAiMaxOutputTokens output-token cap (#60) #104

New Issue

Ghost · 2026-06-21T05:05:39+03:00

Ghost commented

2026-06-21 05:05:39 +03:00

PR #101 (commit 05a7a400, closes #60) added resolveShareAiMaxOutputTokens() — apps/server/src/core/ai-chat/public-share-chat.service.ts:78, used at L230 — bounding per-request output tokens for the anonymous assistant.

Gap: untested, while its identical sibling resolveShareAiWorkspaceMax has 5 dedicated tests in public-share-chat.spec.ts.

Needed: mirror the sibling test block: valid int; float floors via Math.floor; NaN/unset → default (512); zero/negative → default. Regression risk: dropping the raw > 0 check lets env 0 disable the cap → unbounded billable output.

Found in code review of PR #101.

PR #101 (commit 05a7a400, closes #60) added `resolveShareAiMaxOutputTokens()` — apps/server/src/core/ai-chat/public-share-chat.service.ts:78, used at L230 — bounding per-request output tokens for the anonymous assistant. **Gap:** untested, while its identical sibling `resolveShareAiWorkspaceMax` has 5 dedicated tests in `public-share-chat.spec.ts`. **Needed:** mirror the sibling test block: valid int; float floors via `Math.floor`; NaN/unset → default (512); zero/negative → default. Regression risk: dropping the `raw > 0` check lets env `0` disable the cap → unbounded billable output. _Found in code review of PR #101._

Ghost added the test security labels 2026-06-21 05:05:39 +03:00

vvzvlad referenced this issue from a commit

2026-06-21 05:24:26 +03:00

fix(review): address PR #101 review findings (dead DI, docs)

Ghost referenced this issue

2026-06-21 05:51:20 +03:00

fix: review/red-team batch 2 — 30 issues (security, ws, page-templates, html-embed, mcp, tests, docs) #101

Ghost referenced this issue

2026-06-21 05:53:55 +03:00

test: review-batch-2 follow-up coverage (sandbox html-embed, #101 fixes, i18n) #110

Ghost closed this issue

2026-06-21 14:10:35 +03:00