Address PR #215 review: temporary notes hardening

Must-fix:
- CHANGELOG: add [Unreleased]/Added entry for temporary notes (#201).
- temporary-note-cleanup: re-check temporary_expires_at at deletion time so a
  concurrent "Make permanent" (sets it NULL) between the batch SELECT and the
  per-row removePage wins the race and the note is not trashed. Add unit tests
  for the make-permanent and already-trashed race windows.

Non-blocking review items:
- temporary-note-cleanup: cap the sweep batch (LIMIT 500) so a large backlog is
  not loaded into memory; remainder drains on the next hourly run.
- client: extract duplicated post-toggle cache sync into
  syncTemporaryExpiresInCache() shared by the header menu and the banner.
- Remove the tautological migration spec that mocked the whole Kysely builder.
- Tests: cover create() frozen temporaryExpiresAt (workspace override + NULL
  default fallback + non-temporary skips lookup) and restorePage disarming the
  timer (temporaryExpiresAt: null).

Deferred (forward-looking, non-blocking): extract
PageService.computeTemporaryExpiresAt() to dedupe the deadline formula and drop
the @InjectKysely from PageTemplateController; replace migration unit test with
a real Postgres up/down integration test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

apps/client/src/features/page-embed/queries/page-embed-query.ts

@@ -8,6 +8,33 @@ import type {
   ToggleTemplateResponse,
   ToggleTemporaryResponse,
 } from "@/features/page-embed/types/page-embed.types";
+import { queryClient } from "@/main.tsx";
+
+/**
+ * After toggling a note's temporary state, mirror the new deadline into the
+ * shared page cache (keyed by both slugId and id) and refresh the sidebar so the
+ * menu label, the in-page banner, and the tree icon all reflect the change.
+ * Centralised here so the header menu and the banner can't drift apart on the
+ * cache-key plumbing.
+ */
+export function syncTemporaryExpiresInCache(
+  page: { id: string; slugId: string },
+  temporaryExpiresAt: string | null,
+) {
+  for (const key of [page.slugId, page.id]) {
+    const cached = queryClient.getQueryData<any>(["pages", key]);
+    if (cached) {
+      queryClient.setQueryData(["pages", key], {
+        ...cached,
+        temporaryExpiresAt,
+      });
+    }
+  }
+  queryClient.invalidateQueries({
+    predicate: (item) =>
+      ["sidebar-pages"].includes(item.queryKey[0] as string),
+  });
+}
 
 export function useToggleTemplateMutation() {
   return useMutation<

apps/client/src/features/page/components/header/page-header-menu.tsx

@@ -25,8 +25,10 @@ import { useDisclosure, useHotkeys } from "@mantine/hooks";
 import { useClipboard } from "@/hooks/use-clipboard";
 import { useParams } from "react-router-dom";
 import { usePageQuery } from "@/features/page/queries/page-query.ts";
-import { useToggleTemporaryMutation } from "@/features/page-embed/queries/page-embed-query.ts";
-import { queryClient } from "@/main.tsx";
+import {
+  useToggleTemporaryMutation,
+  syncTemporaryExpiresInCache,
+} from "@/features/page-embed/queries/page-embed-query.ts";
 import { buildPageUrl } from "@/features/page/page.utils.ts";
 import { notifications } from "@mantine/notifications";
 import { getAppUrl } from "@/lib/config.ts";
@@ -176,19 +178,7 @@ function PageActionMenu({ readOnly }: PageActionMenuProps) {
       });
       // Reflect the new deadline in the page cache so the menu label flips and
       // any banner updates. The sidebar icon refreshes via its own query.
-      for (const key of [page.slugId, page.id]) {
-        const cached = queryClient.getQueryData<any>(["pages", key]);
-        if (cached) {
-          queryClient.setQueryData(["pages", key], {
-            ...cached,
-            temporaryExpiresAt: res.temporaryExpiresAt,
-          });
-        }
-      }
-      queryClient.invalidateQueries({
-        predicate: (item) =>
-          ["sidebar-pages"].includes(item.queryKey[0] as string),
-      });
+      syncTemporaryExpiresInCache(page, res.temporaryExpiresAt);
       notifications.show({
         message: next
           ? t("Note will move to trash unless made permanent")

apps/client/src/features/page/components/temporary-note-banner.tsx

@@ -3,8 +3,10 @@ import { IconClockHour4 } from "@tabler/icons-react";
 import { Trans, useTranslation } from "react-i18next";
 import { useTimeAgo } from "@/hooks/use-time-ago.tsx";
 import { usePageQuery } from "@/features/page/queries/page-query.ts";
-import { useToggleTemporaryMutation } from "@/features/page-embed/queries/page-embed-query.ts";
-import { queryClient } from "@/main.tsx";
+import {
+  useToggleTemporaryMutation,
+  syncTemporaryExpiresInCache,
+} from "@/features/page-embed/queries/page-embed-query.ts";
 import { useGetSpaceBySlugQuery } from "@/features/space/queries/space-query.ts";
 import { useSpaceAbility } from "@/features/space/permissions/use-space-ability.ts";
 import {
@@ -42,19 +44,7 @@ export function TemporaryNoteBanner({ slugId }: TemporaryNoteBannerProps) {
         pageId: page.id,
         temporary: false,
       });
-      for (const key of [page.slugId, page.id]) {
-        const cached = queryClient.getQueryData<any>(["pages", key]);
-        if (cached) {
-          queryClient.setQueryData(["pages", key], {
-            ...cached,
-            temporaryExpiresAt: res.temporaryExpiresAt,
-          });
-        }
-      }
-      queryClient.invalidateQueries({
-        predicate: (item) =>
-          ["sidebar-pages"].includes(item.queryKey[0] as string),
-      });
+      syncTemporaryExpiresInCache(page, res.temporaryExpiresAt);
     } catch {
       // mutation surfaces the error via notifications
     }