vvzvlad/gitmost
1
0
Fork 0
Code Issues 23 Pull Requests 5 Packages Projects Releases Activity

chore(git-sync): remove dead Settings REST fields, warn on inert REMOTE_TEMPLATE, fix stale docstrings (review)

Browse Source 
Dead code / doc-vs-code cleanup from review #4404:
- Drop the unused Settings.docmostApiUrl/Email/Password fields (the native
  in-process datasource never reads them; the engine only used docmostSpaceId).
  Removed from the type, buildSettings, and the 4 engine test suites that
  fabricated them.
- Warn ONCE at startup when GIT_SYNC_REMOTE_TEMPLATE is set — remote push is
  deferred (SPEC §7) so the value is currently inert; the operator now gets a
  log line instead of a silent no-op.
- Correct stale docstrings that claimed live-destructive code was 'FAKES only /
  NEXT increment / no live wiring' (applyPushActions runs LIVE via
  runCycle->orchestrator); that importPageMarkdown receives a 'self-contained
  file (meta+body)' (it receives the stripped body); and that the Yjs body merge
  is '2-way' (3-way runs end-to-end when the base is present).

No behavior change (except the new warning); build + git-sync smoke verified.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
claude-stand
2026-07-02 19:03:57 +03:00
parent bb5bb52244
commit 91d674fea6
9 changed files with 40 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/integrations/git-sync/services/git-sync.orchestrator.ts
+14 -7
View File
@@ -140,10 +140,9 @@ export class GitSyncOrchestrator implements OnModuleInit, OnModuleDestroy {
// --- one sync cycle for a space -------------------------------
/**
* Build the engine `Settings` for a space. The engine's REST-era fields
* (docmostApiUrl/email/password) are unused on the native path — the
* datasource writes in-process — so they are placeholders; only `vaultPath`
* and the tunables are load-bearing today.
* Build the engine `Settings` for a space. The datasource writes in-process,
* so only `vaultPath`, `docmostSpaceId` and the tunables are load-bearing; the
* dead REST-era fields (docmostApiUrl/email/password) were removed (review).
*
* `gitRemote` is NOT yet consumed: the vendored engine has no remote-push path
* (see engine/git.ts, engine/pull.ts, SPEC §7 — remote push is deferred), so
@@ -174,9 +173,6 @@ export class GitSyncOrchestrator implements OnModuleInit, OnModuleDestroy {
.where('id', '=', spaceId)
.executeTakeFirst();
return {
docmostApiUrl: 'http://native.local',
docmostEmail: 'native@local',
docmostPassword: 'native',
docmostSpaceId: spaceId,
vaultPath: this.vaultRegistry.vaultPath(spaceId),
gitRemote,
@@ -493,6 +489,17 @@ export class GitSyncOrchestrator implements OnModuleInit, OnModuleDestroy {
onModuleInit(): void {
if (!this.environmentService.isGitSyncEnabled()) return;
// GIT_SYNC_REMOTE_TEMPLATE is inert scaffolding: the vendored engine has no
// remote-push path yet (SPEC §7), so setting it does nothing today. Warn once
// at startup so an operator who configured it isn't left with a silent no-op
// (review). Remove this warning when the engine grows a remote-push path.
if (this.environmentService.getGitSyncRemoteTemplate()) {
this.logger.warn(
'git-sync: GIT_SYNC_REMOTE_TEMPLATE is set but NOT yet consumed — ' +
'remote push is deferred (SPEC §7); this value currently has no effect.',
);
}
const ms = this.environmentService.getGitSyncPollIntervalMs();
const handle = setInterval(() => {
void this.pollTick();