vvzvlad/gitmost
1
0
Fork 0
Code Issues 14 Pull Requests 12 Packages Projects Releases Activity

fix(editor,git-sync): parse details open as a boolean so open state survives render/round-trip

Browse Source 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
claude code agent 227
2026-06-26 18:01:39 +03:00
parent e48d7720e9
commit 32e99c6e42
4 changed files with 85 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/git-sync/src/lib/docmost-schema.ts
View File

@@ -470,7 +470,7 @@ const Details = Node.create({
return {
open: {
default: false,
parseHTML: (el: HTMLElement) => el.getAttribute("open"),
parseHTML: (el: HTMLElement) => el.hasAttribute("open"),
renderHTML: (attrs: Record<string, any>) =>
attrs.open ? { open: "" } : {},
},

29
packages/git-sync/test/roundtrip-all-nodes.test.ts
View File

@@ -200,11 +200,30 @@ describe('git-sync converter: lose-prone atoms keep their VALUES across a round
const back = await markdownToProseMirror(md);
const details = findNode(back, 'details');
expect(details).toBeDefined();
// The schema parses the present `open` boolean attribute to "" (its raw
// value); a DROPPED open parses to the default `false`. Asserting it is no
// longer the default proves the nested path now preserves open — parity with
// the top-level <details> case. RED before the fix (open === false).
expect(details.attrs?.open).not.toBe(false);
// `open` must round-trip as a STRICT boolean `true` — not "" (the old raw
// getAttribute value) and not the default `false` (a dropped attribute).
// Before the schema parseHTML fix (hasAttribute), `<details open>` parsed to
// "" — falsy, so it rendered as a bare <details> and collapsed. RED before
// the fix (open was "" or false, never === true).
expect(details.attrs?.open).toBe(true);
});
it('B: a TOP-LEVEL details keeps open as strict boolean true', async () => {
const original = doc({
type: 'details',
attrs: { open: true },
content: [
{ type: 'detailsSummary', content: [T('S')] },
{ type: 'detailsContent', content: [P(T('b'))] },
],
});
const md = convertProseMirrorToMarkdown(original);
const back = await markdownToProseMirror(md);
const details = findNode(back, 'details');
expect(details).toBeDefined();
// Strict boolean, proving the value survives as `true` (not ""/false).
// RED before the fix: parseHTML returned getAttribute("open") === "".
expect(details.attrs?.open).toBe(true);
});
it('D: htmlEmbed source VALUE and height survive', async () => {