feat(git-sync): per-space 'Enable Git sync' toggle (Phase C, §7.1)

UI opt-in for git-sync, mirroring the existing sharing/comments settings pattern
(no new endpoint, no new mechanism; orchestrator read query untouched):
- UpdateSpaceDto.gitSyncEnabled?: boolean.
- SpaceRepo.updateGitSyncSettings: jsonb-merge into settings.gitSync.<key>
  (COALESCE || jsonb_build_object — never clobbers sibling sharing/comments);
  stored as a real jsonb boolean so the orchestrator's
  settings->'gitSync'->>'enabled' = 'true' matches.
- SpaceService.updateSpace handles the flag (audit diff) via the existing
  CASL-guarded space update path (Manage/Settings).
- client: Switch in edit-space-form (optimistic mutate + revert-on-error,
  readOnly-aware) + space types + 2 i18n keys.
- space.service.spec extended (calls updateGitSyncSettings; no-op when undefined).
tsc clean (server+client); jest src/core/space 4 pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
claude code agent 227
2026-06-21 15:42:52 +03:00
parent efb96ae498
commit 0a364dfcac
7 changed files with 161 additions and 2 deletions
@@ -15,4 +15,8 @@ export class UpdateSpaceDto extends PartialType(CreateSpaceDto) {
@IsOptional()
@IsBoolean()
allowViewerComments: boolean;
@IsOptional()
@IsBoolean()
gitSyncEnabled?: boolean;
}
@@ -22,4 +22,75 @@ describe('SpaceService', () => {
it('should be defined', () => {
expect(service).toBeDefined();
});
describe('updateSpace gitSyncEnabled', () => {
const workspaceId = 'ws-1';
const spaceId = 'space-1';
// executeTx runs the callback immediately with a passthrough trx so the
// repo calls happen inline; mirrors how the sibling sharing/comments flags
// are persisted.
const buildService = (settingsBefore: Record<string, any>) => {
const spaceRepo = {
findById: jest.fn().mockResolvedValue({
id: spaceId,
name: 'Space',
slug: 'space',
description: '',
settings: settingsBefore,
}),
updateGitSyncSettings: jest.fn().mockResolvedValue({}),
updateSharingSettings: jest.fn().mockResolvedValue({}),
updateCommentSettings: jest.fn().mockResolvedValue({}),
updateSpace: jest
.fn()
.mockResolvedValue({ id: spaceId, name: 'Space', slug: 'space' }),
slugExists: jest.fn().mockResolvedValue(false),
};
const auditService = { log: jest.fn() };
const svc = new SpaceService(
spaceRepo as any,
{} as any, // spaceMemberService
{} as any, // shareRepo
{} as any, // workspaceRepo
{} as any, // licenseCheckService
{} as any, // db
{} as any, // attachmentQueue
auditService as any,
);
// executeTx is invoked via the imported helper; patch it on the module.
jest
.spyOn(require('@docmost/db/utils'), 'executeTx')
.mockImplementation(async (_db: any, cb: any) => cb({} as any));
return { svc, spaceRepo, auditService };
};
it('persists gitSyncEnabled via updateGitSyncSettings(enabled)', async () => {
const { svc, spaceRepo } = buildService({});
await svc.updateSpace(
{ spaceId, gitSyncEnabled: true } as any,
workspaceId,
);
expect(spaceRepo.updateGitSyncSettings).toHaveBeenCalledWith(
spaceId,
workspaceId,
'enabled',
true,
expect.anything(),
);
});
it('does not call updateGitSyncSettings when flag is undefined', async () => {
const { svc, spaceRepo } = buildService({});
await svc.updateSpace({ spaceId } as any, workspaceId);
expect(spaceRepo.updateGitSyncSettings).not.toHaveBeenCalled();
});
});
});
@@ -213,6 +213,22 @@ export class SpaceService {
);
}
if (typeof updateSpaceDto.gitSyncEnabled !== 'undefined') {
const prev = settingsBefore?.gitSync?.enabled ?? false;
if (prev !== updateSpaceDto.gitSyncEnabled) {
before.gitSyncEnabled = prev;
after.gitSyncEnabled = updateSpaceDto.gitSyncEnabled;
}
await this.spaceRepo.updateGitSyncSettings(
updateSpaceDto.spaceId,
workspaceId,
'enabled',
updateSpaceDto.gitSyncEnabled,
trx,
);
}
updatedSpace = await this.spaceRepo.updateSpace(
{
name: updateSpaceDto.name,
@@ -111,6 +111,28 @@ export class SpaceRepo {
.executeTakeFirst();
}
async updateGitSyncSettings(
spaceId: string,
workspaceId: string,
prefKey: string,
prefValue: string | boolean,
trx?: KyselyTransaction,
) {
const db = dbOrTx(this.db, trx);
return db
.updateTable('spaces')
.set({
settings: sql`COALESCE(settings, '{}'::jsonb)
|| jsonb_build_object('gitSync', COALESCE(settings->'gitSync', '{}'::jsonb)
|| jsonb_build_object('${sql.raw(prefKey)}', ${sql.lit(prefValue)}))`,
updatedAt: new Date(),
})
.where('id', '=', spaceId)
.where('workspaceId', '=', workspaceId)
.returningAll()
.executeTakeFirst();
}
async updateCommentSettings(
spaceId: string,
workspaceId: string,